ctao-bdms-clients 0.2.1__py3-none-any.whl → 0.3.0rc1__py3-none-any.whl

bdms/acada_ingestion.py

@@ -2,16 +2,28 @@
 
 This module provides the IngestionClient class to manage the ingestion of ACADA data into the BDMS system.
 It includes functionality for constructing FITS file paths, converting ACADA paths to Logical File Names (LFNs),
-and registering replicas in Rucio.
+registering replicas in Rucio, extracting metadata and adding metadata to registered replicas. Furthermore, the Ingest class asynchronously
+processes ACADA data using a process pool, managing file discovery, queuing, and distribution to worker processes for ingestion using a continuous
+polling-based approach with the watchdog library.
 """
 
 import logging
 import os
+import threading
+import time
+from concurrent.futures import Future, ProcessPoolExecutor
 from contextlib import ExitStack
+from enum import Enum
+from functools import partial
+from multiprocessing import cpu_count
 from pathlib import Path
+from queue import Empty, Queue
+from traceback import format_exception
 from typing import Optional, Union
 
 from astropy.io import fits
+from filelock import FileLock, Timeout
+from prometheus_client import Counter, Gauge
 from rucio.client.accountclient import AccountClient
 from rucio.client.client import Client, DIDClient
 from rucio.client.replicaclient import ReplicaClient
@@ -20,6 +32,8 @@ from rucio.client.ruleclient import RuleClient
 from rucio.client.scopeclient import ScopeClient
 from rucio.common.exception import Duplicate, RucioException
 from rucio.common.utils import adler32
+from watchdog.events import FileSystemEventHandler
+from watchdog.observers.polling import PollingObserver
 
 from bdms.extract_fits_metadata import (
     extract_metadata_from_data,
@@ -28,17 +42,32 @@ from bdms.extract_fits_metadata import (
 
 LOGGER = logging.getLogger(__name__)
 
+__all__ = ["IngestionClient", "FITSVerificationError", "Ingest"]
 
-__all__ = [
-    "IngestionClient",
-]
+INGEST_RUNNING_MESSAGE = "Another ingestion process is already running"
+DETECTED_NEW_TRIGGER_FILE = "Detected new trigger file"
+INGEST_SUCCESS_MESSAGE = "Successfully ingested"
+TRIGGER_SUFFIX = ".trigger"
+
+# Prometheus Metrics for monitoring
+N_TASKS_SUCCESS = Counter("n_tasks_success", "Number of successfully finished tasks.")
+N_TASKS_FAILED = Counter("n_tasks_failed", "Number of failed tasks.")
+N_TASKS_CANCELLED = Counter("n_tasks_cancelled", "Number of cancelled tasks.")
+N_TASKS_SKIPPED = Counter("n_tasks_skipped", "Number of skipped tasks.")
+N_TASKS_PROCESSED = Counter(
+    "n_tasks_processed", "Total number of tasks processed by the Ingest daemon"
+)
+TASKS_IN_QUEUE = Gauge("n_tasks_queued", "Current number of queued tasks")
+
+IngestStatus = Enum("IngestStatus", [("SUCCESS", 0), ("FAILURE", 1), ("SKIPPED", 2)])
 
 
 class IngestionClient:
     """A client for BDMS ingestion and replication.
 
     This class provides methods to ingest ACADA data into the BDMS system, including converting ACADA paths to
-    Logical File Names (LFNs), registering replicas in Rucio, and replicating data to offsite RSEs.
+    Logical File Names (LFNs), registering replicas in Rucio, extracting metadata and adding metadata to registered replicas, and
+    replicating data to offsite RSEs.
 
     Parameters
     ----------
@@ -78,6 +107,9 @@ class IngestionClient:
         self.logger = logger or LOGGER.getChild(self.__class__.__name__)
         self.vo = vo
 
+        if data_path is None:
+            raise ValueError("data_path must be provided and cannot be None")
+
         # Set data path (Prefix)
         self.data_path = Path(data_path)
         if not self.data_path.is_dir():
@@ -225,7 +257,7 @@ class IngestionClient:
             return True
         return False
 
-    def add_onsite_replica(self, acada_path) -> str:
+    def add_onsite_replica(self, acada_path: Union[str, Path]) -> tuple[str, bool]:
         """Register a file as a replica in Rucio on the specified RSE and retrieve its LFN.
 
         Parameters
@@ -233,13 +265,12 @@ class IngestionClient:
         acada_path : str or Path
             The ACADA path where the file is located.
 
-        rse : str, optional
-            The RSE to register the replica on. If None, uses the client's RSE (self.rse).
-
         Returns
         -------
-        str
-            The Logical File Name (LFN) of the registered replica.
+        tuple[str, bool]
+            A tuple containing:
+            - The Logical File Name (LFN) of the registered or existing replica.
+            - A boolean indicating if the replica was skipped (True) or newly ingested (False).
 
         Raises
         ------
@@ -264,7 +295,7 @@ class IngestionClient:
         # Check if the replica already exists
         if self.check_replica_exists(lfn):
             self.logger.info("Replica already exists for lfn '%s', skipping", lfn)
-            return lfn
+            return lfn, True  # Indicate the file was skipped
 
         # Proceed with registering the replica if check_replica_exists returns False
         valid, metadata = verify_and_extract_metadata(acada_path)
@@ -297,7 +328,7 @@ class IngestionClient:
             self.did_client.set_metadata_bulk(scope=self.scope, name=lfn, meta=metadata)
             self.logger.info("Set metadata of %r to %r", lfn, metadata)
 
-        return lfn
+        return lfn, False  # Indicate the file was newly ingested
 
     def add_offsite_replication_rules(
         self,
@@ -477,3 +508,439 @@ def verify_and_extract_metadata(fits_path):
         except Exception as e:
             LOGGER.error("Failed to extract metadata from %r: %s", fits_path, e)
             return False, metadata
+
+
+def process_file(
+    client: IngestionClient, file_path: str, logger=None, copies: int = 2
+) -> IngestStatus:
+    """Process a single file with IngestionClient, clean up the trigger file, and return the ingestion status.
+
+    Parameters
+    ----------
+    client : IngestionClient
+        The IngestionClient instance to handle replica registration and replication.
+    file_path : str
+        The path to the file to process.
+    logger : logging.Logger, optional
+        Logger instance. If None, uses the client's logger or a default logger.
+
+    Returns
+    -------
+    IngestStatus
+        The status of the ingestion process:
+        - SUCCESS if the file is ingested successfully.
+        - FAILURE if an error occurs during ingestion.
+        - SKIPPED if the file was already ingested.
+    """
+    logger = logger or LOGGER.getChild("Ingest")
+    trigger_file = Path(file_path + TRIGGER_SUFFIX)
+    try:
+        lfn, was_skipped = client.add_onsite_replica(file_path)
+        if was_skipped:
+            logger.info("Replica already exists for %s, skipping", file_path)
+            if trigger_file.exists():
+                trigger_file.unlink()
+                logger.debug("Removed trigger file %s", trigger_file)
+            return IngestStatus.SKIPPED
+        client.add_offsite_replication_rules(lfn, copies=copies)
+        logger.info("%s %s, LFN: %s", INGEST_SUCCESS_MESSAGE, file_path, lfn)
+        if trigger_file.exists():
+            trigger_file.unlink()
+            logger.debug("Removed trigger file %s", trigger_file)
+        return IngestStatus.SUCCESS
+    except Exception as e:
+        logger.exception("Exception in process_file for %s: %s", file_path, str(e))
+        return IngestStatus.FAILURE
+
+
+class TriggerFileHandler(FileSystemEventHandler):
+    """File system event handler for detecting and processing trigger files.
+
+    This handler monitors file system events and responds to the creation of
+    trigger files (files ending with '.trigger'). When a trigger file is detected,
+    it immediately submits the corresponding data file for ingestion processing
+    without any intermediate queuing to the worker pool.
+    """
+
+    def __init__(self, ingest_instance):
+        """Initialize the handler with an Ingest instance.
+
+        Parameters
+        ----------
+        ingest_instance : Ingest
+            The Ingest daemon instance to process files and log events.
+            Must provide `submit_file(file_path)` method and `logger` attribute.
+        """
+        self.ingest = ingest_instance
+
+    def on_moved(self, event):
+        """Handle file move events, which includes symlink creation.
+
+        When creating symlinks with 'ln -s', the filesystem generates a
+        FileMovedEvent instead of FileCreatedEvent. This method handles
+        trigger file detection for symlink-based triggers.
+
+        Parameters
+        ----------
+        event : watchdog.events.FileMovedEvent
+            The file move event containing source and destination paths.
+        """
+        self.ingest.logger.debug("MOVE Event received: %s", event)
+        if event.is_directory or self.ingest.stop_event.is_set():
+            return
+
+        # Check if the destination is a trigger file
+        if event.dest_path and event.dest_path.endswith(TRIGGER_SUFFIX):
+            trigger_file = Path(event.dest_path)
+            data_file = trigger_file.with_suffix("")
+
+            if not data_file.exists():
+                self.ingest.logger.error(
+                    "Data file %s for trigger %s does not exist, skipping",
+                    data_file,
+                    trigger_file,
+                )
+                return
+
+            self.ingest.logger.info(
+                "%s %s, submitting data file %s",
+                DETECTED_NEW_TRIGGER_FILE,
+                trigger_file,
+                data_file,
+            )
+
+            self.ingest._submit_file(str(data_file))
+
+
+class Ingest:
+    """Ingestion daemon service to process ACADA data products using a process pool with result handling.
+
+    Monitors a specified directory for trigger files using a polling-based observer,
+    submitting each file for ingestion to a ProcessPoolExecutor for parallel processing.
+    Uses an improved callback-based result handling system with structured task tracking
+    and immediate result processing. The daemon ensures compatibility with shared
+    filesystems through polling and prevents multiple instances using a lock file.
+    """
+
+    def __init__(
+        self,
+        client,
+        top_dir: Union[str, Path],
+        num_workers: int = cpu_count(),
+        lock_file_path: Union[str, Path, None] = None,
+        polling_interval: float = 1.0,
+        check_interval: float = 1.0,
+        offsite_copies: int = 2,
+    ) -> None:
+        """Initialize the ingestion daemon with configuration parameters.
+
+        Sets up the client, directory, worker count, intervals, and initializes
+        a process-safe queue and daemon state.
+        """
+        self.client = client
+        self.top_dir = Path(top_dir)
+        self.num_workers = num_workers
+        self.lock_file_path = (
+            Path(lock_file_path)
+            if lock_file_path is not None
+            else self.top_dir / "bdms_ingest.lock"
+        )
+        self.polling_interval = polling_interval
+        self.check_interval = check_interval
+        self.offsite_copies = offsite_copies
+        self.stop_event = threading.Event()
+        self.logger = LOGGER.getChild(self.__class__.__name__)
+
+        # Result handling
+        self.result_queue = Queue()
+        self.task_counter = 0
+        self.submitted_tasks = {}  # Track submitted tasks: {task_id: file_path}
+
+        # Statistics tracking
+        self.max_concurrent_tasks = 0
+        self.total_tasks_submitted = 0
+
+        # Lock instance to be held during entire daemon execution
+        self.lock = None
+
+    def _done_callback(self, future, task_id: int, file_path: str):
+        """Queue completed task result for processing.
+
+        This method is invoked immediately when a worker process finishes
+        processing a file. It queues the result for processing by the
+        dedicated result handling thread.
+
+        Parameters
+        ----------
+        future : concurrent.futures.Future
+            The completed Future object containing the task result.
+        task_id : int
+            Unique identifier for the completed task.
+        file_path : str
+            Path to the file that was processed.
+        """
+        self.result_queue.put((task_id, file_path, future))
+
+    def _submit_file(self, file_path: str):
+        """Submit a file for processing using the callback pattern.
+
+        Creates a unique task ID, submits the file to the worker pool, and
+        sets up an immediate callback for result processing
+
+        Parameters
+        ----------
+        file_path : str
+            Path to the data file to be processed.
+        """
+        task_id = self.task_counter
+        self.task_counter += 1
+        self.total_tasks_submitted += 1
+
+        self.submitted_tasks[task_id] = file_path
+
+        # Update max concurrent tasks tracking
+        current_concurrent = len(self.submitted_tasks)
+        self.max_concurrent_tasks = max(self.max_concurrent_tasks, current_concurrent)
+
+        # Increment queue counter when task is submitted
+        TASKS_IN_QUEUE.inc()
+
+        self.logger.debug(
+            "Submitting task %d for file %s (concurrent: %d, max: %d)",
+            task_id,
+            file_path,
+            current_concurrent,
+            self.max_concurrent_tasks,
+        )
+
+        # Submit with callback using partial
+        future = self.executor.submit(
+            process_file,
+            self.client,
+            file_path,
+            logger=self.logger,
+            copies=self.offsite_copies,
+        )
+        future.add_done_callback(
+            partial(self._done_callback, task_id=task_id, file_path=file_path)
+        )
+
+    def _handle_result(
+        self,
+        task_id: int,
+        file_path: str,
+        future: "Future",
+        processed_count: int,
+        start_time: float,
+    ) -> None:
+        """Handle the result of a completed task.
+
+        This method processes the result of a completed ingestion task, performs
+        cleanup of task tracking data, calculates processing statistics, and logs
+        the outcome. It handles successful completion, cancellation, and error cases.
+
+        Parameters
+        ----------
+        task_id : int
+            Unique identifier for the completed task.
+        file_path : str
+            Path to the file that was processed.
+        future : concurrent.futures.Future
+            The completed Future object containing the task result.
+        processed_count : int
+            Total number of tasks processed so far.
+        start_time : float
+            Start time of the result processing thread for rate calculation.
+        """
+        elapsed_time = time.time() - start_time
+        rate = processed_count / elapsed_time if elapsed_time > 0 else 0
+
+        # Clean up task tracking
+        self.submitted_tasks.pop(task_id, None)
+        current_concurrent = len(self.submitted_tasks)
+        TASKS_IN_QUEUE.dec()  # Always decrement queue counter
+
+        self.logger.debug(
+            "Task %d completed, remaining concurrent: %d",
+            task_id,
+            current_concurrent,
+        )
+
+        # Process the result
+        if future.cancelled():
+            status = "cancelled"
+            N_TASKS_CANCELLED.inc()  # Increment cancellation counter
+        elif (e := future.exception()) is not None:
+            self.logger.error(
+                "Task %d failed: %s",
+                task_id,
+                "".join(format_exception(type(e), e, e.__traceback__)),
+            )
+            status = "failed"
+            N_TASKS_FAILED.inc()  # Increment failure counter
+        else:
+            result = future.result()
+            if result == IngestStatus.SUCCESS:
+                status = "success"
+                N_TASKS_SUCCESS.inc()  # Increment success counter
+            elif result == IngestStatus.SKIPPED:
+                status = "skipped"
+                N_TASKS_SKIPPED.inc()  # Increment skipped counter
+            else:
+                status = "failed"
+                N_TASKS_FAILED.inc()  # Increment failure counter
+
+        N_TASKS_PROCESSED.inc()  # Increment total processed counter
+
+        # Summary log for all cases
+        self.logger.info(
+            "Processed file %s with result %s. Rate: %.2f files/sec",
+            file_path,
+            status,
+            rate,
+        )
+
+    def _process_results(self):
+        """Process results from the result queue.
+
+        This method runs in a separate daemon thread and continuously processes
+        completed tasks from the result queue. It handles task cleanup, result
+        logging, and error reporting. The method implements the improved result
+        handling pattern with structured error handling and performance tracking.
+
+        The method maintains local counters for processed_count and start_time,
+        which are passed to _handle_result for rate calculation and logging.
+        The thread processes results until the stop_event is set and the queue
+        is empty, ensuring all results are handled before shutdown.
+        """
+        self.logger.info("Result processing thread started")
+        start_time = time.time()
+        processed_count = 0
+
+        try:
+            while not self.stop_event.is_set() or not self.result_queue.empty():
+                try:
+                    task_id, file_path, future = self.result_queue.get(
+                        timeout=self.check_interval
+                    )
+                except Empty:
+                    continue
+
+                try:
+                    processed_count += 1
+                    self._handle_result(
+                        task_id, file_path, future, processed_count, start_time
+                    )
+                except Exception as e:
+                    self.logger.exception(
+                        "Error processing result for task %d: %s", task_id, str(e)
+                    )
+
+        except Exception as e:
+            self.logger.exception("Fatal error in result processing thread: %s", str(e))
+        finally:
+            self.logger.info("Result processing thread stopped")
+
+    def _check_directory(self) -> None:
+        """Check if the directory is readable.
+
+        Raises
+        ------
+        RuntimeError
+            If the top directory is not accessible.
+        """
+        if not self.top_dir.is_dir() or not os.access(self.top_dir, os.R_OK):
+            self.logger.error("Cannot read directory %s", self.top_dir)
+            raise RuntimeError(f"Cannot read directory {self.top_dir}")
+
+    def run(self) -> None:
+        """Run the ingestion daemon, submitting file ingestion tasks to a process pool, and result handling.
+
+        Initializes and runs the complete ingestion system including:
+
+        1. Process checks (lock file acquisition and hold for entire runtime)
+        2. Validates directory access
+        3. Result processing thread startup
+        4. Worker process pool creation
+        5. File system monitoring with polling observer
+        6. Graceful shutdown handling
+
+        The method blocks until a shutdown signal is received (KeyboardInterrupt)
+        or the stop_event is set. All components are properly shut down and
+        cleaned up before the method returns.
+
+        Raises
+        ------
+        RuntimeError
+            If another ingestion process is running or the directory is unreadable.
+        """
+        # Acquire lock for the entire daemon execution, preventing multiple instances
+        self.lock = FileLock(self.lock_file_path, timeout=10)
+
+        try:
+            # Acquire the lock - this will be held for the entire daemon runtime
+            self.lock.acquire(timeout=10)
+            self.logger.info("Acquired lock file: %s", self.lock.lock_file)
+        except Timeout:
+            raise RuntimeError(INGEST_RUNNING_MESSAGE)
+
+        # Write PID to the original lock file for reference
+        self.lock_file_path.write_text(str(os.getpid()))
+        self.logger.info("Written PID %d to %s", os.getpid(), self.lock_file_path)
+
+        try:
+            self._check_directory()
+
+            # Start the result processing thread
+            result_thread = threading.Thread(target=self._process_results, daemon=True)
+            result_thread.start()
+            self.logger.info("Started result processing thread")
+
+            with ProcessPoolExecutor(max_workers=self.num_workers) as executor:
+                self.executor = executor  # Store reference for submit_file method
+                self.logger.info(
+                    "Started process pool with %d workers", self.num_workers
+                )
+
+                event_handler = TriggerFileHandler(self)
+
+                self.logger.info(
+                    "Starting continuous polling-based monitoring of directory %s with interval %s seconds",
+                    self.top_dir,
+                    self.polling_interval,
+                )
+                observer = PollingObserver(timeout=self.polling_interval)
+                observer.schedule(event_handler, str(self.top_dir), recursive=True)
+                observer.start()
+                self.logger.info("File monitoring observer started successfully")
+
+                try:
+                    while not self.stop_event.is_set():
+                        self.stop_event.wait(self.check_interval)
+                except KeyboardInterrupt:
+                    self.logger.info("Received shutdown signal, stopping daemon")
+                finally:
+                    self.stop_event.set()
+                    self.logger.info("Stopping file observer")
+                    observer.stop()
+                    observer.join()
+                    self.logger.info("Stopping result processing thread")
+                    result_thread.join()
+
+        finally:
+            # Always release the lock and clean up, even if an exception occurred
+            if self.lock and self.lock.is_locked:
+                self.lock.release()
+                self.logger.info("Released lock file")
+
+            # Clean up PID file
+            if self.lock_file_path.exists():
+                try:
+                    self.lock_file_path.unlink()
+                    self.logger.info("Removed PID file: %s", self.lock_file_path)
+                except Exception as e:
+                    self.logger.warning(
+                        "Failed to remove PID file %s: %s", self.lock_file_path, e
+                    )
+
+            self.logger.info("Stopped ingestion daemon")