crucible-mcp 0.1.0__py3-none-any.whl → 0.3.0__py3-none-any.whl

crucible/knowledge/loader.py

@@ -16,6 +16,25 @@ KNOWLEDGE_USER = Path.home() / ".claude" / "crucible" / "knowledge"
 KNOWLEDGE_PROJECT = Path(".crucible") / "knowledge"
 
 
+def load_knowledge_file(filename: str) -> Result[str, str]:
+    """Load a single knowledge file by name.
+
+    Args:
+        filename: Knowledge file name (e.g., "SECURITY.md")
+
+    Returns:
+        Result containing file content or error message
+    """
+    path, source = resolve_knowledge_file(filename)
+    if path is None:
+        return err(f"Knowledge file '{filename}' not found")
+
+    try:
+        return ok(path.read_text())
+    except OSError as e:
+        return err(f"Failed to read '{filename}': {e}")
+
+
 def resolve_knowledge_file(filename: str) -> tuple[Path | None, str]:
     """Find knowledge file with cascade priority.
 
@@ -52,6 +71,55 @@ def get_all_knowledge_files() -> set[str]:
     return files
 
 
+def get_custom_knowledge_files() -> set[str]:
+    """Get knowledge files from project and user directories only.
+
+    These are custom/team knowledge files that should always be included
+    in full_review, regardless of skill references.
+
+    Returns:
+        Set of filenames from project and user knowledge directories
+    """
+    files: set[str] = set()
+
+    for source_dir in [KNOWLEDGE_USER, KNOWLEDGE_PROJECT]:
+        if source_dir.exists():
+            for file_path in source_dir.iterdir():
+                if file_path.is_file() and file_path.suffix == ".md":
+                    files.add(file_path.name)
+
+    return files
+
+
+def load_all_knowledge(
+    include_bundled: bool = False,
+    filenames: set[str] | None = None,
+) -> tuple[list[str], str]:
+    """Load multiple knowledge files.
+
+    Args:
+        include_bundled: If True, include bundled knowledge files
+        filenames: Specific files to load (if None, loads based on include_bundled)
+
+    Returns:
+        Tuple of (list of loaded filenames, combined content)
+    """
+    if filenames is None:
+        filenames = get_all_knowledge_files() if include_bundled else get_custom_knowledge_files()
+
+    loaded: list[str] = []
+    parts: list[str] = []
+
+    for filename in sorted(filenames):
+        result = load_knowledge_file(filename)
+        if result.is_ok:
+            loaded.append(filename)
+            parts.append(f"# {filename}\n\n{result.value}")
+
+    content = "\n\n---\n\n".join(parts) if parts else ""
+    return loaded, content
+
+
 def load_principles(topic: str | None = None) -> Result[str, str]:
     """
     Load engineering principles from markdown files.
@@ -66,9 +134,10 @@ def load_principles(topic: str | None = None) -> Result[str, str]:
     topic_files = {
         None: ["SECURITY.md", "TESTING.md"],  # Default: security + testing basics
         "engineering": ["TESTING.md", "ERROR_HANDLING.md", "TYPE_SAFETY.md"],
-        "security": ["SECURITY.md"],
+        "security": ["SECURITY.md", "GITIGNORE.md", "PRECOMMIT.md"],
         "smart_contract": ["SMART_CONTRACT.md"],
         "checklist": ["SECURITY.md", "TESTING.md", "ERROR_HANDLING.md"],
+        "repo_hygiene": ["GITIGNORE.md", "PRECOMMIT.md", "COMMITS.md"],
     }
 
     files_to_load = topic_files.get(topic, topic_files[None])

crucible/models.py

@@ -59,3 +59,18 @@ DOMAIN_HEURISTICS: dict[Domain, dict[str, list[str]]] = {
         "markers": ["resource ", "provider ", "apiVersion:", "kind:"],
     },
 }
+
+
+@dataclass(frozen=True)
+class FullReviewResult:
+    """Result from full_review tool."""
+
+    domains_detected: tuple[str, ...]
+    severity_summary: dict[str, int]
+    findings: tuple[ToolFinding, ...]
+    applicable_skills: tuple[str, ...]
+    skill_triggers_matched: dict[str, tuple[str, ...]]
+    principles_loaded: tuple[str, ...]
+    principles_content: str
+    sage_knowledge: str | None = None
+    sage_query_used: str | None = None