crochet-migration 0.1.0__py3-none-any.whl → 0.1.1__py3-none-any.whl

crochet/migrations/engine.py

@@ -153,6 +153,7 @@ class MigrationEngine:
         # Compute schema hash and diff
         schema_hash = ""
         diff_summary = ""
+        diff_obj = None
         if current_snapshot is not None:
             current_snapshot = hash_snapshot(current_snapshot)
             schema_hash = current_snapshot.schema_hash
@@ -166,9 +167,9 @@ class MigrationEngine:
                 prev_json = self._ledger.get_snapshot(prev_hash)
                 if prev_json:
                     prev_snapshot = SchemaSnapshot.from_json(prev_json)
-                    diff = diff_snapshots(prev_snapshot, current_snapshot)
-                    if diff.has_changes:
-                        diff_summary = diff.summary()
+                    diff_obj = diff_snapshots(prev_snapshot, current_snapshot)
+                    if diff_obj.has_changes:
+                        diff_summary = diff_obj.summary()
 
         content = render_migration(
             revision_id=revision_id,
@@ -177,6 +178,7 @@ class MigrationEngine:
             schema_hash=schema_hash,
             rollback_safe=rollback_safe,
             diff_summary=diff_summary,
+            diff=diff_obj,
         )
 
         return write_migration_file(

crochet/migrations/template.py

@@ -5,6 +5,10 @@ from __future__ import annotations
 import re
 from datetime import datetime, timezone
 from pathlib import Path
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from crochet.ir.diff import SchemaDiff
 
 _MIGRATION_TEMPLATE = '''\
 """
@@ -52,6 +56,189 @@ def generate_revision_id(seq: int, description: str) -> str:
     return f"{seq:04d}_{slug}"
 
 
+def generate_operations_from_diff(diff: "SchemaDiff") -> tuple[str, str]:
+    """Generate upgrade and downgrade operation code from a SchemaDiff.
+    
+    Returns a tuple of (upgrade_code, downgrade_code) as strings.
+    """
+    upgrade_lines: list[str] = []
+    downgrade_lines: list[str] = []
+    
+    # Process node changes
+    for nc in diff.node_changes:
+        if nc.kind == "added":
+            # Node added - no automatic operations (user should handle data)
+            upgrade_lines.append(f"# TODO: Handle new node '{nc.new.label}' (kgid={nc.kgid})")
+            downgrade_lines.append(f"# TODO: Clean up node '{nc.new.label}' (kgid={nc.kgid})")
+        elif nc.kind == "removed":
+            # Node removed - no automatic operations (user should handle data)
+            upgrade_lines.append(f"# TODO: Handle removed node '{nc.old.label}' (kgid={nc.kgid})")
+            downgrade_lines.append(f"# TODO: Restore node '{nc.old.label}' (kgid={nc.kgid})")
+        elif nc.kind == "modified":
+            label = nc.new.label if nc.new else nc.old.label
+            
+            # Handle label rename
+            if nc.label_renamed and nc.old and nc.new:
+                upgrade_lines.append(
+                    f'ctx.rename_label("{nc.old.label}", "{nc.new.label}")'
+                )
+                downgrade_lines.append(
+                    f'ctx.rename_label("{nc.new.label}", "{nc.old.label}")'
+                )
+            
+            # Handle property changes
+            for pc in nc.property_changes:
+                if pc.kind == "added":
+                    # Property added
+                    upgrade_lines.append(
+                        f'ctx.add_node_property("{label}", "{pc.property_name}")'
+                    )
+                    downgrade_lines.append(
+                        f'ctx.remove_node_property("{label}", "{pc.property_name}")'
+                    )
+                    
+                    # Handle constraints/indexes for new property
+                    if pc.new:
+                        if pc.new.unique_index:
+                            upgrade_lines.append(
+                                f'ctx.add_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.drop_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                        elif pc.new.index:
+                            upgrade_lines.append(
+                                f'ctx.add_index("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.drop_index("{label}", "{pc.property_name}")'
+                            )
+                        if pc.new.required:
+                            upgrade_lines.append(
+                                f'ctx.add_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.drop_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+                            
+                elif pc.kind == "removed":
+                    # Property removed
+                    upgrade_lines.append(
+                        f'ctx.remove_node_property("{label}", "{pc.property_name}")'
+                    )
+                    downgrade_lines.append(
+                        f'ctx.add_node_property("{label}", "{pc.property_name}")'
+                    )
+                    
+                    # Handle constraints/indexes for removed property
+                    if pc.old:
+                        if pc.old.unique_index:
+                            upgrade_lines.append(
+                                f'ctx.drop_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.add_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                        elif pc.old.index:
+                            upgrade_lines.append(
+                                f'ctx.drop_index("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.add_index("{label}", "{pc.property_name}")'
+                            )
+                        if pc.old.required:
+                            upgrade_lines.append(
+                                f'ctx.drop_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.add_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+                            
+                elif pc.kind == "modified" and pc.old and pc.new:
+                    # Property modified - handle constraint/index changes
+                    if pc.old.unique_index != pc.new.unique_index:
+                        if pc.new.unique_index:
+                            upgrade_lines.append(
+                                f'ctx.add_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.drop_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                        else:
+                            upgrade_lines.append(
+                                f'ctx.drop_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.add_unique_constraint("{label}", "{pc.property_name}")'
+                            )
+                    
+                    if pc.old.index != pc.new.index:
+                        if pc.new.index:
+                            upgrade_lines.append(
+                                f'ctx.add_index("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.drop_index("{label}", "{pc.property_name}")'
+                            )
+                        else:
+                            upgrade_lines.append(
+                                f'ctx.drop_index("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.add_index("{label}", "{pc.property_name}")'
+                            )
+                    
+                    if pc.old.required != pc.new.required:
+                        if pc.new.required:
+                            upgrade_lines.append(
+                                f'ctx.add_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.drop_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+                        else:
+                            upgrade_lines.append(
+                                f'ctx.drop_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+                            downgrade_lines.append(
+                                f'ctx.add_node_property_existence_constraint("{label}", "{pc.property_name}")'
+                            )
+    
+    # Process relationship changes
+    for rc in diff.relationship_changes:
+        if rc.kind == "added":
+            upgrade_lines.append(f"# TODO: Handle new relationship '{rc.new.rel_type}' (kgid={rc.kgid})")
+            downgrade_lines.append(f"# TODO: Clean up relationship '{rc.new.rel_type}' (kgid={rc.kgid})")
+        elif rc.kind == "removed":
+            upgrade_lines.append(f"# TODO: Handle removed relationship '{rc.old.rel_type}' (kgid={rc.kgid})")
+            downgrade_lines.append(f"# TODO: Restore relationship '{rc.old.rel_type}' (kgid={rc.kgid})")
+        elif rc.kind == "modified":
+            # Handle relationship property changes similarly to nodes
+            rel_type = rc.new.rel_type if rc.new else rc.old.rel_type
+            for pc in rc.property_changes:
+                if pc.kind == "added":
+                    upgrade_lines.append(
+                        f'# TODO: Add property "{pc.property_name}" to relationship {rel_type}'
+                    )
+                elif pc.kind == "removed":
+                    upgrade_lines.append(
+                        f'# TODO: Remove property "{pc.property_name}" from relationship {rel_type}'
+                    )
+    
+    # Format the code
+    if upgrade_lines:
+        upgrade_code = "    " + "\n    ".join(upgrade_lines)
+    else:
+        upgrade_code = "    pass"
+    
+    if downgrade_lines:
+        downgrade_code = "    " + "\n    ".join(downgrade_lines)
+    else:
+        downgrade_code = "    pass"
+    
+    return upgrade_code, downgrade_code
+
+
 def render_migration(
     revision_id: str,
     parent_id: str | None,
@@ -59,11 +246,23 @@ def render_migration(
     schema_hash: str,
     rollback_safe: bool = True,
     diff_summary: str = "",
+    diff: "SchemaDiff | None" = None,
 ) -> str:
     """Render a migration file from template."""
     now = datetime.now(timezone.utc).isoformat()
 
-    if diff_summary:
+    # Generate operations from diff if available
+    if diff is not None and diff.has_changes:
+        upgrade_lines, downgrade_lines = generate_operations_from_diff(diff)
+        # Prepend comment header showing what was detected
+        if diff_summary:
+            comment_header = _DIFF_COMMENT_HEADER
+            for line in diff_summary.splitlines():
+                comment_header += f"    # {line}\n"
+            upgrade_lines = comment_header + "\n" + upgrade_lines
+            downgrade_lines = comment_header + "\n" + downgrade_lines
+    elif diff_summary:
+        # Fallback to old behavior if only summary is provided
         upgrade_lines = _DIFF_COMMENT_HEADER
         for line in diff_summary.splitlines():
             upgrade_lines += f"    # {line}\n"

{crochet_migration-0.1.0.dist-info → crochet_migration-0.1.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: crochet-migration
-Version: 0.1.0
+Version: 0.1.1
 Summary: Versioned schema & data migrations for neomodel Neo4j graphs
 Project-URL: Homepage, https://github.com/keshavd/crochet
 Project-URL: Repository, https://github.com/keshavd/crochet
@@ -52,7 +52,7 @@ graph.
 ## Installation
 
 ```bash
-pip install crochet
+pip install crochet-migration
 ```
 
 For development:

{crochet_migration-0.1.0.dist-info → crochet_migration-0.1.1.dist-info}/RECORD

@@ -13,14 +13,14 @@ crochet/ir/schema.py,sha256=0MTOWGAmtWDVGCSfUEAdHXNM-lriyeT3gCUbsF3OsSc,6160
 crochet/ledger/__init__.py,sha256=xXaClHCWAbo36NfYMo41VftPo3O7kPpIyW-wj4Lwaqw,133
 crochet/ledger/sqlite.py,sha256=yGy4dDh5KPC5-N3HVaK1FpD7GYixoM2M5_IDRaEROvU,9421
 crochet/migrations/__init__.py,sha256=-112mqAx8xTQzu33lA3mmiZAP6v_H0_tPlOpYRazVeE,204
-crochet/migrations/engine.py,sha256=CyqtjWJbFPuIRfgMZ30ng1D7RUJGR0-i8Z1lxq5Z6sc,9563
+crochet/migrations/engine.py,sha256=YmZ1OuaYmTWof5cp3HZbLKQVhUHARO1OScvMgePEt5w,9626
 crochet/migrations/operations.py,sha256=iv2aFF5w-X5K2y5fqB-w8CuSNN15eEswDHyOJIiamrY,10360
-crochet/migrations/template.py,sha256=1vca5mDkQKt6B4M5mLn3NZErSZAannfkUuf1LPjdU3U,2673
+crochet/migrations/template.py,sha256=A_cZ_ECD5vybg_GaoB3uYydfail-Ygm8hzG915EBsGA,12637
 crochet/scaffold/__init__.py,sha256=ZPyyQ3_s2uwFaw8kdpsYT7q4Br5TdU6KVCJbc0hhslo,236
 crochet/scaffold/node.py,sha256=vXIqyYUj1Ot4qPUIwcwXsFKJsdcIbEh8Y71ASgWH4nY,1266
 crochet/scaffold/relationship.py,sha256=eHKAt0olYcGXAA5TdnIl2DOZpN31GK9y-hJFutF2Tqg,1373
-crochet_migration-0.1.0.dist-info/METADATA,sha256=tGQyC-qLHV0VbIW-u77FU10-EB6_ZXc3hPKa-hW2Tvc,8285
-crochet_migration-0.1.0.dist-info/WHEEL,sha256=WLgqFyCfm_KASv4WHyYy0P3pM_m7J5L9k2skdKLirC8,87
-crochet_migration-0.1.0.dist-info/entry_points.txt,sha256=wKTVp7ky8zuaFIMskw4FEVSppYDoKG-6CV1joyCKSC8,45
-crochet_migration-0.1.0.dist-info/licenses/LICENSE,sha256=plFEmT-Ix7lZ5QZvnBsTTETSVDcBhM9sY8lWCxU6llg,1068
-crochet_migration-0.1.0.dist-info/RECORD,,
+crochet_migration-0.1.1.dist-info/METADATA,sha256=OzS8_dvoN65VJAfMiiZn3B8-q9zb7Gy3O4_MRO_i4HU,8295
+crochet_migration-0.1.1.dist-info/WHEEL,sha256=WLgqFyCfm_KASv4WHyYy0P3pM_m7J5L9k2skdKLirC8,87
+crochet_migration-0.1.1.dist-info/entry_points.txt,sha256=wKTVp7ky8zuaFIMskw4FEVSppYDoKG-6CV1joyCKSC8,45
+crochet_migration-0.1.1.dist-info/licenses/LICENSE,sha256=plFEmT-Ix7lZ5QZvnBsTTETSVDcBhM9sY8lWCxU6llg,1068
+crochet_migration-0.1.1.dist-info/RECORD,,