contact-person-profile-csv-imp-local 0.0.50__py3-none-any.whl → 0.0.51__py3-none-any.whl

contact_person_profile_csv_imp_local/CSVToContactPersonProfile.py

@@ -51,12 +51,12 @@ DEFAULT_PROFILE_ID = 0
 # Those methods should be called from the common method for this repo (contact-person-profile-csv-imp-local-python-package and google-contact-sync ...)
 
 # TODO def process_first_name( original_first_name: str) -> str: (move to people-local-python-package)
-#     normilized_first_name = the first word in original_first_name
-#     GroupsLocal.add_update_group_and_link_to_contact( normilized_first_name, is_group=true, contact_id) # When checking if exists, ignore the upper-case lower-case
-#     return normilized_first_name
+#     normalized_first_name = the first word in original_first_name
+#     GroupsLocal.add_update_group_and_link_to_contact( normalized_first_name, is_group=true, contact_id) # When checking if exists, ignore the upper-case lower-case
+#     return normalized_first_name
 
 # TODO def process_last_name( original_last_name : str) -> str: (move to people-local-python-package)
-#     normilized_last_name = Remove all the digits from the last_name
+#     normalized_last_name = Remove all the digits from the last name
 #     GroupsLocal.add_update_group_and_link_to_contact( normilized_last_name, is_group=true, contact_id) # When checking if exists, ignore the upper-case lower-case
 
 # TODO def process_phone( original_phone_number: str) -> str: (move to phone-local-python-package)
@@ -75,7 +75,7 @@ DEFAULT_PROFILE_ID = 0
 #     normalized_organization_name = GroupsLocal.add_update_group_and_link_to_contact( organization_name, is_organization=true) # When checking if the organization exists, remove suffix such as Ltd, Inc, בעמ... when searching ignore the uppper-case lower-case
 
 # TODO def process_department( department_name: str) -> str: (move to people-local-python-package
-#     normalized_department_name = GroupsLocal.add_update_group_and_link_to_contact( department_name, is_department=true) # When searching ignore the upper-case lower-case, return the value with is_main == true
+#     normalized_department_name = GroupsLocal.add_update_group_and_link_to_contact( department_name, is_department=true) # When searching, ignore the upper-case lower-case, return the value with is_main == true
 
 # TODO def process_continent( continent_name: str) -> str: (move to location-local-python-package)
 #     continent_id, normalized_continent_name = GroupsLocal.add_update_group_and_link_to_contact( continent_name, is_continent=true) # When checking if exists, ignore the upper-case lower-case, return the value with is_main == true
@@ -124,7 +124,8 @@ class CSVToContactPersonProfile(
                                 'contact_location', 'user_externals_local',
                                 'organizations_local', 'domain_local',
                                 'importers_local']
-        GenericCRUD.__init__(self, default_schema_name="entity_type",
+        GenericCRUD.__init__(self, default_schema_name="profile",
+                             default_view_table_name="profile_view",
                              is_test_data=is_test_data)
         self.contact_entity_type_id = \
             self.select_one_value_by_column_and_value(
@@ -229,7 +230,7 @@ class CSVToContactPersonProfile(
         self.logger.info(f"profile_id: {profile_id}")
         # if csv_path is provided then we will use the full path
         # if csv_path is not provided then we will use the directory_name and file_name to create the full path
-        # if directory_name is not provided the assumption is that the file is in the same directory as the script and not in a folder
+        # If directory_name is not provided, the assumption is that the file is in the same directory as the script and not in a folder
         if csv_path is not None:
             csv_file_path = csv_path
         else:
@@ -248,7 +249,7 @@ class CSVToContactPersonProfile(
 
         user_external_id = self.__get_user_external_id(user_external_username=user_external_username,
                                                        profile_id=profile_id, system_id=system_id)
-        # We create a new data_source_instance_id everytime we import a new csv file
+        # We create a new data_source_instance_id every time we import a new csv file
         data_source_instance_id = self.__get_data_source_instance_id(
             data_source_type_id=data_source_type_id, csv_file_path=csv_file_path,
             user_external_id=user_external_id, file_name=file_name,
@@ -331,6 +332,7 @@ class CSVToContactPersonProfile(
                         contact_dict['display_as'] += " " + contact_dict['last_name']
                     if not contact_dict['display_as'] and contact_dict.get('organization'):
                         contact_dict['display_as'] += " " + contact_dict['organization']
+                    # TODO if contact_dict['display_as'] still empty raise?
 
                 # TODO process_notes( contact_dict[notes] )
 
@@ -351,6 +353,7 @@ class CSVToContactPersonProfile(
                         data_source_instance_id=data_source_instance_id,
                         data_source_type_id=data_source_type_id)
                     contact_data_by_contact_id_dict[contact_id] = contact_dict
+                # groups_linked_by_job_title = process_job_title(contact_id=contact_id, job_title=contact_dict['job_title'])
 
         return contact_data_by_contact_id_dict
 
@@ -588,7 +591,9 @@ class CSVToContactPersonProfile(
         return linked_groups_results_list
 
     def __insert_link_contact_persons(self, contact_dict: dict) -> dict:
+        # TODO create and use mandatory_fields_to_link_contact_to_person_array
         if not contact_dict.get("first_name") and not contact_dict.get("last_name"):
+            # TODO logger.warning("Can't connect contact_id= contact.display_as= contact.organization to a person as we don't have first and last name
             return {}
         phones_local = PhonesLocal(is_test_data=self.is_test_data)
         contact_phone_number = contact_dict.get("phone1")
@@ -607,7 +612,7 @@ class CSVToContactPersonProfile(
 
         return contact_person_results_dict
 
-    # TODO This method is confusing me as based on the name I was expected to to have two parameters
+    # TODO This method is confusing me, as based on the name, I was expecting to have two parameters
     # contact_dict and email_addresses but we are sending profile_id, please explain or fix
     def __insert_link_contact_email_addresses(self, contact_dict: dict) -> list[int]:
         email_addresses = self.contacts_local.get_contact_email_addresses_from_contact_dict(
@@ -719,7 +724,7 @@ class CSVToContactPersonProfile(
     # TODO merge this method with the method in google-contact-sync
     def __insert_importer(self, contact_id: int, location_id: int, user_external_id: int,
                           data_source_type_id: int, data_source_instance_id: int) -> int:
-        # TODO: Shall we consider the url of csv's as the following? Use Sql2Code. Use const enum
+        # TODO: Shall we consider the url of CSVs as the following? Use Sql2Code. Use const enum
         if data_source_type_id == CSVToContactPersonProfileConstants.GOOGLE_CSV_DATA_SOURCE_TYPE_ID:
             url = "www.google.com"
         elif data_source_type_id == CSVToContactPersonProfileConstants.OUTLOOK_CSV_DATA_SOURCE_TYPE_ID:
@@ -744,10 +749,10 @@ class CSVToContactPersonProfile(
 
         return importer_id
 
-    # TODO Move this method to ContactsLocal if not exists already
+    # TODO Move this method to ContactsLocal if not already exist
     def __procces_location_of_contact(self, contact_dict: dict) -> dict or None:
         """
-        Process location of Google contact
+        Process the location of the Google contact
         :param contact_dict: location_dict
         :return: location_dict
         """
@@ -776,6 +781,7 @@ class CSVToContactPersonProfile(
                 and not email_addresses_list):
             return
         # TODO: How can we add location type?
+        # TODO Rename to processed_location_dicts
         proccessed_location_dicts = []
         if is_contact_location1:
             location_dict = self.__create_location_dict(
@@ -941,6 +947,7 @@ class CSVToContactPersonProfile(
     @staticmethod
     # TODO Move this function to python-sdk
     def detect_encoding(file_path: str, data_source_type_id: int = None):
+        # TODO Do not use hard-coded values, get it from the data_source_type repo/package
         if data_source_type_id in [16, 17, 18]:
             detect_encodinfg_result = "utf-8"
         else:

contact_person_profile_csv_imp_local/contact_person_profile_csv_imp_local_constants.py

@@ -20,6 +20,7 @@ class CSVToContactPersonProfileConstants:
         'developer_email': DEVELOPER_EMAIL
     }
 
+    # TODO search for the source_type_id in the database and remove those constants
     GOOGLE_CSV_DATA_SOURCE_TYPE_ID = 16
     LINKEDIN_CSV_DATA_SOURCE_TYPE_ID = 18
     OUTLOOK_CSV_DATA_SOURCE_TYPE_ID = 17

{contact_person_profile_csv_imp_local-0.0.50.dist-info → contact_person_profile_csv_imp_local-0.0.51.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: contact-person-profile-csv-imp-local
-Version: 0.0.50
+Version: 0.0.51
 Summary: PyPI Package for Circles CSVToContactPersonProfile-local Local/Remote Python
 Home-page: https://github.com/circles-zone/contact-person-profile-csv-imp-local-python-package
 Author: Circles

contact_person_profile_csv_imp_local-0.0.51.dist-info/RECORD

@@ -0,0 +1,7 @@
+contact_person_profile_csv_imp_local/CSVToContactPersonProfile.py,sha256=86cINZLvSqFNFYD7Z_q-WqNoIXNX3BFkDfHJZgUYg1U,53428
+contact_person_profile_csv_imp_local/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
+contact_person_profile_csv_imp_local/contact_person_profile_csv_imp_local_constants.py,sha256=Wj_mBaolIK-h6To7YGeUGmgop5U95_Pfl7NXrob-6Ws,1264
+contact_person_profile_csv_imp_local-0.0.51.dist-info/METADATA,sha256=ZADrJdCdI_Ou9ORHltO9d8cQep0g8tHKcYaN1uYIM3I,1589
+contact_person_profile_csv_imp_local-0.0.51.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
+contact_person_profile_csv_imp_local-0.0.51.dist-info/top_level.txt,sha256=at6BnVzULDB109KZx9Cl9ClCHU4c0ykfV38WX-QR71U,37
+contact_person_profile_csv_imp_local-0.0.51.dist-info/RECORD,,

contact_person_profile_csv_imp_local-0.0.50.dist-info/RECORD

@@ -1,7 +0,0 @@
-contact_person_profile_csv_imp_local/CSVToContactPersonProfile.py,sha256=4sUZRqO8_s_uxPEB5VFbwvHvmCKqnaKW8-T49VaJZJs,52782
-contact_person_profile_csv_imp_local/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-contact_person_profile_csv_imp_local/contact_person_profile_csv_imp_local_constants.py,sha256=SsMFKnI7y3P_kQxH21rxKnX7H4MZlemBy5vuv_Ns_a4,1180
-contact_person_profile_csv_imp_local-0.0.50.dist-info/METADATA,sha256=sI9EXLOEYRrGb19fOKD-VLs1feswm8JL06rHFQ5JmpM,1589
-contact_person_profile_csv_imp_local-0.0.50.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
-contact_person_profile_csv_imp_local-0.0.50.dist-info/top_level.txt,sha256=at6BnVzULDB109KZx9Cl9ClCHU4c0ykfV38WX-QR71U,37
-contact_person_profile_csv_imp_local-0.0.50.dist-info/RECORD,,