conson-xp 1.41.0__py3-none-any.whl → 1.44.0__py3-none-any.whl

{conson_xp-1.41.0.dist-info → conson_xp-1.44.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: conson-xp
-Version: 1.41.0
+Version: 1.44.0
 Summary: XP Protocol Communication Tools
 Author-Email: ldvchosal <ldvchosal@github.com>
 License: MIT License
@@ -49,6 +49,7 @@ Requires-Dist: twisted>=25.5.0
 Requires-Dist: bubus>=1.5.6
 Requires-Dist: psygnal>=0.15.0
 Requires-Dist: textual>=1.0.0
+Requires-Dist: python-statemachine>=2.5.0
 Description-Content-Type: text/markdown
 
 # 🔌 XP Protocol Communication Tool

{conson_xp-1.41.0.dist-info → conson_xp-1.44.0.dist-info}/RECORD

@@ -1,14 +1,14 @@
-conson_xp-1.41.0.dist-info/METADATA,sha256=pML1FepvoeR1ktngrS69ieWa5rMO0j43m8BC22G_UW0,11361
-conson_xp-1.41.0.dist-info/WHEEL,sha256=tsUv_t7BDeJeRHaSrczbGeuK-TtDpGsWi_JfpzD255I,90
-conson_xp-1.41.0.dist-info/entry_points.txt,sha256=1OcdIcDM1hz3ljCXgybaPUh1IOFEwkaTgLIW9u9zGeg,50
-conson_xp-1.41.0.dist-info/licenses/LICENSE,sha256=rxj6woMM-r3YCyGq_UHFtbh7kHTAJgrccH6O-33IDE4,1419
-xp/__init__.py,sha256=fIc-tmd56J8tWGwB8NrHfsUhz6rBuPHOZmnmWfimedo,181
+conson_xp-1.44.0.dist-info/METADATA,sha256=_XnV63YzozzZlbnPRlvU5adBIY6s7pZq0yZR6xNaVNc,11403
+conson_xp-1.44.0.dist-info/WHEEL,sha256=tsUv_t7BDeJeRHaSrczbGeuK-TtDpGsWi_JfpzD255I,90
+conson_xp-1.44.0.dist-info/entry_points.txt,sha256=1OcdIcDM1hz3ljCXgybaPUh1IOFEwkaTgLIW9u9zGeg,50
+conson_xp-1.44.0.dist-info/licenses/LICENSE,sha256=rxj6woMM-r3YCyGq_UHFtbh7kHTAJgrccH6O-33IDE4,1419
+xp/__init__.py,sha256=_M4wR8pgjr7q-i0BO0eRQ8Tx1cbV_kmviwFhqlqRnYQ,181
 xp/cli/__init__.py,sha256=QjnKB1KaI2aIyKlzrnvCwfbBuUj8HNgwNMvNJVQofbI,81
 xp/cli/__main__.py,sha256=l2iKwMdat5rTGd3JWs-uGksnYYDDffp_Npz05QdKEeU,117
 xp/cli/commands/__init__.py,sha256=G7A1KFRSV0CEeDTqr_khu-K9_sc01CTI2KSfkFcaBRM,4949
 xp/cli/commands/conbus/__init__.py,sha256=HYaX2__XxwD3Xaw4CzflvL8CwoUa4yR6wOyH8wwyofM,535
 xp/cli/commands/conbus/conbus.py,sha256=1j9-Nwnf6nqD4ztBZnZEbJOTlkYo4D-Ks2J7BGNF3MU,3575
-xp/cli/commands/conbus/conbus_actiontable_commands.py,sha256=fIEe45iMWZ3Dbr0STzO8qbtWHR-R8qpGa_sLNeBm_og,7471
+xp/cli/commands/conbus/conbus_actiontable_commands.py,sha256=yLVSADwei7tX6JFa25TCpTxyMHyNJfWlDFqpR8AGRmo,7657
 xp/cli/commands/conbus/conbus_autoreport_commands.py,sha256=TgXFVpoyFNiEatL6r78IghzyF0R2S3cgTrGZaiJPjwA,3934
 xp/cli/commands/conbus/conbus_blink_commands.py,sha256=HRn4Lr_BO7_WynsaUnO_hKezOi3MVhkPYEOnh0rMMlg,5324
 xp/cli/commands/conbus/conbus_config_commands.py,sha256=BugIbgNX6_s4MySGvI6tWZkwguciajHUX2Xz8XBux7k,716
@@ -121,7 +121,7 @@ xp/services/actiontable/msactiontable_xp24_serializer.py,sha256=ku84HCCjYDM9XpRK
 xp/services/actiontable/msactiontable_xp33_serializer.py,sha256=MFjEwSsIa8l3RJt-ig828E6kyiFYYXMHFKe4Q0A3NvA,8781
 xp/services/conbus/__init__.py,sha256=Hi35sMKu9o6LpYoi2tQDaQoMb8M5sOt_-LUTxxaCU_0,28
 xp/services/conbus/actiontable/__init__.py,sha256=oD6vRk_Ye-eZ9s_hldAgtRJFu4mfAnODqpkJUGHHszk,40
-xp/services/conbus/actiontable/actiontable_download_service.py,sha256=C6cjNRRsl7_jjn94I6ycCDvoqIpivNv0cMVkR-CQBXk,7608
+xp/services/conbus/actiontable/actiontable_download_service.py,sha256=RMGC3WxlMQDJkkXy3oKmqkORrXNwQyjDkyfEGWX3JJE,21294
 xp/services/conbus/actiontable/actiontable_list_service.py,sha256=BYNpxdhdVvn5Z3XXvUYyiGGZ3fOoKR1F0boYDfAQ80c,2894
 xp/services/conbus/actiontable/actiontable_show_service.py,sha256=Z11bVYstnIhahFKTL8WqgTmK8rMK6kvismdy7679ojY,3013
 xp/services/conbus/actiontable/actiontable_upload_service.py,sha256=HTWJqJTIDFsp5v0SBx1Wt5gUeso6w03N6bKbtsbHtJY,9705
@@ -161,7 +161,7 @@ xp/services/homekit/homekit_service.py,sha256=0lW-hg40ETco3gDBEYkR_sX-UIYsLSKCD4
 xp/services/log_file_service.py,sha256=fvPcZQj8XOKUA-4ep5R8n0PelvwvRlTLlVxvIWM5KR4,10506
 xp/services/module_type_service.py,sha256=xWhr1EAZMykL5uNWHWdpa5T8yNruGKH43XRTOS8GwZg,7477
 xp/services/protocol/__init__.py,sha256=qRufBmqRKGzpuzZ5bxBbmwf510TT00Ke8s5HcWGnqRY,818
-xp/services/protocol/conbus_event_protocol.py,sha256=PpSr5sWcibN_xb2iMWAtWc0dTkUkFZelgYuPiejutkE,15155
+xp/services/protocol/conbus_event_protocol.py,sha256=XjdVwy7P87Utu_UqK7upfugrA5fYG2iWBwC4go9KFLY,15498
 xp/services/protocol/conbus_protocol.py,sha256=JO7yLkD_ohPT0ETjnAIx4CGpZyobf4LdbuozM_43btE,10276
 xp/services/protocol/protocol_factory.py,sha256=PmjN9AtW9sxNo3voqUiNgQA-pTvX1RW4XXFlHKfFr5Q,2470
 xp/services/protocol/telegram_protocol.py,sha256=Ki5DrXsKxiaqLcdP9WWUuhUI7cPu2DfwyZkh-Gv9Lb8,9496
@@ -171,7 +171,7 @@ xp/services/server/base_server_service.py,sha256=B-ntxp3swbwuri-9_2EuvBDi-4Uo9AH
 xp/services/server/client_buffer_manager.py,sha256=1d_MqfzuUqBwaQUiC1n5K76WwSxrdngYAmNH7he6u3o,2235
 xp/services/server/cp20_server_service.py,sha256=SXdI6Jt400T9sLdw86ovEqKRGeV3nYVaHEA9Gcj6W2A,2041
 xp/services/server/device_service_factory.py,sha256=Y4TvSFALeq0zYzHfCwcbikSpmIyYbLcvm9756n5Jm7Q,3744
-xp/services/server/server_service.py,sha256=YAkn3rxNYnxs3E1Dpwtt3ZzymFXZHKEz8Nitim-Xewg,16300
+xp/services/server/server_service.py,sha256=2jMrL-Azn7KaqpgSI1ztBh0UD3JWom5ns33IkqMCDac,16302
 xp/services/server/xp130_server_service.py,sha256=YnvetDp72-QzkyDGB4qfZZIwFs03HuibUOz2zb9XR0c,2191
 xp/services/server/xp20_server_service.py,sha256=1wJ7A-bRkN9O5Spu3q3LNDW31mNtNF2eNMQ5E6O2ltA,2928
 xp/services/server/xp230_server_service.py,sha256=k9ftCY5tjLFP31mKVCspq283RVaPkGx-Yq61Urk8JLs,1815
@@ -207,4 +207,4 @@ xp/utils/logging.py,sha256=rZDXwlBrYK8A6MPq5StsMNpgsRowzJXM6fvROPwJdGM,3750
 xp/utils/serialization.py,sha256=RWHHk86feaB4ZP7rjE4qOWK0900yg2joUBDkP76gfOY,4618
 xp/utils/state_machine.py,sha256=Oe2sLwCh9z_vr1tF6X0ZRGTeuckRQAGzmef7xc9CNdc,2413
 xp/utils/time_utils.py,sha256=dEyViDlAG9GWU-J3D_YVa-sGma6yiyyMTgN4h2x3PY4,3781
-conson_xp-1.41.0.dist-info/RECORD,,
+conson_xp-1.44.0.dist-info/RECORD,,

xp/__init__.py

@@ -3,7 +3,7 @@
 conson-xp package.
 """
 
-__version__ = "1.41.0"
+__version__ = "1.44.0"
 __manufacturer__ = "salchichon"
 __model__ = "xp.cli"
 __serial__ = "2025.09.23.000"

xp/cli/commands/conbus/conbus_actiontable_commands.py

@@ -61,7 +61,7 @@ def conbus_download_actiontable(ctx: Context, serial_number: str) -> None:
         """
         click.echo(progress, nl=False)
 
-    def on_finish(
+    def on_actiontable_received(
         _actiontable: ActionTable,
         actiontable_dict: Dict[str, Any],
         actiontable_short: list[str],
@@ -79,6 +79,9 @@ def conbus_download_actiontable(ctx: Context, serial_number: str) -> None:
             "actiontable": actiontable_dict,
         }
         click.echo(json.dumps(output, indent=2, default=str))
+
+    def on_finish() -> None:
+        """Handle successful completion of action table download."""
         service.stop_reactor()
 
     def on_error(error: str) -> None:
@@ -93,6 +96,7 @@ def conbus_download_actiontable(ctx: Context, serial_number: str) -> None:
     with service:
         service.on_progress.connect(on_progress)
         service.on_finish.connect(on_finish)
+        service.on_actiontable_received.connect(on_actiontable_received)
         service.on_error.connect(on_error)
         service.start(serial_number=serial_number)
         service.start_reactor()

xp/services/conbus/actiontable/actiontable_download_service.py

@@ -2,36 +2,146 @@
 
 import logging
 from dataclasses import asdict
-from typing import Any, Dict, Optional
+from enum import Enum
+from typing import Any, Optional
 
-from psygnal import Signal
+from psygnal import SignalInstance
+from statemachine import State, StateMachine
 
 from xp.models.actiontable.actiontable import ActionTable
 from xp.models.protocol.conbus_protocol import TelegramReceivedEvent
+from xp.models.telegram.datapoint_type import DataPointType
+from xp.models.telegram.reply_telegram import ReplyTelegram
 from xp.models.telegram.system_function import SystemFunction
 from xp.models.telegram.telegram_type import TelegramType
 from xp.services.actiontable.actiontable_serializer import ActionTableSerializer
 from xp.services.protocol.conbus_event_protocol import ConbusEventProtocol
 from xp.services.telegram.telegram_service import TelegramService
 
+# Constants
+NO_ERROR_CODE = "00"
+CHUNK_HEADER_LENGTH = 2  # data_value format: 2-char counter + actiontable chunk
+MAX_ERROR_RETRIES = 3  # Max retries for error_status_received before giving up
 
-class ActionTableDownloadService:
-    """TCP client service for downloading action tables from Conbus modules.
 
-    Manages TCP socket connections, handles telegram generation and transmission,
-    and processes server responses for action table downloads.
+class Phase(Enum):
+    """Download workflow phases.
+
+    The download workflow consists of three sequential phases:
+    - INIT: Drain pending telegrams, query error status → proceed to DOWNLOAD
+    - DOWNLOAD: Request actiontable, receive chunks with ACK, until EOF
+    - CLEANUP: Drain pending telegrams, query error status → proceed to COMPLETED
 
     Attributes:
-        on_progress: Signal emitted with telegram frame when progress is made.
-        on_error: Signal emitted with error message string when an error occurs.
-        on_finish: Signal emitted with (ActionTable, Dict[str, Any], list[str]) when complete.
+        INIT: Initial phase - drain pending telegrams and query error status.
+        DOWNLOAD: Download phase - request actiontable and receive chunks.
+        CLEANUP: Cleanup phase - drain remaining telegrams and verify status.
     """
 
-    on_progress: Signal = Signal(str)
-    on_error: Signal = Signal(str)
-    on_finish: Signal = Signal(
-        ActionTable, Dict[str, Any], list[str]
-    )  # (ActionTable, Dict[str, Any], list[str])
+    INIT = "init"
+    DOWNLOAD = "download"
+    CLEANUP = "cleanup"
+
+
+class ActionTableDownloadService(StateMachine):
+    """Service for downloading action tables from Conbus modules via TCP.
+
+    Inherits from StateMachine - the service IS the state machine. Uses guard
+    conditions to share states between INIT and CLEANUP phases.
+    see: Download-ActionTable-Workflow.dot
+
+    States (9 total):
+        idle -> receiving -> resetting -> waiting_ok -> requesting
+             -> waiting_data <-> receiving_chunk -> processing_eof -> completed
+
+    Phases - INIT and CLEANUP share the same states (receiving, resetting, waiting_ok):
+
+    INIT phase (drain → reset → wait_ok):
+        idle -> receiving -> resetting -> waiting_ok --(guard: is_init_phase)--> requesting
+
+    DOWNLOAD phase (request → receive chunks → EOF):
+        requesting -> waiting_data <-> receiving_chunk -> processing_eof
+
+    CLEANUP phase (drain → reset → wait_ok):
+        processing_eof -> receiving -> resetting -> waiting_ok --(guard: is_cleanup_phase)--> completed
+
+    The drain/reset/wait_ok cycle:
+    1. Drain pending telegrams (receiving state discards telegram without reading them).
+       There may be a lot of telegram. We are listening and receiving until no more
+       telegram arrive and timeout occurs.
+    2. Timeout triggers error status query (resetting)
+    3. Wait for response (waiting_ok)
+    4. On no error: guard determines target (requesting or completed)
+       On error: retry from drain step
+
+    Attributes:
+        on_progress: Signal emitted with "." for each chunk received.
+        on_error: Signal emitted with error message string.
+        on_actiontable_received: Signal emitted with (ActionTable, dict, list).
+        on_finish: Signal emitted when download and cleanup completed.
+        idle: Initial state - waiting for connection.
+        receiving: Drain telegrams state (INIT or CLEANUP phase).
+        resetting: Query error status state.
+        waiting_ok: Await error status response state.
+        requesting: DOWNLOAD phase - send download request state.
+        waiting_data: DOWNLOAD phase - await chunks state.
+        receiving_chunk: DOWNLOAD phase - process chunk state.
+        processing_eof: DOWNLOAD phase - deserialize result state.
+        completed: Final state - download finished.
+        do_connect: Transition from idle to receiving.
+        filter_telegram: Self-transition in receiving to drain telegrams.
+        do_timeout: Transition on timeout events.
+        send_error_status: Transition from resetting to waiting_ok.
+        error_status_received: Transition when error status is received.
+        no_error_status_received: Transition when no error status received.
+        send_download: Transition from requesting to waiting_data.
+        receive_chunk: Transition from waiting_data to receiving_chunk.
+        send_ack: Transition from receiving_chunk to waiting_data.
+        receive_eof: Transition from waiting_data to processing_eof.
+        do_finish: Transition from processing_eof to receiving (cleanup).
+
+    Example:
+        >>> with download_service as service:
+        ...     service.configure(serial_number="12345678")
+        ...     service.on_actiontable_received.connect(handle_result)
+        ...     service.start_reactor()
+    """
+
+    # States - unified for INIT and CLEANUP phases using guards
+    idle = State(initial=True)
+    receiving = State()  # Drain telegrams (INIT or CLEANUP phase)
+    resetting = State()  # Query error status
+    waiting_ok = State()  # Await error status response
+
+    requesting = State()  # DOWNLOAD phase: send download request
+    waiting_data = State()  # DOWNLOAD phase: await chunks
+    receiving_chunk = State()  # DOWNLOAD phase: process chunk
+    processing_eof = State()  # DOWNLOAD phase: deserialize result
+
+    completed = State(final=True)
+
+    # Phase transitions - shared states with guards for phase-dependent routing
+    do_connect = idle.to(receiving)
+    filter_telegram = receiving.to(receiving)  # Self-transition: drain to /dev/null
+    do_timeout = receiving.to(resetting) | waiting_ok.to(receiving)
+    send_error_status = resetting.to(waiting_ok)
+    error_status_received = waiting_ok.to(
+        receiving, cond="can_retry"
+    )  # Retry if under limit
+
+    # Conditional transitions based on phase
+    no_error_status_received = waiting_ok.to(
+        requesting, cond="is_init_phase"
+    ) | waiting_ok.to(completed, cond="is_cleanup_phase")
+
+    # DOWNLOAD phase transitions
+    send_download = requesting.to(waiting_data)
+    receive_chunk = waiting_data.to(receiving_chunk)
+    send_ack = receiving_chunk.to(waiting_data)
+    receive_eof = waiting_data.to(processing_eof)
+
+    # Return to drain/reset cycle for CLEANUP phase
+    do_finish = processing_eof.to(receiving)
 
     def __init__(
         self,
@@ -51,29 +161,133 @@ class ActionTableDownloadService:
         self.telegram_service = telegram_service
         self.serial_number: str = ""
         self.actiontable_data: list[str] = []
-        # Set up logging
         self.logger = logging.getLogger(__name__)
+        self._phase: Phase = Phase.INIT
+        self._error_retry_count: int = 0
+        self._signals_connected: bool = False
+
+        # Signals (instance attributes to avoid conflict with statemachine)
+        self.on_progress: SignalInstance = SignalInstance((str,))
+        self.on_error: SignalInstance = SignalInstance((str,))
+        self.on_finish: SignalInstance = SignalInstance()
+        self.on_actiontable_received: SignalInstance = SignalInstance(
+            (ActionTable, dict[str, Any], list[str])
+        )
+
+        # Initialize state machine first (before connecting signals)
+        super().__init__(allow_event_without_transition=True)
 
         # Connect protocol signals
-        self.conbus_protocol.on_connection_made.connect(self.connection_made)
-        self.conbus_protocol.on_telegram_sent.connect(self.telegram_sent)
-        self.conbus_protocol.on_telegram_received.connect(self.telegram_received)
-        self.conbus_protocol.on_timeout.connect(self.timeout)
-        self.conbus_protocol.on_failed.connect(self.failed)
+        self._connect_signals()
 
-    def connection_made(self) -> None:
-        """Handle connection established event."""
-        self.logger.debug(
-            "Connection established, sending download actiontable telegram"
+    # Guard conditions for phase-dependent transitions
+
+    def is_init_phase(self) -> bool:
+        """Guard: check if currently in INIT phase.
+
+        Returns:
+            True if in INIT phase, False otherwise.
+        """
+        return self._phase == Phase.INIT
+
+    def is_cleanup_phase(self) -> bool:
+        """Guard: check if currently in CLEANUP phase.
+
+        Returns:
+            True if in CLEANUP phase, False otherwise.
+        """
+        return self._phase == Phase.CLEANUP
+
+    def can_retry(self) -> bool:
+        """Guard: check if retry is allowed (under max limit).
+
+        Returns:
+            True if retry count is below MAX_ERROR_RETRIES, False otherwise.
+        """
+        return self._error_retry_count < MAX_ERROR_RETRIES
+
+    # State machine lifecycle hooks
+    # Note: receiving state is used to drain pending telegrams from the connection
+    # pipe. Any telegram received in this state is intentionally discarded (sent
+    # to /dev/null) to ensure a clean state before processing.
+
+    def on_enter_receiving(self) -> None:
+        """Enter receiving state - drain pending telegrams."""
+        self.logger.debug(f"Entering RECEIVING state (phase={self._phase.value})")
+        self.conbus_protocol.wait()
+
+    def on_enter_resetting(self) -> None:
+        """Enter resetting state - query error status."""
+        self.logger.debug(f"Entering RESETTING state (phase={self._phase.value})")
+        self.conbus_protocol.send_telegram(
+            telegram_type=TelegramType.SYSTEM,
+            serial_number=self.serial_number,
+            system_function=SystemFunction.READ_DATAPOINT,
+            data_value=DataPointType.MODULE_ERROR_CODE.value,
         )
+        self.send_error_status()
+
+    def on_enter_waiting_ok(self) -> None:
+        """Enter waiting_ok state - awaiting error status response."""
+        self.logger.debug(f"Entering WAITING_OK state (phase={self._phase.value})")
+        self.conbus_protocol.wait()
+
+    def on_enter_requesting(self) -> None:
+        """Enter requesting state - send download request."""
+        self._phase = Phase.DOWNLOAD
+        self.logger.debug("Entering REQUESTING state - sending download request")
         self.conbus_protocol.send_telegram(
             telegram_type=TelegramType.SYSTEM,
             serial_number=self.serial_number,
             system_function=SystemFunction.DOWNLOAD_ACTIONTABLE,
-            data_value="00",
+            data_value=NO_ERROR_CODE,
         )
+        self.send_download()
+
+    def on_enter_waiting_data(self) -> None:
+        """Enter waiting_data state - wait for actiontable chunks."""
+        self.logger.debug("Entering WAITING_DATA state - awaiting chunks")
+        self.conbus_protocol.wait()
+
+    def on_enter_receiving_chunk(self) -> None:
+        """Enter receiving_chunk state - send ACK."""
+        self.logger.debug("Entering RECEIVING_CHUNK state - sending ACK")
+        self.conbus_protocol.send_telegram(
+            telegram_type=TelegramType.SYSTEM,
+            serial_number=self.serial_number,
+            system_function=SystemFunction.ACK,
+            data_value=NO_ERROR_CODE,
+        )
+        self.send_ack()
+
+    def on_enter_processing_eof(self) -> None:
+        """Enter processing_eof state - deserialize and emit result, then cleanup."""
+        self.logger.debug("Entering PROCESSING_EOF state - deserializing")
+        all_data = "".join(self.actiontable_data)
+        actiontable = self.serializer.from_encoded_string(all_data)
+        actiontable_dict = asdict(actiontable)
+        actiontable_short = self.serializer.format_decoded_output(actiontable)
+        self.on_actiontable_received.emit(
+            actiontable, actiontable_dict, actiontable_short
+        )
+        # Switch to CLEANUP phase before returning to receiving state
+        self._phase = Phase.CLEANUP
+        self.do_finish()
+
+    def on_enter_completed(self) -> None:
+        """Enter completed state - download finished."""
+        self.logger.debug("Entering COMPLETED state - download finished")
+        self.on_finish.emit()
+
+    # Protocol event handlers
 
-    def telegram_sent(self, telegram_sent: str) -> None:
+    def _on_connection_made(self) -> None:
+        """Handle connection established event."""
+        self.logger.debug("Connection made")
+        if self.idle.is_active:
+            self.do_connect()
+
+    def _on_telegram_sent(self, telegram_sent: str) -> None:
         """Handle telegram sent event.
 
         Args:
@@ -81,59 +295,128 @@ class ActionTableDownloadService:
         """
         self.logger.debug(f"Telegram sent: {telegram_sent}")
 
-    def telegram_received(self, telegram_received: TelegramReceivedEvent) -> None:
+    def _on_read_datapoint_received(self, reply_telegram: ReplyTelegram) -> None:
+        """Handle READ_DATAPOINT response for error status check.
+
+        Args:
+            reply_telegram: The parsed reply telegram.
+        """
+        self.logger.debug(f"Received READ_DATAPOINT in {self.current_state}")
+
+        if reply_telegram.datapoint_type != DataPointType.MODULE_ERROR_CODE:
+            self.logger.debug(
+                f"Filtered: not a MODULE_ERROR_CODE (got {reply_telegram.datapoint_type})"
+            )
+            return
+
+        if not self.waiting_ok.is_active:
+            return
+
+        is_no_error = reply_telegram.data_value == NO_ERROR_CODE
+        if is_no_error:
+            self._error_retry_count = 0  # Reset on success
+            self.no_error_status_received()  # Guards determine target state
+        else:
+            self._error_retry_count += 1
+            self.logger.debug(
+                f"Error status received, retry {self._error_retry_count}/{MAX_ERROR_RETRIES}"
+            )
+            # Guard can_retry blocks transition if max retries exceeded
+            self.error_status_received()
+            # Check if guard blocked the transition (still in waiting_ok)
+            if self.waiting_ok.is_active:
+                self.logger.error(
+                    f"Max error retries ({MAX_ERROR_RETRIES}) exceeded, giving up"
+                )
+                self.on_error.emit(
+                    f"Module error persists after {MAX_ERROR_RETRIES} retries"
+                )
+
+    def _on_actiontable_chunk_received(self, reply_telegram: ReplyTelegram) -> None:
+        """Handle actiontable chunk telegram received.
+
+        Args:
+            reply_telegram: The parsed reply telegram containing chunk data.
+        """
+        self.logger.debug(f"Received actiontable chunk in {self.current_state}")
+        if self.waiting_data.is_active:
+            data_part = reply_telegram.data_value[CHUNK_HEADER_LENGTH:]
+            self.actiontable_data.append(data_part)
+            self.on_progress.emit(".")
+            self.receive_chunk()
+
+    def _on_eof_received(self, _reply_telegram: ReplyTelegram) -> None:
+        """Handle EOF telegram received.
+
+        Args:
+            _reply_telegram: The parsed reply telegram (unused).
+        """
+        self.logger.debug(f"Received EOF in {self.current_state}")
+        if self.waiting_data.is_active:
+            self.receive_eof()
+
+    def _on_telegram_received(self, telegram_received: TelegramReceivedEvent) -> None:
         """Handle telegram received event.
 
         Args:
             telegram_received: The telegram received event.
         """
-        self.logger.debug(f"Telegram received: {telegram_received}")
-        if (
-            not telegram_received.checksum_valid
-            or telegram_received.telegram_type != TelegramType.REPLY.value
-            or telegram_received.serial_number != self.serial_number
-        ):
-            self.logger.debug("Not a reply response")
+        self.logger.debug(f"Received {telegram_received} in {self.current_state}")
+
+        # In receiving state, drain pending telegrams from pipe (discard to /dev/null).
+        # This ensures clean state before processing by clearing any stale messages.
+        if self.receiving.is_active:
+            self.filter_telegram()
+            return
+
+        # Filter invalid telegrams
+        if not telegram_received.checksum_valid:
+            self.logger.debug("Filtered: invalid checksum")
+            return
+
+        if telegram_received.telegram_type != TelegramType.REPLY.value:
+            self.logger.debug(
+                f"Filtered: not a reply (got {telegram_received.telegram_type})"
+            )
+            return
+
+        if telegram_received.serial_number != self.serial_number:
+            self.logger.debug(
+                f"Filtered: wrong serial {telegram_received.serial_number} != {self.serial_number}"
+            )
             return
 
         reply_telegram = self.telegram_service.parse_reply_telegram(
             telegram_received.frame
         )
-        if reply_telegram.system_function not in (
-            SystemFunction.ACTIONTABLE,
-            SystemFunction.EOF,
-        ):
-            self.logger.debug("Not a actiontable response")
+
+        if reply_telegram.system_function == SystemFunction.READ_DATAPOINT:
+            self._on_read_datapoint_received(reply_telegram)
             return
 
         if reply_telegram.system_function == SystemFunction.ACTIONTABLE:
-            self.logger.debug("Saving actiontable response")
-            data_part = reply_telegram.data_value[2:]
-            self.actiontable_data.append(data_part)
-            self.on_progress.emit(".")
-
-            self.conbus_protocol.send_telegram(
-                telegram_type=TelegramType.SYSTEM,
-                serial_number=self.serial_number,
-                system_function=SystemFunction.ACK,
-                data_value="00",
-            )
+            self._on_actiontable_chunk_received(reply_telegram)
             return
 
         if reply_telegram.system_function == SystemFunction.EOF:
-            all_data = "".join(self.actiontable_data)
-            # Deserialize from received data
-            actiontable = self.serializer.from_encoded_string(all_data)
-            actiontable_dict = asdict(actiontable)
-            actiontable_short = self.serializer.format_decoded_output(actiontable)
-            self.on_finish.emit(actiontable, actiontable_dict, actiontable_short)
-
-    def timeout(self) -> None:
-        """Handle timeout event."""
-        self.logger.debug("Timeout occurred")
-        self.failed("Timeout")
+            self._on_eof_received(reply_telegram)
+            return
 
-    def failed(self, message: str) -> None:
+    def _on_timeout(self) -> None:
+        """Handle timeout event."""
+        self.logger.debug(f"Timeout occurred (phase={self._phase.value})")
+        if self.receiving.is_active:
+            self.do_timeout()  # receiving -> resetting
+        elif self.waiting_ok.is_active:
+            self.do_timeout()  # waiting_ok -> receiving (retry)
+        elif self.waiting_data.is_active:
+            self.logger.error("Timeout waiting for actiontable data")
+            self.on_error.emit("Timeout waiting for actiontable data")
+        else:
+            self.logger.debug("Timeout in non-recoverable state")
+            self.on_error.emit("Timeout")
+
+    def _on_failed(self, message: str) -> None:
         """Handle failed connection event.
 
         Args:
@@ -142,22 +425,31 @@ class ActionTableDownloadService:
         self.logger.debug(f"Failed: {message}")
         self.on_error.emit(message)
 
-    def start(
+    # Public API
+
+    def configure(
         self,
         serial_number: str,
-        timeout_seconds: Optional[float] = None,
+        timeout_seconds: Optional[float] = 2.0,
     ) -> None:
-        """Run reactor in dedicated thread with its own event loop.
+        """Configure download parameters before starting.
+
+        Sets the target module serial number and timeout. Call this before
+        start_reactor() to configure the download target.
 
         Args:
-            serial_number: Module serial number.
-            timeout_seconds: Optional timeout in seconds.
+            serial_number: Module serial number to download from.
+            timeout_seconds: Timeout in seconds for each operation (default 2.0).
+
+        Raises:
+            RuntimeError: If called while download is in progress.
         """
-        self.logger.info("Starting actiontable")
+        if not self.idle.is_active:
+            raise RuntimeError("Cannot configure while download in progress")
+        self.logger.info("Configuring actiontable download")
         self.serial_number = serial_number
         if timeout_seconds:
             self.conbus_protocol.timeout_seconds = timeout_seconds
-        # Caller invokes start_reactor()
 
     def set_timeout(self, timeout_seconds: float) -> None:
         """Set operation timeout.
@@ -175,29 +467,59 @@ class ActionTableDownloadService:
         """Stop the reactor."""
         self.conbus_protocol.stop_reactor()
 
+    def _connect_signals(self) -> None:
+        """Connect protocol signals to handlers (idempotent)."""
+        if self._signals_connected:
+            return
+        self.conbus_protocol.on_connection_made.connect(self._on_connection_made)
+        self.conbus_protocol.on_telegram_sent.connect(self._on_telegram_sent)
+        self.conbus_protocol.on_telegram_received.connect(self._on_telegram_received)
+        self.conbus_protocol.on_timeout.connect(self._on_timeout)
+        self.conbus_protocol.on_failed.connect(self._on_failed)
+        self._signals_connected = True
+
+    def _disconnect_signals(self) -> None:
+        """Disconnect protocol signals from handlers (idempotent)."""
+        if not self._signals_connected:
+            return
+        self.conbus_protocol.on_connection_made.disconnect(self._on_connection_made)
+        self.conbus_protocol.on_telegram_sent.disconnect(self._on_telegram_sent)
+        self.conbus_protocol.on_telegram_received.disconnect(self._on_telegram_received)
+        self.conbus_protocol.on_timeout.disconnect(self._on_timeout)
+        self.conbus_protocol.on_failed.disconnect(self._on_failed)
+        self._signals_connected = False
+
     def __enter__(self) -> "ActionTableDownloadService":
-        """Enter context manager - reset state for singleton reuse.
+        """Enter context manager - reset state and reconnect signals.
 
         Returns:
             Self for context manager protocol.
         """
         # Reset state for singleton reuse
         self.actiontable_data = []
+        self._phase = Phase.INIT
+        self._error_retry_count = 0
+        # Reset state machine to idle
+        self._reset_state()
+        # Reconnect signals (in case previously disconnected)
+        self._connect_signals()
         return self
 
+    def _reset_state(self) -> None:
+        """Reset state machine to initial state."""
+        # python-statemachine uses model.state to track current state
+        # Set it directly to the initial state id
+        self.model.state = self.idle.id
+
     def __exit__(
         self, _exc_type: Optional[type], _exc_val: Optional[Exception], _exc_tb: Any
     ) -> None:
         """Exit context manager and disconnect signals."""
-        # Disconnect protocol signals
-        self.conbus_protocol.on_connection_made.disconnect(self.connection_made)
-        self.conbus_protocol.on_telegram_sent.disconnect(self.telegram_sent)
-        self.conbus_protocol.on_telegram_received.disconnect(self.telegram_received)
-        self.conbus_protocol.on_timeout.disconnect(self.timeout)
-        self.conbus_protocol.on_failed.disconnect(self.failed)
+        self._disconnect_signals()
         # Disconnect service signals
         self.on_progress.disconnect()
         self.on_error.disconnect()
+        self.on_actiontable_received.disconnect()
         self.on_finish.disconnect()
         # Stop reactor
         self.stop_reactor()

xp/services/protocol/conbus_event_protocol.py

@@ -103,6 +103,16 @@ class ConbusEventProtocol(protocol.Protocol, protocol.ClientFactory):
         # Start inactivity timeout
         self._reset_timeout()
 
+    def wait(self, wait_timeout: Optional[float] = None) -> None:
+        """Wait for incoming telegrams with optional timeout override.
+
+        Args:
+            wait_timeout: Optional timeout in seconds to override default.
+        """
+        if wait_timeout:
+            self.timeout_seconds = wait_timeout
+        self._reset_timeout()
+
     def dataReceived(self, data: bytes) -> None:
         """Handle received data from TCP connection.
 

xp/services/server/server_service.py

@@ -337,7 +337,7 @@ class ServerService:
                 self.logger.warning(f"Failed to parse telegram: {telegram}")
                 return responses
 
-            self.client_buffers.broadcast(parsed_telegram.raw_telegram)
+            # self.client_buffers.broadcast(parsed_telegram.raw_telegram)
 
             # Handle discover requests
             if self.discover_service.is_discover_request(parsed_telegram):