commonmeta-py 0.131__py3-none-any.whl → 0.132__py3-none-any.whl

commonmeta/__init__.py

@@ -10,7 +10,7 @@ commonmeta-py is a Python library to convert scholarly metadata
 """
 
 __title__ = "commonmeta-py"
-__version__ = "0.131"
+__version__ = "0.132"
 __author__ = "Martin Fenner"
 __license__ = "MIT"
 

commonmeta/writers/crossref_xml_writer.py

@@ -4,7 +4,7 @@ import io
 import logging
 from datetime import datetime
 from time import time
-from typing import Optional
+from typing import Dict, Optional
 
 import orjson as json
 import requests
@@ -390,25 +390,25 @@ def write_crossref_xml_list(metalist) -> Optional[str]:
 
 
 def push_crossref_xml_list(
-    metalist, login_id: str, login_passwd: str, legacy_key: str = None
-) -> bytes:
+    metalist, login_id: str, login_passwd: str, legacy_key: Optional[str] = None
+) -> str:
     """Push crossref_xml list to Crossref API, returns the API response."""
 
-    input = write_crossref_xml_list(metalist)
-    if not input:
+    input_xml = write_crossref_xml_list(metalist)
+    if not input_xml:
         logger.error("Failed to generate XML for upload")
         return "{}"
 
     # Convert string to bytes if necessary
-    if isinstance(input, str):
-        input = input.encode("utf-8")
+    if isinstance(input_xml, str):
+        input_xml = input_xml.encode("utf-8")
 
     # The filename displayed in the Crossref admin interface
     filename = f"{int(time())}"
 
     multipart_data = MultipartEncoder(
         fields={
-            "fname": (filename, io.BytesIO(input), "application/xml"),
+            "fname": (filename, io.BytesIO(input_xml), "application/xml"),
             "operation": "doMDUpload",
             "login_id": login_id,
             "login_passwd": login_passwd,
@@ -417,16 +417,25 @@ def push_crossref_xml_list(
 
     post_url = "https://doi.crossref.org/servlet/deposit"
     headers = {"Content-Type": multipart_data.content_type}
-    resp = requests.post(post_url, data=multipart_data, headers=headers, timeout=10)
-    resp.raise_for_status()
+
+    try:
+        resp = requests.post(post_url, data=multipart_data, headers=headers, timeout=30)
+        resp.raise_for_status()
+    except requests.exceptions.RequestException as e:
+        logger.error(f"Failed to upload to Crossref: {e}")
+        return "{}"
 
     # Parse the response
-    response = parse_xml(resp.content)
-    status = py_.get(response, "html.body.h2")
-    if status != "SUCCESS":
-        # Handle error response
-        message = py_.get(response, "html.body.p")
-        logger.error(f"Crossref API error: {message}")
+    try:
+        response = parse_xml(resp.content)
+        status = py_.get(response, "html.body.h2")
+        if status != "SUCCESS":
+            # Handle error response
+            message = py_.get(response, "html.body.p")
+            logger.error(f"Crossref API error: {message}")
+            return "{}"
+    except Exception as e:
+        logger.error(f"Failed to parse Crossref response: {e}")
         return "{}"
 
     items = []
@@ -439,12 +448,16 @@ def push_crossref_xml_list(
 
         # update rogue-scholar legacy record if legacy_key is provided
         if is_rogue_scholar_doi(item.id, ra="crossref") and legacy_key is not None:
-            record["uuid"] = py_.get(item, "identifiers.0.identifier")
-            record = update_legacy_record(record, legacy_key=legacy_key, field="doi")
+            uuid = py_.get(item, "identifiers.0.identifier")
+            if uuid:
+                record["uuid"] = uuid
+                record = update_legacy_record(
+                    record, legacy_key=legacy_key, field="doi"
+                )
         items.append(record)
 
     # Return JSON response
-    return json.dumps(items, option=json.OPT_INDENT_2)
+    return json.dumps(items, option=json.OPT_INDENT_2).decode("utf-8")
 
 
 def get_attributes(obj, **kwargs) -> dict:
@@ -729,10 +742,16 @@ def get_item_number(obj) -> Optional[dict]:
             }
 
 
-def get_publication_date(obj, media_type: str = None) -> Optional[str]:
+def get_publication_date(obj, media_type: Optional[str] = None) -> Optional[Dict]:
     """get publication date"""
-    pub_date = date_parse(py_.get(obj, "date.published"))
-    if pub_date is None:
+    pub_date_str = py_.get(obj, "date.published")
+    if pub_date_str is None:
+        return None
+
+    try:
+        pub_date = date_parse(pub_date_str)
+    except (ValueError, TypeError) as e:
+        logger.warning(f"Failed to parse publication date '{pub_date_str}': {e}")
         return None
 
     return compact(
@@ -763,17 +782,20 @@ def get_archive_locations(obj) -> Optional[list]:
     ]
 
 
-def get_references(obj) -> Optional[dict]:
+def get_references(obj) -> Optional[Dict]:
     """get references"""
     if py_.get(obj, "references") is None or len(py_.get(obj, "references")) == 0:
         return None
 
     citations = []
     for i, ref in enumerate(py_.get(obj, "references")):
+        # Validate DOI before using it
+        doi = doi_from_url(ref.get("id", None))
+
         reference = compact(
             {
                 "@key": ref.get("key", f"ref{i + 1}"),
-                "doi": doi_from_url(ref.get("id", None)),
+                "doi": doi,
                 "journal_title": ref.get("journal_title", None),
                 "author": ref.get("author", None),
                 "volume": ref.get("volume", None),
@@ -849,15 +871,18 @@ def get_funding_references(obj) -> Optional[dict]:
     }
 
 
-def get_relations(obj) -> list:
+def get_relations(obj) -> Optional[Dict]:
     """get relations"""
     if py_.get(obj, "relations") is None or len(py_.get(obj, "relations")) == 0:
         return None
 
     def format_relation(relation):
         """format relation"""
+        relation_type = relation.get("type", None)
+        if relation_type is None:
+            return None
 
-        if relation.get("type", None) in [
+        if relation_type in [
             "IsPartOf",
             "HasPart",
             "IsReviewOf",
@@ -866,7 +891,7 @@ def get_relations(obj) -> list:
             "HasRelatedMaterial",
         ]:
             group = "rel:inter_work_relation"
-        elif relation.get("type", None) in [
+        elif relation_type in [
             "IsIdenticalTo",
             "IsPreprintOf",
             "HasPreprint",
@@ -879,43 +904,47 @@ def get_relations(obj) -> list:
         else:
             return None
 
-        f = furl(relation.get("id", None))
-        if validate_doi(relation.get("id", None)):
+        relation_id = relation.get("id", None)
+        if relation_id is None:
+            return None
+
+        f = furl(relation_id)
+        if validate_doi(relation_id):
             identifier_type = "doi"
-            _id = doi_from_url(relation.get("id", None))
-        elif f.host == "portal.issn.org" and obj.type in [
-            "Article",
-            "BlogPost",
-        ]:
+            _id = doi_from_url(relation_id)
+        elif f.host == "portal.issn.org" and obj.type in ["Article", "BlogPost"]:
             identifier_type = "issn"
             _id = f.path.segments[-1] if f.path.segments else None
-        elif validate_url(relation.get("id", None)) == "URL":
+        elif validate_url(relation_id) == "URL":
             identifier_type = "uri"
-            _id = relation.get("id", None)
+            _id = relation_id
         else:
             identifier_type = "other"
-            _id = relation.get("id", None)
+            _id = relation_id
 
         return {
             group: compact(
                 {
-                    "@relationship-type": py_.lower_first(relation.get("type"))
-                    if relation.get("type", None) is not None
-                    else None,
+                    "@relationship-type": py_.lower_first(relation_type),
                     "@identifier-type": identifier_type,
                     "#text": _id,
                 },
             )
         }
 
+    related_items = [
+        format_relation(i)
+        for i in py_.get(obj, "relations")
+        if format_relation(i) is not None
+    ]
+
+    if not related_items:
+        return None
+
     return {
         "@xmlns:rel": "http://www.crossref.org/relations.xsd",
         "@name": "relations",
-        "rel:related_item": [
-            format_relation(i)
-            for i in py_.get(obj, "relations")
-            if format_relation(i) is not None
-        ],
+        "rel:related_item": related_items,
     }
 
 

{commonmeta_py-0.131.dist-info → commonmeta_py-0.132.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: commonmeta-py
-Version: 0.131
+Version: 0.132
 Summary: Library for conversions to/from the Commonmeta scholarly metadata format
 Project-URL: Homepage, https://python.commonmeta.org
 Project-URL: Repository, https://github.com/front-matter/commonmeta-py

{commonmeta_py-0.131.dist-info → commonmeta_py-0.132.dist-info}/RECORD

@@ -1,4 +1,4 @@
-commonmeta/__init__.py,sha256=aQTPtjtKTK5Fit8pxN4Vi_zEQ84Kj9UYiA29eo_fb50,2118
+commonmeta/__init__.py,sha256=QeL1QY1Hrvi0a2tFjlFNahbgbEcV638GH5mEYBx43Sw,2118
 commonmeta/api_utils.py,sha256=P8LMHHYiF4OTi97_5k4KstcBreooMkOAKZ4ebxsAv4o,2691
 commonmeta/author_utils.py,sha256=3lYW5s1rOUWNTKs1FP6XLfEUY3yCLOe_3L_VdJTDMp0,8585
 commonmeta/base_utils.py,sha256=-MGy9q2uTiJEkPWQUYOJMdq-3tRpNnvBwlLjvllQ5g8,11164
@@ -77,14 +77,14 @@ commonmeta/writers/__init__.py,sha256=47-snms6xBHkoEXKYV1DBtH1npAtlVtvY29Z4Zr45q
 commonmeta/writers/bibtex_writer.py,sha256=doAdyl1NEp60mPkHPo3GMH8B-HA6MzLAdlyNsIecTzU,4972
 commonmeta/writers/citation_writer.py,sha256=qs_4X3BjrSqHexmJFPvPDTp0mRIqzb0F70_Wuc7S9x0,2343
 commonmeta/writers/commonmeta_writer.py,sha256=QpfyhG__7o_XpsOTCPWxGymO7YKwZi2LQh8Zic44bdc,1365
-commonmeta/writers/crossref_xml_writer.py,sha256=ImsNtmLl2N2lWflQo78ATL_2XrxAism3n4HJdGfTFFg,34075
+commonmeta/writers/crossref_xml_writer.py,sha256=nyNgnyluzd9jZ6jysrSg_TpMNOQuVjfMo7pN0HUb3c0,34832
 commonmeta/writers/csl_writer.py,sha256=4gDYs1EzK4_L2UIRTfs25wgHmYRwdRP2zmfxF9387oU,2779
 commonmeta/writers/datacite_writer.py,sha256=bcinpwhq7XnVthKHH8-sdXA34dSlvFH4ImYH768iaQU,6428
 commonmeta/writers/inveniordm_writer.py,sha256=tiuq9JEkz02l615yVe9wUcJQqiIPJLUqNDyofEE8Aus,26726
 commonmeta/writers/ris_writer.py,sha256=3SdyEvMRaPRP1SV1MB-MXBlunE7x6og7RF1zuWtetPc,2094
 commonmeta/writers/schema_org_writer.py,sha256=s18_x0ReXwAGBoEAwp2q-HCgFQ-h5qRg6JyAlqCoSFE,5871
-commonmeta_py-0.131.dist-info/METADATA,sha256=KjyqcBzab5P6Um8uq6fcI5bxEuNPtdfPKoP_cKrZlR4,7656
-commonmeta_py-0.131.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
-commonmeta_py-0.131.dist-info/entry_points.txt,sha256=U4w4BoRuS3rN5t5Y-uYSyOeU5Lh_VRVMS9OIDzIgw4w,50
-commonmeta_py-0.131.dist-info/licenses/LICENSE,sha256=wsIvxF9Q9GC9vA_s79zTWP3BkXJdfUNRmALlU8GbW1s,1074
-commonmeta_py-0.131.dist-info/RECORD,,
+commonmeta_py-0.132.dist-info/METADATA,sha256=EjTcKw-mi9NnFlRqUTmMh2x11eqabfZRqQqJDCOEbqc,7656
+commonmeta_py-0.132.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
+commonmeta_py-0.132.dist-info/entry_points.txt,sha256=U4w4BoRuS3rN5t5Y-uYSyOeU5Lh_VRVMS9OIDzIgw4w,50
+commonmeta_py-0.132.dist-info/licenses/LICENSE,sha256=wsIvxF9Q9GC9vA_s79zTWP3BkXJdfUNRmALlU8GbW1s,1074
+commonmeta_py-0.132.dist-info/RECORD,,