cognite-neat 1.0.31__py3-none-any.whl → 1.0.33__py3-none-any.whl

cognite/neat/_data_model/{validation → rules}/dms/_ai_readiness.py

@@ -1,13 +1,13 @@
 """Validators for checking if data model is AI-ready."""
 
 from cognite.neat._data_model.models.dms._data_types import EnumProperty
-from cognite.neat._data_model.validation.dms._base import DataModelValidator
+from cognite.neat._data_model.rules.dms._base import DataModelRule
 from cognite.neat._issues import Recommendation
 
 BASE_CODE = "NEAT-DMS-AI-READINESS"
 
 
-class DataModelMissingName(DataModelValidator):
+class DataModelMissingName(DataModelRule):
     """Validates that data model has a human-readable name.
 
     ## What it does
@@ -26,7 +26,7 @@ class DataModelMissingName(DataModelValidator):
     code = f"{BASE_CODE}-001"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         if not self.validation_resources.merged_data_model.name:
@@ -41,7 +41,7 @@ class DataModelMissingName(DataModelValidator):
         return recommendations
 
 
-class DataModelMissingDescription(DataModelValidator):
+class DataModelMissingDescription(DataModelRule):
     """Validates that data model has a human-readable description.
 
     ## What it does
@@ -65,7 +65,7 @@ class DataModelMissingDescription(DataModelValidator):
     code = f"{BASE_CODE}-002"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         if not self.validation_resources.merged_data_model.description:
@@ -80,7 +80,7 @@ class DataModelMissingDescription(DataModelValidator):
         return recommendations
 
 
-class ViewMissingName(DataModelValidator):
+class ViewMissingName(DataModelRule):
     """Validates that a View has a human-readable name.
 
     ## What it does
@@ -100,7 +100,7 @@ class ViewMissingName(DataModelValidator):
     code = f"{BASE_CODE}-003"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for view_ref in self.validation_resources.merged_data_model.views or []:
@@ -121,7 +121,7 @@ class ViewMissingName(DataModelValidator):
         return recommendations
 
 
-class ViewMissingDescription(DataModelValidator):
+class ViewMissingDescription(DataModelRule):
     """Validates that a View has a human-readable description.
 
     ## What it does
@@ -151,7 +151,7 @@ class ViewMissingDescription(DataModelValidator):
     code = f"{BASE_CODE}-004"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for view_ref in self.validation_resources.merged_data_model.views or []:
@@ -172,7 +172,7 @@ class ViewMissingDescription(DataModelValidator):
         return recommendations
 
 
-class ViewPropertyMissingName(DataModelValidator):
+class ViewPropertyMissingName(DataModelRule):
     """Validates that a view property has a human-readable name.
 
     ## What it does
@@ -192,7 +192,7 @@ class ViewPropertyMissingName(DataModelValidator):
     code = f"{BASE_CODE}-005"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for view_ref in self.validation_resources.merged_data_model.views or []:
@@ -217,7 +217,7 @@ class ViewPropertyMissingName(DataModelValidator):
         return recommendations
 
 
-class ViewPropertyMissingDescription(DataModelValidator):
+class ViewPropertyMissingDescription(DataModelRule):
     """Validates that a View property has a human-readable description.
 
     ## What it does
@@ -248,7 +248,7 @@ class ViewPropertyMissingDescription(DataModelValidator):
     code = f"{BASE_CODE}-006"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for view_ref in self.validation_resources.merged_data_model.views or []:
@@ -273,7 +273,7 @@ class ViewPropertyMissingDescription(DataModelValidator):
         return recommendations
 
 
-class EnumerationMissingName(DataModelValidator):
+class EnumerationMissingName(DataModelRule):
     """Validates that an enumeration has a human-readable name.
 
     ## What it does
@@ -293,7 +293,7 @@ class EnumerationMissingName(DataModelValidator):
     code = f"{BASE_CODE}-007"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for container_ref in self.validation_resources.merged.containers:
@@ -322,7 +322,7 @@ class EnumerationMissingName(DataModelValidator):
         return recommendations
 
 
-class EnumerationMissingDescription(DataModelValidator):
+class EnumerationMissingDescription(DataModelRule):
     """Validates that an enumeration value has a human-readable description.
 
     ## What it does
@@ -353,7 +353,7 @@ class EnumerationMissingDescription(DataModelValidator):
     code = f"{BASE_CODE}-008"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for container_ref in self.validation_resources.merged.containers:

cognite/neat/_data_model/rules/dms/_base.py

@@ -0,0 +1,5 @@
+from cognite.neat._data_model.rules._base import NeatRule
+
+
+class DataModelRule(NeatRule):
+    """Rules for data model principles."""

cognite/neat/_data_model/{validation → rules}/dms/_connections.py

@@ -9,13 +9,13 @@ from cognite.neat._data_model.models.dms._references import (
     ViewReference,
 )
 from cognite.neat._data_model.models.dms._view_property import ViewCorePropertyRequest
-from cognite.neat._data_model.validation.dms._base import DataModelValidator
+from cognite.neat._data_model.rules.dms._base import DataModelRule
 from cognite.neat._issues import ConsistencyError, Recommendation
 
 BASE_CODE = "NEAT-DMS-CONNECTIONS"
 
 
-class ConnectionValueTypeUnexisting(DataModelValidator):
+class ConnectionValueTypeUnexisting(DataModelRule):
     """Validates that connection value types exist.
 
     ## What it does
@@ -33,7 +33,7 @@ class ConnectionValueTypeUnexisting(DataModelValidator):
     code = f"{BASE_CODE}-001"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for (view, property_), value_type in self.validation_resources.connection_end_node_types.items():
@@ -57,7 +57,7 @@ class ConnectionValueTypeUnexisting(DataModelValidator):
         return errors
 
 
-class ConnectionValueTypeUndefined(DataModelValidator):
+class ConnectionValueTypeUndefined(DataModelRule):
     """Validates that connection value types are not None, i.e. undefined.
 
     ## What it does
@@ -77,7 +77,7 @@ class ConnectionValueTypeUndefined(DataModelValidator):
     code = f"{BASE_CODE}-002"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for (view, property_), value_type in self.validation_resources.connection_end_node_types.items():
@@ -128,7 +128,7 @@ def _normalize_through_reference(
     return through
 
 
-class ReverseConnectionSourceViewMissing(DataModelValidator):
+class ReverseConnectionSourceViewMissing(DataModelRule):
     """Validates that source view referenced in reverse connection exist.
 
     ## What it does
@@ -146,7 +146,7 @@ class ReverseConnectionSourceViewMissing(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-001"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -172,7 +172,7 @@ class ReverseConnectionSourceViewMissing(DataModelValidator):
         return errors
 
 
-class ReverseConnectionSourcePropertyMissing(DataModelValidator):
+class ReverseConnectionSourcePropertyMissing(DataModelRule):
     """Validates that source property referenced in reverse connections exist.
 
     ## What it does
@@ -191,7 +191,7 @@ class ReverseConnectionSourcePropertyMissing(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-002"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -224,7 +224,7 @@ class ReverseConnectionSourcePropertyMissing(DataModelValidator):
         return errors
 
 
-class ReverseConnectionSourcePropertyWrongType(DataModelValidator):
+class ReverseConnectionSourcePropertyWrongType(DataModelRule):
     """Validates that source property for the reverse connections is a direct relation.
 
     ## What it does
@@ -243,7 +243,7 @@ class ReverseConnectionSourcePropertyWrongType(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-003"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -280,7 +280,7 @@ class ReverseConnectionSourcePropertyWrongType(DataModelValidator):
         return errors
 
 
-class ReverseConnectionContainerMissing(DataModelValidator):
+class ReverseConnectionContainerMissing(DataModelRule):
     """Validates that the container referenced by the reverse connection source properties exist.
 
     ## What it does
@@ -298,7 +298,7 @@ class ReverseConnectionContainerMissing(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-004"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -344,7 +344,7 @@ class ReverseConnectionContainerMissing(DataModelValidator):
         return errors
 
 
-class ReverseConnectionContainerPropertyMissing(DataModelValidator):
+class ReverseConnectionContainerPropertyMissing(DataModelRule):
     """Validates that container property referenced by the reverse connections exists.
 
     ## What it does
@@ -363,7 +363,7 @@ class ReverseConnectionContainerPropertyMissing(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-005"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -412,7 +412,7 @@ class ReverseConnectionContainerPropertyMissing(DataModelValidator):
         return errors
 
 
-class ReverseConnectionContainerPropertyWrongType(DataModelValidator):
+class ReverseConnectionContainerPropertyWrongType(DataModelRule):
     """Validates that the container property used in reverse connection is the direct relations.
 
     ## What it does
@@ -431,7 +431,7 @@ class ReverseConnectionContainerPropertyWrongType(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-006"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -483,7 +483,7 @@ class ReverseConnectionContainerPropertyWrongType(DataModelValidator):
         return errors
 
 
-class ReverseConnectionTargetMissing(DataModelValidator):
+class ReverseConnectionTargetMissing(DataModelRule):
     """Validates that the direct connection in reverse connection pair have target views specified.
 
     ## What it does
@@ -501,7 +501,7 @@ class ReverseConnectionTargetMissing(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-007"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -546,7 +546,7 @@ class ReverseConnectionTargetMissing(DataModelValidator):
         return recommendations
 
 
-class ReverseConnectionPointsToAncestor(DataModelValidator):
+class ReverseConnectionPointsToAncestor(DataModelRule):
     """Validates that direct connections point to specific views rather than ancestors.
 
     ## What it does
@@ -565,7 +565,7 @@ class ReverseConnectionPointsToAncestor(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-008"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for (target_view_ref, reverse_prop_name), (
@@ -613,7 +613,7 @@ class ReverseConnectionPointsToAncestor(DataModelValidator):
         return recommendations
 
 
-class ReverseConnectionTargetMismatch(DataModelValidator):
+class ReverseConnectionTargetMismatch(DataModelRule):
     """Validates that direct connections point to the correct target views.
 
     ## What it does
@@ -632,7 +632,7 @@ class ReverseConnectionTargetMismatch(DataModelValidator):
     code = f"{BASE_CODE}-REVERSE-009"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for (target_view_ref, reverse_prop_name), (

cognite/neat/_data_model/{validation → rules}/dms/_consistency.py

@@ -1,13 +1,13 @@
 """Validators checking for consistency issues in data model."""
 
 from cognite.neat._data_model._constants import COGNITE_SPACES
-from cognite.neat._data_model.validation.dms._base import DataModelValidator
+from cognite.neat._data_model.rules.dms._base import DataModelRule
 from cognite.neat._issues import Recommendation
 
 BASE_CODE = "NEAT-DMS-CONSISTENCY"
 
 
-class ViewSpaceVersionInconsistentWithDataModel(DataModelValidator):
+class ViewSpaceVersionInconsistentWithDataModel(DataModelRule):
     """Validates that views have consistent space and version with the data model.
 
     ## What it does
@@ -25,7 +25,7 @@ class ViewSpaceVersionInconsistentWithDataModel(DataModelValidator):
     code = f"{BASE_CODE}-001"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         if not self.validation_resources.merged_data_model.views:

cognite/neat/_data_model/{validation → rules}/dms/_containers.py

@@ -4,13 +4,13 @@ from pyparsing import cast
 
 from cognite.neat._data_model.models.dms._constraints import Constraint, RequiresConstraintDefinition
 from cognite.neat._data_model.models.dms._view_property import ViewCorePropertyRequest
-from cognite.neat._data_model.validation.dms._base import DataModelValidator
+from cognite.neat._data_model.rules.dms._base import DataModelRule
 from cognite.neat._issues import ConsistencyError
 
 BASE_CODE = "NEAT-DMS-CONTAINER"
 
 
-class ExternalContainerDoesNotExist(DataModelValidator):
+class ExternalContainerDoesNotExist(DataModelRule):
     """
     Validates that any container referenced by a view property, when the
     referenced container does not belong to the data model's space, exists in CDF.
@@ -33,7 +33,7 @@ class ExternalContainerDoesNotExist(DataModelValidator):
     code = f"{BASE_CODE}-001"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         if not self.validation_resources.merged_data_model.views:
@@ -73,7 +73,7 @@ class ExternalContainerDoesNotExist(DataModelValidator):
         return errors
 
 
-class ExternalContainerPropertyDoesNotExist(DataModelValidator):
+class ExternalContainerPropertyDoesNotExist(DataModelRule):
     """
     Validates that any container property referenced by a view property, when the
     referenced container does not belong to the data model's space, exists in CDF.
@@ -97,7 +97,7 @@ class ExternalContainerPropertyDoesNotExist(DataModelValidator):
     code = f"{BASE_CODE}-002"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         if self.validation_resources.merged_data_model.views:
@@ -144,7 +144,7 @@ class ExternalContainerPropertyDoesNotExist(DataModelValidator):
         return errors
 
 
-class RequiredContainerDoesNotExist(DataModelValidator):
+class RequiredContainerDoesNotExist(DataModelRule):
     """
     Validates that any container required by another container exists in the data model.
 
@@ -165,7 +165,7 @@ class RequiredContainerDoesNotExist(DataModelValidator):
     code = f"{BASE_CODE}-003"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for container_ref in self.validation_resources.merged.containers:
@@ -199,7 +199,7 @@ class RequiredContainerDoesNotExist(DataModelValidator):
         return errors
 
 
-class RequiresConstraintCycle(DataModelValidator):
+class RequiresConstraintCycle(DataModelRule):
     """
     Validates that requires constraints between containers do not form cycles.
 
@@ -221,7 +221,7 @@ class RequiresConstraintCycle(DataModelValidator):
     issue_type = ConsistencyError
     alpha = True  # Still in development
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
         optimal_edges = self.validation_resources.oriented_mst_edges
 

cognite/neat/_data_model/{validation → rules}/dms/_limits.py

@@ -8,15 +8,15 @@ from cognite.neat._data_model.models.dms._indexes import BtreeIndex, InvertedInd
 from cognite.neat._data_model.models.dms._view_property import (
     ViewCorePropertyRequest,
 )
-from cognite.neat._data_model.validation.dms._base import (
-    DataModelValidator,
+from cognite.neat._data_model.rules.dms._base import (
+    DataModelRule,
 )
 from cognite.neat._issues import ConsistencyError, Recommendation
 
 BASE_CODE = "NEAT-DMS-LIMITS"
 
 
-class DataModelViewCountIsOutOfLimits(DataModelValidator):
+class DataModelViewCountIsOutOfLimits(DataModelRule):
     """Validates that the data model does not exceed the maximum number of views.
 
     ## What it does
@@ -36,7 +36,7 @@ class DataModelViewCountIsOutOfLimits(DataModelValidator):
     code = f"{BASE_CODE}-DATA-MODEL-001"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         if self.validation_resources.merged_data_model.views is None:
@@ -66,7 +66,7 @@ class DataModelViewCountIsOutOfLimits(DataModelValidator):
 ### View level limits
 
 
-class ViewPropertyCountIsOutOfLimits(DataModelValidator):
+class ViewPropertyCountIsOutOfLimits(DataModelRule):
     """Validates that a view does not exceed the maximum number of properties.
 
     ## What it does
@@ -83,7 +83,7 @@ class ViewPropertyCountIsOutOfLimits(DataModelValidator):
     code = f"{BASE_CODE}-VIEW-001"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         for view_ref in self.validation_resources.merged_data_model.views or []:
@@ -117,7 +117,7 @@ class ViewPropertyCountIsOutOfLimits(DataModelValidator):
         return errors
 
 
-class ViewContainerCountIsOutOfLimits(DataModelValidator):
+class ViewContainerCountIsOutOfLimits(DataModelRule):
     """Validates that a view does not reference too many containers.
 
     ## What it does
@@ -135,7 +135,7 @@ class ViewContainerCountIsOutOfLimits(DataModelValidator):
     code = f"{BASE_CODE}-VIEW-002"
     issue_type = Recommendation
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         # Single loop over all views
@@ -166,7 +166,7 @@ class ViewContainerCountIsOutOfLimits(DataModelValidator):
         return recommendations
 
 
-class ViewImplementsCountIsOutOfLimits(DataModelValidator):
+class ViewImplementsCountIsOutOfLimits(DataModelRule):
     """Validates that a view does not implement too many other views.
 
     ## What it does
@@ -183,7 +183,7 @@ class ViewImplementsCountIsOutOfLimits(DataModelValidator):
     code = f"{BASE_CODE}-VIEW-003"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         # Single loop over all views
@@ -206,7 +206,7 @@ class ViewImplementsCountIsOutOfLimits(DataModelValidator):
 ### Container level limits
 
 
-class ContainerPropertyCountIsOutOfLimits(DataModelValidator):
+class ContainerPropertyCountIsOutOfLimits(DataModelRule):
     """Validates that a container does not exceed the maximum number of properties.
 
     ## What it does
@@ -224,7 +224,7 @@ class ContainerPropertyCountIsOutOfLimits(DataModelValidator):
     code = f"{BASE_CODE}-CONTAINER-001"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
         # Single loop over all containers
         for container_ref in self.validation_resources.merged.containers:
@@ -263,7 +263,7 @@ class ContainerPropertyCountIsOutOfLimits(DataModelValidator):
         return errors
 
 
-class ContainerPropertyListSizeIsOutOfLimits(DataModelValidator):
+class ContainerPropertyListSizeIsOutOfLimits(DataModelRule):
     """Validates that container property list sizes do not exceed CDF limits.
 
     ## What it does
@@ -288,7 +288,7 @@ class ContainerPropertyListSizeIsOutOfLimits(DataModelValidator):
     code = f"{BASE_CODE}-CONTAINER-002"
     issue_type = ConsistencyError
 
-    def run(self) -> list[ConsistencyError]:
+    def validate(self) -> list[ConsistencyError]:
         errors: list[ConsistencyError] = []
 
         # Single loop over all containers

cognite/neat/_data_model/{validation → rules}/dms/_orchestrator.py

@@ -6,14 +6,14 @@ from cognite.neat._data_model._shared import OnSuccessIssuesChecker
 from cognite.neat._data_model._snapshot import SchemaSnapshot
 from cognite.neat._data_model.models.dms._limits import SchemaLimits
 from cognite.neat._data_model.models.dms._schema import RequestSchema
+from cognite.neat._data_model.rules.dms._base import DataModelRule
 from cognite.neat._utils.auxiliary import get_concrete_subclasses
 from cognite.neat._utils.useful_types import ModusOperandi
 
-from ._base import DataModelValidator
 
-
-class DmsDataModelValidation(OnSuccessIssuesChecker):
-    """Placeholder for DMS Quality Assessment functionality."""
+class DmsDataModelRulesOrchestrator(OnSuccessIssuesChecker):
+    """DMS Data Model rules orchestrator, used to execute DMS data model rules on a single data model represented
+    as RequestSchema."""
 
     def __init__(
         self,
@@ -37,8 +37,8 @@ class DmsDataModelValidation(OnSuccessIssuesChecker):
         validation_resources = self._gather_validation_resources(request_schema)
 
         # Initialize all validators
-        validators: list[DataModelValidator] = [
-            validator(validation_resources) for validator in get_concrete_subclasses(DataModelValidator)
+        validators: list[DataModelRule] = [
+            validator(validation_resources) for validator in get_concrete_subclasses(DataModelRule)
         ]
 
         # Run validators
@@ -46,7 +46,7 @@ class DmsDataModelValidation(OnSuccessIssuesChecker):
             if validator.alpha and not self._enable_alpha_validators:
                 continue
             if self._can_run_validator(validator.code, validator.issue_type):
-                self._issues.extend(validator.run())
+                self._issues.extend(validator.validate())
 
         self._has_run = True
 

cognite/neat/_data_model/{validation → rules}/dms/_performance.py

@@ -2,13 +2,13 @@
 
 from cognite.neat._data_model._analysis import RequiresChangeStatus
 from cognite.neat._data_model._constants import COGNITE_SPACES
-from cognite.neat._data_model.validation.dms._base import DataModelValidator
+from cognite.neat._data_model.rules.dms._base import DataModelRule
 from cognite.neat._issues import Recommendation
 
 BASE_CODE = "NEAT-DMS-PERFORMANCE"
 
 
-class MissingRequiresConstraint(DataModelValidator):
+class MissingRequiresConstraint(DataModelRule):
     """
     Recommends adding requires constraints to optimize query performance.
 
@@ -31,7 +31,7 @@ class MissingRequiresConstraint(DataModelValidator):
     issue_type = Recommendation
     alpha = True
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for view_ref in self.validation_resources.merged.views:
@@ -75,7 +75,7 @@ class MissingRequiresConstraint(DataModelValidator):
         return recommendations
 
 
-class SuboptimalRequiresConstraint(DataModelValidator):
+class SuboptimalRequiresConstraint(DataModelRule):
     """
     Recommends removing requires constraints that are not optimal.
 
@@ -100,7 +100,7 @@ class SuboptimalRequiresConstraint(DataModelValidator):
     issue_type = Recommendation
     alpha = True
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for view_ref in self.validation_resources.merged.views:
@@ -125,7 +125,7 @@ class SuboptimalRequiresConstraint(DataModelValidator):
         return recommendations
 
 
-class UnresolvableQueryPerformance(DataModelValidator):
+class UnresolvableQueryPerformance(DataModelRule):
     """
     Identifies views with query performance issues that cannot be resolved.
     This is likely to be caused by unintended modeling choices.
@@ -158,7 +158,7 @@ class UnresolvableQueryPerformance(DataModelValidator):
     issue_type = Recommendation
     alpha = True
 
-    def run(self) -> list[Recommendation]:
+    def validate(self) -> list[Recommendation]:
         recommendations: list[Recommendation] = []
 
         for view_ref in self.validation_resources.merged.views: