codex 1.7.2__py3-none-any.whl → 1.7.3__py3-none-any.whl

codex/views/browser/order_by.py

@@ -19,7 +19,10 @@ class BrowserOrderByView(BrowserGroupMtimeView):
         if not self._order_key:
             order_key: str = self.params["order_by"]
             if (order_key == "search_score" and not self.fts_mode) or (
-                order_key == "filename" and not self.admin_flags["folder_view"]
+                order_key == "filename"
+                and not self.admin_flags["folder_view"]
+                or order_key == "child_count"
+                and self.TARGET == "cover"
             ):
                 order_key = "sort_name"
             self._order_key = order_key
@@ -29,6 +32,8 @@ class BrowserOrderByView(BrowserGroupMtimeView):
         """Order by for comics (and covers)."""
         if not order_key:
             order_key = self.order_key
+        if order_key == "child_count":
+            order_key = "sort_name"
         if order_key == "sort_name":
             if not comic_sort_names:
                 comic_sort_names = self._comic_sort_names
@@ -50,7 +55,7 @@ class BrowserOrderByView(BrowserGroupMtimeView):
                 order_fields_head += ["bookmark_updated_at"]
         return order_fields_head
 
-    def add_order_by(self, qs, order_key="", do_reverse=True, comic_sort_names=None):
+    def add_order_by(self, qs, order_key="", comic_sort_names=None):
         """Create the order_by list."""
         order_fields_head = ()
         if qs.model is Comic:
@@ -60,11 +65,9 @@ class BrowserOrderByView(BrowserGroupMtimeView):
 
         order_fields = (*order_fields_head, "pk")
 
-        prefix = "-" if do_reverse and self.params.get("order_reverse") else ""
-        order_by = []
+        prefix = "-" if self.params.get("order_reverse") else ""
         if prefix:
-            for field in order_fields:
-                order_by.append(prefix + field)
+            order_by = [prefix + field for field in order_fields]
         else:
             order_by = order_fields
 

codex/views/browser/params.py

@@ -58,7 +58,7 @@ class BrowserParamsView(SessionView):
             validated_data = serializer.validated_data
 
             if validated_data:
-                params.update(validated_data)  # type: ignore
+                params.update(validated_data)
             self._params = MappingProxyType(params)
             self.validate_settings()
         return self._params

codex/views/browser/settings.py

@@ -9,7 +9,7 @@ class BrowserSettingsView(SettingsView):
     """Get Browser Settings."""
 
     # Put Browser Settings is normally done through BrowserView.get()
-    serializer_class = BrowserSettingsSerializer  # type: ignore
+    serializer_class = BrowserSettingsSerializer
 
     SESSION_KEY = SettingsView.BROWSER_SESSION_KEY
 

codex/views/browser/validate.py

@@ -3,6 +3,7 @@
 from collections.abc import Mapping
 from copy import deepcopy
 from types import MappingProxyType
+from typing import Any
 
 from rest_framework.exceptions import NotFound
 
@@ -73,17 +74,18 @@ class BrowserValidateView(SearchFilterView):
         self, reason, route_mask=None, settings_mask: Mapping | None = None
     ):
         """Redirect the client to a valid group url."""
-        route = mapping_to_dict(self.DEFAULT_ROUTE)
+        route: dict[str, Any] = mapping_to_dict(self.DEFAULT_ROUTE)  # type:ignore[reportAssignmentType]
         if route_mask:
-            route["params"].update(route_mask)  # type: ignore
-        settings: dict = deepcopy(mapping_to_dict(self.params))  # type: ignore
+            route["params"].update(route_mask)
+        settings: dict[str, Any] = deepcopy(mapping_to_dict(self.params))  # type: ignore[reportAssignmentType]
         if settings_mask:
             settings.update(settings_mask)
         detail = {"route": route, "settings": settings, "reason": reason}
         raise SeeOtherRedirectError(detail=detail)
 
     def _get_valid_browse_top_groups(self):
-        """Get valid top groups for the current settings.
+        """
+        Get valid top groups for the current settings.
 
         Valid top groups are determined by the Browser Settings.
         """
@@ -118,7 +120,8 @@ class BrowserValidateView(SearchFilterView):
             self.raise_redirect(reason, route, settings_mask)
 
     def _get_valid_browse_nav_groups(self, valid_top_groups):
-        """Get valid nav groups for the current settings.
+        """
+        Get valid nav groups for the current settings.
 
         Valid nav groups are the top group and below that are also
         enabled in browser settings.

codex/views/const.py

@@ -76,9 +76,6 @@ METADATA_GROUP_RELATION = MappingProxyType(
     {
         **GROUP_NAME_MAP,
         COMIC_GROUP: "comic",
-        # Possible to list all groups in a non group view, but could get crazy.
-        # FOLDER_GROUP: "comic__folder",
-        # STORY_ARC_GROUP: "comic__story_arc_number__story_arc"
     }
 )
 CUSTOM_COVER_GROUP_RELATION = MappingProxyType(

codex/views/frontend.py

@@ -6,6 +6,7 @@ from rest_framework.permissions import AllowAny
 from rest_framework.renderers import TemplateHTMLRenderer
 from rest_framework.response import Response
 
+from codex.models.admin import AdminFlag
 from codex.serializers.route import RouteSerializer
 from codex.views.session import SessionView
 
@@ -16,13 +17,27 @@ class IndexView(SessionView):
     SESSION_KEY = SessionView.BROWSER_SESSION_KEY
 
     permission_classes = (AllowAny,)
-    renderer_classes: ClassVar[list] = [TemplateHTMLRenderer]  # type: ignore
+    renderer_classes: ClassVar[list] = [TemplateHTMLRenderer]  # type: ignore[reportIncompatibleVariableOverride]
     template_name = "index.html"
 
-    def get(self, *_args, **_kwargs):
-        """Get the app index page."""
+    def _get_last_route(self):
+        """Get the last route from the session."""
         last_route = self.get_last_route(name=False)
         serializer = RouteSerializer(last_route)
-        last_route = serializer.data
-        extra_context = {"last_route": last_route}
+        return serializer.data
+
+    def _get_title(self):
+        """Get the title from the banner text."""
+        bt_flag = AdminFlag.objects.get(key="BT")
+        title = "Codex"
+        if bt_flag.value:
+            title = bt_flag.value + " - " + title
+        return title
+
+    def get(self, *_args, **_kwargs):
+        """Get the app index page."""
+        extra_context = {
+            "last_route": self._get_last_route(),
+            "title": self._get_title(),
+        }
         return Response(extra_context)

codex/views/mixins.py

@@ -2,40 +2,46 @@
 
 from django.db.models.expressions import F
 
+from codex.logger.logging import get_logger
 from codex.models.comic import Comic, Imprint, Volume
+from codex.views.browser.filters.filter import BrowserFilterView
 from codex.views.const import GROUP_NAME_MAP
 
+LOG = get_logger(__name__)
 _SHOW_GROUPS = tuple(GROUP_NAME_MAP.keys())
+_GROUP_NAME_TARGETS = frozenset({"browser", "opds1", "opds2", "reader"})
+_VARIABLE_SHOW = "pi"
 
 
-class SharedAnnotationsMixin:
+class SharedAnnotationsMixin(BrowserFilterView):
     """Cross view annotation methods."""
 
     @staticmethod
-    def _get_order_groups(model_group, pks):
+    def _get_order_groups(parent_group, pks, show):
         """Annotate sort_name."""
-        if not pks or len(pks) > 1:
-            order_groups = _SHOW_GROUPS
-        elif model_group == "c":
+        if parent_group == "c":
             order_groups = ()
         else:
             for index, nav_group in enumerate(_SHOW_GROUPS):
-                if nav_group == model_group:
-                    order_groups = _SHOW_GROUPS[index + 1 :]
+                if nav_group in _VARIABLE_SHOW and not show.get(nav_group):
+                    continue
+                if nav_group == parent_group:
+                    watermark = index
+                    if pks and len(pks) == 1:
+                        watermark += 1
+                    order_groups = _SHOW_GROUPS[watermark:]
                     break
             else:
                 order_groups = _SHOW_GROUPS
         return order_groups
 
     @classmethod
-    def get_sort_name_annotations(cls, model, model_group, pks, show):
+    def get_sort_name_annotations(cls, model, parent_group, pks, show):
         """Annotate sort names for browser subclasses and reader."""
         sort_name_annotations = {}
         if model is Comic:
-            order_groups = cls._get_order_groups(model_group, pks)
+            order_groups = cls._get_order_groups(parent_group, pks, show)
             for order_group in order_groups:
-                if show and not show.get(order_group):
-                    continue
                 group_name = GROUP_NAME_MAP[order_group]
                 ann_name = f"{group_name}_sort_name"
                 name_field = "name" if group_name == "volume" else "sort_name"
@@ -49,8 +55,8 @@ class SharedAnnotationsMixin:
     def annotate_group_names(cls, qs):
         """Annotate name fields by hoisting them up."""
         # Optimized to only lookup what is used on the frontend
-        target = cls.TARGET  # type: ignore
-        if target not in frozenset({"browser", "opds1", "opds2", "reader"}):
+        target = cls.TARGET
+        if target not in _GROUP_NAME_TARGETS:
             return qs
         group_names = {}
         if qs.model is Comic:
@@ -69,20 +75,3 @@ class SharedAnnotationsMixin:
         elif qs.model is Imprint:
             group_names["publisher_name"] = F("publisher__name")
         return qs.annotate(**group_names)
-
-
-class BookmarkSearchMixin:
-    """Create Bookmark Search kwargs."""
-
-    @staticmethod
-    def get_bookmark_search_kwargs(auth_filter, comic_filter=None):
-        """Get the search kwargs for a user's authentication state."""
-        # search kwargs are relative to the bookmark object.
-        search_kwargs = {}
-        search_kwargs.update(auth_filter)
-
-        if comic_filter:
-            for key, value in comic_filter.items():
-                search_kwargs[f"comic__{key}"] = value
-
-        return search_kwargs

codex/views/opds/authentication_v1.py

@@ -40,7 +40,7 @@ _DOC = MappingProxyType(
                 "labels": {"login": "Username", "password": "Password"},
             },
             {
-                # XXX Out of spec type
+                # Out of spec type
                 "type": "cookie",
                 "links": [
                     {

codex/views/opds/const.py

@@ -28,6 +28,7 @@ class Rel:
     SORT_NEW = "http://opds-spec.org/sort/new"
     POPULAR = "http://opds-spec.org/sort/popular"
     FEATURED = "http://opds-spec.org/featured"
+    PROGRESSION = "http://www.cantook.com/api/progression"
     SELF = "self"
     START = "start"
     UP = "up"
@@ -47,16 +48,17 @@ class MimeType:
 
     ATOM = "application/atom+xml"
     _PROFILE_CATALOG = "profile=opds-catalog"
-    NAV = ";".join((ATOM, _PROFILE_CATALOG, "kind=navigation"))
-    ACQUISITION = ";".join((ATOM, _PROFILE_CATALOG, "kind=acquisition"))
-    ENTRY_CATALOG = ";".join((ATOM, "type=entry", _PROFILE_CATALOG))
+    NAV = f"{ATOM};{_PROFILE_CATALOG};kind=navigation"
+    ACQUISITION = f"{ATOM};{_PROFILE_CATALOG};kind=acquisition"
+    ENTRY_CATALOG = f"{ATOM};type=entry;{_PROFILE_CATALOG}"
     AUTHENTICATION = "application/opds-authentication+json"
     OPENSEARCH = "application/opensearchdescription+xml"
     STREAM = "image/jpeg"
     OPDS_JSON = "application/opds+json"
     OPDS_PUB = "application/opds-publication+json"
+    PROGRESSION = "application/vnd.readium.progression+json"
     BOOK = "http://schema.org/Book"
-    # COMIC = "https://schema.org/ComicStory"
+    # COMIC = "https://schema.org/ComicStory" unused
     JPEG = "image/jpeg"
     WEBP = "image/webp"
     HTML = "text/html"

codex/views/opds/util.py

@@ -31,7 +31,7 @@ def update_href_query_params(href, old_query_params, new_query_params=None):
     return href
 
 
-def get_contributor_people(comic_pks, roles, exclude=False):
+def get_contributor_people(comic_pks, roles, exclude):
     """Get contributors that are not authors."""
     people = ContributorPerson.objects.filter(
         contributor__comic__in=comic_pks,
@@ -43,7 +43,7 @@ def get_contributor_people(comic_pks, roles, exclude=False):
     return people.distinct().only("name")
 
 
-def get_contributors(comic_pks, roles, exclude=False):
+def get_contributors(comic_pks, roles, exclude):
     """Get credits that are not part of other roles."""
     contributors = Contributor.objects.filter(comic__in=comic_pks)
     if exclude:
@@ -59,8 +59,8 @@ def get_m2m_objects(pks) -> dict:
     for model in OPDS_M2M_MODELS:
         table = model.__name__.lower()
         rel = GroupACLMixin.get_rel_prefix(model)
-        comic_filter = {rel + "__in": pks}
-        qs = model.objects.filter(**comic_filter).order_by("name").only("name")
+        comic_filter = {rel + "in": pks}
+        qs = model.objects.filter(**comic_filter).only("name").order_by("name")
         cats[table] = qs
 
     return cats
@@ -78,7 +78,7 @@ def full_redirect_view(url_name):
         path = request.get_full_path()
         if path:
             parts = path.split("?")
-            if len(parts) >= 2:  # noqa PLR2004
+            if len(parts) >= 2:  # noqa: PLR2004
                 parts[0] = url
                 url = "?".join(parts)
 

codex/views/opds/v1/entry/entry.py

@@ -47,8 +47,10 @@ class OPDS1Entry(OPDS1EntryLinksMixin):
                 elif group == "c":
                     title = Comic.get_title(
                         self.obj,
-                        zero_pad=self.zero_pad,
+                        volume=True,
+                        name=True,
                         filename_fallback=self.title_filename_fallback,
+                        zero_pad=self.zero_pad,
                     )
                     parts.append(title)
 
@@ -133,7 +135,7 @@ class OPDS1Entry(OPDS1EntryLinksMixin):
         """Get Author names."""
         if not self.metadata:
             return []
-        people = get_contributor_people(self.obj.ids, AUTHOR_ROLES)
+        people = get_contributor_people(self.obj.ids, AUTHOR_ROLES, exclude=False)
         return self._add_url_to_obj(people, "contributors")
 
     @property

codex/views/opds/v1/entry/links.py

@@ -20,7 +20,7 @@ class OPDS1EntryLinksMixin:
     """OPDS v1 Entry Links Methods."""
 
     def __init__(
-        self, obj, query_params, data: OPDS1EntryData, title_filename_fallback=False
+        self, obj, query_params, data: OPDS1EntryData, title_filename_fallback: bool
     ):
         """Initialize params."""
         self.obj = obj
@@ -35,7 +35,6 @@ class OPDS1EntryLinksMixin:
     def _cover_link(self, rel):
         if self.fake:
             return None
-        # cover_pk = getattr(self.obj, "cover_pk", None)
         try:
             kwargs = {"group": self.obj.group, "pks": self.obj.ids}
             ts = floor(datetime.timestamp(self.obj.updated_at))
@@ -46,12 +45,11 @@ class OPDS1EntryLinksMixin:
             }
             href = reverse("opds:bin:cover", kwargs=kwargs)
             href = update_href_query_params(href, query_params)
-            mime_type = "image/webp"
-            return OPDS1Link(rel, href, mime_type)
+            return OPDS1Link(rel, href, MimeType.WEBP)
         except Exception:
             LOG.exception("create thumb")
 
-    def _nav_href(self, metadata=False):
+    def _nav_href(self, metadata: bool):
         try:
             pks = sorted(self.obj.ids)
             kwargs = {"group": self.obj.group, "pks": pks, "page": 1}
@@ -73,7 +71,7 @@ class OPDS1EntryLinksMixin:
             LOG.exception(msg)
             raise
 
-    def _nav_link(self, metadata=False):
+    def _nav_link(self, metadata: bool):
         href = self._nav_href(metadata)
 
         group = self.obj.group
@@ -155,7 +153,7 @@ class OPDS1EntryLinksMixin:
 
             if self.obj.group == "c" and not self.fake:
                 result += self._links_comic()
-            elif nav := self._nav_link():
+            elif nav := self._nav_link(metadata=False):
                 result += [nav]
 
         except Exception:

codex/views/opds/v1/facets.py

@@ -169,11 +169,14 @@ class OPDS1FacetsView(BrowserView):
         )
         qps = {**self.request.GET}
         qps.update(query_params)
-        zero_pad: int = self.obj["zero_pad"]  # type: ignore
+        zero_pad: int = self.obj["zero_pad"]
         data = OPDS1EntryData(
-            self.opds_acquisition_groups, zero_pad, False, self.mime_type_map
+            self.opds_acquisition_groups,
+            zero_pad,
+            metadata=False,
+            mime_type_map=self.mime_type_map,
         )
-        return OPDS1Entry(entry_obj, qps, data)
+        return OPDS1Entry(entry_obj, qps, data, title_filename_fallback=False)
 
     def _is_facet_active(self, facet_group, facet):
         compare = [facet.value]
@@ -231,7 +234,8 @@ class OPDS1FacetsView(BrowserView):
                 facets += [facet_obj]
         return facets
 
-    def facets(self, entries=False, root=True):
+    def facets(self, entries: bool, root: bool):
+        # entries false, root true
         """Return facets."""
         facets = []
         group = self.kwargs.get("group")

codex/views/opds/v1/feed.py

@@ -75,7 +75,7 @@ class OPDS1FeedView(OPDS1LinksView, OPDSTemplateView):
         """Create the feed title."""
         result = ""
         try:
-            browser_title: Mapping[str, Any] = self.obj.get("title")  # type: ignore
+            browser_title: Mapping[str, Any] = self.obj.get("title", {})
             if browser_title:
                 parent_name = browser_title.get("parent_name", "All")
                 pks = self.kwargs["pks"]
@@ -97,7 +97,7 @@ class OPDS1FeedView(OPDS1LinksView, OPDSTemplateView):
         try:
             mtime = self.obj.get("mtime")
             if mtime:
-                datestr = mtime.isoformat()  # type: ignore
+                datestr = mtime.isoformat()
         except Exception:
             LOG.exception("Getting OPDS v1 updated")
         return datestr
@@ -124,13 +124,13 @@ class OPDS1FeedView(OPDS1LinksView, OPDSTemplateView):
         """Get entries by key section."""
         entries = []
         if objs := self.obj.get(key):
-            zero_pad: int = self.obj["zero_pad"]  # type: ignore
+            zero_pad: int = self.obj["zero_pad"]
             data = OPDS1EntryData(
                 self.opds_acquisition_groups, zero_pad, metadata, self.mime_type_map
             )
             fallback = bool(self.admin_flags.get("folder_view"))
             import_pks = set()
-            for obj in objs:  # type: ignore
+            for obj in objs:
                 entry = OPDS1Entry(
                     obj,
                     self.request.GET,
@@ -157,7 +157,7 @@ class OPDS1FeedView(OPDS1LinksView, OPDSTemplateView):
                     entries += self.add_top_links(RootTopLinks.ALL)
                 entries += self.facets(entries=True, root=at_root)
 
-            entries += self._get_entries_section("groups", False)
+            entries += self._get_entries_section("groups", metadata=False)
             metadata = self.request.GET.get("opdsMetadata", "").lower() not in FALSY
             entries += self._get_entries_section("books", metadata)
         except Exception:

codex/views/opds/v1/links.py

@@ -105,7 +105,7 @@ class RootTopLinks:
 class OPDS1LinksView(OPDS1FacetsView):
     """OPDS 1 Links methods."""
 
-    # overwritten in get_object()
+    # overwritten in get_object method
     DEFAULT_ROUTE = MappingProxyType(
         {
             **OPDS1FacetsView.DEFAULT_ROUTE,
@@ -143,7 +143,7 @@ class OPDS1LinksView(OPDS1FacetsView):
     def _root_links(self):
         """Navigation Root Links."""
         links = []
-        if up_route := self.get_last_route():
+        if up_route := self.get_last_route(name=True):
             links += [self._link(up_route, Rel.UP)]
         page = self.kwargs.get("page", 1)
         if page > 1:
@@ -179,7 +179,7 @@ class OPDS1LinksView(OPDS1FacetsView):
                 for top_link in TopLinks.ALL + RootTopLinks.ALL:
                     if not self.is_top_link_displayed(top_link):
                         links += [self._top_link(top_link)]
-                if facets := self.facets():
+                if facets := self.facets(entries=False, root=True):
                     links += facets
         except Exception:
             LOG.exception("Getting OPDS v1 links")
@@ -194,11 +194,16 @@ class OPDS1LinksView(OPDS1FacetsView):
             name=name,
             summary=top_link.desc,
         )
-        zero_pad: int = self.obj["zero_pad"]  # type: ignore
+        zero_pad: int = self.obj["zero_pad"]
         data = OPDS1EntryData(
-            self.opds_acquisition_groups, zero_pad, False, self.mime_type_map
+            self.opds_acquisition_groups,
+            zero_pad,
+            metadata=False,
+            mime_type_map=self.mime_type_map,
+        )
+        return OPDS1Entry(
+            entry_obj, top_link.query_params, data, title_filename_fallback=False
         )
-        return OPDS1Entry(entry_obj, top_link.query_params, data)
 
     def add_top_links(self, top_links):
         """Add a list of top links as entries if they should be enabled."""

codex/views/opds/v2/const.py

@@ -31,7 +31,10 @@ FACETS = (
         "Order Direction",
         "orderReverse",
         "⇕",
-        (Facet(False, "Ascending"), Facet(True, "Descending")),
+        (
+            Facet(query_param_value=False, title="Ascending"),
+            Facet(query_param_value=True, title="Descending"),
+        ),
     ),
     FacetGroup(
         "Top Group",
@@ -114,5 +117,5 @@ class LinksSectionData:
 
 
 TOP_NAV_GROUP_SECTION_DATA = LinksSectionData(group_kwarg=True)
-GROUPS_SECTION_DATA = LinksSectionData("Groups", Rel.SUB, True)
+GROUPS_SECTION_DATA = LinksSectionData("Groups", Rel.SUB, group_kwarg=True)
 FACETS_SECTION_DATA = LinksSectionData(rel=Rel.FACET, links_key="links")

codex/views/opds/v2/feed.py

@@ -8,7 +8,7 @@ from rest_framework.response import Response
 from codex.logger.logging import get_logger
 from codex.models import AdminFlag
 from codex.serializers.browser.settings import OPDSSettingsSerializer
-from codex.serializers.opds.v2 import OPDS2FeedSerializer
+from codex.serializers.opds.v2.feed import OPDS2FeedSerializer
 from codex.views.const import MAX_OBJ_PER_PAGE
 from codex.views.opds.auth import OPDSAuthMixin
 from codex.views.opds.const import BLANK_TITLE
@@ -20,7 +20,8 @@ from codex.views.opds.v2.const import (
     TOP_NAV_GROUP_SECTION_DATA,
     NavigationGroup,
 )
-from codex.views.opds.v2.links import HrefData, LinkData
+from codex.views.opds.v2.href import HrefData
+from codex.views.opds.v2.links import LinkData
 from codex.views.opds.v2.publications import OPDS2PublicationView
 
 LOG = get_logger(__name__)
@@ -55,9 +56,9 @@ class OPDS2FeedView(OPDSAuthMixin, OPDS2PublicationView):
 
     # def _detect_user_agent(self):
     #    """Hacks for individual clients."""
-    #    user_agent = self.request.headers.get("User-Agent")
+    #    user_agent = self.request.headers.get("User-Agent") # noqa: ERA001
     #    if not user_agent:
-    #        return
+    #        return # noqa: ERA001
 
     @staticmethod
     def _is_allowed(link_spec):
@@ -184,7 +185,7 @@ class OPDS2FeedView(OPDSAuthMixin, OPDS2PublicationView):
         title = self._title(title)
         number_of_items = total_count
         current_page = self.kwargs.get("page")
-        up_route = self.get_last_route()
+        up_route = self.get_last_route(name=True)
         links = self.get_links(up_route)
         facets = self._get_facets()
 

codex/views/opds/v2/href.py

@@ -0,0 +1,60 @@
+"""Href methods for OPDS v2.0 Feed."""
+
+from abc import ABC
+from dataclasses import dataclass
+
+from django.urls import reverse
+from rest_framework.views import APIView
+
+from codex.views.opds.util import update_href_query_params
+from codex.views.util import pop_name
+
+
+@dataclass
+class HrefData:
+    """Data for creating hrefs."""
+
+    kwargs: dict | None = None
+    query_params: dict | None = None
+    absolute_query_params: bool = False
+    url_name: str | None = None
+    min_page: int | None = None
+    max_page: int | None = None
+
+
+class OPDS2HrefMixin(APIView, ABC):
+    """Create links method."""
+
+    @property
+    def num_pages(self) -> int:
+        """Dummy."""
+        return 1
+
+    def _href_page_validate(self, kwargs, data):
+        """Validate the page bounds."""
+        min_page = 1 if data.min_page is None else data.min_page
+        max_page = self.num_pages if data.max_page is None else data.max_page
+        page = int(kwargs["page"])
+        return page >= min_page and page <= max_page
+
+    def _href_update_query_params(self, href, data):
+        """Update the query params."""
+        if data.absolute_query_params and data.query_params:
+            href = update_href_query_params(href, data.query_params)
+        elif hasattr(self, "request"):
+            # if request link and not init static links
+            href = update_href_query_params(
+                href, self.request.GET, new_query_params=data.query_params
+            )
+        return href
+
+    def href(self, data):
+        """Create an href."""
+        url_name = data.url_name if data.url_name else "opds:v2:feed"
+        kwargs = data.kwargs if data.kwargs is not None else self.kwargs
+        if "page" in kwargs and not self._href_page_validate(kwargs, data):
+            return None
+
+        kwargs = pop_name(kwargs)
+        href = reverse(url_name, kwargs=kwargs)
+        return self._href_update_query_params(href, data)