codeplain 0.3.13.dev48__py3-none-any.whl → 0.3.14.dev50__py3-none-any.whl

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (49) hide show
  1. change_detection.py +65 -94
  2. cli_output/dry_run.py +7 -3
  3. {codeplain-0.3.13.dev48.dist-info → codeplain-0.3.14.dev50.dist-info}/METADATA +1 -1
  4. {codeplain-0.3.13.dev48.dist-info → codeplain-0.3.14.dev50.dist-info}/RECORD +49 -43
  5. codeplain_REST_api.py +9 -14
  6. docs/generate_cli.py +3 -2
  7. partial_rendering.py +32 -2
  8. plain2code.py +42 -14
  9. plain2code_arguments.py +69 -12
  10. plain2code_telemetry.py +2 -1
  11. plain2code_utils.py +14 -0
  12. plain_modules.py +73 -14
  13. render_machine/actions/analyze_specification_ambiguity.py +5 -3
  14. render_machine/actions/distill_conformance_test_memory.py +3 -1
  15. render_machine/actions/fix_conformance_test.py +4 -4
  16. render_machine/actions/fix_unit_tests.py +3 -1
  17. render_machine/actions/refactor_code.py +6 -1
  18. render_machine/actions/render_conformance_tests.py +52 -20
  19. render_machine/actions/render_functional_requirement.py +5 -2
  20. render_machine/actions/run_conformance_tests.py +3 -2
  21. render_machine/actions/summarize_conformance_tests.py +3 -1
  22. render_machine/render_context.py +59 -20
  23. render_machine/render_types.py +6 -15
  24. standard_template_library/typescript-react-app-boilerplate.plain +2 -1
  25. tests/test_acceptance_scenario_rendered_once.py +169 -0
  26. tests/test_acceptance_scenarios_after_a_code_fix.py +110 -0
  27. tests/test_change_detection.py +138 -127
  28. tests/test_conformance_fix_journal.py +46 -46
  29. tests/test_dry_run_link_validation.py +2 -1
  30. tests/test_fix_unit_tests_action.py +1 -1
  31. tests/test_frid_arguments.py +40 -0
  32. tests/test_functionality_without_scenarios.py +88 -0
  33. tests/test_git_utils.py +13 -13
  34. tests/test_partial_rendering.py +82 -47
  35. tests/test_plain2code.py +39 -41
  36. tests/test_plain2code_utils.py +12 -1
  37. tests/test_plain_modules.py +50 -44
  38. tests/test_render_finished_report.py +2 -0
  39. tests/test_render_range.py +18 -9
  40. tests/test_render_stop_reason.py +5 -5
  41. tests/test_telemetry.py +2 -2
  42. tests/test_terminal_attachment.py +2 -1
  43. tests/test_tests_folders.py +91 -0
  44. tests/test_traceability_warnings.py +69 -0
  45. tui/plain_module_render_choice_tui.py +4 -6
  46. tui/state_handlers.py +19 -28
  47. {codeplain-0.3.13.dev48.dist-info → codeplain-0.3.14.dev50.dist-info}/WHEEL +0 -0
  48. {codeplain-0.3.13.dev48.dist-info → codeplain-0.3.14.dev50.dist-info}/entry_points.txt +0 -0
  49. {codeplain-0.3.13.dev48.dist-info → codeplain-0.3.14.dev50.dist-info}/licenses/LICENSE +0 -0
@@ -12,6 +12,7 @@ under test relies on: ``module_name``, ``required_modules``,
12
12
  import pytest
13
13
 
14
14
  import partial_rendering
15
+ import plain_spec
15
16
  from change_detection import PartialRenderStart
16
17
  from partial_rendering import (
17
18
  PlainModuleRenderState,
@@ -22,7 +23,14 @@ from partial_rendering import (
22
23
  module_comes_before_or_equal,
23
24
  spec_change,
24
25
  )
25
- from plain2code_exceptions import ModuleDoesNotExistError
26
+ from plain2code_exceptions import MissingPreviousFunctionalitiesError, ModuleDoesNotExistError
27
+
28
+
29
+ def _tree(*frids: str) -> dict:
30
+ """A plain source tree holding the given func-ids, in order."""
31
+ return {
32
+ plain_spec.FUNCTIONAL_REQUIREMENTS: [{"id": frid, "markdown": f"The {frid} functionality."} for frid in frids]
33
+ }
26
34
 
27
35
 
28
36
  class FakeModule:
@@ -37,9 +45,10 @@ class FakeModule:
37
45
  no_rendered_functionality=False,
38
46
  fully_rendered=False,
39
47
  next_frid=None,
40
- plain_source="",
48
+ frids=("fr-a", "fr-b", "fr-c", "fr-d", "fr-e"),
41
49
  ):
42
50
  self.module_name = module_name
51
+ self.build_folder = "plain_modules"
43
52
  self.required_modules = list(required_modules or [])
44
53
  self._metadata = metadata
45
54
  self._source_hash = source_hash if source_hash is not None else f"src-{module_name}"
@@ -48,7 +57,7 @@ class FakeModule:
48
57
  self._no_rendered_functionality = no_rendered_functionality
49
58
  self._fully_rendered = fully_rendered
50
59
  self._next_frid = next_frid
51
- self.plain_source = plain_source
60
+ self.plain_source = _tree(*frids)
52
61
 
53
62
  @property
54
63
  def all_required_modules(self):
@@ -267,51 +276,59 @@ def test_detect_partial_rendering_returns_none_when_nothing_rendered():
267
276
 
268
277
 
269
278
  def test_detect_partial_rendering_no_changes_returns_last_rendered():
270
- root, _middle, leaf = _build_fresh_tree(last_rendered=("leaf", "1"))
279
+ root, _middle, leaf = _build_fresh_tree(last_rendered=("leaf", "fr-a"))
271
280
  pr = get_plain_module_render_state(root)
272
281
  assert isinstance(pr, PlainModuleRenderState)
273
282
  assert pr.last_render_module is leaf
274
- assert pr.last_render_frid == "1"
283
+ assert pr.last_render_frid == "fr-a"
275
284
  assert pr.change is None
276
285
  assert pr.change_type is None
277
286
 
278
287
 
279
288
  def test_detect_partial_rendering_raises_when_last_rendered_module_unknown():
280
- root, _, _ = _build_fresh_tree(last_rendered=("phantom", "1"))
289
+ root, _, _ = _build_fresh_tree(last_rendered=("phantom", "fr-a"))
281
290
  with pytest.raises(ModuleDoesNotExistError, match="phantom"):
282
291
  get_plain_module_render_state(root)
283
292
 
284
293
 
294
+ def test_detect_partial_rendering_rejects_a_frid_the_module_does_not_have():
295
+ """A build folder rendered by a client that numbered the functionalities cannot be continued."""
296
+ root, _, _ = _build_fresh_tree(last_rendered=("leaf", "4"))
297
+
298
+ with pytest.raises(MissingPreviousFunctionalitiesError, match="'4', which the module does not have"):
299
+ get_plain_module_render_state(root)
300
+
301
+
285
302
  def test_detect_partial_rendering_spec_change_on_earlier_module_wins():
286
303
  """A spec change on an earlier (required) module is reported via
287
304
  ``change``/``change_type``; ``last_render_module`` and ``last_render_frid``
288
305
  remain the ones reported by ``get_module_render_status``."""
289
- root, middle, leaf = _build_fresh_tree(last_rendered=("middle", "1"))
306
+ root, middle, leaf = _build_fresh_tree(last_rendered=("middle", "fr-a"))
290
307
  leaf._metadata = {"source_hash": "stale-leaf"} # leaf's spec changed
291
308
 
292
309
  pr = get_plain_module_render_state(root)
293
310
  assert pr.last_render_module is middle
294
311
  assert pr.change is leaf
295
312
  assert pr.change_type == "spec_change"
296
- assert pr.last_render_frid == "1"
313
+ assert pr.last_render_frid == "fr-a"
297
314
 
298
315
 
299
316
  def test_detect_partial_rendering_spec_change_on_top_module_is_reported():
300
317
  """A spec change on the top (root) module is reported on the
301
318
  ``PartialRender``; ``last_render_module``/``last_render_frid`` reflect the
302
319
  module that was last rendered."""
303
- root, _middle, leaf = _build_fresh_tree(last_rendered=("leaf", "1"))
320
+ root, _middle, leaf = _build_fresh_tree(last_rendered=("leaf", "fr-a"))
304
321
  root._metadata = {"source_hash": "stale-root"} # spec change on root
305
322
 
306
323
  pr = get_plain_module_render_state(root)
307
324
  assert pr.last_render_module is leaf
308
325
  assert pr.change is root
309
326
  assert pr.change_type == "spec_change"
310
- assert pr.last_render_frid == "1"
327
+ assert pr.last_render_frid == "fr-a"
311
328
 
312
329
 
313
330
  def test_detect_partial_rendering_code_change_wins_over_last_rendered():
314
- root, middle, leaf = _build_fresh_tree(last_rendered=("middle", "1"))
331
+ root, middle, leaf = _build_fresh_tree(last_rendered=("middle", "fr-a"))
315
332
  middle._metadata = {
316
333
  "source_hash": middle.get_module_source_hash(),
317
334
  "required_modules_code_hash": "stale-code",
@@ -321,7 +338,7 @@ def test_detect_partial_rendering_code_change_wins_over_last_rendered():
321
338
  assert pr.last_render_module is middle
322
339
  assert pr.change is leaf
323
340
  assert pr.change_type == "code_change"
324
- assert pr.last_render_frid == "1"
341
+ assert pr.last_render_frid == "fr-a"
325
342
 
326
343
 
327
344
  def test_detect_partial_rendering_spec_and_code_changes_are_mutually_exclusive():
@@ -330,7 +347,7 @@ def test_detect_partial_rendering_spec_and_code_changes_are_mutually_exclusive()
330
347
  current ``pr.change``. Here both point at ``leaf`` — spec_change returns
331
348
  the module whose spec is stale; code_change returns the previous module
332
349
  whose code has changed — so the code_change branch wins the tie."""
333
- root, middle, leaf = _build_fresh_tree(last_rendered=("middle", "1"))
350
+ root, middle, leaf = _build_fresh_tree(last_rendered=("middle", "fr-a"))
334
351
  # Leaf has a spec change.
335
352
  leaf._metadata = {"source_hash": "stale-leaf"}
336
353
  # Middle records a stale code hash for its required module (leaf).
@@ -343,7 +360,7 @@ def test_detect_partial_rendering_spec_and_code_changes_are_mutually_exclusive()
343
360
  assert pr.last_render_module is middle
344
361
  assert pr.change is leaf
345
362
  assert pr.change_type == "code_change"
346
- assert pr.last_render_frid == "1"
363
+ assert pr.last_render_frid == "fr-a"
347
364
 
348
365
 
349
366
  # -------------------------
@@ -380,21 +397,21 @@ def test_render_choices_no_change_unrendered_module_offers_module_start():
380
397
 
381
398
  def test_render_choices_no_change_interrupted_module_offers_continue(monkeypatch):
382
399
  root, middle, _ = _build_choices_tree()
383
- root._next_frid = ("2", middle)
384
- monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["2", "3"])
385
- pr = PlainModuleRenderState(last_render_module=middle, last_render_frid="1")
400
+ root._next_frid = ("fr-b", middle)
401
+ monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["fr-b", "fr-c"])
402
+ pr = PlainModuleRenderState(last_render_module=middle, last_render_frid="fr-a")
386
403
 
387
404
  choices = get_render_choices(root, pr)
388
405
 
389
406
  assert _choice_types(choices) == ["continue_from_frid", "quit"]
390
407
  assert choices["1"].module is middle
391
- assert choices["1"].render_range == ["2", "3"]
408
+ assert choices["1"].render_range == ["fr-b", "fr-c"]
392
409
 
393
410
 
394
411
  def test_render_choices_no_change_fully_rendered_required_module_starts_next():
395
412
  root, middle, _ = _build_choices_tree()
396
413
  middle._fully_rendered = True
397
- pr = PlainModuleRenderState(last_render_module=middle, last_render_frid="9")
414
+ pr = PlainModuleRenderState(last_render_module=middle, last_render_frid="fr-e")
398
415
 
399
416
  choices = get_render_choices(root, pr)
400
417
 
@@ -405,7 +422,7 @@ def test_render_choices_no_change_fully_rendered_required_module_starts_next():
405
422
 
406
423
  def test_render_choices_no_change_fully_rendered_top_module_rerenders_self():
407
424
  root, _, _ = _build_choices_tree(fully_rendered=True)
408
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9")
425
+ pr = PlainModuleRenderState(last_render_module=root, last_render_frid="fr-e")
409
426
 
410
427
  choices = get_render_choices(root, pr)
411
428
 
@@ -423,10 +440,12 @@ def test_render_choices_spec_change_in_first_module_offers_partial_and_full_rest
423
440
  leaf already is the first module."""
424
441
  root, _, leaf = _build_choices_tree(fully_rendered=True)
425
442
  monkeypatch.setattr(
426
- partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=leaf, frid="1")
443
+ partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=leaf, frid="fr-a")
444
+ )
445
+ monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["fr-a", "fr-b"])
446
+ pr = PlainModuleRenderState(
447
+ last_render_module=root, last_render_frid="fr-e", change=leaf, change_type="spec_change"
427
448
  )
428
- monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["1", "2"])
429
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9", change=leaf, change_type="spec_change")
430
449
 
431
450
  choices = get_render_choices(root, pr)
432
451
 
@@ -435,7 +454,7 @@ def test_render_choices_spec_change_in_first_module_offers_partial_and_full_rest
435
454
  assert "continue_from_frid" not in _choice_types(choices)
436
455
  assert _choice_types(choices) == ["render_from_change", "rerender_affected", "quit"]
437
456
  assert choices["1"].module is leaf
438
- assert choices["1"].render_range == ["1", "2"]
457
+ assert choices["1"].render_range == ["fr-a", "fr-b"]
439
458
  assert choices["2"].module is leaf
440
459
 
441
460
 
@@ -444,10 +463,12 @@ def test_render_choices_spec_change_in_top_module_offers_partial_restart_and_ful
444
463
  scratch, and (3) rebuild everything from the first module — plus quit."""
445
464
  root, _, leaf = _build_choices_tree(fully_rendered=True)
446
465
  monkeypatch.setattr(
447
- partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=root, frid="3")
466
+ partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=root, frid="fr-c")
467
+ )
468
+ monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["fr-c", "fr-d"])
469
+ pr = PlainModuleRenderState(
470
+ last_render_module=root, last_render_frid="fr-e", change=root, change_type="spec_change"
448
471
  )
449
- monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["3", "4"])
450
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9", change=root, change_type="spec_change")
451
472
 
452
473
  choices = get_render_choices(root, pr)
453
474
 
@@ -456,7 +477,7 @@ def test_render_choices_spec_change_in_top_module_offers_partial_restart_and_ful
456
477
  assert _choice_types(choices) == ["render_from_change", "rerender_affected", "rerender_from_first", "quit"]
457
478
  # (1) partial render from the changed functionality in C
458
479
  assert choices["1"].module is root
459
- assert choices["1"].render_range == ["3", "4"]
480
+ assert choices["1"].render_range == ["fr-c", "fr-d"]
460
481
  # (2) re-render the affected module (C) from scratch
461
482
  assert choices["2"].module is root
462
483
  assert choices["2"].render_range is None
@@ -467,7 +488,9 @@ def test_render_choices_spec_change_in_top_module_offers_partial_restart_and_ful
467
488
 
468
489
  def test_render_choices_code_change_suppresses_resume_and_offers_rerender_affected():
469
490
  root, _, leaf = _build_choices_tree(fully_rendered=True)
470
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9", change=leaf, change_type="code_change")
491
+ pr = PlainModuleRenderState(
492
+ last_render_module=root, last_render_frid="fr-e", change=leaf, change_type="code_change"
493
+ )
471
494
 
472
495
  choices = get_render_choices(root, pr)
473
496
 
@@ -482,7 +505,9 @@ def test_render_choices_spec_change_no_partial_start_falls_back_to_full_rerender
482
505
  affected module and the first module are offered for a full re-render."""
483
506
  root, middle, leaf = _build_choices_tree(fully_rendered=True)
484
507
  monkeypatch.setattr(partial_rendering, "determine_partial_render_start", lambda pm: None)
485
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9", change=middle, change_type="spec_change")
508
+ pr = PlainModuleRenderState(
509
+ last_render_module=root, last_render_frid="fr-e", change=middle, change_type="spec_change"
510
+ )
486
511
 
487
512
  choices = get_render_choices(root, pr)
488
513
 
@@ -497,18 +522,20 @@ def test_render_choices_appended_after_render_frontier_auto_continues(monkeypatc
497
522
  """A new functionality appended after the last-rendered one is pure future work: offer
498
523
  only a non-destructive continue, so the renderer resumes without prompting the user."""
499
524
  root, _, _ = _build_choices_tree() # not fully rendered: a new FR sits past the frontier
500
- root._next_frid = ("3", root)
525
+ root._next_frid = ("fr-c", root)
501
526
  monkeypatch.setattr(
502
- partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=root, frid="3")
527
+ partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=root, frid="fr-c")
528
+ )
529
+ monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["fr-c"])
530
+ pr = PlainModuleRenderState(
531
+ last_render_module=root, last_render_frid="fr-b", change=root, change_type="spec_change"
503
532
  )
504
- monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["3"])
505
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="2", change=root, change_type="spec_change")
506
533
 
507
534
  choices = get_render_choices(root, pr)
508
535
 
509
536
  assert _choice_types(choices) == ["continue_from_frid", "quit"]
510
537
  assert choices["1"].module is root
511
- assert choices["1"].render_range == ["3"]
538
+ assert choices["1"].render_range == ["fr-c"]
512
539
  assert choices["1"].is_destructive is False
513
540
 
514
541
 
@@ -517,10 +544,12 @@ def test_render_choices_appended_in_required_module_still_prompts(monkeypatch):
517
544
  before the already-rendered top module, so a decision is still required."""
518
545
  root, middle, leaf = _build_choices_tree(fully_rendered=True)
519
546
  monkeypatch.setattr(
520
- partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=middle, frid="3")
547
+ partial_rendering, "determine_partial_render_start", lambda pm: PartialRenderStart(module=middle, frid="fr-c")
548
+ )
549
+ monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["fr-c"])
550
+ pr = PlainModuleRenderState(
551
+ last_render_module=root, last_render_frid="fr-e", change=middle, change_type="spec_change"
521
552
  )
522
- monkeypatch.setattr(partial_rendering.plain_spec, "get_render_range_from", lambda frid, source: ["3"])
523
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9", change=middle, change_type="spec_change")
524
553
 
525
554
  choices = get_render_choices(root, pr)
526
555
 
@@ -531,7 +560,7 @@ def test_render_choices_appended_in_required_module_still_prompts(monkeypatch):
531
560
 
532
561
  def test_render_choices_always_ends_with_quit():
533
562
  root, _, _ = _build_choices_tree(fully_rendered=True)
534
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9")
563
+ pr = PlainModuleRenderState(last_render_module=root, last_render_frid="fr-e")
535
564
 
536
565
  choices = get_render_choices(root, pr)
537
566
 
@@ -547,25 +576,31 @@ def test_render_choices_always_ends_with_quit():
547
576
 
548
577
  def test_change_is_only_future_work_true_for_append_past_frontier():
549
578
  root, _, _ = _build_choices_tree()
550
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="2", change=root, change_type="spec_change")
551
- assert change_is_only_future_work(root, pr, PartialRenderStart(module=root, frid="3")) is True
579
+ pr = PlainModuleRenderState(
580
+ last_render_module=root, last_render_frid="fr-b", change=root, change_type="spec_change"
581
+ )
582
+ assert change_is_only_future_work(root, pr, PartialRenderStart(module=root, frid="fr-c")) is True
552
583
 
553
584
 
554
585
  def test_change_is_only_future_work_false_for_change_at_or_before_frontier():
555
586
  root, _, _ = _build_choices_tree()
556
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="3", change=root, change_type="spec_change")
587
+ pr = PlainModuleRenderState(
588
+ last_render_module=root, last_render_frid="fr-c", change=root, change_type="spec_change"
589
+ )
557
590
  # Same frid (the changed functionality was already rendered) is not strictly after.
558
- assert change_is_only_future_work(root, pr, PartialRenderStart(module=root, frid="3")) is False
559
- assert change_is_only_future_work(root, pr, PartialRenderStart(module=root, frid="2")) is False
591
+ assert change_is_only_future_work(root, pr, PartialRenderStart(module=root, frid="fr-c")) is False
592
+ assert change_is_only_future_work(root, pr, PartialRenderStart(module=root, frid="fr-b")) is False
560
593
 
561
594
 
562
595
  def test_change_is_only_future_work_false_for_change_in_earlier_module():
563
596
  root, middle, _ = _build_choices_tree()
564
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9", change=middle, change_type="spec_change")
565
- assert change_is_only_future_work(root, pr, PartialRenderStart(module=middle, frid="3")) is False
597
+ pr = PlainModuleRenderState(
598
+ last_render_module=root, last_render_frid="fr-e", change=middle, change_type="spec_change"
599
+ )
600
+ assert change_is_only_future_work(root, pr, PartialRenderStart(module=middle, frid="fr-c")) is False
566
601
 
567
602
 
568
603
  def test_change_is_only_future_work_false_when_no_partial_start():
569
604
  root, _, _ = _build_choices_tree()
570
- pr = PlainModuleRenderState(last_render_module=root, last_render_frid="9")
605
+ pr = PlainModuleRenderState(last_render_module=root, last_render_frid="fr-e")
571
606
  assert change_is_only_future_work(root, pr, None) is False
tests/test_plain2code.py CHANGED
@@ -8,86 +8,84 @@ import plain_spec
8
8
  from plain_modules import PlainModule
9
9
 
10
10
 
11
- def _make_module(module_name, has_acceptance_tests, required_modules=None):
11
+ def _make_module(module_name, has_scenarios, required_modules=None):
12
12
  """Build a minimal stand-in for a PlainModule.
13
13
 
14
- The functional requirements only need an `acceptance_tests` key when the module
15
- is expected to contain acceptance tests, because that is all
16
- `plain_spec.has_acceptance_tests` inspects.
14
+ A functionality carries scenarios only when the module is expected to have a test plain
15
+ file bound to it, because that is all the warning inspects.
17
16
  """
18
- functional_requirement = {"markdown": f"- {module_name} functionality."}
19
- if has_acceptance_tests:
20
- functional_requirement[plain_spec.ACCEPTANCE_TESTS] = [{"markdown": "- Test it."}]
17
+ functionality = {"id": f"{module_name}-functionality", "markdown": f"The {module_name} functionality."}
18
+ if has_scenarios:
19
+ functionality[plain_spec.CONFORMANCE_TESTS] = [{"id": "main-path", "text": "It works."}]
21
20
 
22
21
  return SimpleNamespace(
23
22
  module_name=module_name,
24
- plain_source={plain_spec.FUNCTIONAL_REQUIREMENTS: [functional_requirement]},
23
+ plain_source={plain_spec.FUNCTIONAL_REQUIREMENTS: [functionality]},
25
24
  all_required_modules=required_modules or [],
26
25
  )
27
26
 
28
27
 
29
- def test_warns_when_acceptance_tests_present_and_no_conformance_script():
30
- plain_module = _make_module("top", has_acceptance_tests=True)
31
- args = Namespace(conformance_tests_script=None)
32
-
28
+ def _warn(plain_module, conformance_tests_script=None):
29
+ args = Namespace(conformance_tests_script=conformance_tests_script)
33
30
  with patch("plain2code.console") as mock_console:
34
- plain2code.warn_if_acceptance_tests_without_conformance_script(plain_module, args)
31
+ plain2code.warn_if_scenarios_without_conformance_script(plain_module, args)
32
+ return mock_console
33
+
34
+
35
+ def test_warns_when_scenarios_present_and_no_conformance_script():
36
+ mock_console = _warn(_make_module("top", has_scenarios=True))
35
37
 
36
38
  mock_console.warning.assert_called_once()
37
39
  warning_message = mock_console.warning.call_args.args[0]
38
40
  assert "top" in warning_message
39
- assert "conformance tests script" in warning_message
41
+ assert "no scenario is rendered" in warning_message
40
42
 
41
43
 
42
44
  def test_no_warning_when_conformance_script_configured():
43
- plain_module = _make_module("top", has_acceptance_tests=True)
44
- args = Namespace(conformance_tests_script="run_conformance_tests.sh")
45
-
46
- with patch("plain2code.console") as mock_console:
47
- plain2code.warn_if_acceptance_tests_without_conformance_script(plain_module, args)
45
+ mock_console = _warn(_make_module("top", has_scenarios=True), "run_conformance_tests.sh")
48
46
 
49
47
  mock_console.warning.assert_not_called()
50
48
 
51
49
 
52
- def test_no_warning_when_no_acceptance_tests():
53
- plain_module = _make_module("top", has_acceptance_tests=False)
54
- args = Namespace(conformance_tests_script=None)
55
-
56
- with patch("plain2code.console") as mock_console:
57
- plain2code.warn_if_acceptance_tests_without_conformance_script(plain_module, args)
50
+ def test_no_warning_when_no_scenarios():
51
+ mock_console = _warn(_make_module("top", has_scenarios=False))
58
52
 
59
53
  mock_console.warning.assert_not_called()
60
54
 
61
55
 
62
- def test_warns_when_acceptance_tests_only_in_required_module():
63
- required_module = _make_module("dependency", has_acceptance_tests=True)
64
- plain_module = _make_module("top", has_acceptance_tests=False, required_modules=[required_module])
65
- args = Namespace(conformance_tests_script=None)
56
+ def test_warns_when_an_acceptance_scenario_is_the_only_one():
57
+ plain_module = _make_module("top", has_scenarios=False)
58
+ plain_module.plain_source[plain_spec.FUNCTIONAL_REQUIREMENTS][0][plain_spec.ACCEPTANCE_TESTS] = [
59
+ {"id": "reject-empty-name", "text": "It is rejected."}
60
+ ]
66
61
 
67
- with patch("plain2code.console") as mock_console:
68
- plain2code.warn_if_acceptance_tests_without_conformance_script(plain_module, args)
62
+ _warn(plain_module).warning.assert_called_once()
63
+
64
+
65
+ def test_warns_when_scenarios_only_in_required_module():
66
+ required_module = _make_module("dependency", has_scenarios=True)
67
+ plain_module = _make_module("top", has_scenarios=False, required_modules=[required_module])
68
+
69
+ mock_console = _warn(plain_module)
69
70
 
70
71
  mock_console.warning.assert_called_once()
71
- warning_message = mock_console.warning.call_args.args[0]
72
- assert "dependency" in warning_message
72
+ assert "dependency" in mock_console.warning.call_args.args[0]
73
73
 
74
74
 
75
75
  def test_warning_covers_required_modules_for_real_plain_module(get_test_data_path):
76
- """Integration test: a main module without acceptance tests that requires a
77
- module with acceptance tests should still trigger the warning, naming the
78
- required module. This mirrors the dry-run path which builds a real PlainModule."""
76
+ """Integration test: a main module without scenarios that requires a module with a test
77
+ plain file should still trigger the warning, naming the required module. This mirrors the
78
+ dry-run path which builds a real PlainModule."""
79
79
  fixtures_dir = get_test_data_path("data/acceptance_tests_warning")
80
80
  with tempfile.TemporaryDirectory() as build:
81
81
  plain_module = PlainModule(
82
82
  "main_requiring_acceptance_tests.plain",
83
83
  build,
84
84
  [fixtures_dir],
85
+ [f"{fixtures_dir}/tests"],
85
86
  )
86
87
 
87
- args = Namespace(conformance_tests_script=None)
88
- with patch("plain2code.console") as mock_console:
89
- plain2code.warn_if_acceptance_tests_without_conformance_script(plain_module, args)
88
+ mock_console = _warn(plain_module)
90
89
 
91
90
  mock_console.warning.assert_called_once()
92
- warning_message = mock_console.warning.call_args.args[0]
93
- assert "required_with_acceptance_tests" in warning_message
91
+ assert "required_with_acceptance_tests" in mock_console.warning.call_args.args[0]
@@ -1,6 +1,6 @@
1
1
  """Tests for pure helpers in plain2code_utils."""
2
2
 
3
- from plain2code_utils import format_duration_hms
3
+ from plain2code_utils import format_duration_hms, qualified_frid
4
4
 
5
5
 
6
6
  class TestFormatDurationHms:
@@ -34,3 +34,14 @@ class TestFormatDurationHms:
34
34
 
35
35
  def test_negative_input_clamped_to_zero(self):
36
36
  assert format_duration_hms(-5) == "0s"
37
+
38
+
39
+ class TestQualifiedFrid:
40
+ def test_names_the_module_and_the_func_id(self):
41
+ assert qualified_frid("task-manager", "add-task") == "task-manager:add-task"
42
+
43
+ def test_without_a_module_the_func_id_stands_alone(self):
44
+ assert qualified_frid(None, "add-task") == "add-task"
45
+
46
+ def test_without_a_functionality_there_is_no_name(self):
47
+ assert qualified_frid("task-manager", None) is None