codeplain 0.3.10.dev3__py3-none-any.whl → 0.3.10.dev5__py3-none-any.whl

tests/test_dry_run_link_validation.py

@@ -0,0 +1,60 @@
+"""Regression tests for linked-resource validation during --dry-run.
+
+A linked resource must be a single text-based file. Rendering rejects binary
+targets in ``file_utils.load_linked_resources`` (a failed UTF-8 decode raises
+``UnsupportedResourceType``); dry-run must surface the same errors through
+``plain2code.validate_linked_resources``, which reuses that exact mechanism.
+"""
+
+import pytest
+
+from plain2code import validate_linked_resources
+from plain2code_exceptions import UnsupportedResourceType
+from plain_modules import PlainModule
+
+PLAIN_TEMPLATE = """***definitions***
+
+- :Widget: is an item managed by the application.
+  - Its icon is [the widget resource](resources/{resource_name}).
+
+***implementation reqs***
+
+- Implementation should be in Python.
+
+***functional specs***
+
+- A :Widget: can be created.
+"""
+
+
+def _make_module(tmp_path, monkeypatch, resource_name, resource_bytes):
+    resources_dir = tmp_path / "resources"
+    resources_dir.mkdir()
+    (resources_dir / resource_name).write_bytes(resource_bytes)
+    (tmp_path / "binlink.plain").write_text(PLAIN_TEMPLATE.format(resource_name=resource_name))
+
+    # Link targets are resolved relative to the current working directory at parse time.
+    monkeypatch.chdir(tmp_path)
+    return PlainModule("binlink.plain", str(tmp_path / "build"), [str(tmp_path)])
+
+
+def test_dry_run_validation_rejects_binary_linked_resource(tmp_path, monkeypatch):
+    module = _make_module(tmp_path, monkeypatch, "image.png", b"\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR\xff\xfe\xfd")
+
+    with pytest.raises(UnsupportedResourceType) as exc_info:
+        validate_linked_resources(module)
+
+    assert "resources/image.png" in str(exc_info.value)
+    assert "binary file" in str(exc_info.value)
+
+
+def test_dry_run_validation_accepts_text_file_with_unusual_extension(tmp_path, monkeypatch):
+    module = _make_module(tmp_path, monkeypatch, "notes.xyz123", b"plain text content\n")
+
+    validate_linked_resources(module)
+
+
+def test_dry_run_validation_accepts_empty_file(tmp_path, monkeypatch):
+    module = _make_module(tmp_path, monkeypatch, "empty.txt", b"")
+
+    validate_linked_resources(module)

tests/test_prepare_repositories_layout.py

@@ -18,7 +18,9 @@ from types import SimpleNamespace
 
 import pytest
 
+from conformance_fix_journal import CONFORMANCE_TEST_JOURNAL_SUBFOLDER
 from git_utils import FUNCTIONAL_REQUIREMENT_FINISHED_COMMIT_MESSAGE, add_all_files_and_commit, init_git_repo
+from memory_management import CONFORMANCE_TEST_MEMORY_SUBFOLDER
 from partial_rendering import archive_missing_conformance_tests, get_plain_module_render_state, get_render_choices
 from plain_modules import PlainModule
 from render_machine.actions.prepare_repositories import PrepareRepositories
@@ -115,6 +117,42 @@ def test_fresh_render_without_conformance_tests_does_not_create_tests_folder(sol
     assert not os.path.exists(solo_module.module_conformance_tests_folder)
 
 
+def test_fresh_render_inherits_memories_from_the_previous_module(root_module):
+    """The previous module's distilled memories are copied into the new module's memory store
+    (replacing any stale store), while its fix attempt journals stay behind."""
+    previous = root_module.required_modules[-1]
+    _init_repo_with_finished_frid(previous.module_build_folder, previous.module_name)
+    memory_path = Path(previous.module_memory_folder) / CONFORMANCE_TEST_MEMORY_SUBFOLDER
+    memory_path.mkdir(parents=True)
+    (memory_path / "learning.json").write_text('{"memory_id": "learning"}')
+    journal_path = Path(previous.module_memory_folder) / CONFORMANCE_TEST_JOURNAL_SUBFOLDER
+    journal_path.mkdir(parents=True)
+    (journal_path / "pr_middle__1.jsonl").write_text('{"attempt": 1}\n')
+
+    stale_memory = Path(root_module.module_memory_folder) / CONFORMANCE_TEST_MEMORY_SUBFOLDER / "stale.json"
+    stale_memory.parent.mkdir(parents=True)
+    stale_memory.write_text('{"memory_id": "stale"}')
+
+    render_context = _make_render_context(root_module, render_conformance_tests=False)
+    PrepareRepositories().execute(render_context, None)
+
+    inherited_memory_folder = Path(root_module.module_memory_folder) / CONFORMANCE_TEST_MEMORY_SUBFOLDER
+    assert sorted(os.listdir(inherited_memory_folder)) == ["learning.json"]
+    assert not stale_memory.exists()
+    assert not (Path(root_module.module_memory_folder) / CONFORMANCE_TEST_JOURNAL_SUBFOLDER).exists()
+
+
+def test_fresh_render_with_a_memoryless_previous_module_starts_with_an_empty_store(root_module):
+    previous = root_module.required_modules[-1]
+    _init_repo_with_finished_frid(previous.module_build_folder, previous.module_name)
+
+    render_context = _make_render_context(root_module, render_conformance_tests=False)
+    PrepareRepositories().execute(render_context, None)
+
+    assert os.path.isdir(os.path.join(root_module.module_build_folder, ".git"))
+    assert not os.path.exists(root_module.module_memory_folder)
+
+
 # --------------------------------------------------------------------------
 # ConformanceTests — tests-folder paths
 # --------------------------------------------------------------------------

tui/state_handlers.py

@@ -241,7 +241,13 @@ class ConformanceTestsHandler(StateHandler):
                     self.tui, TUIComponents.FRID_PROGRESS_CONFORMANCE_TEST.value, [Substate(fixing_text)]
                 )
         else:
-            if segments[3] == States.CONFORMANCE_TESTS_READY_FOR_SUMMARY.value:
+            if segments[3] == States.CONFORMANCE_TESTS_READY_FOR_MEMORY_DISTILLATION.value:
+                update_progress_item_substates(
+                    self.tui,
+                    TUIComponents.FRID_PROGRESS_CONFORMANCE_TEST.value,
+                    [Substate("Distilling conformance test fix learnings")],
+                )
+            elif segments[3] == States.CONFORMANCE_TESTS_READY_FOR_SUMMARY.value:
                 update_progress_item_substates(
                     self.tui,
                     TUIComponents.FRID_PROGRESS_CONFORMANCE_TEST.value,