codeforlife-portal 6.44.10__py2.py3-none-any.whl → 6.45.0__py2.py3-none-any.whl

cfl_common/common/helpers/emails.py

@@ -1,6 +1,5 @@
 import datetime
 import json
-import re
 from enum import Enum, auto
 from uuid import uuid4
 
@@ -66,13 +65,14 @@ def send_email(
     django_send_email(sender, recipients, subject, text_content, title, replace_url, plaintext_template, html_template)
 
 
-def send_verification_email(request, user, data, new_email=None, age=None):
+def send_verification_email(request, user, data, new_email=None, age=None, school=None):
     """
     Sends emails relating to email address verification.
 
     On registration:
     - if the user is under 13, send a verification email addressed to the parent / guardian
     - if the user is over 13, send a regular verification email
+    - if the user is a student who just got released, send a verification email explaining the situation
     - if the user is a student who has requested to sign up to the newsletter, handle their Dotmailer subscription
 
     On email address update:
@@ -88,20 +88,28 @@ def send_verification_email(request, user, data, new_email=None, age=None):
     student)
     """
 
-    # verifying first email address (registration)
+    # verifying first email address (registration or unverified login attempt)
     if not new_email:
         verification = generate_token(user)
 
-        # if the user is a teacher
         if age is None:
-            url = f"{request.build_absolute_uri(reverse('verify_email', kwargs={'token': verification}))}"
+            # if the user is a released student
+            if hasattr(user, "new_student") and school is not None:
+                url = f"{request.build_absolute_uri(reverse('verify_email', kwargs={'token': verification}))}"
+
+                send_dotdigital_email(
+                    campaign_ids["verify_released_student"], [user.email],
+                    personalization_values={"VERIFICATION_LINK": url, "SCHOOL_NAME": school.name}
+                )
+            else:
+                url = f"{request.build_absolute_uri(reverse('verify_email', kwargs={'token': verification}))}"
 
-            send_dotdigital_email(
-                campaign_ids["verify_new_user"], [user.email], personalization_values={"VERIFICATION_LINK": url}
-            )
+                send_dotdigital_email(
+                    campaign_ids["verify_new_user"], [user.email], personalization_values={"VERIFICATION_LINK": url}
+                )
 
-            if _newsletter_ticked(data):
-                add_to_dotmailer(user.first_name, user.last_name, user.email, DotmailerUserType.TEACHER)
+                if _newsletter_ticked(data):
+                    add_to_dotmailer(user.first_name, user.last_name, user.email, DotmailerUserType.TEACHER)
         # if the user is an independent student
         else:
             if age < 13:

cfl_common/common/mail.py

@@ -26,6 +26,7 @@ campaign_ids = {
     "verify_new_user_first_reminder": 1557170,
     "verify_new_user_second_reminder": 1557173,
     "verify_new_user_via_parent": 1551587,
+    "verify_released_student": 1580574,
 }
 
 

{codeforlife_portal-6.44.10.dist-info → codeforlife_portal-6.45.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: codeforlife-portal
-Version: 6.44.10
+Version: 6.45.0
 Classifier: Programming Language :: Python
 Classifier: Programming Language :: Python :: 3.8
 Classifier: Framework :: Django
@@ -25,7 +25,7 @@ Requires-Dist: django-classy-tags ==2.0.0
 Requires-Dist: libsass ==0.23.0
 Requires-Dist: phonenumbers ==8.12.12
 Requires-Dist: more-itertools ==8.7.0
-Requires-Dist: cfl-common ==6.44.10
+Requires-Dist: cfl-common ==6.45.0
 Requires-Dist: django-ratelimit ==3.0.1
 Requires-Dist: django-preventconcurrentlogins ==0.8.2
 Requires-Dist: django-csp ==3.7

{codeforlife_portal-6.44.10.dist-info → codeforlife_portal-6.45.0.dist-info}/RECORD

@@ -5,13 +5,13 @@ cfl_common/common/app_settings.py,sha256=x2ROLY5Xl5LgqjxyTiChZvQorZYUXpFzEkaLsjh
 cfl_common/common/apps.py,sha256=49UXZ3bSkFKvIEOL4zM7y1sAhccQJyRtsoOg5XVd_8Y,129
 cfl_common/common/context_processors.py,sha256=X0iuX5qu9kMWa7q8osE9CJ2LgM7pPOYQFGdjm8X3rk0,236
 cfl_common/common/csp_config.py,sha256=sZT6s9zMT5FFIqNODsURT0ifxbDgXpDlki8UxaBq2iE,2940
-cfl_common/common/mail.py,sha256=XPImcfZKcW5mxov04_0jc3xkx_u1SJE6Hhn8K2kPgoA,6354
+cfl_common/common/mail.py,sha256=Lmn7CepceKw1UqxjxTR_24fo7izecw0ihBJ3W_9tcco,6394
 cfl_common/common/models.py,sha256=1e_3zHf8h_K812-2cQymRLZAKoA73_5-t4LQGPQlifE,16946
 cfl_common/common/permissions.py,sha256=gC6RQGZI2QDBbglx-xr_V4Hl2C2nf1V2_uPmEuoEcJo,2416
 cfl_common/common/utils.py,sha256=Nn2Npao9Uqad5Js_IdHwF-ow6wrPNpBLW4AO1LxoEBc,1727
 cfl_common/common/helpers/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 cfl_common/common/helpers/data_migration_loader.py,sha256=_BhS5lPmhcuVUbryBmJytlWdHyT02KYyxPkHar32mOE,1748
-cfl_common/common/helpers/emails.py,sha256=6xY8YxYY3ywcFWguys2G_36HTaBBah4ma1p20s4mpKU,10099
+cfl_common/common/helpers/emails.py,sha256=Gu4YAd977k7v_4qezcYFwWYEBUAV3r8pXZYDVxJL3qw,10700
 cfl_common/common/helpers/generators.py,sha256=kTL5e91I8wgmjJ-mu4jr9vIacjccUZ5pZSAz5cUNhdM,1505
 cfl_common/common/helpers/organisation.py,sha256=e-JKumKoXrkMTzZPv0H4ViWL8vtCt7oXJjn_zZ1ec00,427
 cfl_common/common/migrations/0001_initial.py,sha256=Y2kt2xmdCbrmDXCgqmhXeacicNg26Zj7L7SANSsgAAI,9664
@@ -106,7 +106,7 @@ example_project/portal_test_settings.py,sha256=frp_XMpd-z1g3VFCRxB2w7AaFW2ivRVKn
 example_project/settings.py,sha256=XRZZvASoIl5a9xe3masTq_CUBleuJq9ByHx8f_e2UFc,5613
 example_project/urls.py,sha256=OVeRQ-TCpzHISBRuzqD0yd3ewF7H5U3c-f2p2alfUD0,430
 example_project/wsgi.py,sha256=U1W6WzZxZaIdYZ5tks7w9fqp5WS5qvn2iThsVcskrWw,829
-portal/__init__.py,sha256=DAOvnlpkYOeLySc4ozoUqbAuehzkrm5oNyavRwvs7H4,24
+portal/__init__.py,sha256=oVokL7bm_I6q-ZEmSiMqfc1pQbhzWmTkE47idKwv0l4,23
 portal/admin.py,sha256=on1-zNRnZvf2cwBN6GVRVYRhkaksrCgfzX8XPWtkvz8,6062
 portal/app_settings.py,sha256=DhWLQOwM0zVOXE3O5TNKbMM9K6agfLuCsHOdr1J7xEI,651
 portal/backends.py,sha256=2Dss6_WoQwPuDzJUF1yEaTQTNG4eUrD12ujJQ5cp5Tc,812
@@ -123,7 +123,7 @@ portal/forms/dotmailer.py,sha256=McD9_u8yxUfE7PSVG3MPMilRJtx9GTe9QsNzDDV3uuI,761
 portal/forms/error_messages.py,sha256=8d3z_3e2L-5zwj5hFhnUByC5k2CEpIVVuJg2nYkCUQ8,148
 portal/forms/invite_teacher.py,sha256=jkDNcCfkts4_lXRzhcI3xBam21Zn2yX9wMpMVhDtW1w,880
 portal/forms/organisation.py,sha256=QcQyd7AiqBmvt4y8uQSQylguUbKOKqo2pjqWIkpWjDg,7433
-portal/forms/play.py,sha256=IO0gfKfTv7lXEN1K9w0XG8vY-55obBqLpiEBWaUluZ8,11351
+portal/forms/play.py,sha256=z9P5LzyS3jjYcnfco84d2x8ptgLxRmh94Dnj05plmbY,11505
 portal/forms/registration.py,sha256=gWcY7rllhWO3c9as6QHUDWZx1Jme7DqtGHYaKcvxe-U,5990
 portal/forms/teach.py,sha256=-3dMQxIQtYq2xg5DgtIJMpN7RajNhTvc56Clr5QjsHo,20440
 portal/helpers/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -545,7 +545,7 @@ portal/tests/test_class.py,sha256=V6Fkc6PqdisefKD3xs9PbfE2pKp-9e0gwQVkPUiu6bk,14
 portal/tests/test_daily_activities.py,sha256=-siDCMGBD1ijjccHVk7eEmrk4bgTsvbh0B6hDoj2fo0,1803
 portal/tests/test_emails.py,sha256=xNgOt592r2nrQu7VeBdc8kvSnw6Z5fPJqMx2-UMcyyk,9482
 portal/tests/test_helper_methods.py,sha256=-SQCDZm2XUtyXGEp0CHIb_SSC9CPD-XOSnpnY8QclHk,890
-portal/tests/test_independent_student.py,sha256=jyNpHyisCfkD-CDsjIfSxWnWTxDmkReJ-BdXEBdJoMo,27081
+portal/tests/test_independent_student.py,sha256=mRbWZVwbZKPqHajTd9bYrCAn9ZJLpexpk-YSiZuDAbM,27540
 portal/tests/test_invite_teacher.py,sha256=oeOaoJV1IqJSYPlaPFjnhVXdB2mq8otCTLp_lfjuCfk,12224
 portal/tests/test_middleware.py,sha256=b6jfNmiRZ2snqLKsyJUG-RivoX5fmrqLlQkG9MeVnqM,8034
 portal/tests/test_newsletter_footer.py,sha256=MdVUX53mEoDTa4Krq-jg9LFNo-QyghqvTvhHeNXBGnE,838
@@ -556,7 +556,7 @@ portal/tests/test_school_student.py,sha256=bFZwY4twaFHQLp0cltMq8cLNDZGgCHTZBCZHK
 portal/tests/test_security.py,sha256=FGrlRfnzi-Xx2_bn4fTZlYORKm7w_GhGkD3havvplwc,3239
 portal/tests/test_teacher.py,sha256=_VmQCWq07uCFbvq6Vd7GN00mE7vY7WNMeQTk6bHxFPI,36898
 portal/tests/test_teacher_student.py,sha256=NWITbUw1kijqu3c8eRHLHJKaYQMOsOMvl7PAVx5QghI,21567
-portal/tests/test_views.py,sha256=IElQJnp9fhlmqR-54nBycul2uUIjsG9dTRnYy5SxXJ4,39278
+portal/tests/test_views.py,sha256=g6WQtexZ-UfwpNxpTmfiB-RTBtLFiYBmjAa5oFCSBDk,42073
 portal/tests/migrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 portal/tests/migrations/test_migration_make_portaladmin_teacher.py,sha256=ekMRb6cU97oT0k9gCKW7IUB7oPuGmv4uWJCqInQN7x8,2589
 portal/tests/migrations/test_migration_preview_user_remove.py,sha256=K6D-FZT9YFEA8oMxHz9VTglVV6MZOTRYVlvwWwXc2vU,555
@@ -638,13 +638,13 @@ portal/views/student/edit_account_details.py,sha256=Ba-3D_zzKbX5N01NG5qqBS0ud10B
 portal/views/student/play.py,sha256=r5TADH_wYn3d1beezfvkYBiendQ9qLys9dUJwHqF_44,8581
 portal/views/teacher/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 portal/views/teacher/dashboard.py,sha256=8WglspwuHF__2LtoX5_XvoW1ulICSupjKv--MtjrvJk,25714
-portal/views/teacher/teach.py,sha256=B71jReMJ4BYFmo7NtJVK3-4DeXEwxfu_WA3Ij1RYzdI,34725
+portal/views/teacher/teach.py,sha256=PJAUjLeIBELWc5e2Eek0mr8kYleYWb1MH9FF4O2q7Ok,34779
 portal/views/two_factor/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 portal/views/two_factor/core.py,sha256=O_wcBeFqdPYSGNGv-pT_vbs5-Dj1Z-Jfkd6f9-E5yZI,760
 portal/views/two_factor/form.py,sha256=lnHNKI-BMlpncTuW3zUzjPaJJNuEra2I_nOam0eOKFY,257
 portal/views/two_factor/profile.py,sha256=tkl_ludo8arMtd5LKNmohM66vpC_YQiP-0nspTSJiJ4,383
-codeforlife_portal-6.44.10.dist-info/LICENSE.md,sha256=9AbRlCDqD2D1tPibimysFv3zg3AIc49-eyv9aEsyq9w,115
-codeforlife_portal-6.44.10.dist-info/METADATA,sha256=Sfk3uOefLkZtSMygjh3kRTpcYdv5Kh-PgalkF64N6rQ,3476
-codeforlife_portal-6.44.10.dist-info/WHEEL,sha256=DZajD4pwLWue70CAfc7YaxT1wLUciNBvN_TTcvXpltE,110
-codeforlife_portal-6.44.10.dist-info/top_level.txt,sha256=8e5pdsuIoTqEAMqpelHBjGjLbffcBtgOoggmd2q7nMw,41
-codeforlife_portal-6.44.10.dist-info/RECORD,,
+codeforlife_portal-6.45.0.dist-info/LICENSE.md,sha256=9AbRlCDqD2D1tPibimysFv3zg3AIc49-eyv9aEsyq9w,115
+codeforlife_portal-6.45.0.dist-info/METADATA,sha256=wLw9Jy35iptYZbEN8byRqGpjW7IWIUl9iDNyDJTyBjs,3474
+codeforlife_portal-6.45.0.dist-info/WHEEL,sha256=DZajD4pwLWue70CAfc7YaxT1wLUciNBvN_TTcvXpltE,110
+codeforlife_portal-6.45.0.dist-info/top_level.txt,sha256=8e5pdsuIoTqEAMqpelHBjGjLbffcBtgOoggmd2q7nMw,41
+codeforlife_portal-6.45.0.dist-info/RECORD,,

portal/__init__.py

@@ -1 +1 @@
-__version__ = "6.44.10"
+__version__ = "6.45.0"

portal/forms/play.py

@@ -277,15 +277,19 @@ class StudentJoinOrganisationForm(forms.Form):
 
     def clean(self):
         access_code = self.cleaned_data.get("access_code", None)
+        join_error_text = "The class code you entered either does not exist or is not currently accepting join requests. Please double check that you have entered the correct class code and contact the teacher of the class to ensure their class is currently accepting join requests."
 
         if access_code:
             classes = Class.objects.filter(access_code=access_code)
             if len(classes) != 1:
-                raise forms.ValidationError("Cannot find the school or club and/or class")
+                raise forms.ValidationError(join_error_text)
+
             self.klass = classes[0]
-            if not self.klass.always_accept_requests:
-                if self.klass.accept_requests_until is None:
-                    raise forms.ValidationError("Cannot find the school or club and/or class")
-                elif (self.klass.accept_requests_until - timezone.now()) < timedelta():
-                    raise forms.ValidationError("Cannot find the school or club and/or class")
+
+            if not self.klass.always_accept_requests and (
+                self.klass.accept_requests_until is None
+                or self.klass.accept_requests_until - timezone.now()
+                < timedelta()
+            ):
+                raise forms.ValidationError(join_error_text)
         return self.cleaned_data

portal/tests/test_independent_student.py

@@ -283,7 +283,7 @@ class TestIndependentStudentFrontend(BaseTest):
         page = page.go_to_independent_student_login_page()
         page = page.independent_student_login_failure(username, password)
 
-        errors = page.has_login_failed("independent_student_login_form", INVALID_LOGIN_MESSAGE)
+        page.has_login_failed("independent_student_login_form", INVALID_LOGIN_MESSAGE)
         assert page.has_login_failed("independent_student_login_form", INVALID_LOGIN_MESSAGE)
 
         verification_url = mock_send_dotdigital_email.call_args.kwargs["personalization_values"]["VERIFICATION_LINK"]
@@ -471,7 +471,9 @@ class TestIndependentStudentFrontend(BaseTest):
         )
 
         assert self.is_join_class_page(page)
-        assert page.has_join_request_failed("Cannot find the school or club and/or class")
+        assert page.has_join_request_failed(
+            "The class code you entered either does not exist or is not currently accepting join requests. Please double check that you have entered the correct class code and contact the teacher of the class to ensure their class is currently accepting join requests."
+        )
 
     def test_join_class_not_accepting_requests(self):
         teacher_email, _ = signup_teacher_directly()
@@ -490,7 +492,9 @@ class TestIndependentStudentFrontend(BaseTest):
         )
 
         assert self.is_join_class_page(page)
-        assert page.has_join_request_failed("Cannot find the school or club and/or class")
+        assert page.has_join_request_failed(
+            "The class code you entered either does not exist or is not currently accepting join requests. Please double check that you have entered the correct class code and contact the teacher of the class to ensure their class is currently accepting join requests."
+        )
 
     def test_join_class_revoked(self):
         teacher_email, _ = signup_teacher_directly()

portal/tests/test_views.py

@@ -53,8 +53,11 @@ class TestTeacherViews(TestCase):
     @classmethod
     def setUpTestData(cls):
         cls.email, cls.password = signup_teacher_directly()
+        cls.school = create_organisation_directly(cls.email)
         _, _, cls.class_access_code = create_class_directly(cls.email)
-        _, _, cls.student = create_school_student_directly(cls.class_access_code)
+        _, cls.password_student, cls.student = create_school_student_directly(
+            cls.class_access_code
+        )
 
     def login(self):
         c = Client()
@@ -63,7 +66,9 @@ class TestTeacherViews(TestCase):
 
     def test_reminder_cards(self):
         c = self.login()
-        url = reverse("teacher_print_reminder_cards", args=[self.class_access_code])
+        url = reverse(
+            "teacher_print_reminder_cards", args=[self.class_access_code]
+        )
 
         # First test with 2 dummy students
         NAME1 = "Test name"
@@ -97,7 +102,9 @@ class TestTeacherViews(TestCase):
         # page number
         students_per_page = REMINDER_CARDS_PDF_ROWS * REMINDER_CARDS_PDF_COLUMNS
         for _ in range(len(studentlist), students_per_page + 1):
-            studentlist.append({"name": NAME1, "password": PASSWORD1, "login_url": URL})
+            studentlist.append(
+                {"name": NAME1, "password": PASSWORD1, "login_url": URL}
+            )
 
         assert len(studentlist) == students_per_page + 1
 
@@ -136,7 +143,9 @@ class TestTeacherViews(TestCase):
         reader = csv.reader(io.StringIO(content))
 
         access_code = self.class_access_code
-        class_url = reverse("student_login", kwargs={"access_code": access_code})
+        class_url = reverse(
+            "student_login", kwargs={"access_code": access_code}
+        )
         row0 = next(reader)
         assert row0[0].strip() == access_code
         assert class_url in row0[1].strip()
@@ -175,7 +184,9 @@ class TestTeacherViews(TestCase):
 
     def test_daily_activity_student_details(self):
         c = self.login()
-        url = reverse("teacher_print_reminder_cards", args=[self.class_access_code])
+        url = reverse(
+            "teacher_print_reminder_cards", args=[self.class_access_code]
+        )
 
         data = {
             "data": json.dumps(
@@ -221,6 +232,48 @@ class TestTeacherViews(TestCase):
         with pytest.raises(Exception):
             count_student_details_click("Wrong download method")
 
+    def test_release_verified_student(self):
+        c = Client()
+        student_login_url = reverse(
+            "student_login", args=[self.class_access_code]
+        )
+        response = c.post(
+            student_login_url,
+            {
+                "username": self.student.new_user.first_name,
+                "password": self.password_student,
+            },
+        )
+        assert response.status_code == 302
+
+        student = Student.objects.get(pk=self.student.pk)
+        assert student.user.is_verified
+
+        c.logout()
+        c.login(username=self.email, password=self.password)
+
+        release_url = reverse(
+            "teacher_dismiss_students", args=[self.class_access_code]
+        )
+        response = c.post(
+            release_url,
+            {
+                "form-TOTAL_FORMS": 1,
+                "form-INITIAL_FORMS": 1,
+                "form-MIN_NUM_FORMS": 0,
+                "form-MAX_NUM_FORMS": 1000,
+                "form-0-orig_name": self.student.new_user.first_name,
+                "form-0-name": self.student.new_user.first_name,
+                "form-0-email": "independent@gmail.com",
+                "form-0-confirm_email": "independent@gmail.com",
+                "submit_dismiss": "",
+            },
+        )
+        assert response.status_code == 302
+
+        student = Student.objects.get(pk=self.student.pk)
+        assert not student.user.is_verified
+
 
 class TestLoginViews(TestCase):
     @classmethod
@@ -238,7 +291,9 @@ class TestLoginViews(TestCase):
         teacher_email, teacher_password = signup_teacher_directly()
         create_organisation_directly(teacher_email)
         _, _, class_access_code = create_class_directly(teacher_email)
-        student_name, student_password, _ = create_school_student_directly(class_access_code)
+        student_name, student_password, _ = create_school_student_directly(
+            class_access_code
+        )
 
         return (
             teacher_email,
@@ -271,9 +326,16 @@ class TestLoginViews(TestCase):
         _, _, name, password, class_access_code = self._set_up_test_data()
 
         if next_url:
-            url = reverse("student_login", kwargs={"access_code": class_access_code}) + "?next=/"
+            url = (
+                reverse(
+                    "student_login", kwargs={"access_code": class_access_code}
+                )
+                + "?next=/"
+            )
         else:
-            url = reverse("student_login", kwargs={"access_code": class_access_code})
+            url = reverse(
+                "student_login", kwargs={"access_code": class_access_code}
+            )
 
         c = Client()
         response = c.post(url, {"username": name, "password": password})
@@ -312,7 +374,9 @@ class TestLoginViews(TestCase):
 
     def _get_user_class(self, name, class_access_code):
         klass = Class.objects.get(access_code=class_access_code)
-        students = Student.objects.filter(new_user__first_name__iexact=name, class_field=klass)
+        students = Student.objects.filter(
+            new_user__first_name__iexact=name, class_field=klass
+        )
         assert len(students) == 1
         user = students[0].new_user
         return user, klass
@@ -354,7 +418,9 @@ class TestLoginViews(TestCase):
         _, _, name, password, class_access_code = self._set_up_test_data()
 
         c = Client()
-        url = reverse("student_login", kwargs={"access_code": class_access_code})
+        url = reverse(
+            "student_login", kwargs={"access_code": class_access_code}
+        )
         c.post(url, {"username": name, "password": password})
 
         # check if there's a UserSession data within the last 10 secs
@@ -375,7 +441,9 @@ class TestLoginViews(TestCase):
         randomname = "randomname"
 
         c = Client()
-        url = reverse("student_login", kwargs={"access_code": class_access_code})
+        url = reverse(
+            "student_login", kwargs={"access_code": class_access_code}
+        )
         c.post(url, {"username": randomname, "password": "xx"})
 
         # check if there's a UserSession data within the last 10 secs
@@ -401,7 +469,9 @@ class TestLoginViews(TestCase):
 
     def test_student_direct_login(self):
         _, _, _, _, class_access_code = self._set_up_test_data()
-        student, login_id, _, _ = create_student_with_direct_login(class_access_code)
+        student, login_id, _, _ = create_student_with_direct_login(
+            class_access_code
+        )
 
         c = Client()
         assert c.login(user_id=student.new_user.id, login_id=login_id) == True
@@ -523,7 +593,9 @@ class TestViews(TestCase):
         c = Client()
 
         # Login and check initial data
-        url = reverse("student_login", kwargs={"access_code": class_access_code})
+        url = reverse(
+            "student_login", kwargs={"access_code": class_access_code}
+        )
         c.post(url, {"username": student_name, "password": student_password})
 
         student_dashboard_url = reverse("student_details")
@@ -602,7 +674,9 @@ class TestViews(TestCase):
 
         # try again with the correct password
         url = reverse("delete_account")
-        response = c.post(url, {"password": password, "unsubscribe_newsletter": "on"})
+        response = c.post(
+            url, {"password": password, "unsubscribe_newsletter": "on"}
+        )
 
         assert response.status_code == 302
         mock_send_dotdigital_email.assert_called_once()
@@ -684,7 +758,9 @@ class TestViews(TestCase):
 
         school_id = school.id
         school_name = school.name
-        teachers = Teacher.objects.filter(school=school).order_by("new_user__last_name", "new_user__first_name")
+        teachers = Teacher.objects.filter(school=school).order_by(
+            "new_user__last_name", "new_user__first_name"
+        )
         assert len(teachers) == 3
 
         # one of the remaining teachers should be admin (the second in our case, as it's alphabetical)
@@ -715,7 +791,9 @@ class TestViews(TestCase):
         self.assertEqual(mock_send_dotdigital_email.call_count, 2)
 
         # 2 teachers left
-        teachers = Teacher.objects.filter(school=school).order_by("new_user__last_name", "new_user__first_name")
+        teachers = Teacher.objects.filter(school=school).order_by(
+            "new_user__last_name", "new_user__first_name"
+        )
         assert len(teachers) == 2
 
         # teacher2 should still be admin, teacher4 is not passed admin role because there is teacher2
@@ -727,7 +805,9 @@ class TestViews(TestCase):
         # delete teacher4
         anonymise(user4)
 
-        teachers = Teacher.objects.filter(school=school).order_by("new_user__last_name", "new_user__first_name")
+        teachers = Teacher.objects.filter(school=school).order_by(
+            "new_user__last_name", "new_user__first_name"
+        )
         assert len(teachers) == 1
         u = User.objects.get(id=usrid2)
         assert u.new_teacher.is_admin
@@ -785,13 +865,17 @@ class TestViews(TestCase):
         c.logout()
 
     @patch("common.helpers.emails.send_dotdigital_email")
-    def test_registrations_increment_data(self, mock_send_dotdigital_email: Mock):
+    def test_registrations_increment_data(
+        self, mock_send_dotdigital_email: Mock
+    ):
         c = Client()
 
         total_activity = TotalActivity.objects.get(id=1)
         teacher_registration_count = total_activity.teacher_registrations
         student_registration_count = total_activity.student_registrations
-        independent_registration_count = total_activity.independent_registrations
+        independent_registration_count = (
+            total_activity.independent_registrations
+        )
 
         response = c.post(
             reverse("register"),
@@ -811,7 +895,10 @@ class TestViews(TestCase):
 
         total_activity = TotalActivity.objects.get(id=1)
 
-        assert total_activity.teacher_registrations == teacher_registration_count + 1
+        assert (
+            total_activity.teacher_registrations
+            == teacher_registration_count + 1
+        )
 
         response = c.post(
             reverse("register"),
@@ -833,7 +920,10 @@ class TestViews(TestCase):
 
         total_activity = TotalActivity.objects.get(id=1)
 
-        assert total_activity.independent_registrations == independent_registration_count + 1
+        assert (
+            total_activity.independent_registrations
+            == independent_registration_count + 1
+        )
 
         teacher_email, teacher_password = signup_teacher_directly()
         create_organisation_directly(teacher_email)
@@ -849,7 +939,10 @@ class TestViews(TestCase):
 
         total_activity = TotalActivity.objects.get(id=1)
 
-        assert total_activity.student_registrations == student_registration_count + 3
+        assert (
+            total_activity.student_registrations
+            == student_registration_count + 3
+        )
 
 
 # CRON view tests
@@ -868,8 +961,12 @@ class CronTestClient(APIClient):
         secure=False,
         **extra,
     ):
-        wsgi_response = super().generic(method, path, data, content_type, secure, **extra)
-        assert 200 <= wsgi_response.status_code < 300, f"Response has error status code: {wsgi_response.status_code}"
+        wsgi_response = super().generic(
+            method, path, data, content_type, secure, **extra
+        )
+        assert (
+            200 <= wsgi_response.status_code < 300
+        ), f"Response has error status code: {wsgi_response.status_code}"
 
         return wsgi_response
 
@@ -888,7 +985,9 @@ class TestUser(CronTestCase):
         indy_email, _, _ = create_independent_student_directly()
 
         self.teacher_user = User.objects.get(email=teacher_email)
-        self.teacher_user_profile = UserProfile.objects.get(user=self.teacher_user)
+        self.teacher_user_profile = UserProfile.objects.get(
+            user=self.teacher_user
+        )
 
         self.indy_user = User.objects.get(email=indy_email)
         self.indy_user_profile = UserProfile.objects.get(user=self.indy_user)
@@ -904,11 +1003,17 @@ class TestUser(CronTestCase):
         assert_called: bool,
         mock_send_dotdigital_email: Mock,
     ):
-        self.teacher_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+        self.teacher_user.date_joined = timezone.now() - timedelta(
+            days=days, hours=12
+        )
         self.teacher_user.save()
-        self.student_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+        self.student_user.date_joined = timezone.now() - timedelta(
+            days=days, hours=12
+        )
         self.student_user.save()
-        self.indy_user.date_joined = timezone.now() - timedelta(days=days, hours=12)
+        self.indy_user.date_joined = timezone.now() - timedelta(
+            days=days, hours=12
+        )
         self.indy_user.save()
 
         self.teacher_user_profile.is_verified = is_verified
@@ -919,9 +1024,13 @@ class TestUser(CronTestCase):
         self.client.get(reverse(view_name))
 
         if assert_called:
-            mock_send_dotdigital_email.assert_any_call(ANY, [self.teacher_user.email], personalization_values=ANY)
+            mock_send_dotdigital_email.assert_any_call(
+                ANY, [self.teacher_user.email], personalization_values=ANY
+            )
 
-            mock_send_dotdigital_email.assert_any_call(ANY, [self.indy_user.email], personalization_values=ANY)
+            mock_send_dotdigital_email.assert_any_call(
+                ANY, [self.indy_user.email], personalization_values=ANY
+            )
 
             # Check only two emails are sent - the student should never be included.
             assert mock_send_dotdigital_email.call_count == 2
@@ -931,22 +1040,40 @@ class TestUser(CronTestCase):
         mock_send_dotdigital_email.reset_mock()
 
     def test_first_verify_email_reminder_view(self):
-        self.send_verify_email_reminder(6, False, "first-verify-email-reminder", False)
-        self.send_verify_email_reminder(7, False, "first-verify-email-reminder", True)
-        self.send_verify_email_reminder(7, True, "first-verify-email-reminder", False)
-        self.send_verify_email_reminder(8, False, "first-verify-email-reminder", False)
+        self.send_verify_email_reminder(
+            6, False, "first-verify-email-reminder", False
+        )
+        self.send_verify_email_reminder(
+            7, False, "first-verify-email-reminder", True
+        )
+        self.send_verify_email_reminder(
+            7, True, "first-verify-email-reminder", False
+        )
+        self.send_verify_email_reminder(
+            8, False, "first-verify-email-reminder", False
+        )
 
     def test_second_verify_email_reminder_view(self):
-        self.send_verify_email_reminder(13, False, "second-verify-email-reminder", False)
-        self.send_verify_email_reminder(14, False, "second-verify-email-reminder", True)
-        self.send_verify_email_reminder(14, True, "second-verify-email-reminder", False)
-        self.send_verify_email_reminder(15, False, "second-verify-email-reminder", False)
+        self.send_verify_email_reminder(
+            13, False, "second-verify-email-reminder", False
+        )
+        self.send_verify_email_reminder(
+            14, False, "second-verify-email-reminder", True
+        )
+        self.send_verify_email_reminder(
+            14, True, "second-verify-email-reminder", False
+        )
+        self.send_verify_email_reminder(
+            15, False, "second-verify-email-reminder", False
+        )
 
     def test_anonymise_unverified_accounts_view(self):
         now = timezone.now()
 
         for user in [self.teacher_user, self.indy_user, self.student_user]:
-            user.date_joined = now - timedelta(days=USER_DELETE_UNVERIFIED_ACCOUNT_DAYS + 1)
+            user.date_joined = now - timedelta(
+                days=USER_DELETE_UNVERIFIED_ACCOUNT_DAYS + 1
+            )
             user.save()
 
         for user_profile in [self.teacher_user_profile, self.indy_user_profile]:
@@ -1011,7 +1138,9 @@ class TestUser(CronTestCase):
                 new_user=indy_user,
             )
 
-            activity_today = DailyActivity.objects.get_or_create(date=datetime.now().date())[0]
+            activity_today = DailyActivity.objects.get_or_create(
+                date=datetime.now().date()
+            )[0]
             daily_teacher_count = activity_today.anonymised_unverified_teachers
             daily_indy_count = activity_today.anonymised_unverified_independents
 
@@ -1034,16 +1163,30 @@ class TestUser(CronTestCase):
             assert indy_user_active == assert_active
             assert student_user_active
 
-            activity_today = DailyActivity.objects.get_or_create(date=datetime.now().date())[0]
+            activity_today = DailyActivity.objects.get_or_create(
+                date=datetime.now().date()
+            )[0]
             total_activity = TotalActivity.objects.get(id=1)
 
             if not teacher_user_active:
-                assert activity_today.anonymised_unverified_teachers == daily_teacher_count + 1
-                assert total_activity.anonymised_unverified_teachers == total_teacher_count + 1
+                assert (
+                    activity_today.anonymised_unverified_teachers
+                    == daily_teacher_count + 1
+                )
+                assert (
+                    total_activity.anonymised_unverified_teachers
+                    == total_teacher_count + 1
+                )
 
             if not indy_user_active:
-                assert activity_today.anonymised_unverified_independents == daily_indy_count + 1
-                assert total_activity.anonymised_unverified_independents == total_indy_count + 1
+                assert (
+                    activity_today.anonymised_unverified_independents
+                    == daily_indy_count + 1
+                )
+                assert (
+                    total_activity.anonymised_unverified_independents
+                    == total_indy_count + 1
+                )
 
             teacher_user.delete()
             indy_user.delete()

portal/views/teacher/teach.py

@@ -552,15 +552,16 @@ def process_dismiss_student_form(request, formset, klass, access_code):
         student.new_user.first_name = data["name"]
         student.new_user.username = data["email"]
         student.new_user.email = data["email"]
+        student.user.is_verified = False
         student.save()
         student.new_user.save()
-        student.new_user.userprofile.save()
+        student.user.save()
 
         # log the data
         joinrelease = JoinReleaseStudent.objects.create(student=student, action_type=JoinReleaseStudent.RELEASE)
         joinrelease.save()
 
-        send_verification_email(request, student.new_user, data)
+        send_verification_email(request, student.new_user, data, school=klass.teacher.school)
 
     if not failed_users:
         messages.success(request, "The students have been released successfully from the class.")