codeforlife-portal 5.33.5__py2.py3-none-any.whl → 8.9.9__py2.py3-none-any.whl

portal/tests/test_teacher_student.py

@@ -1,13 +1,11 @@
 from __future__ import absolute_import
 
 import json
-import pytest
-
-from django.test import Client
-from django.urls import reverse
-from django.contrib.auth.models import User
-from selenium.webdriver.common.alert import Alert
+import time
+from unittest.mock import Mock, patch
 
+import pytest
+from common.models import JoinReleaseStudent
 from common.tests.utils.classes import create_class_directly
 from common.tests.utils.organisation import (
     create_organisation_directly,
@@ -20,13 +18,18 @@ from common.tests.utils.student import (
     create_student_with_direct_login,
 )
 from common.tests.utils.teacher import signup_teacher_directly
+from django.contrib.auth.models import User
+from django.test import Client
+from django.urls import reverse
+from selenium.webdriver.common.alert import Alert
+from selenium.webdriver.common.by import By
 
 from portal.tests.pageObjects.portal.home_page import HomePage
 from .base_test import BaseTest
 
 
-class TestTeacherStudent(BaseTest):
-    def test_create(self):
+class TestTeacherStudentFrontend(BaseTest):
+    def test_create_valid_name(self):
         email, password = signup_teacher_directly()
         create_organisation_directly(email)
         create_class_directly(email)
@@ -36,52 +39,20 @@ class TestTeacherStudent(BaseTest):
             HomePage(self.selenium)
             .go_to_teacher_login_page()
             .login_no_students(email, password)
+            .open_classes_tab()
+            .go_to_class_page()
         )
 
-        page, student_name = create_school_student(page)
-        assert page.student_exists(student_name)
-
-        assert page.__class__.__name__ == "OnboardingStudentListPage"
-
-    def test_create_valid_name_dash(self):
-        email, password = signup_teacher_directly()
-        create_organisation_directly(email)
-        create_class_directly(email)
-
         student_name = "Florian-Gilbert"
+        page = page.type_student_name(student_name)
 
-        self.selenium.get(self.live_server_url)
-        page = (
-            HomePage(self.selenium)
-            .go_to_teacher_login_page()
-            .login_no_students(email, password)
-        )
-
-        page = page.type_student_name(student_name).create_students()
-
-        assert page.student_exists(student_name)
-
-        assert page.__class__.__name__ == "OnboardingStudentListPage"
-
-    def test_create_valid_name_underscore(self):
-        email, password = signup_teacher_directly()
-        create_organisation_directly(email)
-        create_class_directly(email)
+        student_name2 = "Florian_Gilbert"
+        page = page.type_student_name(student_name2)
 
-        student_name = "Florian_Gilbert"
-
-        self.selenium.get(self.live_server_url)
-        page = (
-            HomePage(self.selenium)
-            .go_to_teacher_login_page()
-            .login_no_students(email, password)
-        )
-
-        page = page.type_student_name(student_name).create_students()
+        page.click_create_students()
 
         assert page.student_exists(student_name)
-
-        assert page.__class__.__name__ == "OnboardingStudentListPage"
+        assert page.student_exists(student_name2)
 
     def test_create_invalid_name(self):
         email, password = signup_teacher_directly()
@@ -95,14 +66,15 @@ class TestTeacherStudent(BaseTest):
             HomePage(self.selenium)
             .go_to_teacher_login_page()
             .login_no_students(email, password)
+            .open_classes_tab()
+            .go_to_class_page()
         )
 
-        page = page.type_student_name(student_name).create_students_failure()
+        page = page.type_student_name(student_name).click_create_students()
 
         assert page.adding_students_failed()
         assert page.was_form_invalid(
-            "form-create-students",
-            "Names may only contain letters, numbers, dashes, underscores, and spaces.",
+            "form-create-students", "Names may only contain letters, numbers, dashes, underscores, and spaces."
         )
 
     def test_create_multiple(self):
@@ -115,6 +87,8 @@ class TestTeacherStudent(BaseTest):
             HomePage(self.selenium)
             .go_to_teacher_login_page()
             .login_no_students(email, password)
+            .open_classes_tab()
+            .go_to_class_page()
         )
 
         page, student_names = create_many_school_students(page, 12)
@@ -134,13 +108,11 @@ class TestTeacherStudent(BaseTest):
             HomePage(self.selenium)
             .go_to_teacher_login_page()
             .login_no_students(email, password)
+            .open_classes_tab()
+            .go_to_class_page()
         )
 
-        page = (
-            page.type_student_name(student_name)
-            .type_student_name(student_name)
-            .create_students_failure()
-        )
+        page = page.type_student_name(student_name).type_student_name(student_name).click_create_students()
         assert page.adding_students_failed()
         assert page.duplicate_students(student_name)
 
@@ -154,6 +126,8 @@ class TestTeacherStudent(BaseTest):
             HomePage(self.selenium)
             .go_to_teacher_login_page()
             .login_no_students(email, password)
+            .open_classes_tab()
+            .go_to_class_page()
             .import_students_from_csv("test_students_names.csv")
         )
 
@@ -172,6 +146,8 @@ class TestTeacherStudent(BaseTest):
             .import_students_from_csv("test_students_names_no_name.csv")
         )
 
+        time.sleep(1)
+
         alert = Alert(page.browser)
         assert alert.text == "'Name' column not found in CSV file."
         alert.dismiss()
@@ -210,6 +186,8 @@ class TestTeacherStudent(BaseTest):
             .import_students_from_csv("test_students_names_no_name.csv")
         )
 
+        time.sleep(1)
+
         alert = Alert(page.browser)
         assert alert.text == "'Name' column not found in CSV file."
         alert.dismiss()
@@ -258,10 +236,7 @@ class TestTeacherStudent(BaseTest):
         login_url = page.get_first_login_url()
         page.browser.get(login_url)
         assert page.on_correct_page("play_dashboard_page")
-        assert (
-            new_student_name
-            in page.browser.find_element_by_xpath("//div[@class='header']").text
-        )
+        assert new_student_name in page.browser.find_element(By.XPATH, "//div[@class='header']").text
 
     def test_update_student_name(self):
         email, password = signup_teacher_directly()
@@ -366,8 +341,7 @@ class TestTeacherStudent(BaseTest):
 
         assert page.is_student_name(name)
         assert page.was_form_invalid(
-            "form-edit-student",
-            "Names may only contain letters, numbers, dashes, underscores, and spaces.",
+            "form-edit-student", "Names may only contain letters, numbers, dashes, underscores, and spaces."
         )
 
     def test_update_student_password(self):
@@ -388,7 +362,7 @@ class TestTeacherStudent(BaseTest):
 
         assert page.is_student_name(name)
 
-        new_student_password = "New_password1"
+        new_student_password = "£EDCVFR$5tgb"
 
         page = page.type_student_password(new_student_password)
         page = page.click_set_password_button()
@@ -420,18 +394,13 @@ class TestTeacherStudent(BaseTest):
 
         # user/student is removed if they never log in (see below for active student)
         with pytest.raises(User.DoesNotExist):
-            u = User.objects.get(id=student.new_user.id)
+            User.objects.get(id=student.new_user.id)
 
     def test_delete_active_student(self):
         email, password = signup_teacher_directly()
         create_organisation_directly(email)
         _, _, access_code = create_class_directly(email)
-        (
-            student,
-            login_id,
-            student_name,
-            student_password,
-        ) = create_student_with_direct_login(access_code)
+        student, login_id, student_name, student_password = create_student_with_direct_login(access_code)
 
         # "active student" is one who has logged in
         c = Client()
@@ -449,7 +418,7 @@ class TestTeacherStudent(BaseTest):
         # user should be anonymised
         u = User.objects.get(id=student.new_user.id)
         assert u.first_name == "Deleted"
-        assert u.is_active == False
+        assert not u.is_active
 
         student.refresh_from_db()
         assert student.login_id == ""
@@ -489,7 +458,7 @@ class TestTeacherStudent(BaseTest):
         email, password = signup_teacher_directly()
         create_organisation_directly(email)
         _, _, access_code = create_class_directly(email)
-        _, _, _ = create_school_student_directly(access_code)
+        create_school_student_directly(access_code)
 
         self.selenium.get(self.live_server_url)
         page = (
@@ -512,10 +481,10 @@ class TestTeacherStudent(BaseTest):
     def test_move_cancel_disambiguate(self):
         old_teacher_email, password_1 = signup_teacher_directly()
         email_2, _ = signup_teacher_directly()
-        org_name, postcode = create_organisation_directly(old_teacher_email)
-        join_teacher_to_organisation(email_2, org_name, postcode)
+        school = create_organisation_directly(old_teacher_email)
+        join_teacher_to_organisation(email_2, school.name)
         _, _, access_code_1 = create_class_directly(old_teacher_email)
-        _, _, _ = create_class_directly(email_2)
+        create_class_directly(email_2)
         student_name, _, _ = create_school_student_directly(access_code_1)
 
         self.selenium.get(self.live_server_url)
@@ -537,12 +506,15 @@ class TestTeacherStudent(BaseTest):
     def test_move(self):
         email_1, password_1 = signup_teacher_directly()
         email_2, password_2 = signup_teacher_directly()
-        org_name, postcode = create_organisation_directly(email_1)
-        join_teacher_to_organisation(email_2, org_name, postcode)
+        school = create_organisation_directly(email_1)
+        join_teacher_to_organisation(email_2, school.name)
         _, _, access_code_1 = create_class_directly(email_1)
-        _, _, _ = create_class_directly(email_2)
+        create_class_directly(email_2)
         student_name_1, _, _ = create_school_student_directly(access_code_1)
         student_name_2, _, _ = create_school_student_directly(access_code_1)
+        # Sort student names alphabetically to match the UI
+        if student_name_1 > student_name_2:
+            student_name_1, student_name_2 = student_name_2, student_name_1
 
         self.selenium.get(self.live_server_url)
         page = (
@@ -561,21 +533,15 @@ class TestTeacherStudent(BaseTest):
 
         page = page.go_to_dashboard()
 
-        page = (
-            page.logout()
-            .go_to_teacher_login_page()
-            .login(email_2, password_2)
-            .open_classes_tab()
-            .go_to_class_page()
-        )
+        page = page.logout().go_to_teacher_login_page().login(email_2, password_2).open_classes_tab().go_to_class_page()
         assert page.student_exists(student_name_1)
 
-    def test_dismiss(self):
+    @patch("common.helpers.emails.send_dotdigital_email")
+    def test_dismiss(self, mock_send_dotdigital_email: Mock):
         email, password = signup_teacher_directly()
         create_organisation_directly(email)
         _, _, access_code = create_class_directly(email)
-        student_name_1, _, _ = create_school_student_directly(access_code)
-        _, _, _ = create_school_student_directly(access_code)
+        student_name_1, _, student = create_school_student_directly(access_code)
 
         self.selenium.get(self.live_server_url)
         page = (
@@ -592,10 +558,56 @@ class TestTeacherStudent(BaseTest):
         page = page.cancel()
         assert page.__class__.__name__ == "TeachClassPage"
 
+        page = page.toggle_select_student().dismiss_students().enter_email("student_email@gmail.com").dismiss()
+        assert not page.student_exists(student_name_1)
+
+        # check whether a record is created correctly
+        logs = JoinReleaseStudent.objects.filter(student=student)
+        assert len(logs) == 1
+        assert logs[0].action_type == JoinReleaseStudent.RELEASE
+
+        mock_send_dotdigital_email.assert_called()
+
+    @patch("common.helpers.emails.send_dotdigital_email")
+    def test_multiple_dismiss(self, mock_send_dotdigital_email: Mock):
+        email, password = signup_teacher_directly()
+        create_organisation_directly(email)
+        _, _, access_code = create_class_directly(email)
+        student_name_1, _, student = create_school_student_directly(access_code)
+        student_name_2, _, student_2 = create_school_student_directly(access_code)
+
+        self.selenium.get(self.live_server_url)
         page = (
-            page.toggle_select_student()
-            .dismiss_students()
-            .enter_email("student_email@gmail.com")
-            .dismiss()
+            HomePage(self.selenium)
+            .go_to_teacher_login_page()
+            .login(email, password)
+            .open_classes_tab()
+            .go_to_class_page()
         )
+        assert page.student_exists(student_name_1)
+        assert page.student_exists(student_name_2)
+
+        page = page.toggle_all_students()
+        page = page.dismiss_students()
+
+        # dismiss with the same email address
+        SAME_EMAIL = "student_email@gmail.com"
+        page = page.enter_email(SAME_EMAIL, 0)
+        page = page.enter_email(SAME_EMAIL, 1)
+        page = page.dismiss()
+
+        # the first should be released, the second not
         assert not page.student_exists(student_name_1)
+        assert page.student_exists(student_name_2)
+
+        # dismiss using teacher's email
+        page = page.toggle_all_students()
+        page = page.dismiss_students()
+
+        page = page.enter_email(email, 0)
+        page = page.dismiss()
+
+        # student should still exist
+        assert page.student_exists(student_name_2)
+
+        mock_send_dotdigital_email.assert_called()