code-coordinator 0.5.46__py3-none-any.whl

coord/dashboard/webapp/src/components/__tests__/PipelineCard.test.tsx

@@ -0,0 +1,143 @@
+/**
+ * Component tests for PipelineCard and the Home-screen filter functions.
+ *
+ * These use vitest + @testing-library/react.  Run with `npm test` (or
+ * `npx vitest run`) after `npm install`.
+ */
+import { describe, it, expect, vi } from 'vitest'
+import { render, screen } from '@testing-library/react'
+import userEvent from '@testing-library/user-event'
+import { PipelineCard } from '@/components/PipelineCard'
+import { type PipelineView } from '@/api/client'
+
+// ── Test helpers ──────────────────────────────────────────────────────────────
+
+function makeView(overrides: Partial<PipelineView> = {}): PipelineView {
+  return {
+    assignment_id: 'work-1',
+    issue_number: 42,
+    issue_title: 'Fix the thing',
+    repo_name: 'myrepo',
+    machine_name: 'laptop',
+    current_stage: 'coding',
+    stages: [
+      { name: 'coding', status: 'active', is_current: true },
+      { name: 'review', status: 'waiting', is_current: false },
+      { name: 'smoke',  status: 'waiting', is_current: false },
+      { name: 'merge',  status: 'waiting', is_current: false },
+    ],
+    available_gates: [],
+    progress_pct: 10,
+    review_findings_pending: false,
+    review_verdict: null,
+    // #1456: null = the reviewer's own verdict stands (the normal case).
+    review_verdict_original: null,
+    review_verdict_override_reason: null,
+    review_findings_body: null,
+    test_verdict: null,
+    needs_attention: false,
+    needs_attention_reason: null,
+    needs_attention_detail: null,
+    finished_at: null,
+    ...overrides,
+  }
+}
+
+// ── PipelineCard rendering ────────────────────────────────────────────────────
+
+describe('PipelineCard', () => {
+  it('renders issue title, repo, issue number, and machine', () => {
+    render(<PipelineCard view={makeView()} onClick={() => undefined} />)
+
+    // The card is a button — scope assertions to it to avoid ambiguity
+    const card = screen.getByRole('button')
+    expect(card).toHaveTextContent('Fix the thing')
+    expect(card).toHaveTextContent('#42')
+    expect(card).toHaveTextContent('myrepo')
+    expect(card).toHaveTextContent('laptop')
+  })
+
+  it('renders stage chips with display names (coding→work, smoke→test)', () => {
+    render(<PipelineCard view={makeView()} onClick={() => undefined} />)
+
+    expect(screen.getByText('work')).toBeInTheDocument()
+    expect(screen.getByText('review')).toBeInTheDocument()
+    expect(screen.getByText('test')).toBeInTheDocument()
+    expect(screen.getByText('merge')).toBeInTheDocument()
+  })
+
+  it('shows "running" status badge when current_stage is coding', () => {
+    render(<PipelineCard view={makeView({ current_stage: 'coding' })} onClick={() => undefined} />)
+    expect(screen.getByText('running')).toBeInTheDocument()
+  })
+
+  it('shows "failed" status badge for failed stage', () => {
+    const view = makeView({
+      current_stage: 'failed',
+      stages: [
+        { name: 'coding', status: 'active', is_current: true },
+        { name: 'review', status: 'waiting', is_current: false },
+        { name: 'smoke',  status: 'waiting', is_current: false },
+        { name: 'merge',  status: 'waiting', is_current: false },
+      ],
+    })
+    render(<PipelineCard view={view} onClick={() => undefined} />)
+    expect(screen.getByText('failed')).toBeInTheDocument()
+  })
+
+  it('shows "mergeable" badge when current_stage is merge_ready', () => {
+    const view = makeView({
+      current_stage: 'merge_ready',
+      stages: [
+        { name: 'coding', status: 'completed', is_current: false },
+        { name: 'review', status: 'completed', is_current: false },
+        { name: 'smoke',  status: 'completed', is_current: false },
+        { name: 'merge',  status: 'active', is_current: true },
+      ],
+      available_gates: [{ action: 'merge', label: 'Merge', endpoint: '/api/pipeline/action' }],
+    })
+    render(<PipelineCard view={view} onClick={() => undefined} />)
+    expect(screen.getByText('mergeable')).toBeInTheDocument()
+  })
+
+  it('shows review findings pending warning', () => {
+    render(
+      <PipelineCard
+        view={makeView({ review_findings_pending: true })}
+        onClick={() => undefined}
+      />,
+    )
+    expect(screen.getByText(/Review findings not yet posted/)).toBeInTheDocument()
+  })
+
+  it('calls onClick when the card is pressed', async () => {
+    const onClick = vi.fn()
+    render(<PipelineCard view={makeView()} onClick={onClick} />)
+    await userEvent.click(screen.getByRole('button'))
+    expect(onClick).toHaveBeenCalledOnce()
+  })
+})
+
+// ── Filter logic (unit-tested here since filterFns are co-located in Home) ────
+
+describe('filter helpers', () => {
+  it('isActive excludes merged items', () => {
+    const active = makeView({ current_stage: 'coding' })
+    const merged = makeView({ current_stage: 'merged' })
+    // Re-implement the predicate inline to keep the test independent of
+    // Home's internal state.  Tests document the contract.
+    const isActive = (v: PipelineView) => v.current_stage !== 'merged'
+    expect(isActive(active)).toBe(true)
+    expect(isActive(merged)).toBe(false)
+  })
+
+  it('needsMe returns true when available_gates is non-empty', () => {
+    const noAction = makeView({ available_gates: [] })
+    const hasAction = makeView({
+      available_gates: [{ action: 'merge', label: 'Merge', endpoint: '/api/pipeline/action' }],
+    })
+    const needsMe = (v: PipelineView) => v.available_gates.length > 0
+    expect(needsMe(noAction)).toBe(false)
+    expect(needsMe(hasAction)).toBe(true)
+  })
+})

coord/dashboard/webapp/src/components/__tests__/SessionCard.test.tsx

@@ -0,0 +1,106 @@
+/**
+ * Component tests for SessionCard.
+ */
+import { describe, it, expect, vi } from 'vitest'
+import { render, screen } from '@testing-library/react'
+import userEvent from '@testing-library/user-event'
+import { SessionCard } from '@/components/SessionCard'
+import { type SessionInfo } from '@/api/client'
+
+// ── Test helpers ──────────────────────────────────────────────────────────────
+
+function makeSession(overrides: Partial<SessionInfo> = {}): SessionInfo {
+  return {
+    session_id: 'work-1',
+    session_name: 'coord-work-1',
+    machine: 'laptop',
+    host: 'laptop.tailnet.ts.net',
+    repo: 'myrepo',
+    issue: 42,
+    issue_title: 'Fix the thing',
+    stage: 'work',
+    status: 'running',
+    attached: false,
+    pane_dead: false,
+    ...overrides,
+  }
+}
+
+describe('SessionCard', () => {
+  it('renders issue title, repo, issue number, and machine', () => {
+    render(<SessionCard session={makeSession()} onClick={() => undefined} />)
+
+    const card = screen.getByRole('button')
+    expect(card).toHaveTextContent('Fix the thing')
+    expect(card).toHaveTextContent('#42')
+    expect(card).toHaveTextContent('myrepo')
+    expect(card).toHaveTextContent('laptop')
+  })
+
+  it('falls back to the tmux session name when no assignment is tracked', () => {
+    render(
+      <SessionCard
+        session={makeSession({ issue_title: null, repo: null, issue: null, machine: null })}
+        onClick={() => undefined}
+      />,
+    )
+    expect(screen.getByRole('button')).toHaveTextContent('coord-work-1')
+  })
+
+  it('shows "live" badge for an untouched running session', () => {
+    render(<SessionCard session={makeSession()} onClick={() => undefined} />)
+    expect(screen.getByText('live')).toBeInTheDocument()
+  })
+
+  it('shows "attached" badge when a client is already attached', () => {
+    render(<SessionCard session={makeSession({ attached: true })} onClick={() => undefined} />)
+    expect(screen.getByText('attached')).toBeInTheDocument()
+  })
+
+  it('shows "ended" badge when the pane is dead', () => {
+    render(<SessionCard session={makeSession({ pane_dead: true })} onClick={() => undefined} />)
+    expect(screen.getByText('ended')).toBeInTheDocument()
+  })
+
+  it('calls onClick when the card is pressed', async () => {
+    const onClick = vi.fn()
+    render(<SessionCard session={makeSession()} onClick={onClick} />)
+    await userEvent.click(screen.getByRole('button'))
+    expect(onClick).toHaveBeenCalledOnce()
+  })
+
+  // ── Assignment-type chip (#1276) ──────────────────────────────────────────
+
+  it('shows a "work" chip for a work session', () => {
+    render(<SessionCard session={makeSession({ stage: 'work' })} onClick={() => undefined} />)
+    expect(screen.getByText('work')).toBeInTheDocument()
+  })
+
+  it('shows a "test" chip for a smoke session', () => {
+    render(<SessionCard session={makeSession({ stage: 'smoke' })} onClick={() => undefined} />)
+    expect(screen.getByText('test')).toBeInTheDocument()
+  })
+
+  it('shows a "review" chip for a review session', () => {
+    render(<SessionCard session={makeSession({ stage: 'review' })} onClick={() => undefined} />)
+    expect(screen.getByText('review')).toBeInTheDocument()
+  })
+
+  it('shows a "merge" chip for a real merge session (assignment.type is "conflict-fix", never "merge")', () => {
+    render(<SessionCard session={makeSession({ stage: 'conflict-fix' })} onClick={() => undefined} />)
+    expect(screen.getByText('merge')).toBeInTheDocument()
+  })
+
+  it('falls back to the raw assignment type when it has no ASSIGNMENT_TYPE_LABEL entry', () => {
+    render(<SessionCard session={makeSession({ stage: 'fix' })} onClick={() => undefined} />)
+    expect(screen.getByText('fix')).toBeInTheDocument()
+  })
+
+  it('renders no stage chip when stage is null', () => {
+    render(<SessionCard session={makeSession({ stage: null })} onClick={() => undefined} />)
+    // Only the status badge ("live") should render — no orphan chip for a
+    // session without a resolvable assignment.
+    expect(screen.queryByText('work')).not.toBeInTheDocument()
+    expect(screen.getByText('live')).toBeInTheDocument()
+  })
+})