cloud-governance 1.1.380__py3-none-any.whl → 1.1.381__py3-none-any.whl

cloud_governance/common/clouds/aws/iam/iam_operations.py

@@ -222,11 +222,14 @@ class IAMOperations:
                         if last_used_date:
                             last_used_days = (now - last_used_date).days
                         else:
-                            last_used_days = "N/A"
+                            # when no last used date is available, get the age of the key
+                            last_used_days = age_days
                     except Exception:
-                        last_used_days = "N/A"
+                        # Set None in case of error to avoid deletion, not "N/A" because it will take age time
+                        logger.error(f"Failed to get last used date for access key")
+                        last_used_days = None
 
-                    result[username][label] = {'label': label, 'status': status, 'age_days': age_days, 'last_activity_days': last_used_days if last_used_days is not None else "N/A"}
+                    result[username][label] = {'label': label, 'status': status, 'age_days': age_days, 'last_activity_days': last_used_days}
 
                 # Tags as list of dicts
                 try:

cloud_governance/main/environment_variables.py

@@ -185,6 +185,7 @@ class EnvironmentVariables:
         self._environment_variables_dict['RESOURCE_TO_TAG'] = EnvironmentVariables.get_env('RESOURCE_TO_TAG', '')
 
         # Common env vars
+        # when dry_run='no', choose FORCE_DELETE=True and update self._resource_id in abstract_policy_operations.py
         self._environment_variables_dict['dry_run'] = EnvironmentVariables.get_env('dry_run', 'yes')
         self._environment_variables_dict['FORCE_DELETE'] = EnvironmentVariables.get_boolean_from_environment(
             'FORCE_DELETE', False)

cloud_governance/policy/aws/unused_access_key.py

@@ -21,15 +21,12 @@ class UnusedAccessKey(AWSPolicyOperations):
                 if 'access key' in access_key_label.lower():
                     last_activity_days = access_key_data['last_activity_days']
                     age_days = access_key_data['age_days']
-                    # if access key last_activity_days is "N/A", use age_days
-                    if last_activity_days == "N/A":
-                        last_activity_days = age_days
                     region = user_data['region']
                     user_name = username
                     tags = user_data.get('Tags', [])
                     cleanup_result = False
                     cleanup_days = 0
-                    if int(last_activity_days) >= UNUSED_ACCESS_KEY_DAYS and self._has_active_access_keys(user_name, access_key_label) and self.get_skip_policy_value(tags=tags) not in ('NOTDELETE', 'SKIP'):
+                    if last_activity_days and int(last_activity_days) >= UNUSED_ACCESS_KEY_DAYS and self._has_active_access_keys(user_name, access_key_label) and self.get_skip_policy_value(tags=tags) not in ('NOTDELETE', 'SKIP'):
                         cleanup_days = self.get_clean_up_days_count(tags=tags)
                         cleanup_result = self.verify_and_delete_resource(resource_id=user_name, tags=tags,
                                                                          clean_up_days=cleanup_days, access_key_label=access_key_label)

{cloud_governance-1.1.380.dist-info → cloud_governance-1.1.381.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cloud-governance
-Version: 1.1.380
+Version: 1.1.381
 Summary: Cloud Governance Tool
 Home-page: https://github.com/redhat-performance/cloud-governance
 Author: Red Hat

{cloud_governance-1.1.380.dist-info → cloud_governance-1.1.381.dist-info}/RECORD

@@ -51,7 +51,7 @@ cloud_governance/common/clouds/aws/dynamodb/dynamodb_operations.py,sha256=eeV3Yg
 cloud_governance/common/clouds/aws/ec2/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 cloud_governance/common/clouds/aws/ec2/ec2_operations.py,sha256=0ibMvf7nqyK9MCRhxrg11xnOPELqsZIQsZUgd6_neKc,24680
 cloud_governance/common/clouds/aws/iam/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-cloud_governance/common/clouds/aws/iam/iam_operations.py,sha256=QXRevArr3OjSOIDhAAc61iZyZZSMGxI97ezySOgdqv8,11485
+cloud_governance/common/clouds/aws/iam/iam_operations.py,sha256=cQWh1iJdlQCGVcZcQF6aDt8fQrKnv6n-361xALNQ7QQ,11732
 cloud_governance/common/clouds/aws/price/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 cloud_governance/common/clouds/aws/price/price.py,sha256=Ju76WniNTVujQPi6QFRgLt6Jd8gsxL2FOnN7c1et5F0,6403
 cloud_governance/common/clouds/aws/price/resources_pricing.py,sha256=k-hucUvxpZfF126wLQQwJt3BzNQiOoSU1x6gjIQ_4cM,6253
@@ -143,7 +143,7 @@ cloud_governance/common/utils/configs.py,sha256=shFxWt0Kc-GwzcZKYCkHm058ujwdTxn4
 cloud_governance/common/utils/json_datetime_encoder.py,sha256=_-jzRTe0UqAKTn2E9qaU8SYIxHUoRA5ElWuVA0Y54Xw,338
 cloud_governance/common/utils/utils.py,sha256=ZUsi4ax2XhDIV-EQ5kJt5Ppd72kmm2psqcg1cNDZrvc,4349
 cloud_governance/main/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-cloud_governance/main/environment_variables.py,sha256=fxGtPqdoRyXk0T7Hp6oSoCoPrEc3d80551v6d_vdaKk,29448
+cloud_governance/main/environment_variables.py,sha256=8OdeTmZNnjCJtXVKjQnqVR4_fnVCRxxW4mZ4Oirq09M,29564
 cloud_governance/main/environment_variables_exceptions.py,sha256=UR0Ith0P0oshsDZdJRlRq8ZUTt0h8jFvUtrnP4m4AIY,437
 cloud_governance/main/es_uploader.py,sha256=6Ify5CS2NtUF1xXZ-rMwpYxVzDKfEZhv2vogWFltt98,10656
 cloud_governance/main/main.py,sha256=4TBiCBO_1z8KpGXb8brPKBmv3jHBl8fl_-Sb80ctYno,18880
@@ -166,7 +166,7 @@ cloud_governance/policy/aws/optimize_resources_report.py,sha256=zG7w8KHF7Z25jxYG
 cloud_governance/policy/aws/s3_inactive.py,sha256=NXUUGtJhpqohaWYczSebw-q0Q7RKg3XMMj_h7xfGhQ0,2839
 cloud_governance/policy/aws/skipped_resources.py,sha256=D0kbt9dg6Bkl5PgGaqimWvLct6D-JOnerzJ0FkWzGFc,5679
 cloud_governance/policy/aws/spot_savings_analysis.py,sha256=lGG5qtz8pr7xjLo5BrtVSHGTz928MLwYPbSCaDfpTes,5513
-cloud_governance/policy/aws/unused_access_key.py,sha256=62_JaQMZLgnmYck0Brp8CTS1CvyRhwcNTXYmFjgWMoY,3542
+cloud_governance/policy/aws/unused_access_key.py,sha256=T4XwZT9b4IjTuV9JgCGvBPgMHbyu9tr-W9XI7d-emSE,3381
 cloud_governance/policy/aws/zombie_cluster_resource.py,sha256=Qkd5_Sh74cixaL7yiQgU1OvoEIfGmeKSECb5tNAnQ7I,59675
 cloud_governance/policy/aws/zombie_snapshots.py,sha256=V48cq4GCG2z-MRwUSE4b5wQcGeI_T1Ah99SiHlTwkvY,3834
 cloud_governance/policy/aws/cleanup/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -264,8 +264,8 @@ cloud_governance/policy/policy_runners/elasticsearch/__init__.py,sha256=47DEQpj8
 cloud_governance/policy/policy_runners/elasticsearch/upload_elastic_search.py,sha256=pOwUJWXjJbyTy8iv3Ap8xJGnqQe-5lZgoR8-vGfAVos,1881
 cloud_governance/policy/policy_runners/ibm/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 cloud_governance/policy/policy_runners/ibm/policy_runner.py,sha256=V0E_f7F3hXit0aSq4BlfX1Jd4vjR2NEvOWsJ5upvZ4o,1302
-cloud_governance-1.1.380.dist-info/licenses/LICENSE,sha256=xx0jnfkXJvxRnG63LTGOxlggYnIysveWIZ6H3PNdCrQ,11357
-cloud_governance-1.1.380.dist-info/METADATA,sha256=9nkOcj-OPneyM7zXBMTxPJzlPMXrd0yCIUTHRpu3phs,11384
-cloud_governance-1.1.380.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
-cloud_governance-1.1.380.dist-info/top_level.txt,sha256=jfB1fgj7jvx3YZkZA4G6hFeS1RHO7J7XtnbjuMNMRww,17
-cloud_governance-1.1.380.dist-info/RECORD,,
+cloud_governance-1.1.381.dist-info/licenses/LICENSE,sha256=xx0jnfkXJvxRnG63LTGOxlggYnIysveWIZ6H3PNdCrQ,11357
+cloud_governance-1.1.381.dist-info/METADATA,sha256=OXwXhY7LJ5wTFMQi5HwapZIK1FHkuaP9T1w1NuDKPi0,11384
+cloud_governance-1.1.381.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
+cloud_governance-1.1.381.dist-info/top_level.txt,sha256=jfB1fgj7jvx3YZkZA4G6hFeS1RHO7J7XtnbjuMNMRww,17
+cloud_governance-1.1.381.dist-info/RECORD,,