claude-mpm 5.5.0__py3-none-any.whl → 5.6.2__py3-none-any.whl

claude_mpm/commander/workflow/notifier.py

@@ -0,0 +1,146 @@
+"""Basic notification delivery for events.
+
+This module provides Notifier which sends notifications for events.
+Currently supports logging, with extensibility for future channels
+(Slack, email, webhooks).
+"""
+
+import logging
+from dataclasses import dataclass
+
+from ..models.events import Event
+
+logger = logging.getLogger(__name__)
+
+
+@dataclass
+class NotifierConfig:
+    """Configuration for notifier.
+
+    Attributes:
+        log_level: Logging level for notifications (default: INFO)
+
+    Future attributes:
+        slack_webhook: URL for Slack webhook notifications
+        email_config: SMTP configuration for email notifications
+        webhook_urls: List of webhook URLs for custom integrations
+    """
+
+    log_level: str = "INFO"
+    # Future: slack_webhook, email_config, webhook_urls
+
+
+class Notifier:
+    """Sends notifications for events.
+
+    Currently implements logging-based notifications with configurable
+    log levels. Designed for extensibility to support future notification
+    channels like Slack, email, and webhooks.
+
+    Attributes:
+        config: Notifier configuration
+
+    Example:
+        >>> config = NotifierConfig(log_level="INFO")
+        >>> notifier = Notifier(config)
+        >>> await notifier.notify(event)
+        >>> await notifier.notify_resolution(event, "User responded")
+    """
+
+    def __init__(self, config: NotifierConfig | None = None) -> None:
+        """Initialize notifier.
+
+        Args:
+            config: Optional NotifierConfig (uses defaults if not provided)
+        """
+        self.config = config or NotifierConfig()
+
+        # Map log level string to logging level
+        level_map = {
+            "DEBUG": logging.DEBUG,
+            "INFO": logging.INFO,
+            "WARNING": logging.WARNING,
+            "ERROR": logging.ERROR,
+            "CRITICAL": logging.CRITICAL,
+        }
+        self._log_level = level_map.get(self.config.log_level.upper(), logging.INFO)
+
+        logger.debug("Notifier initialized with log level: %s", self.config.log_level)
+
+    async def notify(self, event: Event) -> None:
+        """Send notification for an event.
+
+        Currently logs the event at the configured log level. Future versions
+        will support additional notification channels.
+
+        Args:
+            event: Event to notify about
+
+        Example:
+            >>> await notifier.notify(event)
+            # Logs: [HIGH] Event evt_123: Choose deployment target
+        """
+        # Format notification message
+        message = self._format_event(event)
+
+        # Log notification
+        logger.log(
+            self._log_level,
+            "Event notification: %s",
+            message,
+        )
+
+        # Future: Send to Slack, email, webhooks
+        # if self.config.slack_webhook:
+        #     await self._send_slack(event)
+        # if self.config.email_config:
+        #     await self._send_email(event)
+
+    async def notify_resolution(self, event: Event, response: str) -> None:
+        """Notify that an event was resolved.
+
+        Logs the resolution with the user's response. Future versions will
+        send resolution notifications to configured channels.
+
+        Args:
+            event: Event that was resolved
+            response: User's response to the event
+
+        Example:
+            >>> await notifier.notify_resolution(event, "Deploy to staging")
+            # Logs: Event evt_123 resolved: Deploy to staging
+        """
+        message = f"Event {event.id} resolved: {response[:100]}"
+
+        logger.log(
+            self._log_level,
+            "Event resolution: %s",
+            message,
+        )
+
+        # Future: Send resolution notifications to channels
+
+    def _format_event(self, event: Event) -> str:
+        """Format event for notification display.
+
+        Args:
+            event: Event to format
+
+        Returns:
+            Formatted notification string
+
+        Example:
+            >>> msg = notifier._format_event(event)
+            '[HIGH] evt_123 (proj_456): Choose deployment target'
+        """
+        parts = [
+            f"[{event.priority.value.upper()}]",
+            f"{event.id}",
+            f"({event.project_id})",
+            f"{event.title}",
+        ]
+
+        if event.options:
+            parts.append(f"Options: {', '.join(event.options)}")
+
+        return " ".join(parts)

claude_mpm/config/agent_presets.py

@@ -25,13 +25,14 @@ from typing import Any, Callable, Dict, List, Union
 PresetResolver = Union[List[str], Callable[[], List[str]]]
 
 # Core agents included in ALL presets (MIN and MAX)
-# Standard 6 core agents for essential PM workflow functionality
+# Standard 9 core agents for essential PM workflow functionality
 CORE_AGENTS = [
     "claude-mpm/mpm-agent-manager",  # Agent lifecycle management
     "claude-mpm/mpm-skills-manager",  # Skills management
     "engineer/core/engineer",  # General-purpose implementation
     "universal/research",  # Codebase exploration and analysis
     "qa/qa",  # Testing and quality assurance
+    "qa/web-qa",  # Browser-based testing specialist
     "documentation/documentation",  # Documentation generation
     "ops/core/ops",  # Basic deployment operations
     "documentation/ticketing",  # Ticket tracking (essential for PM workflow)

claude_mpm/core/logger.py

@@ -229,7 +229,7 @@ def setup_logging(
             console_handler = logging.StreamHandler(sys.stderr)
             console_handler.setFormatter(formatter if json_format else simple_formatter)
 
-        console_handler.setLevel(logging.INFO)
+        console_handler.setLevel(log_level)  # Respect the requested log level
         logger.addHandler(console_handler)
 
     # File handler

claude_mpm/core/logging_utils.py

@@ -103,23 +103,45 @@ class LoggerFactory:
 
         # Set up root logger
         root_logger = logging.getLogger()
-        root_logger.setLevel(LoggingConfig.LEVELS.get(cls._log_level, logging.INFO))
+
+        # CRITICAL FIX: Respect existing root logger suppression
+        # If root logger is already set to CRITICAL+1 (suppressed by startup.py),
+        # don't override it. This prevents logging from appearing during startup
+        # before the CLI's setup_logging() runs.
+        current_level = root_logger.level
+        desired_level = LoggingConfig.LEVELS.get(cls._log_level, logging.INFO)
+
+        # Only set level if current is unset (0) or lower than desired
+        # CRITICAL+1 is 51, so this check preserves suppression
+        should_configure_logging = current_level == 0 or (
+            current_level < desired_level and current_level <= logging.CRITICAL
+        )
+
+        if should_configure_logging:
+            root_logger.setLevel(desired_level)
+        # else: root logger is suppressed (CRITICAL+1), keep it suppressed
 
         # Remove existing handlers
         root_logger.handlers = []
 
-        # Console handler - MUST use stderr to avoid corrupting hook JSON output
-        # WHY stderr: Hook handlers output JSON to stdout. Logging to stdout
-        # corrupts this JSON and causes "hook error" messages from Claude Code.
-        console_handler = logging.StreamHandler(sys.stderr)
-        console_handler.setLevel(LoggingConfig.LEVELS.get(cls._log_level, logging.INFO))
-        console_formatter = logging.Formatter(
-            log_format or LoggingConfig.DEFAULT_FORMAT,
-            date_format or LoggingConfig.DATE_FORMAT,
-        )
-        console_handler.setFormatter(console_formatter)
-        root_logger.addHandler(console_handler)
-        cls._handlers["console"] = console_handler
+        # CRITICAL FIX: Don't add handlers if logging is suppressed
+        # If root logger is at CRITICAL+1 (startup suppression), don't add any handlers
+        # This prevents early imports from logging before CLI setup_logging() runs
+        if should_configure_logging:
+            # Console handler - MUST use stderr to avoid corrupting hook JSON output
+            # WHY stderr: Hook handlers output JSON to stdout. Logging to stdout
+            # corrupts this JSON and causes "hook error" messages from Claude Code.
+            console_handler = logging.StreamHandler(sys.stderr)
+            console_handler.setLevel(
+                LoggingConfig.LEVELS.get(cls._log_level, logging.INFO)
+            )
+            console_formatter = logging.Formatter(
+                log_format or LoggingConfig.DEFAULT_FORMAT,
+                date_format or LoggingConfig.DATE_FORMAT,
+            )
+            console_handler.setFormatter(console_formatter)
+            root_logger.addHandler(console_handler)
+            cls._handlers["console"] = console_handler
 
         # File handler (optional)
         if log_to_file and cls._log_dir:

claude_mpm/core/unified_config.py

@@ -73,18 +73,19 @@ class AgentConfig(BaseModel):
     )
 
     # Required agents that are always deployed
-    # Standard 6 core agents for essential PM workflow functionality
+    # Standard 7 core agents for essential PM workflow functionality
     # These are auto-deployed when no agents are specified in configuration
     required: List[str] = Field(
         default_factory=lambda: [
             "engineer",  # General-purpose implementation
             "research",  # Codebase exploration and analysis
             "qa",  # Testing and quality assurance
+            "web-qa",  # Browser-based testing specialist
             "documentation",  # Documentation generation
             "ops",  # Basic deployment operations
             "ticketing",  # Ticket tracking (essential for PM workflow)
         ],
-        description="Agents that are always deployed (standard 6 core agents)",
+        description="Agents that are always deployed (standard 7 core agents)",
     )
 
     include_universal: bool = Field(

claude_mpm/core/unified_paths.py

@@ -76,6 +76,7 @@ class DeploymentContext(Enum):
     EDITABLE_INSTALL = "editable_install"
     PIP_INSTALL = "pip_install"
     PIPX_INSTALL = "pipx_install"
+    UV_TOOLS = "uv_tools"
     SYSTEM_PACKAGE = "system_package"
 
 
@@ -190,113 +191,100 @@ class PathContext:
 
         Priority order:
         1. Environment variable override (CLAUDE_MPM_DEV_MODE)
-        2. Current working directory is a claude-mpm development project
-        3. Editable installation detection
-        4. Path-based detection (development, pipx, system, pip)
+        2. Package installation path (uv tools, pipx, site-packages, editable)
+        3. Current working directory (opt-in with CLAUDE_MPM_PREFER_LOCAL_SOURCE)
+
+        This ensures installed packages use their installation paths rather than
+        accidentally picking up development paths from CWD.
         """
-        # Check for environment variable override
+        # 1. Explicit environment variable override
         if os.environ.get("CLAUDE_MPM_DEV_MODE", "").lower() in ("1", "true", "yes"):
             logger.debug(
                 "Development mode forced via CLAUDE_MPM_DEV_MODE environment variable"
             )
             return DeploymentContext.DEVELOPMENT
 
-        # Check if current working directory is a claude-mpm development project
-        # This handles the case where pipx claude-mpm is run from within the dev directory
-        cwd = _safe_cwd()
-        current = cwd
-        for _ in range(5):  # Check up to 5 levels up from current directory
-            if (current / "pyproject.toml").exists() and (
-                current / "src" / "claude_mpm"
-            ).exists():
-                # Check if this is the claude-mpm project
-                try:
-                    pyproject_content = (current / "pyproject.toml").read_text()
-                    if (
-                        'name = "claude-mpm"' in pyproject_content
-                        or '"claude-mpm"' in pyproject_content
-                    ):
-                        logger.debug(
-                            f"Detected claude-mpm development directory at {current}"
-                        )
-                        logger.debug(
-                            "Using development mode for local source preference"
-                        )
-                        return DeploymentContext.DEVELOPMENT
-                except Exception:  # nosec B110
-                    pass
-            if current == current.parent:
-                break
-            current = current.parent
-
+        # 2. Check where the actual package is installed
         try:
             import claude_mpm
 
             module_path = Path(claude_mpm.__file__).parent
+            package_str = str(module_path)
 
-            # First check if this is an editable install, regardless of path
-            # This is important for cases where pipx points to a development installation
-            if PathContext._is_editable_install():
-                logger.debug("Detected editable/development installation")
-                # Check if we should use development paths
-                # This could be because we're in a src/ directory or running from dev directory
-                if module_path.parent.name == "src":
-                    return DeploymentContext.DEVELOPMENT
-                if "pipx" in str(module_path):
-                    # Running via pipx but from within a development directory
-                    # Use development mode to prefer local source over pipx installation
-                    cwd = _safe_cwd()
-                    current = cwd
-                    for _ in range(5):
-                        if (current / "src" / "claude_mpm").exists() and (
-                            current / "pyproject.toml"
-                        ).exists():
-                            logger.debug(
-                                "Running pipx from development directory, using development mode"
-                            )
-                            return DeploymentContext.DEVELOPMENT
-                        if current == current.parent:
-                            break
-                        current = current.parent
-                    return DeploymentContext.EDITABLE_INSTALL
-                return DeploymentContext.EDITABLE_INSTALL
+            # UV tools installation (~/.local/share/uv/tools/)
+            if "/.local/share/uv/tools/" in package_str:
+                logger.debug(f"Detected uv tools installation at {module_path}")
+                return DeploymentContext.UV_TOOLS
 
-            # Check for development mode based on directory structure
-            # module_path is typically /path/to/project/src/claude_mpm
-            if (
-                module_path.parent.name == "src"
-                and (module_path.parent.parent / "src" / "claude_mpm").exists()
-            ):
+            # pipx installation (~/.local/pipx/venvs/)
+            if "/.local/pipx/venvs/" in package_str or "/pipx/" in package_str:
+                logger.debug(f"Detected pipx installation at {module_path}")
+                return DeploymentContext.PIPX_INSTALL
+
+            # site-packages (pip install) - but not editable
+            if "/site-packages/" in package_str and "/src/" not in package_str:
+                logger.debug(f"Detected pip installation at {module_path}")
+                return DeploymentContext.PIP_INSTALL
+
+            # Editable install (pip install -e) - module in src/
+            if module_path.parent.name == "src":
+                # Check if this is truly an editable install
+                if PathContext._is_editable_install():
+                    logger.debug(f"Detected editable installation at {module_path}")
+                    return DeploymentContext.EDITABLE_INSTALL
+                # Module in src/ but not editable - development mode
                 logger.debug(
                     f"Detected development mode via directory structure at {module_path}"
                 )
                 return DeploymentContext.DEVELOPMENT
 
-            # Check for pipx install
-            if "pipx" in str(module_path):
-                logger.debug(f"Detected pipx installation at {module_path}")
-                return DeploymentContext.PIPX_INSTALL
-
-            # Check for system package
-            if "dist-packages" in str(module_path):
+            # dist-packages (system package manager)
+            if "dist-packages" in package_str:
                 logger.debug(f"Detected system package installation at {module_path}")
                 return DeploymentContext.SYSTEM_PACKAGE
 
-            # Check for site-packages (could be pip or editable)
-            if "site-packages" in str(module_path):
-                # Already checked for editable above, so this is a regular pip install
-                logger.debug(f"Detected pip installation at {module_path}")
-                return DeploymentContext.PIP_INSTALL
-
-            # Default to pip install
+            # Default to pip install for any other installation
             logger.debug(f"Defaulting to pip installation for {module_path}")
             return DeploymentContext.PIP_INSTALL
 
         except ImportError:
             logger.debug(
-                "ImportError during context detection, defaulting to development"
+                "ImportError during module path detection, checking CWD as fallback"
             )
-            return DeploymentContext.DEVELOPMENT
+
+        # 3. CWD-based detection (OPT-IN ONLY for explicit development work)
+        # Only use CWD if explicitly requested or no package installation found
+        if os.environ.get("CLAUDE_MPM_PREFER_LOCAL_SOURCE", "").lower() in (
+            "1",
+            "true",
+            "yes",
+        ):
+            cwd = _safe_cwd()
+            current = cwd
+            for _ in range(5):  # Check up to 5 levels up from current directory
+                if (current / "pyproject.toml").exists() and (
+                    current / "src" / "claude_mpm"
+                ).exists():
+                    # Check if this is the claude-mpm project
+                    try:
+                        pyproject_content = (current / "pyproject.toml").read_text()
+                        if (
+                            'name = "claude-mpm"' in pyproject_content
+                            or '"claude-mpm"' in pyproject_content
+                        ):
+                            logger.debug(
+                                f"CLAUDE_MPM_PREFER_LOCAL_SOURCE: Using development directory at {current}"
+                            )
+                            return DeploymentContext.DEVELOPMENT
+                    except Exception:  # nosec B110
+                        pass
+                if current == current.parent:
+                    break
+                current = current.parent
+
+        # Final fallback: assume development mode
+        logger.debug("No installation detected, defaulting to development mode")
+        return DeploymentContext.DEVELOPMENT
 
 
 class UnifiedPathManager: