claude-mpm 4.16.0__py3-none-any.whl → 4.20.3__py3-none-any.whl

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (131) hide show
  1. claude_mpm/VERSION +1 -1
  2. claude_mpm/agents/BASE_ENGINEER.md +286 -0
  3. claude_mpm/agents/BASE_PM.md +255 -23
  4. claude_mpm/agents/PM_INSTRUCTIONS.md +40 -0
  5. claude_mpm/agents/agent_loader.py +4 -4
  6. claude_mpm/agents/templates/engineer.json +5 -1
  7. claude_mpm/agents/templates/python_engineer.json +8 -3
  8. claude_mpm/agents/templates/rust_engineer.json +12 -7
  9. claude_mpm/agents/templates/svelte-engineer.json +225 -0
  10. claude_mpm/cli/commands/__init__.py +2 -0
  11. claude_mpm/cli/commands/mpm_init.py +109 -24
  12. claude_mpm/cli/commands/skills.py +434 -0
  13. claude_mpm/cli/executor.py +2 -0
  14. claude_mpm/cli/parsers/base_parser.py +7 -0
  15. claude_mpm/cli/parsers/skills_parser.py +137 -0
  16. claude_mpm/cli/startup.py +57 -0
  17. claude_mpm/commands/mpm-auto-configure.md +52 -0
  18. claude_mpm/commands/mpm-help.md +3 -0
  19. claude_mpm/commands/mpm-init.md +112 -6
  20. claude_mpm/commands/mpm-version.md +113 -0
  21. claude_mpm/commands/mpm.md +1 -0
  22. claude_mpm/config/agent_config.py +2 -2
  23. claude_mpm/constants.py +12 -0
  24. claude_mpm/core/config.py +42 -0
  25. claude_mpm/core/factories.py +1 -1
  26. claude_mpm/core/optimized_agent_loader.py +3 -3
  27. claude_mpm/hooks/__init__.py +8 -0
  28. claude_mpm/hooks/claude_hooks/response_tracking.py +35 -1
  29. claude_mpm/hooks/session_resume_hook.py +121 -0
  30. claude_mpm/models/resume_log.py +340 -0
  31. claude_mpm/services/agents/auto_config_manager.py +1 -1
  32. claude_mpm/services/agents/deployment/agent_configuration_manager.py +1 -1
  33. claude_mpm/services/agents/deployment/agent_record_service.py +1 -1
  34. claude_mpm/services/agents/deployment/agent_validator.py +17 -1
  35. claude_mpm/services/agents/deployment/async_agent_deployment.py +1 -1
  36. claude_mpm/services/agents/deployment/local_template_deployment.py +1 -1
  37. claude_mpm/services/agents/local_template_manager.py +1 -1
  38. claude_mpm/services/agents/recommender.py +47 -0
  39. claude_mpm/services/cli/resume_service.py +617 -0
  40. claude_mpm/services/cli/session_manager.py +87 -0
  41. claude_mpm/services/cli/session_resume_helper.py +352 -0
  42. claude_mpm/services/core/path_resolver.py +1 -1
  43. claude_mpm/services/infrastructure/resume_log_generator.py +439 -0
  44. claude_mpm/services/mcp_config_manager.py +7 -131
  45. claude_mpm/services/session_manager.py +205 -1
  46. claude_mpm/services/unified/deployment_strategies/local.py +1 -1
  47. claude_mpm/services/version_service.py +104 -1
  48. claude_mpm/skills/__init__.py +21 -0
  49. claude_mpm/skills/agent_skills_injector.py +331 -0
  50. claude_mpm/skills/bundled/LICENSE_ATTRIBUTIONS.md +79 -0
  51. claude_mpm/skills/bundled/api-documentation.md +393 -0
  52. claude_mpm/skills/bundled/async-testing.md +571 -0
  53. claude_mpm/skills/bundled/code-review.md +143 -0
  54. claude_mpm/skills/bundled/collaboration/brainstorming/SKILL.md +75 -0
  55. claude_mpm/skills/bundled/collaboration/dispatching-parallel-agents/SKILL.md +184 -0
  56. claude_mpm/skills/bundled/collaboration/requesting-code-review/SKILL.md +107 -0
  57. claude_mpm/skills/bundled/collaboration/requesting-code-review/code-reviewer.md +146 -0
  58. claude_mpm/skills/bundled/collaboration/writing-plans/SKILL.md +118 -0
  59. claude_mpm/skills/bundled/database-migration.md +199 -0
  60. claude_mpm/skills/bundled/debugging/root-cause-tracing/SKILL.md +177 -0
  61. claude_mpm/skills/bundled/debugging/systematic-debugging/CREATION-LOG.md +119 -0
  62. claude_mpm/skills/bundled/debugging/systematic-debugging/SKILL.md +148 -0
  63. claude_mpm/skills/bundled/debugging/systematic-debugging/references/anti-patterns.md +483 -0
  64. claude_mpm/skills/bundled/debugging/systematic-debugging/references/examples.md +452 -0
  65. claude_mpm/skills/bundled/debugging/systematic-debugging/references/troubleshooting.md +449 -0
  66. claude_mpm/skills/bundled/debugging/systematic-debugging/references/workflow.md +411 -0
  67. claude_mpm/skills/bundled/debugging/systematic-debugging/test-academic.md +14 -0
  68. claude_mpm/skills/bundled/debugging/systematic-debugging/test-pressure-1.md +58 -0
  69. claude_mpm/skills/bundled/debugging/systematic-debugging/test-pressure-2.md +68 -0
  70. claude_mpm/skills/bundled/debugging/systematic-debugging/test-pressure-3.md +69 -0
  71. claude_mpm/skills/bundled/debugging/verification-before-completion/SKILL.md +175 -0
  72. claude_mpm/skills/bundled/debugging/verification-before-completion/references/common-failures.md +213 -0
  73. claude_mpm/skills/bundled/debugging/verification-before-completion/references/gate-function.md +314 -0
  74. claude_mpm/skills/bundled/debugging/verification-before-completion/references/verification-patterns.md +227 -0
  75. claude_mpm/skills/bundled/docker-containerization.md +194 -0
  76. claude_mpm/skills/bundled/express-local-dev.md +1429 -0
  77. claude_mpm/skills/bundled/fastapi-local-dev.md +1199 -0
  78. claude_mpm/skills/bundled/git-workflow.md +414 -0
  79. claude_mpm/skills/bundled/imagemagick.md +204 -0
  80. claude_mpm/skills/bundled/json-data-handling.md +223 -0
  81. claude_mpm/skills/bundled/main/artifacts-builder/SKILL.md +74 -0
  82. claude_mpm/skills/bundled/main/internal-comms/SKILL.md +32 -0
  83. claude_mpm/skills/bundled/main/internal-comms/examples/3p-updates.md +47 -0
  84. claude_mpm/skills/bundled/main/internal-comms/examples/company-newsletter.md +65 -0
  85. claude_mpm/skills/bundled/main/internal-comms/examples/faq-answers.md +30 -0
  86. claude_mpm/skills/bundled/main/internal-comms/examples/general-comms.md +16 -0
  87. claude_mpm/skills/bundled/main/mcp-builder/SKILL.md +328 -0
  88. claude_mpm/skills/bundled/main/mcp-builder/reference/evaluation.md +602 -0
  89. claude_mpm/skills/bundled/main/mcp-builder/reference/mcp_best_practices.md +915 -0
  90. claude_mpm/skills/bundled/main/mcp-builder/reference/node_mcp_server.md +916 -0
  91. claude_mpm/skills/bundled/main/mcp-builder/reference/python_mcp_server.md +752 -0
  92. claude_mpm/skills/bundled/main/mcp-builder/scripts/connections.py +150 -0
  93. claude_mpm/skills/bundled/main/mcp-builder/scripts/evaluation.py +372 -0
  94. claude_mpm/skills/bundled/main/skill-creator/SKILL.md +209 -0
  95. claude_mpm/skills/bundled/main/skill-creator/scripts/init_skill.py +302 -0
  96. claude_mpm/skills/bundled/main/skill-creator/scripts/package_skill.py +111 -0
  97. claude_mpm/skills/bundled/main/skill-creator/scripts/quick_validate.py +65 -0
  98. claude_mpm/skills/bundled/nextjs-local-dev.md +807 -0
  99. claude_mpm/skills/bundled/pdf.md +141 -0
  100. claude_mpm/skills/bundled/performance-profiling.md +567 -0
  101. claude_mpm/skills/bundled/refactoring-patterns.md +180 -0
  102. claude_mpm/skills/bundled/security-scanning.md +327 -0
  103. claude_mpm/skills/bundled/systematic-debugging.md +473 -0
  104. claude_mpm/skills/bundled/test-driven-development.md +378 -0
  105. claude_mpm/skills/bundled/testing/condition-based-waiting/SKILL.md +123 -0
  106. claude_mpm/skills/bundled/testing/test-driven-development/SKILL.md +145 -0
  107. claude_mpm/skills/bundled/testing/test-driven-development/references/anti-patterns.md +543 -0
  108. claude_mpm/skills/bundled/testing/test-driven-development/references/examples.md +741 -0
  109. claude_mpm/skills/bundled/testing/test-driven-development/references/integration.md +470 -0
  110. claude_mpm/skills/bundled/testing/test-driven-development/references/philosophy.md +458 -0
  111. claude_mpm/skills/bundled/testing/test-driven-development/references/workflow.md +639 -0
  112. claude_mpm/skills/bundled/testing/testing-anti-patterns/SKILL.md +304 -0
  113. claude_mpm/skills/bundled/testing/webapp-testing/SKILL.md +96 -0
  114. claude_mpm/skills/bundled/testing/webapp-testing/examples/console_logging.py +35 -0
  115. claude_mpm/skills/bundled/testing/webapp-testing/examples/element_discovery.py +40 -0
  116. claude_mpm/skills/bundled/testing/webapp-testing/examples/static_html_automation.py +34 -0
  117. claude_mpm/skills/bundled/testing/webapp-testing/scripts/with_server.py +107 -0
  118. claude_mpm/skills/bundled/vite-local-dev.md +1061 -0
  119. claude_mpm/skills/bundled/web-performance-optimization.md +2305 -0
  120. claude_mpm/skills/bundled/xlsx.md +157 -0
  121. claude_mpm/skills/registry.py +97 -9
  122. claude_mpm/skills/skills_registry.py +351 -0
  123. claude_mpm/skills/skills_service.py +730 -0
  124. claude_mpm/utils/agent_dependency_loader.py +2 -2
  125. {claude_mpm-4.16.0.dist-info → claude_mpm-4.20.3.dist-info}/METADATA +181 -32
  126. {claude_mpm-4.16.0.dist-info → claude_mpm-4.20.3.dist-info}/RECORD +130 -48
  127. claude_mpm/agents/INSTRUCTIONS_OLD_DEPRECATED.md +0 -602
  128. {claude_mpm-4.16.0.dist-info → claude_mpm-4.20.3.dist-info}/WHEEL +0 -0
  129. {claude_mpm-4.16.0.dist-info → claude_mpm-4.20.3.dist-info}/entry_points.txt +0 -0
  130. {claude_mpm-4.16.0.dist-info → claude_mpm-4.20.3.dist-info}/licenses/LICENSE +0 -0
  131. {claude_mpm-4.16.0.dist-info → claude_mpm-4.20.3.dist-info}/top_level.txt +0 -0
@@ -0,0 +1,75 @@
1
+ ---
2
+ name: Brainstorming Ideas Into Designs
3
+ description: Interactive idea refinement using Socratic method to develop fully-formed designs
4
+ when_to_use: when partner describes any feature or project idea, before writing code or implementation plans
5
+ version: 2.2.0
6
+ ---
7
+
8
+ # Brainstorming Ideas Into Designs
9
+
10
+ ## Overview
11
+
12
+ Transform rough ideas into fully-formed designs through structured questioning and alternative exploration.
13
+
14
+ **Core principle:** Ask questions to understand, explore alternatives, present design incrementally for validation.
15
+
16
+ **Announce at start:** "I'm using the Brainstorming skill to refine your idea into a design."
17
+
18
+ ## The Process
19
+
20
+ ### Phase 1: Understanding
21
+ - Check current project state in working directory
22
+ - Ask ONE question at a time to refine the idea
23
+ - Prefer multiple choice when possible
24
+ - Gather: Purpose, constraints, success criteria
25
+
26
+ ### Phase 2: Exploration
27
+ - Propose 2-3 different approaches
28
+ - For each: Core architecture, trade-offs, complexity assessment
29
+ - Ask your human partner which approach resonates
30
+
31
+ ### Phase 3: Design Presentation
32
+ - Present in 200-300 word sections
33
+ - Cover: Architecture, components, data flow, error handling, testing
34
+ - Ask after each section: "Does this look right so far?"
35
+
36
+ ### Phase 4: Worktree Setup (for implementation)
37
+ When design is approved and implementation will follow:
38
+ - Announce: "I'm using the Using Git Worktrees skill to set up an isolated workspace."
39
+ - Switch to skills/collaboration/using-git-worktrees
40
+ - Follow that skill's process for directory selection, safety verification, and setup
41
+ - Return here when worktree ready
42
+
43
+ ### Phase 5: Planning Handoff
44
+ Ask: "Ready to create the implementation plan?"
45
+
46
+ When your human partner confirms (any affirmative response):
47
+ - Announce: "I'm using the Writing Plans skill to create the implementation plan."
48
+ - Switch to skills/collaboration/writing-plans skill
49
+ - Create detailed plan in the worktree
50
+
51
+ ## When to Revisit Earlier Phases
52
+
53
+ **You can and should go backward when:**
54
+ - Partner reveals new constraint during Phase 2 or 3 → Return to Phase 1 to understand it
55
+ - Validation shows fundamental gap in requirements → Return to Phase 1
56
+ - Partner questions approach during Phase 3 → Return to Phase 2 to explore alternatives
57
+ - Something doesn't make sense → Go back and clarify
58
+
59
+ **Don't force forward linearly** when going backward would give better results.
60
+
61
+ ## Related Skills
62
+
63
+ **During exploration:**
64
+ - When approaches have genuine trade-offs: skills/architecture/preserving-productive-tensions
65
+
66
+ **Before proposing changes to existing code:**
67
+ - Understand why it exists: skills/research/tracing-knowledge-lineages
68
+
69
+ ## Remember
70
+ - One question per message during Phase 1
71
+ - Apply YAGNI ruthlessly
72
+ - Explore 2-3 alternatives before settling
73
+ - Present incrementally, validate as you go
74
+ - Go backward when needed - flexibility > rigid progression
75
+ - Announce skill usage at start
@@ -0,0 +1,184 @@
1
+ ---
2
+ name: Dispatching Parallel Agents
3
+ description: Use multiple Claude agents to investigate and fix independent problems concurrently
4
+ when_to_use: when facing 3+ independent failures that can be investigated without shared state or dependencies
5
+ version: 1.1.0
6
+ languages: all
7
+ context: AI-assisted development (Claude Code or similar)
8
+ ---
9
+
10
+ # Dispatching Parallel Agents
11
+
12
+ ## Overview
13
+
14
+ When you have multiple unrelated failures (different test files, different subsystems, different bugs), investigating them sequentially wastes time. Each investigation is independent and can happen in parallel.
15
+
16
+ **Core principle:** Dispatch one agent per independent problem domain. Let them work concurrently.
17
+
18
+ ## When to Use
19
+
20
+ ```dot
21
+ digraph when_to_use {
22
+ "Multiple failures?" [shape=diamond];
23
+ "Are they independent?" [shape=diamond];
24
+ "Single agent investigates all" [shape=box];
25
+ "One agent per problem domain" [shape=box];
26
+ "Can they work in parallel?" [shape=diamond];
27
+ "Sequential agents" [shape=box];
28
+ "Parallel dispatch" [shape=box];
29
+
30
+ "Multiple failures?" -> "Are they independent?" [label="yes"];
31
+ "Are they independent?" -> "Single agent investigates all" [label="no - related"];
32
+ "Are they independent?" -> "Can they work in parallel?" [label="yes"];
33
+ "Can they work in parallel?" -> "Parallel dispatch" [label="yes"];
34
+ "Can they work in parallel?" -> "Sequential agents" [label="no - shared state"];
35
+ }
36
+ ```
37
+
38
+ **Use when:**
39
+ - 3+ test files failing with different root causes
40
+ - Multiple subsystems broken independently
41
+ - Each problem can be understood without context from others
42
+ - No shared state between investigations
43
+
44
+ **Don't use when:**
45
+ - Failures are related (fix one might fix others)
46
+ - Need to understand full system state
47
+ - Agents would interfere with each other
48
+
49
+ ## The Pattern
50
+
51
+ ### 1. Identify Independent Domains
52
+
53
+ Group failures by what's broken:
54
+ - File A tests: Tool approval flow
55
+ - File B tests: Batch completion behavior
56
+ - File C tests: Abort functionality
57
+
58
+ Each domain is independent - fixing tool approval doesn't affect abort tests.
59
+
60
+ ### 2. Create Focused Agent Tasks
61
+
62
+ Each agent gets:
63
+ - **Specific scope:** One test file or subsystem
64
+ - **Clear goal:** Make these tests pass
65
+ - **Constraints:** Don't change other code
66
+ - **Expected output:** Summary of what you found and fixed
67
+
68
+ ### 3. Dispatch in Parallel
69
+
70
+ ```typescript
71
+ // In Claude Code / AI environment
72
+ Task("Fix agent-tool-abort.test.ts failures")
73
+ Task("Fix batch-completion-behavior.test.ts failures")
74
+ Task("Fix tool-approval-race-conditions.test.ts failures")
75
+ // All three run concurrently
76
+ ```
77
+
78
+ ### 4. Review and Integrate
79
+
80
+ When agents return:
81
+ - Read each summary
82
+ - Verify fixes don't conflict
83
+ - Run full test suite
84
+ - Integrate all changes
85
+
86
+ ## Agent Prompt Structure
87
+
88
+ Good agent prompts are:
89
+ 1. **Focused** - One clear problem domain
90
+ 2. **Self-contained** - All context needed to understand the problem
91
+ 3. **Specific about output** - What should the agent return?
92
+
93
+ ```markdown
94
+ Fix the 3 failing tests in src/agents/agent-tool-abort.test.ts:
95
+
96
+ 1. "should abort tool with partial output capture" - expects 'interrupted at' in message
97
+ 2. "should handle mixed completed and aborted tools" - fast tool aborted instead of completed
98
+ 3. "should properly track pendingToolCount" - expects 3 results but gets 0
99
+
100
+ These are timing/race condition issues. Your task:
101
+
102
+ 1. Read the test file and understand what each test verifies
103
+ 2. Identify root cause - timing issues or actual bugs?
104
+ 3. Fix by:
105
+ - Replacing arbitrary timeouts with event-based waiting
106
+ - Fixing bugs in abort implementation if found
107
+ - Adjusting test expectations if testing changed behavior
108
+
109
+ Do NOT just increase timeouts - find the real issue.
110
+
111
+ Return: Summary of what you found and what you fixed.
112
+ ```
113
+
114
+ ## Common Mistakes
115
+
116
+ **❌ Too broad:** "Fix all the tests" - agent gets lost
117
+ **✅ Specific:** "Fix agent-tool-abort.test.ts" - focused scope
118
+
119
+ **❌ No context:** "Fix the race condition" - agent doesn't know where
120
+ **✅ Context:** Paste the error messages and test names
121
+
122
+ **❌ No constraints:** Agent might refactor everything
123
+ **✅ Constraints:** "Do NOT change production code" or "Fix tests only"
124
+
125
+ **❌ Vague output:** "Fix it" - you don't know what changed
126
+ **✅ Specific:** "Return summary of root cause and changes"
127
+
128
+ ## When NOT to Use
129
+
130
+ **Related failures:** Fixing one might fix others - investigate together first
131
+ **Need full context:** Understanding requires seeing entire system
132
+ **Exploratory debugging:** You don't know what's broken yet
133
+ **Shared state:** Agents would interfere (editing same files, using same resources)
134
+
135
+ ## Real Example from Session
136
+
137
+ **Scenario:** 6 test failures across 3 files after major refactoring
138
+
139
+ **Failures:**
140
+ - agent-tool-abort.test.ts: 3 failures (timing issues)
141
+ - batch-completion-behavior.test.ts: 2 failures (tools not executing)
142
+ - tool-approval-race-conditions.test.ts: 1 failure (execution count = 0)
143
+
144
+ **Decision:** Independent domains - abort logic separate from batch completion separate from race conditions
145
+
146
+ **Dispatch:**
147
+ ```
148
+ Agent 1 → Fix agent-tool-abort.test.ts
149
+ Agent 2 → Fix batch-completion-behavior.test.ts
150
+ Agent 3 → Fix tool-approval-race-conditions.test.ts
151
+ ```
152
+
153
+ **Results:**
154
+ - Agent 1: Replaced timeouts with event-based waiting
155
+ - Agent 2: Fixed event structure bug (threadId in wrong place)
156
+ - Agent 3: Added wait for async tool execution to complete
157
+
158
+ **Integration:** All fixes independent, no conflicts, full suite green
159
+
160
+ **Time saved:** 3 problems solved in parallel vs sequentially
161
+
162
+ ## Key Benefits
163
+
164
+ 1. **Parallelization** - Multiple investigations happen simultaneously
165
+ 2. **Focus** - Each agent has narrow scope, less context to track
166
+ 3. **Independence** - Agents don't interfere with each other
167
+ 4. **Speed** - 3 problems solved in time of 1
168
+
169
+ ## Verification
170
+
171
+ After agents return:
172
+ 1. **Review each summary** - Understand what changed
173
+ 2. **Check for conflicts** - Did agents edit same code?
174
+ 3. **Run full suite** - Verify all fixes work together
175
+ 4. **Spot check** - Agents can make systematic errors
176
+
177
+ ## Real-World Impact
178
+
179
+ From debugging session (2025-10-03):
180
+ - 6 failures across 3 files
181
+ - 3 agents dispatched in parallel
182
+ - All investigations completed concurrently
183
+ - All fixes integrated successfully
184
+ - Zero conflicts between agent changes
@@ -0,0 +1,107 @@
1
+ ---
2
+ name: Requesting Code Review
3
+ description: Dispatch code-reviewer subagent to review implementation against plan or requirements before proceeding
4
+ when_to_use: when completing tasks, implementing major features, or before merging, to verify work meets requirements
5
+ version: 1.1.0
6
+ ---
7
+
8
+ # Requesting Code Review
9
+
10
+ Dispatch code-reviewer subagent to catch issues before they cascade.
11
+
12
+ **Core principle:** Review early, review often.
13
+
14
+ ## When to Request Review
15
+
16
+ **Mandatory:**
17
+ - After each task in subagent-driven development
18
+ - After completing major feature
19
+ - Before merge to main
20
+
21
+ **Optional but valuable:**
22
+ - When stuck (fresh perspective)
23
+ - Before refactoring (baseline check)
24
+ - After fixing complex bug
25
+
26
+ ## How to Request
27
+
28
+ **1. Get git SHAs:**
29
+ ```bash
30
+ BASE_SHA=$(git rev-parse HEAD~1) # or origin/main
31
+ HEAD_SHA=$(git rev-parse HEAD)
32
+ ```
33
+
34
+ **2. Dispatch code-reviewer subagent:**
35
+
36
+ Use Task tool with code-reviewer type, fill template at `code-reviewer.md`
37
+
38
+ **Placeholders:**
39
+ - `{WHAT_WAS_IMPLEMENTED}` - What you just built
40
+ - `{PLAN_OR_REQUIREMENTS}` - What it should do
41
+ - `{BASE_SHA}` - Starting commit
42
+ - `{HEAD_SHA}` - Ending commit
43
+ - `{DESCRIPTION}` - Brief summary
44
+
45
+ **3. Act on feedback:**
46
+ - Fix Critical issues immediately
47
+ - Fix Important issues before proceeding
48
+ - Note Minor issues for later
49
+ - Push back if reviewer is wrong (with reasoning)
50
+
51
+ ## Example
52
+
53
+ ```
54
+ [Just completed Task 2: Add verification function]
55
+
56
+ You: Let me request code review before proceeding.
57
+
58
+ BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
59
+ HEAD_SHA=$(git rev-parse HEAD)
60
+
61
+ [Dispatch code-reviewer subagent]
62
+ WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
63
+ PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
64
+ BASE_SHA: a7981ec
65
+ HEAD_SHA: 3df7661
66
+ DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
67
+
68
+ [Subagent returns]:
69
+ Strengths: Clean architecture, real tests
70
+ Issues:
71
+ Important: Missing progress indicators
72
+ Minor: Magic number (100) for reporting interval
73
+ Assessment: Ready to proceed
74
+
75
+ You: [Fix progress indicators]
76
+ [Continue to Task 3]
77
+ ```
78
+
79
+ ## Integration with Workflows
80
+
81
+ **Subagent-Driven Development:**
82
+ - Review after EACH task
83
+ - Catch issues before they compound
84
+ - Fix before moving to next task
85
+
86
+ **Executing Plans:**
87
+ - Review after each batch (3 tasks)
88
+ - Get feedback, apply, continue
89
+
90
+ **Ad-Hoc Development:**
91
+ - Review before merge
92
+ - Review when stuck
93
+
94
+ ## Red Flags
95
+
96
+ **Never:**
97
+ - Skip review because "it's simple"
98
+ - Ignore Critical issues
99
+ - Proceed with unfixed Important issues
100
+ - Argue with valid technical feedback
101
+
102
+ **If reviewer wrong:**
103
+ - Push back with technical reasoning
104
+ - Show code/tests that prove it works
105
+ - Request clarification
106
+
107
+ See template at: skills/collaboration/requesting-code-review/code-reviewer.md
@@ -0,0 +1,146 @@
1
+ # Code Review Agent
2
+
3
+ You are reviewing code changes for production readiness.
4
+
5
+ **Your task:**
6
+ 1. Review {WHAT_WAS_IMPLEMENTED}
7
+ 2. Compare against {PLAN_OR_REQUIREMENTS}
8
+ 3. Check code quality, architecture, testing
9
+ 4. Categorize issues by severity
10
+ 5. Assess production readiness
11
+
12
+ ## What Was Implemented
13
+
14
+ {DESCRIPTION}
15
+
16
+ ## Requirements/Plan
17
+
18
+ {PLAN_REFERENCE}
19
+
20
+ ## Git Range to Review
21
+
22
+ **Base:** {BASE_SHA}
23
+ **Head:** {HEAD_SHA}
24
+
25
+ ```bash
26
+ git diff --stat {BASE_SHA}..{HEAD_SHA}
27
+ git diff {BASE_SHA}..{HEAD_SHA}
28
+ ```
29
+
30
+ ## Review Checklist
31
+
32
+ **Code Quality:**
33
+ - Clean separation of concerns?
34
+ - Proper error handling?
35
+ - Type safety (if applicable)?
36
+ - DRY principle followed?
37
+ - Edge cases handled?
38
+
39
+ **Architecture:**
40
+ - Sound design decisions?
41
+ - Scalability considerations?
42
+ - Performance implications?
43
+ - Security concerns?
44
+
45
+ **Testing:**
46
+ - Tests actually test logic (not mocks)?
47
+ - Edge cases covered?
48
+ - Integration tests where needed?
49
+ - All tests passing?
50
+
51
+ **Requirements:**
52
+ - All plan requirements met?
53
+ - Implementation matches spec?
54
+ - No scope creep?
55
+ - Breaking changes documented?
56
+
57
+ **Production Readiness:**
58
+ - Migration strategy (if schema changes)?
59
+ - Backward compatibility considered?
60
+ - Documentation complete?
61
+ - No obvious bugs?
62
+
63
+ ## Output Format
64
+
65
+ ### Strengths
66
+ [What's well done? Be specific.]
67
+
68
+ ### Issues
69
+
70
+ #### Critical (Must Fix)
71
+ [Bugs, security issues, data loss risks, broken functionality]
72
+
73
+ #### Important (Should Fix)
74
+ [Architecture problems, missing features, poor error handling, test gaps]
75
+
76
+ #### Minor (Nice to Have)
77
+ [Code style, optimization opportunities, documentation improvements]
78
+
79
+ **For each issue:**
80
+ - File:line reference
81
+ - What's wrong
82
+ - Why it matters
83
+ - How to fix (if not obvious)
84
+
85
+ ### Recommendations
86
+ [Improvements for code quality, architecture, or process]
87
+
88
+ ### Assessment
89
+
90
+ **Ready to merge?** [Yes/No/With fixes]
91
+
92
+ **Reasoning:** [Technical assessment in 1-2 sentences]
93
+
94
+ ## Critical Rules
95
+
96
+ **DO:**
97
+ - Categorize by actual severity (not everything is Critical)
98
+ - Be specific (file:line, not vague)
99
+ - Explain WHY issues matter
100
+ - Acknowledge strengths
101
+ - Give clear verdict
102
+
103
+ **DON'T:**
104
+ - Say "looks good" without checking
105
+ - Mark nitpicks as Critical
106
+ - Give feedback on code you didn't review
107
+ - Be vague ("improve error handling")
108
+ - Avoid giving a clear verdict
109
+
110
+ ## Example Output
111
+
112
+ ```
113
+ ### Strengths
114
+ - Clean database schema with proper migrations (db.ts:15-42)
115
+ - Comprehensive test coverage (18 tests, all edge cases)
116
+ - Good error handling with fallbacks (summarizer.ts:85-92)
117
+
118
+ ### Issues
119
+
120
+ #### Important
121
+ 1. **Missing help text in CLI wrapper**
122
+ - File: index-conversations:1-31
123
+ - Issue: No --help flag, users won't discover --concurrency
124
+ - Fix: Add --help case with usage examples
125
+
126
+ 2. **Date validation missing**
127
+ - File: search.ts:25-27
128
+ - Issue: Invalid dates silently return no results
129
+ - Fix: Validate ISO format, throw error with example
130
+
131
+ #### Minor
132
+ 1. **Progress indicators**
133
+ - File: indexer.ts:130
134
+ - Issue: No "X of Y" counter for long operations
135
+ - Impact: Users don't know how long to wait
136
+
137
+ ### Recommendations
138
+ - Add progress reporting for user experience
139
+ - Consider config file for excluded projects (portability)
140
+
141
+ ### Assessment
142
+
143
+ **Ready to merge: With fixes**
144
+
145
+ **Reasoning:** Core implementation is solid with good architecture and tests. Important issues (help text, date validation) are easily fixed and don't affect core functionality.
146
+ ```
@@ -0,0 +1,118 @@
1
+ ---
2
+ name: Writing Plans
3
+ description: Create detailed implementation plans with bite-sized tasks for engineers with zero codebase context
4
+ when_to_use: when design is complete and you need detailed implementation tasks for engineers with zero codebase context
5
+ version: 2.1.0
6
+ ---
7
+
8
+ # Writing Plans
9
+
10
+ ## Overview
11
+
12
+ Write comprehensive implementation plans assuming the engineer has zero context for our codebase and questionable taste. Document everything they need to know: which files to touch for each task, code, testing, docs they might need to check, how to test it. Give them the whole plan as bite-sized tasks. DRY. YAGNI. TDD. Frequent commits.
13
+
14
+ Assume they are a skilled developer, but know almost nothing about our toolset or problem domain. Assume they don't know good test design very well.
15
+
16
+ **Announce at start:** "I'm using the Writing Plans skill to create the implementation plan."
17
+
18
+ **Context:** This should be run in a dedicated worktree (created by brainstorming skill).
19
+
20
+ **Save plans to:** `docs/plans/YYYY-MM-DD-<feature-name>.md`
21
+
22
+ ## Bite-Sized Task Granularity
23
+
24
+ **Each step is one action (2-5 minutes):**
25
+ - "Write the failing test" - step
26
+ - "Run it to make sure it fails" - step
27
+ - "Implement the minimal code to make the test pass" - step
28
+ - "Run the tests and make sure they pass" - step
29
+ - "Commit" - step
30
+
31
+ ## Plan Document Header
32
+
33
+ **Every plan MUST start with this header:**
34
+
35
+ ```markdown
36
+ # [Feature Name] Implementation Plan
37
+
38
+ > **For Claude:** Use `${SUPERPOWERS_SKILLS_ROOT}/skills/collaboration/executing-plans/SKILL.md` to implement this plan task-by-task.
39
+
40
+ **Goal:** [One sentence describing what this builds]
41
+
42
+ **Architecture:** [2-3 sentences about approach]
43
+
44
+ **Tech Stack:** [Key technologies/libraries]
45
+
46
+ ---
47
+ ```
48
+
49
+ ## Task Structure
50
+
51
+ ```markdown
52
+ ### Task N: [Component Name]
53
+
54
+ **Files:**
55
+ - Create: `exact/path/to/file.py`
56
+ - Modify: `exact/path/to/existing.py:123-145`
57
+ - Test: `tests/exact/path/to/test.py`
58
+
59
+ **Step 1: Write the failing test**
60
+
61
+ ```python
62
+ def test_specific_behavior():
63
+ result = function(input)
64
+ assert result == expected
65
+ ```
66
+
67
+ **Step 2: Run test to verify it fails**
68
+
69
+ Run: `pytest tests/path/test.py::test_name -v`
70
+ Expected: FAIL with "function not defined"
71
+
72
+ **Step 3: Write minimal implementation**
73
+
74
+ ```python
75
+ def function(input):
76
+ return expected
77
+ ```
78
+
79
+ **Step 4: Run test to verify it passes**
80
+
81
+ Run: `pytest tests/path/test.py::test_name -v`
82
+ Expected: PASS
83
+
84
+ **Step 5: Commit**
85
+
86
+ ```bash
87
+ git add tests/path/test.py src/path/file.py
88
+ git commit -m "feat: add specific feature"
89
+ ```
90
+ ```
91
+
92
+ ## Remember
93
+ - Exact file paths always
94
+ - Complete code in plan (not "add validation")
95
+ - Exact commands with expected output
96
+ - Reference relevant skills with @ syntax
97
+ - DRY, YAGNI, TDD, frequent commits
98
+
99
+ ## Execution Handoff
100
+
101
+ After saving the plan, offer execution choice:
102
+
103
+ **"Plan complete and saved to `docs/plans/<filename>.md`. Two execution options:**
104
+
105
+ **1. Subagent-Driven (this session)** - I dispatch fresh subagent per task, review between tasks, fast iteration
106
+
107
+ **2. Parallel Session (separate)** - Open new session with executing-plans, batch execution with checkpoints
108
+
109
+ **Which approach?"**
110
+
111
+ **If Subagent-Driven chosen:**
112
+ - Use skills/collaboration/subagent-driven-development
113
+ - Stay in this session
114
+ - Fresh subagent per task + code review
115
+
116
+ **If Parallel Session chosen:**
117
+ - Guide them to open new session in worktree
118
+ - New session uses skills/collaboration/executing-plans