claude-mpm 4.15.0__py3-none-any.whl → 4.15.2__py3-none-any.whl

claude_mpm/services/diagnostics/checks/configuration_check.py

@@ -11,7 +11,8 @@ from typing import Any, Dict
 
 import yaml
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -52,14 +53,14 @@ class ConfigurationCheck(BaseDiagnosticCheck):
             sub_results.append(perm_result)
 
             # Determine overall status
-            if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            if any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "Configuration has critical issues"
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "Configuration has minor issues"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "Configuration is valid"
 
             return DiagnosticResult(
@@ -73,7 +74,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Configuration check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -85,7 +86,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not config_path.exists():
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No user configuration (using defaults)",
                 details={"path": str(config_path), "exists": False},
             )
@@ -98,14 +99,14 @@ class ConfigurationCheck(BaseDiagnosticCheck):
             if issues:
                 return DiagnosticResult(
                     category="User Config",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"User config has issues: {', '.join(issues)}",
                     details={"path": str(config_path), "issues": issues},
                 )
 
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="User configuration valid",
                 details={
                     "path": str(config_path),
@@ -117,7 +118,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except yaml.YAMLError as e:
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message="User config has invalid YAML",
                 details={"path": str(config_path), "error": str(e)},
                 fix_description="Fix YAML syntax errors in the configuration file",
@@ -125,7 +126,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not read user config: {e!s}",
                 details={"path": str(config_path), "error": str(e)},
             )
@@ -137,7 +138,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not config_path.exists():
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No project configuration (using defaults)",
                 details={"path": str(config_path), "exists": False},
             )
@@ -150,7 +151,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
             if issues:
                 return DiagnosticResult(
                     category="Project Config",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"Project config has issues: {', '.join(issues)}",
                     details={"path": str(config_path), "issues": issues},
                 )
@@ -160,7 +161,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
             if deprecated:
                 return DiagnosticResult(
                     category="Project Config",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"Using deprecated config keys: {', '.join(deprecated)}",
                     details={"path": str(config_path), "deprecated_keys": deprecated},
                     fix_description="Remove deprecated configuration keys",
@@ -168,7 +169,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="Project configuration valid",
                 details={
                     "path": str(config_path),
@@ -180,7 +181,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except yaml.YAMLError as e:
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message="Project config has invalid YAML",
                 details={"path": str(config_path), "error": str(e)},
                 fix_description="Fix YAML syntax errors in the configuration file",
@@ -188,7 +189,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not read project config: {e!s}",
                 details={"path": str(config_path), "error": str(e)},
             )
@@ -207,14 +208,14 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not set_vars:
             return DiagnosticResult(
                 category="Environment Variables",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No claude-mpm environment variables set",
                 details={"variables": {}},
             )
 
         return DiagnosticResult(
             category="Environment Variables",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message=f"{len(set_vars)} environment variable(s) configured",
             details={"variables": set_vars},
         )
@@ -245,7 +246,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not paths_checked:
             return DiagnosticResult(
                 category="Config Permissions",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No configuration files to check",
                 details={"paths_checked": []},
             )
@@ -253,7 +254,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="Config Permissions",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Permission issues: {', '.join(issues)}",
                 details={"issues": issues, "paths_checked": paths_checked},
                 fix_command="chmod 644 ~/.claude/claude-mpm.yaml",
@@ -262,7 +263,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Config Permissions",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="Configuration file permissions are correct",
             details={"paths_checked": paths_checked},
         )

claude_mpm/services/diagnostics/checks/filesystem_check.py

@@ -9,7 +9,8 @@ import os
 import shutil
 from pathlib import Path
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -46,14 +47,14 @@ class FilesystemCheck(BaseDiagnosticCheck):
             details["structure"] = structure_result.details
 
             # Determine overall status
-            if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            if any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "File system has critical issues"
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "File system has minor issues"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "File system healthy"
 
             return DiagnosticResult(
@@ -67,7 +68,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Filesystem check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -106,7 +107,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="Permissions",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"{len(issues)} permission issue(s)",
                 details={"issues": issues, "checked": checked},
                 fix_command="chmod -R 755 .claude",
@@ -116,14 +117,14 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if not checked:
             return DiagnosticResult(
                 category="Permissions",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="No project .claude directories found",
                 details={"checked": [], "missing": [str(d) for d in critical_dirs]},
             )
 
         return DiagnosticResult(
             category="Permissions",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="All permissions valid",
             details={"checked": checked},
         )
@@ -150,7 +151,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
             if free_gb < 0.1:  # Less than 100MB
                 return DiagnosticResult(
                     category="Disk Space",
-                    status=DiagnosticStatus.ERROR,
+                    status=ValidationSeverity.ERROR,
                     message=f"Critical: Only {free_gb:.2f}GB free",
                     details=details,
                     fix_description="Free up disk space immediately",
@@ -158,7 +159,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
             if free_gb < 1:  # Less than 1GB
                 return DiagnosticResult(
                     category="Disk Space",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"Low disk space: {free_gb:.2f}GB free",
                     details=details,
                     fix_description="Consider freeing up disk space",
@@ -166,7 +167,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Disk Space",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"{free_gb:.1f}GB available",
                 details=details,
             )
@@ -174,7 +175,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Disk Space",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check disk space: {e!s}",
                 details={"error": str(e)},
             )
@@ -196,7 +197,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if not base_dir.exists():
             return DiagnosticResult(
                 category="Directory Structure",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="Project .claude directory missing",
                 details={"base_dir": str(base_dir), "exists": False},
                 fix_command="mkdir -p .claude/{agents,responses,memory,logs}",
@@ -213,7 +214,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if missing:
             return DiagnosticResult(
                 category="Directory Structure",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Missing {len(missing)} subdirectory(s)",
                 details={
                     "base_dir": str(base_dir),
@@ -226,7 +227,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Directory Structure",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="Directory structure complete",
             details={"base_dir": str(base_dir), "directories": present},
         )

claude_mpm/services/diagnostics/checks/installation_check.py

@@ -11,8 +11,8 @@ import sys
 from pathlib import Path
 from typing import Optional
 
-from ....core.enums import OperationResult
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -55,14 +55,14 @@ class InstallationCheck(BaseDiagnosticCheck):
             details["dependencies"] = deps_result.details.get("status")
 
             # Determine overall status
-            if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            if any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "Installation has critical issues"
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "Installation has minor issues"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "Installation is healthy"
 
             return DiagnosticResult(
@@ -76,7 +76,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Installation check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -92,7 +92,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if version_info < min_version:
             return DiagnosticResult(
                 category="Python Version",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Python {version_info.major}.{version_info.minor} is below minimum required {min_version[0]}.{min_version[1]}",
                 details={"version": version},
                 fix_description="Upgrade Python to 3.9 or higher",
@@ -100,13 +100,13 @@ class InstallationCheck(BaseDiagnosticCheck):
         if version_info < recommended_version:
             return DiagnosticResult(
                 category="Python Version",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Python {version_info.major}.{version_info.minor} works but {recommended_version[0]}.{recommended_version[1]}+ is recommended",
                 details={"version": version},
             )
         return DiagnosticResult(
             category="Python Version",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message=f"Python {version_info.major}.{version_info.minor}.{version_info.micro}",
             details={"version": version},
         )
@@ -123,7 +123,7 @@ class InstallationCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Claude MPM Version",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"Version: {version}",
                 details={
                     "version": semantic_version,
@@ -134,7 +134,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Claude MPM Version",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="Could not determine version",
                 details={"error": str(e)},
             )
@@ -244,7 +244,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if not methods_found:
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="Installation method unknown",
                 details=details,
             )
@@ -260,7 +260,7 @@ class InstallationCheck(BaseDiagnosticCheck):
                 container_msg += " with virtual environment"
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=container_msg,
                 details=details,
             )
@@ -269,7 +269,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if "pipx" in methods_found:
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="Running from pipx environment (recommended)",
                 details=details,
             )
@@ -279,7 +279,7 @@ class InstallationCheck(BaseDiagnosticCheck):
             venv_name = Path(sys.prefix).name
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"Development mode in virtual environment '{venv_name}'",
                 details=details,
             )
@@ -289,7 +289,7 @@ class InstallationCheck(BaseDiagnosticCheck):
             venv_name = Path(sys.prefix).name
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"Virtual environment '{venv_name}'",
                 details=details,
             )
@@ -298,7 +298,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if "development" in methods_found and "homebrew" in methods_found:
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="Development mode with Homebrew Python",
                 details=details,
             )
@@ -306,7 +306,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if "development" in methods_found:
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="Development mode",
                 details=details,
             )
@@ -316,9 +316,9 @@ class InstallationCheck(BaseDiagnosticCheck):
             msg = "Homebrew Python"
             if details.get("pipx_installed"):
                 msg += " (pipx is installed but not active - consider using 'pipx run claude-mpm')"
-                status = DiagnosticStatus.WARNING
+                status = ValidationSeverity.WARNING
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
             return DiagnosticResult(
                 category="Installation Method",
                 status=status,
@@ -330,7 +330,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if "pip" in methods_found:
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="System pip installation (consider using pipx or venv instead)",
                 details=details,
                 fix_description="Consider reinstalling with pipx for isolated environment",
@@ -340,7 +340,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if "system" in methods_found:
             return DiagnosticResult(
                 category="Installation Method",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="System Python (consider using pipx or venv)",
                 details=details,
             )
@@ -348,7 +348,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         # Fallback for any other combination
         return DiagnosticResult(
             category="Installation Method",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message=f"Installed via {', '.join(methods_found)}",
             details=details,
         )
@@ -400,7 +400,7 @@ class InstallationCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Dependencies",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Missing critical dependencies: {', '.join(missing)}",
                 details={
                     "missing": missing,
@@ -415,7 +415,7 @@ class InstallationCheck(BaseDiagnosticCheck):
         if warnings:
             return DiagnosticResult(
                 category="Dependencies",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Missing optional dependencies: {', '.join(warnings)}",
                 details={
                     "optional_missing": warnings,
@@ -427,7 +427,7 @@ class InstallationCheck(BaseDiagnosticCheck):
             )
         return DiagnosticResult(
             category="Dependencies",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="All dependencies installed",
             details={
                 "status": OperationResult.COMPLETED,

claude_mpm/services/diagnostics/checks/instructions_check.py

@@ -11,7 +11,8 @@ from collections import defaultdict
 from pathlib import Path
 from typing import Dict
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -77,14 +78,14 @@ class InstructionsCheck(BaseDiagnosticCheck):
             sub_results.append(separation_result)
 
             # Determine overall status
-            if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            if any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "Found critical issues with instruction files"
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "Found minor issues with instruction files"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "Instruction files are properly configured"
 
             return DiagnosticResult(
@@ -98,7 +99,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Instructions check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -146,7 +147,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         if not claude_files:
             return DiagnosticResult(
                 category="CLAUDE.md Placement",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No CLAUDE.md files found",
                 details={},
             )
@@ -170,7 +171,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="CLAUDE.md Placement",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Found {len(issues)} misplaced CLAUDE.md file(s)",
                 details={"issues": issues},
                 fix_description=(
@@ -181,7 +182,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="CLAUDE.md Placement",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="CLAUDE.md properly placed in project root",
             details={"count": len(claude_files)},
         )
@@ -191,7 +192,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         if len(files) < 2:
             return DiagnosticResult(
                 category="Duplicate Content",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No duplicate content detected",
                 details={},
             )
@@ -226,7 +227,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         if duplicates:
             return DiagnosticResult(
                 category="Duplicate Content",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Found {len(duplicates)} duplicate content block(s)",
                 details={"duplicates": duplicates[:5]},  # Limit to first 5
                 fix_description=(
@@ -238,7 +239,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Duplicate Content",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="No significant duplicate content found",
             details={},
         )
@@ -280,7 +281,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         if conflicts:
             return DiagnosticResult(
                 category="Conflicting Directives",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Found {len(conflicts)} potential conflict(s)",
                 details={"conflicts": conflicts},
                 fix_description=(
@@ -292,7 +293,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Conflicting Directives",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="No conflicting directives detected",
             details={},
         )
@@ -330,7 +331,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         if duplicates:
             return DiagnosticResult(
                 category="Agent Definitions",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Found {len(duplicates)} duplicate agent definition(s)",
                 details={"duplicates": duplicates},
                 fix_description=(
@@ -341,7 +342,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Agent Definitions",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="Agent definitions are unique",
             details={"total_agents": len(agent_definitions)},
         )
@@ -396,7 +397,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="Separation of Concerns",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Found {len(issues)} separation of concerns issue(s)",
                 details={"issues": issues},
                 fix_description=(
@@ -409,7 +410,7 @@ class InstructionsCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Separation of Concerns",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="Instruction files properly separated",
             details={},
         )