claude-mpm 4.14.9__py3-none-any.whl → 4.15.1__py3-none-any.whl

claude_mpm/services/agents/deployment/pipeline/steps/target_directory_step.py

@@ -3,7 +3,9 @@
 import time
 from pathlib import Path
 
-from .base_step import BaseDeploymentStep, StepResult, StepStatus
+from claude_mpm.core.enums import OperationResult
+
+from .base_step import BaseDeploymentStep, StepResult
 
 
 class TargetDirectorySetupStep(BaseDeploymentStep):
@@ -59,7 +61,7 @@ class TargetDirectorySetupStep(BaseDeploymentStep):
             context.step_timings[self.name] = execution_time
 
             return StepResult(
-                status=StepStatus.SUCCESS,
+                status=OperationResult.SUCCESS,
                 message=f"Target directory set up at {context.actual_target_dir} in {execution_time:.3f}s",
                 execution_time=execution_time,
             )
@@ -73,7 +75,7 @@ class TargetDirectorySetupStep(BaseDeploymentStep):
             context.add_error(error_msg)
 
             return StepResult(
-                status=StepStatus.FAILURE,
+                status=OperationResult.FAILED,
                 message=error_msg,
                 error=e,
                 execution_time=execution_time,

claude_mpm/services/agents/deployment/pipeline/steps/validation_step.py

@@ -2,9 +2,10 @@
 
 import time
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.services.agents.deployment.validation import DeploymentValidator
 
-from .base_step import BaseDeploymentStep, StepResult, StepStatus
+from .base_step import BaseDeploymentStep, StepResult
 
 
 class ValidationStep(BaseDeploymentStep):
@@ -49,13 +50,13 @@ class ValidationStep(BaseDeploymentStep):
 
             # Determine step status
             if not validation_result.is_valid:
-                status = StepStatus.FAILURE
+                status = OperationResult.FAILED
                 message = f"Validation failed with {validation_result.error_count} errors in {execution_time:.3f}s"
             elif validation_result.has_warnings:
-                status = StepStatus.WARNING
+                status = OperationResult.WARNING
                 message = f"Validation completed with {validation_result.warning_count} warnings in {execution_time:.3f}s"
             else:
-                status = StepStatus.SUCCESS
+                status = OperationResult.SUCCESS
                 message = f"Validation passed successfully in {execution_time:.3f}s"
 
             self.logger.info(message)
@@ -73,7 +74,7 @@ class ValidationStep(BaseDeploymentStep):
             context.add_error(error_msg)
 
             return StepResult(
-                status=StepStatus.FAILURE,
+                status=OperationResult.FAILED,
                 message=error_msg,
                 error=e,
                 execution_time=execution_time,

claude_mpm/services/agents/deployment/refactored_agent_deployment_service.py

@@ -117,8 +117,10 @@ class RefactoredAgentDeploymentService(AgentDeploymentInterface):
             )
 
             # Ensure success field is present
-            if "success" not in results:
-                results["success"] = not bool(results.get("errors", []))
+            if OperationResult.SUCCESS.value not in results:
+                results[OperationResult.SUCCESS.value] = not bool(
+                    results.get("errors", [])
+                )
 
             self.logger.info(f"Deployment completed: {results.get('success', False)}")
             return results
@@ -126,7 +128,7 @@ class RefactoredAgentDeploymentService(AgentDeploymentInterface):
         except Exception as e:
             self.logger.error(f"Deployment failed: {e}", exc_info=True)
             return {
-                "success": False,
+                OperationResult.SUCCESS.value: False,
                 "error": str(e),
                 "deployed": [],
                 "updated": [],
@@ -302,7 +304,7 @@ class RefactoredAgentDeploymentService(AgentDeploymentInterface):
         except Exception as e:
             self.logger.error(f"Async deployment failed: {e}", exc_info=True)
             return {
-                "success": False,
+                OperationResult.SUCCESS.value: False,
                 "error": str(e),
                 "deployed": [],
                 "updated": [],

claude_mpm/services/agents/registry/modification_tracker.py

@@ -36,6 +36,7 @@ from watchdog.events import FileSystemEvent, FileSystemEventHandler
 from watchdog.observers import Observer
 
 from claude_mpm.core.base_service import BaseService
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logging_utils import get_logger
 from claude_mpm.core.unified_agent_registry import UnifiedAgentRegistry as AgentRegistry
 from claude_mpm.core.unified_paths import get_path_manager
@@ -551,12 +552,14 @@ class AgentModificationTracker(BaseService):
                     errors.append(f"File does not exist: {modification.file_path}")
 
             # Update validation status
-            modification.validation_status = "failed" if errors else "passed"
+            modification.validation_status = (
+                OperationResult.FAILED if errors else OperationResult.SUCCESS
+            )
             modification.validation_errors = errors
 
         except Exception as e:
             self.logger.error(f"Validation error: {e}")
-            modification.validation_status = "error"
+            modification.validation_status = OperationResult.ERROR
             modification.validation_errors.append(str(e))
 
     async def _invalidate_agent_cache(self, agent_name: str) -> None:

claude_mpm/services/command_handler_service.py

@@ -12,6 +12,7 @@ Extracted from ClaudeRunner to follow Single Responsibility Principle.
 from typing import Any, Dict, List
 
 from claude_mpm.core.base_service import BaseService
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.services.core.interfaces import CommandHandlerInterface
 
 
@@ -169,7 +170,7 @@ class CommandHandlerService(BaseService, CommandHandlerInterface):
             if command == "test":
                 success = self._handle_test_command(args)
                 return {
-                    "success": success,
+                    OperationResult.SUCCESS.value: success,
                     "command": command,
                     "args": args,
                     "message": (
@@ -179,7 +180,7 @@ class CommandHandlerService(BaseService, CommandHandlerInterface):
             if command == "agents":
                 success = self._handle_agents_command(args)
                 return {
-                    "success": success,
+                    OperationResult.SUCCESS.value: success,
                     "command": command,
                     "args": args,
                     "message": (
@@ -189,14 +190,19 @@ class CommandHandlerService(BaseService, CommandHandlerInterface):
                     ),
                 }
             return {
-                "success": False,
+                OperationResult.SUCCESS.value: False,
                 "command": command,
                 "args": args,
-                "error": f"Unknown command: {command}",
+                OperationResult.ERROR.value: f"Unknown command: {command}",
                 "available_commands": self.get_available_commands(),
             }
         except Exception as e:
-            return {"success": False, "command": command, "args": args, "error": str(e)}
+            return {
+                OperationResult.SUCCESS.value: False,
+                "command": command,
+                "args": args,
+                OperationResult.ERROR.value: str(e),
+            }
 
     def get_command_help(self, command: str) -> str:
         """Get help text for a specific command.

claude_mpm/services/core/interfaces/process.py

@@ -32,10 +32,10 @@ USAGE:
 from abc import ABC, abstractmethod
 from typing import Dict, List, Optional
 
+from claude_mpm.core.enums import ServiceState
 from claude_mpm.services.core.models.process import (
     DeploymentState,
     ProcessInfo,
-    ProcessStatus,
     StartConfig,
 )
 
@@ -102,12 +102,12 @@ class IDeploymentStateManager(ABC):
         """
 
     @abstractmethod
-    def get_deployments_by_status(self, status: ProcessStatus) -> List[DeploymentState]:
+    def get_deployments_by_status(self, status: ServiceState) -> List[DeploymentState]:
         """
         Get all deployments with a specific status.
 
         Args:
-            status: ProcessStatus to filter by
+            status: ServiceState to filter by
 
         Returns:
             List of matching DeploymentState objects
@@ -168,14 +168,14 @@ class IDeploymentStateManager(ABC):
 
     @abstractmethod
     def update_deployment_status(
-        self, deployment_id: str, status: ProcessStatus
+        self, deployment_id: str, status: ServiceState
     ) -> bool:
         """
         Update the status of a deployment.
 
         Args:
             deployment_id: Unique deployment identifier
-            status: New ProcessStatus
+            status: New ServiceState
 
         Returns:
             True if updated, False if deployment not found
@@ -290,7 +290,7 @@ class ILocalProcessManager(ABC):
 
     @abstractmethod
     def list_processes(
-        self, status_filter: Optional[ProcessStatus] = None
+        self, status_filter: Optional[ServiceState] = None
     ) -> List[ProcessInfo]:
         """
         List all managed processes.

claude_mpm/services/core/models/__init__.py

@@ -24,7 +24,6 @@ from .process import (
     PROTECTED_PORT_RANGES,
     DeploymentState,
     ProcessInfo,
-    ProcessStatus,
     StartConfig,
     is_port_protected,
 )
@@ -63,7 +62,6 @@ __all__ = [  # noqa: RUF022 - Grouped by category with comments for clarity
     "ValidationResult",
     "ConfigurationPreview",
     # Process management models
-    "ProcessStatus",
     "DeploymentState",
     "ProcessInfo",
     "StartConfig",

claude_mpm/services/core/models/agent_config.py

@@ -17,6 +17,8 @@ from dataclasses import dataclass, field
 from enum import Enum
 from typing import Any, Dict, List, Optional
 
+from ....core.enums import OperationResult, ValidationSeverity
+
 
 class AgentSpecialization(str, Enum):
     """Agent specialization categories.
@@ -154,20 +156,6 @@ class AgentRecommendation:
         }
 
 
-class ConfigurationStatus(str, Enum):
-    """Status of configuration operation.
-
-    WHY: Configuration can succeed, fail, or partially succeed. This enum
-    provides a standardized way to communicate operation outcomes.
-    """
-
-    SUCCESS = "success"
-    PARTIAL_SUCCESS = "partial_success"
-    FAILURE = "failure"
-    VALIDATION_ERROR = "validation_error"
-    USER_CANCELLED = "user_cancelled"
-
-
 @dataclass
 class ConfigurationResult:
     """Result of automated configuration operation.
@@ -179,9 +167,17 @@ class ConfigurationResult:
     DESIGN DECISION: Separates successful and failed deployments to enable
     proper error handling. Includes validation results and user-facing
     messages for transparency.
+
+    NOTE: Uses core OperationResult enum (consolidated from ConfigurationStatus
+    in Phase 3A Batch 25). Mappings:
+    - SUCCESS → OperationResult.SUCCESS
+    - PARTIAL_SUCCESS → OperationResult.WARNING (partial success with issues)
+    - FAILURE → OperationResult.FAILED
+    - VALIDATION_ERROR → OperationResult.ERROR
+    - USER_CANCELLED → OperationResult.CANCELLED
     """
 
-    status: ConfigurationStatus
+    status: OperationResult
     deployed_agents: List[str] = field(default_factory=list)
     failed_agents: List[str] = field(default_factory=list)
     validation_warnings: List[str] = field(default_factory=list)
@@ -193,7 +189,7 @@ class ConfigurationResult:
     @property
     def is_successful(self) -> bool:
         """Check if configuration was completely successful."""
-        return self.status == ConfigurationStatus.SUCCESS
+        return self.status == OperationResult.SUCCESS
 
     @property
     def has_failures(self) -> bool:
@@ -223,18 +219,6 @@ class ConfigurationResult:
         }
 
 
-class ValidationSeverity(str, Enum):
-    """Severity level for validation issues.
-
-    WHY: Not all validation issues are equally critical. This enum enables
-    categorization of issues by severity to support appropriate handling.
-    """
-
-    ERROR = "error"  # Blocks deployment
-    WARNING = "warning"  # Should be reviewed but doesn't block
-    INFO = "info"  # Informational only
-
-
 @dataclass
 class ValidationIssue:
     """Represents a validation issue.

claude_mpm/services/core/models/process.py

@@ -3,56 +3,27 @@ Process Management Data Models for Claude MPM Framework
 ========================================================
 
 WHY: This module defines data structures for process management operations,
-including process status, deployment state, and runtime information.
+including deployment state and runtime information.
 
 DESIGN DECISION: Uses dataclasses for immutability and type safety. Provides
-serialization methods for state persistence.
+serialization methods for state persistence. Process status uses ServiceState
+enum from core.enums (consolidated in Phase 3A Batch 24).
 
 ARCHITECTURE:
-- ProcessStatus: Enum of process lifecycle states
 - DeploymentState: Complete deployment information for persistence
 - ProcessInfo: Runtime process information
 - StartConfig: Configuration for spawning new processes
+
+Note: ProcessStatus enum has been consolidated into ServiceState (core.enums).
 """
 
 import json
 from dataclasses import asdict, dataclass, field
 from datetime import datetime
-from enum import Enum
 from pathlib import Path
 from typing import Any, Dict, List, Optional
 
-
-class ProcessStatus(Enum):
-    """
-    Process lifecycle status.
-
-    WHY: Explicit status tracking enables proper state machine management
-    and prevents invalid state transitions.
-
-    States:
-        STARTING: Process is being spawned
-        RUNNING: Process is actively running
-        STOPPING: Process is shutting down
-        STOPPED: Process has stopped cleanly
-        CRASHED: Process terminated unexpectedly
-        UNKNOWN: Process state cannot be determined
-    """
-
-    STARTING = "starting"
-    RUNNING = "running"
-    STOPPING = "stopping"
-    STOPPED = "stopped"
-    CRASHED = "crashed"
-    UNKNOWN = "unknown"
-
-    def is_active(self) -> bool:
-        """Check if status represents an active process."""
-        return self in (ProcessStatus.STARTING, ProcessStatus.RUNNING)
-
-    def is_terminal(self) -> bool:
-        """Check if status represents a terminal state."""
-        return self in (ProcessStatus.STOPPED, ProcessStatus.CRASHED)
+from claude_mpm.core.enums import ServiceState
 
 
 @dataclass
@@ -71,7 +42,7 @@ class DeploymentState:
         environment: Environment variables (beyond inherited ones)
         port: Primary port used by the process (if applicable)
         started_at: Timestamp when process was started
-        status: Current ProcessStatus
+        status: Current ServiceState (process lifecycle state)
         metadata: Additional deployment-specific information
     """
 
@@ -82,7 +53,7 @@ class DeploymentState:
     environment: Dict[str, str] = field(default_factory=dict)
     port: Optional[int] = None
     started_at: datetime = field(default_factory=datetime.now)
-    status: ProcessStatus = ProcessStatus.STARTING
+    status: ServiceState = ServiceState.STARTING
     metadata: Dict[str, Any] = field(default_factory=dict)
 
     def to_dict(self) -> Dict[str, Any]:
@@ -114,7 +85,14 @@ class DeploymentState:
 
         # Convert status string to enum
         if isinstance(data.get("status"), str):
-            data["status"] = ProcessStatus(data["status"])
+            status_value = data["status"]
+            # Handle legacy "crashed" status -> map to ERROR
+            if status_value == "crashed":
+                data["status"] = (
+                    ServiceState.ERROR
+                )  # CRASHED semantically maps to ERROR state
+            else:
+                data["status"] = ServiceState(status_value)
 
         return cls(**data)
 
@@ -153,18 +131,18 @@ class ProcessInfo:
     Attributes:
         deployment_id: Unique deployment identifier
         process_id: OS process ID
-        status: Current ProcessStatus
+        status: Current ServiceState (process lifecycle state)
         port: Port the process is using
         uptime_seconds: How long the process has been running
         memory_mb: Current memory usage in megabytes
         cpu_percent: Current CPU usage percentage
         is_responding: Whether the process responds to health checks
-        error_message: Error message if status is CRASHED
+        error_message: Error message if status is ERROR (crashed)
     """
 
     deployment_id: str
     process_id: int
-    status: ProcessStatus
+    status: ServiceState
     port: Optional[int] = None
     uptime_seconds: float = 0.0
     memory_mb: float = 0.0
@@ -252,7 +230,6 @@ __all__ = [
     "PROTECTED_PORT_RANGES",
     "DeploymentState",
     "ProcessInfo",
-    "ProcessStatus",
     "StartConfig",
     "is_port_protected",
 ]

claude_mpm/services/diagnostics/__init__.py

@@ -13,6 +13,6 @@ DESIGN DECISIONS:
 
 from .diagnostic_runner import DiagnosticRunner
 from .doctor_reporter import DoctorReporter
-from .models import DiagnosticResult, DiagnosticStatus
+from .models import DiagnosticResult
 
-__all__ = ["DiagnosticResult", "DiagnosticRunner", "DiagnosticStatus", "DoctorReporter"]
+__all__ = ["DiagnosticResult", "DiagnosticRunner", "DoctorReporter"]

claude_mpm/services/diagnostics/checks/agent_check.py

@@ -6,7 +6,8 @@ WHY: Verify that agents are properly deployed, up-to-date, and functioning corre
 
 from pathlib import Path
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -64,29 +65,29 @@ class AgentCheck(BaseDiagnosticCheck):
             available_count = details["available_count"]
 
             if deployed_count == 0:
-                status = DiagnosticStatus.ERROR
+                status = ValidationSeverity.ERROR
                 message = f"No agents deployed (0/{available_count} available)"
                 fix_command = "claude-mpm agents deploy"
                 fix_description = "Deploy all available agents"
             elif deployed_count < available_count:
-                status = DiagnosticStatus.WARNING
+                status = ValidationSeverity.WARNING
                 message = f"{deployed_count}/{available_count} agents deployed"
                 fix_command = "claude-mpm agents deploy"
                 fix_description = (
                     f"Deploy remaining {available_count - deployed_count} agents"
                 )
-            elif any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            elif any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "Agents have critical issues"
                 fix_command = None
                 fix_description = None
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "Agents have minor issues"
                 fix_command = None
                 fix_description = None
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = f"All {deployed_count} agents properly deployed"
                 fix_command = None
                 fix_description = None
@@ -104,7 +105,7 @@ class AgentCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Agent check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -127,7 +128,7 @@ class AgentCheck(BaseDiagnosticCheck):
             # Neither exists, default to user directory for error message
             return DiagnosticResult(
                 category="Deployed Agents",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message="No agents directory found (checked project and user)",
                 details={
                     "project_path": str(project_agents_dir),
@@ -144,7 +145,7 @@ class AgentCheck(BaseDiagnosticCheck):
         if not agent_files:
             return DiagnosticResult(
                 category="Deployed Agents",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"No agents deployed in {location} directory",
                 details={"path": str(agents_dir), "location": location, "count": 0},
                 fix_command="claude-mpm agents deploy",
@@ -159,7 +160,7 @@ class AgentCheck(BaseDiagnosticCheck):
         if missing_core:
             return DiagnosticResult(
                 category="Deployed Agents",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Missing core agents in {location}: {', '.join(missing_core)}",
                 details={
                     "path": str(agents_dir),
@@ -174,7 +175,7 @@ class AgentCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Deployed Agents",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message=f"{len(agent_files)} agents deployed ({location} level)",
             details={
                 "path": str(agents_dir),
@@ -205,7 +206,7 @@ class AgentCheck(BaseDiagnosticCheck):
             else:
                 return DiagnosticResult(
                     category="Agent Versions",
-                    status=DiagnosticStatus.SKIPPED,
+                    status=OperationResult.SKIPPED,
                     message="No agents to check",
                     details={},
                 )
@@ -224,7 +225,7 @@ class AgentCheck(BaseDiagnosticCheck):
             if outdated:
                 return DiagnosticResult(
                     category="Agent Versions",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"{len(outdated)} agent(s) outdated",
                     details={"outdated": outdated, "checked": checked},
                     fix_command="claude-mpm agents update",
@@ -234,14 +235,14 @@ class AgentCheck(BaseDiagnosticCheck):
             if checked == 0:
                 return DiagnosticResult(
                     category="Agent Versions",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message="No agents to check",
                     details={"checked": 0},
                 )
 
             return DiagnosticResult(
                 category="Agent Versions",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"All {checked} agents up-to-date",
                 details={"checked": checked},
             )
@@ -249,7 +250,7 @@ class AgentCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Agent Versions",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check versions: {e!s}",
                 details={"error": str(e)},
             )
@@ -273,7 +274,7 @@ class AgentCheck(BaseDiagnosticCheck):
             else:
                 return DiagnosticResult(
                     category="Agent Validation",
-                    status=DiagnosticStatus.SKIPPED,
+                    status=OperationResult.SKIPPED,
                     message="No agents to validate",
                     details={},
                 )
@@ -301,14 +302,14 @@ class AgentCheck(BaseDiagnosticCheck):
             if invalid:
                 return DiagnosticResult(
                     category="Agent Validation",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"{len(invalid)} validation issue(s)",
                     details={"issues": invalid, "validated": validated},
                 )
 
             return DiagnosticResult(
                 category="Agent Validation",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"All {validated} agents valid",
                 details={"validated": validated},
             )
@@ -316,7 +317,7 @@ class AgentCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Agent Validation",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Validation failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -358,14 +359,14 @@ class AgentCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="Common Issues",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"{len(issues)} issue(s) found",
                 details={"issues": issues},
             )
 
         return DiagnosticResult(
             category="Common Issues",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="No common issues detected",
             details={},
         )