claude-mpm 4.14.6__py3-none-any.whl → 4.21.0__py3-none-any.whl

claude_mpm/services/core/models/process.py

@@ -3,56 +3,30 @@ Process Management Data Models for Claude MPM Framework
 ========================================================
 
 WHY: This module defines data structures for process management operations,
-including process status, deployment state, and runtime information.
+including deployment state and runtime information.
 
 DESIGN DECISION: Uses dataclasses for immutability and type safety. Provides
-serialization methods for state persistence.
+serialization methods for state persistence. Process status uses ServiceState
+enum from core.enums (consolidated in Phase 3A Batch 24).
 
 ARCHITECTURE:
-- ProcessStatus: Enum of process lifecycle states
 - DeploymentState: Complete deployment information for persistence
 - ProcessInfo: Runtime process information
 - StartConfig: Configuration for spawning new processes
+
+Note: ProcessStatus enum has been consolidated into ServiceState (core.enums).
 """
 
 import json
 from dataclasses import asdict, dataclass, field
 from datetime import datetime
-from enum import Enum
 from pathlib import Path
 from typing import Any, Dict, List, Optional
 
+from claude_mpm.core.enums import ServiceState
 
-class ProcessStatus(Enum):
-    """
-    Process lifecycle status.
-
-    WHY: Explicit status tracking enables proper state machine management
-    and prevents invalid state transitions.
-
-    States:
-        STARTING: Process is being spawned
-        RUNNING: Process is actively running
-        STOPPING: Process is shutting down
-        STOPPED: Process has stopped cleanly
-        CRASHED: Process terminated unexpectedly
-        UNKNOWN: Process state cannot be determined
-    """
-
-    STARTING = "starting"
-    RUNNING = "running"
-    STOPPING = "stopping"
-    STOPPED = "stopped"
-    CRASHED = "crashed"
-    UNKNOWN = "unknown"
-
-    def is_active(self) -> bool:
-        """Check if status represents an active process."""
-        return self in (ProcessStatus.STARTING, ProcessStatus.RUNNING)
-
-    def is_terminal(self) -> bool:
-        """Check if status represents a terminal state."""
-        return self in (ProcessStatus.STOPPED, ProcessStatus.CRASHED)
+# Backward compatibility alias (consolidated in Phase 3A Batch 24)
+ProcessStatus = ServiceState
 
 
 @dataclass
@@ -71,7 +45,7 @@ class DeploymentState:
         environment: Environment variables (beyond inherited ones)
         port: Primary port used by the process (if applicable)
         started_at: Timestamp when process was started
-        status: Current ProcessStatus
+        status: Current ServiceState (process lifecycle state)
         metadata: Additional deployment-specific information
     """
 
@@ -82,7 +56,7 @@ class DeploymentState:
     environment: Dict[str, str] = field(default_factory=dict)
     port: Optional[int] = None
     started_at: datetime = field(default_factory=datetime.now)
-    status: ProcessStatus = ProcessStatus.STARTING
+    status: ServiceState = ServiceState.STARTING
     metadata: Dict[str, Any] = field(default_factory=dict)
 
     def to_dict(self) -> Dict[str, Any]:
@@ -114,7 +88,14 @@ class DeploymentState:
 
         # Convert status string to enum
         if isinstance(data.get("status"), str):
-            data["status"] = ProcessStatus(data["status"])
+            status_value = data["status"]
+            # Handle legacy "crashed" status -> map to ERROR
+            if status_value == "crashed":
+                data["status"] = (
+                    ServiceState.ERROR
+                )  # CRASHED semantically maps to ERROR state
+            else:
+                data["status"] = ServiceState(status_value)
 
         return cls(**data)
 
@@ -153,18 +134,18 @@ class ProcessInfo:
     Attributes:
         deployment_id: Unique deployment identifier
         process_id: OS process ID
-        status: Current ProcessStatus
+        status: Current ServiceState (process lifecycle state)
         port: Port the process is using
         uptime_seconds: How long the process has been running
         memory_mb: Current memory usage in megabytes
         cpu_percent: Current CPU usage percentage
         is_responding: Whether the process responds to health checks
-        error_message: Error message if status is CRASHED
+        error_message: Error message if status is ERROR (crashed)
     """
 
     deployment_id: str
     process_id: int
-    status: ProcessStatus
+    status: ServiceState
     port: Optional[int] = None
     uptime_seconds: float = 0.0
     memory_mb: float = 0.0
@@ -252,7 +233,7 @@ __all__ = [
     "PROTECTED_PORT_RANGES",
     "DeploymentState",
     "ProcessInfo",
-    "ProcessStatus",
+    "ProcessStatus",  # Backward compatibility alias for ServiceState
     "StartConfig",
     "is_port_protected",
 ]

claude_mpm/services/core/path_resolver.py

@@ -281,7 +281,7 @@ class PathResolver(IPathResolver):
 
         if agents_dir and agents_dir.exists():
             discovered_agents_dir = agents_dir
-            self.logger.info(f"Using custom agents directory: {discovered_agents_dir}")
+            self.logger.debug(f"Using custom agents directory: {discovered_agents_dir}")
         elif framework_path and framework_path != Path("__PACKAGED__"):
             # Prioritize templates directory over main agents directory
             templates_dir = (

claude_mpm/services/diagnostics/__init__.py

@@ -13,6 +13,6 @@ DESIGN DECISIONS:
 
 from .diagnostic_runner import DiagnosticRunner
 from .doctor_reporter import DoctorReporter
-from .models import DiagnosticResult, DiagnosticStatus
+from .models import DiagnosticResult
 
-__all__ = ["DiagnosticResult", "DiagnosticRunner", "DiagnosticStatus", "DoctorReporter"]
+__all__ = ["DiagnosticResult", "DiagnosticRunner", "DoctorReporter"]

claude_mpm/services/diagnostics/checks/agent_check.py

@@ -6,7 +6,8 @@ WHY: Verify that agents are properly deployed, up-to-date, and functioning corre
 
 from pathlib import Path
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -64,29 +65,29 @@ class AgentCheck(BaseDiagnosticCheck):
             available_count = details["available_count"]
 
             if deployed_count == 0:
-                status = DiagnosticStatus.ERROR
+                status = ValidationSeverity.ERROR
                 message = f"No agents deployed (0/{available_count} available)"
                 fix_command = "claude-mpm agents deploy"
                 fix_description = "Deploy all available agents"
             elif deployed_count < available_count:
-                status = DiagnosticStatus.WARNING
+                status = ValidationSeverity.WARNING
                 message = f"{deployed_count}/{available_count} agents deployed"
                 fix_command = "claude-mpm agents deploy"
                 fix_description = (
                     f"Deploy remaining {available_count - deployed_count} agents"
                 )
-            elif any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            elif any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "Agents have critical issues"
                 fix_command = None
                 fix_description = None
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "Agents have minor issues"
                 fix_command = None
                 fix_description = None
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = f"All {deployed_count} agents properly deployed"
                 fix_command = None
                 fix_description = None
@@ -104,7 +105,7 @@ class AgentCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Agent check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -127,7 +128,7 @@ class AgentCheck(BaseDiagnosticCheck):
             # Neither exists, default to user directory for error message
             return DiagnosticResult(
                 category="Deployed Agents",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message="No agents directory found (checked project and user)",
                 details={
                     "project_path": str(project_agents_dir),
@@ -144,7 +145,7 @@ class AgentCheck(BaseDiagnosticCheck):
         if not agent_files:
             return DiagnosticResult(
                 category="Deployed Agents",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"No agents deployed in {location} directory",
                 details={"path": str(agents_dir), "location": location, "count": 0},
                 fix_command="claude-mpm agents deploy",
@@ -159,7 +160,7 @@ class AgentCheck(BaseDiagnosticCheck):
         if missing_core:
             return DiagnosticResult(
                 category="Deployed Agents",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Missing core agents in {location}: {', '.join(missing_core)}",
                 details={
                     "path": str(agents_dir),
@@ -174,7 +175,7 @@ class AgentCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Deployed Agents",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message=f"{len(agent_files)} agents deployed ({location} level)",
             details={
                 "path": str(agents_dir),
@@ -205,7 +206,7 @@ class AgentCheck(BaseDiagnosticCheck):
             else:
                 return DiagnosticResult(
                     category="Agent Versions",
-                    status=DiagnosticStatus.SKIPPED,
+                    status=OperationResult.SKIPPED,
                     message="No agents to check",
                     details={},
                 )
@@ -224,7 +225,7 @@ class AgentCheck(BaseDiagnosticCheck):
             if outdated:
                 return DiagnosticResult(
                     category="Agent Versions",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"{len(outdated)} agent(s) outdated",
                     details={"outdated": outdated, "checked": checked},
                     fix_command="claude-mpm agents update",
@@ -234,14 +235,14 @@ class AgentCheck(BaseDiagnosticCheck):
             if checked == 0:
                 return DiagnosticResult(
                     category="Agent Versions",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message="No agents to check",
                     details={"checked": 0},
                 )
 
             return DiagnosticResult(
                 category="Agent Versions",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"All {checked} agents up-to-date",
                 details={"checked": checked},
             )
@@ -249,7 +250,7 @@ class AgentCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Agent Versions",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check versions: {e!s}",
                 details={"error": str(e)},
             )
@@ -273,7 +274,7 @@ class AgentCheck(BaseDiagnosticCheck):
             else:
                 return DiagnosticResult(
                     category="Agent Validation",
-                    status=DiagnosticStatus.SKIPPED,
+                    status=OperationResult.SKIPPED,
                     message="No agents to validate",
                     details={},
                 )
@@ -301,14 +302,14 @@ class AgentCheck(BaseDiagnosticCheck):
             if invalid:
                 return DiagnosticResult(
                     category="Agent Validation",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"{len(invalid)} validation issue(s)",
                     details={"issues": invalid, "validated": validated},
                 )
 
             return DiagnosticResult(
                 category="Agent Validation",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"All {validated} agents valid",
                 details={"validated": validated},
             )
@@ -316,7 +317,7 @@ class AgentCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Agent Validation",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Validation failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -358,14 +359,14 @@ class AgentCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="Common Issues",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"{len(issues)} issue(s) found",
                 details={"issues": issues},
             )
 
         return DiagnosticResult(
             category="Common Issues",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="No common issues detected",
             details={},
         )

claude_mpm/services/diagnostics/checks/claude_code_check.py

@@ -9,7 +9,8 @@ import json
 import subprocess
 from pathlib import Path
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -33,9 +34,9 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
             # Check if Claude Code CLI is installed
             install_result = self._check_installation()
             sub_results.append(install_result)
-            details["installed"] = install_result.status == DiagnosticStatus.OK
+            details["installed"] = install_result.status == OperationResult.SUCCESS
 
-            if install_result.status == DiagnosticStatus.OK:
+            if install_result.status == OperationResult.SUCCESS:
                 # Check version compatibility
                 version_result = self._check_version()
                 sub_results.append(version_result)
@@ -49,17 +50,17 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
                 # Check MCP integration
                 mcp_result = self._check_mcp_integration()
                 sub_results.append(mcp_result)
-                details["mcp_configured"] = mcp_result.status == DiagnosticStatus.OK
+                details["mcp_configured"] = mcp_result.status == OperationResult.SUCCESS
 
             # Determine overall status
-            if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            if any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "Claude Code CLI has critical issues"
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "Claude Code CLI needs configuration"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "Claude Code CLI properly configured"
 
             return DiagnosticResult(
@@ -73,7 +74,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Claude Code CLI check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -92,7 +93,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
             if result.returncode == 0:
                 return DiagnosticResult(
                     category="Claude Code CLI Installation",
-                    status=DiagnosticStatus.OK,
+                    status=OperationResult.SUCCESS,
                     message="Claude Code CLI is installed and accessible",
                     details={
                         "installed": True,
@@ -115,14 +116,14 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
             if path.exists() and path.is_file():
                 return DiagnosticResult(
                     category="Claude Code CLI Installation",
-                    status=DiagnosticStatus.OK,
+                    status=OperationResult.SUCCESS,
                     message=f"Claude Code CLI found at {path}",
                     details={"installed": True, "path": str(path)},
                 )
 
         return DiagnosticResult(
             category="Claude Code CLI Installation",
-            status=DiagnosticStatus.ERROR,
+            status=ValidationSeverity.ERROR,
             message="Claude Code CLI not found",
             details={"installed": False},
             fix_description="Install Claude Code CLI from https://claude.ai/code",
@@ -150,7 +151,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
                         break
 
             # Check minimum version requirement (1.0.60+)
-            status = DiagnosticStatus.OK
+            status = OperationResult.SUCCESS
             message = f"Version: {version}"
 
             return DiagnosticResult(
@@ -166,7 +167,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
         except subprocess.SubprocessError as e:
             return DiagnosticResult(
                 category="Claude Code CLI Version",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not determine version: {e}",
                 details={"version": "unknown", "error": str(e)},
             )
@@ -178,7 +179,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
         if not style_path.exists():
             return DiagnosticResult(
                 category="Output Style",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="Output style not deployed",
                 details={"deployed": False, "path": str(style_path)},
                 fix_command="claude-mpm deploy-style",
@@ -192,13 +193,13 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
                 if "Claude MPM Output Style" in content:
                     return DiagnosticResult(
                         category="Output Style",
-                        status=DiagnosticStatus.OK,
+                        status=OperationResult.SUCCESS,
                         message="Output style deployed",
                         details={"deployed": True, "path": str(style_path)},
                     )
                 return DiagnosticResult(
                     category="Output Style",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message="Output style outdated",
                     details={
                         "deployed": True,
@@ -211,7 +212,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Output Style",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check output style: {e!s}",
                 details={"error": str(e)},
             )
@@ -224,7 +225,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
         if not config_path.exists():
             return DiagnosticResult(
                 category="MCP Integration",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="Claude Code CLI config not found",
                 details={"configured": False, "config_path": str(config_path)},
                 fix_command="claude-mpm mcp install",
@@ -239,7 +240,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
                 if "claude-mpm-gateway" in mcp_servers or "claude-mpm" in mcp_servers:
                     return DiagnosticResult(
                         category="MCP Integration",
-                        status=DiagnosticStatus.OK,
+                        status=OperationResult.SUCCESS,
                         message="MCP server configured",
                         details={
                             "configured": True,
@@ -249,7 +250,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
                     )
                 return DiagnosticResult(
                     category="MCP Integration",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message="MCP server not configured",
                     details={
                         "configured": False,
@@ -263,7 +264,7 @@ class ClaudeCodeCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="MCP Integration",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check MCP configuration: {e!s}",
                 details={"error": str(e)},
             )