claude-mpm 4.1.26__py3-none-any.whl → 5.0.9__py3-none-any.whl

claude_mpm/services/async_session_logger.py

@@ -22,18 +22,22 @@ import os
 import sys
 import time
 from dataclasses import asdict, dataclass
-from datetime import datetime
+from datetime import datetime, timezone
 from enum import Enum
 from queue import Full, Queue
 from threading import Lock, Thread
 from typing import Any, Dict, Optional
 
 from claude_mpm.core.constants import PerformanceConfig, SystemLimits, TimeoutConfig
+from claude_mpm.core.logging_utils import get_logger
+
+# Import centralized session manager
+from claude_mpm.services.session_manager import get_session_manager
 
 # Import configuration manager
 from ..core.config import Config
 
-logger = logging.getLogger(__name__)
+logger = get_logger(__name__)
 
 
 class LogFormat(Enum):
@@ -67,8 +71,13 @@ class AsyncSessionLogger:
     - Configurable log formats (JSON, syslog, journald)
     - Fire-and-forget pattern for zero latency impact
     - Graceful degradation on errors
+    - Thread-safe singleton pattern with initialization flag
     """
 
+    _initialization_lock = Lock()
+    _initialized = False
+    _worker_started = False
+
     def __init__(
         self,
         base_dir: Optional[Path] = None,
@@ -89,104 +98,108 @@ class AsyncSessionLogger:
             enable_compression: Enable gzip compression for JSON logs (overrides config)
             config: Configuration instance to use (creates new if not provided)
         """
-        # Load configuration from YAML file or use provided config
-        if config is None:
-            config = Config()
-        self.config = config
-
-        # Get response logging configuration section
-        response_config = self.config.get("response_logging", {})
-
-        # Apply configuration with parameter overrides
-        self.base_dir = Path(
-            base_dir
-            or response_config.get("session_directory", ".claude-mpm/responses")
-        )
+        # Use initialization flag to prevent duplicate setup
+        with self._initialization_lock:
+            if self._initialized and hasattr(self, "config"):
+                logger.debug("AsyncSessionLogger already initialized, skipping setup")
+                return
 
-        # Convert log format string to enum
-        format_str = response_config.get("format", "json").lower()
-        if log_format is not None:
-            self.log_format = log_format
-        elif format_str == "syslog":
-            self.log_format = LogFormat.SYSLOG
-        elif format_str == "journald":
-            self.log_format = LogFormat.JOURNALD
-        else:
-            self.log_format = LogFormat.JSON
+            # Load configuration from YAML file or use provided config
+            if config is None:
+                config = Config()
+            self.config = config
 
-        self.max_queue_size = (
-            max_queue_size
-            if max_queue_size is not None
-            else response_config.get("max_queue_size", SystemLimits.MAX_QUEUE_SIZE)
-        )
+            # Get response logging configuration section
+            response_config = self.config.get("response_logging", {})
 
-        # Handle async configuration with backward compatibility
-        if enable_async is not None:
-            self.enable_async = enable_async
-        else:
-            # Check configuration first, then environment variables for backward compatibility
-            self.enable_async = response_config.get("use_async", True)
-            # Override with environment variable if set (backward compatibility)
-            if os.environ.get("CLAUDE_USE_ASYNC_LOG"):
-                self.enable_async = (
-                    os.environ.get("CLAUDE_USE_ASYNC_LOG", "true").lower() == "true"
-                )
-
-        # Check debug sync mode (forces synchronous for debugging)
-        if (
-            response_config.get("debug_sync", False)
-            or os.environ.get("CLAUDE_LOG_SYNC", "").lower() == "true"
-        ):
-            logger.info("Debug sync mode enabled - forcing synchronous logging")
-            self.enable_async = False
-
-        self.enable_compression = (
-            enable_compression
-            if enable_compression is not None
-            else response_config.get("enable_compression", False)
-        )
+            # Apply configuration with parameter overrides
+            self.base_dir = Path(
+                base_dir
+                or response_config.get("session_directory", ".claude-mpm/responses")
+            )
 
-        # Create base directory
-        self.base_dir.mkdir(parents=True, exist_ok=True)
+            # Convert log format string to enum
+            format_str = response_config.get("format", "json").lower()
+            if log_format is not None:
+                self.log_format = log_format
+            elif format_str == "syslog":
+                self.log_format = LogFormat.SYSLOG
+            elif format_str == "journald":
+                self.log_format = LogFormat.JOURNALD
+            else:
+                self.log_format = LogFormat.JSON
 
-        # Session management
-        self.session_id = self._get_claude_session_id()
+            self.max_queue_size = (
+                max_queue_size
+                if max_queue_size is not None
+                else response_config.get("max_queue_size", SystemLimits.MAX_QUEUE_SIZE)
+            )
 
-        # Async infrastructure
-        self._queue: Queue = Queue(maxsize=self.max_queue_size)
-        self._worker_thread: Optional[Thread] = None
-        self._shutdown = False
-        self._lock = Lock()
+            # Handle async configuration with backward compatibility
+            if enable_async is not None:
+                self.enable_async = enable_async
+            else:
+                # Check configuration first, then environment variables for backward compatibility
+                self.enable_async = response_config.get("use_async", True)
+                # Override with environment variable if set (backward compatibility)
+                if os.environ.get("CLAUDE_USE_ASYNC_LOG"):
+                    self.enable_async = (
+                        os.environ.get("CLAUDE_USE_ASYNC_LOG", "true").lower() == "true"
+                    )
 
-        # Statistics
-        self.stats = {
-            "logged": 0,
-            "queued": 0,
-            "dropped": 0,
-            "errors": 0,
-            "avg_write_time_ms": 0.0,
-        }
+            # Check debug sync mode (forces synchronous for debugging)
+            if (
+                response_config.get("debug_sync", False)
+                or os.environ.get("CLAUDE_LOG_SYNC", "").lower() == "true"
+            ):
+                logger.info("Debug sync mode enabled - forcing synchronous logging")
+                self.enable_async = False
+
+            self.enable_compression = (
+                enable_compression
+                if enable_compression is not None
+                else response_config.get("enable_compression", False)
+            )
 
-        # Initialize format-specific handlers
-        self._init_format_handler()
+            # Create base directory
+            self.base_dir.mkdir(parents=True, exist_ok=True)
+
+            # Use centralized SessionManager for session ID
+            session_manager = get_session_manager()
+            self.session_id = session_manager.get_session_id()
+
+            # Async infrastructure
+            self._queue: Queue = Queue(maxsize=self.max_queue_size)
+            self._worker_thread: Optional[Thread] = None
+            self._shutdown = False
+            self._lock = Lock()
+
+            # Statistics
+            self.stats = {
+                "logged": 0,
+                "queued": 0,
+                "dropped": 0,
+                "errors": 0,
+                "avg_write_time_ms": 0.0,
+            }
+
+            # Initialize format-specific handlers
+            self._init_format_handler()
+
+            # Mark as initialized
+            self._initialized = True
+
+            # Log initialization status
+            logger.debug(
+                f"AsyncSessionLogger initialized with SessionManager: session_id={self.session_id}, async={self.enable_async}, format={self.log_format.value}"
+            )
 
-        # Start background worker if async enabled
-        if self.enable_async:
-            self._start_worker()
-
-    def _get_claude_session_id(self) -> str:
-        """Get or generate a Claude session ID."""
-        # Check environment variables in order of preference
-        for env_var in ["CLAUDE_SESSION_ID", "ANTHROPIC_SESSION_ID", "SESSION_ID"]:
-            session_id = os.environ.get(env_var)
-            if session_id:
-                logger.info(f"Using session ID from {env_var}: {session_id}")
-                return session_id
-
-        # Generate timestamp-based session ID
-        session_id = datetime.now().strftime("%Y%m%d_%H%M%S")
-        logger.info(f"Generated session ID: {session_id}")
-        return session_id
+        # Start background worker if async enabled (outside initialization lock)
+        if self.enable_async and not self._worker_started:
+            with self._initialization_lock:
+                if not self._worker_started:
+                    self._start_worker()
+                    self._worker_started = True
 
     def _init_format_handler(self):
         """Initialize format-specific logging handlers."""
@@ -323,7 +336,7 @@ class AsyncSessionLogger:
             with gzip.open(file_path, "wt", encoding="utf-8") as f:
                 json.dump(data, f, indent=2, ensure_ascii=False)
         else:
-            with open(file_path, "w", encoding="utf-8") as f:
+            with file_path.open("w", encoding="utf-8") as f:
                 json.dump(data, f, indent=2, ensure_ascii=False)
 
         logger.debug(f"Wrote log entry to {file_path}")
@@ -406,7 +419,7 @@ class AsyncSessionLogger:
             agent_name = metadata["agent"].replace(" ", "_").lower()
 
         # Create timestamp with microsecond precision
-        now = datetime.now()
+        now = datetime.now(timezone.utc)
         timestamp = now.isoformat()
         microseconds = now.microsecond
 
@@ -470,8 +483,19 @@ class AsyncSessionLogger:
         Args:
             timeout: Maximum time to wait for shutdown
         """
+        # Only log shutdown if we're actually shutting down an active logger
+        if self._shutdown:
+            logger.debug("AsyncSessionLogger already shut down")
+            return
+
         if self.enable_async:
-            logger.info("Shutting down async logger")
+            # Only log at INFO level if we actually processed something
+            if self.stats.get("logged", 0) > 0 or self.stats.get("queued", 0) > 0:
+                logger.info(
+                    f"Shutting down async logger (logged: {self.stats.get('logged', 0)}, queued: {self.stats.get('queued', 0)})"
+                )
+            else:
+                logger.debug("Shutting down async logger (no activity)")
 
             # Signal shutdown
             self._shutdown = True
@@ -483,8 +507,18 @@ class AsyncSessionLogger:
                 if self._worker_thread.is_alive():
                     logger.warning("Worker thread did not shutdown cleanly")
 
-            # Log final statistics
-            logger.info(f"Logger stats: {self.stats}")
+            # Log final statistics only if we actually logged something
+            if self.stats.get("logged", 0) > 0:
+                logger.info(f"AsyncSessionLogger final stats: {self.stats}")
+            elif self.stats.get("queued", 0) > 0 or self.stats.get("dropped", 0) > 0:
+                logger.debug(
+                    f"AsyncSessionLogger stats (incomplete session): {self.stats}"
+                )
+            else:
+                # Use debug level when nothing was logged
+                logger.debug(
+                    f"AsyncSessionLogger stats (no sessions logged): {self.stats}"
+                )
 
     def get_stats(self) -> Dict[str, Any]:
         """Get logger statistics."""
@@ -492,9 +526,18 @@ class AsyncSessionLogger:
             return self.stats.copy()
 
     def set_session_id(self, session_id: str):
-        """Set a new session ID."""
+        """Set a new session ID.
+
+        Note: This updates both the local session ID and the SessionManager.
+
+        Args:
+            session_id: The new session ID to use
+        """
         self.session_id = session_id
-        logger.info(f"Session ID updated to: {session_id}")
+        # Also update SessionManager to keep consistency
+        session_manager = get_session_manager()
+        session_manager.set_session_id(session_id)
+        logger.debug(f"Session ID updated to: {session_id}")
 
     def is_enabled(self) -> bool:
         """Check if logging is enabled."""

claude_mpm/services/claude_session_logger.py

@@ -10,33 +10,38 @@ Now with optional async logging support for improved performance.
 Configuration via .claude-mpm/configuration.yaml.
 """
 
+# Try to import async logger for performance optimization
+import importlib.util
 import json
-import logging
 import os
-from datetime import datetime
+from datetime import datetime, timezone
+from threading import Lock
 from typing import Any, Dict, Optional
 
 # Import configuration manager
 from claude_mpm.core.config import Config
 
-# Try to import async logger for performance optimization
-try:
-    from claude_mpm.services.async_session_logger import (
-        AsyncSessionLogger,
-        get_async_logger,
-        log_response_async,
-    )
+# Import centralized session manager
+from claude_mpm.services.session_manager import get_session_manager
+
+if importlib.util.find_spec("claude_mpm.services.async_session_logger"):
+    from claude_mpm.services.async_session_logger import get_async_logger
 
     ASYNC_AVAILABLE = True
-except ImportError:
+else:
     ASYNC_AVAILABLE = False
 
-logger = logging.getLogger(__name__)
+from claude_mpm.core.logging_utils import get_logger
+
+logger = get_logger(__name__)
 
 
 class ClaudeSessionLogger:
     """Simplified response logger for Claude Code sessions."""
 
+    _initialization_lock = Lock()
+    _initialized = False
+
     def __init__(
         self,
         base_dir: Optional[Path] = None,
@@ -51,29 +56,41 @@ class ClaudeSessionLogger:
             use_async: Use async logging if available. Overrides config.
             config: Configuration instance to use (creates new if not provided)
         """
-        # Load configuration
-        if config is None:
-            config = Config()
-        self.config = config
-
-        # Get response logging configuration
-        response_config = self.config.get("response_logging", {})
-
-        # Determine base directory
-        if base_dir is None:
-            # Check configuration first
-            base_dir = response_config.get("session_directory")
-            if not base_dir:
-                # Fall back to default response directory
-                base_dir = ".claude-mpm/responses"
-            base_dir = Path(base_dir)
-
-        self.base_dir = Path(base_dir)
-        self.base_dir.mkdir(parents=True, exist_ok=True)
+        # Use initialization flag to prevent duplicate setup
+        with self._initialization_lock:
+            if self._initialized and hasattr(self, "config"):
+                logger.debug("ClaudeSessionLogger already initialized, skipping setup")
+                return
+
+            # Load configuration
+            if config is None:
+                config = Config()
+            self.config = config
+
+            # Get response logging configuration
+            response_config = self.config.get("response_logging", {})
+
+            # Determine base directory
+            if base_dir is None:
+                # Check configuration first
+                base_dir = response_config.get("session_directory")
+                if not base_dir:
+                    # Fall back to default response directory
+                    base_dir = ".claude-mpm/responses"
+                base_dir = Path(base_dir)
+
+            self.base_dir = Path(base_dir)
+            self.base_dir.mkdir(parents=True, exist_ok=True)
+
+            # Use centralized SessionManager for session ID
+            session_manager = get_session_manager()
+            self.session_id = session_manager.get_session_id()
+            logger.debug(
+                f"ClaudeSessionLogger using session ID from SessionManager: {self.session_id}"
+            )
 
-        # Try to get session ID from environment
-        self.session_id = self._get_claude_session_id()
-        self.response_counter = {}  # Track response count per session
+            self.response_counter = {}  # Track response count per session
+            self._initialized = True
 
         # Determine if we should use async logging
         if use_async is None:
@@ -100,46 +117,22 @@ class ClaudeSessionLogger:
 
         if self.use_async:
             try:
+                # Pass our session_id to async logger to avoid duplicate generation
                 self._async_logger = get_async_logger(config=config)
-                logger.info("Using async logger for improved performance")
+                # Synchronize session IDs - use the one we already generated
+                if self.session_id and hasattr(self._async_logger, "set_session_id"):
+                    self._async_logger.set_session_id(self.session_id)
+                    logger.debug(
+                        f"Using async logger with session ID: {self.session_id}"
+                    )
+                else:
+                    logger.debug("Using async logger for improved performance")
             except Exception as e:
                 logger.warning(
                     f"Failed to initialize async logger, falling back to sync: {e}"
                 )
                 self.use_async = False
 
-    def _get_claude_session_id(self) -> Optional[str]:
-        """
-        Get the Claude Code session ID from environment.
-
-        Returns:
-            Session ID if available, None otherwise
-        """
-        # Claude Code may set various environment variables
-        # Check common patterns
-        session_id = None
-
-        # Check for CLAUDE_SESSION_ID
-        session_id = os.environ.get("CLAUDE_SESSION_ID")
-
-        # Check for ANTHROPIC_SESSION_ID
-        if not session_id:
-            session_id = os.environ.get("ANTHROPIC_SESSION_ID")
-
-        # Check for generic SESSION_ID
-        if not session_id:
-            session_id = os.environ.get("SESSION_ID")
-
-        # Generate a default based on timestamp if nothing found
-        if not session_id:
-            # Use a timestamp-based session ID as fallback
-            session_id = datetime.now().strftime("%Y%m%d_%H%M%S")
-            logger.info(f"No Claude session ID found, using generated: {session_id}")
-        else:
-            logger.info(f"Using Claude session ID: {session_id}")
-
-        return session_id
-
     def _generate_filename(self, agent: Optional[str] = None) -> str:
         """
         Generate a flat filename with session ID, agent, and timestamp.
@@ -156,7 +149,7 @@ class ClaudeSessionLogger:
         agent_name = agent_name.replace(" ", "_").lower()
 
         # Generate timestamp with microseconds for uniqueness
-        timestamp = datetime.now().strftime("%Y%m%d_%H%M%S_%f")
+        timestamp = datetime.now(timezone.utc).strftime("%Y%m%d_%H%M%S_%f")
 
         # Create filename: session_id-agent-timestamp.json
         return f"{self.session_id}-{agent_name}-{timestamp}.json"
@@ -216,7 +209,7 @@ class ClaudeSessionLogger:
 
         # Prepare response data with standardized field names
         response_data = {
-            "timestamp": datetime.now().isoformat(),
+            "timestamp": datetime.now(timezone.utc).isoformat(),
             "session_id": self.session_id,
             "request": request_summary,  # Standardized field name
             "response": response_content,  # Already correct
@@ -228,7 +221,7 @@ class ClaudeSessionLogger:
 
         # Save response
         try:
-            with open(file_path, "w", encoding="utf-8") as f:
+            with file_path.open("w", encoding="utf-8") as f:
                 json.dump(response_data, f, indent=2, ensure_ascii=False)
 
             logger.debug(f"Logged response to {filename} for session {self.session_id}")
@@ -242,10 +235,15 @@ class ClaudeSessionLogger:
         """
         Manually set the session ID.
 
+        Note: This updates both the local session ID and the SessionManager.
+
         Args:
             session_id: The session ID to use
         """
         self.session_id = session_id
+        # Also update SessionManager to keep consistency
+        session_manager = get_session_manager()
+        session_manager.set_session_id(session_id)
         logger.info(f"Session ID set to: {session_id}")
 
     def get_session_path(self) -> Optional[Path]:
@@ -271,13 +269,16 @@ class ClaudeSessionLogger:
         return self.session_id is not None
 
 
-# Singleton instance for easy access
+# Singleton instance with thread-safe initialization
 _logger_instance = None
+_logger_lock = Lock()
 
 
 def get_session_logger(config: Optional[Config] = None) -> ClaudeSessionLogger:
     """
-    Get the singleton session logger instance.
+    Get the singleton session logger instance with thread-safe initialization.
+
+    Uses double-checked locking pattern to ensure thread safety.
 
     Args:
         config: Optional configuration instance to use
@@ -286,9 +287,16 @@ def get_session_logger(config: Optional[Config] = None) -> ClaudeSessionLogger:
         The shared ClaudeSessionLogger instance
     """
     global _logger_instance
-    if _logger_instance is None:
-        _logger_instance = ClaudeSessionLogger(config=config)
-    return _logger_instance
+
+    # Fast path - check without lock
+    if _logger_instance is not None:
+        return _logger_instance
+
+    # Slow path - acquire lock and double-check
+    with _logger_lock:
+        if _logger_instance is None:
+            _logger_instance = ClaudeSessionLogger(config=config)
+        return _logger_instance
 
 
 def log_response(

claude_mpm/services/cli/agent_cleanup_service.py

@@ -138,6 +138,11 @@ class AgentCleanupService(IAgentCleanupService):
                 if not isinstance(result, dict):
                     result = {"success": bool(result)}
 
+                # Add success flag based on whether there were errors
+                if "success" not in result:
+                    # Consider it successful if no errors occurred
+                    result["success"] = not bool(result.get("errors"))
+
                 # Add cleaned_count for backward compatibility
                 if "cleaned_count" not in result:
                     removed_count = len(result.get("removed", []))

claude_mpm/services/cli/agent_listing_service.py

@@ -169,8 +169,8 @@ class AgentListingService(IAgentListingService):
 
                 base_service = AgentDeploymentService()
                 self._deployment_service = DeploymentServiceWrapper(base_service)
-            except ImportError:
-                raise ImportError("Agent deployment service not available")
+            except ImportError as e:
+                raise ImportError("Agent deployment service not available") from e
         return self._deployment_service
 
     @property
@@ -250,11 +250,11 @@ class AgentListingService(IAgentListingService):
                     type=agent_data.get("type", "agent"),
                     tier=agent_data.get("tier", "system"),
                     path=agent_data.get("path", ""),
-                    description=agent_data.get("description") if verbose else None,
+                    description=agent_data.get("description"),
                     specializations=(
                         agent_data.get("specializations") if verbose else None
                     ),
-                    version=agent_data.get("version") if verbose else None,
+                    version=agent_data.get("version"),
                     deployed=True,
                 )
                 agents.append(agent)
@@ -364,7 +364,7 @@ class AgentListingService(IAgentListingService):
             if not agent_path.exists():
                 return None
 
-            with open(agent_path) as f:
+            with agent_path.open() as f:
                 content = f.read()
 
             details = {

claude_mpm/services/cli/agent_validation_service.py

@@ -1,3 +1,5 @@
+import re
+
 """
 Agent Validation Service
 ========================
@@ -70,7 +72,7 @@ class AgentValidationService(IAgentValidationService):
                 self._registry = adapter.registry
             except Exception as e:
                 self.logger.error(f"Failed to initialize agent registry: {e}")
-                raise RuntimeError(f"Could not initialize agent registry: {e}")
+                raise RuntimeError(f"Could not initialize agent registry: {e}") from e
         return self._registry
 
     def validate_agent(self, agent_name: str) -> Dict[str, Any]: