claude-mpm 4.1.26__py3-none-any.whl → 4.24.0__py3-none-any.whl

claude_mpm/services/diagnostics/checks/common_issues_check.py

@@ -8,7 +8,8 @@ providing specific fixes for each issue.
 import json
 from pathlib import Path
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -33,7 +34,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             # Check for large .claude.json file
             claude_json_result = self._check_claude_json_size()
             if claude_json_result.has_issues:
-                if claude_json_result.status == DiagnosticStatus.ERROR:
+                if claude_json_result.status == ValidationSeverity.ERROR:
                     issues_found.append(claude_json_result)
                 else:
                     warnings_found.append(claude_json_result)
@@ -62,13 +63,13 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             total_issues = len(issues_found) + len(warnings_found)
 
             if issues_found:
-                status = DiagnosticStatus.ERROR
+                status = ValidationSeverity.ERROR
                 message = f"{len(issues_found)} critical issue(s), {len(warnings_found)} warning(s)"
             elif warnings_found:
-                status = DiagnosticStatus.WARNING
+                status = ValidationSeverity.WARNING
                 message = f"{len(warnings_found)} known issue(s) detected"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "No known issues detected"
 
             details = {
@@ -90,7 +91,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Common issues check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -102,7 +103,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         if not claude_json_path.exists():
             return DiagnosticResult(
                 category="Large .claude.json",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No .claude.json file",
                 details={"exists": False},
             )
@@ -114,7 +115,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             # Try to count conversations
             conversation_count = 0
             try:
-                with open(claude_json_path) as f:
+                with claude_json_path.open() as f:
                     data = json.load(f)
                     if isinstance(data, dict) and "conversations" in data:
                         conversation_count = len(data["conversations"])
@@ -131,7 +132,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             if size_mb > 10:  # Critical: >10MB
                 return DiagnosticResult(
                     category="Large .claude.json",
-                    status=DiagnosticStatus.ERROR,
+                    status=ValidationSeverity.ERROR,
                     message=f"Critical: .claude.json is {size_mb:.1f}MB (causes memory issues)",
                     details=details,
                     fix_command="claude-mpm cleanup-memory",
@@ -140,7 +141,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             if size_mb > 1:  # Warning: >1MB
                 return DiagnosticResult(
                     category="Large .claude.json",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f".claude.json is {size_mb:.1f}MB (may cause memory issues)",
                     details=details,
                     fix_command="claude-mpm cleanup-memory",
@@ -149,7 +150,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Large .claude.json",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f".claude.json size acceptable ({size_mb:.2f}MB)",
                 details=details,
             )
@@ -157,7 +158,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Large .claude.json",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check .claude.json: {e!s}",
                 details={"error": str(e)},
             )
@@ -170,7 +171,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         if not memory_dir.exists():
             return DiagnosticResult(
                 category="Memory Usage",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No project memory directory",
                 details={"exists": False, "path": str(memory_dir)},
             )
@@ -200,7 +201,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             if size_mb > 100:  # >100MB of memory files
                 return DiagnosticResult(
                     category="Memory Usage",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"High memory usage: {size_mb:.1f}MB in {len(memory_files)} files",
                     details=details,
                     fix_command="claude-mpm memory clean --days 30",
@@ -209,7 +210,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             if old_files:
                 return DiagnosticResult(
                     category="Memory Usage",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"{len(old_files)} memory file(s) older than 30 days",
                     details=details,
                     fix_command="claude-mpm memory clean --days 30",
@@ -218,7 +219,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Memory Usage",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"Memory usage normal ({size_mb:.1f}MB)",
                 details=details,
             )
@@ -226,7 +227,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Memory Usage",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check memory: {e!s}",
                 details={"error": str(e)},
             )
@@ -257,7 +258,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         if stale_locks:
             return DiagnosticResult(
                 category="Lock Files",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"{len(stale_locks)} stale lock file(s) found",
                 details={"stale_locks": stale_locks},
                 fix_command=f"rm {' '.join(stale_locks)}",
@@ -266,7 +267,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Lock Files",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="No stale lock files",
             details={"stale_locks": []},
         )
@@ -283,10 +284,10 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             try:
                 import yaml
 
-                with open(user_config) as f:
+                with user_config.open() as f:
                     user_data = yaml.safe_load(f) or {}
 
-                with open(project_config) as f:
+                with project_config.open() as f:
                     project_data = yaml.safe_load(f) or {}
 
                 # Check for conflicting keys
@@ -302,7 +303,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         if conflicts:
             return DiagnosticResult(
                 category="Config Conflicts",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"{len(conflicts)} configuration conflict(s)",
                 details={"conflicts": conflicts},
                 fix_description="Resolve conflicting configurations",
@@ -310,7 +311,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Config Conflicts",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="No configuration conflicts",
             details={"conflicts": []},
         )
@@ -322,7 +323,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         if not cache_dir.exists():
             return DiagnosticResult(
                 category="Cache",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No cache directory",
                 details={"exists": False},
             )
@@ -336,7 +337,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
             if size_mb > 500:  # >500MB cache
                 return DiagnosticResult(
                     category="Cache",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"Large cache: {size_mb:.1f}MB",
                     details={
                         "size_mb": round(size_mb, 2),
@@ -348,7 +349,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Cache",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"Cache size normal ({size_mb:.1f}MB)",
                 details={"size_mb": round(size_mb, 2), "file_count": len(cache_files)},
             )
@@ -356,7 +357,7 @@ class CommonIssuesCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Cache",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check cache: {e!s}",
                 details={"error": str(e)},
             )

claude_mpm/services/diagnostics/checks/configuration_check.py

@@ -11,7 +11,8 @@ from typing import Any, Dict
 
 import yaml
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -52,14 +53,14 @@ class ConfigurationCheck(BaseDiagnosticCheck):
             sub_results.append(perm_result)
 
             # Determine overall status
-            if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            if any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "Configuration has critical issues"
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "Configuration has minor issues"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "Configuration is valid"
 
             return DiagnosticResult(
@@ -73,7 +74,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Configuration check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -85,27 +86,27 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not config_path.exists():
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No user configuration (using defaults)",
                 details={"path": str(config_path), "exists": False},
             )
 
         try:
-            with open(config_path) as f:
+            with config_path.open() as f:
                 config = yaml.safe_load(f)
 
             issues = self._validate_config_structure(config)
             if issues:
                 return DiagnosticResult(
                     category="User Config",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"User config has issues: {', '.join(issues)}",
                     details={"path": str(config_path), "issues": issues},
                 )
 
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="User configuration valid",
                 details={
                     "path": str(config_path),
@@ -117,7 +118,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except yaml.YAMLError as e:
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message="User config has invalid YAML",
                 details={"path": str(config_path), "error": str(e)},
                 fix_description="Fix YAML syntax errors in the configuration file",
@@ -125,7 +126,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="User Config",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not read user config: {e!s}",
                 details={"path": str(config_path), "error": str(e)},
             )
@@ -137,20 +138,20 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not config_path.exists():
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No project configuration (using defaults)",
                 details={"path": str(config_path), "exists": False},
             )
 
         try:
-            with open(config_path) as f:
+            with config_path.open() as f:
                 config = yaml.safe_load(f)
 
             issues = self._validate_config_structure(config)
             if issues:
                 return DiagnosticResult(
                     category="Project Config",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"Project config has issues: {', '.join(issues)}",
                     details={"path": str(config_path), "issues": issues},
                 )
@@ -160,7 +161,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
             if deprecated:
                 return DiagnosticResult(
                     category="Project Config",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"Using deprecated config keys: {', '.join(deprecated)}",
                     details={"path": str(config_path), "deprecated_keys": deprecated},
                     fix_description="Remove deprecated configuration keys",
@@ -168,7 +169,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="Project configuration valid",
                 details={
                     "path": str(config_path),
@@ -180,7 +181,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except yaml.YAMLError as e:
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message="Project config has invalid YAML",
                 details={"path": str(config_path), "error": str(e)},
                 fix_description="Fix YAML syntax errors in the configuration file",
@@ -188,7 +189,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Project Config",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not read project config: {e!s}",
                 details={"path": str(config_path), "error": str(e)},
             )
@@ -207,14 +208,14 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not set_vars:
             return DiagnosticResult(
                 category="Environment Variables",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No claude-mpm environment variables set",
                 details={"variables": {}},
             )
 
         return DiagnosticResult(
             category="Environment Variables",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message=f"{len(set_vars)} environment variable(s) configured",
             details={"variables": set_vars},
         )
@@ -245,7 +246,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if not paths_checked:
             return DiagnosticResult(
                 category="Config Permissions",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message="No configuration files to check",
                 details={"paths_checked": []},
             )
@@ -253,7 +254,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="Config Permissions",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Permission issues: {', '.join(issues)}",
                 details={"issues": issues, "paths_checked": paths_checked},
                 fix_command="chmod 644 ~/.claude/claude-mpm.yaml",
@@ -262,7 +263,7 @@ class ConfigurationCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Config Permissions",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="Configuration file permissions are correct",
             details={"paths_checked": paths_checked},
         )

claude_mpm/services/diagnostics/checks/filesystem_check.py

@@ -9,7 +9,8 @@ import os
 import shutil
 from pathlib import Path
 
-from ..models import DiagnosticResult, DiagnosticStatus
+from ....core.enums import OperationResult, ValidationSeverity
+from ..models import DiagnosticResult
 from .base_check import BaseDiagnosticCheck
 
 
@@ -46,14 +47,14 @@ class FilesystemCheck(BaseDiagnosticCheck):
             details["structure"] = structure_result.details
 
             # Determine overall status
-            if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
-                status = DiagnosticStatus.ERROR
+            if any(r.status == ValidationSeverity.ERROR for r in sub_results):
+                status = ValidationSeverity.ERROR
                 message = "File system has critical issues"
-            elif any(r.status == DiagnosticStatus.WARNING for r in sub_results):
-                status = DiagnosticStatus.WARNING
+            elif any(r.status == ValidationSeverity.WARNING for r in sub_results):
+                status = ValidationSeverity.WARNING
                 message = "File system has minor issues"
             else:
-                status = DiagnosticStatus.OK
+                status = OperationResult.SUCCESS
                 message = "File system healthy"
 
             return DiagnosticResult(
@@ -67,7 +68,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"Filesystem check failed: {e!s}",
                 details={"error": str(e)},
             )
@@ -106,7 +107,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if issues:
             return DiagnosticResult(
                 category="Permissions",
-                status=DiagnosticStatus.ERROR,
+                status=ValidationSeverity.ERROR,
                 message=f"{len(issues)} permission issue(s)",
                 details={"issues": issues, "checked": checked},
                 fix_command="chmod -R 755 .claude",
@@ -116,14 +117,14 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if not checked:
             return DiagnosticResult(
                 category="Permissions",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="No project .claude directories found",
                 details={"checked": [], "missing": [str(d) for d in critical_dirs]},
             )
 
         return DiagnosticResult(
             category="Permissions",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="All permissions valid",
             details={"checked": checked},
         )
@@ -150,7 +151,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
             if free_gb < 0.1:  # Less than 100MB
                 return DiagnosticResult(
                     category="Disk Space",
-                    status=DiagnosticStatus.ERROR,
+                    status=ValidationSeverity.ERROR,
                     message=f"Critical: Only {free_gb:.2f}GB free",
                     details=details,
                     fix_description="Free up disk space immediately",
@@ -158,7 +159,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
             if free_gb < 1:  # Less than 1GB
                 return DiagnosticResult(
                     category="Disk Space",
-                    status=DiagnosticStatus.WARNING,
+                    status=ValidationSeverity.WARNING,
                     message=f"Low disk space: {free_gb:.2f}GB free",
                     details=details,
                     fix_description="Consider freeing up disk space",
@@ -166,7 +167,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
 
             return DiagnosticResult(
                 category="Disk Space",
-                status=DiagnosticStatus.OK,
+                status=OperationResult.SUCCESS,
                 message=f"{free_gb:.1f}GB available",
                 details=details,
             )
@@ -174,7 +175,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         except Exception as e:
             return DiagnosticResult(
                 category="Disk Space",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Could not check disk space: {e!s}",
                 details={"error": str(e)},
             )
@@ -196,7 +197,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if not base_dir.exists():
             return DiagnosticResult(
                 category="Directory Structure",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message="Project .claude directory missing",
                 details={"base_dir": str(base_dir), "exists": False},
                 fix_command="mkdir -p .claude/{agents,responses,memory,logs}",
@@ -213,7 +214,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
         if missing:
             return DiagnosticResult(
                 category="Directory Structure",
-                status=DiagnosticStatus.WARNING,
+                status=ValidationSeverity.WARNING,
                 message=f"Missing {len(missing)} subdirectory(s)",
                 details={
                     "base_dir": str(base_dir),
@@ -226,7 +227,7 @@ class FilesystemCheck(BaseDiagnosticCheck):
 
         return DiagnosticResult(
             category="Directory Structure",
-            status=DiagnosticStatus.OK,
+            status=OperationResult.SUCCESS,
             message="Directory structure complete",
             details={"base_dir": str(base_dir), "directories": present},
         )