claude-mpm 4.1.1__py3-none-any.whl → 4.1.2__py3-none-any.whl

claude_mpm/services/agents/deployment/agent_discovery_service.py

@@ -8,7 +8,6 @@ maintainability and testability.
 """
 
 import json
-import logging
 from pathlib import Path
 from typing import Any, Dict, List, Optional
 
@@ -140,9 +139,8 @@ class AgentDiscoveryService:
         if template_file.exists():
             if self._validate_template_file(template_file):
                 return template_file
-            else:
-                self.logger.error(f"Invalid template file: {template_file}")
-                return None
+            self.logger.error(f"Invalid template file: {template_file}")
+            return None
 
         self.logger.error(f"Template not found for agent: {agent_name}")
         return None
@@ -198,10 +196,8 @@ class AgentDiscoveryService:
                 "name": metadata.get("name", template_file.stem),
                 "description": metadata.get("description", "No description available"),
                 "version": template_data.get(
-                    "agent_version", 
-                    template_data.get("version", 
-                        metadata.get("version", "1.0.0")
-                    )
+                    "agent_version",
+                    template_data.get("version", metadata.get("version", "1.0.0")),
                 ),
                 "tools": capabilities.get("tools", []),
                 "specializations": metadata.get(

claude_mpm/services/agents/deployment/agent_environment_manager.py

@@ -7,7 +7,6 @@ Extracted from AgentDeploymentService as part of the refactoring to improve
 maintainability and testability.
 """
 
-import logging
 import os
 from pathlib import Path
 from typing import Any, Dict, Optional
@@ -236,7 +235,7 @@ cache/
         """
         current_env = self.get_current_environment()
 
-        info = {
+        return {
             "claude_environment_variables": current_env,
             "python_path": os.environ.get("PYTHONPATH", "Not set"),
             "current_working_directory": str(Path.cwd()),
@@ -244,8 +243,6 @@ cache/
             "claude_config_locations": self._find_claude_config_locations(),
         }
 
-        return info
-
     def cleanup_environment(self) -> Dict[str, Any]:
         """
         Clean up Claude environment variables.
@@ -257,9 +254,7 @@ cache/
 
         try:
             # Remove Claude-specific environment variables
-            claude_vars = [
-                key for key in os.environ.keys() if key.startswith("CLAUDE_")
-            ]
+            claude_vars = [key for key in os.environ if key.startswith("CLAUDE_")]
 
             for var in claude_vars:
                 if var in os.environ:

claude_mpm/services/agents/deployment/agent_filesystem_manager.py

@@ -7,10 +7,9 @@ Extracted from AgentDeploymentService as part of the refactoring to improve
 maintainability and testability.
 """
 
-import logging
 import shutil
 from pathlib import Path
-from typing import Any, Dict, List, Optional
+from typing import Any, Dict, Optional
 
 from claude_mpm.core.logging_config import get_logger
 
@@ -120,11 +119,10 @@ class AgentFileSystemManager:
                             # MD file is newer or same age, skip conversion
                             results["skipped"].append(yaml_file.name)
                             continue
-                        else:
-                            # MD file is older, proceed with conversion
-                            self.logger.info(
-                                f"MD file {md_file.name} is older than YAML, converting..."
-                            )
+                        # MD file is older, proceed with conversion
+                        self.logger.info(
+                            f"MD file {md_file.name} is older than YAML, converting..."
+                        )
 
                     # Read YAML content
                     yaml_content = yaml_file.read_text()
@@ -353,7 +351,7 @@ class AgentFileSystemManager:
             tools_list = '["Read", "Write", "Edit"]'
 
         # Build Markdown with YAML frontmatter
-        md_content = f"""---
+        return f"""---
 name: {name}
 description: "{description}"
 version: "{version}"
@@ -374,8 +372,6 @@ model: "sonnet"
 This agent provides specialized functionality for your tasks.
 """
 
-        return md_content
-
     def _extract_yaml_field(self, yaml_content: str, field_name: str) -> Optional[str]:
         """Extract a field value from YAML content."""
         import re

claude_mpm/services/agents/deployment/agent_format_converter.py

@@ -7,11 +7,10 @@ Extracted from AgentDeploymentService as part of the refactoring to improve
 maintainability and testability.
 """
 
-import logging
 import re
 from datetime import datetime
 from pathlib import Path
-from typing import Any, Dict, List, Optional
+from typing import Any, Dict, Optional
 
 from claude_mpm.core.logging_config import get_logger
 
@@ -67,11 +66,10 @@ class AgentFormatConverter:
                             # MD file is newer or same age, skip conversion
                             results["skipped"].append(yaml_file.name)
                             continue
-                        else:
-                            # MD file is older, proceed with conversion
-                            self.logger.info(
-                                f"MD file {md_file.name} is older than YAML, converting..."
-                            )
+                        # MD file is older, proceed with conversion
+                        self.logger.info(
+                            f"MD file {md_file.name} is older than YAML, converting..."
+                        )
 
                     # Read YAML content
                     yaml_content = yaml_file.read_text()
@@ -248,7 +246,7 @@ model: "{model}"
 
         # Add instructions field if there's markdown content
         if markdown_content:
-            frontmatter += f"\ninstructions: |\n"
+            frontmatter += "\ninstructions: |\n"
             # Indent markdown content
             for line in markdown_content.split("\n"):
                 frontmatter += f"  {line}\n"
@@ -269,13 +267,12 @@ model: "{model}"
 
         if content.startswith("---") and "---" in content[3:]:
             return "markdown_yaml"
-        elif content.startswith("{") and content.endswith("}"):
+        if content.startswith("{") and content.endswith("}"):
             return "json"
-        elif ":" in content and not content.startswith("#"):
+        if ":" in content and not content.startswith("#"):
             # Likely YAML if it has key-value pairs and doesn't start with markdown header
             return "yaml"
-        else:
-            return "unknown"
+        return "unknown"
 
     def normalize_agent_content(
         self, content: str, agent_name: str, target_format: str = "markdown_yaml"
@@ -307,10 +304,9 @@ model: "{model}"
         # Convert to target format
         if target_format == "yaml":
             return self.convert_md_to_yaml(intermediate)
-        elif target_format == "json":
+        if target_format == "json":
             return self._convert_md_to_json(intermediate)
-        else:
-            return intermediate
+        return intermediate
 
     def get_conversion_stats(self, target_dir: Path) -> Dict[str, Any]:
         """

claude_mpm/services/agents/deployment/agent_frontmatter_validator.py

@@ -4,6 +4,7 @@ This module provides validation and repair functionality for agent frontmatter.
 Extracted from AgentDeploymentService to reduce complexity and improve maintainability.
 """
 
+import contextlib
 import logging
 from pathlib import Path
 from typing import Any, Dict
@@ -139,10 +140,8 @@ class AgentFrontmatterValidator:
                         )
                         results["replaced"].append(agent_name)
                         # Delete the file so it will be recreated
-                        try:
+                        with contextlib.suppress(Exception):
                             agent_file.unlink()
-                        except Exception:
-                            pass
 
                 except Exception as e:
                     error_msg = f"Failed to validate agent {agent_file.name}: {e}"

claude_mpm/services/agents/deployment/agent_lifecycle_manager.py

@@ -29,13 +29,13 @@ Created for ISS-0118: Agent Registry and Hierarchical Discovery System
 import asyncio
 import time
 from dataclasses import dataclass, field
-from datetime import datetime, timedelta
+from datetime import datetime
 from enum import Enum
-from typing import Any, Dict, List, Optional, Set, Tuple, Union
+from typing import Any, Dict, List, Optional
 
 from claude_mpm.core.base_service import BaseService
 from claude_mpm.core.unified_paths import get_path_manager
-from claude_mpm.models.agent_definition import AgentDefinition, AgentType
+from claude_mpm.models.agent_definition import AgentDefinition
 from claude_mpm.services.agents.management import AgentManager
 from claude_mpm.services.agents.memory import (
     AgentPersistenceService,
@@ -43,7 +43,7 @@ from claude_mpm.services.agents.memory import (
     PersistenceRecord,
     PersistenceStrategy,
 )
-from claude_mpm.services.agents.registry import AgentMetadata, AgentRegistry
+from claude_mpm.services.agents.registry import AgentRegistry
 from claude_mpm.services.agents.registry.modification_tracker import (
     AgentModification,
     AgentModificationTracker,
@@ -841,7 +841,7 @@ class AgentLifecycleManager(BaseService):
             patterns = [
                 f"agent_profile:{agent_name}:*",
                 f"task_prompt:{agent_name}:*",
-                f"agent_registry_discovery",
+                "agent_registry_discovery",
                 f"agent_profile_enhanced:{agent_name}:*",
             ]
 

claude_mpm/services/agents/deployment/agent_metrics_collector.py

@@ -7,10 +7,8 @@ Extracted from AgentDeploymentService as part of the refactoring to improve
 maintainability and testability.
 """
 
-import logging
 import time
-from collections import defaultdict
-from typing import Any, Dict, List
+from typing import Any, Dict
 
 from claude_mpm.core.logging_config import get_logger
 
@@ -194,7 +192,7 @@ class AgentMetricsCollector:
         # Calculate additional performance metrics
         deployment_times = self._deployment_metrics["deployment_times"]
 
-        performance_summary = {
+        return {
             "total_deployments": metrics["total_deployments"],
             "success_rate": metrics["success_rate_percent"],
             "average_time_ms": metrics["average_deployment_time_ms"],
@@ -205,8 +203,6 @@ class AgentMetricsCollector:
             "error_rate_percent": self._calculate_error_rate(),
         }
 
-        return performance_summary
-
     def _categorize_error(self, error: str) -> str:
         """
         Categorize an error message into a type for tracking.
@@ -221,16 +217,15 @@ class AgentMetricsCollector:
 
         if "json" in error_lower or "parse" in error_lower:
             return "parsing_error"
-        elif "file" in error_lower or "path" in error_lower:
+        if "file" in error_lower or "path" in error_lower:
             return "file_error"
-        elif "version" in error_lower:
+        if "version" in error_lower:
             return "version_error"
-        elif "template" in error_lower:
+        if "template" in error_lower:
             return "template_error"
-        elif "validation" in error_lower:
+        if "validation" in error_lower:
             return "validation_error"
-        else:
-            return "other_error"
+        return "other_error"
 
     def _extract_agent_type(self, agent_name: str) -> str:
         """
@@ -247,18 +242,17 @@ class AgentMetricsCollector:
         # Common agent type patterns
         if "security" in name_lower:
             return "security"
-        elif "qa" in name_lower or "test" in name_lower:
+        if "qa" in name_lower or "test" in name_lower:
             return "qa"
-        elif "doc" in name_lower:
+        if "doc" in name_lower:
             return "documentation"
-        elif "data" in name_lower:
+        if "data" in name_lower:
             return "data"
-        elif "ops" in name_lower:
+        if "ops" in name_lower:
             return "operations"
-        elif "research" in name_lower:
+        if "research" in name_lower:
             return "research"
-        else:
-            return "general"
+        return "general"
 
     def _get_most_common_agent_type(self) -> str:
         """Get the most commonly deployed agent type."""

claude_mpm/services/agents/deployment/agent_restore_handler.py

@@ -12,7 +12,6 @@ from claude_mpm.core.path_ops import path_ops
 if TYPE_CHECKING:
     from .agent_lifecycle_manager import (
         AgentLifecycleManager,
-        LifecycleOperation,
         LifecycleOperationResult,
     )
 

claude_mpm/services/agents/deployment/agent_template_builder.py

@@ -8,7 +8,6 @@ maintainability and testability.
 """
 
 import json
-import logging
 from pathlib import Path
 from typing import Any, Dict, List
 
@@ -31,7 +30,11 @@ class AgentTemplateBuilder:
         self.logger = get_logger(__name__)
 
     def build_agent_markdown(
-        self, agent_name: str, template_path: Path, base_agent_data: dict, source_info: str = "unknown"
+        self,
+        agent_name: str,
+        template_path: Path,
+        base_agent_data: dict,
+        source_info: str = "unknown",
     ) -> str:
         """
         Build a complete agent markdown file with YAML frontmatter.
@@ -62,8 +65,10 @@ class AgentTemplateBuilder:
         # Extract tools from template with fallback
         # Handle both dict and list formats for capabilities (backward compatibility)
         capabilities = template_data.get("capabilities", {})
-        capabilities_tools = capabilities.get("tools") if isinstance(capabilities, dict) else None
-        
+        capabilities_tools = (
+            capabilities.get("tools") if isinstance(capabilities, dict) else None
+        )
+
         tools = (
             template_data.get("tools")
             or capabilities_tools
@@ -72,8 +77,10 @@ class AgentTemplateBuilder:
         )
 
         # Extract model from template with fallback
-        capabilities_model = capabilities.get("model") if isinstance(capabilities, dict) else None
-        
+        capabilities_model = (
+            capabilities.get("model") if isinstance(capabilities, dict) else None
+        )
+
         model = (
             template_data.get("model")
             or capabilities_model
@@ -82,10 +89,7 @@ class AgentTemplateBuilder:
         )
 
         # Convert tools list to comma-separated string (no spaces!)
-        if isinstance(tools, list):
-            tools_str = ",".join(tools)
-        else:
-            tools_str = str(tools)
+        tools_str = ",".join(tools) if isinstance(tools, list) else str(tools)
 
         # Validate tools format - CRITICAL: No spaces allowed!
         if ", " in tools_str:
@@ -110,7 +114,7 @@ class AgentTemplateBuilder:
             model = model_map[model]
 
         # Get response format from template or use base agent default
-        response_format = template_data.get("response", {}).get("format", "structured")
+        template_data.get("response", {}).get("format", "structured")
 
         # Create Claude Code compatible name (lowercase, hyphens only)
         claude_code_name = agent_name.lower().replace("_", "-")
@@ -137,7 +141,11 @@ class AgentTemplateBuilder:
 
         # Extract custom metadata fields
         metadata = template_data.get("metadata", {})
-        agent_version = template_data.get("agent_version") or template_data.get("version") or metadata.get("version", "1.0.0")
+        agent_version = (
+            template_data.get("agent_version")
+            or template_data.get("version")
+            or metadata.get("version", "1.0.0")
+        )
         agent_type = template_data.get("agent_type", "general")
         # Use the capabilities_model we already extracted earlier
         model_type = capabilities_model or "sonnet"
@@ -145,14 +153,14 @@ class AgentTemplateBuilder:
         # Map our model types to Claude Code format
         if model_type in ["opus", "sonnet", "haiku"]:
             # Use inherit for now - Claude Code seems to prefer this
-            claude_model = "inherit"
+            pass
         else:
-            claude_model = "inherit"
+            pass
 
         # Determine color - prefer template's color, fallback to type-based defaults
         template_metadata = template_data.get("metadata", {})
         template_color = template_metadata.get("color")
-        
+
         if template_color:
             # Use the color specified in the template
             color = template_color
@@ -170,21 +178,6 @@ class AgentTemplateBuilder:
 
         # Check if we should include tools field (only if significantly restricting)
         # Claude Code approach: omit tools field unless specifically restricting
-        all_available_tools = {
-            "Read",
-            "Write",
-            "Edit",
-            "MultiEdit",
-            "Bash",
-            "Grep",
-            "Glob",
-            "LS",
-            "WebSearch",
-            "WebFetch",
-            "TodoWrite",
-            "Task",
-            "Memory",
-        }
 
         # Convert tools to set for comparison
         agent_tools = set(tools) if isinstance(tools, list) else set(tools.split(","))
@@ -230,7 +223,7 @@ class AgentTemplateBuilder:
             or base_agent_data.get("instructions")
             or "# Agent Instructions\n\nThis agent provides specialized assistance."
         )
-        
+
         # Add memory update instructions if not already present
         if "memory-update" not in content and "Remember" not in content:
             memory_instructions = """
@@ -296,7 +289,7 @@ Only include memories that are:
             raise
 
         # Merge narrative and configuration fields
-        merged_narrative = self.merge_narrative_fields(base_agent_data, template_data)
+        self.merge_narrative_fields(base_agent_data, template_data)
         merged_config = self.merge_configuration_fields(base_agent_data, template_data)
 
         # Extract essential fields for Claude Code
@@ -313,15 +306,13 @@ Only include memories that are:
         tools_yaml = self.format_yaml_list(tools, 2)
 
         # Build YAML content with only essential fields
-        yaml_content = f"""name: {name}
+        return f"""name: {name}
 description: {description}
 model: {model}
 tools:
 {tools_yaml}
 """
 
-        return yaml_content
-
     def merge_narrative_fields(self, base_data: dict, template_data: dict) -> dict:
         """
         Merge narrative fields from base and template, combining arrays.

claude_mpm/services/agents/deployment/agent_validator.py

@@ -7,7 +7,6 @@ Extracted from AgentDeploymentService as part of the refactoring to improve
 maintainability and testability.
 """
 
-import logging
 import re
 from pathlib import Path
 from typing import Any, Dict, List, Optional, Tuple

claude_mpm/services/agents/deployment/agent_version_manager.py

@@ -7,10 +7,9 @@ Extracted from AgentDeploymentService as part of the refactoring to improve
 maintainability and testability.
 """
 
-import logging
 import re
 from pathlib import Path
-from typing import Any, Dict, Tuple
+from typing import Any, Tuple
 
 from claude_mpm.core.logging_config import get_logger
 
@@ -83,9 +82,8 @@ class AgentVersionManager:
         if isinstance(version_tuple, tuple) and len(version_tuple) == 3:
             major, minor, patch = version_tuple
             return f"{major}.{minor}.{patch}"
-        else:
-            # Fallback for legacy format
-            return str(version_tuple)
+        # Fallback for legacy format
+        return str(version_tuple)
 
     def is_old_version_format(self, version_str: str) -> bool:
         """
@@ -132,7 +130,7 @@ class AgentVersionManager:
         for a, b in zip(v1, v2):
             if a < b:
                 return -1
-            elif a > b:
+            if a > b:
                 return 1
         return 0
 
@@ -256,9 +254,9 @@ class AgentVersionManager:
             # Extract agent version from template
             metadata = template_data.get("metadata", {})
             current_agent_version = self.parse_version(
-                template_data.get("agent_version") or 
-                template_data.get("version") or
-                metadata.get("version", 0)
+                template_data.get("agent_version")
+                or template_data.get("version")
+                or metadata.get("version", 0)
             )
 
             # If old format detected, always trigger update for migration

claude_mpm/services/agents/deployment/agent_versioning.py

@@ -16,10 +16,10 @@ class AgentVersionManager:
 
         if change_type == "major":
             return f"{major + 1}.0.0"
-        elif change_type == "minor":
+        if change_type == "minor":
             return f"{major}.{minor + 1}.0"
-        else:  # patch
-            return f"{major}.{minor}.{patch + 1}"
+        # patch
+        return f"{major}.{minor}.{patch + 1}"
 
     def validate_version(self, version: str) -> bool:
         """Validate version format."""

claude_mpm/services/agents/deployment/agents_directory_resolver.py

@@ -27,10 +27,10 @@ class AgentsDirectoryResolver:
     def determine_agents_directory(self, target_dir: Optional[Path]) -> Path:
         """
         Determine the correct agents directory based on input.
-        
+
         MODIFIED: Always deploy to project .claude/agents directory
         regardless of agent source (system, user, or project).
-        
+
         This ensures all agents are deployed at the project level while
         maintaining discovery from both user (~/.claude-mpm) and project
         (.claude-mpm) directories.
@@ -53,12 +53,11 @@ class AgentsDirectoryResolver:
         if target_dir.name == "agents":
             # Already an agents directory, use as-is
             return target_dir
-        elif target_dir.name == ".claude-mpm":
+        if target_dir.name == ".claude-mpm":
             # .claude-mpm directory, add agents subdirectory
             return target_dir / "agents"
-        elif target_dir.name == ".claude":
+        if target_dir.name == ".claude":
             # .claude directory, add agents subdirectory
             return target_dir / "agents"
-        else:
-            # Assume it's a project directory, add .claude/agents
-            return target_dir / ".claude" / "agents"
+        # Assume it's a project directory, add .claude/agents
+        return target_dir / ".claude" / "agents"