claude-mpm 4.1.0__py3-none-any.whl → 4.1.2__py3-none-any.whl

claude_mpm/services/diagnostics/checks/mcp_check.py

@@ -8,7 +8,6 @@ and functioning for enhanced Claude Desktop capabilities.
 import json
 import subprocess
 from pathlib import Path
-from typing import Dict, Any
 
 from ..models import DiagnosticResult, DiagnosticStatus
 from .base_check import BaseDiagnosticCheck
@@ -16,43 +15,42 @@ from .base_check import BaseDiagnosticCheck
 
 class MCPCheck(BaseDiagnosticCheck):
     """Check MCP server installation and configuration."""
-    
+
     @property
     def name(self) -> str:
         return "mcp_check"
-    
+
     @property
     def category(self) -> str:
         return "MCP Server"
-    
+
     def run(self) -> DiagnosticResult:
         """Run MCP diagnostics."""
         try:
-            from ....services.mcp_gateway.core.startup_verification import MCPGatewayStartupVerifier
-            
+
             sub_results = []
             details = {}
-            
+
             # Check if MCP is installed
             install_result = self._check_installation()
             sub_results.append(install_result)
             details["installed"] = install_result.status == DiagnosticStatus.OK
-            
+
             if install_result.status == DiagnosticStatus.OK:
                 # Check MCP configuration
                 config_result = self._check_configuration()
                 sub_results.append(config_result)
                 details["configured"] = config_result.status == DiagnosticStatus.OK
-                
+
                 # Check MCP server status
                 status_result = self._check_server_status()
                 sub_results.append(status_result)
                 details["running"] = status_result.details.get("running", False)
-                
+
                 # Verify startup
                 startup_result = self._check_startup_verification()
                 sub_results.append(startup_result)
-            
+
             # Determine overall status
             if any(r.status == DiagnosticStatus.ERROR for r in sub_results):
                 status = DiagnosticStatus.ERROR
@@ -66,48 +64,49 @@ class MCPCheck(BaseDiagnosticCheck):
             else:
                 status = DiagnosticStatus.OK
                 message = "MCP server properly configured"
-            
+
             return DiagnosticResult(
                 category=self.category,
                 status=status,
                 message=message,
                 details=details,
-                sub_results=sub_results if self.verbose else []
+                sub_results=sub_results if self.verbose else [],
             )
-            
+
         except Exception as e:
             return DiagnosticResult(
                 category=self.category,
                 status=DiagnosticStatus.ERROR,
-                message=f"MCP check failed: {str(e)}",
-                details={"error": str(e)}
+                message=f"MCP check failed: {e!s}",
+                details={"error": str(e)},
             )
-    
+
     def _check_installation(self) -> DiagnosticResult:
         """Check if MCP server is installed."""
         # Check for MCP binary
         mcp_paths = [
             Path("/usr/local/bin/claude-mpm-mcp"),
             Path.home() / ".local/bin/claude-mpm-mcp",
-            Path("/opt/claude-mpm/bin/claude-mpm-mcp")
+            Path("/opt/claude-mpm/bin/claude-mpm-mcp"),
         ]
-        
+
         for mcp_path in mcp_paths:
             if mcp_path.exists():
                 return DiagnosticResult(
                     category="MCP Installation",
                     status=DiagnosticStatus.OK,
                     message="MCP server installed",
-                    details={"path": str(mcp_path), "installed": True}
+                    details={"path": str(mcp_path), "installed": True},
                 )
-        
+
         # Check if it's available via command
         try:
             result = subprocess.run(
                 ["which", "claude-mpm-mcp"],
                 capture_output=True,
                 text=True,
-                timeout=2
+                timeout=2,
+                check=False,
             )
             if result.returncode == 0:
                 path = result.stdout.strip()
@@ -115,34 +114,35 @@ class MCPCheck(BaseDiagnosticCheck):
                     category="MCP Installation",
                     status=DiagnosticStatus.OK,
                     message="MCP server installed",
-                    details={"path": path, "installed": True}
+                    details={"path": path, "installed": True},
                 )
         except (subprocess.SubprocessError, FileNotFoundError):
             pass
-        
+
         return DiagnosticResult(
             category="MCP Installation",
             status=DiagnosticStatus.WARNING,
             message="MCP server not installed",
             details={"installed": False},
             fix_command="claude-mpm mcp install",
-            fix_description="Install MCP server for enhanced capabilities"
+            fix_description="Install MCP server for enhanced capabilities",
         )
-    
+
     def _check_configuration(self) -> DiagnosticResult:
         """Check MCP configuration in Claude Desktop."""
         config_paths = [
             Path.home() / ".config/claude/claude_desktop_config.json",
-            Path.home() / "Library/Application Support/Claude/claude_desktop_config.json",
-            Path.home() / "AppData/Roaming/Claude/claude_desktop_config.json"
+            Path.home()
+            / "Library/Application Support/Claude/claude_desktop_config.json",
+            Path.home() / "AppData/Roaming/Claude/claude_desktop_config.json",
         ]
-        
+
         config_path = None
         for path in config_paths:
             if path.exists():
                 config_path = path
                 break
-        
+
         if not config_path:
             return DiagnosticResult(
                 category="MCP Configuration",
@@ -150,16 +150,16 @@ class MCPCheck(BaseDiagnosticCheck):
                 message="Claude Desktop config not found",
                 details={"configured": False},
                 fix_command="claude-mpm mcp config",
-                fix_description="Configure MCP server in Claude Desktop"
+                fix_description="Configure MCP server in Claude Desktop",
             )
-        
+
         try:
-            with open(config_path, 'r') as f:
+            with open(config_path) as f:
                 config = json.load(f)
-                
+
                 mcp_servers = config.get("mcpServers", {})
                 gateway = mcp_servers.get("claude-mpm-gateway", {})
-                
+
                 if not gateway:
                     return DiagnosticResult(
                         category="MCP Configuration",
@@ -167,9 +167,9 @@ class MCPCheck(BaseDiagnosticCheck):
                         message="MCP gateway not configured",
                         details={"configured": False, "config_path": str(config_path)},
                         fix_command="claude-mpm mcp config",
-                        fix_description="Add MCP gateway to Claude Desktop configuration"
+                        fix_description="Add MCP gateway to Claude Desktop configuration",
                     )
-                
+
                 # Check configuration validity
                 command = gateway.get("command")
                 if not command:
@@ -180,12 +180,12 @@ class MCPCheck(BaseDiagnosticCheck):
                         details={
                             "configured": True,
                             "valid": False,
-                            "config_path": str(config_path)
+                            "config_path": str(config_path),
                         },
                         fix_command="claude-mpm mcp config --force",
-                        fix_description="Fix MCP gateway configuration"
+                        fix_description="Fix MCP gateway configuration",
                     )
-                
+
                 return DiagnosticResult(
                     category="MCP Configuration",
                     status=DiagnosticStatus.OK,
@@ -193,26 +193,26 @@ class MCPCheck(BaseDiagnosticCheck):
                     details={
                         "configured": True,
                         "command": command,
-                        "config_path": str(config_path)
-                    }
+                        "config_path": str(config_path),
+                    },
                 )
-                
+
         except json.JSONDecodeError as e:
             return DiagnosticResult(
                 category="MCP Configuration",
                 status=DiagnosticStatus.ERROR,
                 message="Invalid JSON in config file",
                 details={"error": str(e), "config_path": str(config_path)},
-                fix_description="Fix JSON syntax in Claude Desktop config"
+                fix_description="Fix JSON syntax in Claude Desktop config",
             )
         except Exception as e:
             return DiagnosticResult(
                 category="MCP Configuration",
                 status=DiagnosticStatus.WARNING,
-                message=f"Could not check configuration: {str(e)}",
-                details={"error": str(e)}
+                message=f"Could not check configuration: {e!s}",
+                details={"error": str(e)},
             )
-    
+
     def _check_server_status(self) -> DiagnosticResult:
         """Check if MCP server is running."""
         try:
@@ -221,95 +221,97 @@ class MCPCheck(BaseDiagnosticCheck):
                 ["claude-mpm", "mcp", "status"],
                 capture_output=True,
                 text=True,
-                timeout=5
+                timeout=5,
+                check=False,
             )
-            
+
             if result.returncode == 0:
                 if "running" in result.stdout.lower():
                     return DiagnosticResult(
                         category="MCP Server Status",
                         status=DiagnosticStatus.OK,
                         message="MCP server is running",
-                        details={"running": True}
+                        details={"running": True},
                     )
-                else:
-                    return DiagnosticResult(
-                        category="MCP Server Status",
-                        status=DiagnosticStatus.WARNING,
-                        message="MCP server not running",
-                        details={"running": False},
-                        fix_command="claude-mpm mcp start",
-                        fix_description="Start the MCP server"
-                    )
-            else:
                 return DiagnosticResult(
                     category="MCP Server Status",
                     status=DiagnosticStatus.WARNING,
-                    message="Could not determine server status",
-                    details={"running": "unknown", "error": result.stderr}
+                    message="MCP server not running",
+                    details={"running": False},
+                    fix_command="claude-mpm mcp start",
+                    fix_description="Start the MCP server",
                 )
-                
+            return DiagnosticResult(
+                category="MCP Server Status",
+                status=DiagnosticStatus.WARNING,
+                message="Could not determine server status",
+                details={"running": "unknown", "error": result.stderr},
+            )
+
         except subprocess.TimeoutExpired:
             return DiagnosticResult(
                 category="MCP Server Status",
                 status=DiagnosticStatus.WARNING,
                 message="Server status check timed out",
-                details={"running": "unknown", "error": "timeout"}
+                details={"running": "unknown", "error": "timeout"},
             )
         except Exception as e:
             return DiagnosticResult(
                 category="MCP Server Status",
                 status=DiagnosticStatus.WARNING,
-                message=f"Could not check server status: {str(e)}",
-                details={"running": "unknown", "error": str(e)}
+                message=f"Could not check server status: {e!s}",
+                details={"running": "unknown", "error": str(e)},
             )
-    
+
     def _check_startup_verification(self) -> DiagnosticResult:
         """Run MCP startup verification."""
         try:
-            from ....services.mcp_gateway.core.startup_verification import MCPGatewayStartupVerifier
-            
+            from ....services.mcp_gateway.core.startup_verification import (
+                MCPGatewayStartupVerifier,
+            )
+
             verifier = MCPGatewayStartupVerifier()
             issues = verifier.verify_startup()
-            
+
             if not issues:
                 return DiagnosticResult(
                     category="MCP Startup Verification",
                     status=DiagnosticStatus.OK,
                     message="Startup verification passed",
-                    details={"issues": []}
+                    details={"issues": []},
                 )
-            
+
             # Categorize issues by severity
-            errors = [i for i in issues if "error" in i.lower() or "critical" in i.lower()]
+            errors = [
+                i for i in issues if "error" in i.lower() or "critical" in i.lower()
+            ]
             warnings = [i for i in issues if i not in errors]
-            
+
             if errors:
                 return DiagnosticResult(
                     category="MCP Startup Verification",
                     status=DiagnosticStatus.ERROR,
                     message=f"{len(errors)} critical issue(s) found",
-                    details={"errors": errors, "warnings": warnings}
+                    details={"errors": errors, "warnings": warnings},
                 )
-            elif warnings:
+            if warnings:
                 return DiagnosticResult(
                     category="MCP Startup Verification",
                     status=DiagnosticStatus.WARNING,
                     message=f"{len(warnings)} warning(s) found",
-                    details={"warnings": warnings}
+                    details={"warnings": warnings},
                 )
-            else:
-                return DiagnosticResult(
-                    category="MCP Startup Verification",
-                    status=DiagnosticStatus.OK,
-                    message="Startup verification passed",
-                    details={"issues": []}
-                )
-                
+            return DiagnosticResult(
+                category="MCP Startup Verification",
+                status=DiagnosticStatus.OK,
+                message="Startup verification passed",
+                details={"issues": []},
+            )
+
         except Exception as e:
             return DiagnosticResult(
                 category="MCP Startup Verification",
                 status=DiagnosticStatus.WARNING,
-                message=f"Could not verify startup: {str(e)}",
-                details={"error": str(e)}
-            )
+                message=f"Could not verify startup: {e!s}",
+                details={"error": str(e)},
+            )