claude-mpm 4.0.23__py3-none-any.whl → 4.0.25__py3-none-any.whl

claude_mpm/cli/commands/config.py

@@ -1,5 +1,3 @@
-from pathlib import Path
-
 """
 Configuration management commands for claude-mpm CLI.
 
@@ -8,13 +6,15 @@ the command line. This module provides commands for configuration validation,
 viewing, and troubleshooting.
 
 DESIGN DECISIONS:
-- Integrate with existing CLI structure
-- Provide clear, actionable output
-- Support both validation and viewing operations
-- Use consistent error codes for CI/CD integration
+- Use BaseCommand for consistent CLI patterns
+- Leverage shared utilities for argument parsing and output formatting
+- Provide clear, actionable output with standardized error handling
+- Support multiple output formats (json, yaml, table, text)
 """
 
 import json
+from pathlib import Path
+from typing import Dict, Any
 
 import yaml
 from rich.panel import Panel
@@ -22,273 +22,407 @@ from rich.syntax import Syntax
 from rich.table import Table
 
 from ...core.config import Config
-from ...core.logger import get_logger
 from ...utils.console import console
+from ..shared import BaseCommand, CommandResult, add_config_arguments, add_output_arguments
 
-logger = get_logger(__name__)
-
-
-def manage_config(args) -> int:
-    """Main entry point for configuration management commands.
-
-    WHY: This dispatcher handles different configuration subcommands,
-    routing to the appropriate handler based on user input.
-
-    Args:
-        args: Parsed command line arguments
 
-    Returns:
-        Exit code (0 for success, non-zero for failure)
-    """
-    if args.config_command == "validate":
-        return validate_config(args)
-    elif args.config_command == "view":
-        return view_config(args)
-    elif args.config_command == "status":
-        return show_config_status(args)
-    else:
-        console.print(f"[red]Unknown config command: {args.config_command}[/red]")
-        return 1
+class ConfigCommand(BaseCommand):
+    """Configuration management command using shared utilities."""
 
+    def __init__(self):
+        super().__init__("config")
 
-def validate_config(args) -> int:
-    """Validate configuration file.
+    def validate_args(self, args) -> str:
+        """Validate command arguments."""
+        if not hasattr(args, 'config_command') or not args.config_command:
+            return "No config command specified"
 
-    WHY: Users need immediate feedback on configuration validity with
-    clear guidance on how to fix any issues found.
-
-    Args:
-        args: Command line arguments including config file path
-
-    Returns:
-        Exit code (0=valid, 1=errors, 2=warnings in strict mode)
-    """
-    config_file = args.config_file or Path(".claude-mpm/configuration.yaml")
+        valid_commands = ["validate", "view", "status"]
+        if args.config_command not in valid_commands:
+            return f"Unknown config command: {args.config_command}. Valid commands: {', '.join(valid_commands)}"
 
-    console.print(f"\n[bold blue]Validating configuration: {config_file}[/bold blue]\n")
+        return None
 
-    # Check if file exists
-    if not config_file.exists():
-        console.print(f"[red]✗ Configuration file not found: {config_file}[/red]")
-        console.print(
-            f"[yellow]→ Create with: mkdir -p {config_file.parent} && touch {config_file}[/yellow]"
-        )
-        return 1
-
-    try:
-        # Try to load configuration
-        config = Config(config_file=config_file)
-
-        # Validate configuration
-        is_valid, errors, warnings = config.validate_configuration()
-
-        # Display results
-        if errors:
-            console.print("[bold red]ERRORS:[/bold red]")
-            for error in errors:
-                console.print(f"  [red]✗ {error}[/red]")
-
-        if warnings:
-            console.print("\n[bold yellow]WARNINGS:[/bold yellow]")
-            for warning in warnings:
-                console.print(f"  [yellow]⚠ {warning}[/yellow]")
-
-        # Show summary
-        if is_valid and not warnings:
-            console.print("\n[green]✓ Configuration is valid[/green]")
-            return 0
-        elif is_valid and warnings:
-            console.print(
-                f"\n[green]✓ Configuration is valid with {len(warnings)} warning(s)[/green]"
-            )
-            return 2 if args.strict else 0
+    def run(self, args) -> CommandResult:
+        """Execute the configuration command."""
+        if args.config_command == "validate":
+            return self._validate_config(args)
+        elif args.config_command == "view":
+            return self._view_config(args)
+        elif args.config_command == "status":
+            return self._show_config_status(args)
         else:
-            console.print(
-                f"\n[red]✗ Configuration validation failed with {len(errors)} error(s)[/red]"
-            )
-            console.print(
-                "\n[yellow]Run 'python scripts/validate_configuration.py' for detailed analysis[/yellow]"
-            )
-            return 1
+            return CommandResult.error_result(f"Unknown config command: {args.config_command}")
 
-    except Exception as e:
-        console.print(f"[red]Failed to validate configuration: {e}[/red]")
-        logger.exception("Configuration validation error")
-        return 1
+    def _validate_config(self, args) -> CommandResult:
+        """Validate configuration file."""
+        config_file = getattr(args, 'config_file', None) or Path(".claude-mpm/configuration.yaml")
 
+        # Check if file exists
+        if not config_file.exists():
+            error_msg = f"Configuration file not found: {config_file}"
+            suggestion = f"Create with: mkdir -p {config_file.parent} && touch {config_file}"
 
-def view_config(args) -> int:
-    """View current configuration.
+            if getattr(args, 'format', 'text') in ['json', 'yaml']:
+                return CommandResult.error_result(
+                    error_msg,
+                    data={"suggestion": suggestion, "config_file": str(config_file)}
+                )
+            else:
+                console.print(f"[red]✗ {error_msg}[/red]")
+                console.print(f"[yellow]→ {suggestion}[/yellow]")
+                return CommandResult.error_result(error_msg)
+
+        try:
+            # Load and validate configuration
+            if config_file != Path(".claude-mpm/configuration.yaml"):
+                # Use specific config file
+                config = Config(config_file=config_file)
+            else:
+                # Use default config
+                config = self.config
+            is_valid, errors, warnings = config.validate_configuration()
+
+            # Prepare result data
+            result_data = {
+                "config_file": str(config_file),
+                "valid": is_valid,
+                "errors": errors,
+                "warnings": warnings,
+                "error_count": len(errors),
+                "warning_count": len(warnings)
+            }
+
+            # Handle output format
+            output_format = getattr(args, 'format', 'text')
+            if output_format in ['json', 'yaml']:
+                if is_valid and not warnings:
+                    return CommandResult.success_result("Configuration is valid", data=result_data)
+                elif is_valid and warnings:
+                    message = f"Configuration is valid with {len(warnings)} warning(s)"
+                    exit_code = 2 if getattr(args, 'strict', False) else 0
+                    return CommandResult(success=True, exit_code=exit_code, message=message, data=result_data)
+                else:
+                    return CommandResult.error_result(
+                        f"Configuration validation failed with {len(errors)} error(s)",
+                        data=result_data
+                    )
+            else:
+                # Rich console output for text format
+                console.print(f"\n[bold blue]Validating configuration: {config_file}[/bold blue]\n")
+
+                if errors:
+                    console.print("[bold red]ERRORS:[/bold red]")
+                    for error in errors:
+                        console.print(f"  [red]✗ {error}[/red]")
+
+                if warnings:
+                    console.print("\n[bold yellow]WARNINGS:[/bold yellow]")
+                    for warning in warnings:
+                        console.print(f"  [yellow]⚠ {warning}[/yellow]")
+
+                # Show summary
+                if is_valid and not warnings:
+                    console.print("\n[green]✓ Configuration is valid[/green]")
+                    return CommandResult.success_result("Configuration is valid")
+                elif is_valid and warnings:
+                    console.print(f"\n[green]✓ Configuration is valid with {len(warnings)} warning(s)[/green]")
+                    exit_code = 2 if getattr(args, 'strict', False) else 0
+                    return CommandResult(success=True, exit_code=exit_code, message="Configuration valid with warnings")
+                else:
+                    console.print(f"\n[red]✗ Configuration validation failed with {len(errors)} error(s)[/red]")
+                    console.print("\n[yellow]Run 'python scripts/validate_configuration.py' for detailed analysis[/yellow]")
+                    return CommandResult.error_result("Configuration validation failed")
+
+        except Exception as e:
+            self.logger.error(f"Configuration validation error: {e}", exc_info=True)
+
+            if getattr(args, 'format', 'text') in ['json', 'yaml']:
+                return CommandResult.error_result(
+                    f"Failed to validate configuration: {e}",
+                    data={"config_file": str(config_file), "exception": str(e)}
+                )
+            else:
+                console.print(f"[red]Failed to validate configuration: {e}[/red]")
+                return CommandResult.error_result(f"Failed to validate configuration: {e}")
+
+    def _view_config(self, args) -> CommandResult:
+        """View current configuration."""
+        try:
+            # Load configuration
+            config_file = getattr(args, 'config_file', None)
+            config = Config(config_file=config_file)
+
+            # Get configuration as dictionary
+            config_dict = config.to_dict()
+
+            # Filter by section if specified
+            section = getattr(args, 'section', None)
+            if section:
+                if section in config_dict:
+                    config_dict = {section: config_dict[section]}
+                else:
+                    error_msg = f"Section '{section}' not found in configuration"
+                    available_sections = list(config_dict.keys())
+
+                    if getattr(args, 'format', 'text') in ['json', 'yaml']:
+                        return CommandResult.error_result(
+                            error_msg,
+                            data={"available_sections": available_sections}
+                        )
+                    else:
+                        console.print(f"[red]{error_msg}[/red]")
+                        console.print(f"[yellow]Available sections: {', '.join(available_sections)}[/yellow]")
+                        return CommandResult.error_result(error_msg)
+
+            # Handle output format
+            output_format = getattr(args, 'format', 'text')
+
+            if output_format == "json":
+                if hasattr(args, 'output') and args.output:
+                    # Use shared output handling
+                    return CommandResult.success_result("Configuration retrieved", data=config_dict)
+                else:
+                    # Direct console output with syntax highlighting
+                    output = json.dumps(config_dict, indent=2)
+                    syntax = Syntax(output, "json", theme="monokai", line_numbers=False)
+                    console.print(syntax)
+                    return CommandResult.success_result("Configuration displayed", data=config_dict)
+
+            elif output_format == "yaml":
+                if hasattr(args, 'output') and args.output:
+                    # Use shared output handling
+                    return CommandResult.success_result("Configuration retrieved", data=config_dict)
+                else:
+                    # Direct console output with syntax highlighting
+                    output = yaml.dump(config_dict, default_flow_style=False, sort_keys=False)
+                    syntax = Syntax(output, "yaml", theme="monokai", line_numbers=False)
+                    console.print(syntax)
+                    return CommandResult.success_result("Configuration displayed")
+
+            elif output_format == "table":
+                self._display_config_table(config_dict)
+                return CommandResult.success_result("Configuration displayed")
+
+            else:  # text format
+                self._display_config_table(config_dict)
+                return CommandResult.success_result("Configuration displayed")
+
+        except Exception as e:
+            self.logger.error(f"Configuration view error: {e}", exc_info=True)
+
+            if getattr(args, 'format', 'text') in ['json', 'yaml']:
+                return CommandResult.error_result(
+                    f"Failed to view configuration: {e}",
+                    data={"exception": str(e)}
+                )
+            else:
+                console.print(f"[red]Failed to view configuration: {e}[/red]")
+                return CommandResult.error_result(f"Failed to view configuration: {e}")
 
-    WHY: Users need to see their effective configuration including
-    defaults and environment variable overrides.
+    def _show_config_status(self, args) -> CommandResult:
+        """Show configuration status and health."""
+        try:
+            # Load configuration
+            config_file = getattr(args, 'config_file', None)
+            config = Config(config_file=config_file)
 
-    Args:
-        args: Command line arguments
+            # Get status
+            status = config.get_configuration_status()
 
-    Returns:
-        Exit code (0 for success)
-    """
-    try:
-        # Load configuration
-        config_file = args.config_file
-        config = Config(config_file=config_file)
-
-        # Get configuration as dictionary
-        config_dict = config.to_dict()
-
-        # Filter by section if specified
-        if args.section:
-            if args.section in config_dict:
-                config_dict = {args.section: config_dict[args.section]}
-            else:
-                console.print(
-                    f"[red]Section '{args.section}' not found in configuration[/red]"
-                )
-                return 1
+            # Handle output format
+            output_format = getattr(args, 'format', 'text')
 
-        # Format output
-        if args.format == "json":
-            output = json.dumps(config_dict, indent=2)
-            syntax = Syntax(output, "json", theme="monokai", line_numbers=False)
-            console.print(syntax)
-        elif args.format == "yaml":
-            output = yaml.dump(config_dict, default_flow_style=False, sort_keys=False)
-            syntax = Syntax(output, "yaml", theme="monokai", line_numbers=False)
-            console.print(syntax)
-        else:  # table format
-            display_config_table(config_dict)
+            if output_format in ['json', 'yaml']:
+                # Structured output
+                result_data = status.copy()
 
-        return 0
+                # Add response logging details if requested
+                if getattr(args, 'check_response_logging', False):
+                    result_data['response_logging_config'] = config.get("response_logging", {})
 
-    except Exception as e:
-        console.print(f"[red]Failed to view configuration: {e}[/red]")
-        logger.exception("Configuration view error")
-        return 1
+                if status["valid"]:
+                    return CommandResult.success_result("Configuration status retrieved", data=result_data)
+                else:
+                    return CommandResult.error_result("Configuration has issues", data=result_data)
 
+            else:
+                # Rich console output for text format
+                self._display_status_panel(status)
 
-def show_config_status(args) -> int:
-    """Show configuration status and health.
+                # Show detailed errors/warnings if verbose
+                if getattr(args, 'verbose', False):
+                    self._display_detailed_status(status)
 
-    WHY: Users need a quick way to check if their configuration is
-    working correctly, especially for response logging.
+                # Check response logging specifically
+                if getattr(args, 'check_response_logging', False):
+                    self._display_response_logging_config(config)
 
-    Args:
-        args: Command line arguments
+                return CommandResult.success_result("Configuration status displayed") if status["valid"] else CommandResult.error_result("Configuration has issues")
 
-    Returns:
-        Exit code (0 for success)
-    """
-    try:
-        # Load configuration
-        config = Config(config_file=args.config_file)
+        except Exception as e:
+            self.logger.error(f"Configuration status error: {e}", exc_info=True)
 
-        # Get status
-        status = config.get_configuration_status()
+            if getattr(args, 'format', 'text') in ['json', 'yaml']:
+                return CommandResult.error_result(
+                    f"Failed to get configuration status: {e}",
+                    data={"exception": str(e)}
+                )
+            else:
+                console.print(f"[red]Failed to get configuration status: {e}[/red]")
+                return CommandResult.error_result(f"Failed to get configuration status: {e}")
 
-        # Create status panel
+    def _display_status_panel(self, status: Dict[str, Any]) -> None:
+        """Display configuration status panel."""
         panel_content = []
 
         # Basic info
         panel_content.append(f"[bold]Configuration Status[/bold]")
-        panel_content.append(f"Valid: {'✓' if status['valid'] else '✗'}")
+        panel_content.append(f"Valid: {'✓' if status.get('valid', False) else '✗'}")
         panel_content.append(f"Loaded from: {status.get('loaded_from', 'defaults')}")
-        panel_content.append(f"Total keys: {status['key_count']}")
-
-        # Feature status
-        panel_content.append("\n[bold]Features:[/bold]")
-        panel_content.append(
-            f"Response Logging: {'✓ Enabled' if status['response_logging_enabled'] else '✗ Disabled'}"
-        )
-        panel_content.append(
-            f"Memory System: {'✓ Enabled' if status['memory_enabled'] else '✗ Disabled'}"
-        )
+        panel_content.append(f"Total keys: {status.get('key_count', 'unknown')}")
+
+        # Feature status (only if available)
+        if 'response_logging_enabled' in status or 'memory_enabled' in status:
+            panel_content.append("\n[bold]Features:[/bold]")
+            if 'response_logging_enabled' in status:
+                panel_content.append(
+                    f"Response Logging: {'✓ Enabled' if status['response_logging_enabled'] else '✗ Disabled'}"
+                )
+            if 'memory_enabled' in status:
+                panel_content.append(
+                    f"Memory System: {'✓ Enabled' if status['memory_enabled'] else '✗ Disabled'}"
+                )
 
-        # Errors and warnings
-        if status["errors"]:
+        # Errors and warnings (only if available)
+        if status.get("errors"):
             panel_content.append(f"\n[red]Errors: {len(status['errors'])}[/red]")
-        if status["warnings"]:
-            panel_content.append(
-                f"\n[yellow]Warnings: {len(status['warnings'])}[/yellow]"
-            )
+        if status.get("warnings"):
+            panel_content.append(f"\n[yellow]Warnings: {len(status['warnings'])}[/yellow]")
 
         # Display panel
         panel = Panel(
             "\n".join(panel_content),
             title="Configuration Status",
-            border_style="green" if status["valid"] else "red",
+            border_style="green" if status.get("valid", False) else "red",
         )
         console.print(panel)
 
-        # Show detailed errors/warnings if verbose
-        if args.verbose:
-            if status["errors"]:
-                console.print("\n[bold red]Errors:[/bold red]")
-                for error in status["errors"]:
-                    console.print(f"  [red]• {error}[/red]")
+    def _display_detailed_status(self, status: Dict[str, Any]) -> None:
+        """Display detailed errors and warnings."""
+        if status.get("errors"):
+            console.print("\n[bold red]Errors:[/bold red]")
+            for error in status["errors"]:
+                console.print(f"  [red]• {error}[/red]")
+
+        if status.get("warnings"):
+            console.print("\n[bold yellow]Warnings:[/bold yellow]")
+            for warning in status["warnings"]:
+                console.print(f"  [yellow]• {warning}[/yellow]")
+
+    def _display_response_logging_config(self, config: Config) -> None:
+        """Display response logging configuration table."""
+        console.print("\n[bold]Response Logging Configuration:[/bold]")
+        rl_config = config.get("response_logging", {})
+
+        table = Table(show_header=True)
+        table.add_column("Setting", style="cyan")
+        table.add_column("Value", style="white")
+
+        table.add_row("Enabled", str(rl_config.get("enabled", False)))
+        table.add_row("Format", rl_config.get("format", "json"))
+        table.add_row("Use Async", str(rl_config.get("use_async", True)))
+        table.add_row(
+            "Session Directory",
+            rl_config.get("session_directory", ".claude-mpm/responses"),
+        )
+        table.add_row(
+            "Compression", str(rl_config.get("enable_compression", False))
+        )
+
+        console.print(table)
+
+    def _display_config_table(self, config_dict: dict, prefix: str = "") -> None:
+        """Display configuration as a formatted table."""
+        table = Table(show_header=True, title="Configuration")
+        table.add_column("Key", style="cyan", no_wrap=True)
+        table.add_column("Value", style="white")
+        table.add_column("Type", style="dim")
+
+        def add_items(d: dict, prefix: str = ""):
+            for key, value in d.items():
+                full_key = f"{prefix}.{key}" if prefix else key
+
+                if isinstance(value, dict) and value:
+                    # Add nested items
+                    add_items(value, full_key)
+                else:
+                    # Add leaf value
+                    value_str = str(value)
+                    if len(value_str) > 50:
+                        value_str = value_str[:47] + "..."
+
+                    type_str = type(value).__name__
+                    table.add_row(full_key, value_str, type_str)
+
+        add_items(config_dict)
+        console.print(table)
+
+    def _flatten_config(self, config: dict, prefix: str = "") -> dict:
+        """Flatten nested configuration dictionary."""
+        flattened = {}
+
+        for key, value in config.items():
+            new_key = f"{prefix}.{key}" if prefix else key
+
+            if isinstance(value, dict):
+                flattened.update(self._flatten_config(value, new_key))
+            elif isinstance(value, list):
+                flattened[new_key] = str(value)
+            else:
+                flattened[new_key] = value
 
-            if status["warnings"]:
-                console.print("\n[bold yellow]Warnings:[/bold yellow]")
-                for warning in status["warnings"]:
-                    console.print(f"  [yellow]• {warning}[/yellow]")
+        return flattened
 
-        # Check response logging specifically
-        if args.check_response_logging:
-            console.print("\n[bold]Response Logging Configuration:[/bold]")
-            rl_config = config.get("response_logging", {})
 
-            table = Table(show_header=True)
-            table.add_column("Setting", style="cyan")
-            table.add_column("Value", style="white")
+def manage_config(args) -> int:
+    """Main entry point for configuration management commands.
 
-            table.add_row("Enabled", str(rl_config.get("enabled", False)))
-            table.add_row("Format", rl_config.get("format", "json"))
-            table.add_row("Use Async", str(rl_config.get("use_async", True)))
-            table.add_row(
-                "Session Directory",
-                rl_config.get("session_directory", ".claude-mpm/responses"),
-            )
-            table.add_row(
-                "Compression", str(rl_config.get("enable_compression", False))
-            )
+    This function maintains backward compatibility while using the new BaseCommand pattern.
+    """
+    command = ConfigCommand()
+    result = command.execute(args)
 
-            console.print(table)
+    # Print result if not already handled
+    if hasattr(args, 'format') and args.format in ['json', 'yaml']:
+        command.print_result(result, args)
 
-        return 0 if status["valid"] else 1
+    return result.exit_code
 
-    except Exception as e:
-        console.print(f"[red]Failed to get configuration status: {e}[/red]")
-        logger.exception("Configuration status error")
-        return 1
 
+# Legacy function for backward compatibility
+def validate_config(args) -> int:
+    """Legacy function for backward compatibility."""
+    command = ConfigCommand()
+    result = command.execute(args)
+    return result.exit_code
 
-def display_config_table(config_dict: dict, prefix: str = "") -> None:
-    """Display configuration as a formatted table.
 
-    Args:
-        config_dict: Configuration dictionary
-        prefix: Key prefix for nested values
-    """
-    table = Table(show_header=True, title="Configuration")
-    table.add_column("Key", style="cyan", no_wrap=True)
-    table.add_column("Value", style="white")
-    table.add_column("Type", style="dim")
-
-    def add_items(d: dict, prefix: str = ""):
-        for key, value in d.items():
-            full_key = f"{prefix}.{key}" if prefix else key
-
-            if isinstance(value, dict) and value:
-                # Add nested items
-                add_items(value, full_key)
-            else:
-                # Add leaf value
-                value_str = str(value)
-                if len(value_str) > 50:
-                    value_str = value_str[:47] + "..."
+def view_config(args) -> int:
+    """Legacy function for backward compatibility."""
+    command = ConfigCommand()
+    result = command.execute(args)
+    return result.exit_code
+
+
+def show_config_status(args) -> int:
+    """Legacy function for backward compatibility."""
+    command = ConfigCommand()
+    result = command.execute(args)
+    return result.exit_code
 
-                type_str = type(value).__name__
-                table.add_row(full_key, value_str, type_str)
 
-    add_items(config_dict)
-    console.print(table)
+def display_config_table(config_dict: dict, prefix: str = "") -> None:
+    """Legacy function for backward compatibility."""
+    command = ConfigCommand()
+    command._display_config_table(config_dict, prefix)