claude-mpm 3.4.10__py3-none-any.whl → 5.4.55__py3-none-any.whl

claude_mpm/core/service_registry.py

@@ -5,13 +5,17 @@ Provides centralized service registration and discovery, working with
 the DI container to manage application services.
 """
 
-import logging
-from pathlib import Path
-from typing import Any, Dict, List, Optional, Type, Union
+from typing import TYPE_CHECKING, Any, Dict, List, Optional, Type, Union
 
-from .container import DIContainer, ServiceLifetime, get_container
 from .base_service import BaseService
+from .config import Config
+from .container import DIContainer, ServiceLifetime, get_container
+from .enums import OperationResult
 from .logger import get_logger
+from .shared.config_loader import ConfigLoader
+
+if TYPE_CHECKING:
+    from claude_mpm.services.agents.deployment import AgentDeploymentService
 
 logger = get_logger(__name__)
 
@@ -19,74 +23,88 @@ logger = get_logger(__name__)
 class ServiceRegistry:
     """
     Central registry for all application services.
-    
+
     Manages service registration, configuration, and lifecycle.
     """
-    
+
     def __init__(self, container: Optional[DIContainer] = None):
         """
         Initialize service registry.
-        
+
         Args:
             container: DI container to use (uses global if not provided)
         """
         self.container = container or get_container()
         self._services: Dict[str, Type[BaseService]] = {}
         self._initialized = False
-        
+
     def register_core_services(self) -> None:
         """Register all core framework services."""
-        from ..services.shared_prompt_cache import SharedPromptCache
-        from ..services.ticket_manager import TicketManager
-        from ..services.agent_deployment import AgentDeploymentService
-        from .session_manager import SessionManager
+        from claude_mpm.services.memory.cache.shared_prompt_cache import (
+            SharedPromptCache,
+        )
+
+        from ..services import AgentDeploymentService
         from .agent_session_manager import AgentSessionManager
-        from .config import Config
-        
-        # Register configuration as singleton
-        config = Config()
-        self.container.register_singleton(Config, instance=config)
-        
-        # Register core services
+        from .session_manager import SessionManager
+
+        # Register configuration as singleton with name using ConfigLoader
+        config_loader = ConfigLoader()
+        config = config_loader.load_main_config()
+        self.container.register_singleton(Config, instance=config, name="main_config")
+
+        # Register core services with proper lifetime management
         self.register_service(
-            "session_manager",
-            SessionManager,
-            lifetime=ServiceLifetime.SINGLETON
+            "session_manager", SessionManager, lifetime=ServiceLifetime.SINGLETON
         )
-        
+
         self.register_service(
             "agent_session_manager",
             AgentSessionManager,
             lifetime=ServiceLifetime.SINGLETON,
-            dependencies={
-                'session_dir': lambda c: c.resolve(Config).get('session_dir')
-            }
+            dependencies={"session_dir": lambda c: c.get(Config).get("session_dir")},
         )
-        
-        # Register shared cache as singleton (it's already a singleton internally)
-        self.register_service(
-            "prompt_cache",
+
+        # Register shared cache as singleton with factory
+        self.container.register_factory(
             SharedPromptCache,
+            lambda c: SharedPromptCache.get_instance(),
             lifetime=ServiceLifetime.SINGLETON,
-            factory=lambda c: SharedPromptCache.get_instance()
-        )
-        
-        # Register ticket manager
-        self.register_service(
-            "ticket_manager",
-            TicketManager,
-            lifetime=ServiceLifetime.TRANSIENT
+            name="prompt_cache",
         )
-        
-        # Register agent deployment service
-        self.register_service(
-            "agent_deployment",
+
+        # Ticket manager removed - use claude-mpm tickets CLI commands instead
+
+        # Register agent deployment service with factory for better initialization
+        self.container.register_factory(
             AgentDeploymentService,
-            lifetime=ServiceLifetime.TRANSIENT
+            lambda c: self._create_agent_deployment_service(c),
+            lifetime=ServiceLifetime.TRANSIENT,
+            name="agent_deployment",
         )
-        
-        logger.info("Core services registered")
-        
+
+        logger.info("Core services registered with enhanced DI container")
+
+    def _create_agent_deployment_service(
+        self, container: DIContainer
+    ) -> "AgentDeploymentService":
+        """Factory method for creating agent deployment service."""
+        import os
+        from pathlib import Path
+
+        config = container.get(Config)
+
+        # Get working directory from environment or config
+        if "CLAUDE_MPM_USER_PWD" in os.environ:
+            working_dir = Path(os.environ["CLAUDE_MPM_USER_PWD"])
+        else:
+            working_dir = Path(config.get("project.dir", "."))
+
+        # Lazy import to avoid circular dependencies
+        from claude_mpm.services.agents.deployment import AgentDeploymentService
+
+        return AgentDeploymentService(working_directory=working_dir)
+
     def register_service(
         self,
         name: str,
@@ -94,11 +112,11 @@ class ServiceRegistry:
         lifetime: ServiceLifetime = ServiceLifetime.SINGLETON,
         factory: Optional[Any] = None,
         dependencies: Optional[Dict[str, Any]] = None,
-        config: Optional[Dict[str, Any]] = None
+        config: Optional[Dict[str, Any]] = None,
     ) -> None:
         """
         Register a service with the registry.
-        
+
         Args:
             name: Service name for lookup
             service_class: Service class (must inherit from BaseService)
@@ -109,147 +127,166 @@ class ServiceRegistry:
         """
         # Store service metadata
         self._services[name] = service_class
-        
+
         # Create factory wrapper if config provided
         if config and not factory:
-            factory = lambda c: service_class(name=name, config=config, container=c)
+
+            def factory(c):
+                return service_class(name=name, config=config, container=c)
+
         elif not factory:
             # Default factory with container injection
-            factory = lambda c: service_class(name=name, container=c)
-            
+            def factory(c):
+                return service_class(name=name, container=c)
+
         # Register with DI container
         self.container.register(
-            service_class,
-            factory=factory,
-            lifetime=lifetime,
-            dependencies=dependencies
+            service_class, factory=factory, lifetime=lifetime, dependencies=dependencies
         )
-        
+
         logger.debug(f"Registered service: {name} ({service_class.__name__})")
-        
+
     def get_service(self, service_type: Union[str, Type[BaseService]]) -> BaseService:
         """
         Get a service instance.
-        
+
         Args:
             service_type: Service name or class
-            
+
         Returns:
             Service instance
         """
         if isinstance(service_type, str):
-            # Look up by name
-            if service_type not in self._services:
-                raise KeyError(f"Service '{service_type}' not registered")
-            service_class = self._services[service_type]
+            # First try to get by name from container
+            try:
+                # Use the enhanced container's named resolution
+                return self.container.get(BaseService, name=service_type)
+            except Exception as e:
+                # Fall back to looking up class and resolving
+                if service_type not in self._services:
+                    raise KeyError(f"Service '{service_type}' not registered") from e
+                service_class = self._services[service_type]
+                return self.container.get(service_class)
         else:
-            service_class = service_type
-            
-        return self.container.resolve(service_class)
-        
+            # Direct class resolution
+            return self.container.get(service_type)
+
     def get_service_optional(
         self,
         service_type: Union[str, Type[BaseService]],
-        default: Optional[BaseService] = None
+        default: Optional[BaseService] = None,
     ) -> Optional[BaseService]:
         """Get a service if available, otherwise return default."""
         try:
             return self.get_service(service_type)
         except (KeyError, Exception):
             return default
-            
+
     def start_all_services(self) -> None:
         """Start all registered singleton services."""
         import asyncio
-        
+
         async def _start_all():
             for name, service_class in self._services.items():
                 try:
                     # Only start singleton services
-                    registration = self.container.get_all_registrations().get(service_class)
-                    if registration and registration.lifetime == ServiceLifetime.SINGLETON:
+                    registration = self.container.get_all_registrations().get(
+                        service_class
+                    )
+                    if (
+                        registration
+                        and registration.lifetime == ServiceLifetime.SINGLETON
+                    ):
                         service = self.get_service(service_class)
-                        if hasattr(service, 'start'):
+                        if hasattr(service, "start"):
                             await service.start()
                             logger.info(f"Started service: {name}")
                 except Exception as e:
                     logger.error(f"Failed to start service {name}: {e}")
-                    
+
         asyncio.run(_start_all())
         self._initialized = True
-        
+
     def stop_all_services(self) -> None:
         """Stop all running singleton services."""
         import asyncio
-        
+
         async def _stop_all():
             for name, service_class in reversed(list(self._services.items())):
                 try:
                     # Only stop singleton services
-                    registration = self.container.get_all_registrations().get(service_class)
-                    if registration and registration.lifetime == ServiceLifetime.SINGLETON:
-                        if service_class in self.container._singletons:
-                            service = self.container._singletons[service_class]
-                            if hasattr(service, 'stop') and service.running:
-                                await service.stop()
-                                logger.info(f"Stopped service: {name}")
+                    registration = self.container.get_all_registrations().get(
+                        service_class
+                    )
+                    if (
+                        registration
+                        and registration.lifetime == ServiceLifetime.SINGLETON
+                    ) and service_class in self.container._singletons:
+                        service = self.container._singletons[service_class]
+                        if hasattr(service, "stop") and service.running:
+                            await service.stop()
+                            logger.info(f"Stopped service: {name}")
                 except Exception as e:
                     logger.error(f"Failed to stop service {name}: {e}")
-                    
+
         asyncio.run(_stop_all())
-        
+
     def get_service_health(self) -> Dict[str, Dict[str, Any]]:
         """Get health status of all services."""
         import asyncio
-        
+
         async def _get_health():
             health_status = {}
-            
+
             for name, service_class in self._services.items():
                 try:
                     if service_class in self.container._singletons:
                         service = self.container._singletons[service_class]
-                        if hasattr(service, 'health_check'):
+                        if hasattr(service, "health_check"):
                             health = await service.health_check()
                             health_status[name] = {
-                                'status': health.status,
-                                'message': health.message,
-                                'metrics': health.metrics
+                                "status": health.status,
+                                "message": health.message,
+                                "metrics": health.metrics,
                             }
                 except Exception as e:
                     health_status[name] = {
-                        'status': 'error',
-                        'message': str(e)
+                        "status": OperationResult.ERROR,
+                        "message": str(e),
                     }
-                    
+
             return health_status
-            
+
         return asyncio.run(_get_health())
-        
+
     def list_services(self) -> List[Dict[str, Any]]:
         """List all registered services with their metadata."""
         services = []
-        
+
         for name, service_class in self._services.items():
             registration = self.container.get_all_registrations().get(service_class)
-            
+
             service_info = {
-                'name': name,
-                'class': service_class.__name__,
-                'module': service_class.__module__,
-                'lifetime': registration.lifetime.value if registration else 'unknown',
-                'is_singleton': registration.lifetime == ServiceLifetime.SINGLETON if registration else False,
-                'is_running': False
+                "name": name,
+                "class": service_class.__name__,
+                "module": service_class.__module__,
+                "lifetime": registration.lifetime.value if registration else "unknown",
+                "is_singleton": (
+                    registration.lifetime == ServiceLifetime.SINGLETON
+                    if registration
+                    else False
+                ),
+                "is_running": False,
             }
-            
+
             # Check if singleton is running
             if service_class in self.container._singletons:
                 service = self.container._singletons[service_class]
-                if hasattr(service, 'running'):
-                    service_info['is_running'] = service.running
-                    
+                if hasattr(service, "running"):
+                    service_info["is_running"] = service.running
+
             services.append(service_info)
-            
+
         return services
 
 
@@ -269,23 +306,23 @@ def get_service_registry() -> ServiceRegistry:
 def initialize_services(config: Optional[Dict[str, Any]] = None) -> ServiceRegistry:
     """
     Initialize all application services.
-    
+
     Args:
         config: Optional configuration overrides
-        
+
     Returns:
         Initialized service registry
     """
     registry = get_service_registry()
-    
+
     if config:
         # Apply configuration overrides
         config_service = registry.container.resolve(Config)
         for key, value in config.items():
             config_service.set(key, value)
-            
+
     # Start all services
     if not registry._initialized:
         registry.start_all_services()
-        
-    return registry
+
+    return registry