civics-cdf-validator 1.49.dev9__py3-none-any.whl → 1.49.dev11__py3-none-any.whl

civics_cdf_validator/rules.py

@@ -2898,37 +2898,76 @@ class OfficeSelectionMethodMatch(base.BaseRule):
       )
 
 
+class OfficeHolderTenureTermDates(base.DateRule):
+  """OfficeHolderTenure elements should contain valid term dates."""
+
+  def elements(self):
+    return ["OfficeHolderTenure"]
+
+  def check(self, element):
+    start_date = element.find("StartDate")
+    end_date = element.find("EndDate")
+    if element_has_text(start_date) and element_has_text(end_date):
+      start_date_obj = base.PartialDate.init_partial_date(start_date.text)
+      end_date_obj = base.PartialDate.init_partial_date(end_date.text)
+      if end_date_obj < start_date_obj:
+        raise loggers.ElectionError.from_message(
+            "OfficeHolderTenure element has an EndDate that is before the"
+            " StartDate.",
+            [element],
+        )
+
+
 class OfficeTermDates(base.DateRule):
   """Office elements should contain valid term dates.
 
   Offices with OfficeHolderPersonIds should have a Term declared. Given
   term should have a start date. If term also has an end date then end date
-  should come after start date.
+  should come after start date. Post Office split feed office objects should
+  not have a Term element.
   """
 
+  def __init__(self, election_tree, schema_tree, **kwargs):
+    self.is_post_office_split_feed = False
+    officeholder_tenure_collection_element = self.get_elements_by_class(
+        election_tree, "OfficeHolderTenureCollection"
+    )
+    if officeholder_tenure_collection_element:
+      self.is_post_office_split_feed = True
+
   def elements(self):
     return ["Office"]
 
   def check(self, element):
     self.reset_instance_vars()
-    off_per_id = element.find("OfficeHolderPersonIds")
-    if element_has_text(off_per_id):
+    if self.is_post_office_split_feed:
       term = element.find("Term")
-      if term is None:
-        raise loggers.ElectionWarning.from_message(
-            "The Office is missing a Term.", [element]
+      if term is not None:
+        raise loggers.ElectionError.from_message(
+            "Office should not contain Term data in post Office split feed.",
+            [element],
         )
+      if self.error_log:
+        raise loggers.ElectionError(self.error_log)
+    else:
+      off_per_id = element.find("OfficeHolderPersonIds")
+      if element_has_text(off_per_id):
+        term = element.find("Term")
+        if term is None:
+          raise loggers.ElectionWarning.from_message(
+              "The Office is missing a Term.", [element]
+          )
 
-      self.gather_dates(term)
-      if self.start_date is None:
-        raise loggers.ElectionWarning.from_message(
-            "The Office is missing a Term > StartDate.", [element]
-        )
-      elif self.end_date is not None:
-        self.check_end_after_start()
+        self.gather_dates(term)
+        if self.start_date is None:
+          raise loggers.ElectionWarning.from_message(
+              "The Office is missing a Term > StartDate.", [element]
+          )
+        elif self.end_date is not None:
+          self.check_end_after_start()
 
-    if self.error_log:
-      raise loggers.ElectionError(self.error_log)
+      if self.error_log:
+        raise loggers.ElectionError(self.error_log)
 
 
 class RemovePersonAndOfficeHolderId60DaysAfterEndDate(base.TreeRule):
@@ -4451,6 +4490,118 @@ class UnsupportedOfficeHolderTenureSchema(base.BaseRule):
       )
 
 
+class ElectoralCommissionCollectionExists(base.BaseRule):
+  """ElectoralCommissionCollection should exist."""
+
+  def elements(self):
+    return ["ElectionReport"]
+
+  def check(self, element):
+    if element.find("ElectoralCommissionCollection") is None:
+      raise loggers.ElectionError.from_message(
+          "ElectoralCommissionCollection should exist."
+      )
+
+
+class VoterInformationCollectionExists(base.BaseRule):
+  """Warn if there is no VoterInformationCollection."""
+
+  def elements(self):
+    return ["ElectionReport"]
+
+  def check(self, element):
+    if element.find("VoterInformationCollection") is None:
+      raise loggers.ElectionWarning.from_message(
+          "VoterInformationCollection should exist."
+      )
+
+
+class NoExtraElectionElements(base.BaseRule):
+  """Elections for voter information feeds should not have certain elements.
+
+  BallotStyleCollection, CandidateCollection, ContestCollection, CountStatus
+  should all be excluded.
+  """
+
+  def elements(self):
+    return ["Election"]
+
+  def check(self, element):
+    if element.find("BallotStyleCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "BallotStyleCollection should not exist."
+      )
+
+    if element.find("CandidateCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "CandidateCollection should not exist."
+      )
+    if element.find("ContestCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "ContestCollection should not exist."
+      )
+
+    if element.find("CountStatus") is not None:
+      raise loggers.ElectionError.from_message("CountStatus should not exist.")
+
+
+class WarnOnElementsNotRecommendedForElection(base.BaseRule):
+  """Warn on ContactInformation on an Election for voter information feeds."""
+
+  def elements(self):
+    return ["Election"]
+
+  def check(self, element):
+    if element.find("ContactInformation") is not None:
+      raise loggers.ElectionWarning.from_message(
+          "ContactInformation is not recommended for Election, prefer using an"
+          " ElectionAdministration."
+      )
+
+
+class NoExtraElectionReportCollections(base.BaseRule):
+  """ElectionReports for voter information feeds should not have certain elements.
+
+  CommitteeCollection, GovernmentBodyCollection, OfficeCollection,
+  OfficeHolderTenureCollection, PartyCollection, PersonCollection should all be
+  excluded.
+  """
+
+  def elements(self):
+    return ["ElectionReport"]
+
+  def check(self, element):
+    if element.find("CommitteeCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "CommitteeCollection should not exist."
+      )
+
+    if element.find("GovernmentBodyCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "GovernmentBodyCollection should not exist."
+      )
+
+    if element.find("OfficeCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "OfficeCollection should not exist."
+      )
+
+    if element.find("OfficeHolderTenureCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "OfficeHolderTenureCollection should not exist."
+      )
+
+    if element.find("PartyCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "PartyCollection should not exist."
+      )
+
+    if element.find("PersonCollection") is not None:
+      raise loggers.ElectionError.from_message(
+          "PersonCollection should not exist."
+      )
+
+
 class RuleSet(enum.Enum):
   """Names for sets of rules used to validate a particular feed type."""
 
@@ -4460,6 +4611,7 @@ class RuleSet(enum.Enum):
   ELECTION_DATES = 4
   ELECTION_RESULTS = 5
   METADATA = 6
+  VOTER_INFORMATION = 7
 
 
 # To add new rules, create a new class, inherit the base rule,
@@ -4578,6 +4730,7 @@ ELECTION_RESULTS_RULES = ELECTION_RULES + (
 OFFICEHOLDER_RULES = COMMON_RULES + (
     # go/keep-sorted start
     DateOfBirthIsInPast,
+    OfficeHolderTenureTermDates,
     OfficeSelectionMethodMatch,
     OfficeTermDates,
     PersonHasOffice,
@@ -4620,6 +4773,16 @@ METADATA_RULES = (
     # go/keep-sorted end
 )
 
+VOTER_INFORMATION_RULES = COMMON_RULES + (
+    # go/keep-sorted start
+    ElectoralCommissionCollectionExists,
+    NoExtraElectionElements,
+    NoExtraElectionReportCollections,
+    VoterInformationCollectionExists,
+    WarnOnElementsNotRecommendedForElection,
+    # go/keep-sorted end
+)
+
 ALL_RULES = frozenset(
     COMMON_RULES
     + ELECTION_RULES
@@ -4627,5 +4790,6 @@ ALL_RULES = frozenset(
     + OFFICEHOLDER_RULES
     + COMMITTEE_RULES
     + ELECTION_DATES_RULES
+    + VOTER_INFORMATION_RULES
     + METADATA_RULES
 )

civics_cdf_validator/validator.py

@@ -260,6 +260,8 @@ def filter_all_rules_using_user_arg(rules_allowlist, rule_set, rules_blocklist):
       rule_names = [x.__name__ for x in rules.ELECTION_RESULTS_RULES]
     elif rule_set == rules.RuleSet.METADATA:
       rule_names = [x.__name__ for x in rules.METADATA_RULES]
+    elif rule_set == rules.RuleSet.VOTER_INFORMATION:
+      rule_names = [x.__name__ for x in rules.VOTER_INFORMATION_RULES]
     else:
       raise AssertionError("Invalid rule_set: " + rule_set)
     if rules_blocklist:

civics_cdf_validator/version.py

@@ -5,4 +5,4 @@ No dependencies should be added to this module.
 See https://packaging.python.org/guides/single-sourcing-package-version/
 """
 
-__version__ = '1.49.dev9'
+__version__ = '1.49.dev11'

{civics_cdf_validator-1.49.dev9.dist-info → civics_cdf_validator-1.49.dev11.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: civics_cdf_validator
-Version: 1.49.dev9
+Version: 1.49.dev11
 Summary: Checks if an election feed follows best practices
 Home-page: https://github.com/google/civics_cdf_validator
 Author: Google Civics

civics_cdf_validator-1.49.dev11.dist-info/RECORD

@@ -0,0 +1,15 @@
+civics_cdf_validator/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
+civics_cdf_validator/base.py,sha256=5zntjAdAA-bdwYOOStFgUle9LGX_ccelS--thMhUG9A,16954
+civics_cdf_validator/gpunit_rules.py,sha256=Cg-qlOeVKTCQ5qUKYSxbVrrh3tdLt1X5Eg-7uyyR_SY,9487
+civics_cdf_validator/loggers.py,sha256=LS6U9YWzu72V2Q0PwyE9xE03Ul392UAPRnrp2uRBMLA,6923
+civics_cdf_validator/office_utils.py,sha256=aFxcFQZF2oBn0gPXt_kv1LxHGvwzABScT8X5yaYtVLw,2705
+civics_cdf_validator/rules.py,sha256=Hn7qk3qLhidhQrb15iq1ZwN4XLJ4HVhY4VHBbNGY9u4,158898
+civics_cdf_validator/stats.py,sha256=YNqv3Khkt_hJxCIunFBRSl23oXqu5gNjCmWMHFbAcSU,3819
+civics_cdf_validator/validator.py,sha256=2nwlFfQ9AmpTaO5n5ekaO845Rm0JPjNF-Il6FJW_50k,12678
+civics_cdf_validator/version.py,sha256=5WTRUaJiARj_r2UPhcMKa9SSvt8tRFJt6pCR0zFyGpc,189
+civics_cdf_validator-1.49.dev11.dist-info/licenses/LICENSE-2.0.txt,sha256=z8d0m5b2O9McPEK1xHG_dWgUBT6EfBDz6wA0F7xSPTA,11358
+civics_cdf_validator-1.49.dev11.dist-info/METADATA,sha256=9odJ6J0QGbWLOgkjRweufw1myU5Tg_CX3ts5z_zLbCI,1009
+civics_cdf_validator-1.49.dev11.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
+civics_cdf_validator-1.49.dev11.dist-info/entry_points.txt,sha256=QibgvtMOocwDi7fQ1emgMJ2lIlI41sW0__KIQdnVn90,77
+civics_cdf_validator-1.49.dev11.dist-info/top_level.txt,sha256=PYT5Eclxbop5o6DJIcgs4IeU6Ds5jqyftjoFbgkkJYo,21
+civics_cdf_validator-1.49.dev11.dist-info/RECORD,,

{civics_cdf_validator-1.49.dev9.dist-info → civics_cdf_validator-1.49.dev11.dist-info}/WHEEL

@@ -1,5 +1,5 @@
 Wheel-Version: 1.0
-Generator: setuptools (80.4.0)
+Generator: setuptools (80.9.0)
 Root-Is-Purelib: true
 Tag: py3-none-any
 

civics_cdf_validator-1.49.dev9.dist-info/RECORD

@@ -1,15 +0,0 @@
-civics_cdf_validator/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-civics_cdf_validator/base.py,sha256=5zntjAdAA-bdwYOOStFgUle9LGX_ccelS--thMhUG9A,16954
-civics_cdf_validator/gpunit_rules.py,sha256=Cg-qlOeVKTCQ5qUKYSxbVrrh3tdLt1X5Eg-7uyyR_SY,9487
-civics_cdf_validator/loggers.py,sha256=LS6U9YWzu72V2Q0PwyE9xE03Ul392UAPRnrp2uRBMLA,6923
-civics_cdf_validator/office_utils.py,sha256=aFxcFQZF2oBn0gPXt_kv1LxHGvwzABScT8X5yaYtVLw,2705
-civics_cdf_validator/rules.py,sha256=2Kjtp2sTltj71w_pQa9tAAvdwpxQJYa16NuHL4_wD4Y,153532
-civics_cdf_validator/stats.py,sha256=YNqv3Khkt_hJxCIunFBRSl23oXqu5gNjCmWMHFbAcSU,3819
-civics_cdf_validator/validator.py,sha256=SXPsYLu0G_JT2B03i24-yJFh41YzaSYecan4LQ_Xqm4,12553
-civics_cdf_validator/version.py,sha256=XOa4xnNoLYpXsmOeZNQZtWSb-PQRJvLkfm36T1fBwBI,188
-civics_cdf_validator-1.49.dev9.dist-info/licenses/LICENSE-2.0.txt,sha256=z8d0m5b2O9McPEK1xHG_dWgUBT6EfBDz6wA0F7xSPTA,11358
-civics_cdf_validator-1.49.dev9.dist-info/METADATA,sha256=3J9MrvSscqntXR4MFxPwzqHYDOU4TqLftz9_F_mgZrM,1008
-civics_cdf_validator-1.49.dev9.dist-info/WHEEL,sha256=DnLRTWE75wApRYVsjgc6wsVswC54sMSJhAEd4xhDpBk,91
-civics_cdf_validator-1.49.dev9.dist-info/entry_points.txt,sha256=QibgvtMOocwDi7fQ1emgMJ2lIlI41sW0__KIQdnVn90,77
-civics_cdf_validator-1.49.dev9.dist-info/top_level.txt,sha256=PYT5Eclxbop5o6DJIcgs4IeU6Ds5jqyftjoFbgkkJYo,21
-civics_cdf_validator-1.49.dev9.dist-info/RECORD,,