chia-blockchain 2.5.0rc1__py3-none-any.whl → 2.5.1__py3-none-any.whl

chia/_tests/core/server/flood.py

@@ -9,6 +9,7 @@ import sys
 import time
 
 from chia._tests.util.misc import create_logger
+from chia.util.task_referencer import create_referenced_task
 
 # TODO: CAMPid 0945094189459712842390t591
 IP = "127.0.0.1"
@@ -28,7 +29,7 @@ async def tcp_echo_client(task_counter: str, logger: logging.Logger) -> None:
             writer = None
             try:
                 logger.info(f"Opening connection: {label}")
-                reader, writer = await asyncio.open_connection(IP, PORT)
+                _reader, writer = await asyncio.open_connection(IP, PORT)
                 total_open_connections += 1
                 logger.info(f"Opened connection: {label} (total: {total_open_connections})")
                 assert writer is not None
@@ -56,12 +57,13 @@ async def main() -> None:
     out_path = shutdown_path.with_suffix(".out")
 
     async def dun() -> None:
-        while shutdown_path.exists():
+        # TODO: switch to event driven code
+        while shutdown_path.exists():  # noqa: ASYNC110
             await asyncio.sleep(0.25)
 
         task.cancel()
 
-    file_task = asyncio.create_task(dun())
+    file_task = create_referenced_task(dun())
 
     with out_path.open(mode="w") as file:
         logger = create_logger(file=file)
@@ -69,7 +71,7 @@ async def main() -> None:
         async def f() -> None:
             await asyncio.gather(*[tcp_echo_client(task_counter=f"{i}", logger=logger) for i in range(0, NUM_CLIENTS)])
 
-        task = asyncio.create_task(f())
+        task = create_referenced_task(f())
         try:
             await task
         except asyncio.CancelledError:

chia/_tests/core/server/serve.py

@@ -9,11 +9,12 @@ import logging.config
 import pathlib
 import sys
 import threading
-from typing import List, Optional, final, overload
+from typing import Optional, final, overload
 
 from chia._tests.util.misc import create_logger
 from chia.server.chia_policy import ChiaPolicy
 from chia.server.start_service import async_run
+from chia.util.task_referencer import create_referenced_task
 
 if sys.platform == "win32":
     import _winapi
@@ -48,7 +49,7 @@ async def async_main(
     shutdown_path: pathlib.Path,
     ip: str = "127.0.0.1",
     port: int = 8444,
-    port_holder: Optional[List[int]] = None,
+    port_holder: Optional[list[int]] = None,
 ) -> None: ...
 
 
@@ -59,7 +60,7 @@ async def async_main(
     thread_end_event: threading.Event,
     ip: str = "127.0.0.1",
     port: int = 8444,
-    port_holder: Optional[List[int]] = None,
+    port_holder: Optional[list[int]] = None,
 ) -> None: ...
 
 
@@ -70,7 +71,7 @@ async def async_main(
     thread_end_event: Optional[threading.Event] = None,
     ip: str = "127.0.0.1",
     port: int = 8444,
-    port_holder: Optional[List[int]] = None,
+    port_holder: Optional[list[int]] = None,
 ) -> None:
     with out_path.open(mode="w") as file:
         logger = create_logger(file=file)
@@ -80,12 +81,13 @@ async def async_main(
             thread_end_event = threading.Event()
 
             async def dun() -> None:
-                while shutdown_path.exists():
+                # TODO: switch to event driven code
+                while shutdown_path.exists():  # noqa: ASYNC110
                     await asyncio.sleep(0.25)
 
                 thread_end_event.set()
 
-            file_task = asyncio.create_task(dun())
+            file_task = create_referenced_task(dun())
 
         loop = asyncio.get_event_loop()
         server = await loop.create_server(functools.partial(EchoServer, logger=logger), ip, port)
@@ -97,7 +99,8 @@ async def async_main(
 
         try:
             try:
-                while not thread_end_event.is_set():
+                # TODO: switch to event driven code
+                while not thread_end_event.is_set():  # noqa: ASYNC110
                     await asyncio.sleep(0.1)
             finally:
                 # the test checks explicitly for this

chia/_tests/core/server/test_api_protocol.py

@@ -0,0 +1,21 @@
+from __future__ import annotations
+
+import pytest
+
+from chia.protocols.full_node_protocol import RequestTransaction
+from chia.protocols.protocol_message_types import ProtocolMessageTypes
+from chia.server.api_protocol import ApiMetadata
+
+
+def test_api_protocol_raises_for_repeat_request_registration() -> None:
+    metadata = ApiMetadata()
+
+    @metadata.request(request_type=ProtocolMessageTypes.handshake)
+    async def f(self: object, request: RequestTransaction) -> None: ...
+
+    async def g(self: object, request: RequestTransaction) -> None: ...
+
+    decorator = metadata.request(request_type=ProtocolMessageTypes.handshake)
+
+    with pytest.raises(Exception, match="request type already registered"):
+        decorator(g)

chia/_tests/core/server/test_capabilities.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-from typing import List, Tuple
-
 import pytest
 
 from chia.protocols.shared_protocol import Capability
@@ -53,13 +51,13 @@ from chia.util.ints import uint16
     ids=lambda value: "disabled" if value else "enabled",
 )
 def test_known_active_capabilities_filter(
-    values: List[Tuple[uint16, str]],
-    expected: List[Capability],
+    values: list[tuple[uint16, str]],
+    expected: list[Capability],
     duplicated: bool,
     disabled: bool,
 ) -> None:
     if duplicated:
-        values = values * 2
+        values *= 2
 
     if disabled:
         values = [(value, "0") for value, state in values]

chia/_tests/core/server/test_dos.py

@@ -1,10 +1,9 @@
-# flake8: noqa: F811, F401
 from __future__ import annotations
 
 import asyncio
 import logging
 import time
-from typing import List, Tuple
+from typing import Optional
 
 import pytest
 from aiohttp import ClientSession, ClientTimeout, WSCloseCode, WSMessage, WSMsgType, WSServerHandshakeError
@@ -45,15 +44,15 @@ async def get_block_path(full_node: FullNodeAPI):
 
 
 class FakeRateLimiter:
-    def process_msg_and_check(self, msg, capa, capb):
-        return True
+    def process_msg_and_check(self, msg, capa, capb) -> Optional[str]:
+        return None
 
 
 class TestDos:
     @pytest.mark.anyio
     async def test_banned_host_can_not_connect(
         self,
-        setup_two_nodes_fixture: Tuple[List[FullNodeSimulator], List[Tuple[WalletNode, ChiaServer]], BlockTools],
+        setup_two_nodes_fixture: tuple[list[FullNodeSimulator], list[tuple[WalletNode, ChiaServer]], BlockTools],
         self_hostname: str,
         monkeypatch: pytest.MonkeyPatch,
     ) -> None:
@@ -77,7 +76,7 @@ class TestDos:
     @pytest.mark.anyio
     async def test_large_message_disconnect_and_ban(
         self,
-        setup_two_nodes_fixture: Tuple[List[FullNodeSimulator], List[Tuple[WalletNode, ChiaServer]], BlockTools],
+        setup_two_nodes_fixture: tuple[list[FullNodeSimulator], list[tuple[WalletNode, ChiaServer]], BlockTools],
         self_hostname: str,
         monkeypatch: pytest.MonkeyPatch,
     ) -> None:
@@ -112,7 +111,7 @@ class TestDos:
     @pytest.mark.anyio
     async def test_bad_handshake_and_ban(
         self,
-        setup_two_nodes_fixture: Tuple[List[FullNodeSimulator], List[Tuple[WalletNode, ChiaServer]], BlockTools],
+        setup_two_nodes_fixture: tuple[list[FullNodeSimulator], list[tuple[WalletNode, ChiaServer]], BlockTools],
         self_hostname: str,
         monkeypatch: pytest.MonkeyPatch,
     ) -> None:
@@ -176,7 +175,7 @@ class TestDos:
     @pytest.mark.anyio
     async def test_spam_tx(self, setup_two_nodes_fixture, self_hostname):
         nodes, _, _ = setup_two_nodes_fixture
-        full_node_1, full_node_2 = nodes
+        _full_node_1, full_node_2 = nodes
         server_1 = nodes[0].full_node.server
         server_2 = nodes[1].full_node.server
 
@@ -184,8 +183,8 @@ class TestDos:
 
         assert len(server_1.all_connections) == 1
 
-        ws_con: WSChiaConnection = list(server_1.all_connections.values())[0]
-        ws_con_2: WSChiaConnection = list(server_2.all_connections.values())[0]
+        ws_con: WSChiaConnection = next(iter(server_1.all_connections.values()))
+        ws_con_2: WSChiaConnection = next(iter(server_2.all_connections.values()))
 
         ws_con.peer_info = PeerInfo("1.2.3.4", ws_con.peer_info.port)
         ws_con_2.peer_info = PeerInfo("1.2.3.4", ws_con_2.peer_info.port)
@@ -231,7 +230,7 @@ class TestDos:
     @pytest.mark.anyio
     async def test_spam_message_non_tx(self, setup_two_nodes_fixture, self_hostname):
         nodes, _, _ = setup_two_nodes_fixture
-        full_node_1, full_node_2 = nodes
+        _full_node_1, full_node_2 = nodes
         server_1 = nodes[0].full_node.server
         server_2 = nodes[1].full_node.server
 
@@ -239,8 +238,8 @@ class TestDos:
 
         assert len(server_1.all_connections) == 1
 
-        ws_con: WSChiaConnection = list(server_1.all_connections.values())[0]
-        ws_con_2: WSChiaConnection = list(server_2.all_connections.values())[0]
+        ws_con: WSChiaConnection = next(iter(server_1.all_connections.values()))
+        ws_con_2: WSChiaConnection = next(iter(server_2.all_connections.values()))
 
         ws_con.peer_info = PeerInfo("1.2.3.4", ws_con.peer_info.port)
         ws_con_2.peer_info = PeerInfo("1.2.3.4", ws_con_2.peer_info.port)
@@ -280,7 +279,7 @@ class TestDos:
     @pytest.mark.anyio
     async def test_spam_message_too_large(self, setup_two_nodes_fixture, self_hostname):
         nodes, _, _ = setup_two_nodes_fixture
-        full_node_1, full_node_2 = nodes
+        _full_node_1, full_node_2 = nodes
         server_1 = nodes[0].full_node.server
         server_2 = nodes[1].full_node.server
 
@@ -288,8 +287,8 @@ class TestDos:
 
         assert len(server_1.all_connections) == 1
 
-        ws_con: WSChiaConnection = list(server_1.all_connections.values())[0]
-        ws_con_2: WSChiaConnection = list(server_2.all_connections.values())[0]
+        ws_con: WSChiaConnection = next(iter(server_1.all_connections.values()))
+        ws_con_2: WSChiaConnection = next(iter(server_2.all_connections.values()))
 
         ws_con.peer_info = PeerInfo("1.2.3.4", ws_con.peer_info.port)
         ws_con_2.peer_info = PeerInfo("1.2.3.4", ws_con_2.peer_info.port)

chia/_tests/core/server/test_loop.py

@@ -8,8 +8,9 @@ import random
 import subprocess
 import sys
 import threading
+from collections.abc import AsyncIterator
 from dataclasses import dataclass, field
-from typing import AsyncIterator, List, Optional
+from typing import Optional
 
 import anyio
 import pytest
@@ -17,6 +18,7 @@ import pytest
 from chia._tests.core.server import serve
 from chia._tests.util.misc import create_logger
 from chia.server import chia_policy
+from chia.util.task_referencer import create_referenced_task
 from chia.util.timing import adjusted_timeout
 
 here = pathlib.Path(__file__).parent
@@ -57,8 +59,8 @@ class Client:
 
     @classmethod
     @contextlib.asynccontextmanager
-    async def open_several(cls, count: int, ip: str, port: int) -> AsyncIterator[List[Client]]:
-        clients: List[Client] = await asyncio.gather(*(cls.open(ip=ip, port=port) for _ in range(count)))
+    async def open_several(cls, count: int, ip: str, port: int) -> AsyncIterator[list[Client]]:
+        clients: list[Client] = await asyncio.gather(*(cls.open(ip=ip, port=port) for _ in range(count)))
         try:
             yield [*clients]
         finally:
@@ -98,7 +100,7 @@ class ServeInThread:
     server_task: Optional[asyncio.Task[None]] = None
     thread: Optional[threading.Thread] = None
     thread_end_event: threading.Event = field(default_factory=threading.Event)
-    port_holder: List[int] = field(default_factory=list)
+    port_holder: list[int] = field(default_factory=list)
 
     def start(self) -> None:
         self.original_connection_limit = chia_policy.global_max_concurrent_connections
@@ -122,7 +124,7 @@ class ServeInThread:
             asyncio.set_event_loop_policy(original_event_loop_policy)
 
     async def main(self) -> None:
-        self.server_task = asyncio.create_task(
+        self.server_task = create_referenced_task(
             serve.async_main(
                 out_path=self.out_path,
                 ip=self.ip,
@@ -161,7 +163,8 @@ async def test_loop(tmp_path: pathlib.Path) -> None:
     flood_file.touch()
 
     logger.info(" ==== launching serve.py")
-    with subprocess.Popen(
+    # TODO: is there some reason not to use an async process here?
+    with subprocess.Popen(  # noqa: ASYNC220
         [sys.executable, "-m", "chia._tests.core.server.serve", os.fspath(serve_file)],
     ):
         logger.info(" ====           serve.py running")
@@ -169,7 +172,8 @@ async def test_loop(tmp_path: pathlib.Path) -> None:
         await asyncio.sleep(adjusted_timeout(5))
 
         logger.info(" ==== launching flood.py")
-        with subprocess.Popen(
+        # TODO: is there some reason not to use an async process here?
+        with subprocess.Popen(  # noqa: ASYNC220
             [sys.executable, "-m", "chia._tests.core.server.flood", os.fspath(flood_file)],
         ):
             logger.info(" ====           flood.py running")
@@ -189,7 +193,7 @@ async def test_loop(tmp_path: pathlib.Path) -> None:
         try:
             logger.info(" ==== attempting a single new connection")
             with anyio.fail_after(delay=adjusted_timeout(1)):
-                reader, writer = await asyncio.open_connection(IP, PORT)
+                _reader, writer = await asyncio.open_connection(IP, PORT)
             logger.info(" ==== connection succeeded")
             post_connection_succeeded = True
         except (TimeoutError, ConnectionRefusedError) as e:
@@ -214,10 +218,10 @@ async def test_loop(tmp_path: pathlib.Path) -> None:
 
     over = []
     connection_limit = 25
-    accept_loop_count_over: List[int] = []
+    accept_loop_count_over: list[int] = []
     server_output_lines = serve_output.splitlines()
     found_shutdown = False
-    shutdown_lines: List[str] = []
+    shutdown_lines: list[str] = []
     for line in server_output_lines:
         if not found_shutdown:
             if not line.casefold().endswith("shutting down"):

chia/_tests/core/server/test_node_discovery.py

@@ -2,7 +2,6 @@ from __future__ import annotations
 
 from logging import Logger
 from pathlib import Path
-from typing import Tuple
 
 import pytest
 
@@ -15,7 +14,7 @@ from chia.util.default_root import SIMULATOR_ROOT_PATH
 
 @pytest.mark.anyio
 async def test_enable_private_networks(
-    two_nodes: Tuple[FullNodeAPI, FullNodeAPI, ChiaServer, ChiaServer, BlockTools],
+    two_nodes: tuple[FullNodeAPI, FullNodeAPI, ChiaServer, ChiaServer, BlockTools],
 ) -> None:
     chia_server = two_nodes[2]