ceph-devstack 0.1.0__py3-none-any.whl → 0.2.0__py3-none-any.whl

ceph_devstack/host.py

@@ -1,4 +1,5 @@
 import asyncio
+import json
 import logging
 import os
 import pathlib
@@ -74,12 +75,26 @@ class Host:
 
     def os_type(self) -> str:
         if not hasattr(self, "_os_type"):
-            proc = self.run(["bash", "-c", ". /etc/os-release && echo $ID"])
-            assert proc.stdout is not None
-            assert proc.wait() == 0, "is /etc/os-release missing?"
-            self._os_type = proc.stdout.read().decode().strip().lower()
+            proc = self.run(["uname"])
+            assert proc.wait() == 0, "uname doesn't work?!"
+            if (uname_str := proc.stdout.read().decode().strip().lower()) == "linux":
+                proc = self.run(["bash", "-c", ". /etc/os-release && echo $ID"])
+                assert proc.stdout is not None
+                assert proc.wait() == 0, "is /etc/os-release missing?"
+                self._os_type = proc.stdout.read().decode().strip().lower()
+            else:
+                self._os_type = uname_str
         return self._os_type
 
+    def package_manager(self) -> str | None:
+        if self.os_type in ["centos", "rhel", "alma", "rocky", "fedora"]:
+            return "dnf"
+        elif self.os_type in ["debian", "ubuntu"]:
+            return "apt"
+        elif self.os_type == "darwin":
+            return "brew"
+        raise RuntimeError("Can't determine package manager")
+
     async def podman_info(self, force: bool = False) -> Dict:
         if force or not hasattr(self, "_podman_info"):
             proc = await self.arun(["podman", "info"])
@@ -89,6 +104,13 @@ class Host:
             self._podman_info = yaml.safe_load(stdout.decode().strip())
         return self._podman_info
 
+    async def podman_machine_info(self) -> List[Dict]:
+        proc = await self.arun(["podman", "machine", "list", "--format", "json"])
+        assert proc.stdout is not None
+        await proc.wait()
+        stdout = await proc.stdout.read()
+        return json.loads(stdout)
+
     async def selinux_enforcing(self) -> bool:
         proc = await host.arun(["cat", "/sys/fs/selinux/enforce"])
         assert proc.stdout is not None

ceph_devstack/requirements.py

@@ -1,5 +1,4 @@
 import shlex
-import sys
 
 from pathlib import Path
 from packaging.version import parse as parse_version, Version
@@ -40,7 +39,7 @@ class FixableRequirement(Requirement):
 
     async def fix(self) -> bool:
         assert self.fix_cmd, "Attempted to fix without a fix command"
-        proc = await self.host.arun(self.fix_cmd)
+        proc = await self.host.arun(self.fix_cmd, stream_output=True)
         return await proc.wait() == 0
 
 
@@ -48,36 +47,49 @@ class LocalRequirement(Requirement):
     host = local_host
 
 
-class PodmanPlatform(Requirement):
+class LocalFixableRequirement(FixableRequirement):
+    host = local_host
+
+
+class PodmanPlatform(LocalFixableRequirement):
+    suggest_msg = "podman not found"
+
+    @property
+    def fix_cmd(self):
+        host_os = self.host.os_type()
+        if host_os == "darwin":
+            return ["brew", "install", "podman"]
+        return ["sudo", host.package_manager(), "install", "-y", "podman"]
+
     async def check(self):
-        result = False
         try:
-            podman_info = await self.host.podman_info()
+            await self.host.podman_info()
+            return True
         except FileNotFoundError:
             logger.error("podman not found. Try: dnf install podman")
             return False
-        try:
-            host_os = (
-                podman_info["host"].get("Os") or podman_info["host"]["os"]
-            ).lower()
-            if host_os == "linux":
-                result = True
-        except KeyError:
-            host_os = sys.platform.lower()
-            result = False
-            if sys.platform == "darwin":
-                logger.error(
-                    "The podman machine (VM) is not running. "
-                    "Try: podman machine init --now"
-                )
-            else:
-                logger.error(
-                    "Unknown error trying to query podman. Is podman installed?"
-                )
-            return result
-        if host_os != "linux":
-            logger.error("The platform '{host_os}' is not currently supported.")
-        return result
+
+
+class PodmanMachinePresent(FixableRequirement):
+    suggest_msg = "podman machine (VM) not present"
+    fix_cmd = ["podman", "machine", "init", "--now"]
+
+    async def check(self):
+        machine_infos = await host.podman_machine_info()
+        if machine_infos and (machine_info := machine_infos[-1]):
+            return machine_info.get("Created") is not None
+        return False
+
+
+class PodmanMachineRunning(LocalFixableRequirement):
+    suggest_msg = "podman machine (VM) not running"
+    fix_cmd = ["podman", "machine", "start"]
+
+    async def check(self):
+        machine_infos = await host.podman_machine_info()
+        if machine_infos and (machine_info := machine_infos[-1]):
+            return machine_info.get("Running", False)
+        return False
 
 
 class PodmanGraphDriver(Requirement):
@@ -150,6 +162,12 @@ class PodmanVersion(Requirement):
 
 
 class PodmanRuntime(Requirement):
+    @property
+    def fix_cmd(self):
+        if self.host.os_type() != "darwin":
+            return ["sudo", self.host.package_manager(), "install", "-y", "crun"]
+        return []
+
     async def check(self):
         podman_info = await self.host.podman_info()
         storage_conf_path = podman_info["store"]["configFile"]
@@ -194,22 +212,31 @@ class SysctlValue(FixableRequirement):
 class PodmanDNSPlugin(FixableRequirement):
     suggest_msg = "Could not find the podman DNS plugin"
 
-    def __init__(self):
+    @property
+    def dns_plugin_path(self):
+        os_type = self.host.os_type()
+        if os_type in ["ubuntu", "debian"]:
+            return "/usr/lib/cni/dnsname"
+        return "/usr/libexec/cni/dnsname"
+
+    @property
+    def check_cmd(self):
+        return ["test", "-x", self.dns_plugin_path]
+
+    @property
+    def fix_cmd(self):
         os_type = self.host.os_type()
         if os_type == "centos":
-            dns_plugin_path = "/usr/libexec/cni/dnsname"
-            self.check_cmd = ["test", "-x", dns_plugin_path]
-            self.fix_cmd = ["sudo", "dnf", "install", "-y", dns_plugin_path]
+            return ["sudo", "dnf", "install", "-y", self.dns_plugin_path]
         elif os_type in ["ubuntu", "debian"]:
-            dns_plugin_path = "/usr/lib/cni/dnsname"
-            self.check_cmd = ["test", "-x", dns_plugin_path]
-            self.fix_cmd = [
+            return [
                 "sudo",
                 "apt",
                 "install",
                 "-y",
                 "golang-github-containernetworking-plugin-dnsname",
             ]
+        return []
 
 
 class FuseOverlayfsPresence(FixableRequirement):
@@ -234,6 +261,11 @@ class AppArmorProfile(FixableRequirement):
 async def check_requirements():
     if not await PodmanPlatform().evaluate():
         return False
+    if local_host.os_type() == "darwin":
+        if not await PodmanMachinePresent().evaluate():
+            return False
+        if not await PodmanMachineRunning().evaluate():
+            return False
 
     result = True
     # kernel and podman versions for native overlay filesystem

{ceph_devstack-0.1.0.dist-info → ceph_devstack-0.2.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ceph-devstack
-Version: 0.1.0
+Version: 0.2.0
 Summary: Run a full teuthology lab on your laptop!
 Author-email: Zack Cerza <zack@cerza.org>
 License-Expression: MIT

{ceph_devstack-0.1.0.dist-info → ceph_devstack-0.2.0.dist-info}/RECORD

@@ -5,10 +5,10 @@ ceph_devstack/ceph_devstack.te,sha256=68i9sBb1TAEnCJn2JtyM-ECzPSuZck4vKoymcTbptX
 ceph_devstack/cli.py,sha256=lSYwXrwfP8D-k60XuwSqhwZSZNKJFFQfvRM-av1rePM,2057
 ceph_devstack/config.toml,sha256=HsxO3FhwZkHomde69QfElztuN8U1bxk7cQk1_iWB4w0,562
 ceph_devstack/exec.py,sha256=gn95GEQttB6xgdWXXvTsxUxcQsx9TUu6PC8QVQ0_Y7w,2674
-ceph_devstack/host.py,sha256=cShqi4FORP_cFTP2u33BYfhPpI0Nsd-bx9YLNfqBhUA,4556
+ceph_devstack/host.py,sha256=IRLhQaE_jl4VyHLArkqGzYWi3mxT8_sCG6Y7iDol4vU,5456
 ceph_devstack/logging.conf,sha256=bGlswYcL_fz522y9EoKZOLInrSss8D44glNq0FievFY,521
 ceph_devstack/py.typed,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-ceph_devstack/requirements.py,sha256=NgH0k8qU-cSvuZqp-TsM9CNiki2CsQKGuZM_vCq9SDQ,9192
+ceph_devstack/requirements.py,sha256=7Ashf6qfXW1k-L1Gakj5_Q-fPOBEhMQWnh0hIvtUjh0,9980
 ceph_devstack/resources/__init__.py,sha256=D0vhJBU9Pqslq7hg2qreW_ZhndcRIOHZVVUA0zAIeDM,3386
 ceph_devstack/resources/container.py,sha256=suJNOQ9fMRfCnXQwvEZOcg4jnPtrxb-d17a3Y1s1xG0,5388
 ceph_devstack/resources/misc.py,sha256=iGD_3Xsqako-dOZrHJFEJbMWoQIzy7Q_KkEnkdBb8m0,552
@@ -17,13 +17,13 @@ ceph_devstack/resources/ceph/containers.py,sha256=3QEwkh3I7f3r47SnlnMB-_mU8fYGR0
 ceph_devstack/resources/ceph/exceptions.py,sha256=C4ldyEA7Cukp-QUOwL-MnQ8kpgMDIQ6r_JQe0E9q4eM,101
 ceph_devstack/resources/ceph/requirements.py,sha256=ZJt7Eeb5y2bOc7dJN3-15ftAyySi80phD7erBsGdqSU,2691
 ceph_devstack/resources/ceph/utils.py,sha256=6-1sageEiLMcx53KHo_GKlIjaGw3swoZk8cQ-e-tDP0,1276
-ceph_devstack-0.1.0.dist-info/licenses/LICENSE,sha256=bFeYufyeS1qw0W8pkW1Wj09F2itqX7TAGTnA2NIpApU,1067
+ceph_devstack-0.2.0.dist-info/licenses/LICENSE,sha256=bFeYufyeS1qw0W8pkW1Wj09F2itqX7TAGTnA2NIpApU,1067
 tests/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/conftest.py,sha256=qulfsMZz3PyAFMdWQ_VWpOFT9L_BiavRax_yQF2Ne24,128
 tests/test_config.py,sha256=RLAjt9DAcAo8GQXgv9dc3Ka3hhtongMs6ioz5YQwKhY,4394
 tests/test_deep_merge.py,sha256=IP9zzCThmhVghl9XjAAiSrKsPdouH3KbEUaKq8n3Soc,2178
 tests/test_parse_args.py,sha256=2JDAT4Id88Ywl5QmiUHqq5IDGm_j5Yl3Kk7pbl3sOEk,7550
-tests/test_requirements_core.py,sha256=9IqpcbnatnFJrjp4_fb1arJ-nNO4KXdWjXNMzNzRjNk,18636
+tests/test_requirements_core.py,sha256=t7dE53E6N3owO1aHd0nLjXGZ9WDGFFUNIQKZQd1jJBY,19985
 tests/resources/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/resources/test_container.py,sha256=Xc4IGLf0PViSBIhUQXZHZQtRc-uI2R3PyNjU8lpX6BE,9081
 tests/resources/test_misc.py,sha256=dtOAPngMCTE9bYuYjNuxBiRaxvEibXuBq5VwVsWBdnY,1560
@@ -32,13 +32,13 @@ tests/resources/ceph/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hS
 tests/resources/ceph/test_cephdevstack_core.py,sha256=2Zopu-3TkXyj1amQbMG1KpsVXyRDJts73e6TLYNyz3Y,18340
 tests/resources/ceph/test_devstack.py,sha256=PRsEyYy9EKFIiZKkHYZh6vGffIzlZuW9jA9XEt7xz5M,6201
 tests/resources/ceph/test_env_vars.py,sha256=bLTcEJQJSQp0iiJBunPdGHtVQ94KRWSNEkK8HtXZQn0,2741
-tests/resources/ceph/test_requirements_ceph.py,sha256=R3oqC9wu5VXJfa4aWpRYOSPh8wt25RPVuUxhzuyCtSw,9548
+tests/resources/ceph/test_requirements_ceph.py,sha256=VLPHrzt1dLk3RnzjqRY3wyPUQbMspUuW6S_9cAWtpYU,9134
 tests/resources/ceph/test_ssh_keypair.py,sha256=M8Tc1CY9zb_1WaccMSfnSN35tyjR-CblNtTP0s4OsYU,4019
 tests/resources/ceph/test_testnode.py,sha256=wiftdOU058z9IKp5LeUNlv81U9XjojRUI0fYt8mrbgg,1253
 tests/resources/ceph/fixtures/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/resources/ceph/fixtures/testnode-config.toml,sha256=XaI4VACYHeshb7LLxN3viKBNxOBLOUpPuwlcQJyQO-U,44
-ceph_devstack-0.1.0.dist-info/METADATA,sha256=vRtYDGquw7pUJ45MTHe3HGf762f7UDUM-z5L7XxxGw4,6877
-ceph_devstack-0.1.0.dist-info/WHEEL,sha256=aeYiig01lYGDzBgS8HxWXOg3uV61G9ijOsup-k9o1sk,91
-ceph_devstack-0.1.0.dist-info/entry_points.txt,sha256=3cXOGOSb23ATcOZVQFBTY_imM4VFgFddXlYi-m8PA10,57
-ceph_devstack-0.1.0.dist-info/top_level.txt,sha256=NzTr-vAk2OWL08T8PsmfqkJZNEuezF5oaiHCMJBhHPM,20
-ceph_devstack-0.1.0.dist-info/RECORD,,
+ceph_devstack-0.2.0.dist-info/METADATA,sha256=6QrXrp1vvd4eAAtp8rmKlzPnh6FdyBD9HLBPW-thmjI,6877
+ceph_devstack-0.2.0.dist-info/WHEEL,sha256=aeYiig01lYGDzBgS8HxWXOg3uV61G9ijOsup-k9o1sk,91
+ceph_devstack-0.2.0.dist-info/entry_points.txt,sha256=3cXOGOSb23ATcOZVQFBTY_imM4VFgFddXlYi-m8PA10,57
+ceph_devstack-0.2.0.dist-info/top_level.txt,sha256=NzTr-vAk2OWL08T8PsmfqkJZNEuezF5oaiHCMJBhHPM,20
+ceph_devstack-0.2.0.dist-info/RECORD,,

tests/resources/ceph/test_requirements_ceph.py

@@ -216,15 +216,11 @@ class TestCephDevStackCheckRequirements:
             ) as MockLoopCtrlWrite,
             patch("ceph_devstack.host.host.selinux_enforcing") as mock_selinux,
         ):
-            mock_has_sudo = AsyncMock()
-            mock_has_sudo.evaluate = AsyncMock(return_value=True)
-            MockHasSudo.return_value = mock_has_sudo
-            mock_loop_ctrl = AsyncMock()
-            mock_loop_ctrl.evaluate = AsyncMock(return_value=True)
-            MockLoopCtrl.return_value = mock_loop_ctrl
-            mock_loop_ctrl_write = AsyncMock()
-            mock_loop_ctrl_write.evaluate = AsyncMock(return_value=True)
-            MockLoopCtrlWrite.return_value = mock_loop_ctrl_write
+            MockHasSudo.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockLoopCtrl.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockLoopCtrlWrite.return_value = AsyncMock(
+                evaluate=AsyncMock(return_value=True)
+            )
             mock_selinux.return_value = False
             result = await devstack.check_requirements()
             assert result is True
@@ -247,15 +243,11 @@ class TestCephDevStackCheckRequirements:
             patch("ceph_devstack.host.host.selinux_enforcing") as mock_selinux,
             patch("ceph_devstack.host.host.path_exists") as mock_path_exists,
         ):
-            mock_has_sudo = AsyncMock()
-            mock_has_sudo.evaluate = AsyncMock(return_value=True)
-            MockHasSudo.return_value = mock_has_sudo
-            mock_loop_ctrl = AsyncMock()
-            mock_loop_ctrl.evaluate = AsyncMock(return_value=True)
-            MockLoopCtrl.return_value = mock_loop_ctrl
-            mock_loop_ctrl_write = AsyncMock()
-            mock_loop_ctrl_write.evaluate = AsyncMock(return_value=True)
-            MockLoopCtrlWrite.return_value = mock_loop_ctrl_write
+            MockHasSudo.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockLoopCtrl.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockLoopCtrlWrite.return_value = AsyncMock(
+                evaluate=AsyncMock(return_value=True)
+            )
             mock_selinux.return_value = False
             mock_path_exists.return_value = False
             result = await devstack.check_requirements()

tests/test_requirements_core.py

@@ -1,7 +1,7 @@
 import asyncio
 import pytest
 from packaging.version import parse as parse_version
-from unittest.mock import AsyncMock, patch
+from unittest.mock import AsyncMock, MagicMock, patch
 
 
 from ceph_devstack import config, requirements
@@ -17,6 +17,11 @@ def req(cls):
     return cls()
 
 
+@pytest.fixture(scope="class", params=["centos", "ubuntu", "debian"])
+def os_type(request):
+    return request.param
+
+
 class TestRequirement:
     @pytest.fixture(scope="class")
     def cls(self):
@@ -113,6 +118,73 @@ class TestLocalRequirement:
         assert req.host == requirements.local_host
 
 
+class TestPodmanPlatform:
+    @pytest.fixture(scope="class")
+    def cls(self):
+        return requirements.PodmanPlatform
+
+    async def test_podman_present(self, cls):
+        with (
+            patch(
+                "ceph_devstack.requirements.PodmanPlatform.host.podman_info"
+            ) as MockPodmanInfo,
+            patch("ceph_devstack.requirements.local_host") as MockLocalHost,
+        ):
+            MockLocalHost.os_type = MagicMock(return_value="darwin")
+            MockPodmanInfo.return_value = {}
+            req = cls()
+            assert await req.check() is True
+
+    async def test_podman_missing(self, cls):
+        with (
+            patch(
+                "ceph_devstack.requirements.PodmanPlatform.host.podman_info"
+            ) as MockPodmanInfo,
+            patch("ceph_devstack.requirements.local_host") as MockLocalHost,
+        ):
+            MockLocalHost.os_type = MagicMock(return_value="darwin")
+            MockPodmanInfo.side_effect = FileNotFoundError
+            req = cls()
+            assert await req.check() is False
+
+
+class TestPodmanMachinePresent:
+    @pytest.fixture(scope="class")
+    def cls(self):
+        return requirements.PodmanMachinePresent
+
+    @pytest.mark.parametrize(
+        "info,success", [[{}, False], [{"Created": "some_timestamp"}, True]]
+    )
+    async def test_podman_machine_present(self, cls, info, success):
+        with patch("ceph_devstack.requirements.host", AsyncMock()) as MockHost:
+            MockHost.podman_machine_info = AsyncMock(return_value=[info])
+            req = cls()
+            assert await req.check() is success
+
+
+class TestPodmanMachineRunning:
+    @pytest.fixture(scope="class")
+    def cls(self):
+        return requirements.PodmanMachineRunning
+
+    @pytest.mark.parametrize(
+        "info,success",
+        [[{}, False], [{"Running": False}, False], [{"Running": True}, True]],
+    )
+    async def test_podman_machine_running(self, cls, info, success):
+        with patch("ceph_devstack.requirements.host", AsyncMock()) as MockHost:
+            MockHost.podman_machine_info = AsyncMock(return_value=[info])
+            req = cls()
+            assert await req.check() is success
+
+
+class TestPodmanRuntime:
+    @pytest.fixture(scope="class")
+    def cls(self):
+        return requirements.PodmanRuntime
+
+
 class TestPodmanVersionInit:
     @pytest.fixture(scope="class")
     def cls(self):
@@ -223,10 +295,6 @@ class TestPodmanDNSPluginInit:
     def cls(self):
         return requirements.PodmanDNSPlugin
 
-    @pytest.fixture(scope="class", params=["centos", "ubuntu", "debian"])
-    def os_type(self, request):
-        return request.param
-
     @pytest.fixture(scope="class")
     def dns_plugin_path(self, os_type):
         if os_type == "centos":
@@ -281,22 +349,25 @@ class TestCheckRequirements:
 
     async def test_check_requirements_returns_false_on_overlay_failure(self):
         with (
+            patch("ceph_devstack.requirements.local_host") as MockLocalHost,
             patch("ceph_devstack.requirements.PodmanPlatform") as MockPlatform,
             patch("ceph_devstack.requirements.PodmanGraphDriver") as MockGraph,
+            patch("ceph_devstack.requirements.PodmanVersion") as MockVersion,
+            patch("ceph_devstack.requirements.KernelVersionForOverlay") as MockKernel,
+            patch("ceph_devstack.requirements.CgroupV2") as MockCgroup,
         ):
-            mock_platform = AsyncMock()
-            mock_platform.evaluate = AsyncMock(return_value=True)
-            MockPlatform.return_value = mock_platform
-
-            mock_graph = AsyncMock()
-            mock_graph.evaluate = AsyncMock(return_value=False)
-            MockGraph.return_value = mock_graph
-
+            MockLocalHost.os_type = MagicMock(return_value="centos")
+            MockPlatform.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockGraph.return_value = AsyncMock(evaluate=AsyncMock(return_value=False))
+            MockVersion.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernel.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockCgroup.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
             result = await requirements.check_requirements()
             assert result is False
 
     async def test_check_requirements_returns_true_when_all_pass(self):
         with (
+            patch("ceph_devstack.requirements.local_host") as MockLocalHost,
             patch("ceph_devstack.requirements.PodmanPlatform") as MockPlatform,
             patch("ceph_devstack.requirements.PodmanGraphDriver") as MockGraph,
             patch("ceph_devstack.requirements.PodmanVersion") as MockVersion,
@@ -309,45 +380,24 @@ class TestCheckRequirements:
             patch("ceph_devstack.requirements.host.selinux_enforcing") as mock_selinux,
             patch("ceph_devstack.requirements.SysctlValue") as MockSysctl,
         ):
-            mock_platform = AsyncMock()
-            mock_platform.evaluate = AsyncMock(return_value=True)
-            MockPlatform.return_value = mock_platform
-
-            mock_graph = AsyncMock()
-            mock_graph.evaluate = AsyncMock(return_value=True)
-            MockGraph.return_value = mock_graph
-
-            mock_version = AsyncMock()
-            mock_version.evaluate = AsyncMock(return_value=True)
-            MockVersion.return_value = mock_version
-
-            mock_kernel = AsyncMock()
-            mock_kernel.evaluate = AsyncMock(return_value=True)
-            MockKernel.return_value = mock_kernel
-
-            mock_cgroup = AsyncMock()
-            mock_cgroup.evaluate = AsyncMock(return_value=True)
-            MockCgroup.return_value = mock_cgroup
-
-            mock_kernel_cgroup = AsyncMock()
-            mock_kernel_cgroup.evaluate = AsyncMock(return_value=True)
-            MockKernelCgroup.return_value = mock_kernel_cgroup
-
-            mock_runtime = AsyncMock()
-            mock_runtime.evaluate = AsyncMock(return_value=True)
-            MockRuntime.return_value = mock_runtime
-
+            MockLocalHost.os_type = MagicMock(return_value="centos")
+            MockPlatform.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockGraph.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockVersion.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernel.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockCgroup.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernelCgroup.return_value = AsyncMock(
+                evaluate=AsyncMock(return_value=True)
+            )
+            MockRuntime.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
             mock_selinux.return_value = False
-
-            mock_sysctl = AsyncMock()
-            mock_sysctl.evaluate = AsyncMock(return_value=True)
-            MockSysctl.return_value = mock_sysctl
-
+            MockSysctl.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
             result = await requirements.check_requirements()
             assert result is True
 
     async def test_check_requirements_returns_false_on_runtime_failure(self):
         with (
+            patch("ceph_devstack.requirements.local_host") as MockLocalHost,
             patch("ceph_devstack.requirements.PodmanPlatform") as MockPlatform,
             patch("ceph_devstack.requirements.PodmanGraphDriver") as MockGraph,
             patch("ceph_devstack.requirements.PodmanVersion") as MockVersion,
@@ -359,43 +409,26 @@ class TestCheckRequirements:
             patch("ceph_devstack.requirements.PodmanRuntime") as MockRuntime,
             patch("ceph_devstack.requirements.host.selinux_enforcing") as mock_selinux,
         ):
-            mock_platform = AsyncMock()
-            mock_platform.evaluate = AsyncMock(return_value=True)
-            MockPlatform.return_value = mock_platform
-
-            mock_graph = AsyncMock()
-            mock_graph.evaluate = AsyncMock(return_value=True)
-            MockGraph.return_value = mock_graph
-
-            mock_version = AsyncMock()
-            mock_version.evaluate = AsyncMock(return_value=True)
-            MockVersion.return_value = mock_version
-
-            mock_kernel = AsyncMock()
-            mock_kernel.evaluate = AsyncMock(return_value=True)
-            MockKernel.return_value = mock_kernel
-
-            mock_cgroup = AsyncMock()
-            mock_cgroup.evaluate = AsyncMock(return_value=True)
-            MockCgroup.return_value = mock_cgroup
-
+            MockLocalHost.os_type = MagicMock(return_value="centos")
+            MockPlatform.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockGraph.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockVersion.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernel.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockCgroup.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
             mock_kernel_cgroup = AsyncMock()
             mock_kernel_cgroup.evaluate = AsyncMock(return_value=True)
             MockKernelCgroup.return_value = mock_kernel_cgroup
-
-            mock_runtime = AsyncMock()
-            mock_runtime.evaluate = AsyncMock(return_value=False)
-            MockRuntime.return_value = mock_runtime
-
+            MockRuntime.return_value = AsyncMock(evaluate=AsyncMock(return_value=False))
             mock_selinux.return_value = False
-
             result = await requirements.check_requirements()
             assert result is False
 
     async def test_check_requirements_returns_false_on_selinux_bool_failure(self):
         with (
+            patch("ceph_devstack.requirements.local_host") as MockLocalHost,
             patch("ceph_devstack.requirements.PodmanPlatform") as MockPlatform,
             patch("ceph_devstack.requirements.PodmanGraphDriver") as MockGraph,
+            patch("ceph_devstack.requirements.PodmanVersion") as MockVersion,
             patch("ceph_devstack.requirements.KernelVersionForOverlay") as MockKernel,
             patch("ceph_devstack.requirements.CgroupV2") as MockCgroup,
             patch(
@@ -405,46 +438,26 @@ class TestCheckRequirements:
             patch("ceph_devstack.requirements.host.selinux_enforcing") as mock_selinux,
             patch("ceph_devstack.requirements.SELinuxBoolean") as MockSELinuxBoolean,
         ):
-            mock_platform = AsyncMock()
-            mock_platform.evaluate = AsyncMock(return_value=True)
-            MockPlatform.return_value = mock_platform
-
-            mock_graph = AsyncMock()
-            mock_graph.evaluate = AsyncMock(return_value=True)
-            MockGraph.return_value = mock_graph
-
-            with patch("ceph_devstack.requirements.PodmanVersion") as MockVersion:
-                mock_version = AsyncMock()
-                mock_version.evaluate = AsyncMock(return_value=True)
-                MockVersion.return_value = mock_version
-
-                mock_kernel = AsyncMock()
-                mock_kernel.evaluate = AsyncMock(return_value=True)
-                MockKernel.return_value = mock_kernel
-
-                mock_cgroup = AsyncMock()
-                mock_cgroup.evaluate = AsyncMock(return_value=True)
-                MockCgroup.return_value = mock_cgroup
-
-                mock_kernel_cgroup = AsyncMock()
-                mock_kernel_cgroup.evaluate = AsyncMock(return_value=True)
-                MockKernelCgroup.return_value = mock_kernel_cgroup
-
-                mock_runtime = AsyncMock()
-                mock_runtime.evaluate = AsyncMock(return_value=True)
-                MockRuntime.return_value = mock_runtime
-
-                mock_selinux.return_value = True
-
-                mock_sel = AsyncMock()
-                mock_sel.evaluate = AsyncMock(return_value=False)
-                MockSELinuxBoolean.return_value = mock_sel
-
-                result = await requirements.check_requirements()
-                assert result is False
+            MockLocalHost.os_type = MagicMock(return_value="centos")
+            MockPlatform.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockGraph.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockVersion.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernel.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockCgroup.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernelCgroup.return_value = AsyncMock(
+                evaluate=AsyncMock(return_value=True)
+            )
+            MockRuntime.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            mock_selinux.return_value = True
+            MockSELinuxBoolean.return_value = AsyncMock(
+                evaluate=AsyncMock(return_value=False)
+            )
+            result = await requirements.check_requirements()
+            assert result is False
 
     async def test_check_requirements_returns_false_on_sysctl_failure(self):
         with (
+            patch("ceph_devstack.requirements.local_host") as MockLocalHost,
             patch("ceph_devstack.requirements.PodmanPlatform") as MockPlatform,
             patch("ceph_devstack.requirements.PodmanGraphDriver") as MockGraph,
             patch("ceph_devstack.requirements.PodmanVersion") as MockVersion,
@@ -457,39 +470,17 @@ class TestCheckRequirements:
             patch("ceph_devstack.requirements.host.selinux_enforcing") as mock_selinux,
             patch("ceph_devstack.requirements.SysctlValue") as MockSysctl,
         ):
-            mock_platform = AsyncMock()
-            mock_platform.evaluate = AsyncMock(return_value=True)
-            MockPlatform.return_value = mock_platform
-
-            mock_graph = AsyncMock()
-            mock_graph.evaluate = AsyncMock(return_value=True)
-            MockGraph.return_value = mock_graph
-
-            mock_version = AsyncMock()
-            mock_version.evaluate = AsyncMock(return_value=True)
-            MockVersion.return_value = mock_version
-
-            mock_kernel = AsyncMock()
-            mock_kernel.evaluate = AsyncMock(return_value=True)
-            MockKernel.return_value = mock_kernel
-
-            mock_cgroup = AsyncMock()
-            mock_cgroup.evaluate = AsyncMock(return_value=True)
-            MockCgroup.return_value = mock_cgroup
-
-            mock_kernel_cgroup = AsyncMock()
-            mock_kernel_cgroup.evaluate = AsyncMock(return_value=True)
-            MockKernelCgroup.return_value = mock_kernel_cgroup
-
-            mock_runtime = AsyncMock()
-            mock_runtime.evaluate = AsyncMock(return_value=True)
-            MockRuntime.return_value = mock_runtime
-
+            MockLocalHost.os_type = MagicMock(return_value="centos")
+            MockPlatform.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockGraph.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockVersion.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernel.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockCgroup.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
+            MockKernelCgroup.return_value = AsyncMock(
+                evaluate=AsyncMock(return_value=True)
+            )
+            MockRuntime.return_value = AsyncMock(evaluate=AsyncMock(return_value=True))
             mock_selinux.return_value = False
-
-            mock_sysctl = AsyncMock()
-            mock_sysctl.evaluate = AsyncMock(return_value=False)
-            MockSysctl.return_value = mock_sysctl
-
+            MockSysctl.return_value = AsyncMock(evaluate=AsyncMock(return_value=False))
             result = await requirements.check_requirements()
             assert result is False