cartography 0.102.0rc1__py3-none-any.whl → 0.103.0__py3-none-any.whl

cartography/intel/gcp/crm.py

@@ -27,9 +27,12 @@ def get_gcp_organizations(crm_v1: Resource) -> List[Resource]:
     try:
         req = crm_v1.organizations().search(body={})
         res = req.execute()
-        return res.get('organizations', [])
+        return res.get("organizations", [])
     except HttpError as e:
-        logger.warning("HttpError occurred in crm.get_gcp_organizations(), returning empty list. Details: %r", e)
+        logger.warning(
+            "HttpError occurred in crm.get_gcp_organizations(), returning empty list. Details: %r",
+            e,
+        )
         return []
 
 
@@ -45,9 +48,12 @@ def get_gcp_folders(crm_v2: Resource) -> List[Resource]:
     try:
         req = crm_v2.folders().search(body={})
         res = req.execute()
-        return res.get('folders', [])
+        return res.get("folders", [])
     except HttpError as e:
-        logger.warning("HttpError occurred in crm.get_gcp_folders(), returning empty list. Details: %r", e)
+        logger.warning(
+            "HttpError occurred in crm.get_gcp_folders(), returning empty list. Details: %r",
+            e,
+        )
         return []
 
 
@@ -65,17 +71,27 @@ def get_gcp_projects(crm_v1: Resource) -> List[Resource]:
         req = crm_v1.projects().list(filter="lifecycleState:ACTIVE")
         while req is not None:
             res = req.execute()
-            page = res.get('projects', [])
+            page = res.get("projects", [])
             projects.extend(page)
-            req = crm_v1.projects().list_next(previous_request=req, previous_response=res)
+            req = crm_v1.projects().list_next(
+                previous_request=req,
+                previous_response=res,
+            )
         return projects
     except HttpError as e:
-        logger.warning("HttpError occurred in crm.get_gcp_projects(), returning empty list. Details: %r", e)
+        logger.warning(
+            "HttpError occurred in crm.get_gcp_projects(), returning empty list. Details: %r",
+            e,
+        )
         return []
 
 
 @timeit
-def load_gcp_organizations(neo4j_session: neo4j.Session, data: List[Dict], gcp_update_tag: int) -> None:
+def load_gcp_organizations(
+    neo4j_session: neo4j.Session,
+    data: List[Dict],
+    gcp_update_tag: int,
+) -> None:
     """
     Ingest the GCP organizations to Neo4j
     :param neo4j_session: The Neo4j session
@@ -94,15 +110,19 @@ def load_gcp_organizations(neo4j_session: neo4j.Session, data: List[Dict], gcp_u
     for org_object in data:
         neo4j_session.run(
             query,
-            OrgName=org_object['name'],
-            DisplayName=org_object.get('displayName', None),
-            LifecycleState=org_object.get('lifecycleState', None),
+            OrgName=org_object["name"],
+            DisplayName=org_object.get("displayName", None),
+            LifecycleState=org_object.get("lifecycleState", None),
             gcp_update_tag=gcp_update_tag,
         )
 
 
 @timeit
-def load_gcp_folders(neo4j_session: neo4j.Session, data: List[Dict], gcp_update_tag: int) -> None:
+def load_gcp_folders(
+    neo4j_session: neo4j.Session,
+    data: List[Dict],
+    gcp_update_tag: int,
+) -> None:
     """
     Ingest the GCP folders to Neo4j
     :param neo4j_session: The Neo4j session
@@ -114,9 +134,9 @@ def load_gcp_folders(neo4j_session: neo4j.Session, data: List[Dict], gcp_update_
         # Get the correct parent type.
         # Parents of folders can only be GCPOrganizations or other folders, see
         # https://cloud.google.com/resource-manager/docs/cloud-platform-resource-hierarchy
-        if folder['parent'].startswith("organizations"):
+        if folder["parent"].startswith("organizations"):
             query = "MATCH (parent:GCPOrganization{id:$ParentId})"
-        elif folder['parent'].startswith("folders"):
+        elif folder["parent"].startswith("folders"):
             query = """
             MERGE (parent:GCPFolder{id:$ParentId})
             ON CREATE SET parent.firstseen = timestamp()
@@ -135,16 +155,20 @@ def load_gcp_folders(neo4j_session: neo4j.Session, data: List[Dict], gcp_update_
         """
         neo4j_session.run(
             query,
-            ParentId=folder['parent'],
-            FolderName=folder['name'],
-            DisplayName=folder.get('displayName', None),
-            LifecycleState=folder.get('lifecycleState', None),
+            ParentId=folder["parent"],
+            FolderName=folder["name"],
+            DisplayName=folder.get("displayName", None),
+            LifecycleState=folder.get("lifecycleState", None),
             gcp_update_tag=gcp_update_tag,
         )
 
 
 @timeit
-def load_gcp_projects(neo4j_session: neo4j.Session, data: List[Dict], gcp_update_tag: int) -> None:
+def load_gcp_projects(
+    neo4j_session: neo4j.Session,
+    data: List[Dict],
+    gcp_update_tag: int,
+) -> None:
     """
     Ingest the GCP projects to Neo4j
     :param neo4j_session: The Neo4j session
@@ -165,35 +189,40 @@ def load_gcp_projects(neo4j_session: neo4j.Session, data: List[Dict], gcp_update
     for project in data:
         neo4j_session.run(
             query,
-            ProjectId=project['projectId'],
-            ProjectNumber=project['projectNumber'],
-            DisplayName=project.get('name', None),
-            LifecycleState=project.get('lifecycleState', None),
+            ProjectId=project["projectId"],
+            ProjectNumber=project["projectNumber"],
+            DisplayName=project.get("name", None),
+            LifecycleState=project.get("lifecycleState", None),
             gcp_update_tag=gcp_update_tag,
         )
-        if project.get('parent'):
+        if project.get("parent"):
             _attach_gcp_project_parent(neo4j_session, project, gcp_update_tag)
 
 
 @timeit
-def _attach_gcp_project_parent(neo4j_session: neo4j.Session, project: Dict, gcp_update_tag: int) -> None:
+def _attach_gcp_project_parent(
+    neo4j_session: neo4j.Session,
+    project: Dict,
+    gcp_update_tag: int,
+) -> None:
     """
     Attach a project to its respective parent, as in the Resource Hierarchy -
     https://cloud.google.com/resource-manager/docs/cloud-platform-resource-hierarchy
     """
-    if project['parent']['type'] == 'organization':
-        parent_label = 'GCPOrganization'
-    elif project['parent']['type'] == 'folder':
-        parent_label = 'GCPFolder'
+    if project["parent"]["type"] == "organization":
+        parent_label = "GCPOrganization"
+    elif project["parent"]["type"] == "folder":
+        parent_label = "GCPFolder"
     else:
         raise NotImplementedError(
             "Ingestion of GCP {}s as parent nodes is currently not supported. "
-            "Please file an issue at https://github.com/lyft/cartography/issues.".format(
-                project['parent']['type'],
+            "Please file an issue at https://github.com/cartography-cncf/cartography/issues.".format(
+                project["parent"]["type"],
             ),
         )
     parent_id = f"{project['parent']['type']}s/{project['parent']['id']}"
-    INGEST_PARENT_TEMPLATE = Template("""
+    INGEST_PARENT_TEMPLATE = Template(
+        """
     MATCH (project:GCPProject{id:$ProjectId})
 
     MERGE (parent:$parent_label{id:$ParentId})
@@ -202,51 +231,71 @@ def _attach_gcp_project_parent(neo4j_session: neo4j.Session, project: Dict, gcp_
     MERGE (parent)-[r:RESOURCE]->(project)
     ON CREATE SET r.firstseen = timestamp()
     SET r.lastupdated = $gcp_update_tag
-    """)
+    """,
+    )
     neo4j_session.run(
         INGEST_PARENT_TEMPLATE.safe_substitute(parent_label=parent_label),
         ParentId=parent_id,
-        ProjectId=project['projectId'],
+        ProjectId=project["projectId"],
         gcp_update_tag=gcp_update_tag,
     )
 
 
 @timeit
-def cleanup_gcp_organizations(neo4j_session: neo4j.Session, common_job_parameters: Dict) -> None:
+def cleanup_gcp_organizations(
+    neo4j_session: neo4j.Session,
+    common_job_parameters: Dict,
+) -> None:
     """
     Remove stale GCP organizations and their relationships
     :param neo4j_session: The Neo4j session
     :param common_job_parameters: Parameters to carry to the cleanup job
     :return: Nothing
     """
-    run_cleanup_job('gcp_crm_organization_cleanup.json', neo4j_session, common_job_parameters)
+    run_cleanup_job(
+        "gcp_crm_organization_cleanup.json",
+        neo4j_session,
+        common_job_parameters,
+    )
 
 
 @timeit
-def cleanup_gcp_folders(neo4j_session: neo4j.Session, common_job_parameters: Dict) -> None:
+def cleanup_gcp_folders(
+    neo4j_session: neo4j.Session,
+    common_job_parameters: Dict,
+) -> None:
     """
     Remove stale GCP folders and their relationships
     :param neo4j_session: The Neo4j session
     :param common_job_parameters: Parameters to carry to the cleanup job
     :return: Nothing
     """
-    run_cleanup_job('gcp_crm_folder_cleanup.json', neo4j_session, common_job_parameters)
+    run_cleanup_job("gcp_crm_folder_cleanup.json", neo4j_session, common_job_parameters)
 
 
 @timeit
-def cleanup_gcp_projects(neo4j_session: neo4j.Session, common_job_parameters: Dict) -> None:
+def cleanup_gcp_projects(
+    neo4j_session: neo4j.Session,
+    common_job_parameters: Dict,
+) -> None:
     """
     Remove stale GCP projects and their relationships
     :param neo4j_session: The Neo4j session
     :param common_job_parameters: Parameters to carry to the cleanup job
     :return: Nothing
     """
-    run_cleanup_job('gcp_crm_project_cleanup.json', neo4j_session, common_job_parameters)
+    run_cleanup_job(
+        "gcp_crm_project_cleanup.json",
+        neo4j_session,
+        common_job_parameters,
+    )
 
 
 @timeit
 def sync_gcp_organizations(
-    neo4j_session: neo4j.Session, crm_v1: Resource, gcp_update_tag: int,
+    neo4j_session: neo4j.Session,
+    crm_v1: Resource,
+    gcp_update_tag: int,
     common_job_parameters: Dict,
 ) -> None:
     """
@@ -266,7 +315,9 @@ def sync_gcp_organizations(
 
 @timeit
 def sync_gcp_folders(
-    neo4j_session: neo4j.Session, crm_v2: Resource, gcp_update_tag: int,
+    neo4j_session: neo4j.Session,
+    crm_v2: Resource,
+    gcp_update_tag: int,
     common_job_parameters: Dict,
 ) -> None:
     """
@@ -286,7 +337,9 @@ def sync_gcp_folders(
 
 @timeit
 def sync_gcp_projects(
-    neo4j_session: neo4j.Session, projects: List[Dict], gcp_update_tag: int,
+    neo4j_session: neo4j.Session,
+    projects: List[Dict],
+    gcp_update_tag: int,
     common_job_parameters: Dict,
 ) -> None:
     """

cartography/intel/gcp/dns.py

@@ -32,17 +32,26 @@ def get_dns_zones(dns: Resource, project_id: str) -> List[Resource]:
         request = dns.managedZones().list(project=project_id)
         while request is not None:
             response = request.execute()
-            for managed_zone in response['managedZones']:
+            for managed_zone in response["managedZones"]:
                 zones.append(managed_zone)
-            request = dns.managedZones().list_next(previous_request=request, previous_response=response)
+            request = dns.managedZones().list_next(
+                previous_request=request,
+                previous_response=response,
+            )
         return zones
     except HttpError as e:
-        err = json.loads(e.content.decode('utf-8'))['error']
-        if err.get('status', '') == 'PERMISSION_DENIED' or err.get('message', '') == 'Forbidden':
+        err = json.loads(e.content.decode("utf-8"))["error"]
+        if (
+            err.get("status", "") == "PERMISSION_DENIED"
+            or err.get("message", "") == "Forbidden"
+        ):
             logger.warning(
                 (
                     "Could not retrieve DNS zones on project %s due to permissions issues. Code: %s, Message: %s"
-                ), project_id, err['code'], err['message'],
+                ),
+                project_id,
+                err["code"],
+                err["message"],
             )
             return []
         else:
@@ -50,7 +59,11 @@ def get_dns_zones(dns: Resource, project_id: str) -> List[Resource]:
 
 
 @timeit
-def get_dns_rrs(dns: Resource, dns_zones: List[Dict], project_id: str) -> List[Resource]:
+def get_dns_rrs(
+    dns: Resource,
+    dns_zones: List[Dict],
+    project_id: str,
+) -> List[Resource]:
     """
     Returns a list of DNS Resource Record Sets within the given project.
 
@@ -69,21 +82,33 @@ def get_dns_rrs(dns: Resource, dns_zones: List[Dict], project_id: str) -> List[R
     try:
         rrs: List[Resource] = []
         for zone in dns_zones:
-            request = dns.resourceRecordSets().list(project=project_id, managedZone=zone['id'])
+            request = dns.resourceRecordSets().list(
+                project=project_id,
+                managedZone=zone["id"],
+            )
             while request is not None:
                 response = request.execute()
-                for resource_record_set in response['rrsets']:
-                    resource_record_set['zone'] = zone['id']
+                for resource_record_set in response["rrsets"]:
+                    resource_record_set["zone"] = zone["id"]
                     rrs.append(resource_record_set)
-                request = dns.resourceRecordSets().list_next(previous_request=request, previous_response=response)
+                request = dns.resourceRecordSets().list_next(
+                    previous_request=request,
+                    previous_response=response,
+                )
         return rrs
     except HttpError as e:
-        err = json.loads(e.content.decode('utf-8'))['error']
-        if err.get('status', '') == 'PERMISSION_DENIED' or err.get('message', '') == 'Forbidden':
+        err = json.loads(e.content.decode("utf-8"))["error"]
+        if (
+            err.get("status", "") == "PERMISSION_DENIED"
+            or err.get("message", "") == "Forbidden"
+        ):
             logger.warning(
                 (
                     "Could not retrieve DNS RRS on project %s due to permissions issues. Code: %s, Message: %s"
-                ), project_id, err['code'], err['message'],
+                ),
+                project_id,
+                err["code"],
+                err["message"],
             )
             return []
         else:
@@ -92,7 +117,12 @@ def get_dns_rrs(dns: Resource, dns_zones: List[Dict], project_id: str) -> List[R
 
 
 @timeit
-def load_dns_zones(neo4j_session: neo4j.Session, dns_zones: List[Dict], project_id: str, gcp_update_tag: int) -> None:
+def load_dns_zones(
+    neo4j_session: neo4j.Session,
+    dns_zones: List[Dict],
+    project_id: str,
+    gcp_update_tag: int,
+) -> None:
     """
     Ingest GCP DNS Zones into Neo4j
 
@@ -142,7 +172,12 @@ def load_dns_zones(neo4j_session: neo4j.Session, dns_zones: List[Dict], project_
 
 
 @timeit
-def load_rrs(neo4j_session: neo4j.Session, dns_rrs: List[Resource], project_id: str, gcp_update_tag: int) -> None:
+def load_rrs(
+    neo4j_session: neo4j.Session,
+    dns_rrs: List[Resource],
+    project_id: str,
+    gcp_update_tag: int,
+) -> None:
     """
     Ingest GCP RRS into Neo4j
 
@@ -188,7 +223,10 @@ def load_rrs(neo4j_session: neo4j.Session, dns_rrs: List[Resource], project_id:
 
 
 @timeit
-def cleanup_dns_records(neo4j_session: neo4j.Session, common_job_parameters: Dict) -> None:
+def cleanup_dns_records(
+    neo4j_session: neo4j.Session,
+    common_job_parameters: Dict,
+) -> None:
     """
     Delete out-of-date GCP DNS Zones and RRS nodes and relationships
 
@@ -201,12 +239,15 @@ def cleanup_dns_records(neo4j_session: neo4j.Session, common_job_parameters: Dic
     :rtype: NoneType
     :return: Nothing
     """
-    run_cleanup_job('gcp_dns_cleanup.json', neo4j_session, common_job_parameters)
+    run_cleanup_job("gcp_dns_cleanup.json", neo4j_session, common_job_parameters)
 
 
 @timeit
 def sync(
-    neo4j_session: neo4j.Session, dns: Resource, project_id: str, gcp_update_tag: int,
+    neo4j_session: neo4j.Session,
+    dns: Resource,
+    project_id: str,
+    gcp_update_tag: int,
     common_job_parameters: Dict,
 ) -> None:
     """
@@ -237,5 +278,5 @@ def sync(
     # RECORD SETS
     dns_rrs = get_dns_rrs(dns, dns_zones, project_id)
     load_rrs(neo4j_session, dns_rrs, project_id, gcp_update_tag)
-    # TODO scope the cleanup to the current project - https://github.com/lyft/cartography/issues/381
+    # TODO scope the cleanup to the current project - https://github.com/cartography-cncf/cartography/issues/381
     cleanup_dns_records(neo4j_session, common_job_parameters)

cartography/intel/gcp/gke.py

@@ -8,6 +8,7 @@ from googleapiclient.discovery import Resource
 
 from cartography.util import run_cleanup_job
 from cartography.util import timeit
+
 logger = logging.getLogger(__name__)
 
 
@@ -26,16 +27,21 @@ def get_gke_clusters(container: Resource, project_id: str) -> Dict:
     :return: Cluster response object
     """
     try:
-        req = container.projects().zones().clusters().list(projectId=project_id, zone='-')
+        req = (
+            container.projects().zones().clusters().list(projectId=project_id, zone="-")
+        )
         res = req.execute()
         return res
     except HttpError as e:
-        err = json.loads(e.content.decode('utf-8'))['error']
-        if err['status'] == 'PERMISSION_DENIED':
+        err = json.loads(e.content.decode("utf-8"))["error"]
+        if err["status"] == "PERMISSION_DENIED":
             logger.warning(
                 (
                     "Could not retrieve GKE clusters on project %s due to permissions issue. Code: %s, Message: %s"
-                ), project_id, err['code'], err['message'],
+                ),
+                project_id,
+                err["code"],
+                err["message"],
             )
             return {}
         else:
@@ -43,7 +49,12 @@ def get_gke_clusters(container: Resource, project_id: str) -> Dict:
 
 
 @timeit
-def load_gke_clusters(neo4j_session: neo4j.Session, cluster_resp: Dict, project_id: str, gcp_update_tag: int) -> None:
+def load_gke_clusters(
+    neo4j_session: neo4j.Session,
+    cluster_resp: Dict,
+    project_id: str,
+    gcp_update_tag: int,
+) -> None:
     """
     Ingest GCP GKE Clusters to Neo4j
 
@@ -98,37 +109,50 @@ def load_gke_clusters(neo4j_session: neo4j.Session, cluster_resp: Dict, project_
     ON CREATE SET r.firstseen = timestamp()
     SET r.lastupdated = $gcp_update_tag
     """
-    for cluster in cluster_resp.get('clusters', []):
+    for cluster in cluster_resp.get("clusters", []):
         neo4j_session.run(
             query,
             ProjectId=project_id,
-            ClusterSelfLink=cluster['selfLink'],
-            ClusterCreateTime=cluster['createTime'],
-            ClusterName=cluster['name'],
-            ClusterDescription=cluster.get('description'),
-            ClusterLoggingService=cluster.get('loggingService'),
-            ClusterMonitoringService=cluster.get('monitoringService'),
-            ClusterNetwork=cluster.get('network'),
-            ClusterSubnetwork=cluster.get('subnetwork'),
-            ClusterIPv4Cidr=cluster.get('clusterIpv4Cidr'),
-            ClusterZone=cluster.get('zone'),
-            ClusterLocation=cluster.get('location'),
-            ClusterEndpoint=cluster.get('endpoint'),
-            ClusterInitialVersion=cluster.get('initialClusterVersion'),
-            ClusterMasterVersion=cluster.get('currentMasterVersion'),
-            ClusterStatus=cluster.get('status'),
-            ClusterServicesIPv4Cidr=cluster.get('servicesIpv4Cidr'),
-            ClusterDatabaseEncryption=cluster.get('databaseEncryption', {}).get('state'),
+            ClusterSelfLink=cluster["selfLink"],
+            ClusterCreateTime=cluster["createTime"],
+            ClusterName=cluster["name"],
+            ClusterDescription=cluster.get("description"),
+            ClusterLoggingService=cluster.get("loggingService"),
+            ClusterMonitoringService=cluster.get("monitoringService"),
+            ClusterNetwork=cluster.get("network"),
+            ClusterSubnetwork=cluster.get("subnetwork"),
+            ClusterIPv4Cidr=cluster.get("clusterIpv4Cidr"),
+            ClusterZone=cluster.get("zone"),
+            ClusterLocation=cluster.get("location"),
+            ClusterEndpoint=cluster.get("endpoint"),
+            ClusterInitialVersion=cluster.get("initialClusterVersion"),
+            ClusterMasterVersion=cluster.get("currentMasterVersion"),
+            ClusterStatus=cluster.get("status"),
+            ClusterServicesIPv4Cidr=cluster.get("servicesIpv4Cidr"),
+            ClusterDatabaseEncryption=cluster.get("databaseEncryption", {}).get(
+                "state",
+            ),
             ClusterNetworkPolicy=_process_network_policy(cluster),
-            ClusterMasterAuthorizedNetworks=cluster.get('masterAuthorizedNetworksConfig', {}).get('enabled'),
-            ClusterAbac=cluster.get('legacyAbac', {}).get('enabled'),
-            ClusterShieldedNodes=cluster.get('shieldedNodes', {}).get('enabled'),
-            ClusterPrivateNodes=cluster.get('privateClusterConfig', {}).get('enablePrivateNodes'),
-            ClusterPrivateEndpointEnabled=cluster.get('privateClusterConfig', {}).get('enablePrivateEndpoint'),
-            ClusterPrivateEndpoint=cluster.get('privateClusterConfig', {}).get('privateEndpoint'),
-            ClusterPublicEndpoint=cluster.get('privateClusterConfig', {}).get('publicEndpoint'),
-            ClusterMasterUsername=cluster.get('masterAuth', {}).get('username'),
-            ClusterMasterPassword=cluster.get('masterAuth', {}).get('password'),
+            ClusterMasterAuthorizedNetworks=cluster.get(
+                "masterAuthorizedNetworksConfig",
+                {},
+            ).get("enabled"),
+            ClusterAbac=cluster.get("legacyAbac", {}).get("enabled"),
+            ClusterShieldedNodes=cluster.get("shieldedNodes", {}).get("enabled"),
+            ClusterPrivateNodes=cluster.get("privateClusterConfig", {}).get(
+                "enablePrivateNodes",
+            ),
+            ClusterPrivateEndpointEnabled=cluster.get("privateClusterConfig", {}).get(
+                "enablePrivateEndpoint",
+            ),
+            ClusterPrivateEndpoint=cluster.get("privateClusterConfig", {}).get(
+                "privateEndpoint",
+            ),
+            ClusterPublicEndpoint=cluster.get("privateClusterConfig", {}).get(
+                "publicEndpoint",
+            ),
+            ClusterMasterUsername=cluster.get("masterAuth", {}).get("username"),
+            ClusterMasterPassword=cluster.get("masterAuth", {}).get("password"),
             gcp_update_tag=gcp_update_tag,
         )
 
@@ -138,15 +162,18 @@ def _process_network_policy(cluster: Dict) -> bool:
     Parse cluster.networkPolicy to verify if
     the provider has been enabled.
     """
-    provider = cluster.get('networkPolicy', {}).get('provider')
-    enabled = cluster.get('networkPolicy', {}).get('enabled')
+    provider = cluster.get("networkPolicy", {}).get("provider")
+    enabled = cluster.get("networkPolicy", {}).get("enabled")
     if provider and enabled is True:
         return provider
     return False
 
 
 @timeit
-def cleanup_gke_clusters(neo4j_session: neo4j.Session, common_job_parameters: Dict) -> None:
+def cleanup_gke_clusters(
+    neo4j_session: neo4j.Session,
+    common_job_parameters: Dict,
+) -> None:
     """
     Delete out-of-date GCP GKE Clusters nodes and relationships
 
@@ -159,12 +186,19 @@ def cleanup_gke_clusters(neo4j_session: neo4j.Session, common_job_parameters: Di
     :rtype: NoneType
     :return: Nothing
     """
-    run_cleanup_job('gcp_gke_cluster_cleanup.json', neo4j_session, common_job_parameters)
+    run_cleanup_job(
+        "gcp_gke_cluster_cleanup.json",
+        neo4j_session,
+        common_job_parameters,
+    )
 
 
 @timeit
 def sync_gke_clusters(
-    neo4j_session: neo4j.Session, container: Resource, project_id: str, gcp_update_tag: int,
+    neo4j_session: neo4j.Session,
+    container: Resource,
+    project_id: str,
+    gcp_update_tag: int,
     common_job_parameters: Dict,
 ) -> None:
     """
@@ -191,5 +225,5 @@ def sync_gke_clusters(
     logger.info("Syncing Compute objects for project %s.", project_id)
     gke_res = get_gke_clusters(container, project_id)
     load_gke_clusters(neo4j_session, gke_res, project_id, gcp_update_tag)
-    # TODO scope the cleanup to the current project - https://github.com/lyft/cartography/issues/381
+    # TODO scope the cleanup to the current project - https://github.com/cartography-cncf/cartography/issues/381
     cleanup_gke_clusters(neo4j_session, common_job_parameters)