better-notion 1.4.0__py3-none-any.whl → 1.5.1__py3-none-any.whl

better_notion/_sdk/models/database.py

@@ -94,7 +94,8 @@ class Database(BaseEntity):
         *,
         client: "NotionClient",
         title: str,
-        properties: dict[str, Any]
+        properties: dict[str, Any] | None = None,
+        schema: dict[str, Any] | None = None,
     ) -> "Database":
         """Create a new database.
 
@@ -102,7 +103,8 @@ class Database(BaseEntity):
             parent: Parent Page
             client: NotionClient instance
             title: Database title
-            properties: Property schema configuration
+            properties: Property schema configuration (alias for schema)
+            schema: Property schema configuration
 
         Returns:
             Newly created Database object
@@ -112,7 +114,7 @@ class Database(BaseEntity):
             ...     parent=page,
             ...     client=client,
             ...     title="Tasks",
-            ...     properties={
+            ...     schema={
             ...         "Name": {"type": "title"},
             ...         "Status": {"type": "select"}
             ...     }
@@ -120,13 +122,16 @@ class Database(BaseEntity):
         """
         from better_notion._api.properties import Title
 
-        # Build title array
-        title_array = [{"type": "text", "text": {"content": title}}]
+        # Support both properties and schema as parameter names
+        if schema is not None and properties is None:
+            properties = schema
+        elif properties is None:
+            properties = {}
 
-        # Create database via API
+        # Create database via API (pass title string - API layer will build the array)
         data = await client.api.databases.create(
             parent={"type": "page_id", "page_id": parent.id},
-            title=title_array,
+            title=title,
             properties=properties
         )
 

better_notion/plugins/official/agents.py

@@ -15,7 +15,6 @@ Features:
 
 from __future__ import annotations
 
-import asyncio
 from pathlib import Path
 from typing import Optional
 
@@ -87,6 +86,12 @@ class AgentsPlugin(CombinedPluginInterface):
                 "-n",
                 help="Name for the workspace",
             ),
+            debug: bool = typer.Option(
+                False,
+                "--debug",
+                "-d",
+                help="Enable debug logging",
+            ),
         ) -> None:
             """
             Initialize a new workspace with all required databases.
@@ -104,6 +109,20 @@ class AgentsPlugin(CombinedPluginInterface):
             Example:
                 $ notion agents init --parent-page page123 --name "My Workspace"
             """
+            import asyncio
+            import logging
+            import sys
+
+            # Enable debug logging if requested
+            if debug:
+                logging.basicConfig(
+                    level=logging.DEBUG,
+                    format='%(asctime)s - %(name)s - %(levelname)s - %(message)s',
+                    stream=sys.stderr,
+                )
+                # Also enable httpx debug logging
+                logging.getLogger("httpx").setLevel(logging.DEBUG)
+
             async def _init() -> str:
                 try:
                     client = get_client()
@@ -126,7 +145,8 @@ class AgentsPlugin(CombinedPluginInterface):
                     )
 
                 except Exception as e:
-                    return format_error("INIT_ERROR", str(e), retry=False)
+                    result = format_error("INIT_ERROR", str(e), retry=False)
+                    return result
 
             result = asyncio.run(_init())
             typer.echo(result)

better_notion/plugins/official/agents_cli.py

@@ -672,6 +672,9 @@ def tasks_next(
                 },
             })
 
+        except ValueError as e:
+            # Specific validation error (e.g., project not found)
+            return format_error("VALIDATION_ERROR", str(e), retry=False)
         except Exception as e:
             return format_error("FIND_NEXT_TASK_ERROR", str(e), retry=False)
 
@@ -767,20 +770,28 @@ def tasks_start(task_id: str) -> str:
 
 def tasks_complete(
     task_id: str,
-    actual_hours: Optional[int] = typer.Option(None, "--actual-hours", "-a", help="Actual hours spent"),
+    actual_hours: Optional[int] = typer.Option(None, "--actual-hours", "-a", help="Actual hours spent (must be non-negative)"),
 ) -> str:
     """
     Complete a task (transition to Completed).
 
     Args:
         task_id: Task page ID
-        actual_hours: Actual hours spent (optional)
+        actual_hours: Actual hours spent (optional, must be non-negative)
 
     Example:
         $ notion tasks complete task_123 --actual-hours 3
     """
     async def _complete() -> str:
         try:
+            # Validate actual_hours parameter if provided
+            if actual_hours is not None:
+                from better_notion.utils.validators import Validators, ValidationError
+                try:
+                    Validators.non_negative_float(actual_hours, "actual_hours")
+                except ValidationError as e:
+                    return format_error("INVALID_PARAMETER", str(e), retry=False)
+
             client = get_client()
 
             # Register SDK plugin
@@ -1047,13 +1058,20 @@ def ideas_review(count: int = 10) -> str:
     Get a batch of ideas for review, prioritized by effort.
 
     Args:
-        count: Maximum number of ideas to return
+        count: Maximum number of ideas to return (must be positive)
 
     Example:
         $ notion ideas review --count 5
     """
     async def _review() -> str:
         try:
+            # Validate count parameter
+            from better_notion.utils.validators import Validators, ValidationError
+            try:
+                Validators.positive_int(count, "count")
+            except ValidationError as e:
+                return format_error("INVALID_PARAMETER", str(e), retry=False)
+
             client = get_client()
 
             # Register SDK plugin
@@ -1623,13 +1641,20 @@ def incidents_mttr(project_id: Optional[str] = None, within_days: int = 30) -> s
 
     Args:
         project_id: Filter by project ID (optional)
-        within_days: Only consider incidents from last N days
+        within_days: Only consider incidents from last N days (must be positive)
 
     Example:
         $ notion incidents mttr --project-id proj_123 --within-days 30
     """
     async def _mttr() -> str:
         try:
+            # Validate within_days parameter
+            from better_notion.utils.validators import Validators, ValidationError
+            try:
+                Validators.positive_int(within_days, "within_days")
+            except ValidationError as e:
+                return format_error("INVALID_PARAMETER", str(e), retry=False)
+
             client = get_client()
 
             # Register SDK plugin

better_notion/plugins/official/agents_sdk/managers.py

@@ -400,13 +400,41 @@ class TaskManager:
 
         Returns:
             Task instance or None if no tasks available
+
+        Raises:
+            ValueError: If project_id is provided but project doesn't exist
         """
-        from better_notion.plugins.official.agents_sdk.models import Task
+        from better_notion.plugins.official.agents_sdk.models import Task, Project
 
         database_id = self._get_database_id("Tasks")
         if not database_id:
             return None
 
+        # Validate project_id if provided
+        if project_id:
+            # First check if Projects database exists in workspace config
+            projects_db = self._get_database_id("Projects")
+            if not projects_db:
+                # Workspace not initialized, can't validate project
+                pass
+            else:
+                # Check if project exists by querying for it
+                try:
+                    project_response = await self._client._api.databases.query(
+                        database_id=projects_db,
+                        filter={"property": "id", "rich_text": {"equals": project_id}}
+                    )
+                    # If no results, project doesn't exist
+                    if not project_response.get("results"):
+                        raise ValueError(
+                            f"Project '{project_id}' not found. "
+                            f"Please verify the project ID or run 'notion agents projects list' to see available projects."
+                        )
+                except Exception as e:
+                    if "not found" in str(e).lower():
+                        raise
+                    # If query fails for other reasons, continue without validation
+
         # Filter for backlog/claimed tasks
         response = await self._client._api.databases.query(
             database_id=database_id,

better_notion/utils/agents/schemas.py

@@ -50,159 +50,174 @@ class SelectOption:
 
 
 class PropertyBuilder:
-    """Helper class for building Notion database properties."""
+    """
+    Helper class for building Notion database properties.
+
+    Notion API create format:
+        "Name": {"title": {}}
+        "Status": {"select": {"options": [...]}}
+    """
 
     @staticmethod
-    def title(name: str = "Name") -> Dict[str, str]:
-        """Create a title property.
+    def title(name: str = "Name") -> Dict[str, Any]:
+        """
+        Create a title property.
 
         Args:
             name: Property name (default: "Name")
 
         Returns:
-            Title property schema
+            Title property schema for Notion API create
         """
-        return {"type": "title", "name": name}
+        return {"title": {}}
 
     @staticmethod
-    def text(name: str) -> Dict[str, str]:
-        """Create a text property.
+    def text(name: str) -> Dict[str, Any]:
+        """
+        Create a text property.
 
         Args:
             name: Property name
 
         Returns:
-            Text property schema
+            Text property schema for Notion API create
         """
-        return {"type": "rich_text", "name": name}
+        return {"rich_text": {}}
 
     @staticmethod
     def number(name: str, format: Optional[str] = None) -> Dict[str, Any]:
-        """Create a number property.
+        """
+        Create a number property.
 
         Args:
             name: Property name
             format: Number format (number, percent, dollar, euro, pound, yen, ruble)
 
         Returns:
-            Number property schema
+            Number property schema for Notion API create
         """
-        prop: Dict[str, Any] = {"type": "number", "name": name}
-
         if format:
-            prop["number"] = {"format": format}
-
-        return prop
+            return {"number": {"format": format}}
+        return {"number": {}}
 
     @staticmethod
     def select(name: str, options: List[Dict[str, str]]) -> Dict[str, Any]:
-        """Create a select property.
+        """
+        Create a select property.
 
         Args:
             name: Property name
             options: List of option dicts from SelectOption.option()
 
         Returns:
-            Select property schema
+            Select property schema for Notion API create
         """
-        return {"type": "select", "name": name, "select": {"options": options}}
+        return {"select": {"options": options}}
 
     @staticmethod
     def multi_select(name: str, options: List[Dict[str, str]]) -> Dict[str, Any]:
-        """Create a multi-select property.
+        """
+        Create a multi-select property.
 
         Args:
             name: Property name
             options: List of option dicts
 
         Returns:
-            Multi-select property schema
+            Multi-select property schema for Notion API create
         """
-        return {"type": "multi_select", "name": name, "multi_select": {"options": options}}
+        return {"multi_select": {"options": options}}
 
     @staticmethod
-    def date(name: str) -> Dict[str, str]:
-        """Create a date property.
+    def date(name: str) -> Dict[str, Any]:
+        """
+        Create a date property.
 
         Args:
             name: Property name
 
         Returns:
-            Date property schema
+            Date property schema for Notion API create
         """
-        return {"type": "date", "name": name}
+        return {"date": {}}
 
     @staticmethod
-    def checkbox(name: str) -> Dict[str, str]:
-        """Create a checkbox property.
+    def checkbox(name: str) -> Dict[str, Any]:
+        """
+        Create a checkbox property.
 
         Args:
             name: Property name
 
         Returns:
-            Checkbox property schema
+            Checkbox property schema for Notion API create
         """
-        return {"type": "checkbox", "name": name}
+        return {"checkbox": {}}
 
     @staticmethod
-    def url(name: str) -> Dict[str, str]:
-        """Create a URL property.
+    def url(name: str) -> Dict[str, Any]:
+        """
+        Create a URL property.
 
         Args:
             name: Property name
 
         Returns:
-            URL property schema
+            URL property schema for Notion API create
         """
-        return {"type": "url", "name": name}
+        return {"url": {}}
 
     @staticmethod
-    def email(name: str) -> Dict[str, str]:
-        """Create an email property.
+    def email(name: str) -> Dict[str, Any]:
+        """
+        Create an email property.
 
         Args:
             name: Property name
 
         Returns:
-            Email property schema
+            Email property schema for Notion API create
         """
-        return {"type": "email", "name": name}
+        return {"email": {}}
 
     @staticmethod
-    def phone(name: str) -> Dict[str, str]:
-        """Create a phone property.
+    def phone(name: str) -> Dict[str, Any]:
+        """
+        Create a phone property.
 
         Args:
             name: Property name
 
         Returns:
-            Phone property schema
+            Phone property schema for Notion API create
         """
-        return {"type": "phone", "name": name}
+        return {"phone_number": {}}
 
     @staticmethod
-    def people(name: str) -> Dict[str, str]:
-        """Create a people property.
+    def people(name: str) -> Dict[str, Any]:
+        """
+        Create a people property.
 
         Args:
             name: Property name
 
         Returns:
-            People property schema
+            People property schema for Notion API create
         """
-        return {"type": "people", "name": name}
+        return {"people": {}}
 
     @staticmethod
-    def files(name: str) -> Dict[str, str]:
-        """Create a files property.
+    def files(name: str) -> Dict[str, Any]:
+        """
+        Create a files property.
 
         Args:
             name: Property name
 
         Returns:
-            Files property schema
+            Files property schema for Notion API create
         """
-        return {"type": "files", "name": name}
+        return {"files": {}}
 
     @staticmethod
     def relation(
@@ -210,7 +225,8 @@ class PropertyBuilder:
         database_id: Optional[str] = None,
         dual_property: bool = True,
     ) -> Dict[str, Any]:
-        """Create a relation property.
+        """
+        Create a relation property.
 
         Args:
             name: Property name
@@ -224,19 +240,22 @@ class PropertyBuilder:
             If database_id is None, it must be set later when the related
             database is created.
         """
-        prop: Dict[str, Any] = {"type": "relation", "name": name, "relation": {}}
+        relation_config: Dict[str, Any] = {}
 
         if database_id:
-            prop["relation"]["database_id"] = database_id
+            relation_config["database_id"] = database_id
 
         if dual_property:
-            prop["relation"]["type"] = "dual_property"
+            relation_config["dual_property"] = {}
+        else:
+            relation_config["single_property"] = {}
 
-        return prop
+        return {"relation": relation_config}
 
     @staticmethod
     def formula(name: str, expression: str) -> Dict[str, Any]:
-        """Create a formula property.
+        """
+        Create a formula property.
 
         Args:
             name: Property name
@@ -245,11 +264,12 @@ class PropertyBuilder:
         Returns:
             Formula property schema
         """
-        return {"type": "formula", "name": name, "formula": {"expression": expression}}
+        return {"formula": {"expression": expression}}
 
     @staticmethod
-    def created_time(name: str = "Created time") -> Dict[str, str]:
-        """Create a created_time property.
+    def created_time(name: str = "Created time") -> Dict[str, Any]:
+        """
+        Create a created_time property.
 
         Args:
             name: Property name (default: "Created time")
@@ -257,11 +277,12 @@ class PropertyBuilder:
         Returns:
             Created time property schema
         """
-        return {"type": "created_time", "name": name}
+        return {"created_time": {}}
 
     @staticmethod
-    def created_by(name: str = "Created by") -> Dict[str, str]:
-        """Create a created_by property.
+    def created_by(name: str = "Created by") -> Dict[str, Any]:
+        """
+        Create a created_by property.
 
         Args:
             name: Property name (default: "Created by")
@@ -269,7 +290,7 @@ class PropertyBuilder:
         Returns:
             Created by property schema
         """
-        return {"type": "created_by", "name": name}
+        return {"created_by": {}}
 
 
 class OrganizationSchema:
@@ -277,7 +298,8 @@ class OrganizationSchema:
 
     @staticmethod
     def get_schema() -> Dict[str, Dict[str, Any]]:
-        """Return Notion database schema for Organizations.
+        """
+        Return Notion database schema for Organizations.
 
         Returns:
             Dict mapping property names to property schemas
@@ -332,7 +354,7 @@ class ProjectSchema:
                     SelectOption.option("React", "blue"),
                     SelectOption.option("Vue", "green"),
                     SelectOption.option("Node.js", "green"),
-                    SelectOption.option("Go", "cyan"),
+                    SelectOption.option("Go", "blue"),
                     SelectOption.option("Rust", "orange"),
                     SelectOption.option("Java", "red"),
                     SelectOption.option("C++", "blue"),
@@ -389,7 +411,8 @@ class VersionSchema:
             "Branch Name": PropertyBuilder.text("Branch Name"),
             "Progress": PropertyBuilder.number("Progress", format="percent"),
             "Release Date": PropertyBuilder.date("Release Date"),
-            "Superseded By": PropertyBuilder.relation("Superseded By", dual_property=False),
+            # Note: "Superseded By" self-referential relation removed because
+            # it can't be created during initial database creation (needs its own ID)
         }
 
 
@@ -435,8 +458,8 @@ class TaskSchema:
                     SelectOption.option("Low", "blue"),
                 ],
             ),
-            "Dependencies": PropertyBuilder.relation("Dependencies", dual_property=False),
-            "Dependent Tasks": PropertyBuilder.relation("Dependent Tasks", dual_property=False),
+            # Note: Self-referential relations (Dependencies, Dependent Tasks) removed because
+            # they can't be created during initial database creation (need the database's own ID)
             "Estimated Hours": PropertyBuilder.number("Estimated Hours"),
             "Actual Hours": PropertyBuilder.number("Actual Hours"),
             "Assignee": PropertyBuilder.people("Assignee"),