better-notion 1.4.0__py3-none-any.whl → 1.5.0__py3-none-any.whl

better_notion/plugins/official/agents.py

@@ -15,7 +15,6 @@ Features:
 
 from __future__ import annotations
 
-import asyncio
 from pathlib import Path
 from typing import Optional
 
@@ -74,7 +73,7 @@ class AgentsPlugin(CombinedPluginInterface):
 
         # Register sub-commands
         @agents_app.command("init")
-        def init_workspace(
+        async def init_workspace(
             parent_page_id: str = typer.Option(
                 ...,
                 "--parent-page",
@@ -87,6 +86,12 @@ class AgentsPlugin(CombinedPluginInterface):
                 "-n",
                 help="Name for the workspace",
             ),
+            debug: bool = typer.Option(
+                False,
+                "--debug",
+                "-d",
+                help="Enable debug logging",
+            ),
         ) -> None:
             """
             Initialize a new workspace with all required databases.
@@ -104,32 +109,44 @@ class AgentsPlugin(CombinedPluginInterface):
             Example:
                 $ notion agents init --parent-page page123 --name "My Workspace"
             """
-            async def _init() -> str:
-                try:
-                    client = get_client()
-                    initializer = WorkspaceInitializer(client)
-
-                    database_ids = await initializer.initialize_workspace(
-                        parent_page_id=parent_page_id,
-                        workspace_name=workspace_name,
-                    )
+            import logging
+            import sys
+
+            # Enable debug logging if requested
+            if debug:
+                logging.basicConfig(
+                    level=logging.DEBUG,
+                    format='%(asctime)s - %(name)s - %(levelname)s - %(message)s',
+                    stream=sys.stderr,
+                )
+                # Also enable httpx debug logging
+                logging.getLogger("httpx").setLevel(logging.DEBUG)
 
-                    # Save database IDs
-                    initializer.save_database_ids()
+            try:
+                client = get_client()
+                initializer = WorkspaceInitializer(client)
 
-                    return format_success(
-                        {
-                            "message": "Workspace initialized successfully",
-                            "databases_created": len(database_ids),
-                            "database_ids": database_ids,
-                        }
-                    )
+                database_ids = await initializer.initialize_workspace(
+                    parent_page_id=parent_page_id,
+                    workspace_name=workspace_name,
+                )
+
+                # Save database IDs
+                initializer.save_database_ids()
 
-                except Exception as e:
-                    return format_error("INIT_ERROR", str(e), retry=False)
+                result = format_success(
+                    {
+                        "message": "Workspace initialized successfully",
+                        "databases_created": len(database_ids),
+                        "database_ids": database_ids,
+                    }
+                )
+                typer.echo(result)
 
-            result = asyncio.run(_init())
-            typer.echo(result)
+            except Exception as e:
+                result = format_error("INIT_ERROR", str(e), retry=False)
+                typer.echo(result)
+                raise typer.Exit(code=1)
 
         @agents_app.command("init-project")
         def init_project(

better_notion/plugins/official/agents_cli.py

@@ -672,6 +672,9 @@ def tasks_next(
                 },
             })
 
+        except ValueError as e:
+            # Specific validation error (e.g., project not found)
+            return format_error("VALIDATION_ERROR", str(e), retry=False)
         except Exception as e:
             return format_error("FIND_NEXT_TASK_ERROR", str(e), retry=False)
 
@@ -767,20 +770,28 @@ def tasks_start(task_id: str) -> str:
 
 def tasks_complete(
     task_id: str,
-    actual_hours: Optional[int] = typer.Option(None, "--actual-hours", "-a", help="Actual hours spent"),
+    actual_hours: Optional[int] = typer.Option(None, "--actual-hours", "-a", help="Actual hours spent (must be non-negative)"),
 ) -> str:
     """
     Complete a task (transition to Completed).
 
     Args:
         task_id: Task page ID
-        actual_hours: Actual hours spent (optional)
+        actual_hours: Actual hours spent (optional, must be non-negative)
 
     Example:
         $ notion tasks complete task_123 --actual-hours 3
     """
     async def _complete() -> str:
         try:
+            # Validate actual_hours parameter if provided
+            if actual_hours is not None:
+                from better_notion.utils.validators import Validators, ValidationError
+                try:
+                    Validators.non_negative_float(actual_hours, "actual_hours")
+                except ValidationError as e:
+                    return format_error("INVALID_PARAMETER", str(e), retry=False)
+
             client = get_client()
 
             # Register SDK plugin
@@ -1047,13 +1058,20 @@ def ideas_review(count: int = 10) -> str:
     Get a batch of ideas for review, prioritized by effort.
 
     Args:
-        count: Maximum number of ideas to return
+        count: Maximum number of ideas to return (must be positive)
 
     Example:
         $ notion ideas review --count 5
     """
     async def _review() -> str:
         try:
+            # Validate count parameter
+            from better_notion.utils.validators import Validators, ValidationError
+            try:
+                Validators.positive_int(count, "count")
+            except ValidationError as e:
+                return format_error("INVALID_PARAMETER", str(e), retry=False)
+
             client = get_client()
 
             # Register SDK plugin
@@ -1623,13 +1641,20 @@ def incidents_mttr(project_id: Optional[str] = None, within_days: int = 30) -> s
 
     Args:
         project_id: Filter by project ID (optional)
-        within_days: Only consider incidents from last N days
+        within_days: Only consider incidents from last N days (must be positive)
 
     Example:
         $ notion incidents mttr --project-id proj_123 --within-days 30
     """
     async def _mttr() -> str:
         try:
+            # Validate within_days parameter
+            from better_notion.utils.validators import Validators, ValidationError
+            try:
+                Validators.positive_int(within_days, "within_days")
+            except ValidationError as e:
+                return format_error("INVALID_PARAMETER", str(e), retry=False)
+
             client = get_client()
 
             # Register SDK plugin

better_notion/plugins/official/agents_sdk/managers.py

@@ -400,13 +400,41 @@ class TaskManager:
 
         Returns:
             Task instance or None if no tasks available
+
+        Raises:
+            ValueError: If project_id is provided but project doesn't exist
         """
-        from better_notion.plugins.official.agents_sdk.models import Task
+        from better_notion.plugins.official.agents_sdk.models import Task, Project
 
         database_id = self._get_database_id("Tasks")
         if not database_id:
             return None
 
+        # Validate project_id if provided
+        if project_id:
+            # First check if Projects database exists in workspace config
+            projects_db = self._get_database_id("Projects")
+            if not projects_db:
+                # Workspace not initialized, can't validate project
+                pass
+            else:
+                # Check if project exists by querying for it
+                try:
+                    project_response = await self._client._api.databases.query(
+                        database_id=projects_db,
+                        filter={"property": "id", "rich_text": {"equals": project_id}}
+                    )
+                    # If no results, project doesn't exist
+                    if not project_response.get("results"):
+                        raise ValueError(
+                            f"Project '{project_id}' not found. "
+                            f"Please verify the project ID or run 'notion agents projects list' to see available projects."
+                        )
+                except Exception as e:
+                    if "not found" in str(e).lower():
+                        raise
+                    # If query fails for other reasons, continue without validation
+
         # Filter for backlog/claimed tasks
         response = await self._client._api.databases.query(
             database_id=database_id,

better_notion/utils/agents/workspace.py

@@ -5,6 +5,7 @@ required databases for the workflow management system.
 """
 
 import json
+import logging
 from pathlib import Path
 from typing import Any, Dict, Optional
 
@@ -22,6 +23,8 @@ from better_notion.utils.agents.schemas import (
     WorkIssueSchema,
 )
 
+logger = logging.getLogger(__name__)
+
 
 class WorkspaceInitializer:
     """Initialize a new workspace with workflow databases.
@@ -64,38 +67,48 @@ class WorkspaceInitializer:
             Dict mapping database names to their IDs
 
         Raises:
-            Exception: If database creation fails
+            Exception: If database creation fails with detailed error message
         """
+        logger.info(f"Initializing workspace '{workspace_name}' in page {parent_page_id}")
+
         # Get parent page
-        parent = await Page.get(parent_page_id, client=self._client)
+        try:
+            parent = await Page.get(parent_page_id, client=self._client)
+            logger.info(f"Parent page found: {parent.id}")
+        except Exception as e:
+            error_msg = f"Failed to get parent page '{parent_page_id}': {str(e)}"
+            logger.error(error_msg)
+            raise Exception(error_msg) from e
 
         # Create databases in order (independent first, then dependent)
         self._database_ids = {}
-
-        # 1. Organizations (independent)
-        await self._create_organizations_db(parent)
-
-        # 2. Tags (independent)
-        await self._create_tags_db(parent)
-
-        # 3. Projects (depends on Organizations)
-        await self._create_projects_db(parent)
-
-        # 4. Versions (depends on Projects)
-        await self._create_versions_db(parent)
-
-        # 5. Tasks (depends on Versions)
-        await self._create_tasks_db(parent)
-
-        # 6. Ideas (depends on Projects)
-        await self._create_ideas_db(parent)
-
-        # 7. Work Issues (depends on Projects, Tasks, Ideas)
-        await self._create_work_issues_db(parent)
-
-        # 8. Incidents (depends on Projects, Versions, Tasks)
-        await self._create_incidents_db(parent)
-
+        databases_order = [
+            ("Organizations", "organizations", self._create_organizations_db),
+            ("Tags", "tags", self._create_tags_db),
+            ("Projects", "projects", self._create_projects_db),
+            ("Versions", "versions", self._create_versions_db),
+            ("Tasks", "tasks", self._create_tasks_db),
+            ("Ideas", "ideas", self._create_ideas_db),
+            ("Work Issues", "work_issues", self._create_work_issues_db),
+            ("Incidents", "incidents", self._create_incidents_db),
+        ]
+
+        for display_name, key, create_func in databases_order:
+            try:
+                logger.info(f"Creating {display_name} database...")
+                await create_func(parent)
+                logger.info(f"✓ {display_name} database created: {self._database_ids[key]}")
+            except Exception as e:
+                error_msg = (
+                    f"Failed to create {display_name} database: {str(e)}\n"
+                    f"Databases created so far: {list(self._database_ids.keys())}\n"
+                    f"Parent page: {parent_page_id}\n"
+                    f"Workspace name: {workspace_name}"
+                )
+                logger.error(error_msg)
+                raise Exception(error_msg) from e
+
+        logger.info(f"Workspace initialization complete. Created {len(self._database_ids)} databases")
         return self._database_ids
 
     async def _create_organizations_db(self, parent: Page) -> None:

better_notion/utils/validators.py

@@ -0,0 +1,132 @@
+"""Validation helpers for CLI commands.
+
+This module provides reusable validation functions for CLI parameters.
+"""
+
+
+class ValidationError(Exception):
+    """Custom exception for validation errors."""
+
+    def __init__(self, message: str):
+        self.message = message
+        super().__init__(self.message)
+
+
+class Validators:
+    """Reusable validation functions for CLI parameters."""
+
+    @staticmethod
+    def positive_int(value: int, name: str = "value") -> None:
+        """
+        Validate that a value is a positive integer.
+
+        Args:
+            value: The value to validate
+            name: Parameter name for error messages
+
+        Raises:
+            ValidationError: If value is not positive
+        """
+        if not isinstance(value, int):
+            raise ValidationError(f"{name} must be an integer (got: {type(value).__name__})")
+        if value <= 0:
+            raise ValidationError(f"{name} must be positive (greater than 0, got: {value})")
+
+    @staticmethod
+    def non_negative_int(value: int, name: str = "value") -> None:
+        """
+        Validate that a value is a non-negative integer.
+
+        Args:
+            value: The value to validate
+            name: Parameter name for error messages
+
+        Raises:
+            ValidationError: If value is negative
+        """
+        if not isinstance(value, int):
+            raise ValidationError(f"{name} must be an integer (got: {type(value).__name__})")
+        if value < 0:
+            raise ValidationError(f"{name} must be non-negative (0 or greater, got: {value})")
+
+    @staticmethod
+    def non_negative_float(value: float, name: str = "value") -> None:
+        """
+        Validate that a value is a non-negative float.
+
+        Args:
+            value: The value to validate
+            name: Parameter name for error messages
+
+        Raises:
+            ValidationError: If value is negative
+        """
+        if not isinstance(value, (int, float)):
+            raise ValidationError(f"{name} must be a number (got: {type(value).__name__})")
+        if value < 0:
+            raise ValidationError(f"{name} must be non-negative (0 or greater, got: {value})")
+
+    @staticmethod
+    def enum(value: str, name: str, allowed: list, case_sensitive: bool = False) -> None:
+        """
+        Validate that a value is in the allowed list.
+
+        Args:
+            value: The value to validate
+            name: Parameter name for error messages
+            allowed: List of allowed values
+            case_sensitive: Whether comparison should be case-sensitive
+
+        Raises:
+            ValidationError: If value is not in allowed list
+        """
+        if not case_sensitive:
+            value_lower = value.lower()
+            allowed_lower = [a.lower() for a in allowed]
+            if value_lower not in allowed_lower:
+                raise ValidationError(
+                    f"{name} must be one of {allowed} (got: {value})"
+                )
+        else:
+            if value not in allowed:
+                raise ValidationError(
+                    f"{name} must be one of {allowed} (got: {value})"
+                )
+
+    @staticmethod
+    def range_int(value: int, name: str, min_val: int, max_val: int) -> None:
+        """
+        Validate that a value is within a specified range.
+
+        Args:
+            value: The value to validate
+            name: Parameter name for error messages
+            min_val: Minimum allowed value (inclusive)
+            max_val: Maximum allowed value (inclusive)
+
+        Raises:
+            ValidationError: If value is outside the range
+        """
+        if not isinstance(value, int):
+            raise ValidationError(f"{name} must be an integer (got: {type(value).__name__})")
+        if value < min_val or value > max_val:
+            raise ValidationError(
+                f"{name} must be between {min_val} and {max_val} (got: {value})"
+            )
+
+    @staticmethod
+    def required(value: Any, name: str) -> None:
+        """
+        Validate that a value is not None or empty.
+
+        Args:
+            value: The value to validate
+            name: Parameter name for error messages
+
+        Raises:
+            ValidationError: If value is None or empty
+        """
+        if value is None:
+            raise ValidationError(f"{name} is required")
+        if isinstance(value, str) and not value.strip():
+            raise ValidationError(f"{name} cannot be empty")

{better_notion-1.4.0.dist-info → better_notion-1.5.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: better-notion
-Version: 1.4.0
+Version: 1.5.0
 Summary: A high-level Python SDK for the Notion API with developer experience in mind.
 Project-URL: Homepage, https://github.com/nesalia-inc/better-notion
 Project-URL: Documentation, https://github.com/nesalia-inc/better-notion#readme

{better_notion-1.4.0.dist-info → better_notion-1.5.0.dist-info}/RECORD

@@ -41,8 +41,8 @@ better_notion/_cli/commands/auth.py,sha256=d1-g8SKCrC8Di4yM36hafVlF9YZQ9pypRYU9I
 better_notion/_cli/commands/blocks.py,sha256=ErcR-SHhPoz6B9uy0xOG6CGZB-bhvny5lxBYufmYHbw,15711
 better_notion/_cli/commands/comments.py,sha256=dBdxvpkjk_yA_1WUivXl1Nt8Ig-uYD5-k4XtenHU_cI,4981
 better_notion/_cli/commands/config.py,sha256=3bOCmcRnpTb5SHB2TJPXdxrRshy84nZRAsULxfbSqk0,5360
-better_notion/_cli/commands/databases.py,sha256=05NR4BQBaxXedl1MBemwlXPA1Q7loWc36t56AGAofdQ,8320
-better_notion/_cli/commands/pages.py,sha256=Tt99IhQthAUjFVc6KkLmvubfYgW84RwCvcjt4gNXqdA,14280
+better_notion/_cli/commands/databases.py,sha256=SRfUi74Cm7YVvdwPjbcwP1g__DiZsMyY0YLQTY-skx4,12953
+better_notion/_cli/commands/pages.py,sha256=NZwrWDOim43FzIdtqubbXarsflnjQo2T4BGB1TJsco0,13068
 better_notion/_cli/commands/plugins.py,sha256=mBYSVciwwgnCRXYOuJfSYDV2UMAr_9P8KwPuiC-pY2A,27067
 better_notion/_cli/commands/search.py,sha256=JM20W5TiohsOKLyEUABEaWr0yB82W2_qAGQ1w64_pGk,4671
 better_notion/_cli/commands/update.py,sha256=NfmijzTpCbVTEY2h0QdcJZXEiGmWkk-iyEtZCqrgmAk,4997
@@ -107,16 +107,17 @@ better_notion/plugins/base.py,sha256=3h9jOZzS--UqmVW3RREtcQ2h1GTWWPUryTencsJKhTM
 better_notion/plugins/loader.py,sha256=zCWsMdJyvZs1IHFm0zjEiqm_l_5jB1Uw4x30Kq8rLS4,9527
 better_notion/plugins/state.py,sha256=jH_tZWvC35hqLO4qwl2Kwq9ziWVavwCEUcCqy3s5wMY,3780
 better_notion/plugins/official/__init__.py,sha256=rPg5vdk1cEANVstMPzxcWmImtsOpdSR40JSml7h1uUk,426
-better_notion/plugins/official/agents.py,sha256=UF9zn7DNBX-3_bmpjrHhbNd4dZXQIGa5ljhCC71SRcA,25939
-better_notion/plugins/official/agents_cli.py,sha256=v2yem60ER6EVRt9u1f5xF3MOExQeQ4lGqGCQ6z7pV18,51706
+better_notion/plugins/official/agents.py,sha256=f86Qg456tbebFdB7xvSobSFqqAvJBLKYocm41ItRmYk,26507
+better_notion/plugins/official/agents_cli.py,sha256=8l6e1zJCAT4DdAO-QfdjK_vrrrik3pmrojwakE32ZNY,53048
 better_notion/plugins/official/productivity.py,sha256=_-whP4pYA4HufE1aUFbIdhrjU-O9njI7xUO_Id2M1J8,8726
 better_notion/plugins/official/agents_sdk/__init__.py,sha256=luQBzZLsJ7fC5U0jFu8dfzMviiXj2SBZXcTohM53wkQ,725
-better_notion/plugins/official/agents_sdk/managers.py,sha256=dkpGozJhKXvz8rFqc2tAWyL6MeVzFVcjGMC0Ed2Z1dQ,29813
+better_notion/plugins/official/agents_sdk/managers.py,sha256=0zMZPu63zhdyqiudO2gKsmM3YOJh0nFAR9FrMlwkV2A,31186
 better_notion/plugins/official/agents_sdk/models.py,sha256=gwGw9t-Z17NxddzmRKWiD9Noje86sxgPNlLJGARI0KA,75448
 better_notion/plugins/official/agents_sdk/plugin.py,sha256=bs9O8Unv6SARGj4lBU5Gj9HGbLTUNqTacJ3RLUhdbI4,4479
 better_notion/utils/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 better_notion/utils/helpers.py,sha256=HgFuUQlG_HzBOB0z2GA9RxPLoXgwRc0DIxa9Fg6C-Jk,2337
 better_notion/utils/retry.py,sha256=9WJDNitiIfVTL18hIlipvOKn41ukePrOwtAwx-LevpQ,7479
+better_notion/utils/validators.py,sha256=RyAGcYJexKOq1YepF6insoBu4QEOVPoAMWqi8Mt_5Xk,4583
 better_notion/utils/agents/__init__.py,sha256=Zu32q0abbimrJY5dczjWNEastE-IrtGPQjpxD4JS4IU,1715
 better_notion/utils/agents/auth.py,sha256=_SBcqBjXmX8CJMCPpRWM-UuaDg7-OOtMWbhnYEiIBTs,6568
 better_notion/utils/agents/dependency_resolver.py,sha256=PfHHDIQztGih4LwylMb0_MyhDFbOYPjvUxcxY52mSEs,12033
@@ -124,9 +125,9 @@ better_notion/utils/agents/project_context.py,sha256=aJlzy5H2rL4sAfW2jHL_3K2VkBJ
 better_notion/utils/agents/rbac.py,sha256=8ZA8Y7wbOiVZDbpjpH7iC35SZrZ0jl4fcJ3xWCm3SsE,11820
 better_notion/utils/agents/schemas.py,sha256=e_lpGGO12FXtfqFyI91edj9xc5RUtuA6pU7Sk6ip7xg,21784
 better_notion/utils/agents/state_machine.py,sha256=xUBEeDTbU1Xq-rsRo2sbr6AUYpYrV9DTHOtZT2cWES8,6699
-better_notion/utils/agents/workspace.py,sha256=T8mP_DNIWhI1-k6UydJINsEJ6kQxQ6_Pa44ul58k088,12370
-better_notion-1.4.0.dist-info/METADATA,sha256=WXldrn_zOf9rVjRSQJmWLLr_ixIdAOtZxGW2BhWNmZc,11096
-better_notion-1.4.0.dist-info/WHEEL,sha256=WLgqFyCfm_KASv4WHyYy0P3pM_m7J5L9k2skdKLirC8,87
-better_notion-1.4.0.dist-info/entry_points.txt,sha256=D0bUcP7Z00Zyjxw7r2p29T95UrwioDO0aGDoHe9I6fo,55
-better_notion-1.4.0.dist-info/licenses/LICENSE,sha256=BAdN3JpgMY_y_fWqZSCFSvSbC2mTHP-BKDAzF5FXQAI,1069
-better_notion-1.4.0.dist-info/RECORD,,
+better_notion/utils/agents/workspace.py,sha256=qsbVSFNtmpH87azvwlGShlloNVo9o2dhpohhtP9u8r8,13454
+better_notion-1.5.0.dist-info/METADATA,sha256=N0p6fb7GbSnvgzixdJnPkMAo557uXqFLaHBKHP0Rpgc,11096
+better_notion-1.5.0.dist-info/WHEEL,sha256=WLgqFyCfm_KASv4WHyYy0P3pM_m7J5L9k2skdKLirC8,87
+better_notion-1.5.0.dist-info/entry_points.txt,sha256=D0bUcP7Z00Zyjxw7r2p29T95UrwioDO0aGDoHe9I6fo,55
+better_notion-1.5.0.dist-info/licenses/LICENSE,sha256=BAdN3JpgMY_y_fWqZSCFSvSbC2mTHP-BKDAzF5FXQAI,1069
+better_notion-1.5.0.dist-info/RECORD,,