bbstrader 0.2.991__py3-none-any.whl → 0.3.1__py3-none-any.whl

bbstrader/__init__.py

@@ -7,7 +7,7 @@ __author__ = "Bertin Balouki SIMYELI"
 __copyright__ = "2023-2025 Bertin Balouki SIMYELI"
 __email__ = "bertin@bbstrader.com"
 __license__ = "MIT"
-__version__ = "0.2.0"
+__version__ = "0.3.1"
 
 from bbstrader import compat  # noqa: F401
 from bbstrader import core  # noqa: F401

bbstrader/__main__.py

@@ -1,15 +1,29 @@
 import argparse
 import sys
+from enum import Enum
 
 import pyfiglet
 from colorama import Fore
 
 from bbstrader.btengine.scripts import backtest
+from bbstrader.core.scripts import send_news_feed
 from bbstrader.metatrader.scripts import copy_trades
 from bbstrader.trading.scripts import execute_strategy
 
-DESCRIPTION = "BBSTRADER"
-USAGE_TEXT = """
+
+class Module(Enum):
+    COPIER = "copier"
+    BACKTEST = "backtest"
+    EXECUTION = "execution"
+    NEWS_FEED = "news_feed"
+
+
+FONT = pyfiglet.figlet_format("BBSTRADER", font="big")
+
+
+def main():
+    DESCRIPTION = "BBSTRADER"
+    USAGE_TEXT = """
     Usage:
         python -m bbstrader --run <module> [options]
 
@@ -17,14 +31,10 @@ USAGE_TEXT = """
         copier: Copy trades from one MetaTrader account to another or multiple accounts
         backtest: Backtest a strategy, see bbstrader.btengine.backtest.run_backtest
         execution: Execute a strategy, see bbstrader.trading.execution.Mt5ExecutionEngine
+        news_feed: Send news feed from Coindesk to Telegram channel
     
     python -m bbstrader --run <module> --help for more information on the module
-"""
-
-FONT = pyfiglet.figlet_format("BBSTRADER", font="big")
-
-
-def main():
+    """
     print(Fore.BLUE + FONT)
     print(Fore.WHITE + "")
     parser = argparse.ArgumentParser(
@@ -39,12 +49,23 @@ def main():
     if ("-h" in sys.argv or "--help" in sys.argv) and args.run is None:
         print(Fore.WHITE + USAGE_TEXT)
         sys.exit(0)
-    if args.run == "copier":
-        copy_trades(unknown)
-    elif args.run == "backtest":
-        backtest(unknown)
-    elif args.run == "execution":
-        execute_strategy(unknown)
+    try:
+        match args.run:
+            case Module.COPIER.value:
+                copy_trades(unknown)
+            case Module.BACKTEST.value:
+                backtest(unknown)
+            case Module.EXECUTION.value:
+                execute_strategy(unknown)
+            case Module.NEWS_FEED.value:
+                send_news_feed(unknown)
+            case _:
+                print(Fore.RED + f"Unknown module: {args.run}")
+                sys.exit(1)
+    except KeyboardInterrupt:
+        sys.exit(0)
+    except Exception:
+        sys.exit(1)
 
 
 if __name__ == "__main__":

bbstrader/btengine/data.py

@@ -5,6 +5,7 @@ from queue import Queue
 from typing import Dict, List
 
 import numpy as np
+from numpy.typing import NDArray
 import pandas as pd
 import yfinance as yf
 from eodhd import APIClient
@@ -91,7 +92,7 @@ class DataHandler(metaclass=ABCMeta):
         pass
 
     @abstractmethod
-    def get_latest_bars_values(self, symbol, val_type, N=1) -> np.ndarray:
+    def get_latest_bars_values(self, symbol, val_type, N=1) -> NDArray:
         """
         Returns the last N bar values from the
         latest_symbol list, or N-k if less available.
@@ -301,7 +302,7 @@ class BaseCSVDataHandler(DataHandler):
                 )
                 raise
 
-    def get_latest_bars_values(self, symbol: str, val_type: str, N=1) -> np.ndarray:
+    def get_latest_bars_values(self, symbol: str, val_type: str, N=1) -> NDArray:
         """
         Returns the last N bar values from the
         latest_symbol list, or N-k if less available.
@@ -413,6 +414,7 @@ class MT5DataHandler(BaseCSVDataHandler):
         self.data_dir = kwargs.get("data_dir")
         self.symbol_list = symbol_list
         self.kwargs = kwargs
+        self.kwargs["backtest"] = True # Ensure backtest mode is set to avoid InvalidBroker errors
 
         csv_dir = self._download_and_cache_data(self.data_dir)
         super().__init__(

bbstrader/btengine/execution.py

@@ -7,6 +7,7 @@ from bbstrader.btengine.data import DataHandler
 from bbstrader.btengine.event import Events, FillEvent, OrderEvent
 from bbstrader.config import BBSTRADER_DIR
 from bbstrader.metatrader.account import Account
+from bbstrader.metatrader.utils import SymbolType
 
 __all__ = ["ExecutionHandler", "SimExecutionHandler", "MT5ExecutionHandler"]
 
@@ -71,6 +72,8 @@ class SimExecutionHandler(ExecutionHandler):
         self.events = events
         self.bardata = data
         self.logger = kwargs.get("logger") or logger
+        self.commissions = kwargs.get("commission")
+        self.exchange = kwargs.get("exchange", "ARCA")
 
     def execute_order(self, event: OrderEvent):
         """
@@ -85,11 +88,11 @@ class SimExecutionHandler(ExecutionHandler):
             fill_event = FillEvent(
                 timeindex=dtime,
                 symbol=event.symbol,
-                exchange="ARCA",
+                exchange=self.exchange,
                 quantity=event.quantity,
                 direction=event.direction,
                 fill_cost=None,
-                commission=None,
+                commission=self.commissions,
                 order=event.signal,
             )
             self.events.put(fill_event)
@@ -135,6 +138,8 @@ class MT5ExecutionHandler(ExecutionHandler):
         self.events = events
         self.bardata = data
         self.logger = kwargs.get("logger") or logger
+        self.commissions = kwargs.get("commission")
+        self.exchange = kwargs.get("exchange", "MT5")
         self.__account = Account(**kwargs)
 
     def _calculate_lot(self, symbol, quantity, price):
@@ -145,9 +150,13 @@ class MT5ExecutionHandler(ExecutionHandler):
         lot = (quantity * price) / (contract_size * price)
         if contract_size == 1:
             lot = quantity
-        if symbol_type in ["COMD", "FUT", "CRYPTO"] and contract_size > 1:
+        if (
+            symbol_type
+            in (SymbolType.COMMODITIES, SymbolType.FUTURES, SymbolType.CRYPTO)
+            and contract_size > 1
+        ):
             lot = quantity / contract_size
-        if symbol_type == "FX":
+        if symbol_type == SymbolType.FOREX:
             lot = quantity * price / contract_size
         return self._check_lot(symbol, lot)
 
@@ -161,17 +170,17 @@ class MT5ExecutionHandler(ExecutionHandler):
 
     def _estimate_total_fees(self, symbol, lot, qty, price):
         symbol_type = self.__account.get_symbol_type(symbol)
-        if symbol_type in ["STK", "ETF"]:
+        if symbol_type in (SymbolType.STOCKS, SymbolType.ETFs):
             return self._estimate_stock_commission(symbol, qty, price)
-        elif symbol_type == "FX":
+        elif symbol_type == SymbolType.FOREX:
             return self._estimate_forex_commission(lot)
-        elif symbol_type == "COMD":
+        elif symbol_type == SymbolType.COMMODITIES:
             return self._estimate_commodity_commission(lot)
-        elif symbol_type == "IDX":
+        elif symbol_type == SymbolType.INDICES:
             return self._estimate_index_commission(lot)
-        elif symbol_type == "FUT":
+        elif symbol_type == SymbolType.FUTURES:
             return self._estimate_futures_commission()
-        elif symbol_type == "CRYPTO":
+        elif symbol_type == SymbolType.CRYPTO:
             return self._estimate_crypto_commission()
         else:
             return 0.0
@@ -187,7 +196,7 @@ class MT5ExecutionHandler(ExecutionHandler):
         eu_asia_cm = 0.0015  # percent
         if (
             symbol in self.__account.get_stocks_from_country("USA")
-            or self.__account.get_symbol_type(symbol) == "ETF"
+            or self.__account.get_symbol_type(symbol) == SymbolType.ETFs
             and self.__account.get_currency_rates(symbol)["mc"] == "USD"
         ):
             return max(min_com, qty * us_com)
@@ -195,7 +204,7 @@ class MT5ExecutionHandler(ExecutionHandler):
             symbol in self.__account.get_stocks_from_country("GBR")
             or symbol in self.__account.get_stocks_from_country("FRA")
             or symbol in self.__account.get_stocks_from_country("DEU")
-            or self.__account.get_symbol_type(symbol) == "ETF"
+            or self.__account.get_symbol_type(symbol) == SymbolType.ETFs
             and self.__account.get_currency_rates(symbol)["mc"] in ["GBP", "EUR"]
         ):
             return max(min_com, qty * price * ger_fr_uk_cm)
@@ -241,14 +250,15 @@ class MT5ExecutionHandler(ExecutionHandler):
             lot = self._calculate_lot(symbol, quantity, price)
             fees = self._estimate_total_fees(symbol, lot, quantity, price)
             dtime = self.bardata.get_latest_bar_datetime(symbol)
+            commission = self.commissions or fees
             fill_event = FillEvent(
                 timeindex=dtime,
                 symbol=symbol,
-                exchange="MT5",
+                exchange=self.exchange,
                 quantity=quantity,
                 direction=direction,
                 fill_cost=None,
-                commission=fees,
+                commission=commission,
                 order=event.signal,
             )
             self.events.put(fill_event)

bbstrader/btengine/strategy.py

@@ -17,10 +17,12 @@ from bbstrader.metatrader.account import (
     AdmiralMarktsGroup,
     PepperstoneGroupLimited,
 )
+from bbstrader.metatrader.utils import SymbolType
 from bbstrader.metatrader.rates import Rates
-from bbstrader.metatrader.trade import TradeSignal
+from bbstrader.metatrader.trade import TradeSignal, TradingMode
 from bbstrader.models.optimization import optimized_weights
 
+
 __all__ = ["Strategy", "MT5Strategy"]
 
 logger.add(
@@ -76,7 +78,7 @@ class MT5Strategy(Strategy):
         events: Queue = None,
         symbol_list: List[str] = None,
         bars: DataHandler = None,
-        mode: str = None,
+        mode: TradingMode = None,
         **kwargs,
     ):
         """
@@ -86,7 +88,7 @@ class MT5Strategy(Strategy):
             events : The event queue.
             symbol_list : The list of symbols for the strategy.
             bars : The data handler object.
-            mode : The mode of operation for the strategy (backtest or live).
+            mode (TradingMode): The mode of operation for the strategy.
             **kwargs : Additional keyword arguments for other classes (e.g, Portfolio, ExecutionHandler).
                 - max_trades : The maximum number of trades allowed per symbol.
                 - time_frame : The time frame for the strategy.
@@ -101,33 +103,49 @@ class MT5Strategy(Strategy):
         self.max_trades = kwargs.get("max_trades", {s: 1 for s in self.symbols})
         self.tf = kwargs.get("time_frame", "D1")
         self.logger = kwargs.get("logger") or logger
-        if self.mode == "backtest":
+        if self.mode == TradingMode.BACKTEST:
             self._initialize_portfolio()
         self.kwargs = kwargs
         self.periodes = 0
+    
+    @property 
+    def account(self):
+        return Account(**self.kwargs)
 
     @property
     def cash(self) -> float:
+        if self.mode == TradingMode.LIVE:
+            return self.account.balance
         return self._porfolio_value
 
     @cash.setter
     def cash(self, value):
+        if self.mode == TradingMode.LIVE:
+            raise ValueError("Cannot set the account cash in live mode")
         self._porfolio_value = value
 
     @property
-    def orders(self) -> Dict[str, Dict[str, List[SignalEvent]]]:
+    def orders(self):
+        if self.mode == TradingMode.LIVE:
+            return self.account.get_orders()
         return self._orders
 
     @property
     def trades(self) -> Dict[str, Dict[str, int]]:
+        if self.mode == TradingMode.LIVE:
+            raise ValueError("Cannot call this methode in live mode")
         return self._trades
 
     @property
-    def positions(self) -> Dict[str, Dict[str, int | float]]:
+    def positions(self):
+        if self.mode == TradingMode.LIVE:
+            return self.account.get_positions()
         return self._positions
 
     @property
     def holdings(self) -> Dict[str, float]:
+        if self.mode == TradingMode.LIVE:
+            raise ValueError("Cannot call this methode in live mode")
         return self._holdings
 
     def _check_risk_budget(self, **kwargs):
@@ -606,7 +624,7 @@ class MT5Strategy(Strategy):
         value_type: str = "returns",
         array: bool = True,
         bars: DataHandler = None,
-        mode: Literal["backtest", "live"] = "backtest",
+        mode: TradingMode = TradingMode.BACKTEST,
         tf: str = "D1",
         error: Literal["ignore", "raise"] = None,
     ) -> Dict[str, np.ndarray | pd.Series] | None:
@@ -634,7 +652,7 @@ class MT5Strategy(Strategy):
         if mode not in ["backtest", "live"]:
             raise ValueError("Mode must be either backtest or live.")
         asset_values = {}
-        if mode == "backtest":
+        if mode == TradingMode.BACKTEST:
             if bars is None:
                 raise ValueError("DataHandler is required for backtest mode.")
             for asset in symbol_list:
@@ -644,11 +662,11 @@ class MT5Strategy(Strategy):
                 else:
                     values = bars.get_latest_bars(asset, N=window)
                     asset_values[asset] = getattr(values, value_type)
-        elif mode == "live":
+        elif mode == TradingMode.LIVE:
             for asset in symbol_list:
                 rates = Rates(asset, timeframe=tf, count=window + 1, **self.kwargs)
                 if array:
-                    values = getattr(rates, value_type).values
+                    values = getattr(rates, value_type).to_numpy()
                     asset_values[asset] = values[~np.isnan(values)]
                 else:
                     values = getattr(rates, value_type)
@@ -704,7 +722,7 @@ class MT5Strategy(Strategy):
         Returns:
             bool : True if there are open positions, False otherwise
         """
-        account = account or Account(**self.kwargs)
+        account = account or self.account
         positions = account.get_positions(symbol=symbol)
         if positions is not None:
             open_positions = [
@@ -730,7 +748,7 @@ class MT5Strategy(Strategy):
         Returns:
             prices : numpy array of buy or sell prices for open positions if any or an empty array.
         """
-        account = account or Account(**self.kwargs)
+        account = account or self.account
         positions = account.get_positions(symbol=symbol)
         if positions is not None:
             prices = np.array(
@@ -778,21 +796,21 @@ class MT5Strategy(Strategy):
         return dt_to
 
     @staticmethod
-    def get_mt5_equivalent(symbols, type="STK", **kwargs) -> List[str]:
+    def get_mt5_equivalent(symbols, symbol_type: str | SymbolType = SymbolType.STOCKS, **kwargs) -> List[str]:
         """
         Get the MetaTrader 5 equivalent symbols for the symbols in the list.
         This method is used to get the symbols that are available on the MetaTrader 5 platform.
 
         Args:
             symbols : The list of symbols to get the MetaTrader 5 equivalent symbols for.
-            type : The type of symbols to get (e.g., STK, CFD, etc.).
+            symbol_type : The type of symbols to get (See `bbstrader.metatrader.utils.SymbolType`).
             **kwargs : Additional keyword arguments for the `bbstrader.metatrader.Account` object.
 
         Returns:
             mt5_equivalent : The MetaTrader 5 equivalent symbols for the symbols in the list.
         """
         account = Account(**kwargs)
-        mt5_symbols = account.get_symbols(symbol_type=type)
+        mt5_symbols = account.get_symbols(symbol_type=symbol_type)
         mt5_equivalent = []
         if account.broker == AdmiralMarktsGroup():
             for s in mt5_symbols:

bbstrader/core/data.py

@@ -149,7 +149,7 @@ class FmpNews(object):
             try:
                 articles = pd.read_csv("latest_fmp_articles.csv")
                 articles = articles.to_dict(orient="records")
-                if self._last_date(articles[0]["date"]) < end_date:
+                if self._last_date(articles[0]["date"]).hour < end_date.hour:
                     articles = self.get_articles(**kwargs)
                 else:
                     return articles
@@ -161,7 +161,9 @@ class FmpNews(object):
             df.to_csv("latest_fmp_articles.csv", index=False)
         return articles
 
-    def get_news(self, query, source="articles", articles=None, symbol=None, **kwargs):
+    def get_news(
+        self, query, source="articles", articles=None, symbol: str = None, **kwargs
+    ):
         """
         Retrieves relevant financial news based on the specified source.
 
@@ -183,6 +185,10 @@ class FmpNews(object):
                         Returns an empty list if no relevant news is found.
         """
         query = _get_search_query(query)
+        if symbol is not None:
+            symbol = symbol.replace("-", "").split("=")[
+                0
+            ]  # if symbol is a yahoo finance ticker
         source_methods = {
             "articles": lambda: self.get_latest_articles(articles=articles, save=True),
             "releases": lambda: self.get_releases(symbol=symbol, **kwargs),
@@ -191,6 +197,8 @@ class FmpNews(object):
             "forex": lambda: self.get_forex_news(symbol=symbol, **kwargs),
         }
         news_source = source_methods.get(source, lambda: [])()
+        if source == "articles":
+            symbol = None  # Articles do not require a symbol filter
         news = self.parse_news(news_source, symbol=symbol)
         return _filter_news(news, query)
 
@@ -198,12 +206,12 @@ class FmpNews(object):
 class FinancialNews(object):
     """
     The FinancialNews class provides methods to fetch financial news, articles, and discussions
-    from various sources such as Yahoo Finance, Google Finance, Reddit, and Twitter.
+    from various sources such as Yahoo Finance, Google Finance, Reddit, Coindesk and Twitter.
     It also supports retrieving news using Financial Modeling Prep (FMP).
 
     """
 
-    def _fetch_news(self, url, query, asset_type, n_news, headline_tag) -> List[str]:
+    def _fetch_news(self, url, query, n_news, headline_tag) -> List[str]:
         headers = {"User-Agent": "Mozilla/5.0"}
         try:
             response = requests.get(url, headers=headers)
@@ -224,32 +232,60 @@ class FinancialNews(object):
         ]
         return headlines[:n_news]
 
-    def get_yahoo_finance_news(self, query, asset_type="stock", n_news=10):
+    def get_yahoo_finance_news(self, query: str, asset_type="stock", n_news=10):
         """
         Fetches recent Yahoo Finance news headlines for a given financial asset.
 
         Args:
             query (str): The asset symbol or name (e.g., "AAPL").
-            asset_type (str, optional): The type of asset (e.g., "stock", "etf"). Defaults to "stock".
+            asset_type (str, optional): The type of asset (e.g., "stock", "etf"). Defaults to "stock",
+                supported types include:
+                - "stock": Stock symbols (e.g., AAPL, MSFT)
+                - "etf": Exchange-traded funds (e.g., SPY, QQQ)
+                - "future": Futures contracts (e.g., CL=F for crude oil)
+                - "forex": Forex pairs (e.g., EURUSD=X, USDJPY=X)
+                - "crypto": Cryptocurrency pairs (e.g., BTC-USD, ETH-USD)
+                - "index": Stock market indices (e.g., ^GSPC for S&P 500)
             n_news (int, optional): The number of news headlines to return. Defaults to 10.
 
+        Note:
+            For commotities and bonds, use the "Future" asset type.
+
         Returns:
             list[str]: A list of Yahoo Finance news headlines relevant to the query.
         """
+        if asset_type == "forex" or asset_type == "future":
+            assert (
+                "=" in query
+            ), "Forex query must contain '=' for currency pairs (e.g., EURUSD=X, CL=F)"
+        if asset_type == "crypto":
+            assert (
+                "-" in query
+            ), "Crypto query must contain '-' for crypto pairs (e.g., BTC-USD, ETH-USD)"
+        if asset_type == "index":
+            assert query.startswith(
+                "^"
+            ), "Index query must start with '^' (e.g., ^GSPC for S&P 500)"
         url = (
             f"https://finance.yahoo.com/quote/{query}/news"
-            if asset_type in ["stock", "etf"]
+            if asset_type in ["stock", "etf", "index", "future", "forex"]
             else "https://finance.yahoo.com/news"
         )
-        return self._fetch_news(url, query, asset_type, n_news, "h3")
+        return self._fetch_news(url, query, n_news, "h3")
 
-    def get_google_finance_news(self, query, asset_type="stock", n_news=10):
+    def get_google_finance_news(self, query: str, asset_type="stock", n_news=10):
         """
         Fetches recent Google Finance news headlines for a given financial asset.
 
         Args:
             query (str): The asset symbol or name (e.g., "AAPL").
             asset_type (str, optional): The type of asset (e.g., "stock", "crypto"). Defaults to "stock".
+                Supported types include:
+                - "stock": Stock symbols (e.g., AAPL, MSFT)
+                - "etf": Exchange-traded funds (e.g., SPY, QQQ)
+                - "future": Futures contracts (e.g., CL=F or crude oil)
+                - "forex": Forex pairs (e.g., EURUSD, USDJPY)
+                - "crypto": Cryptocurrency pairs (e.g., BTCUSD, ETHUSD)
             n_news (int, optional): The number of news headlines to return. Defaults to 10.
 
         Returns:
@@ -258,20 +294,18 @@ class FinancialNews(object):
         search_terms = {
             "stock": f"{query} stock OR {query} shares OR {query} market",
             "etf": f"{query} ETF OR {query} fund OR {query} exchange-traded fund",
-            "futures": f"{query} futures OR {query} price OR {query} market",
-            "commodity": f"{query} price OR {query} futures OR {query} market",
+            "future": f"{query} futures OR {query} price OR {query} market",
             "forex": f"{query} forex OR {query} exchange rate OR {query} market",
             "crypto": f"{query} cryptocurrency OR {query} price OR {query} market",
-            "bond": f"{query} bond OR {query} yield OR {query} interest rate",
             "index": f"{query} index OR {query} stock market OR {query} performance",
         }
         search_query = search_terms.get(asset_type, query)
         url = f"https://news.google.com/search?q={search_query.replace(' ', '+')}"
-        return self._fetch_news(url, query, asset_type, n_news, "a")
+        return self._fetch_news(url, query, n_news, "a")
 
     def get_reddit_posts(
         self,
-        symbol,
+        symbol: str,
         client_id=None,
         client_secret=None,
         user_agent=None,
@@ -294,8 +328,8 @@ class FinancialNews(object):
                 - "stock": Searches in stock-related subreddits (e.g., wallstreetbets, stocks).
                 - "forex": Searches in forex-related subreddits.
                 - "commodities": Searches in commodity-related subreddits (e.g., gold, oil).
-                - "etfs": Searches in ETF-related subreddits.
-                - "futures": Searches in futures and options trading subreddits.
+                - "etf": Searches in ETF-related subreddits.
+                - "future": Searches in futures and options trading subreddits.
                 - "crypto": Searches in cryptocurrency-related subreddits.
                 - If an unrecognized asset class is provided, defaults to stock-related subreddits.
             n_posts (int, optional): The number of posts to return per subreddit. Defaults to 10.
@@ -317,15 +351,36 @@ class FinancialNews(object):
         """
 
         reddit = praw.Reddit(
-            client_id=client_id, client_secret=client_secret, user_agent=user_agent
+            client_id=client_id,
+            client_secret=client_secret,
+            user_agent=user_agent,
+            check_for_updates=False,
+            comment_kind="t1",
+            message_kind="t4",
+            redditor_kind="t2",
+            submission_kind="t3",
+            subreddit_kind="t5",
+            trophy_kind="t6",
+            oauth_url="https://oauth.reddit.com",
+            reddit_url="https://www.reddit.com",
+            short_url="https://redd.it",
+            timeout=16,
+            ratelimit_seconds=5,
         )
-
+        assert reddit.read_only
         subreddit_mapping = {
             "stock": ["wallstreetbets", "stocks", "investing", "StockMarket"],
             "forex": ["Forex", "ForexTrading", "DayTrading"],
-            "commodities": ["Commodities", "Gold", "Silverbugs", "oil"],
             "etfs": ["ETFs", "investing"],
-            "futures": ["FuturesTrading", "OptionsTrading", "DayTrading"],
+            "futures": [
+                "FuturesTrading",
+                "OptionsTrading",
+                "DayTrading",
+                "Commodities",
+                "Gold",
+                "Silverbugs",
+                "oil",
+            ],
             "crypto": ["CryptoCurrency", "Bitcoin", "ethereum", "altcoin"],
         }
         try:
@@ -473,16 +528,23 @@ class FinancialNews(object):
         maximum = 100
         if limit > maximum:
             raise ValueError(f"Number of total news articles allowed is {maximum}")
-
-        response = requests.get(
-            "https://data-api.coindesk.com/news/v1/article/list",
-            params={"lang": lang, "limit": limit},
-            headers={"Content-type": "application/json; charset=UTF-8"},
-        )
-        json_response = response.json()
-        articles = json_response["Data"]
-        if len(articles) == 0:
+        try:
+            response = requests.get(
+                "https://data-api.coindesk.com/news/v1/article/list",
+                params={"lang": lang, "limit": limit},
+                headers={"Content-type": "application/json; charset=UTF-8"},
+            )
+            response.raise_for_status()
+            json_response = response.json()
+        except requests.exceptions.RequestException:
             return []
+        if (
+            response.status_code != 200
+            or "Data" not in json_response
+            or len(json_response["Data"]) == 0
+        ):
+            return []
+        articles = json_response["Data"]
         to_keep = [
             "PUBLISHED_ON",
             "TITLE",
@@ -495,10 +557,11 @@ class FinancialNews(object):
         ]
         filtered_articles = []
         for article in articles:
+            keys = article.keys()
             filtered_articles.append(
                 {
                     k.lower(): article[k]
-                    if k in article and k != "PUBLISHED_ON"
+                    if k in keys and k != "PUBLISHED_ON"
                     else datetime.fromtimestamp(article[k])
                     for k in to_keep
                     if article[k] is not None and "sponsored" not in str(article[k])