basic-memory 0.14.2__py3-none-any.whl → 0.14.4__py3-none-any.whl

basic_memory/config.py

@@ -46,7 +46,7 @@ class BasicMemoryConfig(BaseSettings):
 
     projects: Dict[str, str] = Field(
         default_factory=lambda: {
-            "main": str(Path(os.getenv("BASIC_MEMORY_HOME", Path.home() / "basic-memory")))
+            "main": Path(os.getenv("BASIC_MEMORY_HOME", Path.home() / "basic-memory")).as_posix()
         },
         description="Mapping of project names to their filesystem paths",
     )
@@ -74,6 +74,17 @@ class BasicMemoryConfig(BaseSettings):
         description="Whether to sync changes in real time. default (True)",
     )
 
+    kebab_filenames: bool = Field(
+        default=False,
+        description="Format for generated filenames. False preserves spaces and special chars, True converts them to hyphens for consistency with permalinks",
+    )
+
+    # API connection configuration
+    api_url: Optional[str] = Field(
+        default=None,
+        description="URL of remote Basic Memory API. If set, MCP will connect to this API instead of using local ASGI transport.",
+    )
+
     model_config = SettingsConfigDict(
         env_prefix="BASIC_MEMORY_",
         extra="ignore",
@@ -94,9 +105,9 @@ class BasicMemoryConfig(BaseSettings):
         """Ensure configuration is valid after initialization."""
         # Ensure main project exists
         if "main" not in self.projects:  # pragma: no cover
-            self.projects["main"] = str(
+            self.projects["main"] = (
                 Path(os.getenv("BASIC_MEMORY_HOME", Path.home() / "basic-memory"))
-            )
+            ).as_posix()
 
         # Ensure default project is valid
         if self.default_project not in self.projects:  # pragma: no cover
@@ -124,6 +135,7 @@ class BasicMemoryConfig(BaseSettings):
         """
 
         # Load the app-level database path from the global config
+        config_manager = ConfigManager()
         config = config_manager.load_config()  # pragma: no cover
         return config.app_database_path  # pragma: no cover
 
@@ -162,20 +174,21 @@ class ConfigManager:
         # Ensure config directory exists
         self.config_dir.mkdir(parents=True, exist_ok=True)
 
-        # Load or create configuration
-        self.config = self.load_config()
+    @property
+    def config(self) -> BasicMemoryConfig:
+        """Get configuration, loading it lazily if needed."""
+        return self.load_config()
 
     def load_config(self) -> BasicMemoryConfig:
         """Load configuration from file or create default."""
+
         if self.config_file.exists():
             try:
                 data = json.loads(self.config_file.read_text(encoding="utf-8"))
                 return BasicMemoryConfig(**data)
             except Exception as e:  # pragma: no cover
-                logger.error(f"Failed to load config: {e}")
-                config = BasicMemoryConfig()
-                self.save_config(config)
-                return config
+                logger.exception(f"Failed to load config: {e}")
+                raise e
         else:
             config = BasicMemoryConfig()
             self.save_config(config)
@@ -183,10 +196,7 @@ class ConfigManager:
 
     def save_config(self, config: BasicMemoryConfig) -> None:
         """Save configuration to file."""
-        try:
-            self.config_file.write_text(json.dumps(config.model_dump(), indent=2))
-        except Exception as e:  # pragma: no cover
-            logger.error(f"Failed to save config: {e}")
+        save_basic_memory_config(self.config_file, config)
 
     @property
     def projects(self) -> Dict[str, str]:
@@ -208,8 +218,10 @@ class ConfigManager:
         project_path = Path(path)
         project_path.mkdir(parents=True, exist_ok=True)  # pragma: no cover
 
-        self.config.projects[name] = str(project_path)
-        self.save_config(self.config)
+        # Load config, modify it, and save it
+        config = self.load_config()
+        config.projects[name] = project_path.as_posix()
+        self.save_config(config)
         return ProjectConfig(name=name, home=project_path)
 
     def remove_project(self, name: str) -> None:
@@ -219,11 +231,13 @@ class ConfigManager:
         if not project_name:  # pragma: no cover
             raise ValueError(f"Project '{name}' not found")
 
-        if project_name == self.config.default_project:  # pragma: no cover
+        # Load config, check, modify, and save
+        config = self.load_config()
+        if project_name == config.default_project:  # pragma: no cover
             raise ValueError(f"Cannot remove the default project '{name}'")
 
-        del self.config.projects[name]
-        self.save_config(self.config)
+        del config.projects[name]
+        self.save_config(config)
 
     def set_default_project(self, name: str) -> None:
         """Set the default project."""
@@ -231,15 +245,18 @@ class ConfigManager:
         if not project_name:  # pragma: no cover
             raise ValueError(f"Project '{name}' not found")
 
-        self.config.default_project = name
-        self.save_config(self.config)
+        # Load config, modify, and save
+        config = self.load_config()
+        config.default_project = project_name
+        self.save_config(config)
 
     def get_project(self, name: str) -> Tuple[str, str] | Tuple[None, None]:
         """Look up a project from the configuration by name or permalink"""
         project_permalink = generate_permalink(name)
-        for name, path in app_config.projects.items():
-            if project_permalink == generate_permalink(name):
-                return name, path
+        app_config = self.config
+        for project_name, path in app_config.projects.items():
+            if project_permalink == generate_permalink(project_name):
+                return project_name, path
         return None, None
 
 
@@ -252,7 +269,7 @@ def get_project_config(project_name: Optional[str] = None) -> ProjectConfig:
     actual_project_name = None
 
     # load the config from file
-    global app_config
+    config_manager = ConfigManager()
     app_config = config_manager.load_config()
 
     # Get project name from environment variable
@@ -282,14 +299,12 @@ def get_project_config(project_name: Optional[str] = None) -> ProjectConfig:
     raise ValueError(f"Project '{actual_project_name}' not found")  # pragma: no cover
 
 
-# Create config manager
-config_manager = ConfigManager()
-
-# Export the app-level config
-app_config: BasicMemoryConfig = config_manager.config
-
-# Load project config for the default project (backward compatibility)
-config: ProjectConfig = get_project_config()
+def save_basic_memory_config(file_path: Path, config: BasicMemoryConfig) -> None:
+    """Save configuration to file."""
+    try:
+        file_path.write_text(json.dumps(config.model_dump(), indent=2))
+    except Exception as e:  # pragma: no cover
+        logger.error(f"Failed to save config: {e}")
 
 
 def update_current_project(project_name: str) -> None:
@@ -341,12 +356,24 @@ def setup_basic_memory_logging():  # pragma: no cover
         # print("Skipping duplicate logging setup")
         return
 
+    # Check for console logging environment variable - accept more truthy values
+    console_logging_env = os.getenv("BASIC_MEMORY_CONSOLE_LOGGING", "false").lower()
+    console_logging = console_logging_env in ("true", "1", "yes", "on")
+
+    # Check for log level environment variable first, fall back to config
+    log_level = os.getenv("BASIC_MEMORY_LOG_LEVEL")
+    if not log_level:
+        config_manager = ConfigManager()
+        log_level = config_manager.config.log_level
+
+    config_manager = ConfigManager()
+    config = get_project_config()
     setup_logging(
         env=config_manager.config.env,
         home_dir=user_home,  # Use user home for logs
-        log_level=config_manager.load_config().log_level,
+        log_level=log_level,
         log_file=f"{DATA_DIR_NAME}/basic-memory-{process_name}.log",
-        console=False,
+        console=console_logging,
     )
 
     logger.info(f"Basic Memory {basic_memory.__version__} (Project: {config.project})")

basic_memory/db.py

@@ -4,7 +4,7 @@ from enum import Enum, auto
 from pathlib import Path
 from typing import AsyncGenerator, Optional
 
-from basic_memory.config import BasicMemoryConfig
+from basic_memory.config import BasicMemoryConfig, ConfigManager
 from alembic import command
 from alembic.config import Config
 
@@ -88,7 +88,6 @@ async def get_or_create_db(
     db_path: Path,
     db_type: DatabaseType = DatabaseType.FILESYSTEM,
     ensure_migrations: bool = True,
-    app_config: Optional["BasicMemoryConfig"] = None,
 ) -> tuple[AsyncEngine, async_sessionmaker[AsyncSession]]:  # pragma: no cover
     """Get or create database engine and session maker."""
     global _engine, _session_maker
@@ -98,10 +97,7 @@ async def get_or_create_db(
 
         # Run migrations automatically unless explicitly disabled
         if ensure_migrations:
-            if app_config is None:
-                from basic_memory.config import app_config as global_app_config
-
-                app_config = global_app_config
+            app_config = ConfigManager().config
             await run_migrations(app_config, db_type)
 
     # These checks should never fail since we just created the engine and session maker

basic_memory/deps.py

@@ -12,7 +12,7 @@ from sqlalchemy.ext.asyncio import (
 import pathlib
 
 from basic_memory import db
-from basic_memory.config import ProjectConfig, BasicMemoryConfig
+from basic_memory.config import ProjectConfig, BasicMemoryConfig, ConfigManager
 from basic_memory.importers import (
     ChatGPTImporter,
     ClaudeConversationsImporter,
@@ -33,10 +33,10 @@ from basic_memory.services.file_service import FileService
 from basic_memory.services.link_resolver import LinkResolver
 from basic_memory.services.search_service import SearchService
 from basic_memory.sync import SyncService
-from basic_memory.config import app_config
 
 
 def get_app_config() -> BasicMemoryConfig:  # pragma: no cover
+    app_config = ConfigManager().config
     return app_config
 
 
@@ -297,6 +297,7 @@ ContextServiceDep = Annotated[ContextService, Depends(get_context_service)]
 
 
 async def get_sync_service(
+    app_config: AppConfigDep,
     entity_service: EntityServiceDep,
     entity_parser: EntityParserDep,
     entity_repository: EntityRepositoryDep,

basic_memory/file_utils.py

@@ -2,9 +2,11 @@
 
 import hashlib
 from pathlib import Path
+import re
 from typing import Any, Dict, Union
 
 import yaml
+import frontmatter
 from loguru import logger
 
 from basic_memory.utils import FilePath
@@ -233,3 +235,66 @@ async def update_frontmatter(path: FilePath, updates: Dict[str, Any]) -> str:
             error=str(e),
         )
         raise FileError(f"Failed to update frontmatter: {e}")
+
+
+def dump_frontmatter(post: frontmatter.Post) -> str:
+    """
+    Serialize frontmatter.Post to markdown with Obsidian-compatible YAML format.
+    
+    This function ensures that tags are formatted as YAML lists instead of JSON arrays:
+    
+    Good (Obsidian compatible):
+    ---
+    tags:
+    - system
+    - overview  
+    - reference
+    ---
+    
+    Bad (current behavior):
+    ---
+    tags: ["system", "overview", "reference"]
+    ---
+    
+    Args:
+        post: frontmatter.Post object to serialize
+        
+    Returns:
+        String containing markdown with properly formatted YAML frontmatter
+    """    
+    if not post.metadata:
+        # No frontmatter, just return content
+        return post.content
+        
+    # Serialize YAML with block style for lists
+    yaml_str = yaml.dump(
+        post.metadata,
+        sort_keys=False,
+        allow_unicode=True,
+        default_flow_style=False
+    )
+    
+    # Construct the final markdown with frontmatter
+    if post.content:
+        return f"---\n{yaml_str}---\n\n{post.content}"
+    else:
+        return f"---\n{yaml_str}---\n"
+
+
+def sanitize_for_filename(text: str, replacement: str = "-") -> str:
+    """
+    Sanitize string to be safe for use as a note title
+    Replaces path separators and other problematic characters
+    with hyphens.
+    """
+    # replace both POSIX and Windows path separators
+    text = re.sub(r"[/\\]", replacement, text)
+
+    # replace some other problematic chars
+    text = re.sub(r'[<>:"|?*]', replacement, text)
+
+    # compress multiple, repeated replacements
+    text = re.sub(f"{re.escape(replacement)}+", replacement, text)
+
+    return text.strip(replacement)
+

basic_memory/importers/chatgpt_importer.py

@@ -93,7 +93,7 @@ class ChatGPTImporter(Importer[ChatImportResult]):
                 break
 
         # Generate permalink
-        date_prefix = datetime.fromtimestamp(created_at).strftime("%Y%m%d")
+        date_prefix = datetime.fromtimestamp(created_at).astimezone().strftime("%Y%m%d")
         clean_title = clean_filename(conversation["title"])
 
         # Format content
@@ -193,7 +193,7 @@ class ChatGPTImporter(Importer[ChatImportResult]):
     def _traverse_messages(
         self, mapping: Dict[str, Any], root_id: Optional[str], seen: Set[str]
     ) -> List[Dict[str, Any]]:  # pragma: no cover
-        """Traverse message tree and return messages in order.
+        """Traverse message tree iteratively to handle deep conversations.
 
         Args:
             mapping: Message mapping.
@@ -204,19 +204,29 @@ class ChatGPTImporter(Importer[ChatImportResult]):
             List of message data.
         """
         messages = []
-        node = mapping.get(root_id) if root_id else None
+        if not root_id:
+            return messages
 
-        while node:
+        # Use iterative approach with stack to avoid recursion depth issues
+        stack = [root_id]
+
+        while stack:
+            node_id = stack.pop()
+            if not node_id:
+                continue
+
+            node = mapping.get(node_id)
+            if not node:
+                continue
+
+            # Process current node if it has a message and hasn't been seen
             if node["id"] not in seen and node.get("message"):
                 seen.add(node["id"])
                 messages.append(node["message"])
 
-            # Follow children
+            # Add children to stack in reverse order to maintain conversation flow
             children = node.get("children", [])
-            for child_id in children:
-                child_msgs = self._traverse_messages(mapping, child_id, seen)
-                messages.extend(child_msgs)
-
-            break  # Don't follow siblings
+            for child_id in reversed(children):
+                stack.append(child_id)
 
         return messages

basic_memory/importers/memory_json_importer.py

@@ -3,7 +3,7 @@
 import logging
 from typing import Any, Dict, List
 
-from basic_memory.config import config
+from basic_memory.config import get_project_config
 from basic_memory.markdown.schemas import EntityFrontmatter, EntityMarkdown, Observation, Relation
 from basic_memory.importers.base import Importer
 from basic_memory.schemas.importer import EntityImportResult
@@ -27,10 +27,12 @@ class MemoryJsonImporter(Importer[EntityImportResult]):
         Returns:
             EntityImportResult containing statistics and status of the import.
         """
+        config = get_project_config()
         try:
             # First pass - collect all relations by source entity
             entity_relations: Dict[str, List[Relation]] = {}
             entities: Dict[str, Dict[str, Any]] = {}
+            skipped_entities: int = 0
 
             # Ensure the base path exists
             base_path = config.home  # pragma: no cover
@@ -41,7 +43,13 @@ class MemoryJsonImporter(Importer[EntityImportResult]):
             for line in source_data:
                 data = line
                 if data["type"] == "entity":
-                    entities[data["name"]] = data
+                    # Handle different possible name keys
+                    entity_name = data.get("name") or data.get("entityName") or data.get("id")
+                    if not entity_name:
+                        logger.warning(f"Entity missing name field: {data}")
+                        skipped_entities += 1
+                        continue
+                    entities[entity_name] = data
                 elif data["type"] == "relation":
                     # Store relation with its source entity
                     source = data.get("from") or data.get("from_id")
@@ -57,25 +65,31 @@ class MemoryJsonImporter(Importer[EntityImportResult]):
             # Second pass - create and write entities
             entities_created = 0
             for name, entity_data in entities.items():
+                # Get entity type with fallback
+                entity_type = entity_data.get("entityType") or entity_data.get("type") or "entity"
+
                 # Ensure entity type directory exists
-                entity_type_dir = base_path / entity_data["entityType"]
+                entity_type_dir = base_path / entity_type
                 entity_type_dir.mkdir(parents=True, exist_ok=True)
 
+                # Get observations with fallback to empty list
+                observations = entity_data.get("observations", [])
+
                 entity = EntityMarkdown(
                     frontmatter=EntityFrontmatter(
                         metadata={
-                            "type": entity_data["entityType"],
+                            "type": entity_type,
                             "title": name,
-                            "permalink": f"{entity_data['entityType']}/{name}",
+                            "permalink": f"{entity_type}/{name}",
                         }
                     ),
                     content=f"# {name}\n",
-                    observations=[Observation(content=obs) for obs in entity_data["observations"]],
+                    observations=[Observation(content=obs) for obs in observations],
                     relations=entity_relations.get(name, []),
                 )
 
                 # Write entity file
-                file_path = base_path / f"{entity_data['entityType']}/{name}.md"
+                file_path = base_path / f"{entity_type}/{name}.md"
                 await self.write_entity(entity, file_path)
                 entities_created += 1
 
@@ -86,6 +100,7 @@ class MemoryJsonImporter(Importer[EntityImportResult]):
                 success=True,
                 entities=entities_created,
                 relations=relations_count,
+                skipped_entities=skipped_entities,
             )
 
         except Exception as e:  # pragma: no cover

basic_memory/importers/utils.py

@@ -43,13 +43,13 @@ def format_timestamp(timestamp: Any) -> str:  # pragma: no cover
         except ValueError:
             try:
                 # Try unix timestamp as string
-                timestamp = datetime.fromtimestamp(float(timestamp))
+                timestamp = datetime.fromtimestamp(float(timestamp)).astimezone()
             except ValueError:
                 # Return as is if we can't parse it
                 return timestamp
     elif isinstance(timestamp, (int, float)):
         # Unix timestamp
-        timestamp = datetime.fromtimestamp(timestamp)
+        timestamp = datetime.fromtimestamp(timestamp).astimezone()
 
     if isinstance(timestamp, datetime):
         return timestamp.strftime("%Y-%m-%d %H:%M:%S")

basic_memory/markdown/entity_parser.py

@@ -130,6 +130,6 @@ class EntityParser:
             content=post.content,
             observations=entity_content.observations,
             relations=entity_content.relations,
-            created=datetime.fromtimestamp(file_stats.st_ctime),
-            modified=datetime.fromtimestamp(file_stats.st_mtime),
+            created=datetime.fromtimestamp(file_stats.st_ctime).astimezone(),
+            modified=datetime.fromtimestamp(file_stats.st_mtime).astimezone(),
         )

basic_memory/markdown/markdown_processor.py

@@ -2,11 +2,11 @@ from pathlib import Path
 from typing import Optional
 from collections import OrderedDict
 
-import frontmatter
 from frontmatter import Post
 from loguru import logger
 
 from basic_memory import file_utils
+from basic_memory.file_utils import dump_frontmatter
 from basic_memory.markdown.entity_parser import EntityParser
 from basic_memory.markdown.schemas import EntityMarkdown, Observation, Relation
 
@@ -115,7 +115,7 @@ class MarkdownProcessor:
 
         # Create Post object for frontmatter
         post = Post(content, **frontmatter_dict)
-        final_content = frontmatter.dumps(post, sort_keys=False)
+        final_content = dump_frontmatter(post)
 
         logger.debug(f"writing file {path} with content:\n{final_content}")
 

basic_memory/markdown/plugins.py

@@ -8,35 +8,49 @@ from markdown_it.token import Token
 # Observation handling functions
 def is_observation(token: Token) -> bool:
     """Check if token looks like our observation format."""
+    import re
     if token.type != "inline":  # pragma: no cover
         return False
-
-    content = token.content.strip()
+    # Use token.tag which contains the actual content for test tokens, fallback to content
+    content = (token.tag or token.content).strip()
     if not content:  # pragma: no cover
         return False
-
     # if it's a markdown_task, return false
     if content.startswith("[ ]") or content.startswith("[x]") or content.startswith("[-]"):
         return False
-
-    has_category = content.startswith("[") and "]" in content
+    
+    # Exclude markdown links: [text](url)
+    if re.match(r"^\[.*?\]\(.*?\)$", content):
+        return False
+    
+    # Exclude wiki links: [[text]]
+    if re.match(r"^\[\[.*?\]\]$", content):
+        return False
+    
+    # Check for proper observation format: [category] content
+    match = re.match(r"^\[([^\[\]()]+)\]\s+(.+)", content)
     has_tags = "#" in content
-    return has_category or has_tags
+    return bool(match) or has_tags
 
 
 def parse_observation(token: Token) -> Dict[str, Any]:
     """Extract observation parts from token."""
-    # Strip bullet point if present
-    content = token.content.strip()
-
-    # Parse [category]
+    import re
+    # Use token.tag which contains the actual content for test tokens, fallback to content
+    content = (token.tag or token.content).strip()
+    
+    # Parse [category] with regex
+    match = re.match(r"^\[([^\[\]()]+)\]\s+(.+)", content)
     category = None
-    if content.startswith("["):
-        end = content.find("]")
-        if end != -1:
-            category = content[1:end].strip() or None  # Convert empty to None
-            content = content[end + 1 :].strip()
-
+    if match:
+        category = match.group(1).strip()
+        content = match.group(2).strip()
+    else:
+        # Handle empty brackets [] followed by content
+        empty_match = re.match(r"^\[\]\s+(.+)", content)
+        if empty_match:
+            content = empty_match.group(1).strip()
+    
     # Parse (context)
     context = None
     if content.endswith(")"):
@@ -44,20 +58,18 @@ def parse_observation(token: Token) -> Dict[str, Any]:
         if start != -1:
             context = content[start + 1 : -1].strip()
             content = content[:start].strip()
-
+    
     # Extract tags and keep original content
     tags = []
     parts = content.split()
     for part in parts:
         if part.startswith("#"):
-            # Handle multiple #tags stuck together
             if "#" in part[1:]:
-                # Split on # but keep non-empty tags
                 subtags = [t for t in part.split("#") if t]
                 tags.extend(subtags)
             else:
                 tags.append(part[1:])
-
+    
     return {
         "category": category,
         "content": content,
@@ -72,14 +84,16 @@ def is_explicit_relation(token: Token) -> bool:
     if token.type != "inline":  # pragma: no cover
         return False
 
-    content = token.content.strip()
+    # Use token.tag which contains the actual content for test tokens, fallback to content
+    content = (token.tag or token.content).strip()
     return "[[" in content and "]]" in content
 
 
 def parse_relation(token: Token) -> Dict[str, Any] | None:
     """Extract relation parts from token."""
     # Remove bullet point if present
-    content = token.content.strip()
+    # Use token.tag which contains the actual content for test tokens, fallback to content
+    content = (token.tag or token.content).strip()
 
     # Extract [[target]]
     target = None
@@ -213,10 +227,12 @@ def relation_plugin(md: MarkdownIt) -> None:
                         token.meta["relations"] = [rel]
 
                 # Always check for inline links in any text
-                elif "[[" in token.content:
-                    rels = parse_inline_relations(token.content)
-                    if rels:
-                        token.meta["relations"] = token.meta.get("relations", []) + rels
+                else:
+                    content = token.tag or token.content
+                    if "[[" in content:
+                        rels = parse_inline_relations(content)
+                        if rels:
+                            token.meta["relations"] = token.meta.get("relations", []) + rels
 
     # Add the rule after inline processing
     md.core.ruler.after("inline", "relations", relation_rule)

basic_memory/markdown/utils.py

@@ -41,7 +41,7 @@ def entity_model_from_markdown(
     # Only update permalink if it exists in frontmatter, otherwise preserve existing
     if markdown.frontmatter.permalink is not None:
         model.permalink = markdown.frontmatter.permalink
-    model.file_path = str(file_path)
+    model.file_path = file_path.as_posix()
     model.content_type = "text/markdown"
     model.created_at = markdown.created
     model.updated_at = markdown.modified