avrae-ls 0.4.0__py3-none-any.whl → 0.5.0__py3-none-any.whl

avrae_ls/diagnostics.py

@@ -1,694 +0,0 @@
-from __future__ import annotations
-
-import inspect
-import ast
-import logging
-from typing import Dict, Iterable, List, Sequence, Set
-
-import draconic
-from lsprotocol import types
-
-from .argument_parsing import apply_argument_parsing
-from .completions import _infer_type_map, _resolve_type_name, _type_meta
-from .config import DiagnosticSettings
-from .context import ContextData, GVarResolver
-from .parser import find_draconic_blocks
-from .runtime import MockExecutor, _default_builtins
-
-log = logging.getLogger(__name__)
-
-SEVERITY = {
-    "error": types.DiagnosticSeverity.Error,
-    "warning": types.DiagnosticSeverity.Warning,
-    "info": types.DiagnosticSeverity.Information,
-}
-
-
-class DiagnosticProvider:
-    def __init__(self, executor: MockExecutor, settings: DiagnosticSettings):
-        self._executor = executor
-        self._settings = settings
-        self._builtin_signatures = _build_builtin_signatures()
-
-    async def analyze(
-        self,
-        source: str,
-        ctx_data: ContextData,
-        gvar_resolver: GVarResolver,
-    ) -> List[types.Diagnostic]:
-        diagnostics: list[types.Diagnostic] = []
-
-        source = apply_argument_parsing(source)
-        blocks = find_draconic_blocks(source)
-        if not blocks:
-            diagnostics.extend(await self._analyze_code(source, ctx_data, gvar_resolver))
-            return diagnostics
-
-        for block in blocks:
-            block_diags = await self._analyze_code(block.code, ctx_data, gvar_resolver)
-            diagnostics.extend(_shift_diagnostics(block_diags, block.line_offset, block.char_offset))
-        return diagnostics
-
-    async def _analyze_code(
-        self,
-        code: str,
-        ctx_data: ContextData,
-        gvar_resolver: GVarResolver,
-    ) -> List[types.Diagnostic]:
-        diagnostics: list[types.Diagnostic] = []
-        parser = draconic.DraconicInterpreter()
-        line_shift = 0
-        try:
-            body = parser.parse(code)
-        except draconic.DraconicSyntaxError as exc:
-            wrapped, added = _wrap_draconic(code)
-            try:
-                body = parser.parse(wrapped)
-                line_shift = -added
-            except draconic.DraconicSyntaxError:
-                diagnostics.append(_syntax_diagnostic(exc))
-                return diagnostics
-        except SyntaxError as exc:
-            diagnostics.append(_syntax_from_std(exc))
-            return diagnostics
-
-        diagnostics.extend(
-            self._check_unknown_names(body, ctx_data, self._settings.semantic_level)
-        )
-        diagnostics.extend(await _check_gvars(body, gvar_resolver, self._settings))
-        diagnostics.extend(_check_imports(body, self._settings.semantic_level))
-        diagnostics.extend(_check_call_args(body, self._builtin_signatures, self._settings.semantic_level))
-        diagnostics.extend(_check_private_method_calls(body))
-        diagnostics.extend(
-            _check_api_misuse(body, code, ctx_data, self._settings.semantic_level)
-        )
-        if line_shift:
-            diagnostics = _shift_diagnostics(diagnostics, line_shift, 0)
-        return diagnostics
-
-    def _check_unknown_names(
-        self,
-        body: Sequence[ast.AST],
-        ctx_data: ContextData,
-        severity_level: str,
-    ) -> List[types.Diagnostic]:
-        known: Set[str] = set(self._executor.available_names(ctx_data))
-        diagnostics: list[types.Diagnostic] = []
-
-        class Walker(ast.NodeVisitor):
-            def __init__(self, tracker: Set[str]):
-                self.tracker = tracker
-
-            def visit_Assign(self, node: ast.Assign):
-                self.visit(node.value)
-                for target in node.targets:
-                    self.tracker.update(_names_in_target(target))
-
-            def visit_AnnAssign(self, node: ast.AnnAssign):
-                if node.value:
-                    self.visit(node.value)
-                self.tracker.update(_names_in_target(node.target))
-
-            def visit_AugAssign(self, node: ast.AugAssign):
-                self.visit(node.value)
-                self.tracker.update(_names_in_target(node.target))
-
-            def visit_FunctionDef(self, node: ast.FunctionDef):
-                self.tracker.add(node.name)
-                for arg in node.args.args:
-                    self.tracker.add(arg.arg)
-                for stmt in node.body:
-                    self.visit(stmt)
-
-            def visit_ClassDef(self, node: ast.ClassDef):
-                self.tracker.add(node.name)
-                for stmt in node.body:
-                    self.visit(stmt)
-
-            def visit_For(self, node: ast.For):
-                # Loop targets become defined for the loop body and after the loop
-                self.tracker.update(_names_in_target(node.target))
-                self.visit(node.iter)
-                for stmt in node.body:
-                    self.visit(stmt)
-                for stmt in node.orelse:
-                    self.visit(stmt)
-
-            def visit_AsyncFor(self, node: ast.AsyncFor):
-                # Async loop targets follow the same scoping rules as regular loops
-                self.tracker.update(_names_in_target(node.target))
-                self.visit(node.iter)
-                for stmt in node.body:
-                    self.visit(stmt)
-                for stmt in node.orelse:
-                    self.visit(stmt)
-
-            def visit_Name(self, node: ast.Name):
-                if isinstance(node.ctx, ast.Load) and node.id not in self.tracker:
-                    diagnostics.append(
-                        _make_diagnostic(
-                            node,
-                            f"'{node.id}' may be undefined in this scope",
-                            severity_level,
-                        )
-                    )
-
-            def visit_Call(self, node: ast.Call):
-                if isinstance(node.func, ast.Name) and node.func.id == "using":
-                    for kw in node.keywords:
-                        if kw.arg:
-                            self.tracker.add(str(kw.arg))
-                self.generic_visit(node)
-
-        walker = Walker(known)
-        for stmt in body:
-            walker.visit(stmt)
-        return diagnostics
-
-
-def _syntax_diagnostic(exc: draconic.DraconicSyntaxError) -> types.Diagnostic:
-    rng = _range_from_positions(
-        exc.lineno,
-        exc.offset,
-        exc.end_lineno,
-        exc.end_offset,
-    )
-    return types.Diagnostic(
-        message=exc.msg,
-        range=rng,
-        severity=types.DiagnosticSeverity.Error,
-        source="avrae-ls",
-    )
-
-
-def _syntax_from_std(exc: SyntaxError) -> types.Diagnostic:
-    lineno, offset = exc.lineno, exc.offset
-    rng = _range_from_positions(lineno, offset, getattr(exc, "end_lineno", None), getattr(exc, "end_offset", None))
-    return types.Diagnostic(
-        message=exc.msg,
-        range=rng,
-        severity=types.DiagnosticSeverity.Error,
-        source="avrae-ls",
-    )
-
-
-def _names_in_target(target: ast.AST) -> Set[str]:
-    names: set[str] = set()
-    if isinstance(target, ast.Name):
-        names.add(target.id)
-    elif isinstance(target, ast.Tuple):
-        for elt in target.elts:
-            names.update(_names_in_target(elt))
-    elif isinstance(target, ast.List):
-        for elt in target.elts:
-            names.update(_names_in_target(elt))
-    return names
-
-
-async def _check_gvars(
-    body: Sequence[ast.AST],
-    resolver: GVarResolver,
-    settings: DiagnosticSettings,
-) -> List[types.Diagnostic]:
-    diagnostics: list[types.Diagnostic] = []
-    seen: set[str] = set()
-
-    def _literal_value(node: ast.AST) -> str | None:
-        if isinstance(node, ast.Constant) and isinstance(node.value, str):
-            return node.value
-        if isinstance(node, ast.Str):
-            return node.s
-        return None
-
-    for node in _iter_calls(body):
-        if not isinstance(node.func, ast.Name):
-            continue
-
-        async def _validate_gvar(arg_node: ast.AST):
-            gvar_id = _literal_value(arg_node)
-            if gvar_id is None or gvar_id in seen:
-                return
-            seen.add(gvar_id)
-            found_local = resolver.get_local(gvar_id)
-            ensured = found_local is not None or await resolver.ensure(gvar_id)
-            if not ensured:
-                diagnostics.append(
-                    _make_diagnostic(
-                        arg_node,
-                        f"Unknown gvar '{gvar_id}'",
-                        settings.semantic_level,
-                    )
-                )
-
-        if node.func.id == "get_gvar":
-            if node.args:
-                await _validate_gvar(node.args[0])
-        elif node.func.id == "using":
-            for kw in node.keywords:
-                await _validate_gvar(kw.value)
-    return diagnostics
-
-
-def _iter_calls(body: Sequence[ast.AST]) -> Iterable[ast.Call]:
-    class Finder(ast.NodeVisitor):
-        def __init__(self):
-            self.calls: list[ast.Call] = []
-
-        def visit_Call(self, node: ast.Call):
-            self.calls.append(node)
-            self.generic_visit(node)
-
-    finder = Finder()
-    for stmt in body:
-        finder.visit(stmt)
-    return finder.calls
-
-
-def _check_private_method_calls(body: Sequence[ast.AST]) -> List[types.Diagnostic]:
-    diagnostics: list[types.Diagnostic] = []
-
-    class Finder(ast.NodeVisitor):
-        def visit_Call(self, node: ast.Call):
-            func = node.func
-            if isinstance(func, ast.Attribute) and func.attr.startswith("_"):
-                diagnostics.append(
-                    _make_diagnostic(
-                        func,
-                        "Calling private methods (starting with '_') is not allowed",
-                        "error",
-                    )
-                )
-            self.generic_visit(node)
-
-    finder = Finder()
-    for stmt in body:
-        finder.visit(stmt)
-    return diagnostics
-
-
-def _check_api_misuse(
-    body: Sequence[ast.AST],
-    code: str,
-    ctx_data: ContextData,
-    severity_level: str,
-) -> List[types.Diagnostic]:
-    """Heuristics for common API mistakes (list vs scalar, missing context, property calls)."""
-    diagnostics: list[types.Diagnostic] = []
-    module = ast.Module(body=list(body), type_ignores=[])
-    parent_map = _build_parent_map(module)
-    assigned_names = _collect_assigned_names(module)
-    type_map = _diagnostic_type_map(code)
-    context_seen: set[str] = set()
-
-    for node in ast.walk(module):
-        if isinstance(node, ast.Call):
-            diagnostics.extend(_context_call_diagnostics(node, ctx_data, severity_level, context_seen))
-            diagnostics.extend(_property_call_diagnostics(node, type_map, code, severity_level))
-        if isinstance(node, ast.Attribute):
-            diagnostics.extend(_uncalled_context_attr_diagnostics(node, assigned_names, severity_level))
-            diagnostics.extend(_iterable_attr_diagnostics(node, parent_map, type_map, code, severity_level))
-    return diagnostics
-
-
-def _context_call_diagnostics(
-    node: ast.Call,
-    ctx_data: ContextData,
-    severity_level: str,
-    seen: set[str],
-) -> List[types.Diagnostic]:
-    diagnostics: list[types.Diagnostic] = []
-    if isinstance(node.func, ast.Name):
-        if node.func.id == "character" and not ctx_data.character and "character" not in seen:
-            seen.add("character")
-            diagnostics.append(
-                _make_diagnostic(
-                    node.func,
-                    "No character context configured; character() will raise at runtime.",
-                    severity_level,
-                )
-            )
-        elif node.func.id == "combat" and not ctx_data.combat and "combat" not in seen:
-            seen.add("combat")
-            diagnostics.append(
-                _make_diagnostic(
-                    node.func,
-                    "No combat context configured; combat() will return None.",
-                    severity_level,
-                )
-            )
-    return diagnostics
-
-
-def _property_call_diagnostics(
-    node: ast.Call,
-    type_map: Dict[str, str],
-    code: str,
-    severity_level: str,
-) -> List[types.Diagnostic]:
-    if not isinstance(node.func, ast.Attribute):
-        return []
-    base_type = _resolve_expr_type(node.func.value, type_map, code)
-    if not base_type:
-        return []
-    meta = _type_meta(base_type)
-    attr = node.func.attr
-    if attr in meta.methods or attr not in meta.attrs:
-        return []
-    receiver = _expr_to_str(node.func.value) or base_type
-    return [
-        _make_diagnostic(
-            node.func,
-            f"'{attr}' on {receiver} is a property; drop the parentheses.",
-            severity_level,
-        )
-    ]
-
-
-def _uncalled_context_attr_diagnostics(
-    node: ast.Attribute,
-    assigned_names: Set[str],
-    severity_level: str,
-) -> List[types.Diagnostic]:
-    if isinstance(node.value, ast.Name) and node.value.id in {"character", "combat"} and node.value.id not in assigned_names:
-        call_hint = f"{node.value.id}()"
-        return [
-            _make_diagnostic(
-                node.value,
-                f"Call {call_hint} before accessing '{node.attr}'.",
-                severity_level,
-            )
-        ]
-    return []
-
-
-def _iterable_attr_diagnostics(
-    node: ast.Attribute,
-    parent_map: Dict[ast.AST, ast.AST],
-    type_map: Dict[str, str],
-    code: str,
-    severity_level: str,
-) -> List[types.Diagnostic]:
-    parent = parent_map.get(node)
-    if parent is None:
-        return []
-    if isinstance(parent, ast.Subscript) and parent.value is node:
-        return []
-
-    base_type = _resolve_expr_type(node.value, type_map, code)
-    if not base_type:
-        return []
-    meta = _type_meta(base_type)
-    attr_meta = meta.attrs.get(node.attr)
-    if not attr_meta:
-        return []
-
-    is_collection = bool(attr_meta.element_type) or attr_meta.type_name in {"list", "dict"}
-    if not is_collection:
-        return []
-
-    expr_label = _expr_to_str(node) or node.attr
-    element_label = attr_meta.element_type or "items"
-    container_label = attr_meta.type_name or "collection"
-
-    if isinstance(parent, ast.Attribute) and parent.value is node:
-        next_attr = parent.attr
-        message = f"'{expr_label}' is a {container_label} of {element_label}; index or iterate before accessing '{next_attr}'."
-        return [_make_diagnostic(node, message, severity_level)]
-
-    if isinstance(parent, ast.Call) and parent.func is node:
-        message = f"'{expr_label}' is a {container_label} of {element_label}; index or iterate before calling it."
-        return [_make_diagnostic(node, message, severity_level)]
-
-    return []
-
-
-def _diagnostic_type_map(code: str) -> Dict[str, str]:
-    mapping = _infer_type_map(code)
-    if mapping:
-        return mapping
-    wrapped, _ = _wrap_draconic(code)
-    return _infer_type_map(wrapped)
-
-
-def _resolve_expr_type(expr: ast.AST, type_map: Dict[str, str], code: str) -> str:
-    expr_text = _expr_to_str(expr)
-    if not expr_text:
-        return ""
-    return _resolve_type_name(expr_text, code, type_map)
-
-
-def _expr_to_str(expr: ast.AST) -> str:
-    try:
-        return ast.unparse(expr)
-    except Exception:
-        return ""
-
-
-def _collect_assigned_names(module: ast.Module) -> Set[str]:
-    assigned: set[str] = set()
-
-    class Collector(ast.NodeVisitor):
-        def visit_Assign(self, node: ast.Assign):
-            for target in node.targets:
-                assigned.update(_names_in_target(target))
-            self.generic_visit(node)
-
-        def visit_AnnAssign(self, node: ast.AnnAssign):
-            assigned.update(_names_in_target(node.target))
-            self.generic_visit(node)
-
-        def visit_For(self, node: ast.For):
-            assigned.update(_names_in_target(node.target))
-            self.generic_visit(node)
-
-        def visit_AsyncFor(self, node: ast.AsyncFor):
-            assigned.update(_names_in_target(node.target))
-            self.generic_visit(node)
-
-        def visit_FunctionDef(self, node: ast.FunctionDef):
-            assigned.add(node.name)
-            for arg in node.args.args:
-                assigned.add(arg.arg)
-            self.generic_visit(node)
-
-        def visit_ClassDef(self, node: ast.ClassDef):
-            assigned.add(node.name)
-            self.generic_visit(node)
-
-    Collector().visit(module)
-    return assigned
-
-
-def _build_parent_map(root: ast.AST) -> Dict[ast.AST, ast.AST]:
-    parents: dict[ast.AST, ast.AST] = {}
-    for parent in ast.walk(root):
-        for child in ast.iter_child_nodes(parent):
-            parents[child] = parent
-    return parents
-
-
-def _make_diagnostic(node: ast.AST, message: str, level: str) -> types.Diagnostic:
-    severity = SEVERITY.get(level, types.DiagnosticSeverity.Warning)
-    if hasattr(node, "lineno"):
-        rng = _range_from_positions(
-            getattr(node, "lineno", 1),
-            getattr(node, "col_offset", 0) + 1,
-            getattr(node, "end_lineno", None),
-            getattr(node, "end_col_offset", None),
-        )
-    else:
-        rng = types.Range(
-            start=types.Position(line=0, character=0),
-            end=types.Position(line=0, character=1),
-    )
-    return types.Diagnostic(
-        message=message,
-        range=rng,
-        severity=severity,
-        source="avrae-ls",
-    )
-
-
-def _shift_diagnostics(diags: List[types.Diagnostic], line_offset: int, char_offset: int) -> List[types.Diagnostic]:
-    shifted: list[types.Diagnostic] = []
-    for diag in diags:
-        shifted.append(
-            types.Diagnostic(
-                message=diag.message,
-                range=_shift_range(diag.range, line_offset, char_offset),
-                severity=diag.severity,
-                source=diag.source,
-                code=diag.code,
-                code_description=diag.code_description,
-                tags=diag.tags,
-                related_information=diag.related_information,
-                data=diag.data,
-            )
-        )
-    return shifted
-
-
-def _shift_range(rng: types.Range, line_offset: int, char_offset: int) -> types.Range:
-    def _shift_pos(pos: types.Position) -> types.Position:
-        return types.Position(
-            line=max(pos.line + line_offset, 0),
-            character=max(pos.character + (char_offset if pos.line == 0 else 0), 0),
-        )
-
-    return types.Range(start=_shift_pos(rng.start), end=_shift_pos(rng.end))
-
-
-def _wrap_draconic(code: str) -> tuple[str, int]:
-    indented = "\n".join(f"    {line}" for line in code.splitlines())
-    wrapped = f"def __alias_main__():\n{indented}\n__alias_main__()"
-    return wrapped, 1
-
-
-def _build_builtin_signatures() -> dict[str, inspect.Signature]:
-    sigs: dict[str, inspect.Signature] = {}
-    builtins = _default_builtins()
-
-    def try_add(name: str, obj):
-        try:
-            sigs[name] = inspect.signature(obj)
-        except (TypeError, ValueError):
-            pass
-
-    for name, obj in builtins.items():
-        try_add(name, obj)
-
-    # runtime helpers we expose
-    def get_gvar(key): ...
-    def get_svar(name, default=None): ...
-    def get_cvar(name, default=None): ...
-    def get_uvar(name, default=None): ...
-    def get_uvars(): ...
-    def set_uvar(name, value): ...
-    def set_uvar_nx(name, value): ...
-    def delete_uvar(name): ...
-    def uvar_exists(name): ...
-    def exists(name): ...
-    def get(name, default=None): ...
-    def using(**imports): ...
-    def signature(data=0): ...
-    def verify_signature(data): ...
-    def print_fn(*args, sep=" ", end="\n"): ...
-
-    helpers = {
-        "get_gvar": get_gvar,
-        "get_svar": get_svar,
-        "get_cvar": get_cvar,
-        "get_uvar": get_uvar,
-        "get_uvars": get_uvars,
-        "set_uvar": set_uvar,
-        "set_uvar_nx": set_uvar_nx,
-        "delete_uvar": delete_uvar,
-        "uvar_exists": uvar_exists,
-        "exists": exists,
-        "get": get,
-        "using": using,
-        "signature": signature,
-        "verify_signature": verify_signature,
-        "print": print_fn,
-    }
-    for name, obj in helpers.items():
-        try_add(name, obj)
-    return sigs
-
-
-def _check_call_args(
-    body: Sequence[ast.AST],
-    signatures: dict[str, inspect.Signature],
-    severity_level: str,
-) -> List[types.Diagnostic]:
-    diagnostics: list[types.Diagnostic] = []
-
-    class Visitor(ast.NodeVisitor):
-        def visit_Call(self, node: ast.Call):
-            if isinstance(node.func, ast.Name):
-                fn = node.func.id
-                if fn in signatures:
-                    sig = signatures[fn]
-                    if not _call_args_match(sig, node):
-                        diagnostics.append(
-                            _make_diagnostic(
-                                node.func,
-                                f"Call to '{fn}' may have invalid arguments",
-                                severity_level,
-                            )
-                        )
-            self.generic_visit(node)
-
-    visitor = Visitor()
-    for stmt in body:
-        visitor.visit(stmt)
-    return diagnostics
-
-
-def _call_args_match(sig: inspect.Signature, call: ast.Call) -> bool:
-    params = list(sig.parameters.values())
-    required = [
-        p
-        for p in params
-        if p.default is inspect._empty
-        and p.kind
-        in (
-            inspect.Parameter.POSITIONAL_ONLY,
-            inspect.Parameter.POSITIONAL_OR_KEYWORD,
-        )
-    ]
-    max_args = None
-    if any(p.kind == inspect.Parameter.VAR_POSITIONAL for p in params):
-        max_args = None
-    else:
-        max_args = len(
-            [
-                p
-                for p in params
-                if p.kind
-                in (
-                    inspect.Parameter.POSITIONAL_ONLY,
-                    inspect.Parameter.POSITIONAL_OR_KEYWORD,
-                )
-            ]
-        )
-
-    arg_count = len(call.args)
-    if arg_count < len(required):
-        return False
-    if max_args is not None and arg_count > max_args:
-        return False
-    return True
-
-
-def _check_imports(body: Sequence[ast.AST], severity_level: str) -> List[types.Diagnostic]:
-    diagnostics: list[types.Diagnostic] = []
-
-    class Visitor(ast.NodeVisitor):
-        def visit_Import(self, node: ast.Import):
-            diagnostics.append(_make_diagnostic(node, "Imports are not supported in draconic aliases", severity_level))
-
-        def visit_ImportFrom(self, node: ast.ImportFrom):
-            diagnostics.append(_make_diagnostic(node, "Imports are not supported in draconic aliases", severity_level))
-
-    visitor = Visitor()
-    for stmt in body:
-        visitor.visit(stmt)
-    return diagnostics
-
-
-def _range_from_positions(
-    lineno: int | None,
-    col_offset: int | None,
-    end_lineno: int | None,
-    end_col_offset: int | None,
-) -> types.Range:
-    start = types.Position(
-        line=max((lineno or 1) - 1, 0),
-        character=max((col_offset or 1) - 1, 0),
-    )
-    end = types.Position(
-        line=max(((end_lineno or lineno or 1) - 1), 0),
-        character=max(((end_col_offset or col_offset or 1) - 1), 0),
-    )
-    return types.Range(start=start, end=end)