PyPI - arelle-release - Versions diffs - 2.37.49__py3-none-any.whl → 2.37.51__py3-none-any.whl - Mend

arelle-release 2.37.49py3-none-any.whl → 2.37.51py3-none-any.whl

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Potentially problematic release.

This version of arelle-release might be problematic. Click here for more details.

Files changed (27) hide show

arelle/plugin/validate/EDINET/rules/gfm.py CHANGED Viewed

@@ -30,7 +30,7 @@ from arelle.utils.validate.Validation import Validation
 from arelle.utils.validate.ValidationUtil import etreeIterWithDepth
 from ..DisclosureSystems import (DISCLOSURE_SYSTEM_EDINET)
 from ..PluginValidationDataExtension import PluginValidationDataExtension
-from ..Constants import xhtmlDtdExtension
 _: TypeGetText
@@ -257,13 +257,14 @@ def rule_gfm_1_2_8(
     EDINET.EC5700W: [GFM 1.2.8] Every xbrli:context element must appear in at least one
     contextRef attribute in the same instance.
     """
-    unused_contexts = list(set(val.modelXbrl.contexts.values()) - set(val.modelXbrl.contextsInUse))
-    unused_contexts.sort(key=lambda x: x.id)
-    for context in unused_contexts:
+    unusedContexts = list(set(val.modelXbrl.contexts.values()) - set(val.modelXbrl.contextsInUse))
+    unusedContexts.extend(val.modelXbrl.ixdsUnmappedContexts.values())
+    unusedContexts.sort(key=lambda x: x.id if x.id is not None else "")
+    for context in unusedContexts:
         yield Validation.warning(
             codes='EDINET.EC5700W.GFM.1.2.8',
             msg=_('If you are not using a context, delete it if it is not needed.'),
-            modelObject = context
+            modelObject=context
         )
@@ -367,28 +368,15 @@ def rule_gfm_1_2_14(
     (a format that conforms to XML grammar, such as all start and end tags being paired, and the end tag of a nested tag not coming after the end tag of its parent tag, etc.).
     Please modify it so that it is well-formed.
     """
-    CDATApattern = regex.compile(r"<!\[CDATA\[(.+)\]\]")
-    dtd = DTD(os.path.join(val.modelXbrl.modelManager.cntlr.configDir, xhtmlDtdExtension))
-    htmlBodyTemplate = "<body><div>\n{0}\n</div></body>\n"
-    namedEntityPattern = regex.compile("&[_A-Za-z\xC0-\xD6\xD8-\xF6\xF8-\xFF\u0100-\u02FF\u0370-\u037D\u037F-\u1FFF\u200C-\u200D\u2070-\u218F\u2C00-\u2FEF\u3001-\uD7FF\uF900-\uFDCF\uFDF0-\uFFFD]"
-                                    r"[_\-\.:"
-                                    "\xB7A-Za-z0-9\xC0-\xD6\xD8-\xF6\xF8-\xFF\u0100-\u02FF\u0370-\u037D\u037F-\u1FFF\u200C-\u200D\u2070-\u218F\u2C00-\u2FEF\u3001-\uD7FF\uF900-\uFDCF\uFDF0-\uFFFD\u0300-\u036F\u203F-\u2040]*;")
-    XMLpattern = regex.compile(r".*(<|&lt;|&#x3C;|&#60;)[A-Za-z_]+[A-Za-z0-9_:]*[^>]*(/>|>|&gt;|/&gt;).*", regex.DOTALL)
-    for fact in val.modelXbrl.facts:
-        concept = fact.concept
-        if not fact.isNil and concept is not None and concept.isTextBlock and XMLpattern.match(fact.value):
-            for xmlText in [fact.value] + CDATApattern.findall(fact.value):
-                xmlBodyWithoutEntities = htmlBodyTemplate.format(namedEntityPattern.sub("", xmlText).replace('&','&amp;'))
-                textblockXml = XML(xmlBodyWithoutEntities)
-                if not dtd.validate(textblockXml):
-                    yield Validation.warning(
-                        codes='EDINET.EC5700W.GFM.1.2.14',
-                        msg=_('The content of an element with a data type of nonnum:textBlockItemType is not well-formed XML (a format that conforms to XML grammar, '
-                              'such as all start and end tags being in pairs, and the end tag of a nested tag not coming after the end tag of its parent tag). '
-                              'Correct the content so that it is well-formed.'),
-                        modelObject = fact
-                    )
+    problematicFacts = pluginData.getProblematicTextBlocks(val.modelXbrl)
+    if len(problematicFacts) > 0:
+        yield Validation.warning(
+            codes='EDINET.EC5700W.GFM.1.2.14',
+            msg=_('The content of an element with a data type of nonnum:textBlockItemType is not well-formed XML (a format that conforms to XML grammar, '
+                  'such as all start and end tags being in pairs, and the end tag of a nested tag not coming after the end tag of its parent tag). '
+                  'Correct the content so that it is well-formed.'),
+            modelObject = problematicFacts
+        )
 @validation(
@@ -484,6 +472,7 @@ def rule_gfm_1_2_25(
             XbrlConst.qnXbrliEndDate.clarkNotation,
             XbrlConst.qnXbrliInstant.clarkNotation
         ):
+            elt = cast(ModelObject, elt)
             dateText = XmlUtil.text(elt)
             if not GFM_CONTEXT_DATE_PATTERN.match(dateText):
                 errors.append(elt)
@@ -558,12 +547,14 @@ def rule_gfm_1_2_27(
     EDINET.EC5700W: [GFM 1.2.27] An instance must not contain unused units.
     """
     # TODO: Consolidate validations involving unused units
-    unusedUnits = set(val.modelXbrl.units.values()) - {fact.unit for fact in val.modelXbrl.facts if fact.unit is not None}
+    unusedUnits = list(set(val.modelXbrl.units.values()) - set(val.modelXbrl.unitsInUse))
+    unusedUnits.extend(val.modelXbrl.ixdsUnmappedUnits.values())
+    unusedUnits.sort(key=lambda x: x.hash)
     if len(unusedUnits) > 0:
         yield Validation.warning(
             codes='EDINET.EC5700W.GFM.1.2.27',
             msg=_("Delete unused units from the instance."),
-            modelObject=list(unusedUnits)
+            modelObject=unusedUnits
         )

arelle/plugin/validate/EDINET/rules/upload.py CHANGED Viewed

@@ -16,7 +16,7 @@ from arelle.utils.PluginHooks import ValidationHook
 from arelle.utils.validate.Decorator import validation
 from arelle.utils.validate.Validation import Validation
 from ..DisclosureSystems import (DISCLOSURE_SYSTEM_EDINET)
-from ..InstanceType import InstanceType, HTML_EXTENSIONS, IMAGE_EXTENSIONS
+from ..ReportFolderType import ReportFolderType, HTML_EXTENSIONS, IMAGE_EXTENSIONS
 from ..PluginValidationDataExtension import PluginValidationDataExtension
 if TYPE_CHECKING:
@@ -24,6 +24,16 @@ if TYPE_CHECKING:
 _: TypeGetText
+ALLOWED_ROOT_FOLDERS = {
+    "AttachDoc",
+    "AuditDoc",
+    "PrivateAttach",
+    "PrivateDoc",
+    "PublicAttach",
+    "PublicDoc",
+    "XBRL",
+}
 FILE_COUNT_LIMITS = {
     Path("AttachDoc"): 990,
     Path("AuditDoc"): 990,
@@ -43,7 +53,7 @@ FILENAME_STEM_PATTERN = re.compile(r'[a-zA-Z0-9_-]*')
     hook=ValidationHook.FILESOURCE,
     disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
 )
-def rule_EC0121E(
+def rule_EC0100E(
         pluginData: ControllerPluginData,
         cntlr: Cntlr,
         fileSource: FileSource,
@@ -51,30 +61,32 @@ def rule_EC0121E(
         **kwargs: Any,
 ) -> Iterable[Validation]:
     """
-    EDINET.EC0121E: There is a directory or file that contains more than 31 characters
-    or uses characters other than those allowed (alphanumeric characters, '-' and '_').
-    Note: Sample instances from EDINET almost always violate this rule based on our
-    current interpretation. The exception being files placed outside the XBRL directory,
-    i.e. amendment documents. For now, we will only check amendment documents, directory
-    names, or other files in unexpected locations.
+    EDINET.EC0100E: An illegal directory is found directly under the transferred directory.
+    Only the following root folders are allowed:
+        AttachDoc
+        AuditDoc*
+        PrivateAttach
+        PrivateDoc*
+        PublicAttach
+        PublicDoc*
+        XBRL
+    * Only when reporting corrections
+    NOTE: since we do not have access to the submission type, we can't determine if the submission is a correction or not.
+    For this implementation, we will allow all directories that may be valid for at least one submission type.
+    This allows for a false-negative outcome when a non-correction submission has a correction-only root directory.
     """
     uploadContents = pluginData.getUploadContents(fileSource)
-    paths = set(uploadContents.directories | uploadContents.unknownPaths)
-    for amendmentPaths in uploadContents.amendmentPaths.values():
-        paths.update(amendmentPaths)
-    for path in paths:
-        if len(str(path.name)) > 31 or not FILENAME_STEM_PATTERN.match(path.stem):
+    for path, pathInfo in uploadContents.uploadPaths.items():
+        if pathInfo.isRoot and path.name not in ALLOWED_ROOT_FOLDERS:
             yield Validation.error(
-                codes='EDINET.EC0121E',
-                msg=_("There is a directory or file in '%(directory)s' that contains more than 31 characters "
-                      "or uses characters other than those allowed (alphanumeric characters, '-' and '_'). "
-                      "Directory or file name: '%(basename)s'. "
-                      "Please change the file name (or folder name) to within 31 characters and to usable "
-                      "characters, and upload again."),
-                directory=str(path.parent),
-                basename=path.name,
-                file=str(path)
+                codes='EDINET.EC0100E',
+                msg=_("An illegal directory is found directly under the transferred directory. "
+                      "Directory name or file name: '%(rootDirectory)s'. "
+                      "Delete all folders except the following folders that exist directly "
+                      "under the root folder, and then upload again: %(allowedDirectories)s."),
+                rootDirectory=path.name,
+                allowedDirectories=', '.join(f"'{d}'" for d in ALLOWED_ROOT_FOLDERS)
             )
@@ -82,7 +94,7 @@ def rule_EC0121E(
     hook=ValidationHook.FILESOURCE,
     disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
 )
-def rule_EC0124E(
+def rule_EC0124E_EC0187E(
         pluginData: ControllerPluginData,
         cntlr: Cntlr,
         fileSource: FileSource,
@@ -90,7 +102,8 @@ def rule_EC0124E(
         **kwargs: Any,
 ) -> Iterable[Validation]:
     """
-    EDINET.EC0124E: There are no empty directories.
+    EDINET.EC0124E: There are no empty root directories.
+    EDINET.EC0187E: There are no empty subdirectories.
     """
     uploadFilepaths = pluginData.getUploadFilepaths(fileSource)
     emptyDirectories = []
@@ -98,15 +111,24 @@ def rule_EC0124E(
         if path.suffix:
             continue
         if not any(path in p.parents for p in uploadFilepaths):
-            emptyDirectories.append(str(path))
+            emptyDirectories.append(path)
     for emptyDirectory in emptyDirectories:
-        yield Validation.error(
-            codes='EDINET.EC0124E',
-            msg=_("There is no file directly under '%(emptyDirectory)s'. "
-                  "No empty folders. "
-                  "Please store the file in the appropriate folder or delete the folder and upload again."),
-            emptyDirectory=emptyDirectory,
-        )
+        if len(emptyDirectory.parts) <= 1:
+            yield Validation.error(
+                codes='EDINET.EC0124E',
+                msg=_("There is no file directly under '%(emptyDirectory)s'. "
+                      "No empty root folders. "
+                      "Please store the file in the appropriate folder or delete the folder and upload again."),
+                emptyDirectory=str(emptyDirectory),
+            )
+        else:
+            yield Validation.error(
+                codes='EDINET.EC0187E',
+                msg=_("'%(parentDirectory)s' contains a subordinate directory ('%(emptyDirectory)s') with no files. "
+                      "Please store the file in the corresponding subfolder or delete the subfolder and upload again."),
+                parentDirectory=str(emptyDirectory.parent),
+                emptyDirectory=str(emptyDirectory),
+            )
 @validation(
@@ -160,22 +182,13 @@ def rule_EC0130E(
     EDINET.EC0130E: File extensions must match the file extensions allowed in Figure 2-1-3 and Figure 2-1-5.
     """
     uploadContents = pluginData.getUploadContents(fileSource)
-    checks = []
-    for instanceType, amendmentPaths in uploadContents.amendmentPaths.items():
-        for amendmentPath in amendmentPaths:
-            isSubdirectory = amendmentPath.parent.name != instanceType.value
-            checks.append((amendmentPath, True, instanceType, isSubdirectory))
-    for instanceType, formPaths in uploadContents.instances.items():
-        for amendmentPath in formPaths:
-            isSubdirectory = amendmentPath.parent.name != instanceType.value
-            checks.append((amendmentPath, False, instanceType, isSubdirectory))
-    for path, isAmendment, instanceType, isSubdirectory in checks:
-        ext = path.suffix
-        if len(ext) == 0:
+    for path, pathInfo in uploadContents.uploadPaths.items():
+        if pathInfo.reportFolderType is None or pathInfo.isDirectory:
             continue
-        validExtensions = instanceType.getValidExtensions(isAmendment, isSubdirectory)
+        validExtensions = pathInfo.reportFolderType.getValidExtensions(pathInfo.isCorrection, pathInfo.isSubdirectory)
         if validExtensions is None:
             continue
+        ext = path.suffix
         if ext not in validExtensions:
             yield Validation.error(
                 codes='EDINET.EC0130E',
@@ -207,18 +220,17 @@ def rule_EC0132E(
     EDINET.EC0132E: Store the manifest file directly under the relevant folder.
     """
     uploadContents = pluginData.getUploadContents(fileSource)
-    for instanceType in (InstanceType.AUDIT_DOC, InstanceType.PRIVATE_DOC, InstanceType.PUBLIC_DOC):
-        if instanceType not in uploadContents.instances:
+    for reportFolderType, paths in uploadContents.reports.items():
+        if reportFolderType.isAttachment:
             continue
-        if instanceType.manifestPath in uploadContents.instances.get(instanceType, []):
-            continue
-        yield Validation.error(
-            codes='EDINET.EC0132E',
-            msg=_("'%(expectedManifestName)s' does not exist in '%(expectedManifestDirectory)s'. "
-                  "Please store the manifest file (or cover file) directly under the relevant folder and upload it again. "),
-            expectedManifestName=instanceType.manifestPath.name,
-            expectedManifestDirectory=str(instanceType.manifestPath.parent),
-        )
+        if reportFolderType.manifestPath not in paths:
+            yield Validation.error(
+                codes='EDINET.EC0132E',
+                msg=_("'%(expectedManifestName)s' does not exist in '%(expectedManifestDirectory)s'. "
+                      "Please store the manifest file (or cover file) directly under the relevant folder and upload it again. "),
+                expectedManifestName=reportFolderType.manifestPath.name,
+                expectedManifestDirectory=str(reportFolderType.manifestPath.parent),
+            )
 @validation(
@@ -279,6 +291,36 @@ def rule_EC0188E(
             )
+@validation(
+    hook=ValidationHook.FILESOURCE,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_EC0192E(
+        pluginData: ControllerPluginData,
+        cntlr: Cntlr,
+        fileSource: FileSource,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC0192E: The cover file for PrivateDoc cannot be set because it uses a
+    PublicDoc cover file. Please delete the cover file from PrivateDoc and upload
+    it again.
+    """
+    uploadContents = pluginData.getUploadContents(fileSource)
+    for path, pathInfo in uploadContents.uploadPaths.items():
+        if not pathInfo.isCoverPage:
+            continue
+        # Only applies to PrivateDoc correction reports
+        if pathInfo.isCorrection and pathInfo.reportFolderType == ReportFolderType.PRIVATE_DOC:
+            yield Validation.error(
+                codes='EDINET.EC0192E',
+                msg=_("The cover file for PrivateDoc ('%(file)s') cannot be set because it uses a PublicDoc cover file. "
+                      "Please delete the cover file from PrivateDoc and upload it again."),
+                file=str(path),
+            )
 @validation(
     hook=ValidationHook.FILESOURCE,
     disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
@@ -315,6 +357,82 @@ def rule_EC0198E(
             )
+@validation(
+    hook=ValidationHook.FILESOURCE,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_EC0233E(
+        pluginData: ControllerPluginData,
+        cntlr: Cntlr,
+        fileSource: FileSource,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC0233E: There is a file in the report directory that comes before the cover file
+    in file name sort order.
+    NOTE: This includes files in subdirectories. For example, PublicDoc/00000000_images/image.png
+    comes before PublicDoc/0000000_header_*.htm
+    """
+    uploadContents = pluginData.getUploadContents(fileSource)
+    directories = defaultdict(list)
+    for path in uploadContents.sortedPaths:
+        pathInfo = uploadContents.uploadPaths[path]
+        if pathInfo.isDirectory:
+            continue
+        if pathInfo.reportFolderType in (ReportFolderType.PRIVATE_DOC, ReportFolderType.PUBLIC_DOC):
+            directories[pathInfo.reportPath].append(pathInfo)
+    for reportPath, pathInfos in directories.items():
+        coverPagePath = next(iter(p for p in pathInfos if p.isCoverPage), None)
+        if coverPagePath is None:
+            continue
+        errorPathInfos = pathInfos[:pathInfos.index(coverPagePath)]
+        for pathInfo in errorPathInfos:
+            yield Validation.error(
+                codes='EDINET.EC0233E',
+                msg=_("There is a file in the report directory in '%(reportPath)s' that comes before the cover "
+                      "file ('%(coverPage)s') in file name sort order. "
+                      "Directory name or file name: '%(path)s'. "
+                      "Please make sure that there are no files that come before the cover file in the file "
+                      "name sort order, and then upload again."),
+                reportPath=str(reportPath),
+                coverPage=str(coverPagePath.path.name),
+                path=str(pathInfo.path),
+            )
+@validation(
+    hook=ValidationHook.FILESOURCE,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_EC0234E(
+        pluginData: ControllerPluginData,
+        cntlr: Cntlr,
+        fileSource: FileSource,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC0234E: A cover file exists in an unsupported subdirectory.
+    """
+    uploadContents = pluginData.getUploadContents(fileSource)
+    for path, pathInfo in uploadContents.uploadPaths.items():
+        if pathInfo.isDirectory:
+            continue
+        if pathInfo.reportFolderType not in (ReportFolderType.PRIVATE_DOC, ReportFolderType.PUBLIC_DOC):
+            continue
+        if pathInfo.isSubdirectory and pathInfo.isCoverPage:
+            yield Validation.error(
+                codes='EDINET.EC0234E',
+                msg=_("A cover file ('%(coverPage)s') exists in an unsupported subdirectory. "
+                      "Directory: '%(directory)s'. "
+                      "Please make sure there is no cover file in the subfolder and upload again."),
+                coverPage=str(path.name),
+                directory=str(path.parent),
+            )
 @validation(
     hook=ValidationHook.FILESOURCE,
     disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
@@ -444,6 +562,61 @@ def rule_EC1020E(
             )
+@validation(
+    hook=ValidationHook.FILESOURCE,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_filenames(
+        pluginData: ControllerPluginData,
+        cntlr: Cntlr,
+        fileSource: FileSource,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC0121E: There is a directory or file that contains
+    more than 31 characters or uses characters other than those allowed (alphanumeric characters,
+    '-' and '_').
+    Note: Applies to everything EXCEPT files directly beneath non-correction report folders.
+    EDINET.EC0200E: There is a file that uses characters other
+    than those allowed (alphanumeric characters, '-' and '_').
+    Note: Applies ONLY to files directly beneath non-correction report folders.
+    """
+    for path, pathInfo in pluginData.getUploadContents(fileSource).uploadPaths.items():
+        isReportFile = (
+            not pathInfo.isAttachment and
+            not pathInfo.isCorrection and
+            not pathInfo.isDirectory and
+            not pathInfo.isSubdirectory
+        )
+        charactersAreValid = FILENAME_STEM_PATTERN.fullmatch(path.stem)
+        lengthIsValid = isReportFile or (len(path.name) <= 31)
+        if charactersAreValid and lengthIsValid:
+            continue
+        if isReportFile:
+            yield Validation.error(
+                codes='EDINET.EC0200E',
+                msg=_("There is a file inside the XBRL directory that uses characters "
+                      "other than those allowed (alphanumeric characters, '-' and '_'). "
+                      "File: '%(path)s'. "
+                      "Please change the filename to usable characters, and upload again."),
+                path=str(path)
+            )
+        else:
+            yield Validation.error(
+                codes='EDINET.EC0121E',
+                msg=_("There is a directory or file in '%(directory)s' that contains more "
+                      "than 31 characters or uses characters other than those allowed "
+                      "(alphanumeric characters, '-' and '_'). "
+                      "Directory or filename: '%(basename)s'. "
+                      "Please change the file name (or folder name) to within 31 characters and to usable "
+                      "characters, and upload again."),
+                directory=str(path.parent),
+                basename=path.name,
+            )
 @validation(
     hook=ValidationHook.FILESOURCE,
     disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],

arelle/plugin/validate/ESEF/ESEF_2021/ValidateXbrlFinally.py CHANGED Viewed

@@ -529,11 +529,11 @@ def validateXbrlFinally(val: ValidateXbrl, *args: Any, **kwargs: Any) -> None:
         if contextsWithDisallowedOCEs:
             modelXbrl.error("ESEF.2.1.3.segmentUsed",
                 _("xbrli:segment container MUST NOT be used in contexts: %(contextIds)s"),
-                modelObject=contextsWithDisallowedOCEs, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEs))
+                modelObject=contextsWithDisallowedOCEs, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEs if c.id is not None))
         if contextsWithDisallowedOCEcontent:
             modelXbrl.error("ESEF.2.1.3.scenarioContainsNonDimensionalContent",
                 _("xbrli:scenario in contexts MUST NOT contain any other content than defined in XBRL Dimensions specification: %(contextIds)s"),
-                modelObject=contextsWithDisallowedOCEcontent, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEcontent))
+                modelObject=contextsWithDisallowedOCEcontent, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEcontent if c.id is not None))
         if len(contextIdentifiers) > 1:
             modelXbrl.error("ESEF.2.1.4.multipleIdentifiers",
                 _("All entity identifiers in contexts MUST have identical content: %(contextIds)s"),

arelle/plugin/validate/ESEF/ESEF_Current/ValidateXbrlFinally.py CHANGED Viewed

@@ -589,11 +589,11 @@ def validateXbrlFinally(val: ValidateXbrl, *args: Any, **kwargs: Any) -> None:
         if contextsWithDisallowedOCEs:
             modelXbrl.error("ESEF.2.1.3.segmentUsed",
                 _("xbrli:segment container MUST NOT be used in contexts: %(contextIds)s"),
-                modelObject=contextsWithDisallowedOCEs, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEs))
+                modelObject=contextsWithDisallowedOCEs, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEs if c.id is not None))
         if contextsWithDisallowedOCEcontent:
             modelXbrl.error("ESEF.2.1.3.scenarioContainsNonDimensionalContent",
                 _("xbrli:scenario in contexts MUST NOT contain any other content than defined in XBRL Dimensions specification: %(contextIds)s"),
-                modelObject=contextsWithDisallowedOCEcontent, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEcontent))
+                modelObject=contextsWithDisallowedOCEcontent, contextIds=", ".join(c.id for c in contextsWithDisallowedOCEcontent if c.id is not None))
         if len(contextIdentifiers) > 1:
             modelXbrl.error("ESEF.2.1.4.multipleIdentifiers",
                 _("All entity identifiers in contexts MUST have identical content: %(contextIds)s"),

arelle/plugin/validate/NL/PluginValidationDataExtension.py CHANGED Viewed

@@ -265,7 +265,7 @@ class PluginValidationDataExtension(PluginData):
                             contextsWithPeriodTimeZone.append(context)
                 if context.hasSegment:
                     contextsWithSegments.append(context)
-                if context.nonDimValues("scenario"):  # type: ignore[no-untyped-call]
+                if context.nonDimValues("scenario"):
                     contextsWithImproperContent.append(context)
         return ContextData(
             contextsWithImproperContent=contextsWithImproperContent,

arelle/plugin/validate/NL/rules/fr_nl.py CHANGED Viewed

@@ -552,9 +552,9 @@ def rule_fr_nl_3_03(
     """
     FR-NL-3.03: An XBRL instance document MUST NOT contain unused contexts
     """
-    unused_contexts = list(set(val.modelXbrl.contexts.values()) - set(val.modelXbrl.contextsInUse))
-    unused_contexts.sort(key=lambda x: x.id)
-    for context in unused_contexts:
+    unusedContexts = list(set(val.modelXbrl.contexts.values()) - set(val.modelXbrl.contextsInUse))
+    unusedContexts.sort(key=lambda x: x.id if x.id is not None else "")
+    for context in unusedContexts:
         yield Validation.error(
             codes='NL.FR-NL-3.03',
             msg=_('Unused context must not exist in XBRL instance document'),
@@ -637,10 +637,9 @@ def rule_fr_nl_4_02(
     """
     FR-NL-4.02: An XBRL instance document MUST NOT contain unused 'xbrli:unit' elements
     """
-    unused_units_set = set(val.modelXbrl.units.values()) - {fact.unit for fact in val.modelXbrl.facts if fact.unit is not None}
-    unused_units = list(unused_units_set)
-    unused_units.sort(key=lambda x: x.hash)
-    for unit in unused_units:
+    unusedUnits = list(set(val.modelXbrl.units.values()) - set(val.modelXbrl.unitsInUse))
+    unusedUnits.sort(key=lambda x: x.hash)
+    for unit in unusedUnits:
         yield Validation.error(
             codes='NL.FR-NL-4.02',
             msg=_('Unused unit must not exist in the XBRL instance document'),

arelle-release 2.37.49__py3-none-any.whl → 2.37.51__py3-none-any.whl

Potentially problematic release.

arelle-release 2.37.49py3-none-any.whl → 2.37.51py3-none-any.whl