arelle-release 2.37.46__py3-none-any.whl → 2.38.0__py3-none-any.whl

arelle/Validate.py

@@ -14,6 +14,7 @@ from arelle import (FileSource, ModelXbrl, ModelDocument, ModelVersReport, XbrlC
                ValidateXbrl, ValidateVersReport,
                ValidateInfoset, ViewFileRenderedLayout, UrlUtil)
 from arelle.PythonUtil import isLegacyAbs
+from arelle.ValidateFileSource import ValidateFileSource
 from arelle.formula import ValidateFormula
 from arelle.ModelDocument import Type, ModelDocumentReference, load as modelDocumentLoad
 from arelle.ModelDtsObject import ModelResource
@@ -24,7 +25,6 @@ from arelle.ModelTestcaseObject import testcaseVariationsByTarget, ModelTestcase
 from arelle.ModelValue import (qname, QName)
 from arelle.PluginManager import pluginClassMethods
 from arelle.packages.report.DetectReportPackage import isReportPackageExtension
-from arelle.packages.report.ReportPackageValidator import ReportPackageValidator
 from arelle.rendering import RenderingEvaluator
 from arelle.utils.EntryPointDetection import filesourceEntrypointFiles
 from arelle.XmlUtil import collapseWhitespace, xmlstring
@@ -126,10 +126,6 @@ class Validate:
         elif self.modelXbrl.modelDocument.type == Type.RSSFEED:
             self.validateRssFeed()
         else:
-            if self.modelXbrl.fileSource.isReportPackage or self.modelXbrl.modelManager.validateAllFilesAsReportPackages:
-                rpValidator = ReportPackageValidator(self.modelXbrl.fileSource)
-                for val in rpValidator.validate():
-                    self.modelXbrl.log(level=val.level.name, codes=val.codes, msg=val.msg, modelXbrl=self.modelXbrl, **val.args)
             try:
                 self.instValidator.validate(self.modelXbrl, self.modelXbrl.modelManager.formulaOptions.typedParameters(self.modelXbrl.prefixedNamespaces))
                 self.instValidator.close()
@@ -137,9 +133,10 @@ class Validate:
                 self.modelXbrl.error("exception:" + type(err).__name__,
                     _("Instance validation exception: %(error)s, instance: %(instance)s"),
                     modelXbrl=self.modelXbrl,
-                    instance=self.modelXbrl.modelDocument.basename, error=err,
+                    instance=self.modelXbrl.modelDocument.basename if hasattr(self.modelXbrl, "modelDocument") and hasattr(self.modelXbrl.modelDocument, "basename") else "(closed)",
+                    error=err,
                     # traceback=traceback.format_tb(sys.exc_info()[2]),
-                    exc_info=(type(err) is not AssertionError))
+                    exc_info=True)
         self.close()
 
     def validateRssFeed(self):
@@ -304,6 +301,7 @@ class Validate:
     def _testcaseLoadReadMeFirstUri(self, testcase, modelTestcaseVariation, index, readMeFirstUri, resultIsVersioningReport, resultIsTaxonomyPackage, inputDTSes, errorCaptureLevel, baseForElement, parameters):
         preLoadingErrors = [] # accumulate pre-loading errors, such as during taxonomy package loading
         loadedModels = []
+        filesource = None
         readMeFirstElements = modelTestcaseVariation.readMeFirstElements
         expectTaxonomyPackage = (index < len(readMeFirstElements) and
                                     readMeFirstElements[index] is not None and
@@ -387,10 +385,11 @@ class Validate:
                     pluginXbrlMethod(self, _rptPkgIxdsOptions)
                 reportPackageErrors = False
                 if (filesource.isReportPackage or self.modelXbrl.modelManager.validateAllFilesAsReportPackages) and not _rptPkgIxdsOptions:
-                    rpValidator = ReportPackageValidator(filesource)
-                    for val in rpValidator.validate():
+                    preLoadingErrorsCount = len(preLoadingErrors)
+                    fileSourceValidator = ValidateFileSource(self.modelXbrl.modelManager.cntlr, filesource)
+                    fileSourceValidator.validate(self.modelXbrl.modelManager.validateAllFilesAsReportPackages, preLoadingErrors)
+                    if len(preLoadingErrors) > preLoadingErrorsCount:
                         reportPackageErrors = True
-                        preLoadingErrors.append(val.codes)
                 if filesource and not filesource.selection and filesource.isArchive:
                     try:
                         if filesource.isTaxonomyPackage or expectTaxonomyPackage:
@@ -398,6 +397,8 @@ class Validate:
                             filesource.select(None) # must select loadable reports (not the taxonomy package itself)
                         elif not filesource.isReportPackage:
                             entrypoints = filesourceEntrypointFiles(filesource)
+                            fileSourceValidator = ValidateFileSource(self.modelXbrl.modelManager.cntlr, filesource)
+                            fileSourceValidator.validate(self.modelXbrl.modelManager.validateAllFilesAsReportPackages, preLoadingErrors)
                             if entrypoints:
                                 # resolve an IXDS in entrypoints
                                 for pluginXbrlMethod in pluginClassMethods("ModelTestcaseVariation.ArchiveIxds"):
@@ -421,6 +422,8 @@ class Validate:
                     if not reportPackageErrors:
                         assert isinstance(filesource.basefile, str)
                         if entrypoints := filesourceEntrypointFiles(filesource):
+                            fileSourceValidator = ValidateFileSource(self.modelXbrl.modelManager.cntlr, filesource)
+                            fileSourceValidator.validate(self.modelXbrl.modelManager.validateAllFilesAsReportPackages, preLoadingErrors)
                             for pluginXbrlMethod in pluginClassMethods("ModelTestcaseVariation.ArchiveIxds"):
                                 pluginXbrlMethod(self, filesource, entrypoints)
                             for entrypoint in entrypoints:
@@ -486,8 +489,10 @@ class Validate:
                 except Exception as err:
                     model.error("exception:" + type(err).__name__,
                         _("Testcase variation validation exception: %(error)s, instance: %(instance)s"),
-                        modelXbrl=model, instance=model.modelDocument.basename, error=err, exc_info=(type(err) is not AssertionError))
+                        modelXbrl=model, instance=model.modelDocument.basename, error=err, exc_info=True)
                 model.hasFormulae = _hasFormulae
+        for pluginXbrlMethod in pluginClassMethods("Validate.Complete"):
+            pluginXbrlMethod(self.modelXbrl.modelManager.cntlr, filesource)
         errors = [error for model in loadedModels for error in model.errors]
         for err in preLoadingErrors:
             if err not in errors:
@@ -570,7 +575,7 @@ class Validate:
             except Exception as err:
                 modelXbrl.error("exception:" + type(err).__name__,
                     _("Testcase formula variation validation exception: %(error)s, instance: %(instance)s"),
-                    modelXbrl=modelXbrl, instance=modelXbrl.modelDocument.basename, error=err, exc_info=(type(err) is not AssertionError))
+                    modelXbrl=modelXbrl, instance=modelXbrl.modelDocument.basename, error=err, exc_info=True)
         if modelTestcaseVariation.resultIsInfoset and self.modelXbrl.modelManager.validateInfoset:
             for pluginXbrlMethod in pluginClassMethods("Validate.Infoset"):
                 pluginXbrlMethod(modelXbrl, modelTestcaseVariation.resultInfosetUri)

arelle/ValidateDuplicateFacts.py

@@ -207,6 +207,8 @@ class DuplicateFactSet:
         :return: A subset of the facts where the fact of lower precision in every consistent pair has been removed.
         """
         facts = self.deduplicateCompleteSubsets()
+        if len(facts) < 2:
+            return facts
         if not self.areNumeric:
             # Consistency is equivalent to completeness for non-numeric facts
             return facts
@@ -402,7 +404,7 @@ def getAspectEqualFacts(
                 fact.qname,
                 (
                     cast(str, fact.xmlLang or "").lower()
-                    if useLang and fact.concept.type.isWgnStringFactType
+                    if useLang and fact.concept.type.isOimTextFactType
                     else None
                 ),
             )

arelle/ValidateFileSource.py

@@ -0,0 +1,38 @@
+"""
+See COPYRIGHT.md for copyright information.
+"""
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+from arelle import PluginManager
+from arelle.packages.report.ReportPackageValidator import ReportPackageValidator
+
+if TYPE_CHECKING:
+    from arelle.Cntlr import Cntlr
+    from arelle.FileSource import FileSource
+
+
+class ValidateFileSource:
+    def __init__(self, cntrl: Cntlr, filesource: FileSource):
+        self._cntrl = cntrl
+        self._filesource = filesource
+
+    def validate(self, forceValidateAsReportPackages: bool = False, errors: list[str] | None = None) -> None:
+        for pluginXbrlMethod in PluginManager.pluginClassMethods("Validate.FileSource"):
+            pluginXbrlMethod(self._cntrl, self._filesource)
+
+        if self._filesource.isReportPackage or forceValidateAsReportPackages:
+            rpValidator = ReportPackageValidator(self._filesource)
+            for val in rpValidator.validate():
+                codes = [val.codes] if isinstance(val.codes, str) else val.codes
+                for code in codes:
+                    self._cntrl.addToLog(
+                        messageCode=code,
+                        message=val.msg,
+                        messageArgs=val.args,
+                        level=val.level.name,
+                    )
+                if errors is not None:
+                    errors.append(code)

arelle/ValidateFilingText.py

@@ -13,7 +13,7 @@ from arelle.PythonUtil import isLegacyAbs
 from arelle.XbrlConst import ixbrlAll, xhtml
 from arelle.XmlUtil import setXmlns, xmlstring, xmlDeclarationPattern, XmlDeclarationLocationException
 from arelle.ModelObject import ModelObject
-from arelle.UrlUtil import decodeBase64DataImage, isHttpUrl, scheme
+from arelle.UrlUtil import decodeBase64DataImage, isExternalUrl, isHttpUrl, scheme
 
 XMLpattern = re.compile(r".*(<|&lt;|&#x3C;|&#60;)[A-Za-z_]+[A-Za-z0-9_:]*[^>]*(/>|>|&gt;|/&gt;).*", re.DOTALL)
 CDATApattern = re.compile(r"<!\[CDATA\[(.+)\]\]")
@@ -631,7 +631,7 @@ def validateTextBlockFacts(modelXbrl):
                                         attribute=attrTag, element=eltTag)
                                 elif eltTag == "a" and (not allowedExternalHrefPattern or allowedExternalHrefPattern.match(attrValue)):
                                     pass
-                                elif scheme(attrValue) in ("http", "https", "ftp"):
+                                elif isExternalUrl(attrValue):
                                     modelXbrl.error(("EFM.6.05.16.externalReference", "FERC.6.05.16.externalReference"),
                                         _("Fact %(fact)s of context %(contextID)s has an invalid external reference in '%(attribute)s' for <%(element)s>"),
                                         modelObject=f1, fact=f1.qname, contextID=f1.contextID,
@@ -773,7 +773,7 @@ def validateHtmlContent(modelXbrl, referenceElt, htmlEltTree, validatedObjectLab
                         messageCodes=("EFM.6.05.34.activeContent", "EFM.5.02.05.activeContent", "FERC.6.05.34.activeContent", "FERC.5.02.05.activeContent"))
                 elif eltTag == "a" and (not allowedExternalHrefPattern or allowedExternalHrefPattern.match(attrValue)):
                     pass
-                elif scheme(attrValue) in ("http", "https", "ftp"):
+                elif isExternalUrl(attrValue):
                     modelXbrl.error(messageCodePrefix + "externalReference",
                         _("%(validatedObjectLabel)s has an invalid external reference in '%(attribute)s' for <%(element)s>: %(value)s"),
                         modelObject=elt, validatedObjectLabel=validatedObjectLabel,

arelle/ValidateXbrl.py

@@ -147,6 +147,8 @@ class ValidateXbrl:
             if arcrole.startswith("XBRL-") or ELR is None or \
                 linkqname is None or arcqname is None:
                 continue
+            elif arcrole in self.modelXbrl.modelManager.disclosureSystem.arcroleCyclesAllowed:
+                cyclesAllowed, specSect = self.modelXbrl.modelManager.disclosureSystem.arcroleCyclesAllowed[arcrole]
             elif arcrole in XbrlConst.standardArcroleCyclesAllowed:
                 # TODO: table should be in this module, where it is used
                 cyclesAllowed, specSect = XbrlConst.standardArcroleCyclesAllowed[arcrole]
@@ -163,7 +165,7 @@ class ValidateXbrl:
                                       or arcrole in self.genericArcArcroles  \
                                       or arcrole.startswith(XbrlConst.formulaStartsWith) \
                                       or (modelXbrl.hasXDT and arcrole.startswith(XbrlConst.dimStartsWith)):
-                relsSet = modelXbrl.relationshipSet(arcrole,ELR,linkqname,arcqname)
+                relsSet = modelXbrl.relationshipSet(arcrole, ELR, linkqname, arcqname)
                 if cyclesAllowed != "any" and \
                     ((XbrlConst.isStandardExtLinkQname(linkqname) and XbrlConst.isStandardArcQname(arcqname)) \
                         or arcrole in self.genericArcArcroles):
@@ -426,7 +428,8 @@ class ValidateXbrl:
 
         if self.validateCalcs:
             modelXbrl.modelManager.showStatus(_("Validating instance calculations"))
-            ValidateXbrlCalcs.validate(modelXbrl, self.validateCalcs)
+            for val in ValidateXbrlCalcs.validate(modelXbrl, self.validateCalcs):
+                modelXbrl.validation(val)
             modelXbrl.profileStat(_("validateCalculations"))
 
         if self.validateUTR: