arelle-release 2.37.44__py3-none-any.whl → 2.37.46__py3-none-any.whl

arelle/plugin/validate/EDINET/{Manifest.py → ManifestInstance.py}

@@ -3,44 +3,59 @@ See COPYRIGHT.md for copyright information.
 """
 from __future__ import annotations
 
+import traceback
 import zipfile
+from collections import defaultdict
 from dataclasses import dataclass
 from functools import lru_cache
 from pathlib import Path
+from typing import cast
 
 from lxml import etree
 from lxml.etree import _Element
 
 from arelle import XbrlConst
+from arelle.Cntlr import Cntlr
 from arelle.FileSource import FileSource
 from arelle.ModelValue import QName, qname
+from arelle.typing import TypeGetText
 from . import Constants
 
+_: TypeGetText
+
 
 @dataclass(frozen=True)
-class Manifest:
-    instances: list[ManifestInstance]
+class ManifestInstance:
+    id: str
+    ixbrlFiles: list[Path]
     path: Path
+    preferredFilename: str
     titlesByLang: dict[str, str]
     tocItems: list[ManifestTocItem]
+    type: str
 
 
 @dataclass(frozen=True)
 class ManifestTocItem:
+    element: _Element
     extrole: str
     childItems: list[ManifestTocItem]
     itemIn: str
     parent: QName | None
     ref: str
     start: QName | None
+    end: QName | None
 
 
-@dataclass(frozen=True)
-class ManifestInstance:
-    id: str
-    ixbrlFiles: list[Path]
-    preferredFilename: str
-    type: str
+def _invalidManifestError(cntlr: Cntlr, file: str, message: str | None = None) -> None:
+    if message is None:
+        message = _("Please correct the content.")
+    cntlr.error(
+        "EDINET.EC5800E.FATAL_ERROR_INVALID_MANIFEST",
+        _("The manifest file definition is incorrect <file=%(file)s>. %(message)s"),
+        file=file,
+        message=message,
+    )
 
 
 def _parseManifestTocItems(parentElt: _Element, parentQName: QName | None) -> list[ManifestTocItem]:
@@ -51,28 +66,33 @@ def _parseManifestTocItems(parentElt: _Element, parentQName: QName | None) -> li
             childParentQName = qname(insertElt.attrib.get("parent"), insertElt.nsmap) if insertElt.attrib.get("parent") else None
             childTocItems.extend(_parseManifestTocItems(insertElt, childParentQName))
         tocItems.append(ManifestTocItem(
+            element=itemElt,
             extrole=itemElt.attrib.get("extrole", ""),
             childItems=childTocItems,
             parent=parentQName,
             itemIn=itemElt.attrib.get("in", ""),
             ref=itemElt.attrib.get("ref", ""),
             start=qname(itemElt.attrib.get("start"), itemElt.nsmap) if itemElt.attrib.get("start") else None,
+            end=qname(itemElt.attrib.get("end"), itemElt.nsmap) if itemElt.attrib.get("end") else None,
         ))
     return tocItems
 
 
-def _parseManifestDoc(xmlRootElement: _Element, path: Path) -> Manifest:
+def _parseManifestDoc(xmlRootElement: _Element, path: Path) -> list[ManifestInstance]:
     instances = []
     titlesByLang = {}
     base = path.parent
     tocElts = list(xmlRootElement.iterchildren(tag=Constants.qnEdinetManifestTocComposition.clarkNotation))
-    assert len(tocElts) == 1, 'There should be exactly one tocComposition element in the manifest.'
+    assert len(tocElts) == 1, _('There should be exactly one tocComposition element in the manifest.')
     for titleElt in tocElts[0].iterchildren(tag=Constants.qnEdinetManifestTitle.clarkNotation):
         lang = titleElt.attrib.get(XbrlConst.qnXmlLang.clarkNotation, "")
         titlesByLang[lang] = titleElt.text.strip() if titleElt.text else ""
     tocItems = _parseManifestTocItems(tocElts[0], None)
+    tocItemsByRef = defaultdict(list)
+    for tocItem in tocItems:
+        tocItemsByRef[tocItem.ref].append(tocItem)
     listElts = list(xmlRootElement.iterchildren(tag=Constants.qnEdinetManifestList.clarkNotation))
-    assert len(listElts) == 1, 'There should be exactly one list element in the manifest.'
+    assert len(listElts) == 1, _('There should be exactly one list element in the manifest.')
     for instanceElt in listElts[0].iterchildren(tag=Constants.qnEdinetManifestInstance.clarkNotation):
         instanceId = str(instanceElt.attrib.get("id", ""))
         instanceType = str(instanceElt.attrib.get("type", ""))
@@ -85,40 +105,65 @@ def _parseManifestDoc(xmlRootElement: _Element, path: Path) -> Manifest:
         instances.append(ManifestInstance(
             id=instanceId,
             ixbrlFiles=ixbrlFiles,
+            path=path,
             preferredFilename=preferredFilename,
+            titlesByLang=titlesByLang,
+            tocItems=tocItemsByRef.get(instanceId, []),
             type=instanceType,
         ))
-    return Manifest(
-        instances=instances,
-        path=path,
-        titlesByLang=titlesByLang,
-        tocItems=tocItems,
-    )
+    return instances
 
 
 @lru_cache(1)
-def parseManifests(filesource: FileSource) -> list[Manifest]:
-    manifests: list[Manifest] = []
+def parseManifests(filesource: FileSource) -> list[ManifestInstance]:
+    assert filesource.cntlr is not None, "FileSource controller must be set before parsing manifests."
+    cntlr = filesource.cntlr
+    instances: list[ManifestInstance] = []
     if filesource.isArchive:
         if filesource.isTaxonomyPackage:
-            return manifests
+            return instances
         if filesource.reportPackage is not None:
-            return manifests
-        for _archiveFile in (filesource.dir or ()):
-            if not Path(_archiveFile).stem.startswith('manifest'):
-                continue
-            assert isinstance(filesource.fs, zipfile.ZipFile), \
-                "The EDINET plugin only supports archives in .zip format."
-            with filesource.fs.open(_archiveFile) as manifestDoc:
-                xmlRootElement = etree.fromstring(manifestDoc.read())
-                manifests.append(_parseManifestDoc(xmlRootElement, Path(_archiveFile)))
+            return instances
+        if not isinstance(filesource.fs, zipfile.ZipFile):
+            _invalidManifestError(
+                cntlr,
+                cast(str, filesource.url),
+                _("The EDINET plugin only supports archives in .zip format.")
+            )
+        else:
+            for _archiveFile in (filesource.dir or ()):
+                if not Path(_archiveFile).stem.startswith('manifest'):
+                    continue
+                try:
+                    with filesource.fs.open(_archiveFile) as manifestDoc:
+                        xmlRootElement = etree.fromstring(manifestDoc.read())
+                        instances.extend(_parseManifestDoc(xmlRootElement, Path(_archiveFile)))
+                except AssertionError as err:
+                    _invalidManifestError(cntlr, str(_archiveFile), str(err))
+                except Exception as err:
+                    _invalidManifestError(cntlr, str(_archiveFile))
+                    cntlr.addToLog(_("[Exception] Failed to parse manifest \"{0}\": \n{1} \n{2}").format(
+                        str(_archiveFile),
+                        err,
+                        traceback.format_exc()
+                    ))
     elif (dirpath := Path(str(filesource.url))).is_dir():
         for file in dirpath.rglob("*"):
             if not file.is_file():
                 continue
             if not file.stem.startswith('manifest'):
                 continue
-            with open(file, 'rb') as manifestDoc:
-                xmlRootElement = etree.fromstring(manifestDoc.read())
-                manifests.append(_parseManifestDoc(xmlRootElement, file))
-    return manifests
+            try:
+                with open(file, 'rb') as manifestDoc:
+                    xmlRootElement = etree.fromstring(manifestDoc.read())
+                    instances.extend(_parseManifestDoc(xmlRootElement, file))
+            except AssertionError as err:
+                _invalidManifestError(cntlr, str(file), str(err))
+            except Exception as err:
+                _invalidManifestError(cntlr, str(file))
+                cntlr.addToLog(_("[Exception] Failed to parse manifest \"{0}\": \n{1} \n{2}").format(
+                    str(file),
+                    err,
+                    traceback.format_exc()
+                ))
+    return instances

arelle/plugin/validate/EDINET/PluginValidationDataExtension.py

@@ -22,17 +22,19 @@ from arelle.ValidateXbrl import ValidateXbrl
 from arelle.XmlValidate import VALID
 from arelle.typing import TypeGetText
 from arelle.utils.PluginData import PluginData
-from .FormType import FormType
 from .Constants import CORPORATE_FORMS
+from .ControllerPluginData import ControllerPluginData
+from .InstanceType import InstanceType
+from .ManifestInstance import ManifestInstance
 
 _: TypeGetText
 
 
 @dataclass(frozen=True)
 class UploadContents:
-    amendmentPaths: dict[FormType, frozenset[Path]]
+    amendmentPaths: dict[InstanceType, frozenset[Path]]
     directories: frozenset[Path]
-    forms: dict[FormType, frozenset[Path]]
+    instances: dict[InstanceType, frozenset[Path]]
     unknownPaths: frozenset[Path]
 
 
@@ -142,6 +144,15 @@ class PluginValidationDataExtension(PluginData):
             if isinstance(elt, (ModelObject, LinkPrototype))
         ]
 
+    @lru_cache(1)
+    def getManifestInstance(self, modelXbrl: ModelXbrl) -> ManifestInstance | None:
+        controllerPluginData = ControllerPluginData.get(modelXbrl.modelManager.cntlr, self.name)
+        return controllerPluginData.matchManifestInstance(modelXbrl.ixdsDocUrls)
+
+    @lru_cache(1)
+    def getManifestInstances(self, modelXbrl: ModelXbrl) -> list[ManifestInstance]:
+        controllerPluginData = ControllerPluginData.get(modelXbrl.modelManager.cntlr, self.name)
+        return controllerPluginData.getManifestInstances()
 
     def getUploadFileSizes(self, modelXbrl: ModelXbrl) -> dict[Path, int]:
         """
@@ -172,14 +183,14 @@ class PluginValidationDataExtension(PluginData):
             if parents[0] == 'XBRL':
                 if len(parents) > 1:
                     formName = parents[1]
-                    formType = FormType.parse(formName)
-                    if formType is not None:
-                        forms[formType].append(path)
+                    instanceType = InstanceType.parse(formName)
+                    if instanceType is not None:
+                        forms[instanceType].append(path)
                         continue
             formName = parents[0]
-            formType = FormType.parse(formName)
-            if formType is not None:
-                amendmentPaths[formType].append(path)
+            instanceType = InstanceType.parse(formName)
+            if instanceType is not None:
+                amendmentPaths[instanceType].append(path)
                 continue
             if len(path.suffix) == 0:
                 directories.append(path)
@@ -188,7 +199,7 @@ class PluginValidationDataExtension(PluginData):
         return UploadContents(
             amendmentPaths={k: frozenset(v) for k, v in amendmentPaths.items() if len(v) > 0},
             directories=frozenset(directories),
-            forms={k: frozenset(v) for k, v in forms.items() if len(v) > 0},
+            instances={k: frozenset(v) for k, v in forms.items() if len(v) > 0},
             unknownPaths=frozenset(unknownPaths)
         )
 

arelle/plugin/validate/EDINET/ValidationPluginExtension.py

@@ -5,16 +5,36 @@ from __future__ import annotations
 
 from typing import Any
 
+from arelle.FileSource import FileSource
 from arelle.ValidateXbrl import ValidateXbrl
 from arelle.typing import TypeGetText
 from arelle.utils.validate.ValidationPlugin import ValidationPlugin
+from .ControllerPluginData import ControllerPluginData
 from .DisclosureSystems import DISCLOSURE_SYSTEM_EDINET
+from .ManifestInstance import parseManifests
 from .PluginValidationDataExtension import PluginValidationDataExtension
 
 _: TypeGetText
 
 
 class ValidationPluginExtension(ValidationPlugin):
+
+    def fileSourceEntrypointFiles(self, filesource: FileSource, *args: Any, **kwargs: Any) -> list[dict[str, Any]] | None:
+        instances = parseManifests(filesource)
+        if len(instances) == 0:
+            return None
+        assert filesource.cntlr is not None
+        pluginData = ControllerPluginData.get(filesource.cntlr, self.name)
+        entrypointFiles = []
+        for instance in instances:
+            pluginData.addManifestInstance(instance)
+            entrypoints = []
+            for ixbrlFile in instance.ixbrlFiles:
+                filesource.select(str(ixbrlFile))
+                entrypoints.append({"file": filesource.url})
+            entrypointFiles.append({'ixds': entrypoints, 'id': instance.id})
+        return entrypointFiles
+
     def newPluginData(self, validateXbrl: ValidateXbrl) -> PluginValidationDataExtension:
         disclosureSystem = validateXbrl.disclosureSystem.name
         if disclosureSystem == DISCLOSURE_SYSTEM_EDINET:
@@ -24,6 +44,3 @@ class ValidationPluginExtension(ValidationPlugin):
         return PluginValidationDataExtension(
             self.name,
         )
-
-    def modelXbrlLoadComplete(self, *args: Any, **kwargs: Any) -> None:
-        return None

arelle/plugin/validate/EDINET/__init__.py

@@ -5,17 +5,14 @@ See COPYRIGHT.md for copyright information.
 """
 from __future__ import annotations
 
-from collections import defaultdict
 from pathlib import Path
 from typing import Any
 
-from arelle.FileSource import FileSource
 from arelle.ModelXbrl import ModelXbrl
 from arelle.Version import authorLabel, copyrightLabel
 from . import Constants
-from .Manifest import Manifest, ManifestInstance, parseManifests
 from .ValidationPluginExtension import ValidationPluginExtension
-from .rules import contexts, edinet, frta, gfm, upload
+from .rules import contexts, edinet, frta, gfm, manifests, upload
 
 PLUGIN_NAME = "Validate EDINET"
 DISCLOSURE_SYSTEM_VALIDATION_TYPE = "EDINET"
@@ -38,6 +35,7 @@ validationPlugin = ValidationPluginExtension(
         edinet,
         frta,
         gfm,
+        manifests,
         upload,
     ],
 )
@@ -51,19 +49,8 @@ def disclosureSystemConfigURL(*args: Any, **kwargs: Any) -> str:
     return validationPlugin.disclosureSystemConfigURL
 
 
-def fileSourceEntrypointFiles(filesource: FileSource, inlineOnly: bool, *args: Any, **kwargs: Any) -> list[dict[str, Any]] | None:
-    manifests = parseManifests(filesource)
-    if len(manifests) == 0:
-        return None
-    entrypointFiles = []
-    for manifest in manifests:
-        for instance in manifest.instances:
-            entrypoints = []
-            for ixbrlFile in instance.ixbrlFiles:
-                filesource.select(str(ixbrlFile))
-                entrypoints.append({"file": filesource.url})
-            entrypointFiles.append({'ixds': entrypoints})
-    return entrypointFiles
+def fileSourceEntrypointFiles(*args: Any, **kwargs: Any) -> list[dict[str, Any]] | None:
+    return validationPlugin.fileSourceEntrypointFiles(*args, **kwargs)
 
 
 def loggingSeverityReleveler(modelXbrl: ModelXbrl, level: str, messageCode: str, args: Any, **kwargs: Any) -> tuple[str | None, str | None]:
@@ -72,10 +59,6 @@ def loggingSeverityReleveler(modelXbrl: ModelXbrl, level: str, messageCode: str,
     return level, messageCode
 
 
-def modelXbrlLoadComplete(*args: Any, **kwargs: Any) -> None:
-    return validationPlugin.modelXbrlLoadComplete(*args, **kwargs)
-
-
 def validateFinally(*args: Any, **kwargs: Any) -> None:
     return validationPlugin.validateFinally(*args, **kwargs)
 
@@ -96,7 +79,6 @@ __pluginInfo__ = {
     "DisclosureSystem.ConfigURL": disclosureSystemConfigURL,
     "FileSource.EntrypointFiles": fileSourceEntrypointFiles,
     "Logging.Severity.Releveler": loggingSeverityReleveler,
-    "ModelXbrl.LoadComplete": modelXbrlLoadComplete,
     "Validate.XBRL.Finally": validateXbrlFinally,
     "ValidateFormula.Finished": validateFinally,
 }

arelle/plugin/validate/EDINET/rules/edinet.py

@@ -154,7 +154,7 @@ def rule_EC8027W(
                 continue
             arcroles = linkbaseType.getArcroles()
             relSet = val.modelXbrl.relationshipSet(tuple(arcroles), roleType.roleURI)
-            relSetFrom = relSet.loadModelRelationshipsFrom()
+            relSetFrom = relSet.fromModelObjects()
             rootConcepts = relSet.rootConcepts
             if len(rootConcepts) < 2:
                 continue

arelle/plugin/validate/EDINET/rules/manifests.py

@@ -0,0 +1,88 @@
+"""
+See COPYRIGHT.md for copyright information.
+"""
+from __future__ import annotations
+
+from typing import Any, Iterable
+
+from arelle.LinkbaseType import LinkbaseType
+from arelle.ModelXbrl import ModelXbrl
+from arelle.ValidateXbrl import ValidateXbrl
+from arelle.typing import TypeGetText
+from arelle.utils.PluginHooks import ValidationHook
+from arelle.utils.validate.Decorator import validation
+from arelle.utils.validate.Validation import Validation
+from ..DisclosureSystems import (DISCLOSURE_SYSTEM_EDINET)
+from ..ManifestInstance import ManifestTocItem
+from ..PluginValidationDataExtension import PluginValidationDataExtension
+
+_: TypeGetText
+
+
+def _validateTocItem(modelXbrl: ModelXbrl, tocItem: ManifestTocItem, instanceId: str) -> Iterable[Validation]:
+    for childTocItem in tocItem.childItems:
+        yield from _validateTocItem(modelXbrl, childTocItem, instanceId)
+    relSet = modelXbrl.relationshipSet(tuple(LinkbaseType.PRESENTATION.getArcroles()), tocItem.extrole)
+    if len(relSet.fromModelObjects()) == 0:
+        yield Validation.error(
+            codes="EDINET.EC5800E.FATAL_ERROR_TOC_TREE_NOT_DEFINED",
+            msg=_("A table of contents item specified an extended link role "
+                  "that does not exist in the presentation linkbase. "),
+            modelObject=tocItem.element,
+        )
+    for conceptQname in {tocItem.parent, tocItem.start, tocItem.end}:
+        if conceptQname is None:
+            continue
+        concept = modelXbrl.qnameConcepts.get(conceptQname)
+        if concept is None or not relSet.contains(concept):
+            yield Validation.error(
+                codes="EDINET.EC5800E.ERROR_ELEMENT_NOT_DEFINED_IN_EXTENDED_LINK_ROLE",
+                msg=_("A table of contents item specified an extended link role "
+                      "that does not contain the element specified by the parent "
+                      "attribute of the insert element or the start or end "
+                      "attribute of the item element. Check the extended link "
+                      "role and correct it."),
+                modelObject=tocItem.element,
+            )
+    if tocItem.end is not None:
+        if tocItem.start is None or \
+                not relSet.isRelated(tocItem.start, "child", tocItem.end):
+            yield Validation.error(
+                codes="EDINET.EC5800E.ERROR_ENDING_ELEMENT_NOT_DEFINED_UNDER_STARTING_ELEMENT",
+                msg=_("A table of contents item specified an end element that "
+                      "is not a descendant of the start element within the "
+                      "specified extended link role. Please check and correct "
+                      "the table of contents items."),
+                modelObject=tocItem.element,
+            )
+
+
+@validation(
+    hook=ValidationHook.XBRL_FINALLY,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_EC5800E(
+        pluginData: PluginValidationDataExtension,
+        val: ValidateXbrl,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC5800E.FATAL_ERROR_TOC_TREE_NOT_DEFINED:
+    A table of contents item specified an extended link role that does not
+    exist in the presentation linkbase.
+    EDINET.EC5800E.ERROR_ELEMENT_NOT_DEFINED_IN_EXTENDED_LINK_ROLE:
+    A table of contents item specified an extended link role that does not
+    contain the element specified by the parent attribute of the insert
+    element or the start or end attribute of the item element. Check the
+    extended link role and correct it.
+    EDINET.EC5800E.ERROR_ENDING_ELEMENT_NOT_DEFINED_UNDER_STARTING_ELEMENT:
+    A table of contents item specified an end element that is not a descendant
+    of the start element within the specified extended link role. Please check
+    and correct the table of contents items.
+    """
+    instance = pluginData.getManifestInstance(val.modelXbrl)
+    if instance is None:
+        return
+    for tocItem in instance.tocItems:
+        yield from _validateTocItem(val.modelXbrl, tocItem, instance.id)

arelle/plugin/validate/EDINET/rules/upload.py

@@ -5,9 +5,8 @@ from __future__ import annotations
 
 import re
 from collections import defaultdict
-from collections.abc import Iterable
 from pathlib import Path
-from typing import Any
+from typing import Any, Iterable
 
 from arelle.ValidateXbrl import ValidateXbrl
 from arelle.typing import TypeGetText
@@ -15,8 +14,7 @@ from arelle.utils.PluginHooks import ValidationHook
 from arelle.utils.validate.Decorator import validation
 from arelle.utils.validate.Validation import Validation
 from ..DisclosureSystems import (DISCLOSURE_SYSTEM_EDINET)
-from ..FormType import FormType, HTML_EXTENSIONS, IMAGE_EXTENSIONS
-from ..Manifest import parseManifests
+from ..InstanceType import InstanceType, HTML_EXTENSIONS, IMAGE_EXTENSIONS
 from ..PluginValidationDataExtension import PluginValidationDataExtension
 
 _: TypeGetText
@@ -162,19 +160,19 @@ def rule_EC0130E(
         return
     uploadContents = pluginData.getUploadContents(val.modelXbrl)
     checks = []
-    for formType, amendmentPaths in uploadContents.amendmentPaths.items():
+    for instanceType, amendmentPaths in uploadContents.amendmentPaths.items():
         for amendmentPath in amendmentPaths:
-            isSubdirectory = amendmentPath.parent.name != formType.value
-            checks.append((amendmentPath, True, formType, isSubdirectory))
-    for formType, formPaths in uploadContents.forms.items():
+            isSubdirectory = amendmentPath.parent.name != instanceType.value
+            checks.append((amendmentPath, True, instanceType, isSubdirectory))
+    for instanceType, formPaths in uploadContents.instances.items():
         for amendmentPath in formPaths:
-            isSubdirectory = amendmentPath.parent.name != formType.value
-            checks.append((amendmentPath, False, formType, isSubdirectory))
-    for path, isAmendment, formType, isSubdirectory in checks:
+            isSubdirectory = amendmentPath.parent.name != instanceType.value
+            checks.append((amendmentPath, False, instanceType, isSubdirectory))
+    for path, isAmendment, instanceType, isSubdirectory in checks:
         ext = path.suffix
         if len(ext) == 0:
             continue
-        validExtensions = formType.getValidExtensions(isAmendment, isSubdirectory)
+        validExtensions = instanceType.getValidExtensions(isAmendment, isSubdirectory)
         if validExtensions is None:
             continue
         if ext not in validExtensions:
@@ -209,17 +207,17 @@ def rule_EC0132E(
     if not pluginData.shouldValidateUpload(val):
         return
     uploadContents = pluginData.getUploadContents(val.modelXbrl)
-    for formType in (FormType.AUDIT_DOC, FormType.PRIVATE_DOC, FormType.PUBLIC_DOC):
-        if formType not in uploadContents.forms:
+    for instanceType in (InstanceType.AUDIT_DOC, InstanceType.PRIVATE_DOC, InstanceType.PUBLIC_DOC):
+        if instanceType not in uploadContents.instances:
             continue
-        if formType.manifestPath in uploadContents.forms.get(formType, []):
+        if instanceType.manifestPath in uploadContents.instances.get(instanceType, []):
             continue
         yield Validation.error(
             codes='EDINET.EC0132E',
             msg=_("'%(expectedManifestName)s' does not exist in '%(expectedManifestDirectory)s'. "
                   "Please store the manifest file (or cover file) directly under the relevant folder and upload it again. "),
-            expectedManifestName=formType.manifestPath.name,
-            expectedManifestDirectory=str(formType.manifestPath.parent),
+            expectedManifestName=instanceType.manifestPath.name,
+            expectedManifestDirectory=str(instanceType.manifestPath.parent),
         )
 
 
@@ -478,40 +476,40 @@ def rule_manifest_preferredFilename(
     """
     if not pluginData.shouldValidateUpload(val):
         return
-    manifests = parseManifests(val.modelXbrl.fileSource)
-    for manifest in manifests:
-        preferredFilenames = set()
-        duplicateFilenames = set()
-        for instance in manifest.instances:
-            if len(instance.preferredFilename) == 0:
-                yield Validation.error(
-                    codes='EDINET.EC5804E',
-                    msg=_("The instance file name is not set. "
-                          "Set the instance name as the preferredFilename attribute value "
-                          "of the instance element in the manifest file. (manifest: '%(manifest)s', id: %(id)s)"),
-                    manifest=str(manifest.path),
-                    id=instance.id,
-                )
-                continue
-            preferredFilename = Path(instance.preferredFilename)
-            if preferredFilename.suffix != '.xbrl':
-                yield Validation.error(
-                    codes='EDINET.EC5805E',
-                    msg=_("The instance file extension is not '.xbrl'. "
-                          "File name: '%(preferredFilename)s'. "
-                          "Please change the extension of the instance name set in the "
-                          "preferredFilename attribute value of the instance element in "
-                          "the manifest file to '.xbrl'. (manifest: '%(manifest)s', id: %(id)s)"),
-                    preferredFilename=instance.preferredFilename,
-                    manifest=str(manifest.path),
-                    id=instance.id,
-                )
-                continue
-            if instance.preferredFilename in preferredFilenames:
-                duplicateFilenames.add(instance.preferredFilename)
-                continue
-            preferredFilenames.add(instance.preferredFilename)
-        for duplicateFilename in duplicateFilenames:
+    instances = pluginData.getManifestInstances(val.modelXbrl)
+    preferredFilenames: dict[Path, set[str]] = defaultdict(set)
+    duplicateFilenames = defaultdict(set)
+    for instance in instances:
+        if len(instance.preferredFilename) == 0:
+            yield Validation.error(
+                codes='EDINET.EC5804E',
+                msg=_("The instance file name is not set. "
+                      "Set the instance name as the preferredFilename attribute value "
+                      "of the instance element in the manifest file. (manifest: '%(manifest)s', id: %(id)s)"),
+                manifest=str(instance.path),
+                id=instance.id,
+            )
+            continue
+        preferredFilename = Path(instance.preferredFilename)
+        if preferredFilename.suffix != '.xbrl':
+            yield Validation.error(
+                codes='EDINET.EC5805E',
+                msg=_("The instance file extension is not '.xbrl'. "
+                      "File name: '%(preferredFilename)s'. "
+                      "Please change the extension of the instance name set in the "
+                      "preferredFilename attribute value of the instance element in "
+                      "the manifest file to '.xbrl'. (manifest: '%(manifest)s', id: %(id)s)"),
+                preferredFilename=instance.preferredFilename,
+                manifest=str(instance.path),
+                id=instance.id,
+            )
+            continue
+        if instance.preferredFilename in preferredFilenames[instance.path]:
+            duplicateFilenames[instance.path].add(instance.preferredFilename)
+            continue
+        preferredFilenames[instance.path].add(instance.preferredFilename)
+    for path, filenames in duplicateFilenames.items():
+        for filename in filenames:
             yield Validation.error(
                 codes='EDINET.EC5806E',
                 msg=_("The same instance file name is set multiple times. "
@@ -519,6 +517,6 @@ def rule_manifest_preferredFilename(
                       "The preferredFilename attribute value of the instance "
                       "element in the manifest file must be unique within the "
                       "same file. (manifest: '%(manifest)s')"),
-                manifest=str(manifest.path),
-                preferredFilename=duplicateFilename,
+                manifest=str(path),
+                preferredFilename=filename,
             )

arelle/utils/validate/ESEFImage.py

@@ -257,22 +257,22 @@ def checkSVGContentElt(
 ) -> Iterable[Validation]:
     guidance = params.contentOtherThanXHTMLGuidance
     rootElement = True
-    for elt in elt.iter():
+    for childElt in elt.iter():
         if rootElement:
-            if elt.tag != "{http://www.w3.org/2000/svg}svg":
+            if childElt.tag != "{http://www.w3.org/2000/svg}svg":
                 yield Validation.error((f"{guidance}.imageFileCannotBeLoaded", "NL.NL-KVK.3.5.1.imageFileCannotBeLoaded"),
                                        _("Image SVG has root element which is not svg"),
                                        modelObject=imgElts)
             rootElement = False
         # Comments, processing instructions, and maybe other special constructs don't have string tags.
-        if not isinstance(elt.tag, str):
+        if not isinstance(childElt.tag, str):
             continue
-        eltTag = elt.tag.rpartition("}")[2] # strip namespace
+        eltTag = childElt.tag.rpartition("}")[2] # strip namespace
         if eltTag == "image":
-            imgElts = [*imgElts, elt]
-            yield from validateImage(baseUrl, getHref(elt), modelXbrl, val, imgElts, "", params)
+            imgElts = [*imgElts, childElt]
+            yield from validateImage(baseUrl, getHref(childElt), modelXbrl, val, imgElts, "", params)
         if eltTag in ("object", "script", "audio", "foreignObject", "iframe", "image", "use", "video"):
-            href = elt.get("href","")
+            href = childElt.get("href","")
             if eltTag in ("object", "script") or "javascript:" in href:
                 yield Validation.error((f"{guidance}.executableCodePresent", "NL.NL-KVK.3.5.1.1.executableCodePresent"),
                                        _("Inline XBRL images MUST NOT contain executable code: %(element)s"),