ardupilot-methodic-configurator 2.0.3__py3-none-any.whl → 2.0.5__py3-none-any.whl

ardupilot_methodic_configurator/frontend_tkinter_parameter_editor_table.py

@@ -24,10 +24,10 @@ from ardupilot_methodic_configurator.backend_filesystem import LocalFilesystem
 from ardupilot_methodic_configurator.data_model_ardupilot_parameter import (
     ArduPilotParameter,
     BitmaskHelper,
-    ConnectionRenamer,
     ParameterOutOfRangeError,
     ParameterUnchangedError,
 )
+from ardupilot_methodic_configurator.data_model_configuration_step import ConfigurationStepProcessor
 from ardupilot_methodic_configurator.frontend_tkinter_base_window import BaseWindow
 from ardupilot_methodic_configurator.frontend_tkinter_entry_dynamic import EntryWithDynamicalyFilteredListbox
 from ardupilot_methodic_configurator.frontend_tkinter_pair_tuple_combobox import PairTupleCombobox
@@ -36,6 +36,7 @@ from ardupilot_methodic_configurator.frontend_tkinter_scroll_frame import Scroll
 from ardupilot_methodic_configurator.frontend_tkinter_show import show_tooltip
 
 NEW_VALUE_WIDGET_WIDTH = 9
+NEW_VALUE_DIFFERENT_STR = "\u2260" if platform_system() == "Windows" else "!="
 
 
 class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors, too-many-instance-attributes
@@ -56,6 +57,9 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         self.upload_checkbutton_var: dict[str, tk.BooleanVar] = {}
         self.at_least_one_param_edited = False
         self.parameters: dict[str, ArduPilotParameter] = {}
+        self.config_step_processor = ConfigurationStepProcessor(local_filesystem)
+        # Track last return values to prevent duplicate event processing
+        self._last_return_values: dict[tk.Misc, str] = {}
 
         style = ttk.Style()
         style.configure("narrow.TButton", padding=0, width=4, border=(0, 0, 0, 0))  # type: ignore[no-untyped-call]
@@ -85,6 +89,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             _("-/+"),
             _("Parameter"),
             _("Current Value"),
+            " ",  # intentionally left blank
             _("New Value"),
             _("Unit"),
         ]
@@ -92,7 +97,8 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         base_tooltips = [
             _("Delete or add a parameter"),
             _("Parameter name must be ^[A-Z][A-Z_0-9]* and most 16 characters long"),
-            _("Current value on the flight controller "),
+            _("Current value on the flight controller"),
+            _("Is the new value different from the current FC value?"),
             _("New value from the above selected intermediate parameter file"),
             _("Parameter Unit"),
         ]
@@ -115,18 +121,19 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             base_headers.append(_("Upload"))
             base_tooltips.append(_("When selected, upload the new value to the flight controller"))
 
-        base_headers.append(_("Change Reason"))
+        base_headers.append(_("Why are you changing this parameter?"))
         base_tooltips.append(change_reason_tooltip)
 
         return tuple(base_headers), tuple(base_tooltips)
 
-    def repopulate(
+    def repopulate(  # pylint: disable=too-many-locals
         self, selected_file: str, fc_parameters: dict[str, float], show_only_differences: bool, gui_complexity: str
     ) -> None:
         for widget in self.view_port.winfo_children():
             widget.destroy()
         self.current_file = selected_file
-        self.parameters = {}
+        # Clear the last return values tracking dictionary when repopulating
+        self._last_return_values.clear()
 
         # Check if upload column should be shown based on UI complexity
         show_upload_column = self._should_show_upload_column(gui_complexity)
@@ -141,30 +148,21 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
 
         self.upload_checkbutton_var = {}
 
-        # re-compute derived parameters because the fc_parameters values might have changed
-        if self.local_filesystem.configuration_steps and selected_file in self.local_filesystem.configuration_steps:
-            self.variables["fc_parameters"] = fc_parameters
-            error_msg = self.local_filesystem.compute_parameters(
-                selected_file, self.local_filesystem.configuration_steps[selected_file], "derived", self.variables
-            )
-            if error_msg:
-                messagebox.showerror(_("Error in derived parameters"), error_msg)
-            # merge derived parameter values
-            elif self.local_filesystem.merge_forced_or_derived_parameters(
-                selected_file, self.local_filesystem.derived_parameters, list(fc_parameters.keys())
-            ):
-                self.at_least_one_param_edited = True
-
-            self._rename_fc_connection(selected_file)
+        # Process configuration step and create domain model parameters
+        self.parameters, config_step_edited, ui_errors, ui_infos = self.config_step_processor.process_configuration_step(
+            selected_file, fc_parameters, self.variables
+        )
+        if config_step_edited:
+            self.at_least_one_param_edited = True
 
-        # Convert file parameters to domain model parameters
-        self._create_domain_model_parameters(selected_file, fc_parameters)
+        for title, msg in ui_errors:
+            messagebox.showerror(title, msg)
+        for title, msg in ui_infos:
+            messagebox.showinfo(title, msg)
 
         if show_only_differences:
-            # recompute different_params because of renames and derived values changes
-            different_params = {
-                name: param for name, param in self.parameters.items() if param.is_different_from_fc or not param.has_fc_value
-            }
+            # Filter to show only different parameters
+            different_params = self.config_step_processor.filter_different_parameters(self.parameters)
             self._update_table(different_params, fc_parameters, self.parameter_editor.gui_complexity)
             if not different_params:
                 info_msg = _("No different parameters found in {selected_file}. Skipping...").format(**locals())
@@ -177,54 +175,6 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         # Scroll to the top of the parameter table
         self.canvas.yview("moveto", 0)
 
-    def _create_domain_model_parameters(self, selected_file: str, fc_parameters: dict[str, float]) -> None:
-        """Create ArduPilotParameter objects for each parameter in the file."""
-        self.parameters = {}
-
-        for param_name, param in self.local_filesystem.file_parameters[selected_file].items():
-            # Get parameter metadata and default values
-            metadata = self.local_filesystem.doc_dict.get(param_name, {})
-            default_par = self.local_filesystem.param_default_dict.get(param_name, None)
-
-            # Check if parameter is forced or derived
-            forced_par = self.local_filesystem.forced_parameters.get(selected_file, {}).get(param_name, None)
-            derived_par = self.local_filesystem.derived_parameters.get(selected_file, {}).get(param_name, None)
-
-            # Get FC value if available
-            fc_value = fc_parameters.get(param_name)
-
-            # Create domain model parameter
-            self.parameters[param_name] = ArduPilotParameter(
-                param_name, param, metadata, default_par, fc_value, forced_par, derived_par
-            )
-
-    def _rename_fc_connection(self, selected_file: str) -> None:
-        """Rename parameters based on connection prefixes using the ConnectionRenamer."""
-        if "rename_connection" in self.local_filesystem.configuration_steps[selected_file]:
-            new_connection_prefix = self.local_filesystem.configuration_steps[selected_file]["rename_connection"]
-
-            # Apply renames to the parameters dictionary
-            duplicated_parameters, renamed_pairs = ConnectionRenamer.apply_renames(
-                self.local_filesystem.file_parameters[selected_file], new_connection_prefix, self.variables
-            )
-
-            for old_name in duplicated_parameters:
-                logging_info(_("Removing duplicate parameter %s"), old_name)
-                info_msg = _("The parameter '{old_name}' was removed due to duplication.")
-                messagebox.showinfo(_("Parameter Removed"), info_msg.format(**locals()))
-                # will ask the user to save changes before switching to another file
-                self.at_least_one_param_edited = True
-
-            for old_name, new_name in renamed_pairs:
-                logging_info(_("Renaming parameter %s to %s"), old_name, new_name)
-                info_msg = _(
-                    "The parameter '{old_name}' was renamed to '{new_name}'.\n"
-                    "to obey the flight controller connection defined in the component editor window."
-                )
-                messagebox.showinfo(_("Parameter Renamed"), info_msg.format(**locals()))
-                # will ask the user to save changes before switching to another file
-                self.at_least_one_param_edited = True
-
     def _update_table(
         self, params: dict[str, ArduPilotParameter], fc_parameters: dict[str, float], gui_complexity: str
     ) -> None:
@@ -259,11 +209,13 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         """Create all column widgets for a parameter row."""
         column: list[tk.Widget] = []
         change_reason_widget = self._create_change_reason_entry(param)
+        value_is_different_widget = self._create_value_different_label(param)
         column.append(self._create_delete_button(param_name))
         column.append(self._create_parameter_name(param))
         column.append(self._create_flightcontroller_value(param))
+        column.append(value_is_different_widget)
         # update the change reason tooltip when the new value changes
-        column.append(self._create_new_value_entry(param, change_reason_widget))
+        column.append(self._create_new_value_entry(param, change_reason_widget, value_is_different_widget))
         column.append(self._create_unit_label(param))
 
         if show_upload_column:
@@ -280,9 +232,10 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         column[2].grid(row=row, column=2, sticky="e", padx=0)
         column[3].grid(row=row, column=3, sticky="e", padx=0)
         column[4].grid(row=row, column=4, sticky="e", padx=0)
+        column[5].grid(row=row, column=5, sticky="e", padx=0)
 
         if show_upload_column:
-            column[5].grid(row=row, column=5, sticky="e", padx=0)
+            column[6].grid(row=row, column=6, sticky="e", padx=0)
 
         change_reason_column = self._get_change_reason_column_index(show_upload_column)
         column[change_reason_column].grid(row=row, column=change_reason_column, sticky="ew", padx=(0, 5))
@@ -299,7 +252,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
 
         """
         # Base columns: Delete, Parameter, Current Value, New Value, Unit
-        base_column_count = 5
+        base_column_count = 6
         if show_upload_column:
             return base_column_count + 1  # Upload column + Change Reason
         return base_column_count  # Change Reason directly after Unit
@@ -309,11 +262,12 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         self.view_port.columnconfigure(0, weight=0)  # Delete and Add buttons
         self.view_port.columnconfigure(1, weight=0, minsize=120)  # Parameter name
         self.view_port.columnconfigure(2, weight=0)  # Current Value
-        self.view_port.columnconfigure(3, weight=0)  # New Value
-        self.view_port.columnconfigure(4, weight=0)  # Units
+        self.view_port.columnconfigure(3, weight=0)  # Different
+        self.view_port.columnconfigure(4, weight=0)  # New Value
+        self.view_port.columnconfigure(5, weight=0)  # Units
 
         if show_upload_column:
-            self.view_port.columnconfigure(5, weight=0)  # Upload to FC
+            self.view_port.columnconfigure(6, weight=0)  # Upload to FC
 
         self.view_port.columnconfigure(self._get_change_reason_column_index(show_upload_column), weight=1)  # Change Reason
 
@@ -351,7 +305,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
                 flightcontroller_value = ttk.Label(self.view_port, text=param.fc_value_as_string, background="light blue")
             elif param.fc_value_is_below_limit():
                 flightcontroller_value = ttk.Label(self.view_port, text=param.fc_value_as_string, background="orangered")
-            elif param.fc_value_is_above_limit():
+            elif param.fc_value_is_above_limit() or param.fc_value_has_unknown_bits_set():
                 flightcontroller_value = ttk.Label(self.view_port, text=param.fc_value_as_string, background="red3")
             else:
                 # Otherwise, set the background color to the default color
@@ -364,8 +318,17 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             show_tooltip(flightcontroller_value, tooltip_fc_value)
         return flightcontroller_value
 
-    def _update_combobox_style_on_selection(
-        self, combobox_widget: PairTupleCombobox, param: ArduPilotParameter, event: tk.Event, change_reason_widget: ttk.Entry
+    def _create_value_different_label(self, param: ArduPilotParameter) -> ttk.Label:
+        """Create a label indicating if the new value is different from current FC value."""
+        return ttk.Label(self.view_port, text=NEW_VALUE_DIFFERENT_STR if param.is_different_from_fc else " ")
+
+    def _update_combobox_style_on_selection(  # pylint: disable=too-many-arguments, too-many-positional-arguments
+        self,
+        combobox_widget: PairTupleCombobox,
+        param: ArduPilotParameter,
+        event: tk.Event,
+        change_reason_widget: ttk.Entry,
+        value_is_different: ttk.Label,
     ) -> None:
         """Update the combobox style based on selection."""
         new_value_str = combobox_widget.get_selected_key() or ""
@@ -384,6 +347,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             show_tooltip(change_reason_widget, param.tooltip_change_reason)
             self.at_least_one_param_edited = True
             self.local_filesystem.file_parameters[self.current_file][param.name].value = new_value
+            value_is_different.config(text=NEW_VALUE_DIFFERENT_STR if param.is_different_from_fc else " ")
 
         combobox_widget.configure(
             style="default_v.TCombobox" if param.new_value_equals_default_value else "readonly.TCombobox"
@@ -403,14 +367,14 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             style = "default_v.TEntry"
         elif param.is_below_limit():
             style = "below_limit.TEntry"
-        elif param.is_above_limit():
+        elif param.is_above_limit() or param.has_unknown_bits_set():
             style = "above_limit.TEntry"
         else:
             style = "TEntry"
         new_value_entry.configure(style=style)
 
     def _create_new_value_entry(  # pylint: disable=too-many-statements # noqa: PLR0915
-        self, param: ArduPilotParameter, change_reason_widget: ttk.Entry
+        self, param: ArduPilotParameter, change_reason_widget: ttk.Entry, value_is_different: ttk.Label
     ) -> Union[PairTupleCombobox, ttk.Entry]:
         """Create an entry widget for editing the parameter value."""
         # if param.is_dirty:
@@ -433,11 +397,13 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             )
             new_value_entry.set(selected_value)
             font_family, font_size = get_widget_font_family_and_size(new_value_entry)
-            font_size -= 2 if platform_system() == "Windows" else 1
+            font_size -= 2 if platform_system() == "Windows" else -1
             new_value_entry.config(state="readonly", width=NEW_VALUE_WIDGET_WIDTH, font=(font_family, font_size))
             new_value_entry.bind(  # type: ignore[call-overload] # workaround a mypy issue
                 "<<ComboboxSelected>>",
-                lambda event: self._update_combobox_style_on_selection(new_value_entry, param, event, change_reason_widget),
+                lambda event: self._update_combobox_style_on_selection(
+                    new_value_entry, param, event, change_reason_widget, value_is_different
+                ),
                 "+",
             )
         else:
@@ -477,6 +443,24 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             if new_value is None:
                 return
 
+            # Prevent duplicate execution when both Return and FocusOut events are triggered
+            # EventType.KeyPress for Return/Enter, EventType.FocusOut for focus loss
+            if (
+                hasattr(event, "type")
+                and event.type == tk.EventType.FocusOut
+                and event.widget in self._last_return_values
+                # Check if the widget still has the same value as when Return was pressed
+                # If Return was just pressed, skip FocusOut to avoid duplicate processing
+                and new_value == self._last_return_values[event.widget]
+            ):
+                # Clear the flag and skip processing
+                del self._last_return_values[event.widget]
+                return
+
+            # Mark that Return was pressed with this value (for FocusOut deduplication)
+            if hasattr(event, "type") and event.type == tk.EventType.KeyPress:  # KeyPress event (Return/Enter)
+                self._last_return_values[event.widget] = new_value
+
             new_value_result = None
             valid = True
 
@@ -486,7 +470,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
                 new_value_result = param.set_new_value(new_value)
             except ParameterOutOfRangeError as oor:  # user-visible warning from model
                 # Ask the user if they want to accept the out-of-range value
-                if messagebox.askyesno(_("Out-of-bounds Value"), str(oor) + _(" Use out-of-bounds value?"), icon="warning"):
+                if messagebox.askyesno(_("Out-of-range value"), str(oor) + _(" Use out-of-range value?"), icon="warning"):
                     # Retry accepting the value while telling the model to ignore range checks
                     new_value_result = param.set_new_value(new_value, ignore_out_of_range=True)
                 else:
@@ -495,7 +479,8 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
                 # Valid but no change — just refresh the UI and do not mark edited
                 valid = False
             except (ValueError, TypeError) as exc:  # invalid input according to model
-                messagebox.showerror(_("Invalid Value"), str(exc))
+                logging_exception(_("Invalid value for %s: %s"), param.name, exc)
+                messagebox.showerror(_("Invalid value"), str(exc))
                 valid = False
 
             if valid and new_value_result is not None:
@@ -505,6 +490,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
                 # Update the corresponding file parameter with the model-returned value
                 # (model returns the canonical numeric/string representation)
                 self.local_filesystem.file_parameters[self.current_file][param.name].value = new_value_result
+                value_is_different.config(text=NEW_VALUE_DIFFERENT_STR if param.is_different_from_fc else " ")
 
             # Update the displayed value in the Entry or Combobox
             if isinstance(
@@ -513,7 +499,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
                 self._update_new_value_entry_text(event.widget, param)  # type: ignore[arg-type] # workaround a mypy bug
             elif isinstance(event.widget, PairTupleCombobox):
                 # For PairTupleCombobox, update the style based on whether it matches default value
-                self._update_combobox_style_on_selection(event.widget, param, event, change_reason_widget)
+                self._update_combobox_style_on_selection(event.widget, param, event, change_reason_widget, value_is_different)
 
         if not param.is_editable:
             new_value_entry.config(state="disabled", background="light grey")
@@ -523,7 +509,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         elif param.is_bitmask:
             new_value_entry.bind(
                 "<Double-Button-1>",
-                lambda event: self._open_bitmask_selection_window(event, param, change_reason_widget),
+                lambda event: self._open_bitmask_selection_window(event, param, change_reason_widget, value_is_different),
             )
             new_value_entry.bind("<FocusOut>", _on_parameter_value_change)
             new_value_entry.bind("<Return>", _on_parameter_value_change)
@@ -539,7 +525,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
         return new_value_entry
 
     def _open_bitmask_selection_window(  # pylint: disable=too-many-locals, too-many-statements # noqa: PLR0915
-        self, event: tk.Event, param: ArduPilotParameter, change_reason_widget: ttk.Entry
+        self, event: tk.Event, param: ArduPilotParameter, change_reason_widget: ttk.Entry, value_is_different: ttk.Label
     ) -> None:
         """Open a window to select bitmask options."""
 
@@ -553,20 +539,34 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
                 )
                 return
 
+            new_value_result = None
+            valid = True
             # Update the parameter value and entry text
             try:
-                new_value = param.set_new_value(BitmaskHelper.get_value_from_keys(checked_keys))
+                new_value_result = param.set_new_value(BitmaskHelper.get_value_from_keys(checked_keys))
+            except ParameterOutOfRangeError as oor:  # user-visible warning from model
+                # Ask the user if they want to accept the out-of-range value
+                if messagebox.askyesno(_("Unknown bit set"), str(oor) + _(" Use out-of-range value?"), icon="warning"):
+                    # Retry accepting the value while telling the model to ignore range checks
+                    new_value_result = param.set_new_value(
+                        BitmaskHelper.get_value_from_keys(checked_keys), ignore_out_of_range=True
+                    )
+                else:
+                    valid = False
             except ParameterUnchangedError:
-                # valid but no change
-                pass
-            except (ValueError, TypeError) as exc:
+                # Valid but no change — just refresh the UI and do not mark edited
+                valid = False
+            except (ValueError, TypeError) as exc:  # invalid input according to model
                 logging_exception(_("Could not set bitmask value for %s: %s"), param.name, exc)
                 messagebox.showerror(_("Error"), str(exc))
-            else:
+                valid = False
+
+            if valid and new_value_result is not None:
                 show_tooltip(change_reason_widget, param.tooltip_change_reason)
                 self.at_least_one_param_edited = True
                 # Update the corresponding file parameter
-                self.local_filesystem.file_parameters[self.current_file][param.name].value = new_value
+                self.local_filesystem.file_parameters[self.current_file][param.name].value = new_value_result
+                value_is_different.config(text=NEW_VALUE_DIFFERENT_STR if param.is_different_from_fc else " ")
 
             # Update new_value_entry with the new decimal value
             # For bitmask windows, event.widget should always be ttk.Entry (not PairTupleCombobox)
@@ -582,8 +582,8 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             self.root.update_idletasks()
             # Re-bind the FocusIn event to new_value_entry
             event.widget.bind(
-                "<Double-Button>",
-                lambda event: self._open_bitmask_selection_window(event, param, change_reason_widget),
+                "<Double-Button-1>",
+                lambda event: self._open_bitmask_selection_window(event, param, change_reason_widget, value_is_different),
             )
 
         def is_widget_visible(widget: Union[tk.Misc, None]) -> bool:
@@ -603,7 +603,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             close_label.config(text=get_param_value_msg(param.name, checked_keys))
 
         # Temporarily unbind the FocusIn event to prevent triggering the window again
-        event.widget.unbind("<Double-Button>")
+        event.widget.unbind("<Double-Button-1>")
         window = tk.Toplevel(self.root)
         title = _("Select {param.name} Bitmask Options")
         window.title(title.format(**locals()))
@@ -678,8 +678,24 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
             change_reason_entry.config(state="disabled", background="light grey")
         else:
 
-            def on_focus_out(event: tk.Event) -> None:  # pylint: disable=unused-argument # noqa: ARG001
+            def _on_change_reason_change(event: tk.Event) -> None:
                 new_comment = change_reason_entry.get()
+
+                # Prevent duplicate execution when both Return and FocusOut events are triggered
+                if (
+                    hasattr(event, "type")
+                    and event.type == tk.EventType.FocusOut
+                    and change_reason_entry in self._last_return_values
+                    and new_comment == self._last_return_values[change_reason_entry]
+                ):
+                    # Clear the flag and skip processing
+                    del self._last_return_values[change_reason_entry]
+                    return
+
+                # Mark that Return was pressed with this value (for FocusOut deduplication)
+                if hasattr(event, "type") and event.type == tk.EventType.KeyPress:  # KeyPress event (Return/Enter)
+                    self._last_return_values[change_reason_entry] = new_comment
+
                 # Only set the flag and update file if the comment actually changes
                 if param.set_change_reason(new_comment):
                     logging_debug(
@@ -692,10 +708,9 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors,
                     # Update the corresponding file parameter comment
                     self.local_filesystem.file_parameters[self.current_file][param.name].comment = new_comment
 
-            change_reason_entry.bind(
-                "<FocusOut>",
-                on_focus_out,
-            )
+            change_reason_entry.bind("<FocusOut>", _on_change_reason_change)
+            change_reason_entry.bind("<Return>", _on_change_reason_change)
+            change_reason_entry.bind("<KP_Enter>", _on_change_reason_change)
 
         show_tooltip(change_reason_entry, param.tooltip_change_reason)
         return change_reason_entry

ardupilot_methodic_configurator/frontend_tkinter_rich_text.py

@@ -11,6 +11,7 @@ SPDX-License-Identifier: GPL-3.0-or-later
 # https://wiki.tcl-lang.org/page/Changing+Widget+Colors
 
 import tkinter as tk
+from platform import system as platform_system
 from tkinter import font as tkFont  # noqa: N812
 from tkinter import ttk
 
@@ -43,7 +44,7 @@ class RichText(tk.Text):  # pylint: disable=too-many-ancestors
     def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
 
-        default_font = tkFont.nametofont(self.cget("font"))
+        default_font = tkFont.nametofont("TkDefaultFont")
         default_size = default_font.cget("size")
 
         bold_font = tkFont.Font(**default_font.configure())  # type: ignore[arg-type]
@@ -60,10 +61,26 @@ class RichText(tk.Text):  # pylint: disable=too-many-ancestors
 
 
 def get_widget_font_family_and_size(widget: tk.Widget) -> tuple[str, int]:
+    """
+    Get the font family and size used by a Tkinter widget.
+
+    Args:
+        widget: The Tkinter widget to inspect.
+
+    Returns:
+        A tuple containing the font family and size.
+        WARNINGS: This function assumes the widget has a style set.
+                  On linux the font size might be negative.
+
+    """
     style = ttk.Style()
     widget_style = widget.cget("style")  # Get the style used by the widget
     font_name = style.lookup(widget_style, "font")  # type: ignore[no-untyped-call]
     font_dict = tkFont.nametofont(font_name).config()
+
+    default_font_family = "Segoe UI" if platform_system() == "Windows" else "Helvetica"
+    default_font_size = 9 if platform_system() == "Windows" else -12
+
     if font_dict is None:
-        return "Segoe UI", 9
-    return font_dict.get("family", "Segoe UI"), font_dict.get("size", 9)
+        return default_font_family, default_font_size
+    return font_dict.get("family", default_font_family), font_dict.get("size", default_font_size)

ardupilot_methodic_configurator/frontend_tkinter_template_overview.py

@@ -25,6 +25,7 @@ from ardupilot_methodic_configurator.backend_filesystem_vehicle_components impor
 from ardupilot_methodic_configurator.common_arguments import add_common_arguments
 from ardupilot_methodic_configurator.data_model_template_overview import TemplateOverview
 from ardupilot_methodic_configurator.frontend_tkinter_base_window import BaseWindow
+from ardupilot_methodic_configurator.frontend_tkinter_rich_text import get_widget_font_family_and_size
 
 
 class VehicleComponentsProviderProtocol(Protocol):
@@ -123,8 +124,9 @@ class TemplateOverviewWindow(BaseWindow):
 
         # Initialize instruction label
         instruction_text = self._get_instruction_text()
-        scaled_font_size = self.calculate_scaled_font_size(12)
-        self.instruction_label = ttk.Label(self.top_frame, text=instruction_text, font=("Arial", scaled_font_size))
+        font_family, font_size = get_widget_font_family_and_size(self.main_frame)
+        scaled_font_size = self.calculate_scaled_font_size(font_size)
+        self.instruction_label = ttk.Label(self.top_frame, text=instruction_text, font=(font_family, scaled_font_size))
 
         # Initialize image label
         self.image_label = ttk.Label(self.top_frame)

ardupilot_methodic_configurator/vehicle_templates/ArduPlane/normal_plane/configuration_steps_ArduPlane.json

@@ -662,7 +662,7 @@
             "blog_text": "Configure parameters for the roll axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_ArduPlane#11-system-identification-for-analytical-pid-optimization-optional",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",
@@ -680,7 +680,7 @@
             "blog_text": "Configure parameters for the pitch axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_ArduPlane#1112-pitch-rate-mathematical-model",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",
@@ -696,7 +696,7 @@
             "blog_text": "Configure parameters for the yaw axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_ArduPlane#1113-yaw-rate-mathematical-model",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",
@@ -712,7 +712,7 @@
             "blog_text": "Configure parameters for the thrust axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_ArduPlane#1114-thrust-mathematical-model",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",

ardupilot_methodic_configurator/vehicle_templates/Heli/OMP_M4/configuration_steps_Heli.json

@@ -661,7 +661,7 @@
             "blog_text": "Configure parameters for the roll axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_Heli#11-system-identification-for-analytical-pid-optimization-optional",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",
@@ -679,7 +679,7 @@
             "blog_text": "Configure parameters for the pitch axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_Heli#1112-pitch-rate-mathematical-model",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",
@@ -695,7 +695,7 @@
             "blog_text": "Configure parameters for the yaw axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_Heli#1113-yaw-rate-mathematical-model",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",
@@ -711,7 +711,7 @@
             "blog_text": "Configure parameters for the thrust axis system identification to create a mathematical model of the vehicle",
             "blog_url": "https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_Heli#1114-thrust-mathematical-model",
             "wiki_text": "Matlab and Simulink IAV scripts for system identification",
-            "wiki_url": "https://ardupilot.org/copter/docs/systemid-mode-operation.html#identification-of-a-multicopter",
+            "wiki_url": "https://ardupilot.org/copter/docs/systemid-model-development.html#identification-of-a-multicopter",
             "external_tool_text": "ArduCopter Simulink Model",
             "external_tool_url": "https://github.com/ArduPilot/ardupilot/blob/master/Tools/simulink/arducopter/README.md",
             "mandatory_text": "20% mandatory (80% optional)",