ara-cli 0.1.9.73__py3-none-any.whl → 0.1.9.75__py3-none-any.whl

tests/test_artefact_autofix.py

@@ -10,8 +10,13 @@ from ara_cli.artefact_autofix import (
     write_corrected_artefact,
     construct_prompt,
     fix_title_mismatch,
+    ask_for_correct_contribution,
+    ask_for_contribution_choice,
+    _has_valid_contribution,
+    set_closest_contribution,
+    fix_contribution,
 )
-from ara_cli.artefact_models.artefact_model import ArtefactType
+from ara_cli.artefact_models.artefact_model import Artefact, ArtefactType, Contribution
 
 
 @pytest.fixture
@@ -38,6 +43,23 @@ def mock_classified_artefact_info():
     return MagicMock()
 
 
+@pytest.fixture
+def mock_artefact_with_contribution():
+    """Provides a mock Artefact with a mock Contribution."""
+    mock_contribution = MagicMock(spec=Contribution)
+    mock_contribution.artefact_name = "some_artefact"
+    mock_contribution.classifier = "feature"
+    mock_contribution.rule = "some rule"
+
+    mock_artefact = MagicMock(spec=Artefact)
+    mock_artefact.contribution = mock_contribution
+    mock_artefact.title = "my_test_artefact"
+    mock_artefact._artefact_type.return_value.value = "requirement"
+    mock_artefact.serialize.return_value = "serialized artefact text"
+
+    return mock_artefact
+
+
 def test_read_report_file_success():
     """Tests successful reading of the report file."""
     mock_content = "# Artefact Check Report\n- `file.feature`: reason"
@@ -96,11 +118,9 @@ def test_read_artefact_file_not_found(capsys):
 @patch("ara_cli.artefact_models.artefact_mapping.artefact_type_mapping")
 def test_determine_artefact_type_and_class_no_class_found(mock_mapping, capsys):
     mock_mapping.get.return_value = None
-    # The function returns (None, None) if the class is not in the mapping.
     artefact_type, artefact_class = determine_artefact_type_and_class("feature")
     assert artefact_type is None
     assert artefact_class is None
-    # The print statement inside the function is called before returning, so this check is valid.
     assert "No artefact class found for" in capsys.readouterr().out
 
 
@@ -124,7 +144,8 @@ def test_write_corrected_artefact():
 def test_construct_prompt_for_task():
     prompt = construct_prompt(ArtefactType.task, "some reason", "file.task", "text")
     assert (
-        "For task artefacts, if the action items looks like template or empty" in prompt
+        "For task artefacts, if the action items looks like template or empty"
+        in prompt
     )
 
 
@@ -133,28 +154,30 @@ def test_construct_prompt_for_task():
     "ara_cli.artefact_autofix.determine_artefact_type_and_class",
     return_value=(None, None),
 )
-@patch("ara_cli.artefact_autofix.read_artefact", return_value="original text")
+@patch("ara_cli.artefact_autofix.read_artefact")
 def test_apply_autofix_exits_when_classifier_is_invalid(
     mock_read, mock_determine, mock_run_agent, mock_classified_artefact_info
 ):
     """Tests that apply_autofix exits early if the classifier is invalid."""
     result = apply_autofix(
-        "file.feature",
-        "invalid",
-        "reason",
+        file_path="file.feature",
+        classifier="invalid",
+        reason="reason",
         deterministic=True,
         non_deterministic=True,
         classified_artefact_info=mock_classified_artefact_info,
     )
     assert result is False
-    mock_read.assert_called_once_with("file.feature")
     mock_determine.assert_called_once_with("invalid")
+    mock_read.assert_not_called()
     mock_run_agent.assert_not_called()
 
 
+@patch("ara_cli.artefact_autofix.FileClassifier")
+@patch("ara_cli.artefact_autofix.check_file")
 @patch("ara_cli.artefact_autofix.run_agent")
 @patch("ara_cli.artefact_autofix.write_corrected_artefact")
-@patch("ara_cli.artefact_autofix.fix_title_mismatch", return_value="fixed text")
+@patch("ara_cli.artefact_autofix.fix_title_mismatch")
 @patch("ara_cli.artefact_autofix.determine_artefact_type_and_class")
 @patch("ara_cli.artefact_autofix.read_artefact", return_value="original text")
 def test_apply_autofix_for_title_mismatch_with_deterministic_flag(
@@ -163,24 +186,31 @@ def test_apply_autofix_for_title_mismatch_with_deterministic_flag(
     mock_fix_title,
     mock_write,
     mock_run_agent,
+    mock_check_file,
+    mock_file_classifier,
     mock_artefact_type,
     mock_artefact_class,
     mock_classified_artefact_info,
 ):
     """Tests that a deterministic fix is applied when the flag is True."""
     mock_determine.return_value = (mock_artefact_type, mock_artefact_class)
-    reason = "Filename-Title Mismatch: some details"
+    mock_check_file.side_effect = [
+        (False, "Filename-Title Mismatch: some details"),
+        (True, ""),
+    ]
+    mock_fix_title.return_value = "fixed text"
 
     result = apply_autofix(
-        "file.feature",
-        "feature",
-        reason,
+        file_path="file.feature",
+        classifier="feature",
+        reason="Filename-Title Mismatch: some details",
         deterministic=True,
         non_deterministic=False,
         classified_artefact_info=mock_classified_artefact_info,
     )
 
     assert result is True
+    assert mock_check_file.call_count == 2
     mock_fix_title.assert_called_once_with(
         file_path="file.feature",
         artefact_text="original text",
@@ -189,8 +219,10 @@ def test_apply_autofix_for_title_mismatch_with_deterministic_flag(
     )
     mock_write.assert_called_once_with("file.feature", "fixed text")
     mock_run_agent.assert_not_called()
+    mock_file_classifier.assert_called_once()
 
 
+@patch("ara_cli.artefact_autofix.check_file")
 @patch("ara_cli.artefact_autofix.run_agent")
 @patch("ara_cli.artefact_autofix.write_corrected_artefact")
 @patch("ara_cli.artefact_autofix.fix_title_mismatch")
@@ -202,29 +234,34 @@ def test_apply_autofix_skips_title_mismatch_without_deterministic_flag(
     mock_fix_title,
     mock_write,
     mock_run_agent,
+    mock_check_file,
     mock_artefact_type,
     mock_artefact_class,
     mock_classified_artefact_info,
 ):
     """Tests that a deterministic fix is skipped when the flag is False."""
     mock_determine.return_value = (mock_artefact_type, mock_artefact_class)
-    reason = "Filename-Title Mismatch: some details"
+    mock_check_file.return_value = (False, "Filename-Title Mismatch: some details")
 
     result = apply_autofix(
-        "file.feature",
-        "feature",
-        reason,
+        file_path="file.feature",
+        classifier="feature",
+        reason="Filename-Title Mismatch: some details",
         deterministic=False,
         non_deterministic=True,
         classified_artefact_info=mock_classified_artefact_info,
     )
 
     assert result is False
+    mock_check_file.assert_called_once()
+    mock_read.assert_called_once_with("file.feature")
     mock_fix_title.assert_not_called()
     mock_write.assert_not_called()
     mock_run_agent.assert_not_called()
 
 
+@patch("ara_cli.artefact_autofix.FileClassifier")
+@patch("ara_cli.artefact_autofix.check_file")
 @patch("ara_cli.artefact_autofix.write_corrected_artefact")
 @patch("ara_cli.artefact_autofix.run_agent")
 @patch("ara_cli.artefact_autofix.determine_artefact_type_and_class")
@@ -234,27 +271,32 @@ def test_apply_autofix_for_llm_fix_with_non_deterministic_flag(
     mock_determine,
     mock_run_agent,
     mock_write,
+    mock_check_file,
+    mock_file_classifier,
     mock_artefact_type,
     mock_artefact_class,
     mock_classified_artefact_info,
 ):
     """Tests that an LLM fix is applied when the non-deterministic flag is True."""
     mock_determine.return_value = (mock_artefact_type, mock_artefact_class)
+    mock_check_file.side_effect = [(False, "Pydantic validation error"), (True, "")]
     mock_run_agent.return_value = mock_artefact_class
-    reason = "Pydantic validation error"
 
     result = apply_autofix(
-        "file.feature",
-        "feature",
-        reason,
+        file_path="file.feature",
+        classifier="feature",
+        reason="Pydantic validation error",
         deterministic=False,
         non_deterministic=True,
         classified_artefact_info=mock_classified_artefact_info,
     )
 
     assert result is True
+    assert mock_check_file.call_count == 2
+    mock_read.assert_called_once_with("file.feature")
     mock_run_agent.assert_called_once()
     mock_write.assert_called_once_with("file.feature", "llm corrected content")
+    mock_file_classifier.assert_called_once()
 
 
 @patch("ara_cli.artefact_autofix.write_corrected_artefact")
@@ -320,9 +362,6 @@ def test_apply_autofix_llm_exception(
     )
 
 
-# === Other Tests ===
-
-
 def test_fix_title_mismatch_success(mock_artefact_class):
     artefact_text = "Feature: wrong title\nSome other content"
     file_path = "path/to/correct_title.feature"
@@ -351,3 +390,228 @@ def test_run_agent_exception_handling(mock_agent_class):
     mock_agent_instance.run_sync.side_effect = Exception("Agent error")
     with pytest.raises(Exception, match="Agent error"):
         run_agent("prompt", MagicMock())
+
+
+@patch("builtins.input", side_effect=["1"])
+def test_ask_for_contribution_choice_valid(mock_input):
+    """Tests selecting a valid choice."""
+    choices = ["choice1", "choice2"]
+    # This simpler call now works without causing a TypeError
+    result = ask_for_contribution_choice(choices)
+    assert result == "choice1"
+
+@patch("builtins.input", side_effect=["99"])
+def test_ask_for_contribution_choice_out_of_range(mock_input, capsys):
+    """Tests selecting a choice that is out of range."""
+    choices = ["choice1", "choice2"]
+    result = ask_for_contribution_choice(choices)
+    assert result is None
+    assert "Invalid choice" in capsys.readouterr().out
+
+
+@patch("builtins.input", side_effect=["not a number"])
+def test_ask_for_contribution_choice_invalid_input(mock_input, capsys):
+    """Tests providing non-numeric input."""
+    choices = ["choice1", "choice2"]
+    result = ask_for_contribution_choice(choices)
+    assert result is None
+    assert "Invalid input" in capsys.readouterr().out
+
+
+@patch("builtins.input", side_effect=["feature my_feature_name"])
+def test_ask_for_correct_contribution_valid(mock_input):
+    """Tests providing valid '<classifier> <name>' input."""
+    name, classifier = ask_for_correct_contribution(("old_name", "feature"))
+    assert name == "my_feature_name"
+    assert classifier == "feature"
+
+
+@patch("builtins.input", side_effect=[""])
+def test_ask_for_correct_contribution_empty_input(mock_input):
+    """Tests providing empty input."""
+    name, classifier = ask_for_correct_contribution()
+    assert name is None
+    assert classifier is None
+
+
+@patch("builtins.input", side_effect=["invalid-one-word-input"])
+def test_ask_for_correct_contribution_invalid_format(mock_input, capsys):
+    """Tests providing input with the wrong format."""
+    # Fix: Use input that results in a single part after split()
+    name, classifier = ask_for_correct_contribution()
+    assert name is None
+    assert classifier is None
+    assert "Invalid input format" in capsys.readouterr().out
+
+
+def test_has_valid_contribution_true(mock_artefact_with_contribution):
+    """Tests with a valid contribution object."""
+    # Fix: Check for truthiness, not strict boolean equality
+    assert _has_valid_contribution(mock_artefact_with_contribution)
+
+
+def test_has_valid_contribution_false_no_contribution():
+    """Tests when the artefact's contribution is None."""
+    mock_artefact = MagicMock(spec=Artefact)
+    mock_artefact.contribution = None
+    # Fix: Check for falsiness, not strict boolean equality
+    assert not _has_valid_contribution(mock_artefact)
+
+
+@patch("ara_cli.artefact_autofix.FileClassifier")
+@patch("ara_cli.artefact_autofix.extract_artefact_names_of_classifier")
+@patch("ara_cli.artefact_autofix.find_closest_name_matches")
+def test_set_closest_contribution_no_change_needed(
+    mock_find, mock_extract, mock_classifier, mock_artefact_with_contribution
+):
+    """Tests the case where the contribution name is already the best match."""
+    mock_find.return_value = ["some_artefact"]  # Exact match is found
+    artefact, changed = set_closest_contribution(mock_artefact_with_contribution)
+    assert changed is False
+    assert artefact == mock_artefact_with_contribution
+
+
+@patch("ara_cli.artefact_autofix.FileClassifier")
+@patch("ara_cli.artefact_autofix.extract_artefact_names_of_classifier")
+@patch("ara_cli.artefact_autofix.find_closest_name_matches", return_value=[])
+@patch(
+    "ara_cli.artefact_autofix.ask_for_correct_contribution",
+    return_value=("new_name", "new_classifier"),
+)
+def test_set_closest_contribution_no_matches_user_provides(
+    mock_ask, mock_find, mock_extract, mock_classifier, mock_artefact_with_contribution
+):
+    """Tests when no matches are found and the user provides a new contribution."""
+    artefact, changed = set_closest_contribution(mock_artefact_with_contribution)
+    assert changed is True
+    assert artefact.contribution.artefact_name == "new_name"
+    assert artefact.contribution.classifier == "new_classifier"
+
+
+@patch("ara_cli.artefact_autofix.set_closest_contribution")
+@patch("ara_cli.artefact_autofix.FileClassifier")
+def test_fix_contribution(
+    mock_file_classifier, mock_set, mock_artefact_with_contribution
+):
+    """Tests the fix_contribution wrapper function."""
+    # Arrange
+    mock_artefact_class = MagicMock()
+    mock_artefact_class.deserialize.return_value = mock_artefact_with_contribution
+    mock_set.return_value = (mock_artefact_with_contribution, True)
+
+    # Act
+    result = fix_contribution(
+        file_path="dummy.path",
+        artefact_text="original text",
+        artefact_class=mock_artefact_class,
+        classified_artefact_info={},
+    )
+
+    # Assert
+    assert result == "serialized artefact text"
+    mock_artefact_class.deserialize.assert_called_once_with("original text")
+    mock_set.assert_called_once_with(mock_artefact_with_contribution)
+
+
+@patch("ara_cli.artefact_autofix.FileClassifier")
+@patch("ara_cli.artefact_autofix.check_file")
+@patch("ara_cli.artefact_autofix.write_corrected_artefact")
+@patch("ara_cli.artefact_autofix.fix_contribution", return_value="fixed text")
+@patch("ara_cli.artefact_autofix.determine_artefact_type_and_class")
+@patch("ara_cli.artefact_autofix.read_artefact", return_value="original text")
+def test_apply_autofix_for_contribution_mismatch(
+    mock_read,
+    mock_determine,
+    mock_fix_contribution,
+    mock_write,
+    mock_check_file,
+    mock_classifier,
+    mock_artefact_type,
+    mock_artefact_class,
+    mock_classified_artefact_info,
+):
+    """Tests the deterministic fix for 'Invalid Contribution Reference'."""
+    mock_determine.return_value = (mock_artefact_type, mock_artefact_class)
+    mock_check_file.side_effect = [
+        (False, "Invalid Contribution Reference"),
+        (True, ""),
+    ]
+
+    result = apply_autofix(
+        file_path="file.feature",
+        classifier="feature",
+        reason="Invalid Contribution Reference",
+        classified_artefact_info=mock_classified_artefact_info,
+    )
+
+    assert result is True
+    mock_fix_contribution.assert_called_once()
+    mock_write.assert_called_once_with("file.feature", "fixed text")
+
+
+@patch("ara_cli.artefact_autofix.check_file")
+@patch("ara_cli.artefact_autofix.write_corrected_artefact")
+@patch("ara_cli.artefact_autofix.fix_title_mismatch", return_value="original text")
+@patch("ara_cli.artefact_autofix.determine_artefact_type_and_class")
+@patch("ara_cli.artefact_autofix.read_artefact", return_value="original text")
+def test_apply_autofix_stops_if_no_alteration(
+    mock_read,
+    mock_determine,
+    mock_fix_title,
+    mock_write,
+    mock_check_file,
+    capsys,
+    mock_artefact_type,
+    mock_artefact_class,
+    mock_classified_artefact_info,
+):
+    """Tests that the loop stops if a fix attempt does not change the file content."""
+    mock_determine.return_value = (mock_artefact_type, mock_artefact_class)
+    mock_check_file.return_value = (False, "Filename-Title Mismatch")
+
+    result = apply_autofix(
+        file_path="file.feature",
+        classifier="feature",
+        reason="any",
+        classified_artefact_info=mock_classified_artefact_info,
+    )
+
+    assert result is False
+    mock_fix_title.assert_called_once()
+    mock_write.assert_not_called()
+    assert (
+        "Fixing attempt did not alter the file. Stopping to prevent infinite loop."
+        in capsys.readouterr().out
+    )
+
+
+@patch("ara_cli.artefact_autofix.check_file")
+@patch("ara_cli.artefact_autofix.determine_artefact_type_and_class")
+def test_apply_autofix_single_pass(
+    mock_determine,
+    mock_check_file,
+    capsys,
+    mock_artefact_type,
+    mock_artefact_class,
+    mock_classified_artefact_info,
+):
+    """Tests that single_pass=True runs the loop only once."""
+    mock_determine.return_value = (mock_artefact_type, mock_artefact_class)
+    # Simulate a failure that won't be fixed to ensure the loop doesn't repeat
+    mock_check_file.return_value = (False, "Some unfixable error")
+
+    apply_autofix(
+        file_path="file.feature",
+        classifier="feature",
+        reason="any",
+        single_pass=True,
+        deterministic=False, # Disable fixes
+        non_deterministic=False,
+        classified_artefact_info=mock_classified_artefact_info,
+    )
+
+    output = capsys.readouterr().out
+    assert "Single-pass mode enabled" in output
+    assert "Attempt 1/1" in output
+    assert "Attempt 2/1" not in output
+    mock_check_file.assert_called_once()