ara-cli 0.1.9.69__py3-none-any.whl → 0.1.9.71__py3-none-any.whl

tests/test_artefact_scan.py

@@ -8,6 +8,8 @@ def test_check_file_valid():
     """Tests the happy path where the file is valid and the title matches."""
     mock_artefact_instance = MagicMock()
     mock_artefact_instance.title = "dummy_path"
+    # Mock contribution to be None to avoid contribution reference check
+    mock_artefact_instance.contribution = None
 
     mock_artefact_class = MagicMock()
     mock_artefact_class.deserialize.return_value = mock_artefact_instance
@@ -15,8 +17,8 @@ def test_check_file_valid():
     with patch("builtins.open", mock_open(read_data="valid content")):
         is_valid, reason = check_file("dummy_path.feature", mock_artefact_class)
         
-    assert is_valid is True
-    assert reason is None
+    assert reason is None, f"Reason for invalid found, expected none to be found. The reason found: {reason}"
+    assert is_valid is True, "File detected as invalid, expected to be valid"
 
 
 def test_check_file_title_mismatch():
@@ -80,31 +82,35 @@ def test_check_file_unexpected_error():
 
 
 def test_find_invalid_files():
+    """Tests finding invalid files with proper mocking of check_file."""
     mock_artefact_class = MagicMock()
-    with patch("ara_cli.artefact_models.artefact_mapping.artefact_type_mapping", {"test_classifier": mock_artefact_class}):
-        artefact_files = {
-            "test_classifier": [
-                {"file_path": "file1.txt"},              # Should be checked
-                {"file_path": "file2.txt"},              # Should be checked
-                {"file_path": "templates/file3.txt"},    # Should be skipped
-                {"file_path": "some/path/file.data"}     # Should be skipped
-            ]
-        }
-
+    classified_info = {
+        "test_classifier": [
+            {"file_path": "file1.txt"},              # Should be checked
+            {"file_path": "file2.txt"},              # Should be checked
+            {"file_path": "templates/file3.txt"},    # Should be skipped
+            {"file_path": "some/path/file.data"}     # Should be skipped
+        ]
+    }
+    
+    with patch("ara_cli.artefact_models.artefact_mapping.artefact_type_mapping", 
+              {"test_classifier": mock_artefact_class}):
         with patch("ara_cli.artefact_scan.check_file") as mock_check_file:
             mock_check_file.side_effect = [
                 (True, None),              # for file1.txt
                 (False, "Invalid content") # for file2.txt
             ]
 
-            invalid_files = find_invalid_files(
-                artefact_files, "test_classifier")
+            invalid_files = find_invalid_files(classified_info, "test_classifier")
+            
             assert len(invalid_files) == 1
             assert invalid_files[0] == ("file2.txt", "Invalid content")
             assert mock_check_file.call_count == 2
+            
+            # Check that check_file was called with the correct parameters
             mock_check_file.assert_has_calls([
-                call("file1.txt", mock_artefact_class),
-                call("file2.txt", mock_artefact_class)
+                call("file1.txt", mock_artefact_class, classified_info),
+                call("file2.txt", mock_artefact_class, classified_info)
             ], any_order=False)
 
 
@@ -114,7 +120,7 @@ def test_show_results_no_issues(capsys):
         show_results(invalid_artefacts)
         captured = capsys.readouterr()
         assert captured.out == "All files are good!\n"
-        m.assert_called_once_with("incompatible_artefacts_report.md", "w")
+        m.assert_called_once_with("incompatible_artefacts_report.md", "w", encoding="utf-8")
         handle = m()
         handle.write.assert_has_calls([
             call("# Artefact Check Report\n\n"),
@@ -141,7 +147,7 @@ def test_show_results_with_issues(capsys):
             "\t\treason3\n"
         )
         assert captured.out == expected_output
-        m.assert_called_once_with("incompatible_artefacts_report.md", "w")
+        m.assert_called_once_with("incompatible_artefacts_report.md", "w", encoding="utf-8")
         handle = m()
         expected_writes = [
             call("# Artefact Check Report\n\n"),
@@ -153,4 +159,31 @@ def test_show_results_with_issues(capsys):
             call("- `file3.txt`: reason3\n"),
             call("\n")
         ]
-        handle.write.assert_has_calls(expected_writes, any_order=False)
+        handle.write.assert_has_calls(expected_writes, any_order=False)
+
+
+def test_check_file_with_invalid_contribution():
+    """Tests file with invalid contribution reference."""
+    mock_artefact_instance = MagicMock()
+    mock_artefact_instance.title = "dummy_path"
+    
+    # Set up invalid contribution
+    mock_contribution = MagicMock()
+    mock_contribution.classifier = "test_classifier"
+    mock_contribution.artefact_name = "non_existing_artefact"
+    mock_artefact_instance.contribution = mock_contribution
+
+    mock_artefact_class = MagicMock()
+    mock_artefact_class.deserialize.return_value = mock_artefact_instance
+
+    # Mock classified_artefact_info
+    classified_info = {"test_classifier": [{"name": "existing_artefact"}]}
+    
+    # Mock extract_artefact_names_of_classifier to return a list without the referenced artefact
+    with patch("builtins.open", mock_open(read_data="valid content")):
+        with patch("ara_cli.artefact_fuzzy_search.extract_artefact_names_of_classifier", 
+                  return_value=["existing_artefact"]):
+            is_valid, reason = check_file("dummy_path.feature", mock_artefact_class, classified_info)
+    
+    assert is_valid is False
+    assert "Invalid Contribution Reference" in reason

tests/test_file_classifier.py

@@ -241,7 +241,7 @@ def test_find_closest_artefact_name_match(mock_file_system):
         'file1', 'py') == 'file1'
 
     # Fuzzy match
-    with patch('ara_cli.file_classifier.find_closest_name_match', return_value='file2') as mock_fuzzy:
+    with patch('ara_cli.file_classifier.find_closest_name_matches', return_value='file2') as mock_fuzzy:
         assert classifier.find_closest_artefact_name_match(
             'file3', 'py') == 'file2'
         mock_fuzzy.assert_called_once_with('file3', ['file1', 'file2'])

tests/test_file_lister.py

@@ -55,7 +55,7 @@ def test_generate_markdown_listing_multiple_directories(setup_test_environment):
 
         generate_markdown_listing([temp_dir, another_temp_dir], ['*.py'], output_file_path)
 
-        with open(output_file_path, 'r') as f:
+        with open(output_file_path, 'r', encoding='utf-8') as f:
             output_content = f.read().splitlines()
 
         assert output_content == expected_content

tests/test_list_filter.py

@@ -65,7 +65,7 @@ def test_default_content_retrieval():
     with patch("builtins.open", mock_open(read_data=mock_data)) as mocked_file:
         content = ListFilterMonad.default_content_retrieval("dummy_path")
         assert content == mock_data
-        mocked_file.assert_called_once_with("dummy_path", 'r')
+        mocked_file.assert_called_once_with("dummy_path", 'r', encoding='utf-8')
 
 
 def test_default_tag_retrieval():
@@ -77,7 +77,7 @@ def test_default_content_retrieval_exception():
     with patch("builtins.open", side_effect=Exception("Mocked exception")) as mocked_file:
         content = ListFilterMonad.default_content_retrieval("dummy_path")
         assert content == ""  # Expect empty string on exception
-        mocked_file.assert_called_once_with("dummy_path", 'r')
+        mocked_file.assert_called_once_with("dummy_path", 'r', encoding='utf-8')
 
 
 @pytest.mark.parametrize("include, exclude, expected", [

tests/test_update_config_prompt.py

@@ -34,13 +34,13 @@ mock_content_updated = """
 def test_read_file():
     with patch('builtins.open', mock_open(read_data="data")) as mocked_file:
         result = read_file('dummy_path')
-        mocked_file.assert_called_once_with('dummy_path', 'r')
+        mocked_file.assert_called_once_with('dummy_path', 'r', encoding='utf-8')
         assert result == "data"
 
 def test_write_file():
     with patch('builtins.open', mock_open()) as mocked_file:
         write_file('dummy_path', 'data')
-        mocked_file.assert_called_once_with('dummy_path', 'w')
+        mocked_file.assert_called_once_with('dummy_path', 'w', encoding='utf-8')
         mocked_file().write.assert_called_once_with('data')
 
 def test_find_checked_items():