ara-cli 0.1.10.5__py3-none-any.whl → 0.1.14.0__py3-none-any.whl

tests/test_chat.py

@@ -4,14 +4,17 @@ import tempfile
 import base64
 import glob
 import cmd2
+import sys
 import ara_cli
 from unittest.mock import patch, MagicMock, mock_open
 from types import SimpleNamespace
+
+from io import StringIO
 from ara_cli.chat import Chat
 from ara_cli.error_handler import AraError
 from ara_cli.template_manager import TemplatePathManager
 from ara_cli.ara_config import ConfigManager
-from ara_cli.file_loaders.text_file_loader import TextFileLoader
+from ara_cli.file_loaders.loaders.text_file_loader import TextFileLoader
 
 
 def get_default_config():
@@ -66,7 +69,7 @@ def temp_load_file():
 
 
 def test_handle_existing_chat_no_reset(temp_chat_file):
-    with patch("builtins.input", return_value="n"):
+    with patch("sys.stdin.readline", return_value="n"):
         mock_config = get_default_config()
         with patch(
             "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
@@ -76,7 +79,7 @@ def test_handle_existing_chat_no_reset(temp_chat_file):
 
 
 def test_handle_existing_chat_with_reset(temp_chat_file):
-    with patch("builtins.input", return_value="y"):
+    with patch("sys.stdin.readline", return_value="y"):
         mock_config = get_default_config()
         with patch(
             "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
@@ -489,7 +492,7 @@ def test_send_message(
 
     mock_chunks = [mock_chunk1, mock_chunk2]
 
-    with patch("ara_cli.chat.send_prompt", return_value=mock_chunks), patch.object(
+    with patch("ara_cli.prompt_handler.send_prompt", return_value=mock_chunks), patch.object(
         chat, "get_last_line", return_value=last_line_in_file
     ), patch.object(chat, "assemble_prompt", return_value="mocked prompt"):
 
@@ -740,7 +743,7 @@ def test_load_binary_file(temp_chat_file, path_exists):
 
     # We patch open within the loader's module
     with patch(
-        "ara_cli.file_loaders.binary_file_loader.open",
+        "ara_cli.file_loaders.loaders.binary_file_loader.open",
         mock_open(read_data=file_content),
     ) as mock_loader_open:
 
@@ -816,7 +819,7 @@ def test_load_document_file(
         mock_setup(mock_modules[module_to_mock])
 
         with patch(
-            "ara_cli.file_loaders.document_file_loader.open", mock_open()
+            "builtins.open", mock_open()
         ) as mock_chat_open:
             # FIX: Call with a positional argument `file_name` as the decorator expects, not a keyword `file_path`.
             result = chat.load_document_file(
@@ -951,13 +954,14 @@ def test_choose_file_to_load_valid_cases(
     monkeypatch.setattr("builtins.input", mock_input)
 
     mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        with patch("builtins.open", mock_open()):
-            chat = Chat("dummy_chat_name", reset=False)
+    with patch("sys.stdin.readline", return_value=f"{user_input}\n"):
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            with patch("builtins.open", mock_open()):
+                chat = Chat("dummy_chat_name", reset=False)
 
-    file_path = chat.choose_file_to_load(files, pattern)
+        file_path = chat.choose_file_to_load(files, pattern)
 
     captured = capsys.readouterr()
 
@@ -1000,19 +1004,23 @@ def test_choose_file_to_load_invalid_choice_index(
 ):
     """Test choose_file_to_load with invalid choice indices"""
 
+    # Mock input for the test setup, but actual test uses sys.stdin.readline
+    # Mock input for the test setup, but actual test uses sys.stdin.readline
     def mock_input(prompt):
         return user_input
 
     monkeypatch.setattr("builtins.input", mock_input)
+    
+    # We also need to mock sys.stdin.readline because that's what's actually used in the code
+    with patch("sys.stdin.readline", return_value=f"{user_input}\n"):
+        mock_config = get_default_config()
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            with patch("builtins.open", mock_open()):
+                chat = Chat("dummy_chat_name", reset=False)
 
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        with patch("builtins.open", mock_open()):
-            chat = Chat("dummy_chat_name", reset=False)
-
-    file_path = chat.choose_file_to_load(files, pattern)
+        file_path = chat.choose_file_to_load(files, pattern)
 
     # Verify error was reported
     mock_report_error.assert_called_once()
@@ -1061,16 +1069,19 @@ def test_choose_file_to_load_invalid_input_format(
     def mock_input(prompt):
         return user_input
 
+    # Mock input for the test setup, but actual test uses sys.stdin.readline
     monkeypatch.setattr("builtins.input", mock_input)
+    
+    # We also need to mock sys.stdin.readline because that's what's actually used in the code
+    with patch("sys.stdin.readline", return_value=f"{user_input}\n"):
+        mock_config = get_default_config()
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            with patch("builtins.open", mock_open()):
+                chat = Chat("dummy_chat_name", reset=False)
 
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        with patch("builtins.open", mock_open()):
-            chat = Chat("dummy_chat_name", reset=False)
-
-    file_path = chat.choose_file_to_load(files, pattern)
+        file_path = chat.choose_file_to_load(files, pattern)
 
     # Verify error was reported
     mock_report_error.assert_called_once()
@@ -1091,15 +1102,17 @@ def test_choose_file_to_load_files_are_sorted(monkeypatch, capsys):
         return "2"  # Choose the second file (beta.md after sorting)
 
     monkeypatch.setattr("builtins.input", mock_input)
+    
+    # Mock sys.stdin.readline as used in implementation
+    with patch("sys.stdin.readline", return_value="2\n"):
+        mock_config = get_default_config()
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            with patch("builtins.open", mock_open()):
+                chat = Chat("dummy_chat_name", reset=False)
 
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        with patch("builtins.open", mock_open()):
-            chat = Chat("dummy_chat_name", reset=False)
-
-    file_path = chat.choose_file_to_load(files, "*.md")
+        file_path = chat.choose_file_to_load(files, "*.md")
 
     captured = capsys.readouterr()
 
@@ -1120,15 +1133,17 @@ def test_choose_file_to_load_basename_displayed(monkeypatch, capsys):
         return "1"
 
     monkeypatch.setattr("builtins.input", mock_input)
+    
+    # Mock sys.stdin.readline as used in implementation
+    with patch("sys.stdin.readline", return_value="1\n"):
+        mock_config = get_default_config()
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            with patch("builtins.open", mock_open()):
+                chat = Chat("dummy_chat_name", reset=False)
 
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        with patch("builtins.open", mock_open()):
-            chat = Chat("dummy_chat_name", reset=False)
-
-    file_path = chat.choose_file_to_load(files, "*.md")
+        file_path = chat.choose_file_to_load(files, "*.md")
 
     captured = capsys.readouterr()
 
@@ -1173,15 +1188,20 @@ def test_choose_file_to_load_input_prompt_message(monkeypatch, capsys):
         return "1"
 
     monkeypatch.setattr("builtins.input", mock_input)
+    # Use sys.stdin.readline to provide input and StringIO to capture stdout
+    with patch("sys.stdin.readline", return_value="1\n"), patch(
+        "sys.stdout", new_callable=StringIO
+    ) as mock_stdout:
+        mock_config = get_default_config()
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            with patch("builtins.open", mock_open()):
+                chat = Chat("dummy_chat_name", reset=False)
 
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        with patch("builtins.open", mock_open()):
-            chat = Chat("dummy_chat_name", reset=False)
-
-    chat.choose_file_to_load(files, "*.md")
+        chat.choose_file_to_load(files, "*.md")
+        output = mock_stdout.getvalue()
+    assert expected_prompt in output
 
 
 @pytest.mark.parametrize(
@@ -1304,24 +1324,22 @@ def test_load_helper_basic_scenarios(
     def mock_glob(file_pattern):
         return existing_files
 
-    def mock_input(prompt):
-        return user_input
-
-    def mock_load_file(self, file_path):
-        return True
-
     monkeypatch.setattr(glob, "glob", mock_glob)
-    monkeypatch.setattr("builtins.input", mock_input)
-    monkeypatch.setattr(Chat, "load_file", mock_load_file)
     monkeypatch.setattr(Chat, "add_prompt_tag_if_needed", lambda self, chat_file: None)
 
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        chat = Chat(temp_chat_file.name, reset=False)
+    with patch("sys.stdin.readline", return_value=f"{user_input}\n"):
+        def mock_load_file(self, file_path):
+            return True
+
+        monkeypatch.setattr(Chat, "load_file", mock_load_file)
+
+        mock_config = get_default_config()
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            chat = Chat(temp_chat_file.name, reset=False)
 
-    chat._load_helper(directory, pattern, file_type, exclude_pattern)
+        chat._load_helper(directory, pattern, file_type, exclude_pattern)
 
     captured = capsys.readouterr()
     # Check both stdout and stderr since error messages go to stderr
@@ -1394,24 +1412,22 @@ def test_load_helper_with_exclusions(
             return excluded_files
         return existing_files
 
-    def mock_input(prompt):
-        return user_input
-
-    def mock_load_file(self, file_path):
-        return True
-
     monkeypatch.setattr(glob, "glob", mock_glob)
-    monkeypatch.setattr("builtins.input", mock_input)
-    monkeypatch.setattr(Chat, "load_file", mock_load_file)
     monkeypatch.setattr(Chat, "add_prompt_tag_if_needed", lambda self, chat_file: None)
 
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        chat = Chat(temp_chat_file.name, reset=False)
+    with patch("sys.stdin.readline", return_value=f"{user_input}\n"):
+        def mock_load_file(self, file_path):
+            return True
+
+        monkeypatch.setattr(Chat, "load_file", mock_load_file)
+
+        mock_config = get_default_config()
+        with patch(
+            "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+        ):
+            chat = Chat(temp_chat_file.name, reset=False)
 
-    chat._load_helper(directory, pattern, file_type, exclude_pattern)
+        chat._load_helper(directory, pattern, file_type, exclude_pattern)
 
     captured = capsys.readouterr()
     # Check both stdout and stderr since error messages go to stderr
@@ -1441,7 +1457,8 @@ def test_load_helper_load_file_fails(monkeypatch, capsys, temp_chat_file):
     ):
         chat = Chat(temp_chat_file.name, reset=False)
 
-    chat._load_helper("prompt.data", "*.rules.md", "rules")
+    with patch("sys.stdin.readline", return_value="1\n"): # Add stdin mock for choose_file_to_load
+        chat._load_helper("prompt.data", "*.rules.md", "rules")
 
     captured = capsys.readouterr()
     output = captured.out + captured.err
@@ -1495,8 +1512,8 @@ def test_load_helper_directory_path_construction(temp_chat_file):
     with patch("glob.glob", side_effect=mock_glob), patch.object(
         chat, "load_file", return_value=True
     ), patch.object(chat, "add_prompt_tag_if_needed"):
-
-        chat._load_helper("custom_dir", "*.custom.md", "custom")
+        with patch("sys.stdin.readline", return_value="1\n"): # Add stdin mock for choose_file_to_load
+            chat._load_helper("custom_dir", "*.custom.md", "custom")
 
 
 def test_load_helper_calls_add_prompt_tag_before_load(temp_chat_file):
@@ -1519,8 +1536,8 @@ def test_load_helper_calls_add_prompt_tag_before_load(temp_chat_file):
     with patch("glob.glob", return_value=["rules1.md"]), patch.object(
         chat, "add_prompt_tag_if_needed", side_effect=mock_add_prompt_tag
     ), patch.object(chat, "load_file", side_effect=mock_load_file):
-
-        chat._load_helper("prompt.data", "*.rules.md", "rules")
+        with patch("sys.stdin.readline", return_value="1\n"): # Add stdin mock for choose_file_to_load
+            chat._load_helper("prompt.data", "*.rules.md", "rules")
 
         # Verify correct call order
         assert call_order == ["add_prompt_tag", "load_file"]
@@ -1547,20 +1564,6 @@ def test_load_helper_reports_error_when_no_files_found(
         assert "No rules file found." in str(error_call[0])
 
 
-def test_help_menu_with_aliases(temp_chat_file, capsys):
-    mock_config = get_default_config()
-    with patch(
-        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
-    ):
-        chat = Chat(temp_chat_file.name, reset=False)
-
-    chat._help_menu(verbose=False)
-    captured = capsys.readouterr()
-
-    assert "Aliases" in captured.out
-    assert "q -> quit" in captured.out
-    assert "h -> help" in captured.out
-    assert "s -> SEND" in captured.out
 
 
 def test_do_quit(temp_chat_file, capsys):
@@ -1658,11 +1661,7 @@ def test_do_LOAD_interactive(monkeypatch, capsys, temp_chat_file, temp_load_file
     def mock_glob(file_pattern):
         return [temp_load_file.name]
 
-    def mock_input(prompt):
-        return temp_load_file.name
-
     monkeypatch.setattr(glob, "glob", mock_glob)
-    monkeypatch.setattr("builtins.input", mock_input)
     monkeypatch.setattr(Chat, "add_prompt_tag_if_needed", lambda self, chat_file: None)
 
     mock_config = get_default_config()
@@ -1670,7 +1669,8 @@ def test_do_LOAD_interactive(monkeypatch, capsys, temp_chat_file, temp_load_file
         "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
     ):
         chat = Chat(temp_chat_file.name, reset=False)
-    chat.do_LOAD("")
+    with patch("sys.stdin.readline", return_value=f"1\n"): # Simulate user choosing the first file
+        chat.do_LOAD("")
 
     captured = capsys.readouterr()
     assert f"Loaded contents of file {temp_load_file.name}" in captured.out
@@ -1703,7 +1703,11 @@ def test_complete_LOAD(
         "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
     ):
         chat = Chat(temp_chat_file.name, reset=False)
-    completions = chat.complete_LOAD(text, line, begidx, endidx)
+    monkeypatch.setattr(Chat, "add_prompt_tag_if_needed", lambda self, chat_file: None)
+    
+    # No user input is needed for completion, but if choose_file_to_load is called, it needs stdin
+    with patch("sys.stdin.readline", return_value="1\n"):
+        completions = chat.complete_LOAD(text, line, begidx, endidx)
 
     assert completions == matching_files
 
@@ -1832,7 +1836,7 @@ def test_load_image_binary_type_mapping_usage(mock_report_error, temp_chat_file)
         chat = Chat(temp_chat_file.name, reset=False)
 
     # Verify the mapping is used correctly by testing each supported extension
-    original_mapping = Chat.BINARY_TYPE_MAPPING.copy()
+    original_mapping = ara_cli.BINARY_TYPE_MAPPING.copy()
 
     with patch.object(chat, "load_binary_file", return_value=True) as mock_load_binary:
         for extension, expected_mime in original_mapping.items():
@@ -1895,35 +1899,30 @@ def test_do_LOAD_IMAGE(
 
 
 @pytest.mark.parametrize(
-    "input_chat_name, expected_chat_name",
+    "input_chat_name, user_input, expected_name_part",
     [
-        ("", "What should be the new chat name? "),
-        ("new_chat", "new_chat_chat.md"),
-        ("new_chat.md", "new_chat.md"),
+        ("", "interactive_name\n", "interactive_name"),
+        ("cli_arg_name", "", "cli_arg_name"),
     ],
 )
-def test_do_new(monkeypatch, temp_chat_file, input_chat_name, expected_chat_name):
-    def mock_input(prompt):
-        return "input_chat_name"
-
-    monkeypatch.setattr("builtins.input", mock_input)
-
+def test_do_new(temp_chat_file, capsys, input_chat_name, user_input, expected_name_part):
     mock_config = get_default_config()
     with patch(
         "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
     ):
         chat = Chat(temp_chat_file.name, reset=False)
 
-    with patch.object(Chat, "__init__", return_value=None) as mock_init:
+    with patch("sys.stdin.readline", return_value=user_input), \
+         patch.object(Chat, "__init__", return_value=None) as mock_init:
+        
         chat.do_NEW(input_chat_name)
-        if input_chat_name == "":
-            mock_init.assert_called_with(
-                os.path.join(os.path.dirname(temp_chat_file.name), "input_chat_name")
-            )
-        else:
-            mock_init.assert_called_with(
-                os.path.join(os.path.dirname(temp_chat_file.name), input_chat_name)
-            )
+        
+        expected_path = os.path.join(os.path.dirname(temp_chat_file.name), expected_name_part)
+        mock_init.assert_called_with(expected_path)
+
+    captured = capsys.readouterr()
+    if input_chat_name == "":
+        assert "What should be the new chat name? " in captured.out
 
 
 def test_do_RERUN(temp_chat_file):
@@ -1956,7 +1955,7 @@ def test_do_CLEAR(temp_chat_file, capsys):
     ):
         chat = Chat(temp_chat_file.name, reset=False)
 
-    with patch("builtins.input", return_value="y"):
+    with patch("sys.stdin.readline", return_value="y"):
         chat.do_CLEAR(None)
 
     captured = capsys.readouterr()
@@ -1979,7 +1978,7 @@ def test_do_CLEAR_abort(temp_chat_file, capsys):
     ):
         chat = Chat(temp_chat_file.name, reset=False)
 
-    with patch("builtins.input", return_value="n"):
+    with patch("sys.stdin.readline", return_value="n"):
         chat.do_CLEAR(None)
 
     captured = capsys.readouterr()
@@ -2441,7 +2440,7 @@ def test_do_SEND(temp_chat_file):
         with patch.object(chat, "send_message") as mock_send_message:
             chat.do_SEND(None)
             mock_save_message.assert_called_once_with(
-                Chat.ROLE_PROMPT, "Message part 1\nMessage part 2"
+                ara_cli.ROLE_PROMPT, "Message part 1\nMessage part 2"
             )
             mock_send_message.assert_called_once()
 
@@ -2631,5 +2630,42 @@ def test_do_LOAD_TEMPLATE_serialize_called_correctly(temp_chat_file):
         # Verify serialize was called exactly once
         mock_artefact.serialize.assert_called_once_with()
 
-        # Verify the serialized content was written to file
-        mock_file().write.assert_called_once_with(expected_content)
+
+def test_do_run_pyscript_parsing(temp_chat_file):
+    """Test argument parsing for run_pyscript command."""
+    mock_config = get_default_config()
+    with patch(
+        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+    ):
+        chat = Chat(temp_chat_file.name, reset=False)
+
+    chat.script_runner = MagicMock()
+    
+    # Test with simple arguments
+    # Note: simulate cmd2 passing a string (Statement behaves like string)
+    chat.do_run_pyscript('script.py arg1 arg2')
+    chat.script_runner.run_script.assert_called_with('script.py', ['arg1', 'arg2'])
+
+    # Test with quoted arguments
+    chat.do_run_pyscript('script.py "arg with spaces" arg2')
+    chat.script_runner.run_script.assert_called_with('script.py', ['arg with spaces', 'arg2'])
+
+    # Test with single argument
+    chat.do_run_pyscript('script.py')
+    chat.script_runner.run_script.assert_called_with('script.py', [])
+
+
+def test_do_run_pyscript_empty(temp_chat_file):
+    """Test run_pyscript with no arguments."""
+    mock_config = get_default_config()
+    with patch(
+        "ara_cli.prompt_handler.ConfigManager.get_config", return_value=mock_config
+    ):
+        chat = Chat(temp_chat_file.name, reset=False)
+
+    chat.script_runner = MagicMock()
+    
+    chat.do_run_pyscript('')
+    # Should not call run_script if no script name provided
+    chat.script_runner.run_script.assert_not_called()
+