aplos-nca-saas-sdk 0.0.12__py3-none-any.whl → 0.0.14__py3-none-any.whl

aplos_nca_saas_sdk/integration_testing/tests/file_upload_test.py

@@ -1,5 +1,5 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """
@@ -18,8 +18,12 @@ from aplos_nca_saas_sdk.integration_testing.integration_test_response import (
     IntegrationTestResponse,
 )
 from aplos_nca_saas_sdk.nca_resources.nca_file_upload import NCAFileUpload
-from aplos_nca_saas_sdk.nca_resources.nca_login import NCALogin
+from aplos_nca_saas_sdk.nca_resources.nca_file_download import NCAFileDownload
+from aplos_nca_saas_sdk.nca_resources.nca_authenticator import NCAAuthenticator
 from aplos_nca_saas_sdk.utilities.http_utility import HttpUtilities
+from aplos_nca_saas_sdk.integration_testing.configs.file_upload_config import (
+    FileUploadConfig,
+)
 
 logger = Logger()
 
@@ -35,31 +39,30 @@ class FileUploadTest(IntegrationTestBase):
 
         self.results.clear()
 
+        file_upload: FileUploadConfig
         for file_upload in self.config.file_uploads.list:
             test_response: IntegrationTestResponse = IntegrationTestResponse()
             test_response.name = self.name
             try:
                 # Confirm Login
                 nca_login = self.__login(file_upload.login)
-                if not nca_login.jwt:
-                    test_response.error = "Failed to authenticate"
+                # if not nca_login.cognito.jwt:
+                #     test_response.error = "Failed to authenticate"
+                # else:
+                # Confirm Upload
+                upload_response: Dict[str, Any] = self.__upload(
+                    nca_login, file_upload.file_path
+                )
+                if upload_response is None:
+                    test_response.error = "Failed to upload"
                 else:
-                    # Confirm Upload
-                    upload_response: Dict[str, Any] = self.__upload(
-                        nca_login, file_upload.file_path
-                    )
-                    if upload_response is None:
-                        test_response.error = "Failed to upload"
-                    else:
-                        # Confirm conversion and download
-                        # Allow time buffer so file data is available
-                        file_id: str = upload_response.get("file_id", "")
-                        if not file_id:
-                            raise RuntimeError(
-                                "Failed to get a file_id from the upload"
-                            )
-                        time.sleep(3)
-                        self.__download(nca_login, file_id, test_response)
+                    # Confirm conversion and download
+                    # Allow time buffer so file data is available
+                    file_id: str = upload_response.get("file_id", "")
+                    if not file_id:
+                        raise RuntimeError("Failed to get a file_id from the upload")
+                    time.sleep(3)
+                    self.__download(nca_login, file_id, test_response)
 
             except Exception as e:  # pylint: disable=w0718
                 test_response.error = str(e)
@@ -68,91 +71,37 @@ class FileUploadTest(IntegrationTestBase):
 
         return self.success()
 
-    def __login(self, login: LoginConfig) -> NCALogin:
-        nca_login = NCALogin(aplos_saas_domain=login.domain)
+    def __login(self, login: LoginConfig) -> NCAAuthenticator:
+        nca_login = NCAAuthenticator(host=login.host)
         nca_login.authenticate(username=login.username, password=login.password)
         return nca_login
 
-    def __upload(self, nca_login: NCALogin, upload_file_path: str) -> Dict[str, Any]:
+    def __upload(self, auth: NCAAuthenticator, upload_file_path: str) -> Dict[str, Any]:
         logger.info({"message": "Uploading file", "file_path": upload_file_path})
 
-        nca_file_upload = NCAFileUpload(nca_login)
+        nca_file_upload = NCAFileUpload(auth.host)
+        nca_file_upload.authenticator = auth
         upload_response: Dict[str, Any] = nca_file_upload.upload(upload_file_path)
         return upload_response
 
     def __download(
         self,
-        nca_login: NCALogin,
+        nca_login: NCAAuthenticator,
         file_id: str,
         test_response: IntegrationTestResponse,
     ):
         logger.info({"message": "Downloading file", "file_id": file_id})
-        file_data_endpoint = nca_login.config.endpoints.file_data(
-            nca_login.cognito.tenant_id,
-            nca_login.cognito.user_id,
-            file_id,
-        )
-        file_info_endpoint = nca_login.config.endpoints.file(
-            nca_login.cognito.tenant_id,
-            nca_login.cognito.user_id,
-            file_id,
-        )
-
-        max_wait_in_minutes: int = 3
-        headers = HttpUtilities.get_headers(nca_login.jwt)
-        current_time = datetime.now()
-
-        # Create a timedelta object representing 3 minutes
-        time_delta = timedelta(minutes=max_wait_in_minutes)
-        # Add the timedelta to the current time
-        max_time = current_time + time_delta
-
-        complete = False
-        while not complete:
-            response = requests.get(file_info_endpoint, headers=headers, timeout=60)
-            json_response: dict = response.json()
-            errors: List[Dict[str, Any]] = []
-            errors.extend(json_response.get("errors") or [])
-            status = json_response.get("workable_state")
-            complete = status == "ready"
-
-            if status == "invalid" or len(errors) > 0:
-                test_response.success = False
-                test_response.error = (
-                    "File conversion failed."
-                    if len(errors) < 0
-                    else f"File conversion failed with errors ${errors}."
-                )
-                break
-            if complete:
-                break
-            if not complete:
-                time.sleep(5)
-            if datetime.now() > max_time:
-                test_response.success = False
-                test_response.error = (
-                    "Timeout attempting to get conversion file status. "
-                    f"The current timeout limit is {max_wait_in_minutes} minutes. "
-                    "You may need to up the timeout period, or check for errors. "
-                )
-                break
-
-        if test_response.error is not None:
-            return
+        downloader: NCAFileDownload = NCAFileDownload(nca_login.host)
+        downloader.authenticator = nca_login
+        response = downloader.download(file_id)
 
-        file_response = requests.get(file_data_endpoint, headers=headers, timeout=30)
-
-        json_file_response: dict = file_response.json()
-        data = json_file_response.get("data", None)
-        error = json_file_response.get("error", None)
-
-        if data is None:
+        status = response.get("workable_state")
+        if status != "ready":
             test_response.success = False
-            test_response.error = "File download missing expected data. "
-        if error is not None:
-            test_response.success = False
-            test_response.error = (
-                test_response.error or ""
-            ) + f"File download contained error ${error}"
+            test_response.error = f"File conversion failed. Status: {status}"
+        else:
+            test_response.success = True
+
+        test_response.response = response
 
-        test_response.success = True
+        return response

aplos_nca_saas_sdk/integration_testing/tests/nca_analysis_test.py

@@ -1,5 +1,5 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """
@@ -48,7 +48,7 @@ class NCAAnalysisTest(IntegrationTestBase):
             try:
                 # Create new NCA Execution
                 nca_execution: NCAAnalysis = NCAAnalysis(
-                    nca_execution_config.login.domain
+                    nca_execution_config.login.host
                 )
 
                 # Initialize Configuration Data

aplos_nca_saas_sdk/integration_testing/tests/validation_test.py

@@ -1,5 +1,5 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """

aplos_nca_saas_sdk/nca_resources/_api_base.py

@@ -0,0 +1,44 @@
+"""
+Copyright 2024-2025 Aplos Analytics
+All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
+Property of Aplos Analytics, Utah, USA
+"""
+
+from typing import Any
+
+
+from aplos_nca_saas_sdk.nca_resources.nca_authenticator import NCAAuthenticator
+from aplos_nca_saas_sdk.nca_resources.nca_endpoints import NCAEndpoints
+
+
+class NCAApiBaseClass:
+    """NCA Api Base Class"""
+
+    def __init__(self, host: str) -> None:
+        self.host = host
+        self.__authenticator: NCAAuthenticator = NCAAuthenticator(host=host)
+        self.__endpoints: NCAEndpoints = NCAEndpoints(host=host)
+        if not host:
+            raise ValueError("Missing Aplos Api Domain")
+
+    @property
+    def authenticator(self) -> NCAAuthenticator:
+        """Gets the authenticator"""
+
+        return self.__authenticator
+
+    @authenticator.setter
+    def authenticator(self, value: Any) -> None:
+        """Sets the authenticator"""
+
+        self.__authenticator = value
+
+    @property
+    def endpoints(self) -> NCAEndpoints:
+        """Gets the endpoints"""
+
+        if self.authenticator.cognito.jwt:
+            self.__endpoints.tenant_id = self.authenticator.cognito.tenant_id
+            self.__endpoints.user_id = self.authenticator.cognito.user_id
+
+        return self.__endpoints

aplos_nca_saas_sdk/{aws_resources → nca_resources}/aws_cognito.py

@@ -1,5 +1,5 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """
@@ -79,7 +79,7 @@ class CognitoAuthentication:
           - or the Aplos Domain (which can get the clientId and region)
         """
         if self.__client_id is None and self.__aplos_domain is not None:
-            self.__config = NCAAppConfiguration(aplos_saas_domain=self.__aplos_domain)
+            self.__config = NCAAppConfiguration(host=self.__aplos_domain)
             self.__client_id = self.__config.cognito_client_id
             self.__region = self.__config.cognito_region
 

aplos_nca_saas_sdk/{aws_resources → nca_resources}/aws_s3_presigned_payload.py

@@ -1,12 +1,12 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """
 
 
-class S3PresignedPayload:
-    """S3PresignedPayload"""
+class S3PresignedUrlPayload:
+    """S3 Presigned Url Payload"""
 
     def __init__(self, payload: dict | None = None) -> None:
         self.url: str | None = None

aplos_nca_saas_sdk/{aws_resources → nca_resources}/aws_s3_presigned_upload.py

@@ -1,5 +1,5 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """
@@ -9,20 +9,23 @@ import os
 from typing import Any, Dict
 
 import requests
-from aplos_nca_saas_sdk.aws_resources.aws_s3_presigned_payload import (
-    S3PresignedPayload,
+from aplos_nca_saas_sdk.nca_resources.aws_s3_presigned_payload import (
+    S3PresignedUrlPayload,
 )
-from aplos_nca_saas_sdk.utilities.http_utility import HttpUtilities, Routes
+from aplos_nca_saas_sdk.utilities.http_utility import HttpUtilities
+from aplos_nca_saas_sdk.nca_resources._api_base import NCAApiBaseClass
 
 
-class S3PresignedUpload:
-    """S3PresignedUpload"""
+class S3PresignedUrlUpload(NCAApiBaseClass):
+    """S3PresignedUrlUpload"""
 
-    def __init__(self, jwt: str, api_url: str) -> None:
-        self.api_url = api_url
-        self.jwt = jwt
+    def __init__(self, host: str) -> None:
+        super().__init__(host)
 
-    def upload_file(self, input_file: str) -> Dict[str, Any]:
+    def upload_file(
+        self,
+        input_file: str,
+    ) -> Dict[str, Any]:
         """
         Uploads a file to your Aplos Cloud Account in AWS
 
@@ -34,15 +37,17 @@ class S3PresignedUpload:
         """
 
         # get the presigned url for uploading
-        paylod: S3PresignedPayload = self.__get_presigned_upload_info(
-            input_file=input_file
+        paylod: S3PresignedUrlPayload = self.__get_presigned_upload_info(
+            input_file=input_file, jwt=self.authenticator.cognito.jwt
         )
         # upload the files
         upload_response = self.__upload_file_to_s3(paylod, input_file=input_file)
 
         return upload_response
 
-    def __get_presigned_upload_info(self, input_file: str) -> S3PresignedPayload:
+    def __get_presigned_upload_info(
+        self, input_file: str, jwt: str
+    ) -> S3PresignedUrlPayload:
         """
         Performs all the necessary steps for creating a presigned url to upload a file to S3.
         We're using AWS S3 presigned urls for security as well as allowing for very large files if required.
@@ -50,11 +55,11 @@ class S3PresignedUpload:
             input_file (str): the path to the input (analysis) file
 
         Returns:
-            S3PresignedPayload: instance of S3PresignedPayload
+            S3PresignedUrlPayload: instance of S3PresignedUrlPayload
         """
 
-        url = f"{self.api_url}/{Routes.NCA_GENERATE_UPLOAD}"
-        headers = HttpUtilities.get_headers(self.jwt)
+        url = self.endpoints.files
+        headers = HttpUtilities.get_headers(jwt)
 
         body = {"file_name": input_file, "method_type": "post"}
         response = requests.post(
@@ -64,29 +69,29 @@ class S3PresignedUpload:
         if response.status_code == 403:
             raise PermissionError(
                 "Failed to get a presigned url. "
-                f"Status Code: {response.status_code }"
+                f"Status Code: {response.status_code}"
                 f"Reason: {response.reason} "
                 f"403 Errors can also occur if you have an invalid path."
             )
         elif response.status_code != 200:
             raise RuntimeError(
                 "Failed to get a presigned url. "
-                f"Status Code: {response.status_code }"
+                f"Status Code: {response.status_code}"
                 f"Reason: {response.reason}"
             )
         result = response.json()
 
-        payload: S3PresignedPayload = S3PresignedPayload(result)
+        payload: S3PresignedUrlPayload = S3PresignedUrlPayload(result)
 
         return payload
 
     def __upload_file_to_s3(
-        self, payload: S3PresignedPayload, input_file: str
+        self, payload: S3PresignedUrlPayload, input_file: str
     ) -> Dict[str, Any]:
         """
         Peforms the actual uploading via a presigned url for S3 bucket storage
         Args:
-            payload (S3PresignedPayload): instance of S3PresignedPayload with all the data needed
+            payload (S3PresignedUrlPayload): instance of S3PresignedUrlPayload with all the data needed
             input_file (str): the path to a file being uploaded
 
         Raises:
@@ -104,8 +109,9 @@ class S3PresignedUpload:
         with open(input_file, "rb") as file:
             files = {"file": (input_file, file)}
             # upload to s3 with the presigned url
+            # authentication is built into the url
             upload_response = requests.post(
-                str(payload.url), data=payload.form_data, files=files, timeout=30
+                str(payload.url), data=payload.form_data, files=files, timeout=60
             )
 
         # Check the response: 204 is a success in this case

aplos_nca_saas_sdk/nca_resources/nca_analysis.py

@@ -1,5 +1,5 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """
@@ -11,61 +11,27 @@ import zipfile
 from datetime import datetime, timedelta
 from pathlib import Path
 from typing import Any, Dict
-from aws_lambda_powertools import Logger
+
 import requests
+from aws_lambda_powertools import Logger
 
-from aplos_nca_saas_sdk.aws_resources.aws_cognito import CognitoAuthentication
-from aplos_nca_saas_sdk.aws_resources.aws_s3_presigned_upload import (
-    S3PresignedUpload,
+from aplos_nca_saas_sdk.nca_resources._api_base import NCAApiBaseClass
+from aplos_nca_saas_sdk.nca_resources.aws_s3_presigned_upload import (
+    S3PresignedUrlUpload,
 )
-from aplos_nca_saas_sdk.utilities.commandline_args import CommandlineArgs
-from aplos_nca_saas_sdk.utilities.http_utility import HttpUtilities, Routes
 from aplos_nca_saas_sdk.utilities.environment_vars import EnvironmentVars
+from aplos_nca_saas_sdk.utilities.http_utility import HttpUtilities
 
 logger = Logger()
 
 
-class NCAAnalysis:
-    """NCA Analysis API Access"""
+class NCAAnalysis(NCAApiBaseClass):
+    """NCA Analysis API"""
 
-    def __init__(self, api_domain: str) -> None:
-        self.__jwt: str
+    def __init__(self, host: str) -> None:
+        super().__init__(host)
 
-        if not api_domain:
-            raise ValueError("Missing Aplos Api Domain")
-
-        self.__api_domain: str = api_domain
         self.verbose: bool = False
-        self.__cognito: CognitoAuthentication | None = None
-
-    @property
-    def cognito(self) -> CognitoAuthentication:
-        """Gets the cognito authentication object"""
-
-        if not self.__api_domain:
-            raise RuntimeError(
-                "Missing Aplos Api Domain. Set the internal property of __api_domain first."
-                "This is required to make an authentication connection"
-            )
-
-        if self.__cognito is None:
-            self.__cognito = CognitoAuthentication(
-                client_id=None, region=None, aplos_domain=self.__api_domain
-            )
-
-        return self.__cognito
-
-    @property
-    def api_root(self) -> str:
-        """Gets the base url"""
-        if self.__api_domain is None:
-            raise RuntimeError("Missing Aplos Api Domain")
-
-        url = HttpUtilities.build_url(
-            self.__api_domain, self.cognito.tenant_id, self.cognito.user_id
-        )
-
-        return url
 
     def execute(
         self,
@@ -100,17 +66,13 @@ class NCAAnalysis:
             Dict[str, Any]: The execution response.  If you wait for the completion
         """
 
-        self.log(f"\tLogging into {self.__api_domain}.")
+        self.log(f"\tLogging into {self.host}.")
 
-        if not username:
-            raise ValueError("Missing username.  Please provide a valid username.")
-        if not password:
-            raise ValueError("Missing password.  Please provide a valid password.")
-
-        self.__jwt = self.cognito.login(username=username, password=password)
+        self.authenticator.authenticate(username=username, password=password)
 
         self.log("\tUploading the analysis file.")
-        uploader: S3PresignedUpload = S3PresignedUpload(self.__jwt, str(self.api_root))
+        uploader: S3PresignedUrlUpload = S3PresignedUrlUpload(str(self.host))
+        uploader.authenticator = self.authenticator
         upload_response: Dict[str, Any] = uploader.upload_file(input_file_path)
 
         file_id: str = upload_response.get("file_id", "")
@@ -188,7 +150,7 @@ class NCAAnalysis:
             raise ValueError(
                 "Missing config_data.  Please provide a valid config_data."
             )
-        headers = HttpUtilities.get_headers(self.__jwt)
+        headers = HttpUtilities.get_headers(self.authenticator.cognito.jwt)
         # to start a new execution we need the location of the file (s3 bucket and object key)
         # you basic configuration
         # optional meta data
@@ -198,9 +160,12 @@ class NCAAnalysis:
             "configuration": config_data,
             "meta_data": meta_data,
         }
-        url = f"{str(self.api_root)}/{Routes.NCA_EXECUTIONS}"
+
         response: requests.Response = requests.post(
-            url, headers=headers, data=json.dumps(submission), timeout=30
+            self.endpoints.executions,
+            headers=headers,
+            data=json.dumps(submission),
+            timeout=30,
         )
         json_response: dict = response.json()
 
@@ -234,9 +199,9 @@ class NCAAnalysis:
             str | None: on success: a url for download, on failure: None
         """
 
-        url = f"{self.api_root}/{Routes.NCA_EXECUTIONS}/{execution_id}"
+        url = f"{self.endpoints.execution(execution_id)}"
 
-        headers = HttpUtilities.get_headers(self.__jwt)
+        headers = HttpUtilities.get_headers(self.authenticator.cognito.jwt)
         current_time = datetime.now()
         # Create a timedelta object representing 15 minutes
         time_delta = timedelta(seconds=max_wait_in_seconds)
@@ -337,112 +302,3 @@ class NCAAnalysis:
 
         if self.verbose:
             print(message)
-
-
-def main():
-    try:
-        print("Welcome to the NCA Engine Upload & Execution Demo")
-        args = CommandlineArgs()
-        files_path = os.path.join(Path(__file__).parent, "files")
-
-        args.analysis_file_default = os.path.join(files_path, "single_ev.csv")
-        args.config_file_default = os.path.join(
-            files_path, "configuration_single_ev.json"
-        )
-        args.metadata_file_default = os.path.join(files_path, "meta_data.json")
-        if not args.is_valid():
-            print("\n\n")
-            print("Missing some arguments.")
-            exit()
-
-        engine = NCAAnalysis(
-            api_domain=str(args.api_domain),
-        )
-
-        print("\tLoading analysis configurations")
-        print(f"\t\t{args.config_file}")
-        config_data: dict = read_json_file(str(args.config_file))
-
-        print("\tLoading analysis meta data")
-        print(f"\t\t{args.metadata_file}")
-        meta_data = optional_json_loads(read_text_file(str(args.metadata_file)))
-
-        engine.execute(
-            username=str(args.username),
-            password=str(args.password),
-            input_file_path=str(args.analysis_file),
-            config_data=config_data,
-            meta_data=meta_data,
-            output_directory=str(args.output_directory),
-        )
-        print("Thank you for using the NCA Engine Upload and Execution Demo")
-    except Exception as e:  # pylint: disable=w0718
-        print("An error occured ... exiting with an error")
-        print(str(e))
-
-
-def optional_json_loads(data: str | dict) -> str | dict:
-    """
-    Attempts to load the data as json, fails gracefull and retuns the data is if it fails
-    Args:
-        data (str): data as string
-
-    Returns:
-        str | dict: either the data as is or a converted dictionary/json object
-    """
-    if isinstance(data, dict):
-        return data
-
-    try:
-        data = json.loads(str(data))
-    finally:
-        pass
-    return data
-
-
-def read_json_file(file_path: str) -> dict:
-    """
-    Reads a file and returns the json
-    Args:
-        file_path (str): _description_
-
-    Raises:
-        FileNotFoundError: _description_
-
-    Returns:
-        dict: _description_
-    """
-    if not os.path.exists(file_path):
-        raise FileNotFoundError(f"File Not Found: {file_path}")
-
-    data = None
-    with open(file_path, mode="r", encoding="utf8") as file:
-        data = json.load(file)
-
-    return data
-
-
-def read_text_file(file_path: str) -> str:
-    """
-    Read files contents
-    Args:
-        file_path (str): path to the file
-
-    Raises:
-        FileNotFoundError: if the file is not found
-
-    Returns:
-        str: the files data
-    """
-    if not os.path.exists(file_path):
-        raise FileNotFoundError(f"File Not Found: {file_path}")
-
-    data = None
-    with open(file_path, mode="r", encoding="utf8") as file:
-        data = file.read()
-
-    return data
-
-
-if __name__ == "__main__":
-    main()

aplos_nca_saas_sdk/nca_resources/nca_app_configuration.py

@@ -1,5 +1,5 @@
 """
-Copyright 2024 Aplos Analytics
+Copyright 2024-2025 Aplos Analytics
 All Rights Reserved.   www.aplosanalytics.com   LICENSED MATERIALS
 Property of Aplos Analytics, Utah, USA
 """
@@ -30,8 +30,8 @@ class NCAAppConfiguration:
 
     """
 
-    def __init__(self, aplos_saas_domain: str):
-        self.endpoints: NCAEndpoints = NCAEndpoints(aplos_saas_domain=aplos_saas_domain)
+    def __init__(self, host: str):
+        self.__endpoints: NCAEndpoints = NCAEndpoints(host=host)
         self.__response: requests.Response | None = None
 
     def get(self) -> requests.Response:
@@ -40,7 +40,7 @@ class NCAAppConfiguration:
         if self.__response is not None:
             return self.__response
 
-        url = self.endpoints.app_configuration()
+        url = self.__endpoints.app_configuration
         self.__response = requests.get(url, timeout=30)
         if self.__response.status_code != 200:
             raise RuntimeError("App configuration url is not working.")