amps-python-client 5.3.4.2__zip → 5.3.4.4__zip

{amps-python-client-5.3.4.2 → amps-python-client-5.3.4.4}/src/cpp/include/amps/amps.h

@@ -41,6 +41,18 @@
 #include <stdio.h>
 #include "amps/amps_generated.h"
 
+#ifdef AMPS_CPP_COUNT_THREADS
+#ifdef __cplusplus
+extern "C" {
+#endif
+  size_t amps_get_thread_create_count(void);
+  size_t amps_get_thread_join_count(void);
+  size_t amps_get_thread_detach_count(void);
+#ifdef __cplusplus
+}
+#endif
+#endif
+
 //Avoid compiler warnings on win
 #ifdef INVALID_SOCKET
   #define AMPS_INVALID_SOCKET INVALID_SOCKET
@@ -746,6 +758,8 @@ amps_now(void);
  */
 AMPSDLL int amps_ssl_init(const char* dllPath_);
 
+AMPSDLL int amps_ssl_init_from_context(void* sslContext_, const char* fileName_);
+
 /**
  * Configures OpenSSL to validate the server's certificate when connecting.
  * This parameter must be set before attempting to connect to AMPS.

{amps-python-client-5.3.4.2 → amps-python-client-5.3.4.4}/src/cpp/include/amps/amps_impl.h

@@ -43,6 +43,7 @@
   #define _AMPS_TLS_KEY DWORD
   char* _amps_strndup(const char* ptr_, size_t len_);
   #define _AMPS_STRNDUP _amps_strndup
+  #define AMPS_CLOSESOCKET closesocket
 
 #else
   #include <pthread.h>
@@ -54,7 +55,7 @@
   #define _AMPS_SNPRINTF snprintf
   #define _AMPS_KEYCREATE pthread_key_create
   #define _AMPS_TLS_KEY pthread_key_t
-  #define closesocket close
+  #define AMPS_CLOSESOCKET close
   #define _AMPS_STRNDUP strndup
 
   #ifndef SO_DOMAIN
@@ -204,5 +205,17 @@ AMPSDLL void amps_atfork_init(void);
 AMPSDLL void amps_atfork_add(void*, _amps_atfork_callback_function);
 AMPSDLL void amps_atfork_remove(void*, _amps_atfork_callback_function);
 
+#ifdef AMPS_CPP_COUNT_THREADS
+#if __STDC_VERSION__ >= 201100
+  extern _Atomic size_t amps_thread_create_count;
+  extern _Atomic size_t amps_thread_join_count;
+  extern _Atomic size_t amps_thread_detach_count;
+#else
+  extern volatile size_t amps_thread_create_count;
+  extern volatile size_t amps_thread_join_count;
+  extern volatile size_t amps_thread_detach_count;
+#endif
+#endif
+
 
 #endif

{amps-python-client-5.3.4.2 → amps-python-client-5.3.4.4}/src/cpp/include/amps/ampscrc.hpp

@@ -48,9 +48,7 @@ namespace AMPS
       __cpuid(cpuinfo, 1);
       return (cpuinfo[2] & (1 << 20)) != 0;
 #else
-      unsigned int eax, ebx, ecx = 0, edx;
-      __get_cpuid(1, &eax, &ebx, &ecx, &edx);
-      return ecx & (1 << 20);
+      return true;
 #endif
 #else
       return false;
@@ -87,7 +85,7 @@ namespace AMPS
       }
 
       // process 64 bytes at a time
-      unsigned int middleLen = (len_ - beginLen) & ~0x3Fl;
+      unsigned int middleLen = (unsigned int)((len_ - beginLen) & ~0x3Fl);
 
       unsigned int i = 0;
 

{amps-python-client-5.3.4.2 → amps-python-client-5.3.4.4}/src/cpp/include/amps/ampsplusplus.hpp

@@ -241,8 +241,7 @@ namespace AMPS
     {\
       ;\
     }\
-  }
-  */
+  }*/
 #ifdef _WIN32
 #define AMPS_CALL_EXCEPTION_WRAPPER_2(me,x) \
   try\
@@ -427,7 +426,9 @@ namespace AMPS
     _exceptionListener->exceptionThrown(ex);\
   }\
   catch(...)\
-  {;}
+  {\
+    ;\
+  }
 
 #define AMPS_UNHANDLED_EXCEPTION_2(me,ex) \
   try\
@@ -435,7 +436,9 @@ namespace AMPS
     me->_exceptionListener->exceptionThrown(ex);\
   }\
   catch(...)\
-  {;}
+  {\
+    ;\
+  }
 
 
   class Client;
@@ -1511,7 +1514,7 @@ namespace AMPS
     /// subscriptions, and so on). The listener should not issue commands
     /// on the client while recovery is in progress.
     virtual void connectionStateChanged(State newState_) = 0;
-    virtual ~ConnectionStateListener()  {;};
+    virtual ~ConnectionStateListener()  {;}
   };
 
 
@@ -1724,11 +1727,12 @@ namespace AMPS
       unsigned connectionVersion;
       AckResponseImpl() :
         RefBody(),
+        username(), password(), reason(), status(), bookmark(), options(),
         sequenceNo((amps_uint64_t)0),
         serverVersion(),
         responded(false),
         abandoned(false),
-        connectionVersion(0)
+        connectionVersion(UINT_MAX) // Don't abandon if unsent AC-1329
       {
       }
     };
@@ -2020,7 +2024,7 @@ namespace AMPS
       }
       bool timedOut = false;
       AMPS_START_TIMER(timeout_)
-      while (!timedOut && !ack.responded() && !ack.abandoned() && _connected)
+      while (!timedOut && !ack.responded() && !ack.abandoned())
       {
         if (timeout_)
         {
@@ -2268,8 +2272,10 @@ namespace AMPS
         }
         _connected = false;
         _heartbeatTimer.setTimeout(0.0);
+        // AC-1189 AC-1329 AC-1337 We need acks cleared while lock is held,
+        // but not for unsent commands.
+        clearAcks(UINT_MAX-1);
       }
-      clearAcks(INT_MAX);
       amps_client_disconnect(_client);
       _routes.clear();
     }
@@ -2278,6 +2284,8 @@ namespace AMPS
     {
       AMPS_CALL_EXCEPTION_WRAPPER(flushAcks());
       setDisconnected();
+      // Abandon all acks, sent and unsent
+      clearAcks(UINT_MAX);
       AMPS_CALL_EXCEPTION_WRAPPER(processDeferredExecutions());
       Lock<Mutex> l(_lock);
       broadcastConnectionStateChanged(ConnectionStateListener::Shutdown);
@@ -4407,9 +4415,7 @@ namespace AMPS
       unsigned requestedAcks = message.getAckTypeEnum();
       bool isPublishStore = _publishStore.isValid() && command_.needsSequenceNumber();
       Message::Command::Type commandType = message.getCommandEnum();
-      if (commandType == Message::Command::SOWAndSubscribe
-          || commandType == Message::Command::SOWAndDeltaSubscribe
-          || commandType == Message::Command::StopTimer)
+      if (commandType == Message::Command::StopTimer)
       {
         systemAddedAcks |= Message::AckType::Completed;
       }
@@ -4458,9 +4464,9 @@ namespace AMPS
         _registerHandler(command_, cid, handler_,
                          requestedAcks, systemAddedAcks, commandType);
       }
-      bool useSyncSend = cid.len() > 0 && command_.hasProcessedAck();
       if (isPublishStore)
       {
+        bool useSyncSend = cid.len() > 0 && command_.hasProcessedAck();
         amps_uint64_t haSequenceNumber = (amps_uint64_t)0;
         message.setAckTypeEnum(requestedAcks | systemAddedAcks);
         {
@@ -4482,8 +4488,7 @@ namespace AMPS
         }
         catch (const DisconnectedException&)
         {
-          // -V565
-          // Pass - message will get replayed when reconnected
+          throw;
         }
         catch (...)
         {
@@ -4516,15 +4521,8 @@ namespace AMPS
           message.setAckTypeEnum(requestedAcks | systemAddedAcks);
           try
           {
-            if (useSyncSend)
-            {
-              syncAckProcessing((long)command_.getTimeout(), message,
-                                isHASubscribe_);
-            }
-            else
-            {
-              _send(message);
-            }
+            syncAckProcessing((long)command_.getTimeout(), message,
+                              isHASubscribe_);
           }
           catch (const DisconnectedException&)
           {
@@ -4570,6 +4568,9 @@ namespace AMPS
         }
         else
         {
+          // SOW, Flush, etc. should always be sync. Publish/delete may not be.
+          bool useSyncSend = commandType & ~Message::Command::NoDataCommands
+                             || (cid.len() > 0 && command_.hasProcessedAck());
           message.setAckTypeEnum(requestedAcks | systemAddedAcks);
           try
           {
@@ -7834,15 +7835,23 @@ namespace AMPS
     while (true)
     {
       AtomicFlagFlip subFlip(&me->_badTimeToHASubscribe);
+      bool retryInProgress = false;
       try
       {
         me->_connected = false;
-        {
-          // Have to release the lock here or receive thread can't
-          // invoke the message handler.
-          Unlock<Mutex> unlock(me->_lock);
-          me->_disconnectHandler.invoke(wrapper);
-        }
+        me->_lock.signalAll();
+        // Have to release the lock here or receive thread can't
+        // invoke the message handler.
+        Unlock<Mutex> unlock(me->_lock);
+        me->_disconnectHandler.invoke(wrapper);
+      }
+#ifdef _WIN32
+      catch (const RetryOperationException&)
+#else
+      catch (const RetryOperationException& ex)
+#endif
+      {
+        retryInProgress = true;
       }
       catch (const std::exception& ex)
       {
@@ -7852,8 +7861,15 @@ namespace AMPS
 
       if (!me->_connected)
       {
-        me->broadcastConnectionStateChanged(ConnectionStateListener::Shutdown);
-        AMPS_UNHANDLED_EXCEPTION_2(me, DisconnectedException("Reconnect failed."));
+        if (retryInProgress)
+        {
+          AMPS_UNHANDLED_EXCEPTION_2(me, RetryOperationException("Reconnect in progress."));
+        }
+        else
+        {
+          me->broadcastConnectionStateChanged(ConnectionStateListener::Shutdown);
+          AMPS_UNHANDLED_EXCEPTION_2(me, DisconnectedException("Reconnect failed."));
+        }
         return AMPS_E_DISCONNECTED;
       }
       try
@@ -8386,6 +8402,14 @@ namespace AMPS
         _state = Disconnected;
         close();
       }
+      else if (state_ == AMPS::ConnectionStateListener::Connected
+               && _commandId.empty()
+               && _subId.empty()
+               && _queryId.empty())
+      {
+        // AC-1331 Reconnect before command was sent, so Unset
+        _state = Unset;
+      }
       _lock.signalAll();
     }
 
@@ -8500,10 +8524,11 @@ namespace AMPS
         {
           _state = Closed;
         }
-        else if (current_.getCommandEnum() == Message::Command::Publish &&
-                 _client.isValid() && _client.getAutoAck() &&
-                 !current_.getLeasePeriod().empty() &&
-                 !current_.getBookmark().empty())
+        else if (current_.isValid()
+                 && current_.getCommandEnum() == Message::Command::Publish
+                 && _client.isValid() && _client.getAutoAck()
+                 && !current_.getLeasePeriod().empty()
+                 && !current_.getBookmark().empty())
         {
           _previousTopic = current_.getTopic().deepCopy();
           _previousBookmark = current_.getBookmark().deepCopy();

{amps-python-client-5.3.4.2 → amps-python-client-5.3.4.4}/src/cpp/include/amps/ampsver.h

@@ -32,10 +32,10 @@
 
 
 /// The current version of the AMPS client.
-#define AMPS_CLIENT_VERSION "5.3.4.2"
+#define AMPS_CLIENT_VERSION "5.3.4.4"
 
 /// The current version of the AMPS client with the language appended.
-#define AMPS_CLIENT_VERSION_WITH_LANGUAGE "5.3.4.2.3304e34.540236:python"
+#define AMPS_CLIENT_VERSION_WITH_LANGUAGE "5.3.4.4.1b5ff54.964735:python"
 
 #endif
 

{amps-python-client-5.3.4.2 → amps-python-client-5.3.4.4}/src/cpp/include/amps/util.hpp

@@ -153,6 +153,20 @@ namespace AMPS
     {
       LeaveCriticalSection(&_lock);
     }
+    bool tryAcquire(int retries_ = 100)
+    {
+      BOOL ret = FALSE;
+      while (!ret && --retries_ > 0)
+      {
+        ret = TryEnterCriticalSection(&_lock);
+        Sleep(1);
+      }
+#if defined(PY_MAJOR_VERSION) && PY_MAJOR_VERSION < 3
+      return ret == TRUE; // Avoids a warning with some Windows compilers
+#else
+      return (bool)ret;
+#endif
+    }
     void wait()
     {
       ++_waiters;
@@ -214,6 +228,18 @@ namespace AMPS
     {
       releaseRead();
     }
+    bool tryAcquire(int retries_ = 100)
+    {
+      static const struct timespec spin_ts = { 0, 100 * 1000 };
+      int ret = pthread_mutex_trylock(&_lock);
+      while (ret != 0 && --retries_ > 0)
+      {
+        nanosleep(&spin_ts, NULL);
+        ret = pthread_mutex_trylock(&_lock);
+      }
+      /* Windows-like return, 1 for TRUE (acquired) 0 for FALSE */
+      return (ret == 0);
+    }
     void wait()
     {
       pthread_cond_wait(&_condition, &_lock);
@@ -366,6 +392,35 @@ namespace AMPS
     }
   };
 
+///
+///
+/// Simple RAII-style class for automatic try locking/unlocking
+///
+  template <class T>
+  class TryLock
+  {
+    T& _lock;
+    bool _locked;
+    TryLock(const TryLock<T>& rhs); // not implemented
+    TryLock<T>& operator=(const TryLock<T>& rhs); // not implemented
+  public:
+    TryLock(T& lock) : _lock(lock)
+    {
+      _locked = _lock.tryAcquire();
+    }
+    ~TryLock()
+    {
+      if (_locked)
+      {
+        _lock.releaseRead();
+      }
+    }
+    bool isLocked() const
+    {
+      return _locked;
+    }
+  };
+
 ///
 /// Simple RAII-style class for automatic unlocking/relocking
 ///
@@ -587,7 +642,7 @@ namespace AMPS
       rhs._isRef = false;
     }
 
-    const BorrowRefHandle& operator=(BorrowRefHandle&& rhs)
+    BorrowRefHandle& operator=(BorrowRefHandle&& rhs)
     {
       if (this == &rhs)
       {
@@ -605,7 +660,7 @@ namespace AMPS
     }
 #endif // defined(__GXX_EXPERIMENTAL_CXX0X__) || _MSC_VER >= 1600
 
-    const BorrowRefHandle& operator=(const BorrowRefHandle& rhs)
+    BorrowRefHandle& operator=(const BorrowRefHandle& rhs)
     {
       if (this == &rhs)
       {
@@ -777,12 +832,15 @@ namespace AMPS
   public:
 #if __cplusplus >= 201100L || _MSC_VER >= 1900
     FlagFlip(std::atomic<bool>* pFlag_) : _pFlag(pFlag_)
+    {
+      *_pFlag = !*_pFlag;
+    }
 #else
     FlagFlip(volatile bool * pFlag_) : _pFlag(pFlag_)
-#endif
     {
       *_pFlag = !*_pFlag;
     }
+#endif
     ~FlagFlip()
     {
       *_pFlag = !*_pFlag;
@@ -853,7 +911,7 @@ namespace AMPS
       buffer[sizeof(buffer) - 1] = '\0';
       (std::runtime_error&)*this = std::runtime_error(buffer);
     }
-    virtual ~AMPSException() throw() {;}
+    virtual ~AMPSException() {;}
 
     ///
     /// Returns a null-terminated string containing self's
@@ -888,10 +946,19 @@ namespace AMPS
   {\
   public:\
     x(const std::string& message, amps_result result = AMPS_E_OK)\
-      : b(message, result) {;}\
+      : b(message, result)\
+    {\
+      ;\
+    }\
     x(amps_handle client, amps_result result)\
-      : b(client, result) {;}\
-    virtual const char* getClassName() const { return #x; }\
+      : b(client, result)\
+    {\
+      ;\
+    }\
+    virtual const char* getClassName() const\
+    {\
+      return #x;\
+    }\
   };
   AMPS_EX_TYPE(CommandException, AMPSException)
   AMPS_EX_TYPE(ConnectionException, AMPSException)
@@ -926,7 +993,7 @@ namespace AMPS
   AMPS_EX_TYPE(UnknownException, CommandException)
   AMPS_EX_TYPE(PublishStoreGapException, StoreException)
 
-  template <class T> // static
+  template <class T>
   void AMPSException::throwFor(const T& context_, amps_result result_)
   {
     switch (result_)
@@ -1600,7 +1667,7 @@ namespace AMPS
       return convertVersionToNumber(_versionString.data(), _versionString.length());
     }
 
-    const VersionInfo& operator=(const VersionInfo& info_)
+    VersionInfo& operator=(const VersionInfo& info_)
     {
       _versionString = info_._versionString;
       _versionNum = info_._versionNum;
@@ -1655,7 +1722,7 @@ namespace AMPS
       const int MAXDIGITS[] = { 4, 4, 5, 5 };
 
       amps_uint64_t versionNum = 0;
-      if (version_.length() == 0 || !isdigit(version_[0]))
+      if (version_.empty() || !isdigit(version_[0]))
       {
         // Start with non-numeric is a special build
         return AMPS_DEFAULT_SERVER_VERSION;

{amps-python-client-5.3.4.2 → amps-python-client-5.3.4.4}/src/cpp/src/amps_protocol.c

@@ -178,6 +178,7 @@ static const char comma        = ',';
 static const char colon        = ':';
 static const char open_brace   = '{';
 static const char close_brace  = '}';
+static const char backslash    = '\\';
 
 /* string data inside double quotes (anything but ")
  * return 0 for "
@@ -239,28 +240,70 @@ typedef struct
 
 } cstring;
 
-static size_t get_string(const char* p_, const char* pEnd_)
+static size_t get_string(char* p_, const char* pEnd_, size_t* pLen_)
 {
-  const char* p = p_;
+  *pLen_ = 0;
+  char* p = p_;
   while (p_ < pEnd_)
   {
-    /* lookup will return 0, 1 or 2 (2 is returned for escaped chars */
-    char rc = lookup_string_data[(unsigned char)p_[0]];
-    if (rc)
+    if (p_[0] == quote)
     {
-      p_ += (size_t)rc;
+      size_t len = (size_t)(p_ - p);
+      /* skip over '"' */
+      ++p_;
+      return len;
     }
-    else
+    else if (p_[0] == backslash)
     {
-      if (p_[0] == quote)
+      switch(p_[1])
       {
-        size_t len = (size_t)(p_ - p);
-        /* skip over '"' */
-        ++p_;
-        return len;
+      case 'b':
+        {
+          p[(*pLen_)++] = '\b';
+          p_ += 2;
+        }
+      break;
+      case 'f':
+        {
+          p[(*pLen_)++] = '\f';
+          p_ += 2;
+        }
+      break;
+      case 'n':
+        {
+          p[(*pLen_)++] = '\n';
+          p_ += 2;
+        }
+      break;
+      case 'r':
+        {
+          p[(*pLen_)++] = '\r';
+          p_ += 2;
+        }
+      break;
+      case 't':
+        {
+          p[(*pLen_)++] = '\t';
+          p_ += 2;
+        }
+      break;
+      case 'u':
+        {
+          // Leave it alone
+          p_ += 6;
+        }
+      break;
+      default:
+        {
+          p[(*pLen_)++] = p_[1];
+          p_ += 2;
+        }
       }
-      assert(0); // Indicates parse failure, i.e. server or network error
-      return 0;
+    }
+    else
+    {
+      p[(*pLen_)++] = p_[0];
+      ++p_;
     }
   }
   assert(0); // Indicates parse failure, i.e. server or network error
@@ -285,8 +328,9 @@ static size_t get_number(const char* p_, const char* pEnd_)
   return 0;
 }
 
-static const char* get_value(const char* p_, const char* pEnd_, cstring* pValue_)
+static char* get_value(char* p_, const char* pEnd_, cstring* pValue_)
 {
+  size_t len = 0;
   /* '[' == 0x5B, '{' == 0x7B */
   char c = p_[0];
   switch (c)
@@ -296,9 +340,9 @@ static const char* get_value(const char* p_, const char* pEnd_, cstring* pValue_
      * skip over '"' */
     ++p_;
     pValue_->_p = (const char*)p_;
-    pValue_->_len = get_string(p_, pEnd_);
+    len = get_string(p_, pEnd_, &pValue_->_len);
     /* skip over terminating '"' */
-    return p_ + pValue_->_len + 1;
+    return p_ + len + 1;
   case '0':
   case '1':
   case '2':
@@ -355,9 +399,9 @@ amps_result amps_protocol_deserialize(amps_handle message, size_t startingPositi
   static const char* PUBLISH = "publish";
   amps_message_t* me = (amps_message_t*)message;
   size_t length = me->length - startingPosition;
-  const char* pStart = me->rawBuffer + startingPosition;
+  char* pStart = (char*)me->rawBuffer + startingPosition;
   const char* pEnd = pStart + length;
-  const char* p = pStart;
+  char* p = pStart;
   const char* pTag = 0;
   char ch;
   cstring value = { 0, 0 };
@@ -441,7 +485,7 @@ scan_start:
       {
         p = get_value(p, pEnd, &value);
         amps_message_assign_field_value(me, (FieldId)fieldId, value._p, value._len);
-        //fprintf(stderr,"PARSE AMPS 3 %d len = %lu\n",fieldId,value._len);
+        //fprintf(stderr,"PARSE AMPS 3 %d len = %lu val %.*s\n",fieldId,value._len,(int)value._len,value._p);
       }
       if (p == 0)
       {