aline-ai 0.7.1__py3-none-any.whl → 0.7.3__py3-none-any.whl

realign/dashboard/widgets/agents_panel.py

@@ -6,6 +6,7 @@ import asyncio
 import json as _json
 import re
 import shlex
+import time
 from pathlib import Path
 from typing import Optional
 
@@ -171,6 +172,7 @@ class AgentsPanel(Container, can_focus=True):
         self._share_agent_id: Optional[str] = None
         self._sync_agent_id: Optional[str] = None
         self._refresh_timer = None
+        self._last_refresh_error_at: float | None = None
 
     def compose(self) -> ComposeResult:
         with Horizontal(classes="summary"):
@@ -180,7 +182,8 @@ class AgentsPanel(Container, can_focus=True):
 
     def on_show(self) -> None:
         if self._refresh_timer is None:
-            self._refresh_timer = self.set_interval(1.0, self._on_refresh_timer)
+            # Refresh frequently, but avoid hammering SQLite/tmux (can cause transient empty UI).
+            self._refresh_timer = self.set_interval(2.0, self._on_refresh_timer)
         else:
             try:
                 self._refresh_timer.resume()
@@ -212,100 +215,127 @@ class AgentsPanel(Container, can_focus=True):
 
     def _collect_agents(self) -> list[dict]:
         """Collect agent info with their terminals."""
-        agents = []
-        try:
-            from ...db import get_database
+        agents: list[dict] = []
 
-            db = get_database(read_only=True)
-            agent_infos = db.list_agent_info()
+        from ...db import get_database
+
+        # Dashboard should prefer correctness/stability over ultra-low lock timeouts.
+        db = get_database(read_only=True, connect_timeout_seconds=2.0)
+
+        # Critical: if this fails, let it surface as a worker ERROR so we can keep
+        # the last rendered UI instead of flashing an empty agent list.
+        agent_infos = db.list_agent_info()
+
+        # Best-effort: missing pieces should degrade gracefully (names still render).
+        try:
             active_terminals = db.list_agents(status="active", limit=1000)
+        except Exception as e:
+            logger.debug(f"Failed to list active terminals: {e}")
+            active_terminals = []
 
-            # Latest window links per terminal (V23)
+        try:
             latest_links = db.list_latest_window_links(limit=2000)
-            link_by_terminal = {l.terminal_id: l for l in latest_links if l.terminal_id}
+        except Exception:
+            latest_links = []
+        link_by_terminal = {
+            l.terminal_id: l for l in latest_links if getattr(l, "terminal_id", None)
+        }
 
-            # Get tmux windows to retrieve window id and fallback session_id
+        try:
             tmux_windows = tmux_manager.list_inner_windows()
-            terminal_to_window = {
-                w.terminal_id: w for w in tmux_windows if w.terminal_id
-            }
+        except Exception as e:
+            logger.debug(f"Failed to list tmux windows: {e}")
+            tmux_windows = []
+        terminal_to_window = {
+            w.terminal_id: w for w in tmux_windows if getattr(w, "terminal_id", None)
+        }
 
-            # Collect all session_ids for title lookup
-            session_ids: list[str] = []
-            for t in active_terminals:
-                link = link_by_terminal.get(t.id)
-                if link and link.session_id:
-                    session_ids.append(link.session_id)
-                    continue
+        # Collect all session_ids for title lookup
+        session_ids: list[str] = []
+        for t in active_terminals:
+            link = link_by_terminal.get(t.id)
+            if link and getattr(link, "session_id", None):
+                session_ids.append(link.session_id)
+                continue
+            window = terminal_to_window.get(t.id)
+            if window and getattr(window, "session_id", None):
+                session_ids.append(window.session_id)
+
+        titles = self._fetch_session_titles(session_ids)
+
+        # Map agent_info.id -> list of terminals
+        agent_to_terminals: dict[str, list[dict]] = {}
+        for t in active_terminals:
+            # Find which agent_info this terminal belongs to
+            agent_info_id = None
+
+            link = link_by_terminal.get(t.id)
+
+            # Method 1: Check source field for "agent:{agent_info_id}" format
+            source = t.source or ""
+            if source.startswith("agent:"):
+                agent_info_id = source[6:]
+
+            # Method 2: WindowLink agent_id
+            if not agent_info_id and link and getattr(link, "agent_id", None):
+                agent_info_id = link.agent_id
+
+            # Method 3: Fallback - check tmux window's session.agent_id
+            if not agent_info_id:
                 window = terminal_to_window.get(t.id)
-                if window and window.session_id:
-                    session_ids.append(window.session_id)
-
-            titles = self._fetch_session_titles(session_ids)
-
-            # Map agent_info.id -> list of terminals
-            agent_to_terminals: dict[str, list[dict]] = {}
-            for t in active_terminals:
-                # Find which agent_info this terminal belongs to
-                agent_info_id = None
-
-                link = link_by_terminal.get(t.id)
-
-                # Method 1: Check source field for "agent:{agent_info_id}" format
-                source = t.source or ""
-                if source.startswith("agent:"):
-                    agent_info_id = source[6:]
-
-                # Method 2: WindowLink agent_id
-                if not agent_info_id and link and link.agent_id:
-                    agent_info_id = link.agent_id
-
-                # Method 3: Fallback - check tmux window's session.agent_id
-                if not agent_info_id:
-                    window = terminal_to_window.get(t.id)
-                    if window and window.session_id:
+                if window and getattr(window, "session_id", None):
+                    try:
                         session = db.get_session_by_id(window.session_id)
-                        if session:
-                            agent_info_id = session.agent_id
+                    except Exception:
+                        session = None
+                    if session:
+                        agent_info_id = session.agent_id
 
-                if agent_info_id:
-                    if agent_info_id not in agent_to_terminals:
-                        agent_to_terminals[agent_info_id] = []
+            if agent_info_id:
+                agent_to_terminals.setdefault(agent_info_id, [])
 
-                    # Get session_id from windowlink (preferred) or tmux window
-                    window = terminal_to_window.get(t.id)
-                    session_id = (
-                        link.session_id if link and link.session_id else (window.session_id if window else None)
-                    )
-                    title = titles.get(session_id, "") if session_id else ""
-
-                    agent_to_terminals[agent_info_id].append(
-                        {
-                            "terminal_id": t.id,
-                            "session_id": session_id,
-                            "provider": link.provider if link and link.provider else (t.provider or ""),
-                            "session_type": t.session_type or "",
-                            "title": title,
-                            "cwd": t.cwd or "",
-                        }
+                # Get session_id from windowlink (preferred) or tmux window
+                window = terminal_to_window.get(t.id)
+                session_id = (
+                    link.session_id
+                    if link and getattr(link, "session_id", None)
+                    else (
+                        window.session_id
+                        if window and getattr(window, "session_id", None)
+                        else None
                     )
+                )
+                title = titles.get(session_id, "") if session_id else ""
 
-            for info in agent_infos:
-                terminals = agent_to_terminals.get(info.id, [])
-                agents.append(
+                agent_to_terminals[agent_info_id].append(
                     {
-                        "id": info.id,
-                        "name": info.name,
-                        "description": info.description or "",
-                        "terminals": terminals,
-                        "share_url": getattr(info, "share_url", None),
-                        "last_synced_at": getattr(info, "last_synced_at", None),
+                        "terminal_id": t.id,
+                        "session_id": session_id,
+                        "provider": (
+                            link.provider
+                            if link and getattr(link, "provider", None)
+                            else (t.provider or "")
+                        ),
+                        "session_type": t.session_type or "",
+                        "title": title,
+                        "cwd": t.cwd or "",
                     }
                 )
-        except Exception as e:
-            logger.debug(f"Failed to collect agents: {e}")
-        return agents
 
+        for info in agent_infos:
+            terminals = agent_to_terminals.get(info.id, [])
+            agents.append(
+                {
+                    "id": info.id,
+                    "name": info.name,
+                    "description": info.description or "",
+                    "terminals": terminals,
+                    "share_url": getattr(info, "share_url", None),
+                    "last_synced_at": getattr(info, "last_synced_at", None),
+                }
+            )
+
+        return agents
 
     @staticmethod
     def _fingerprint(agents: list[dict]) -> str:
@@ -319,9 +349,21 @@ class AgentsPanel(Container, can_focus=True):
         # Handle refresh worker
         if self._refresh_worker is not None and event.worker is self._refresh_worker:
             if event.state == WorkerState.ERROR:
-                self._agents = []
+                # Keep the last successfully-rendered list on refresh errors to avoid
+                # flashing an empty Agents tab during transient tmux/SQLite hiccups.
+                self._last_refresh_error_at = time.monotonic()
+                err = self._refresh_worker.error
+                if isinstance(err, BaseException):
+                    logger.warning(
+                        "Agents refresh failed",
+                        exc_info=(type(err), err, err.__traceback__),
+                    )
+                else:
+                    logger.warning(f"Agents refresh failed: {err}")
+                return
             elif event.state == WorkerState.SUCCESS:
                 self._agents = self._refresh_worker.result or []
+                self._last_refresh_error_at = None
             else:
                 return
             fp = self._fingerprint(self._agents)
@@ -329,7 +371,10 @@ class AgentsPanel(Container, can_focus=True):
                 return  # nothing changed – skip re-render to avoid flicker
             self._rendered_fingerprint = fp
             self.run_worker(
-                self._render_agents(), group="agents-render", exclusive=True
+                self._render_agents(),
+                group="agents-render",
+                exclusive=True,
+                exit_on_error=False,
             )
             return
 
@@ -345,108 +390,123 @@ class AgentsPanel(Container, can_focus=True):
         async with self._refresh_lock:
             try:
                 container = self.query_one("#agents-list", Vertical)
-            except Exception:
-                return
+                await container.remove_children()
 
-            await container.remove_children()
-
-            if not self._agents:
-                await container.mount(
-                    Static("No agents yet. Click 'Create Agent' to add one.")
-                )
-                return
+                if not self._agents:
+                    await container.mount(Static("No agents yet. Click 'Create Agent' to add one."))
+                    return
 
-            for agent in self._agents:
-                safe_id = self._safe_id(agent["id"])
+                for agent in self._agents:
+                    safe_id = self._safe_id(agent["id"])
 
-                # Agent row with name, create button, and delete button
-                row = Horizontal(classes="agent-row")
-                await container.mount(row)
+                    # Agent row with name, create button, and delete button
+                    row = Horizontal(classes="agent-row")
+                    await container.mount(row)
 
-                # Agent name button
-                name_label = Text(agent["name"], style="bold")
-                terminal_count = len(agent["terminals"])
-                if terminal_count > 0:
-                    name_label.append(f" ({terminal_count})", style="dim")
+                    # Agent name button
+                    name_label = Text(agent["name"], style="bold")
+                    terminal_count = len(agent["terminals"])
+                    if terminal_count > 0:
+                        name_label.append(f" ({terminal_count})", style="dim")
 
-                await row.mount(
-                    AgentNameButton(
+                    agent_btn = AgentNameButton(
                         name_label,
                         id=f"agent-{safe_id}",
                         name=agent["id"],
                         classes="agent-name",
                     )
-                )
+                    if agent.get("description"):
+                        agent_btn.tooltip = agent["description"]
+                    await row.mount(agent_btn)
 
-                # Share or Sync button (Sync if agent already has a share_url)
-                if agent.get("share_url"):
+                    # Share or Sync button (Sync if agent already has a share_url)
+                    if agent.get("share_url"):
+                        await row.mount(
+                            Button(
+                                "Sync",
+                                id=f"sync-{safe_id}",
+                                name=agent["id"],
+                                classes="agent-share",
+                            )
+                        )
+                        await row.mount(
+                            Button(
+                                "Link",
+                                id=f"link-{safe_id}",
+                                name=agent["id"],
+                                classes="agent-share",
+                            )
+                        )
+                    else:
+                        await row.mount(
+                            Button(
+                                "Share",
+                                id=f"share-{safe_id}",
+                                name=agent["id"],
+                                classes="agent-share",
+                            )
+                        )
+
+                    # Create terminal button
                     await row.mount(
                         Button(
-                            "Sync",
-                            id=f"sync-{safe_id}",
+                            "+ Term",
+                            id=f"create-term-{safe_id}",
                             name=agent["id"],
-                            classes="agent-share",
+                            classes="agent-create",
                         )
                     )
-                else:
+
+                    # Delete agent button
                     await row.mount(
                         Button(
-                            "Share",
-                            id=f"share-{safe_id}",
+                            "✕",
+                            id=f"delete-{safe_id}",
                             name=agent["id"],
-                            classes="agent-share",
+                            variant="error",
+                            classes="agent-delete",
                         )
                     )
 
-                # Create terminal button
-                await row.mount(
-                    Button(
-                        "+ Term",
-                        id=f"create-term-{safe_id}",
-                        name=agent["id"],
-                        classes="agent-create",
-                    )
-                )
-
-                # Delete agent button
-                await row.mount(
-                    Button(
-                        "✕",
-                        id=f"delete-{safe_id}",
-                        name=agent["id"],
-                        variant="error",
-                        classes="agent-delete",
-                    )
-                )
-
-                # Terminal list (indented under agent)
-                if agent["terminals"]:
-                    term_list = Vertical(classes="terminal-list")
-                    await container.mount(term_list)
-
-                    for term in agent["terminals"]:
-                        term_safe_id = self._safe_id(term["terminal_id"])
-                        term_row = Horizontal(classes="terminal-row")
-                        await term_list.mount(term_row)
-
-                        label = self._make_terminal_label(term)
-                        await term_row.mount(
-                            Button(
-                                label,
-                                id=f"switch-{term_safe_id}",
-                                name=term["terminal_id"],
-                                classes="terminal-switch",
+                    # Terminal list (indented under agent)
+                    if agent["terminals"]:
+                        term_list = Vertical(classes="terminal-list")
+                        await container.mount(term_list)
+
+                        for term in agent["terminals"]:
+                            term_safe_id = self._safe_id(term["terminal_id"])
+                            term_row = Horizontal(classes="terminal-row")
+                            await term_list.mount(term_row)
+
+                            label = self._make_terminal_label(term)
+                            await term_row.mount(
+                                Button(
+                                    label,
+                                    id=f"switch-{term_safe_id}",
+                                    name=term["terminal_id"],
+                                    classes="terminal-switch",
+                                )
                             )
-                        )
-                        await term_row.mount(
-                            Button(
-                                "✕",
-                                id=f"close-{term_safe_id}",
-                                name=term["terminal_id"],
-                                variant="error",
-                                classes="terminal-close",
+                            await term_row.mount(
+                                Button(
+                                    "✕",
+                                    id=f"close-{term_safe_id}",
+                                    name=term["terminal_id"],
+                                    variant="error",
+                                    classes="terminal-close",
+                                )
                             )
-                        )
+            except Exception:
+                logger.exception("Failed to render agents list")
+                try:
+                    container = self.query_one("#agents-list", Vertical)
+                    await container.remove_children()
+                    await container.mount(
+                        Static("Agents UI error (see ~/.aline/.logs/dashboard.log)")
+                    )
+                except Exception:
+                    pass
+                return
 
     def _make_terminal_label(self, term: dict) -> Text:
         """Generate label for a terminal."""
@@ -554,6 +614,11 @@ class AgentsPanel(Container, can_focus=True):
             await self._sync_agent(agent_id)
             return
 
+        if btn_id.startswith("link-"):
+            agent_id = event.button.name or ""
+            await self._copy_share_link(agent_id)
+            return
+
         if btn_id.startswith("switch-"):
             terminal_id = event.button.name or ""
             await self._switch_to_terminal(terminal_id)
@@ -599,9 +664,7 @@ class AgentsPanel(Container, can_focus=True):
         if result:
             if result.get("imported"):
                 n = result.get("sessions_imported", 0)
-                self.app.notify(
-                    f"Imported: {result.get('name')} ({n} sessions)", title="Agent"
-                )
+                self.app.notify(f"Imported: {result.get('name')} ({n} sessions)", title="Agent")
             else:
                 self.app.notify(f"Created: {result.get('name')}", title="Agent")
         self.refresh_data()
@@ -639,11 +702,10 @@ class AgentsPanel(Container, can_focus=True):
 
         # Create the terminal with agent association
         self.run_worker(
-            self._do_create_terminal(
-                agent_type, workspace, skip_permissions, no_track, agent_id
-            ),
+            self._do_create_terminal(agent_type, workspace, skip_permissions, no_track, agent_id),
             group="terminal-create",
             exclusive=True,
+            exit_on_error=False,
         )
 
     async def _do_create_terminal(
@@ -656,9 +718,7 @@ class AgentsPanel(Container, can_focus=True):
     ) -> None:
         """Actually create the terminal with agent association."""
         if agent_type == "claude":
-            await self._create_claude_terminal(
-                workspace, skip_permissions, no_track, agent_id
-            )
+            await self._create_claude_terminal(workspace, skip_permissions, no_track, agent_id)
         elif agent_type == "codex":
             await self._create_codex_terminal(workspace, no_track, agent_id)
         elif agent_type == "opencode":
@@ -734,13 +794,9 @@ class AgentsPanel(Container, can_focus=True):
             except Exception:
                 pass
         else:
-            self.app.notify(
-                "Failed to create terminal", title="Agent", severity="error"
-            )
+            self.app.notify("Failed to create terminal", title="Agent", severity="error")
 
-    async def _create_codex_terminal(
-        self, workspace: str, no_track: bool, agent_id: str
-    ) -> None:
+    async def _create_codex_terminal(self, workspace: str, no_track: bool, agent_id: str) -> None:
         """Create a Codex terminal associated with an agent."""
         try:
             from ...db import get_database
@@ -803,9 +859,7 @@ class AgentsPanel(Container, can_focus=True):
         except Exception:
             pass
 
-        command = self._command_in_directory(
-            tmux_manager.zsh_run_and_keep_open("codex"), workspace
-        )
+        command = self._command_in_directory(tmux_manager.zsh_run_and_keep_open("codex"), workspace)
 
         created = tmux_manager.create_inner_window(
             "codex",
@@ -817,9 +871,7 @@ class AgentsPanel(Container, can_focus=True):
         )
 
         if not created:
-            self.app.notify(
-                "Failed to create terminal", title="Agent", severity="error"
-            )
+            self.app.notify("Failed to create terminal", title="Agent", severity="error")
 
     async def _create_opencode_terminal(self, workspace: str, agent_id: str) -> None:
         """Create an Opencode terminal associated with an agent."""
@@ -878,9 +930,7 @@ class AgentsPanel(Container, can_focus=True):
             except Exception:
                 pass
         else:
-            self.app.notify(
-                "Failed to create terminal", title="Agent", severity="error"
-            )
+            self.app.notify("Failed to create terminal", title="Agent", severity="error")
 
     async def _create_zsh_terminal(self, workspace: str, agent_id: str) -> None:
         """Create a zsh terminal associated with an agent."""
@@ -937,9 +987,7 @@ class AgentsPanel(Container, can_focus=True):
             except Exception:
                 pass
         else:
-            self.app.notify(
-                "Failed to create terminal", title="Agent", severity="error"
-            )
+            self.app.notify("Failed to create terminal", title="Agent", severity="error")
 
     def _install_claude_hooks(self, workspace: str) -> None:
         """Install Claude hooks for a workspace."""
@@ -966,12 +1014,8 @@ class AgentsPanel(Container, can_focus=True):
 
             project_root = Path(workspace)
             install_stop_hook(get_stop_settings_path(project_root), quiet=True)
-            install_user_prompt_submit_hook(
-                get_submit_settings_path(project_root), quiet=True
-            )
-            install_permission_request_hook(
-                get_permission_settings_path(project_root), quiet=True
-            )
+            install_user_prompt_submit_hook(get_submit_settings_path(project_root), quiet=True)
+            install_permission_request_hook(get_permission_settings_path(project_root), quiet=True)
         except Exception:
             pass
 
@@ -1050,14 +1094,10 @@ class AgentsPanel(Container, can_focus=True):
             db = get_database(read_only=True)
             sessions = db.get_sessions_by_agent_id(agent_id)
             if not sessions:
-                self.app.notify(
-                    "Agent has no sessions to share", title="Share", severity="warning"
-                )
+                self.app.notify("Agent has no sessions to share", title="Share", severity="warning")
                 return
         except Exception as e:
-            self.app.notify(
-                f"Failed to check sessions: {e}", title="Share", severity="error"
-            )
+            self.app.notify(f"Failed to check sessions: {e}", title="Share", severity="error")
             return
 
         # Store agent_id for the worker callback
@@ -1114,9 +1154,7 @@ class AgentsPanel(Container, can_focus=True):
                         try:
                             match = re.search(r"\{.*\}", output, re.DOTALL)
                             if match:
-                                result["json"] = json_module.loads(
-                                    match.group(0), strict=False
-                                )
+                                result["json"] = json_module.loads(match.group(0), strict=False)
                         except Exception:
                             result["json"] = None
 
@@ -1151,9 +1189,7 @@ class AgentsPanel(Container, can_focus=True):
         share_link = payload.get("share_link") or payload.get("share_url")
         if not share_link:
             share_link = result.get("share_link_guess")
-        slack_message = (
-            payload.get("slack_message") if isinstance(payload, dict) else None
-        )
+        slack_message = payload.get("slack_message") if isinstance(payload, dict) else None
         if not slack_message:
             try:
                 from ...db import get_database
@@ -1176,17 +1212,13 @@ class AgentsPanel(Container, can_focus=True):
             copied = copy_text(self.app, text_to_copy)
 
             suffix = " (copied)" if copied else ""
-            self.app.notify(
-                f"Share link: {share_link}{suffix}", title="Share", timeout=6
-            )
+            self.app.notify(f"Share link: {share_link}{suffix}", title="Share", timeout=6)
         elif exit_code == 0:
             self.app.notify("Share completed", title="Share", timeout=3)
         else:
             extra = result.get("stderr") or ""
             suffix = f": {extra}" if extra else ""
-            self.app.notify(
-                f"Share failed (exit {exit_code}){suffix}", title="Share", timeout=6
-            )
+            self.app.notify(f"Share failed (exit {exit_code}){suffix}", title="Share", timeout=6)
 
     async def _sync_agent(self, agent_id: str) -> None:
         """Sync all sessions for an agent with remote share."""
@@ -1260,3 +1292,26 @@ class AgentsPanel(Container, can_focus=True):
         else:
             error = result.get("error", "Unknown error")
             self.app.notify(f"Sync failed: {error}", title="Sync", severity="error")
+
+    async def _copy_share_link(self, agent_id: str) -> None:
+        """Copy the share link for an agent to clipboard."""
+        if not agent_id:
+            return
+
+        agent = next((a for a in self._agents if a["id"] == agent_id), None)
+        if not agent:
+            self.app.notify("Agent not found", title="Link", severity="error")
+            return
+
+        share_url = agent.get("share_url")
+        if not share_url:
+            self.app.notify("No share link available", title="Link", severity="warning")
+            return
+
+        copied = copy_text(self.app, share_url)
+        if copied:
+            self.app.notify("Share link copied to clipboard", title="Link", timeout=3)
+        else:
+            self.app.notify(
+                f"Failed to copy. Link: {share_url}", title="Link", severity="warning"
+            )