algokit-utils 4.0.2b1__py3-none-any.whl → 4.1.0__py3-none-any.whl

algokit_utils/applications/app_client.py

@@ -95,6 +95,9 @@ __all__ = [
 # TEAL opcodes for constant blocks
 BYTE_CBLOCK = 38  # bytecblock opcode
 INT_CBLOCK = 32  # intcblock opcode
+MAX_SIMULATE_OPCODE_BUDGET = (
+    20_000 * 16
+)  # https://github.com/algorand/go-algorand/blob/807b29a91c371d225e12b9287c5d56e9b33c4e4c/ledger/simulation/trace.go#L104
 
 T = TypeVar("T")  # For generic return type in _handle_call_errors
 
@@ -449,21 +452,16 @@ class _StateAccessor:
                 if not box.name_raw.startswith(prefix):
                     continue
 
-                encoded_key = prefix + box.name_raw
-                base64_key = base64.b64encode(encoded_key).decode("utf-8")
-
                 try:
                     key = get_abi_decoded_value(box.name_raw[len(prefix) :], metadata.key_type, self._app_spec.structs)
                     value = get_abi_decoded_value(
-                        self._algorand.app.get_box_value(self._app_id, base64.b64decode(base64_key)),
+                        self._algorand.app.get_box_value(self._app_id, box.name_raw),
                         metadata.value_type,
                         self._app_spec.structs,
                     )
                     result[str(key)] = value
                 except Exception as e:
-                    if "Failed to decode key" in str(e):
-                        raise ValueError(f"Failed to decode key {base64_key}") from e
-                    raise ValueError(f"Failed to decode value for key {base64_key}") from e
+                    raise ValueError(f"Failed to decode value for key {box.name_raw.decode('utf-8')}") from e
 
             return result
 
@@ -1183,7 +1181,6 @@ class _TransactionSender:
         :param params: Parameters for the application call including method and transaction options
         :param send_params: Send parameters
         :return: The result of sending or simulating the transaction, including ABI return value if applicable
-        :raises ValueError: If the transaction is read-only and `max_fee` is not provided
         """
         is_read_only_call = (
             params.on_complete == algosdk.transaction.OnComplete.NoOpOC or params.on_complete is None
@@ -1194,14 +1191,10 @@ class _TransactionSender:
             readonly_send_params = send_params or SendParams()
 
             # Read-only calls do not require fees to be paid, as they are only simulated on the network.
-            # Therefore there is no value in calculating the minimum fee needed for a successful app call with inners.
-            # As a a result we only need to send a single simulate call,
-            # however to do this successfully we need to ensure fees for the transaction are fully covered using maxFee.
-            if readonly_send_params.get("cover_app_call_inner_transaction_fees"):
-                if params.max_fee is None:
-                    raise ValueError(
-                        "Please provide a `max_fee` for the transaction when `cover_app_call_inner_transaction_fees` is enabled."  # noqa: E501
-                    )
+            # With maximum opcode budget provided, ensure_budget won't create inner transactions,
+            # so fee coverage is no longer a concern for read-only calls.
+            # If max_fee is provided, use it as static_fee for potential benefits.
+            if readonly_send_params.get("cover_app_call_inner_transaction_fees") and params.max_fee is not None:
                 readonly_params = replace(readonly_params, static_fee=params.max_fee, extra_fee=None)
 
             method_call_to_simulate = self._algorand.new_group().add_app_call_method_call(
@@ -1215,11 +1208,13 @@ class _TransactionSender:
                         skip_signatures=True,
                         allow_more_logs=True,
                         allow_empty_signatures=True,
-                        extra_opcode_budget=None,
+                        extra_opcode_budget=MAX_SIMULATE_OPCODE_BUDGET,
                         exec_trace_config=None,
                         simulation_round=None,
                     )
                 except Exception as e:
+                    # For read-only calls with max opcode budget, fee issues should be rare
+                    # but we can still provide helpful error message if they occur
                     if readonly_send_params.get("cover_app_call_inner_transaction_fees") and "fee too small" in str(e):
                         raise ValueError(
                             "Fees were too small. You may need to increase the transaction `maxFee`."

algokit_utils/applications/app_deployer.py

@@ -447,7 +447,8 @@ class AppDeployer:
         composer = self._transaction_sender.new_group()
 
         # Add create transaction
-        if isinstance(deployment.create_params, AppCreateMethodCallParams):
+        has_abi_create = isinstance(deployment.create_params, AppCreateMethodCallParams)
+        if has_abi_create:
             composer.add_app_create_method_call(
                 AppCreateMethodCallParams(
                     **{
@@ -467,10 +468,10 @@ class AppDeployer:
                     }
                 )
             )
-        create_txn_index = composer.count() - 1
 
         # Add delete transaction
-        if isinstance(deployment.delete_params, AppDeleteMethodCallParams):
+        has_abi_delete = isinstance(deployment.delete_params, AppDeleteMethodCallParams)
+        if has_abi_delete:
             delete_call_params = AppDeleteMethodCallParams(
                 **{
                     **deployment.delete_params.__dict__,
@@ -486,12 +487,15 @@ class AppDeployer:
                 }
             )
             composer.add_app_delete(delete_params)
-        delete_txn_index = composer.count() - 1
 
-        result = composer.send()
+        result = composer.send(deployment.send_params)
 
-        create_result = SendAppCreateTransactionResult[ABIReturn].from_composer_result(result, create_txn_index)
-        delete_result = SendAppTransactionResult[ABIReturn].from_composer_result(result, delete_txn_index)
+        create_result = SendAppCreateTransactionResult[ABIReturn].from_composer_result(
+            result, is_abi=has_abi_create, index=0
+        )
+        delete_result = SendAppTransactionResult[ABIReturn].from_composer_result(
+            result, is_abi=has_abi_delete, index=-1
+        )
 
         app_id = int(result.confirmations[0]["application-index"])  # type: ignore[call-overload]
         app_metadata = ApplicationMetaData(

algokit_utils/transactions/transaction_sender.py

@@ -81,7 +81,9 @@ class SendSingleTransactionResult:
     """The ABI return value if applicable"""
 
     @classmethod
-    def from_composer_result(cls, result: SendAtomicTransactionComposerResults, index: int = -1) -> Self:
+    def from_composer_result(
+        cls, result: SendAtomicTransactionComposerResults, *, is_abi: bool = False, index: int = -1
+    ) -> Self:
         # Get base parameters
         base_params = {
             "transaction": result.transactions[index],
@@ -104,12 +106,12 @@ class SendSingleTransactionResult:
                 {
                     "app_id": app_id,
                     "app_address": algosdk.logic.get_application_address(app_id),
-                    "abi_return": result.returns[index] if result.returns else None,  # type: ignore[dict-item]
+                    "abi_return": result.returns[index] if result.returns and is_abi else None,  # type: ignore[dict-item]
                 }
             )
         # For regular app transactions, just add abi_return
         elif cls is SendAppTransactionResult:
-            base_params["abi_return"] = result.returns[index] if result.returns else None  # type: ignore[assignment]
+            base_params["abi_return"] = result.returns[index] if result.returns and is_abi else None  # type: ignore[assignment]
 
         return cls(**base_params)  # type: ignore[arg-type]
 

{algokit_utils-4.0.2b1.dist-info → algokit_utils-4.1.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: algokit-utils
-Version: 4.0.2b1
+Version: 4.1.0
 Summary: Utilities for Algorand development for use by AlgoKit
 License: MIT
 Author: Algorand Foundation

{algokit_utils-4.0.2b1.dist-info → algokit_utils-4.1.0.dist-info}/RECORD

@@ -21,8 +21,8 @@ algokit_utils/application_client.py,sha256=5UIxXIBjukjRyjZPCeXmaNlAftbb3TziV7EfB
 algokit_utils/application_specification.py,sha256=wV0H088IudMqlxsW-gsZIfJyKA4e-zVwxJ-cR__ouBA,1379
 algokit_utils/applications/__init__.py,sha256=NGjhpBeExsQZOAYCT2QUFag1xuKoFiX-Ux5SR2GNzd8,452
 algokit_utils/applications/abi.py,sha256=OjTdn4szJPPeC8XmosdDYtkIIVgQSWAnqz2DHw5OH9g,10117
-algokit_utils/applications/app_client.py,sha256=WKedIu3CDamBW8dAAR5IBYCXkesvETkof1dwIqKHaNE,88474
-algokit_utils/applications/app_deployer.py,sha256=-6pCs61PdFMMrnDIpXOuaIlr6TgDkvsB6vwbOZhOiZ0,30606
+algokit_utils/applications/app_client.py,sha256=891BMnUOIOenEWgeelSIMgi0Wj4kggluWiKAu6-GYrE,88208
+algokit_utils/applications/app_deployer.py,sha256=xJCu7SU66OTg5misSbSF0QI8abRB-DWAwAVKd1kNcPI,30685
 algokit_utils/applications/app_factory.py,sha256=jVAzoK1J9S-BTGHA5BLxT-cl0pWhPdf222W4fYpFihE,45352
 algokit_utils/applications/app_manager.py,sha256=8bboIswlwBQhPIqilSBMaxd83yHjIpkloezmtgcAdZY,22301
 algokit_utils/applications/app_spec/__init__.py,sha256=HtjAhAqHNFml9WbRKGmhJnwyJeW8AztPRO_BriQ84vs,140
@@ -63,8 +63,8 @@ algokit_utils/py.typed,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 algokit_utils/transactions/__init__.py,sha256=7fYF3m6DyOGzbV36MT5svo0wSkj9AIz496kWgIWSAlk,225
 algokit_utils/transactions/transaction_composer.py,sha256=eK-6l2W1CkbKID1ezi-zCs_TxA2i5ZTm3YTl8sT2Zfw,103995
 algokit_utils/transactions/transaction_creator.py,sha256=cuP6Xm-fhGoCc2FNSbLiEg3iQRwW38rfdTzsqPyEcpM,29053
-algokit_utils/transactions/transaction_sender.py,sha256=4u2FON3YM4_DKPde6gSkZFAH1wp7FC8E65HpQ803RNo,50056
-algokit_utils-4.0.2b1.dist-info/LICENSE,sha256=J5i7U1Q9Q2c7saUzlvFRmrCCFhQyXb5Juz_LO5omNUw,1076
-algokit_utils-4.0.2b1.dist-info/METADATA,sha256=_voF9wDpeJ2vIPFXZixsmX6V8F2bFDthSwR4NLOKQ-o,2421
-algokit_utils-4.0.2b1.dist-info/WHEEL,sha256=b4K_helf-jlQoXBBETfwnf4B04YC67LOev0jo4fX5m8,88
-algokit_utils-4.0.2b1.dist-info/RECORD,,
+algokit_utils/transactions/transaction_sender.py,sha256=Wi3ws9S-Df1JeTlaSTXmq-WS24Gsq7WGsKk1B0z23ao,50117
+algokit_utils-4.1.0.dist-info/LICENSE,sha256=J5i7U1Q9Q2c7saUzlvFRmrCCFhQyXb5Juz_LO5omNUw,1076
+algokit_utils-4.1.0.dist-info/METADATA,sha256=9Et8L9-7fqp3dk3J_N8X6_6AWHm4EZf7qy7IIyuYEA4,2419
+algokit_utils-4.1.0.dist-info/WHEEL,sha256=b4K_helf-jlQoXBBETfwnf4B04YC67LOev0jo4fX5m8,88
+algokit_utils-4.1.0.dist-info/RECORD,,