agent-audit 0.1.0__py3-none-any.whl → 0.2.0__py3-none-any.whl

agent_audit/rules/engine.py

@@ -32,6 +32,50 @@ class RuleEngine:
     Loads rules from YAML files and applies them to scan results.
     """
 
+    # Pattern type to Rule ID mapping for OWASP Agentic Top 10
+    PATTERN_TYPE_TO_RULE_MAP: Dict[str, str] = {
+        # ASI-01: Goal Hijack
+        'prompt_injection_fstring': 'AGENT-010',
+        'prompt_injection_fstring_kwarg': 'AGENT-010',
+        'prompt_injection_format': 'AGENT-010',
+        'system_prompt_fstring': 'AGENT-010',
+        'system_prompt_concat': 'AGENT-010',
+        'system_prompt_format': 'AGENT-010',
+        'agent_without_input_guard': 'AGENT-011',
+
+        # ASI-03: Identity & Privilege Abuse
+        'hardcoded_credential_in_agent': 'AGENT-013',
+        'excessive_tools': 'AGENT-014',
+        'auto_approval': 'AGENT-014',
+
+        # ASI-04: Supply Chain
+        'npx_unfixed_version': 'AGENT-015',
+        'unofficial_mcp_source': 'AGENT-015',
+        'unvalidated_rag_ingestion': 'AGENT-016',
+
+        # ASI-05: RCE
+        'unsandboxed_code_exec_in_tool': 'AGENT-017',
+
+        # ASI-06: Memory Poisoning
+        'unsanitized_memory_write': 'AGENT-018',
+        'unbounded_memory': 'AGENT-019',
+
+        # ASI-07: Insecure Communication
+        'multi_agent_no_auth': 'AGENT-020',
+        'agent_comm_no_tls': 'AGENT-020',
+
+        # ASI-08: Cascading Failures
+        'missing_circuit_breaker': 'AGENT-021',
+        'tool_without_error_handling': 'AGENT-022',
+
+        # ASI-09: Trust Exploitation
+        'opaque_agent_output': 'AGENT-023',
+
+        # ASI-10: Rogue Agents
+        'no_kill_switch': 'AGENT-024',
+        'no_observability': 'AGENT-025',
+    }
+
     # Pre-compiled regex patterns for common detections
     CREDENTIAL_PATTERNS = [
         (re.compile(r'AKIA[0-9A-Z]{16}'), "AWS Access Key"),
@@ -104,6 +148,7 @@ class RuleEngine:
         for pattern in patterns:
             pattern_type = pattern.get('type', '')
 
+            # Check original patterns (AGENT-001)
             if pattern_type == 'shell_true' or pattern_type == 'dangerous_function_call':
                 # Check if this matches AGENT-001 (Command Injection)
                 if self._is_command_injection(pattern):
@@ -115,6 +160,17 @@ class RuleEngine:
                     if finding:
                         findings.append(finding)
 
+            # Check OWASP Agentic patterns
+            if pattern_type in self.PATTERN_TYPE_TO_RULE_MAP:
+                rule_id = self.PATTERN_TYPE_TO_RULE_MAP[pattern_type]
+                finding = self._create_finding_from_pattern(
+                    rule_id=rule_id,
+                    pattern=pattern,
+                    file_path=file_path
+                )
+                if finding:
+                    findings.append(finding)
+
         return findings
 
     def evaluate_credentials(
@@ -465,6 +521,9 @@ class RuleEngine:
                 if remediation_data.get('references') else None
             )
 
+        # Support both owasp_id and owasp_agentic_id
+        owasp_id = rule.get('owasp_agentic_id') or rule.get('owasp_id')
+
         return Finding(
             rule_id=rule['id'],
             title=rule['title'],
@@ -478,7 +537,7 @@ class RuleEngine:
                 snippet=match.get('snippet', '')
             ),
             cwe_id=rule.get('cwe_id'),
-            owasp_id=rule.get('owasp_id'),
+            owasp_id=owasp_id,
             remediation=remediation,
             confidence=match.get('confidence', 1.0)
         )

agent_audit/scanners/base.py

@@ -3,7 +3,9 @@
 from abc import ABC, abstractmethod
 from dataclasses import dataclass, field
 from pathlib import Path
-from typing import List, Any, Dict
+from typing import Any, Dict, Sequence, TypeVar
+
+T = TypeVar("T", bound="ScanResult", covariant=True)
 
 
 @dataclass
@@ -19,7 +21,7 @@ class BaseScanner(ABC):
     name: str = "BaseScanner"
 
     @abstractmethod
-    def scan(self, path: Path) -> List[ScanResult]:
+    def scan(self, path: Path) -> Sequence[ScanResult]:
         """
         Scan the given path and return results.
 
@@ -27,6 +29,6 @@ class BaseScanner(ABC):
             path: Path to scan (file or directory)
 
         Returns:
-            List of scan results
+            Sequence of scan results
         """
         pass

agent_audit/scanners/config_scanner.py

@@ -45,7 +45,7 @@ class ConfigScanner(BaseScanner):
     name = "Config Scanner"
 
     # Configuration patterns to check
-    DANGEROUS_PATTERNS = {
+    DANGEROUS_PATTERNS: Dict[str, Dict[str, Any]] = {
         # Debug/development settings that shouldn't be in production
         'debug': {
             'dangerous_values': [True, 'true', 'True', '1', 'yes'],

agent_audit/scanners/mcp_config_scanner.py

@@ -299,10 +299,11 @@ class MCPConfigScanner(BaseScanner):
 
         Returns analysis of filesystem access configuration.
         """
-        result = {
+        accessible_paths: List[str] = []
+        result: Dict[str, Any] = {
             'has_root_access': False,
             'has_home_access': False,
-            'accessible_paths': [],
+            'accessible_paths': accessible_paths,
             'risk_level': 'low'
         }
 
@@ -316,6 +317,6 @@ class MCPConfigScanner(BaseScanner):
                     result['has_home_access'] = True
                     result['risk_level'] = 'high' if result['risk_level'] != 'critical' else 'critical'
                 elif arg.startswith('/'):
-                    result['accessible_paths'].append(arg)
+                    accessible_paths.append(arg)
 
         return result

agent_audit/scanners/mcp_inspector.py

@@ -261,9 +261,10 @@ class MCPInspector:
 
     def _analyze_input_schema(self, schema: Dict[str, Any]) -> Dict[str, Any]:
         """Analyze input schema for security properties."""
-        result = {
+        unconstrained_strings: List[str] = []
+        result: Dict[str, Any] = {
             "has_validation": False,
-            "unconstrained_strings": [],
+            "unconstrained_strings": unconstrained_strings,
             "has_enum": False,
             "has_pattern": False,
         }
@@ -283,7 +284,7 @@ class MCPInspector:
                 elif "maxLength" in param_def or "minLength" in param_def:
                     result["has_validation"] = True
                 else:
-                    result["unconstrained_strings"].append(param_name)
+                    unconstrained_strings.append(param_name)
 
             elif param_type in ("integer", "number"):
                 if "minimum" in param_def or "maximum" in param_def:
@@ -361,7 +362,7 @@ class MCPInspector:
 
     def _generate_findings(self, result: MCPInspectionResult) -> List[Dict[str, Any]]:
         """Generate security findings from inspection."""
-        findings = []
+        findings: List[Dict[str, Any]] = []
 
         # Check for high-risk tools
         for tool in result.tools: