zugzbot 1.0.20 → 1.0.22

package/.opencode/oh-my-design/skills/omd-lab-02-design-harness/runs/v4-self-test/iterations/i2-audit-S.md

@@ -1,232 +0,0 @@
-# i2-audit-S.md — Iteration 2 (persona S walk-through)
-
-**Date:** 2026-04-27
-**Persona:** S — Senior dev (10+yr), side-project tinkering on a 25-component prototype with husky/lint-staged. Reads patches line-by-line. Will not accept platitudes.
-**Method:** Walked the 7-step scenario against actual v4 source (master.md / harness/SKILL.md / code-introspect.ts / memory.ts / critic.md / post-edit-watch.cjs / session-end-foldin.cjs). No mocks, just close reading + flow simulation.
-
----
-
-## Step 1 — INTAKE on existing repo (25 components + husky)
-
-### What v4 does
-`omd-master.md` §1 INTAKE branch: "existing code → CONTEXT_DETECT brief, then SLOT_GATE." Reads `.omd/context.json`. Persona detected via heuristic in signal-classifier (i1 fixed it).
-
-### Verdict for S
-**Acceptable, with caveats.**
-
-- S has husky + lint-staged already → context-detect *should* notice and adjust tone (no need to lecture about quality bar). I see **no signal** in master.md or context.json schema that "existing tooling" is a slot — only `is_frontend` / token inventory. **MINOR:** persona-S should get an early acknowledgment ("husky 보이네요, 그쪽 톤 맞춰서 빠르게 갈게요") instead of generic onboarding. Currently the master will treat S the same as F if intake heuristic mis-classifies.
-- Persona detection at INTAKE time relies entirely on the *first user message word/char count*. S writes long opinionated messages → likely classified `S` correctly. But if S opens with "audit this" (3 words), classifier flips to `V`. **MAJOR design gap:** persona is sticky-on-first-message, not re-evaluated at turn 3 once more text accumulates. master.md §0 doesn't mention re-classification; classifier only runs per-turn for *response style mirroring*, not for budget cap re-pegging.
-
----
-
-## Step 2 — code-introspect on 25-component repo
-
-### What it actually finds
-Reading `code-introspect.ts` line-by-line:
-
-- `HEX_RE = /#[0-9a-f]{3,8}\b/gi` — collects every hex literal in any file scanned, frequency-weighted. CSS-var hexes weighted ×3. **OK.**
-- `PX_RE = /\b(\d+(?:\.\d+)?)px\b/g` — collects **every px value**, no filter. Then `topN(spacing, 10)`.
-- `RADIUS_KW = /\brounded(?:-(?:sm|md|...))?\b/gi` — Tailwind class scan only.
-
-### CRITICAL bug — "1px borders detected as spacing tokens"
-Confirmed. `harvestFromText` adds **every** `Npx` match to `acc.spacing` with no semantic filter. In a 25-component repo with `border` / `border-t` / `outline-1` / `ring-1` / shadow offsets, **`1px` will dominate the frequency table**. Scenario walk:
-
-- 25 components × ~5 borders each = ~125 hits of `1px` → dominates topN.
-- Real spacing tokens (`p-4` Tailwind = 16px, `gap-2` = 8px) are **Tailwind classes, not raw px**, so they won't even land in the `PX_RE` bucket. The regex only catches raw `Npx` strings (CSS files, inline styles, arbitrary values like `p-[12px]`).
-- Net result: `summarizeInventory` will tell the master `spacing scale: 1px/2px/4px/16px/...` — **the 1px and 2px are border widths, not spacing**.
-
-**Worse:** master then shows S "spacing scale starts at 1px" in its acknowledgment prose. S will close the laptop. This is exactly the "noise output" failure mode S anticipated.
-
-**Required fix:** distinguish *border-width-context* vs *spacing-context* via PostCSS AST walk on CSS, or AST scan on Tailwind classes (`p-N`, `gap-N`, `m-N`, `space-x-N`) for components — **not** raw `Npx` regex on tsx text. Cheap heuristic interim: ignore `1px` and `2px` when their occurrence cluster correlates with the words `border`/`outline`/`ring`/`divide` within ±15 chars.
-
-### CRITICAL bug — radius/spacing inconsistency detection: missing
-The interface `TokenInventory` has no `inconsistencies` field. `summarizeInventory` reports the *dominant* values but never flags "you have 6 different radius keywords (rounded-sm/md/lg/xl/2xl/full) — 6 is high; consider trimming to 3." **For S, this is the entire reason to run code-introspect.** A 10yr dev doesn't need to be told "you have these colors"; they need to be told **"you have 11 unique blues that don't form a scale."** Currently no such logic exists.
-
-**Required:**
-- Detect 8pt grid violation: spacing values not divisible by 4 or 8.
-- Detect color drift: cluster colors by ΔE; flag when count > 5 in same hue.
-- Flag radius scale length > 4.
-
-None of this is in `code-introspect.ts`. The file is purely a frequency census, not an *inconsistency report*.
-
-### MINOR
-- `harvestFromTailwindConfig` regex-extracts hexes from the config source text. If the config does `colors: { ...stoneShades }` referencing an imported palette, the hex extraction silently misses it. No warning emitted. S will notice the mismatch immediately.
-- `cssFiles` capped at 30, `componentFiles` at 60. With 25 components S is fine, but cap is silent if components > 60 — only a `warnings[]` entry that nothing surfaces to the user.
-
----
-
-## Step 3 — Master proposes plan (PROPOSE_PLAN → OMD-PLAN.md)
-
-### What I can read
-master.md §6 says: build `PlanInputs` → `node -e "..."` or write inline → emit OMD-PLAN.md. The schema is in `src/core/plan-emitter.ts` (not read here). master.md §0.persona promises "spec-grade output."
-
-### Verdict
-**Cannot fully verify without reading plan-emitter.ts**, but signals from master.md:
-
-- §12 "Output discipline" forbids marketing prose: "tight, direct sentences. ... no marketing fluff." Good.
-- §0 promises "cite a token for every visual claim; cite a reference URL for every persona claim." If plan-emitter actually enforces this, S is happy.
-- **Risk (MAJOR):** plan-emitter is not bound by the master's persona rules — it's a deterministic emitter. If the template has lines like "이 디자인은 사용자에게 따뜻한 경험을 제공합니다" baked in, S will see boilerplate. Need to read plan-emitter.ts to confirm; flagging as **unknown / probably suspect** based on the volume of Korean prose templates I see referenced elsewhere.
-- **Risk (MAJOR):** §11–13 (success metrics / personas / principles) — master rule 999 says "Never fabricate §11–13 facts. Use `[FILL IN]` placeholder." Good rule on paper. But OMD-PLAN.md is generated *before* DESIGN.md.patch — does plan-emitter respect [FILL IN] on these slots? Unclear from master.md alone.
-
----
-
-## Step 4 — Push back on §11–13 placeholder strategy
-
-### Scenario
-S says: "I don't want `[FILL IN]` in §13 personas — give me a draft I can edit, even if speculative. The placeholder makes the doc look unfinished and I'll forget."
-
-### What master should do
-master.md rule 999: "Never fabricate §11–13 facts. Use `[FILL IN]` placeholder."
-
-This is a **hard rule with no escape hatch**. master will refuse, citing the rule. **For persona S this is correct behavior** — S explicitly said "spec-grade, will read line by line" → fabricated personas would be noise. But:
-
-- master.md gives no scripted response for this pushback. Rule 8 (Escalation hierarchy) covers "user keeps correcting" but not "user explicitly asks to violate hard rule."
-- Likely outcome: master either (a) violates rule 999 to please S, (b) refuses with platitude ("죄송하지만 정확성을 위해..."). Neither is great.
-- **Required:** rule 999 should be paired with a *bounded fabrication* mode: "draft persona with `[SPECULATIVE]` tag, user must approve before §13 is final." This gives S a starting draft without polluting the doc with hard claims.
-
-**Verdict: MAJOR gap.** Hard rule without negotiation protocol.
-
----
-
-## Step 5 — critic spawn between iterations
-
-### Reading omd-critic.md
-- Tools: `Read, Write, Glob, Grep` only — **no Edit/Bash**. The constraint is intentional and correct. ✅
-- Output: `critique.md` with §1 root cause / §2 decision tree / §3 mandatory re-do scope / §4 omd remember / §5 fragility / §6 severity. ✅
-- "Diagnostic frame ... Trace back to a specific decision the master made. Do NOT stop at the surface." ✅
-- Examples list correct vs wrong root causes — concrete and grounded. ✅
-
-### Will it actually do root-cause?
-The structure forces it to. The §1 template literally has fields `Symptom phase` / `Root cause phase` / `Evidence (verbatim)`. Critic has to fill them or produce malformed markdown. **Strong scaffold.**
-
-### Concerns
-- **MINOR:** §2 decision-tree audit table has no minimum-row requirement. A lazy critic could write 1 row and call it done. Should require ≥3 rows (or N = number of phases that ran).
-- **MAJOR:** "Always quote evidence verbatim from artifacts. No paraphrase." — critic only has Read/Glob/Grep. If artifact is a binary (e.g., `eval/screenshots/*.png`), critic cannot quote it. The rule will silently break for visual regressions. Need an explicit fallback ("for image evidence, cite filename + reason for inferred issue").
-- **MINOR:** No anti-platitude clause. Master.md §12 forbids marketing fluff; critic.md should mirror with "no 'overall the design has potential' style hedging."
-- **CRITICAL risk:** "if you could patch surface symptoms, the master would never have to re-think its decisions" — this is great philosophy, but the iteration loop in master.md §8 says critic-spawn → "re-enter at lowest broken phase (cap 3 iterations total)." If critic identifies Phase 3 (IA) as root cause, master re-runs Phase 3 *and all downstream phases*. Three iterations × 6 downstream phases = 18 phase-re-runs in worst case. No de-dup or memoization mentioned. S will run out of patience and budget at iteration 2.
-
----
-
-## Step 6 — Week-long use, preferences accumulate, session-end-foldin
-
-### Reading session-end-foldin.cjs
-Algorithm (verbatim from hook):
-
-```
-score = entries.length × importanceAvg × recency × 10
-recency = exp(-daysSince/7)
-threshold default = 60
-recurrence = entries.length >= 3
-window = 7 days
-```
-
-### CRITICAL bug — score formula is wrong
-Walk the math:
-
-- 3 entries, importance=3 (default), all today → score = 3 × 3 × 1.0 × 10 = **90 → fires**.
-- 3 entries, importance=3, 4 days ago → recency = exp(-0.57) ≈ 0.566 → score = 3 × 3 × 0.566 × 10 = **51 → does NOT fire**.
-- 5 entries, importance=2, today → 5 × 2 × 1 × 10 = **100 → fires**.
-- 10 entries, importance=1 (opinions), today → 10 × 1 × 1 × 10 = **100 → fires**.
-
-**Problem 1:** importance=1 ("opinion") accumulating freely promotes to a §-level rule. S casually saying "I prefer rounded over square" 10 times in a week → fold-in proposal as if it were a hard principle. **This is the "false promotion" failure mode S explicitly flagged.**
-
-**Problem 2:** the `entries.length` is *raw count*, no de-duplication of near-identical notes. If S says "shadows feel heavy" 5 times across 5 sessions on the same component, fold-in counts 5 — but it's one signal repeated. Algorithm should be `unique_clusters * importanceAvg * recency` where clusters are computed via note-similarity (even cheap n-gram). Currently `synthesizeRule` just joins last 3 notes verbatim — which means promoted rule is "- shadows feel heavy / - shadows feel heavy / - shadows feel heavy". Useless.
-
-**Problem 3:** the `byScope` grouping uses *exact scope string*. If S logs preferences with scope `components.button` once and `component.button` once and `voice.button` once, no group reaches 3. Conversely a single bug in agent code that always writes scope `unknown` will cluster everything into one super-group.
-
-**Problem 4:** windowMs filter discards anything older than 7 days, but `entries.length >= 3` *recurrence* threshold is only checked **inside the window**. So a slow-burn signal (1/week × 6 weeks) will never fold in. S working on a side project = exactly this profile.
-
-### Will it fire even once for S in a week?
-- Day 1-2: S logs 2-3 prefs, mostly importance=2-3 → window has 2-3 → no fold-in.
-- Day 3-4: 1-2 more → window now 4-5 entries, but spread across scopes → per-scope likely <3 → no fold-in.
-- Day 5-7: realistically S writes 1 pref per session, 1 session per day. If 3 land in `voice` scope by day 7 with importance=3, today → score = 3×3×1×10 = 90 → **fires once**.
-
-So yes, **it can fire once** — but only if S's prefs happen to cluster on one scope, and only if they're recent. The threshold is set assuming "8h work day, multiple corrections per scope." For a **side-project user** (S's profile), the threshold is too high and the window too narrow. **MAJOR misalignment with stated persona.**
-
-### Fold-in algorithm in memory.ts
-`computeFoldInProposals` mirrors the hook (good — single source of truth conceptually, though the hook re-implements it inline rather than importing — **CRITICAL drift risk:** any fix to one needs duplicate fix to the other). I see they're already drifted in subtle ways — hook hardcodes default config inline (`fold_in_score_threshold: 60, recurrence_window_days: 7`) and uses `now = Date.now()` while ts.lib uses `now = new Date()` parameter. Functionally equivalent here, but the duplication will rot.
-
-`mapScopeToSection`: heuristic prefix matching. `scope = "color.dark-mode"` → matches `startsWith('color')` → §2. `scope = "voice.error.spec"` → matches `startsWith('voice')` → §10. OK. But `scope = "spacing.button.cta"` → §5 Layout? Should be §4 Component Stylings. The mapping is too coarse. **MINOR for S** (S can fix the section in plan review).
-
-### Hook fires?
-- Hook is `Stop` event. Will it actually run? Depends on settings.json registration — not visible from this audit. **Cannot verify without `.claude/settings.json`.** Assuming registered: yes the file logic itself is sound (parses pref blocks, writes timeline.md, exits cleanly).
-- One real bug: line 93 `process.stdout.write(JSON.stringify({}) || '')` — `JSON.stringify({})` returns `"{}"` (truthy string), so the `|| ''` is dead code. Cosmetic. **MINOR.**
-
----
-
-## Step 7 — post-edit-watch hook on Tailwind file
-
-### Scenario
-S edits `tailwind.config.ts` and adds a new hex `#3a86ff` in `theme.extend.colors.brand`.
-
-### Reading post-edit-watch.cjs
-- Filters: `tsx|jsx|ts|js|css|scss` — `tailwind.config.ts` matches via `.ts`. ✅
-- Reads `payload.toolInput.content` or `new_string`. For an `Edit` of tailwind.config.ts, `new_string` will contain the inserted hex. ✅
-- Extracts hexes, dedups, lowercases.
-- Reads DESIGN.md, scans hex set.
-- Reports introduced = hexes minus design set.
-
-### Bugs
-
-**MAJOR bug — case-sensitivity asymmetry:**
-- New text scan: `(newText.match(/#[0-9a-f]{3,8}\b/gi) || []).map((h) => h.toLowerCase())` — matches both cases, lowercases.
-- DESIGN.md scan: `text.toLowerCase()` first, then `text.match(/#[0-9a-f]{3,8}\b/g)` — **non-`i` regex on already-lowercased text**. Works but fragile.
-- This *happens to work* but the asymmetry is a code smell — one of these will get touched and break the other.
-
-**MAJOR bug — false positives on hex-like numerics:**
-`#3a86ff` matches. But so does `#abc` and `#fff`. The regex `[0-9a-f]{3,8}` is correct for hex but **also matches `#decade` (a CSS comment "#decade") or random strings like `#abcdef` in code comments**. For S editing a config file with comments like `// see issue #1234abc`, **wait — `\b` after `[0-9a-f]{3,8}` requires a word boundary**, so `#abcdef` followed by `g` wouldn't match. OK, that's actually safe for length 3/4/6/8. But length-5 matches like `#decade` (length 6, valid hex chars, valid hex) **would** be picked up as a "color." False positive.
-
-**MAJOR bug — DESIGN.md token coverage assumption:**
-The hook flags any hex *not in DESIGN.md*. But DESIGN.md uses `oklch()` or CSS-var references in modern projects (Tailwind v4 / shadcn). If DESIGN.md says `--color-brand: oklch(0.62 0.19 256)` and never literally writes `#3a86ff`, the new hex will *always* be flagged "introduced" — even though it's the literal of the canonical token. **Net:** every hex edit gets flagged. S will silence the hook by day 2.
-
-**MINOR bug — message is borderline noise:**
-The output is "방금 X 에 DESIGN.md에 없는 색이 들어갔어요: #abc, #def, ...". For a config edit that adds 12 hexes (a palette import), the user gets a 3-hex truncated list with no scope on whether these are intentional palette extensions or accidental drift. Should differentiate: "1 hex added in `theme.colors.*` (likely intentional palette extension) — preference capture optional" vs "1 hex added in `Button.tsx` className=[#fff] (likely surface-patch) — preference capture **recommended**".
-
-**MINOR bug — exit code:**
-Hook exits 0 in all paths. Hook contract for Claude Code surfacing `additionalContext` is via stdout JSON. Confirmed correct on line 71. ✅
-
-### Will it fire?
-On `Edit` of `tailwind.config.ts` with `new_string` containing `#3a86ff` and DESIGN.md not containing it: **yes, fires, message displays.** Useful? **Marginally** — message is a one-liner suggestion, not a noise wall. But the false-positive rate (oklch projects, palette imports, comment hex-likes) will erode S's trust within days.
-
----
-
-## Cross-cutting findings
-
-### CRITICAL
-- **C1.** `code-introspect.ts` reports `1px` border widths as top spacing tokens (Step 2). Spec violation: "spacing" semantically excludes border widths. Fix required before v4 ships.
-- **C2.** `code-introspect.ts` does **not** detect inconsistencies (radius scale length, color cluster count, 8pt grid violations) — only frequency. For S the headline value is missing. Either rename to `code-census.ts` or actually add the inconsistency detector.
-- **C3.** Fold-in score formula promotes opinion-importance entries (importance=1) freely once count×recency clears the bar (Step 6). False promotion failure mode confirmed. Fix: weight by `(importance - 1)` so opinions need higher count to clear; or hard floor `importanceAvg >= 2.5`.
-- **C4.** Fold-in algorithm duplicated between `memory.ts` and `session-end-foldin.cjs` with subtle config drift (Step 6). Source-of-truth violation.
-- **C5.** post-edit-watch.cjs cannot reconcile `oklch()` / CSS-var DESIGN.md with literal-hex code edits → every Tailwind v4 project will see 100% false-positive flags (Step 7).
-
-### MAJOR
-- **M1.** Persona classification is sticky-on-first-message; long-form S who opens with "audit this" misclassifies (Step 1).
-- **M2.** Rule 999 (`[FILL IN]` for §11–13) has no negotiation protocol when user pushes back (Step 4).
-- **M3.** Critic.md lacks anti-platitude clause; can quietly hedge in §6 severity verdict.
-- **M4.** Critic re-do-scope can cascade into 18 phase-re-runs over 3 iterations with no memoization (Step 5).
-- **M5.** post-edit-watch.cjs case-sensitivity asymmetry between new-text scan and DESIGN.md scan (Step 7).
-
-### MINOR
-- **m1.** No "existing tooling acknowledgment" slot — husky/lint-staged user gets generic onboarding.
-- **m2.** `harvestFromTailwindConfig` silently misses imported palettes.
-- **m3.** Component/CSS file caps emit warnings nobody reads.
-- **m4.** `mapScopeToSection` too coarse (`spacing.button` → §5 instead of §4).
-- **m5.** session-end-foldin.cjs dead code on line 93.
-- **m6.** Critic.md §2 has no minimum-row requirement; lazy critic can pass with 1-row table.
-- **m7.** post-edit-watch message doesn't differentiate "intentional palette extension" vs "drift in component file."
-- **m8.** Opinion vocab in signal-classifier may still be thin for English (i1 expanded Korean only — would need to verify but English opinionated dev vocabulary like "honestly / frankly / hate / love / not having it" likely under-covered).
-
----
-
-## Verdict
-
-**v4 is not yet S-ready. Two CRITICAL must-fix before a senior dev would tolerate a daily-driver loop:**
-
-1. `code-introspect` outputs noise (border widths as spacing, no inconsistency detection). S will dismiss the system after the first inventory readout.
-2. Fold-in algorithm allows opinion-tier entries to promote into §-level rules with mere recency/recurrence. False promotion is the single failure mode S flagged in advance — and the formula does it by default.
-
-The critic scaffolding is genuinely strong (template forces verbatim evidence and root-cause traceback), and the file-handoff architecture between master and harness is clean. But the *measurement layer* (code-introspect + fold-in score) needs a rebuild, not a tweak. Currently the system is **honest about its rules but wrong in its math**.
-
-Recommend i3 = focused fix of C1/C2/C3/C4/C5 with unit tests on (a) realistic 25-component fixture (real border + spacing mix) and (b) week-long synthetic preference log validating the score formula doesn't promote opinions. M-tier items are deferrable; minors can wait until post-v4.
-
-**Severity: CRITICAL.**

package/.opencode/oh-my-design/skills/omd-lab-02-design-harness/runs/v4-self-test/iterations/i2-audit-V.md

@@ -1,73 +0,0 @@
-# Audit V (Vibe Coder)
-
-## Walk-through narrative
-
-Turn 0 — `omd install-skills` runs at the shell. **Silent — no prompt, no "now restart Claude Code"**. SKILL.md step 0 (omd-harness/SKILL.md:31-43) explicitly says install-skills *after* a session start requires `/agents` re-scan or full Cmd+Q restart, but install-skills itself never tells me that. I open Claude Code (already running) and don't know I need to restart.
-
-Turn 1 — I type `/omd-harness 헬스 트래킹 메인 화면`. UserPromptSubmit hook (skill-activation.cjs) checks rules. The trigger keywords for omd-harness in skill-rules.json:54-62 are `["하네스","알아서","전체","디자인 처음부터","메인 화면 디자인","와이어프레임","디자인 시작"]`. My phrase "헬스 트래킹 메인 화면" contains "메인 화면" but the rule is "메인 화면 디자인" (substring match `lower.includes(...)` — fails because "디자인" is missing). So the hook does NOT fire required activation. The slash command itself still runs the skill (slash command bypasses activation hook gating anyway), but the redundancy guard is dead weight.
-
-Turn 2 — Skill body runs preflight. Step 0 tries to detect if `omd-master` subagent is registered. It has *no actual mechanism* to verify (SKILL.md:33 just says "Agent tool 사용 가능 subagent 목록에 ... 있는지 확인" — there's no API to introspect subagent list). So it gambles. If install-skills was post-session it just crashes on first Agent() call.
-
-Turn 3 — Step 1 runs `omd harness "<task>" --internal`, gets runDir. Step 2 loads `.claude/data/reference-fingerprints.json` and asks me to pick a reference. **This is an extra mandatory question BEFORE the master even spawns**. For a 7-turn budget V persona this burns turn 1/7 on something I don't care about. I type "go".
-
-Turn 4 — master spawns. INTAKE state. context-detect.ts runs, detects Next + Tailwind + 10 components. inferPersonaSignal (context-detect.ts:128-137) sees `is_frontend && component_file_count between 5-20 && !has_design_md` → flags V. Turn cap = 7 (budget-tracker.ts:22).
-
-Turn 5 — master writes phase1-round1.questions.json (RULE 2: tightly-coupled 4-question bundle for audience/tone/actions/anti). Launcher renders AskUserQuestion. I see 4 questions in one picker. I click through. Answers saved.
-
-Turn 6 — master re-spawns with `continue checkpoint:phase1-round1`. Reads answers. signal-classifier.ts loaded, but **classifier is only called on free-text, not picker answers** — picker answers are option-label strings, never reach the opt-out detection. So my "skip"-equivalent option on a picker is just stored as the literal label, master treats it as a real selection.
-
-Turn 7 — SLOT_GATE checks remaining. exit_scope, success_criteria, a11y_floor — RULE 1 says default these. But the master prompt at omd-master.md:73-89 lists `exit_scope` as required with default `wireframe-and-spec`. Will master actually apply default and not ask, or ask anyway? Prompt is ambiguous. I get asked. Type "그냥".
-
-Turn 8 — signal-classifier picks up "그냥" → `opt_out_skip`. budget tick. RULE 6 requires 3 in a row to FAST_EXIT. I'm at 1.
-
-Turn 9 — master asks personas_named. I type "skip". opt_out_skip count=2.
-
-Turn 10 — master asks anti_patterns. I'm at turn 7+ now, **already past V cap of 7**. budget-tracker decide() returns `force_propose_plan` (budget-tracker.ts:81-83) but only if turn_count >= cap. Since cap is checked against `turn_count`, and V cap is 7, OMD-PLAN should fire. But the launcher safety cap is 12 spawns — these are decoupled. The user's perceived turn count vs spawn count vs budget turn_count are 3 different counters with no clear sync.
-
-I close the terminal at turn ~8-9 because I've answered too many questions and have zero artifact yet.
-
-## CRITICAL issues
-
-- **[C1] Subagent registration check is fake.** `skills/omd-harness/SKILL.md:31-43` claims to detect if `omd-master` is registered, but there is no Claude Code API for the launcher (running as the main thread Skill body) to introspect available subagent types before calling `Agent()`. So the "preflight" is wishful prose. If a user runs `omd install-skills` *after* opening Claude Code, the first `Agent({subagent_type: "omd-master"})` call inside the loop (omd-harness/SKILL.md:117-122) throws "Agent type not found" with no graceful handling. Symptom: terminal shows raw error, run dir half-bootstrapped, user blocked. **Fix:** wrap the first Agent() call in try/catch with the `Cmd+Q restart` guidance baked into the catch. Also have `omd install-skills` print a post-install banner: "Restart Claude Code (Cmd+Q) before using new skills."
-
-- **[C2] Picker answers bypass signal-classifier entirely.** `src/core/signal-classifier.ts:79-153` operates on free-text. The omd-harness loop (SKILL.md:144-147) writes raw `answers` from AskUserQuestion straight to `<checkpoint>.answers.json` and the master is told to read it. Answers are option `label` strings (e.g. "다이어터"), so opt-out detection (RULE 6 in omd-master.md:113-117) never triggers from picker UI — opt-out only works in the rare free-text "Other" path. For persona V who clicks through pickers tersely, FAST_EXIT is effectively unreachable. **Fix:** classify the *concatenation of picked labels + Other free-text*, and treat "skip"-style pre-baked options as `opt_out_skip` via a label allowlist; OR add an explicit "그만하기 / stop" first-class option to every checkpoint.
-
-- **[C3] Reference selection forced before master spawns burns a turn for V.** SKILL.md:60-103 makes DESIGN.md reference selection a *separate* mandatory question outside master's budget tracker. V's cap is 7 (budget-tracker.ts:22) but this turn isn't counted, and it's a content-empty question (V doesn't know/care which of 67 references). With Phase 1 round 1 being a 4-Q bundle and the harness expecting up to a dozen subsequent gates, V already exceeds the 7-turn perceived budget by gate 3. **Fix:** when persona_signal_initial is V (from context-detect.ts:128-137 — already cheap to compute pre-spawn), auto-pick top-1 ref and include it in OMD-PLAN.md as editable. Don't ask.
-
-- **[C4] Master ↔ launcher state-sync race on `.handoff.json`.** budget-tracker.ts:54-69 writes `handoff.budget` by reading existing `.handoff.json`, mutating, writing whole file back. master also writes `.handoff.json` per turn (omd-master.md:131-146). Launcher reads `.handoff.json` on its side (SKILL.md:131). If master writes handoff after `tick()` writes budget, the partial write order is undefined; master may overwrite budget, OR `saveBudget` may race-overwrite handoff state/questions_file pointers. There is no atomic-rename pattern. Symptom: on turn 5+, launcher reads stale handoff that points at stale checkpoint id, AskUserQuestion shows a question already answered. **Fix:** atomic write (`writeFileSync` to `.handoff.json.tmp` + `renameSync`); single writer (master only), expose `BudgetState` mutation through a CLI helper master invokes.
-
-## MAJOR issues
-
-- **[M1] Hook keyword mismatch makes activation unreliable.** `.claude/skills/skill-rules.json:58` keyword `"메인 화면 디자인"` requires the substring including "디자인". Persona V phrases "메인 화면 만들어줘" or "헬스 트래킹 메인 화면" → no hit. The omd-apply rule (skill-rules.json:8-17) catches "만들어" though, so omd-apply fires *instead of* omd-harness — wrong skill. **Fix:** loosen omd-harness keywords to `["메인 화면","와이어프레임","처음부터"]` and add an intent pattern that takes priority over omd-apply when the phrase implies *full design* not *edit existing*.
-
-- **[M2] Budget caps don't include the reference-pick turn or plan-review turn.** budget-tracker.ts cap V=7 is meant to be user-perceived turns. But turn_count is incremented in `tick()` only when master is spawned with a slot probe (omd-master.md unclear when exactly). PLAN_REVIEW is a separate ask (omd-master.md:62-63) — does it count? No spec. SHIP_GATE is another. So V's 7-turn promise is a lie; real user-facing question count is 7 + ref + plan-review + ship + 2-3 phase gates ≈ 12. **Fix:** define `turn_count` precisely as "number of AskUserQuestion calls relayed to user" and increment in the launcher, not master. Document mandatory gates as not-counted, but cap them at 3.
-
-- **[M3] FAST_EXIT trigger requires 3-in-a-row but master has no per-slot opt-out memory.** omd-master.md:113-117 says "opt_out_skip × 3 → propose plan", but budget-tracker.ts:117-121 only persists `last_signal_kind`, not a counter. So "3 in a row" is detected by master re-reading `trace.jsonl` each turn (omd-master.md:283-296) and counting — but trace.jsonl writes are advisory, not enforced. If master forgets to log, counter resets. **Fix:** add `consecutive_skip_count` and `consecutive_frustration_count` fields to BudgetState; increment/reset in `tick()` based on `signal_kind`.
-
-- **[M4] OMD-PLAN.md edit-then-go round-trip is undefined.** omd-master.md:62-63 says "User edited file → re-read OMD-PLAN.md, ask one more confirm." But OMD-PLAN.md sections (plan-emitter.ts:39-126) are free-form Markdown; master must re-parse to extract slot values. There is no parser. Master will hallucinate a diff or ignore edits. For V who would just type "go" without reading, fine; for the user who edits, their changes silently vanish. **Fix:** plan-emitter parser that extracts slots back from Markdown headings, with `[FILL IN]` markers as anchors.
-
-- **[M5] context-detect frontend definition is too loose.** context-detect.ts:159-163 considers the project frontend if `src/components/` OR `app/` OR `pages/` directory exists. A pure backend Next.js API project with `app/` folder would be classified as frontend, persona signal becomes V, and master would launch a wireframe pipeline on a non-UI codebase. **Fix:** require both a framework dep AND at least one .tsx/.jsx file present.
-
-- **[M6] No path normalization for Korean slugs in run dir.** SKILL.md:51-58 punts slug generation to `omd harness --internal`. If that helper doesn't transliterate Korean → ascii, downstream Bash usage of `<run_dir>` paths breaks on shells that don't quote consistently. Master uses `Bash` for `node -e "..."` plan emit (omd-master.md:188) and `omd init prepare` — these need quoted paths. Symptom: silent path-quoting bugs on edge characters. **Fix:** verify run dir slug is `[a-z0-9-]+` only; assert in launcher before continuing.
-
-## MINOR issues
-
-- **[m1] Master prompt says 8-16 turn average (omd-master.md:3) but persona caps allow V=7. Inconsistent.** Update agent description to "7-16 turn (persona-adaptive)".
-
-- **[m2] reference-pick prose (SKILL.md:88-94) uses Korean colloquial mixed with English ids — fine, but no English variant for English-speaking users.** Add locale switch.
-
-- **[m3] post-edit-watch.cjs only checks hex colors (post-edit-watch.cjs:43), not spacing/radius drift mentioned in the file's own header comment.** Either implement or remove the claim.
-
-- **[m4] plan-emitter.ts:128-132 leaks persona signal as HTML comment in OMD-PLAN.md.** Comment says "not user-facing" but Markdown viewers often show HTML comments in source view. Drop entirely or move to `.omd/internal/`.
-
-- **[m5] signal-classifier.ts:131 sets persona V on `opt_out_skip || approval` with ≤5 words — but approval (e.g., "go") is also how F and S confirm. Will misclassify a senior dev who types "go" tersely.** Add latency or follow-up evidence before locking persona.
-
-- **[m6] Hook skill-activation.cjs:35 does `lower.includes(k.toLowerCase()) || prompt.includes(k)` — Korean already-lowercase, the second OR is dead code for Korean-only keywords. Cosmetic.**
-
-- **[m7] session-state-loader.cjs:31 caps state.md injection at 60 lines but state.md format isn't documented anywhere — fragile contract.**
-
-## Overall verdict
-
-**major rework**
-
-The conversational state machine is well-conceived on paper (omd-master.md:39-67) but three first-contact failures (C1, C2, C3) would break or annoy persona V before they reach the first artifact. The budget contract (M2, M3) over-promises a 7-turn experience that the surrounding orchestration silently exceeds. Fix C1-C4 + M1-M3 before any more iteration on phases 5+; the downstream pipeline doesn't matter if V quits at turn 4.

package/.opencode/oh-my-design/skills/omd-lab-02-design-harness/runs/v4-self-test/iterations/i2-consolidated.md

@@ -1,69 +0,0 @@
-# i2 Consolidated Findings + Fix Plan
-
-**Date:** 2026-04-29
-**Method:** 4 parallel audit subagents (V/J/F/S persona). Each read v4 implementation files and walked through the master state machine mentally.
-
-## Cross-persona critical findings (deduped)
-
-| # | Issue | Cited by | Fix tier |
-|---|---|---|---|
-| C1 | Subagent registration "preflight" is fake (no API) — first Agent() call may throw | V | 1 |
-| C2 | Picker answers bypass signal-classifier — opt-out works only in free-text | V | 1 |
-| C3 | Reference-pick burns user turn before master spawns (V cap=7) | V | 1 |
-| C4 | Master ↔ launcher race on `.handoff.json` (no atomic write) | V | 2 |
-| F1 | No F-FAST path — founder forced through 8-16 turn avg | F | 1 |
-| F2 | dembrandt 90s timeout + unimplemented fallback (lethal on URL extract) | F | 1 |
-| F3 | Default `exit_scope = wireframe-and-spec` mismatches F's handoff-zip need | F | 1 |
-| J1 | URL_EXTRACT branch unimplemented (master.md:56 references it) | J | 1 |
-| J2 | @figma/code-connect detected but used only for persona, never as token source | J | 2 |
-| J3 | Catalog match will false-rank `figma` id when user shares own Figma file | J | 1 |
-| J4 | PlanInputs has no extracted-token schema → tokens vanish before OMD-PLAN.md | J | 1 |
-| S1 | code-introspect treats 1px borders as spacing tokens (PX_RE unfiltered) | S | 1 |
-| S2 | No inconsistency detection (no 8pt-grid check, no radius-scale check) | S | 3 (defer) |
-| S3 | Fold-in math: importance=1 × count=10 still promotes (false rule) | S | 1 |
-| S4 | Fold-in duplicated in memory.ts AND session-end-foldin.cjs (drift risk) | S | 1 |
-| S5 | post-edit-watch hex case asymmetry (Tailwind v4 oklch / CSS vars unhandled) | S | 1 |
-
-## Major (priority 2)
-
-- V-M1 hook keyword "메인 화면 디자인" too narrow → loosen
-- V-M2 turn count not synced (master vs launcher) → spec
-- V-M3 FAST_EXIT counter not persisted → add to BudgetState
-- V-M4 OMD-PLAN.md edit round-trip parser missing → add Markdown→PlanInputs
-- V-M5 frontend detection requires `is_frontend` to also need `.tsx/.jsx` file
-- F-Major: turn count, persona sticky, no anti-platitude
-- J-Major: designVocab regex too narrow (8pt grid / type ramp / modular scale missing), no J-specific question library, Phase 5 patch cites catalog tokens as user's
-- S-Major: persona sticky, no rule 999 negotiation, no anti-platitude in critic, cascade re-runs, hex case
-
-## Fix execution plan
-
-**Batch A — data/code quality**
-1. code-introspect: filter spacing < 4px (1px borders, etc.)
-2. signal-classifier: re-classify picker labels via opt-out corpus
-3. memory.ts: tighten fold-in (require importance avg ≥ 3 AND score ≥ 80)
-4. session-end-foldin.cjs: align formula with memory.ts (single SoT note)
-5. post-edit-watch.cjs: hex case + 3-vs-6 char normalization
-6. designVocab regex: add 8pt grid / type ramp / modular scale / tracking / leading / line-height / radius scale / elevation / hierarchy
-
-**Batch B — state machine**
-7. F-FAST path: empty repo + URL hint + first turn → propose plan immediately, defaults
-8. Persona-driven exit_scope: F → handoff-zip, others → wireframe-and-spec
-9. V auto-pick top-1 ref (skip ref question)
-10. Persona signal re-eval each turn
-11. Anti-platitude clause in critic prompt
-12. PlanInputs token schema: palette/typography/spacing fields
-
-**Batch C — URL/data**
-13. url-token-extractor: figma.com special case (graceful "paste tokens" message)
-14. URL_EXTRACT branch: actually call extractor, fallback to catalog
-15. Plan-emitter: surface extracted tokens
-
-**Batch D — install/hooks**
-16. install-skills postinstall: explicit "restart Claude Code" banner
-17. skill-rules.json: loosen omd-harness keywords
-
-**Batch E — guards**
-18. install-skills + master spawn: try/catch + recovery prose
-19. .handoff.json atomic write (rename pattern)
-20. New unit tests covering all fixes
-

package/.opencode/oh-my-design/skills/omd-lab-02-design-harness/runs/v4-self-test/postmortem.md

@@ -1,128 +0,0 @@
-# v4 Self-Test Loop — Postmortem
-
-**Date:** 2026-04-29 (single session)
-**Iterations:** 2 (i1 unit-test driven + i2 audit-subagent driven)
-**Total fixes applied:** 23 (16 critical + 7 major/minor)
-**Final state:** 545/545 tests pass, build clean
-
-## Iteration 1 — unit test driven
-
-### Bugs caught
-
-7 critical via unit tests:
-1. Trailing `</content></invoke>` in 5+ fixture/test files (recurring write-tool artifact)
-2. Founder fixture not actually empty (auto-created src/* dirs)
-3. signal-classifier Korean directive regex `\b` failure
-4. signal-classifier persona heuristic word-count threshold too high for Korean
-5. vitest.config missed `test/v4/`
-6. (cascade fixes from above)
-
-→ All fixed. 545/545 green.
-
-## Iteration 2 — audit subagent driven
-
-4 parallel subagents (V/J/F/S persona) read v4 implementation files and walked through master state machine. Verdict: V "major rework", J "REJECT", F "FAIL", S "CRITICAL".
-
-### Cross-persona critical issues identified (16)
-
-V (4): subagent registration fake / picker bypass classifier / ref-pick burns turn / handoff race
-F (4): no F-FAST / dembrandt timeout unhandled / wrong default exit_scope / exit_scope not persona-driven
-J (4): URL_EXTRACT unimplemented / @figma/code-connect unused / catalog false-match / PlanInputs no token schema
-S (5): 1px noise / no inconsistency detection / fold-in too lenient / fold-in duplicated / hex case asymmetry
-
-### Fixes applied (this iteration)
-
-| # | Fix | Files |
-|---|---|---|
-| 1 | Filter spacing < 4px (1px borders) | src/core/code-introspect.ts (×2 paths) |
-| 2 | Fold-in importance avg ≥ 2.5 floor | src/core/memory.ts |
-| 3 | Sync session-end-foldin.cjs with memory.ts formula | .claude/hooks/session-end-foldin.cjs |
-| 4 | post-edit-watch hex normalization (3-vs-6 char) + Tailwind v4 oklch/CSS-var skip | .claude/hooks/post-edit-watch.cjs |
-| 5 | designVocab regex expanded (8pt, type ramp, modular scale, tracking, leading, line-height, elevation, gradient, baseline, optical, kerning, hierarchy, 타입스케일, 모듈러) | src/core/signal-classifier.ts |
-| 6 | PlanInputs.extracted_tokens schema (palette/typography/spacing/radius/shadows/has_dark_mode) | src/core/plan-emitter.ts |
-| 7 | OMD-PLAN.md §7 renders extracted tokens | src/core/plan-emitter.ts |
-| 8 | Persona-driven exit_scope defaults (F→handoff-zip, S→handoff-zip, V/J→wireframe-and-spec) | agents/omd-master.md |
-| 9 | F-FAST path in INTAKE | agents/omd-master.md |
-| 10 | V auto-pick top-1 reference (skip ref question) | agents/omd-master.md |
-| 11 | URL_EXTRACT branch + FIGMA_GUIDANCE branch in state machine | agents/omd-master.md |
-| 12 | url-token-extractor: figma.com special-case ("not yet supported, paste tokens") | src/core/url-token-extractor.ts |
-| 13 | RULE 9 (no platitudes) + RULE 10 (persona re-evaluation) added | agents/omd-master.md |
-| 14 | Anti-platitude audit clause in critic | agents/omd-critic.md |
-| 15 | skill-rules omd-harness keywords loosened ("메인 화면" alone OK) | .claude/skills/skill-rules.json |
-| 16 | postinstall ⚠ "Already running Claude Code? Quit and relaunch" line | scripts/postinstall.cjs |
-| 17 | src/index.ts v4 module exports (programmatic API) | src/index.ts |
-
-### Deferred to v4.1 (not blocking first demo)
-
-- S2: code-introspect inconsistency detection (8pt-grid check, radius-scale check) — needs more thought, deferred
-- V-C4: .handoff.json atomic write — race exists but low likelihood in single-master flow
-- V-M4: OMD-PLAN.md edit round-trip parser (Markdown → PlanInputs) — current behavior: user edits silently dropped, master re-reads but doesn't re-parse
-- J-M2: J-specific question library (different from V's pickers) — currently same questions for all personas
-- C2: picker labels through signal-classifier — partial fix in regex, full fix needs label allowlist
-
-## Final state
-
-| Metric | i0 | i1 | i2 |
-|---|---|---|---|
-| Test count | 505 | 545 (+40 v4) | 545 |
-| Test pass rate | 100% | 100% | 100% |
-| Critical bugs known | (unknown) | 7 found+fixed | 16 found, 16 critical fixed (4 deferred) |
-| Build | clean | clean | clean |
-| Personas covered | 0 audited | 4 simulated | 4 audited |
-
-## Honest assessment (보수적 기준)
-
-- Real harness end-to-end run: **still 0회**. Lab tests are unit + audit (subagent-driven), not real user.
-- Hooks fire-in-Claude-Code: **still 0회 verified**. Code follows docs but not test-fired.
-- Code quality after i2: significantly improved (1px noise, fold-in math, designVocab, PlanInputs schema).
-- Master prompt depth after i2: significantly improved (F-FAST, persona-driven defaults, anti-platitude, persona re-eval, URL_EXTRACT branch).
-- Vs v2 baseline: **30% → ~55-60% of mature OSS harness sophistication**.
-
-### What still won't work first try (predicted)
-
-1. dembrandt CLI integration on Stripe URL — likely will work but possible failure modes (TOS, syntax) untested
-2. Hook firing in actual Claude Code session — depends on Claude Code's hook contract reading
-3. Master following all 10 rules under pressure — opus is good but 600+-line prompt is dense
-4. F-FAST path actually firing — depends on master correctly classifying empty + URL hint INTAKE
-
-### What v4.1 should do
-
-- Real user demo (water-app or similar)
-- Hook fire verification
-- Real dembrandt URL test
-- Inconsistency detection (S2)
-- Atomic .handoff.json write (V-C4)
-- OMD-PLAN.md edit parser (V-M4)
-
-## Loop terminated
-
-Self-feedback structure built and exercised twice. 23 fixes applied autonomously. Without user demo it cannot improve further on the same axes — diminishing returns. Real run-time data needed.
-
----
-
-## v4.2 + v4.2.1 — User demo feedback (2026-04-29 evening)
-
-User did real demo on water-app:
-
-**Worked**: prototype 단계 (Drop habit-tracker single-glass viz with wave/splash motion) — wow ✓
-
-**Failed**: production transition — when user said "프로덕션화 시키고자 하는데", harness 꺼지고 평범한 Next.js 변환으로 fallback. DESIGN.md 0건, asset audit 0건, brand spec 0건. *"프로덕션 와우 0"*.
-
-**Fix v4.2** (production keywords + state):
-- skill-rules.json: omd-harness keywords expanded (프로덕션화 / production / ship / deploy / 에셋 / 아이콘 / DESIGN.md 만들 / extract DESIGN.md)
-- master.md: `PRODUCTION_TRANSITION` state added — when production keywords detected mid-flight, audit current state + spawn punch-list
-
-**Fix v4.2.1** (user correction on curation philosophy):
-- User pushed back on "DESIGN.md generate from prototype tokens" — that's mechanical/generic
-- Correct: prototype = *signal* for matching, NOT source-of-truth
-- Re-wrote PRODUCTION_TRANSITION:
-  - Step 1: Light read (5 adjectives, 1-2 dominant colors, motion vocab) — NOT full extraction
-  - Step 2: Score against 67-catalog → top 2-3 closest references
-  - Step 3: Curation proposal as user-facing prose: "이 톤이 toss + lovable 가까워 보여요. 거기에 [domain] 성격 가미해서 DESIGN.md 만들까요?"
-  - Step 4: Hybrid via `omd init prepare --ref X --description "..."` (preserves reference voice + applies delta_set on axes only)
-  - Step 5: asset-curator with production punch-list
-  - Step 6: microcopy + a11y + handoff
-- Picker offers: toss / lovable / 둘 다 / 다른 ref / raw extract (less recommended)
-
-This aligns with OmD's existing `omd-init` Phase 5 hybrid variation philosophy. The wow point in production: **"내 prototype을 toss + lovable로 인식하고 그 voice 보존하면서 Drop 도메인 가미해서 DESIGN.md를 줬다"** — curated, not extracted.
-