zudoku 0.0.0-fix-prevent-full-deref-allof.b02efbe5 → 0.0.0-fix-firebase-export.f8270825

package/src/lib/util/flattenAllOf.test.ts

@@ -362,16 +362,12 @@ describe("flattenAllOf processor", () => {
       },
     };
 
-    const mockDereference = vi.fn().mockResolvedValue(schema);
-
     const result = await flattenAllOfProcessor({
       schema,
       file: "/test/schema.json",
-      dereference: mockDereference,
+      dereference: vi.fn(),
     });
 
-    expect(mockDereference).toHaveBeenCalledWith(schema);
-
     const responseSchema =
       result.paths?.["/users"]?.get?.responses?.[200]?.content?.[
         "application/json"
@@ -423,31 +419,20 @@ describe("flattenAllOf processor", () => {
     expect(userSchema).not.toHaveProperty("allOf");
   });
 
-  it("should handle errors gracefully and return original schema", async () => {
+  it("should handle schemas without allOf gracefully", async () => {
     const schema: OpenAPIDocument = {
       openapi: "3.0.0",
       info: { title: "Test API", version: "1.0.0" },
       paths: {},
     };
 
-    const mockDereference = vi
-      .fn()
-      .mockRejectedValue(new Error("Dereference failed"));
-
-    const consoleSpy = vi.spyOn(console, "warn").mockImplementation(() => {});
-
     const result = await flattenAllOfProcessor({
       schema,
       file: "/test/schema.json",
-      dereference: mockDereference,
+      dereference: vi.fn(),
     });
 
-    expect(result).toBe(schema);
-    expect(consoleSpy).toHaveBeenCalledWith(
-      expect.stringContaining("Failed to flatten"),
-    );
-
-    consoleSpy.mockRestore();
+    expect(result).toStrictEqual(schema);
   });
 
   it("should only flatten schema objects, not other OpenAPI structures", async () => {
@@ -634,4 +619,71 @@ describe("flattenAllOf processor", () => {
     });
     expect(containerSchema?.oneOf?.[1]).not.toHaveProperty("allOf");
   });
+
+  it("should preserve $refs outside of allOf while flattening allOf with $refs", async () => {
+    // Schema with:
+    // 1. A reusable component (Base) that's referenced multiple times
+    // 2. An allOf that references Base (should be resolved for merging)
+    // 3. A property that references Base (should stay as $ref)
+    const schema = {
+      openapi: "3.0.0",
+      info: { title: "Test API", version: "1.0.0" },
+      paths: {},
+      components: {
+        schemas: {
+          Base: {
+            type: "object",
+            properties: {
+              id: { type: "string" },
+              createdAt: { type: "string", format: "date-time" },
+            },
+          },
+          Extended: {
+            allOf: [
+              { $ref: "#/components/schemas/Base" },
+              {
+                type: "object",
+                properties: {
+                  name: { type: "string" },
+                },
+              },
+            ],
+          },
+          Container: {
+            type: "object",
+            properties: {
+              // This $ref should NOT be expanded
+              nested: { $ref: "#/components/schemas/Base" },
+            },
+          },
+        },
+      },
+    } as OpenAPIDocument;
+
+    const result = await flattenAllOfProcessor({
+      schema,
+      file: "/test/schema.json",
+      dereference: vi.fn(),
+    });
+
+    // Extended should have allOf flattened (merged with Base)
+    const extendedSchema = result.components?.schemas?.Extended;
+    expect(extendedSchema).not.toHaveProperty("allOf");
+    expect(extendedSchema).toMatchObject({
+      type: "object",
+      properties: {
+        id: { type: "string" },
+        createdAt: { type: "string", format: "date-time" },
+        name: { type: "string" },
+      },
+    });
+
+    // Container.nested should still be a $ref (NOT expanded)
+    const containerSchema = result.components?.schemas
+      ?.Container as unknown as Record<string, unknown>;
+    const nestedProp = (containerSchema?.properties as Record<string, unknown>)
+      ?.nested as Record<string, unknown>;
+    expect(nestedProp).toHaveProperty("$ref");
+    expect(nestedProp.$ref).toBe("#/components/schemas/Base");
+  });
 });