zklib-ts 1.0.4 → 1.0.5

package/dist/index.cjs.js

@@ -1328,17 +1328,26 @@ class ZTCP {
     }
     async getSerialNumber() {
         const keyword = '~SerialNumber';
+        let serialNumber = '';
+        let count = 10;
         try {
             // Execute the command to get serial number
-            const data = await this.executeCmd(COMMANDS.CMD_OPTIONS_RRQ, keyword);
-            // Extract and format the serial number from the response data
-            const serialNumber = data.slice(8) // Skip the first 8 bytes (header)
-                .toString('utf-8') // Convert buffer to string
-                .replace(`${keyword}=`, '') // Remove the keyword prefix
-                .replace('=', '') // Remove sometines last number is a character equal to = or unknow character
-                .replace(/\u0000/g, ''); // Remove null characters
-            if (serialNumber.length !== 13 && this.verbose) {
-                console.warn('Serial number length not equal to 13, check');
+            /**
+             * @dev implemented a counter and a while loop because sometimes serial number parses wrong for some reason
+             * */
+            while (serialNumber.length !== 13 && count > 0) {
+                const data = await this.executeCmd(COMMANDS.CMD_OPTIONS_RRQ, keyword);
+                // Extract and format the serial number from the response data
+                const SN = data.slice(8) // Skip the first 8 bytes (header)
+                    .toString('utf-8') // Convert buffer to string
+                    .replace(`${keyword}=`, '') // Remove the keyword prefix
+                    .replace('=', '') // Remove sometines last number is a character equal to = or unknow character
+                    .replace(/\u0000/g, ''); // Remove null characters
+                if (serialNumber.length !== 13 && this.verbose) {
+                    console.warn('Serial number length not equal to 13, check');
+                }
+                count--;
+                serialNumber = SN;
             }
             return serialNumber;
         }

package/dist/index.es.js

@@ -1307,17 +1307,26 @@ class ZTCP {
     }
     async getSerialNumber() {
         const keyword = '~SerialNumber';
+        let serialNumber = '';
+        let count = 10;
         try {
             // Execute the command to get serial number
-            const data = await this.executeCmd(COMMANDS.CMD_OPTIONS_RRQ, keyword);
-            // Extract and format the serial number from the response data
-            const serialNumber = data.slice(8) // Skip the first 8 bytes (header)
-                .toString('utf-8') // Convert buffer to string
-                .replace(`${keyword}=`, '') // Remove the keyword prefix
-                .replace('=', '') // Remove sometines last number is a character equal to = or unknow character
-                .replace(/\u0000/g, ''); // Remove null characters
-            if (serialNumber.length !== 13 && this.verbose) {
-                console.warn('Serial number length not equal to 13, check');
+            /**
+             * @dev implemented a counter and a while loop because sometimes serial number parses wrong for some reason
+             * */
+            while (serialNumber.length !== 13 && count > 0) {
+                const data = await this.executeCmd(COMMANDS.CMD_OPTIONS_RRQ, keyword);
+                // Extract and format the serial number from the response data
+                const SN = data.slice(8) // Skip the first 8 bytes (header)
+                    .toString('utf-8') // Convert buffer to string
+                    .replace(`${keyword}=`, '') // Remove the keyword prefix
+                    .replace('=', '') // Remove sometines last number is a character equal to = or unknow character
+                    .replace(/\u0000/g, ''); // Remove null characters
+                if (serialNumber.length !== 13 && this.verbose) {
+                    console.warn('Serial number length not equal to 13, check');
+                }
+                count--;
+                serialNumber = SN;
             }
             return serialNumber;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "zklib-ts",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Unofficial zkteco library allows Node.js developers to easily interface with ZK BioMetric Fingerprint Attendance Devices",
   "main": "dist/index.cjs.js",
   "module": "dist/index.es.js",