zigbee-herdsman-converters 25.2.0 → 25.4.0

package/dist/converters/toZigbee.js

@@ -76,7 +76,8 @@ exports.on_off = {
                 throw Error("The off_wait_time value must be a number!");
             }
             const payload = meta.converterOptions
-                ? meta.converterOptions
+                ? // TODO: better typing? currently used in a single place??
+                    meta.converterOptions
                 : { ctrlbits: 0, ontime: Math.round(onTime * 10), offwaittime: Math.round(offWaitTime * 10) };
             await entity.command("genOnOff", "onWithTimedOff", payload, utils.getOptions(meta.mapped, entity));
         }
@@ -97,11 +98,9 @@ exports.light_color = {
     key: ["color"],
     options: [exposes.options.color_sync(), exposes.options.transition()],
     convertSet: async (entity, key, value, meta) => {
-        // biome-ignore lint/suspicious/noImplicitAnyLet: ignored using `--suppress`
-        let command;
         const newColor = libColor.Color.fromConverterArg(value);
         const newState = {};
-        const zclData = { transtime: utils.getTransition(entity, key, meta).time };
+        const transtime = utils.getTransition(entity, key, meta).time;
         const supportsHueAndSaturation = utils.getMetaValue(entity, meta.mapped, "supportsHueAndSaturation", "allEqual", true);
         const supportsEnhancedHue = utils.getMetaValue(entity, meta.mapped, "supportsEnhancedHue", "allEqual", true);
         if (newColor.isHSV() && !supportsHueAndSaturation) {
@@ -121,57 +120,48 @@ exports.light_color = {
             }
             newState.color_mode = constants.colorModeLookup[1];
             newState.color = xy.toObject();
-            zclData.colorx = utils.mapNumberRange(xy.x, 0, 1, 0, 65535);
-            zclData.colory = utils.mapNumberRange(xy.y, 0, 1, 0, 65535);
-            command = "moveToColor";
+            const colorx = utils.mapNumberRange(xy.x, 0, 1, 0, 65535);
+            const colory = utils.mapNumberRange(xy.y, 0, 1, 0, 65535);
+            await entity.command("lightingColorCtrl", "moveToColor", { transtime, colorx, colory }, utils.getOptions(meta.mapped, entity));
         }
         else if (newColor.isHSV()) {
             const hsv = newColor.hsv;
             const hsvCorrected = hsv.colorCorrected(meta);
             newState.color_mode = constants.colorModeLookup[0];
             newState.color = hsv.toObject(false);
-            if (hsv.hue !== null) {
-                if (supportsEnhancedHue) {
-                    zclData.enhancehue = utils.mapNumberRange(hsvCorrected.hue, 0, 360, 0, 65535);
-                }
-                else {
-                    zclData.hue = utils.mapNumberRange(hsvCorrected.hue, 0, 360, 0, 254);
-                }
-                // @ts-expect-error ignore
-                zclData.direction = value.direction || 0;
-            }
-            if (hsv.saturation != null) {
-                zclData.saturation = utils.mapNumberRange(hsvCorrected.saturation, 0, 100, 0, 254);
-            }
-            if (hsv.value !== null) {
-                // fallthrough to genLevelCtrl
-                // @ts-expect-error ignore
-                value.brightness = utils.mapNumberRange(hsvCorrected.value, 0, 100, 0, 254);
+            if (hsv.value !== null && utils.isObject(value)) {
+                await entity.command("genLevelCtrl", "moveToLevelWithOnOff", { level: utils.mapNumberRange(hsvCorrected.value, 0, 100, 0, 254), transtime }, utils.getOptions(meta.mapped, entity));
             }
             if (hsv.hue !== null && hsv.saturation !== null) {
+                const saturation = utils.mapNumberRange(hsvCorrected.saturation, 0, 100, 0, 254);
                 if (supportsEnhancedHue) {
-                    command = "enhancedMoveToHueAndSaturation";
+                    const enhancehue = utils.mapNumberRange(hsvCorrected.hue, 0, 360, 0, 65535);
+                    await entity.command("lightingColorCtrl", "enhancedMoveToHueAndSaturation", { transtime, enhancehue, saturation }, utils.getOptions(meta.mapped, entity));
                 }
                 else {
-                    command = "moveToHueAndSaturation";
+                    const hue = utils.mapNumberRange(hsvCorrected.hue, 0, 360, 0, 254);
+                    await entity.command("lightingColorCtrl", "moveToHueAndSaturation", { transtime, hue, saturation }, utils.getOptions(meta.mapped, entity));
                 }
             }
             else if (hsv.hue !== null) {
+                const direction = value.direction || 0;
                 if (supportsEnhancedHue) {
-                    command = "enhancedMoveToHue";
+                    const enhancehue = utils.mapNumberRange(hsvCorrected.hue, 0, 360, 0, 65535);
+                    await entity.command("lightingColorCtrl", "enhancedMoveToHue", { transtime, enhancehue, direction }, utils.getOptions(meta.mapped, entity));
                 }
                 else {
-                    command = "moveToHue";
+                    const hue = utils.mapNumberRange(hsvCorrected.hue, 0, 360, 0, 254);
+                    await entity.command("lightingColorCtrl", "moveToHue", { transtime, hue, direction }, utils.getOptions(meta.mapped, entity));
                 }
             }
             else if (hsv.saturation !== null) {
-                command = "moveToSaturation";
+                const saturation = utils.mapNumberRange(hsvCorrected.saturation, 0, 100, 0, 254);
+                await entity.command("lightingColorCtrl", "moveToSaturation", { transtime, saturation }, utils.getOptions(meta.mapped, entity));
             }
         }
-        if (utils.isObject(value) && value.brightness != null) {
-            await entity.command("genLevelCtrl", "moveToLevelWithOnOff", { level: Number(value.brightness), transtime: utils.getTransition(entity, key, meta).time }, utils.getOptions(meta.mapped, entity));
+        else {
+            throw new Error("Invalid color");
         }
-        await entity.command("lightingColorCtrl", command, zclData, utils.getOptions(meta.mapped, entity));
         return { state: libColor.syncColorState(newState, meta.state, entity, meta.options) };
     },
     convertGet: async (entity, key, meta) => {
@@ -513,7 +503,7 @@ exports.cover_via_brightness = {
             : meta.options.invert_cover;
         utils.assertNumber(value);
         const position = invert ? 100 - value : value;
-        await entity.command("genLevelCtrl", "moveToLevelWithOnOff", { level: utils.mapNumberRange(Number(position), 0, 100, 0, 255).toString(), transtime: 0 }, utils.getOptions(meta.mapped, entity));
+        await entity.command("genLevelCtrl", "moveToLevelWithOnOff", { level: utils.mapNumberRange(Number(position), 0, 100, 0, 255), transtime: 0 }, utils.getOptions(meta.mapped, entity));
         return { state: { position: value } };
     },
     convertGet: async (entity, key, meta) => {
@@ -600,11 +590,15 @@ exports.squawk = {
 exports.cover_state = {
     key: ["state"],
     convertSet: async (entity, key, value, meta) => {
-        const lookup = { open: "upOpen", close: "downClose", stop: "stop", on: "upOpen", off: "downClose" };
+        const lookup = {
+            open: "upOpen",
+            close: "downClose",
+            stop: "stop",
+            on: "upOpen",
+            off: "downClose",
+        };
         utils.assertString(value, key);
-        // biome-ignore lint/style/noParameterAssign: ignored using `--suppress`
-        value = value.toLowerCase();
-        await entity.command("closuresWindowCovering", utils.getFromLookup(value, lookup), {}, utils.getOptions(meta.mapped, entity));
+        await entity.command("closuresWindowCovering", utils.getFromLookup(value.toLowerCase(), lookup), {}, utils.getOptions(meta.mapped, entity));
     },
 };
 exports.cover_position_tilt = {
@@ -787,7 +781,14 @@ exports.level_config = {
         }
     },
     convertGet: async (entity, key, meta) => {
-        for (const attribute of ["onOffTransitionTime", "onTransitionTime", "offTransitionTime", "startUpCurrentLevel", "onLevel", "options"]) {
+        for (const attribute of [
+            "onOffTransitionTime",
+            "onTransitionTime",
+            "offTransitionTime",
+            "startUpCurrentLevel",
+            "onLevel",
+            "options",
+        ]) {
             try {
                 await entity.read("genLevelCtrl", [attribute]);
             }
@@ -823,24 +824,23 @@ exports.ballast_config = {
     convertGet: async (entity, key, meta) => {
         let result = {};
         for (const attrName of [
-            "ballast_status",
-            "min_level",
-            "max_level",
-            "power_on_level",
-            "power_on_fade_time",
-            "intrinsic_ballast_factor",
-            "ballast_factor_adjustment",
-            "lamp_quantity",
-            "lamp_type",
-            "lamp_manufacturer",
-            "lamp_rated_hours",
-            "lamp_burn_hours",
-            "lamp_alarm_mode",
-            "lamp_burn_hours_trip_point",
+            "ballastStatus",
+            "minLevel",
+            "maxLevel",
+            "powerOnLevel",
+            "powerOnFadeTime",
+            "intrinsicBallastFactor",
+            "ballastFactorAdjustment",
+            "lampQuantity",
+            "lampType",
+            "lampManufacturer",
+            "lampRatedHours",
+            "lampBurnHours",
+            "lampAlarmMode",
+            "lampBurnHoursTripPoint",
         ]) {
             try {
-                // @ts-expect-error ignore
-                result = { ...result, ...(await entity.read("lightingBallastCfg", [utils.toCamelCase(attrName)])) };
+                result = { ...result, ...(await entity.read("lightingBallastCfg", [attrName])) };
             }
             catch {
                 // continue regardless of error
@@ -932,7 +932,8 @@ exports.light_colortemp_move = {
     key: ["colortemp_move", "color_temp_move"],
     convertSet: async (entity, key, value, meta) => {
         // Initialize payload with default constraints
-        const payload = { minimum: 0, maximum: 600 };
+        let minimum = 0;
+        let maximum = 600;
         let rate;
         let movemode;
         // Handle different input formats
@@ -955,8 +956,8 @@ exports.light_colortemp_move = {
                 throw new Error(`${key}: invalid string value "${value}". Expected "stop", "release", "0", "up", "1", or "down"`);
             }
             // Use legacy constraints for string-based commands
-            payload.minimum = 153;
-            payload.maximum = 370;
+            minimum = 153;
+            maximum = 370;
         }
         else if (utils.isNumber(value)) {
             // Simple number input
@@ -994,26 +995,23 @@ exports.light_colortemp_move = {
             if (value.minimum != null) {
                 const minValue = Number(value.minimum);
                 utils.assertNumber(minValue, `${key}.minimum`);
-                payload.minimum = minValue;
+                minimum = minValue;
             }
             if (value.maximum != null) {
                 const maxValue = Number(value.maximum);
                 utils.assertNumber(maxValue, `${key}.maximum`);
-                payload.maximum = maxValue;
+                maximum = maxValue;
             }
             // Validate constraints
-            if (payload.minimum >= payload.maximum) {
-                throw new Error(`${key}: minimum (${payload.minimum}) must be less than maximum (${payload.maximum})`);
+            if (minimum >= maximum) {
+                throw new Error(`${key}: minimum (${minimum}) must be less than maximum (${maximum})`);
             }
         }
         else {
             throw new Error(`${key}: invalid value type. Expected number, string, or object with rate property`);
         }
-        // Set final payload values
-        payload.rate = rate;
-        payload.movemode = movemode;
         // Send command
-        await entity.command("lightingColorCtrl", "moveColorTemp", payload, utils.getOptions(meta.mapped, entity));
+        await entity.command("lightingColorCtrl", "moveColorTemp", { minimum, maximum, rate, movemode }, utils.getOptions(meta.mapped, entity));
         // Read current color temperature if stopping
         if (movemode === 0) {
             const entityToRead = utils.getEntityOrFirstGroupMember(entity);
@@ -1078,17 +1076,18 @@ exports.light_hue_saturation_move = {
         value = value === "stop" ? value : Number(value);
         const command = key === "hue_move" ? "moveHue" : "moveSaturation";
         const attribute = key === "hue_move" ? "currentHue" : "currentSaturation";
-        const payload = {};
+        let rate = 0;
+        let movemode = 0;
         if (value === "stop" || value === 0) {
-            payload.rate = 1;
-            payload.movemode = 0;
+            rate = 1;
+            movemode = 0;
         }
         else {
             utils.assertNumber(value, key);
-            payload.rate = Math.abs(value);
-            payload.movemode = value > 0 ? 1 : 3;
+            rate = Math.abs(value);
+            movemode = value > 0 ? 1 : 3;
         }
-        await entity.command("lightingColorCtrl", command, payload, utils.getOptions(meta.mapped, entity));
+        await entity.command("lightingColorCtrl", command, { rate, movemode }, utils.getOptions(meta.mapped, entity));
         // We cannot determine the hue/saturation from the current state so we read it, because
         // - Color mode could have been switched (x/y or colortemp)
         if (value === "stop" || value === 0) {
@@ -1107,6 +1106,7 @@ exports.light_onoff_brightness = {
         const { message } = meta;
         const transition = utils.getTransition(entity, "brightness", meta);
         const turnsOffAtBrightness1 = utils.getMetaValue(entity, meta.mapped, "turnsOffAtBrightness1", "allEqual", false);
+        const moveToLevelWithOnOffDisable = utils.getMetaValue(entity, meta.mapped, "moveToLevelWithOnOffDisable", "allEqual", false);
         let state = message.state !== undefined ? (typeof message.state === "string" ? message.state.toLowerCase() : null) : undefined;
         let brightness;
         if (message.brightness != null) {
@@ -1174,7 +1174,6 @@ exports.light_onoff_brightness = {
                     try {
                         const attributeRead = await entity.read("genLevelCtrl", ["onLevel"]);
                         if (attributeRead !== undefined) {
-                            // @ts-expect-error ignore
                             onLevel = attributeRead.onLevel;
                         }
                     }
@@ -1217,12 +1216,12 @@ exports.light_onoff_brightness = {
             globalStore.putValue(entity, "brightness", brightness);
             globalStore.clearValue(entity, "turnedOffWithTransition");
         }
-        await entity.command("genLevelCtrl", state === null ? "moveToLevel" : "moveToLevelWithOnOff", { level: Number(brightness), transtime: transition.time }, utils.getOptions(meta.mapped, entity));
+        await entity.command("genLevelCtrl", state === null || moveToLevelWithOnOffDisable ? "moveToLevel" : "moveToLevelWithOnOff", { level: Number(brightness), transtime: transition.time }, utils.getOptions(meta.mapped, entity));
         const result = { state: {} };
         if (publishBrightness) {
             result.state.brightness = Number(brightness);
         }
-        if (state !== null) {
+        if (state !== null && !moveToLevelWithOnOffDisable) {
             result.state.state = brightness === 0 ? "OFF" : "ON";
         }
         return result;
@@ -1254,7 +1253,7 @@ exports.light_colortemp_startup = {
             // biome-ignore lint/style/noParameterAssign: ignored using `--suppress`
             value = light.clampColorTemp(value, colorTempMin, colorTempMax);
         }
-        await entity.write("lightingColorCtrl", { startUpColorTemperature: value }, utils.getOptions(meta.mapped, entity));
+        await entity.write("lightingColorCtrl", { startUpColorTemperature: value /* type failure? */ }, utils.getOptions(meta.mapped, entity));
         return { state: { color_temp_startup: value } };
     },
     convertGet: async (entity, key, meta) => {
@@ -1368,29 +1367,28 @@ exports.thermostat_weekly_schedule = {
                    ]}}
              */
         utils.assertObject(value, key);
-        const payload = {
-            dayofweek: value.dayofweek,
-            transitions: value.transitions,
-        };
-        if (Array.isArray(payload.transitions)) {
+        let daysofweek = value.dayofweek;
+        const transitions = value.transitions;
+        let numoftrans = 0;
+        const modes = [];
+        if (Array.isArray(transitions)) {
             // calculate numoftrans
             if (typeof value.numoftrans !== "undefined") {
                 logger_1.logger.warning(`weekly_schedule: ignoring provided numoftrans value (${JSON.stringify(value.numoftrans)}), this is now calculated automatically`, NS);
             }
-            payload.numoftrans = payload.transitions.length;
+            numoftrans = transitions.length;
             // mode is calculated below
             if (typeof value.mode !== "undefined") {
                 logger_1.logger.warning(`weekly_schedule: ignoring provided mode value (${JSON.stringify(value.mode)}), this is now calculated automatically`, NS);
             }
-            payload.mode = [];
             // transform transition payload values if needed
-            for (const elem of payload.transitions) {
-                // update payload.mode if needed
-                if (elem.heatSetpoint != null && !payload.mode.includes("heat")) {
-                    payload.mode.push("heat");
+            for (const elem of transitions) {
+                // update mode if needed
+                if (elem.heatSetpoint != null && !modes.includes("heat")) {
+                    modes.push("heat");
                 }
-                if (elem.coolSetpoint != null && !payload.mode.includes("cool")) {
-                    payload.mode.push("cool");
+                if (elem.coolSetpoint != null && !modes.includes("cool")) {
+                    modes.push("cool");
                 }
                 // transform setpoint values if numeric
                 if (typeof elem.heatSetpoint === "number") {
@@ -1402,8 +1400,8 @@ exports.thermostat_weekly_schedule = {
                 // accept 24h time notation (e.g. 19:30)
                 if (typeof elem.transitionTime === "string") {
                     const time = elem.transitionTime.split(":");
-                    const timeHour = Number.parseInt(time[0]) * 60;
-                    const timeMinute = Number.parseInt(time[1]);
+                    const timeHour = Number.parseInt(time[0], 10) * 60;
+                    const timeMinute = Number.parseInt(time[1], 10);
                     if (time.length !== 2 || Number.isNaN(timeHour) || Number.isNaN(timeMinute)) {
                         logger_1.logger.warning(`weekly_schedule: expected 24h time notation (e.g. 19:30) but got '${elem.transitionTime}'!`, NS);
                     }
@@ -1421,7 +1419,7 @@ exports.thermostat_weekly_schedule = {
                     if (Number.isNaN(elem.transitionTime.minute)) {
                         throw new Error(`weekly_schedule: expected time.minute to be a number, but got '${elem.transitionTime.minute}'!`);
                     }
-                    elem.transitionTime = Number.parseInt(elem.transitionTime.hour) * 60 + Number.parseInt(elem.transitionTime.minute);
+                    elem.transitionTime = Number.parseInt(elem.transitionTime.hour, 10) * 60 + Number.parseInt(elem.transitionTime.minute, 10);
                 }
             }
         }
@@ -1431,18 +1429,17 @@ exports.thermostat_weekly_schedule = {
         }
         // map array of desired modes to bitmask
         let mode = 0;
-        for (let m of payload.mode) {
+        for (const m of modes) {
             // lookup mode bit
-            m = utils.getKey(constants.thermostatScheduleMode, m.toLowerCase(), m, Number);
-            mode |= 1 << m;
+            mode |= 1 << utils.getKey(constants.thermostatScheduleMode, m, 0, Number);
         }
-        payload.mode = mode;
         // map array of days to desired dayofweek bitmask
-        if (typeof payload.dayofweek === "string")
-            payload.dayofweek = [payload.dayofweek];
-        if (Array.isArray(payload.dayofweek)) {
-            let dayofweek = 0;
-            for (let d of payload.dayofweek) {
+        if (typeof daysofweek === "string") {
+            daysofweek = [daysofweek];
+        }
+        let dayofweek = 0;
+        if (Array.isArray(daysofweek)) {
+            for (let d of daysofweek) {
                 if (typeof d === "object") {
                     if (d.day == null) {
                         throw new Error(`weekly_schedule: expected dayofweek to be string or {"day": "str"}, but got '${JSON.stringify(d)}'!`);
@@ -1453,9 +1450,8 @@ exports.thermostat_weekly_schedule = {
                 d = utils.getKey(constants.thermostatDayOfWeek, d.toLowerCase(), d, Number);
                 dayofweek |= 1 << d;
             }
-            payload.dayofweek = dayofweek;
         }
-        await entity.command("hvacThermostat", "setWeeklySchedule", payload, utils.getOptions(meta.mapped, entity));
+        await entity.command("hvacThermostat", "setWeeklySchedule", { dayofweek, numoftrans, transitions, mode }, utils.getOptions(meta.mapped, entity));
     },
     convertGet: async (entity, key, meta) => {
         const payload = {
@@ -1551,8 +1547,7 @@ exports.thermostat_keypad_lockout = {
 exports.thermostat_temperature_setpoint_hold = {
     key: ["temperature_setpoint_hold"],
     convertSet: async (entity, key, value, meta) => {
-        const tempSetpointHold = value;
-        await entity.write("hvacThermostat", { tempSetpointHold });
+        await entity.write("hvacThermostat", { tempSetpointHold: value });
     },
     convertGet: async (entity, key, meta) => {
         await entity.read("hvacThermostat", ["tempSetpointHold"]);
@@ -1561,8 +1556,7 @@ exports.thermostat_temperature_setpoint_hold = {
 exports.thermostat_temperature_setpoint_hold_duration = {
     key: ["temperature_setpoint_hold_duration"],
     convertSet: async (entity, key, value, meta) => {
-        const tempSetpointHoldDuration = value;
-        await entity.write("hvacThermostat", { tempSetpointHoldDuration });
+        await entity.write("hvacThermostat", { tempSetpointHoldDuration: value });
     },
     convertGet: async (entity, key, meta) => {
         await entity.read("hvacThermostat", ["tempSetpointHoldDuration"]);
@@ -1584,7 +1578,7 @@ exports.fan_speed = {
     key: ["speed"],
     convertSet: async (entity, key, value, meta) => {
         utils.assertNumber(value);
-        await entity.command("genLevelCtrl", "moveToLevel", { level: value.toString(), transtime: 0 }, utils.getOptions(meta.mapped, entity));
+        await entity.command("genLevelCtrl", "moveToLevel", { level: value, transtime: 0 }, utils.getOptions(meta.mapped, entity));
         return { state: { speed: value } };
     },
     convertGet: async (entity, key, meta) => {
@@ -1980,7 +1974,7 @@ exports.humidity = {
 exports.elko_power_status = {
     key: ["system_mode"],
     convertSet: async (entity, key, value, meta) => {
-        await entity.write("hvacThermostat", { elkoPowerStatus: value === "heat" });
+        await entity.write("hvacThermostat", { elkoPowerStatus: value === "heat" ? 1 : 0 });
         return { state: { system_mode: value } };
     },
     convertGet: async (entity, key, meta) => {
@@ -2183,7 +2177,9 @@ exports.livolo_cover_state = {
             default:
                 throw new Error(`Value '${value}' is not a valid cover position (must be one of 'OPEN' or 'CLOSE')`);
         }
-        await entity.writeStructured("genPowerCfg", [payload], options);
+        await entity.writeStructured("genPowerCfg", 
+        // @ts-expect-error workaround write custom payload
+        [payload], options);
         return {
             state: {
                 moving: true,
@@ -2244,14 +2240,18 @@ exports.livolo_cover_options = {
                      (must be one of 'FORWARD' or 'REVERSE')`);
             }
             const payload = { 4865: { value: [direction, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] } };
-            await entity.write("genPowerCfg", payload, options);
+            await entity.write("genPowerCfg", 
+            // @ts-expect-error workaround write custom payload
+            payload, options);
         }
         if (value.motor_speed != null) {
             if (value.motor_speed < 20 || value.motor_speed > 40) {
                 throw new Error("livolo_cover_options: Motor speed is out of range (20-40)");
             }
             const payload = { 4609: { value: [value.motor_speed, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] } };
-            await entity.write("genPowerCfg", payload, options);
+            await entity.write("genPowerCfg", 
+            // @ts-expect-error workaround write custom payload
+            payload, options);
         }
     },
 };
@@ -2548,8 +2548,7 @@ exports.danfoss_adaptation_settings = {
 exports.danfoss_adaptation_control = {
     key: ["adaptation_run_control"],
     convertSet: async (entity, key, value, meta) => {
-        const payload = { danfossAdaptionRunControl: utils.getKey(constants.danfossAdaptionRunControl, value, value, Number) };
-        await entity.write("hvacThermostat", payload, manufacturerOptions.danfoss);
+        await entity.write("hvacThermostat", { danfossAdaptionRunControl: utils.getKey(constants.danfossAdaptionRunControl, value, value, Number) }, manufacturerOptions.danfoss);
         return { state: { adaptation_run_control: value } };
     },
     convertGet: async (entity, key, meta) => {
@@ -2559,8 +2558,7 @@ exports.danfoss_adaptation_control = {
 exports.danfoss_regulation_setpoint_offset = {
     key: ["regulation_setpoint_offset"],
     convertSet: async (entity, key, value, meta) => {
-        const payload = { danfossRegulationSetpointOffset: value };
-        await entity.write("hvacThermostat", payload, manufacturerOptions.danfoss);
+        await entity.write("hvacThermostat", { danfossRegulationSetpointOffset: value }, manufacturerOptions.danfoss);
         return { state: { regulation_setpoint_offset: value } };
     },
     convertGet: async (entity, key, meta) => {
@@ -2636,7 +2634,7 @@ exports.danfoss_system_status_code = {
 exports.danfoss_heat_supply_request = {
     key: ["heat_supply_request"],
     convertGet: async (entity, key, meta) => {
-        await entity.read("haDiagnostic", ["danfossHeatsupplyRequest"], manufacturerOptions.danfoss);
+        await entity.read("haDiagnostic", ["danfossHeatSupplyRequest"], manufacturerOptions.danfoss);
     },
 };
 exports.danfoss_system_status_water = {
@@ -2982,15 +2980,13 @@ exports.tuya_led_controller = {
             return { state: { state: value.toUpperCase() } };
         }
         if (key === "color") {
-            const hue = {};
-            const saturation = {};
             utils.assertObject(value);
-            hue.hue = utils.mapNumberRange(value.h, 0, 360, 0, 254);
-            saturation.saturation = utils.mapNumberRange(value.s, 0, 100, 0, 254);
-            hue.transtime = saturation.transtime = 0;
-            hue.direction = 0;
-            await entity.command("lightingColorCtrl", "moveToHue", hue, utils.getOptions(meta.mapped, entity));
-            await entity.command("lightingColorCtrl", "moveToSaturation", saturation, utils.getOptions(meta.mapped, entity));
+            const hue = utils.mapNumberRange(value.h, 0, 360, 0, 254);
+            const saturation = utils.mapNumberRange(value.s, 0, 100, 0, 254);
+            const transtime = 0;
+            const direction = 0;
+            await entity.command("lightingColorCtrl", "moveToHue", { hue, transtime, direction }, utils.getOptions(meta.mapped, entity));
+            await entity.command("lightingColorCtrl", "moveToSaturation", { saturation, transtime }, utils.getOptions(meta.mapped, entity));
         }
     },
     convertGet: async (entity, key, meta) => {
@@ -3244,14 +3240,14 @@ exports.ptvo_switch_uart = {
 exports.ptvo_switch_analog_input = {
     key: ["l1", "l2", "l3", "l4", "l5", "l6", "l7", "l8", "l9", "l10", "l11", "l12", "l13", "l14", "l15", "l16"],
     convertGet: async (entity, key, meta) => {
-        const epId = Number.parseInt(key.substr(1, 2));
+        const epId = Number.parseInt(key.substr(1, 2), 10);
         if (utils.hasEndpoints(meta.device, [epId])) {
             const endpoint = meta.device.getEndpoint(epId);
             await endpoint.read("genAnalogInput", ["presentValue", "description"]);
         }
     },
     convertSet: async (entity, key, value, meta) => {
-        const epId = Number.parseInt(key.substr(1, 2));
+        const epId = Number.parseInt(key.substr(1, 2), 10);
         if (utils.hasEndpoints(meta.device, [epId])) {
             const endpoint = meta.device.getEndpoint(epId);
             let cluster = "genLevelCtrl";
@@ -3561,16 +3557,16 @@ exports.diyruz_zintercom_config = {
     },
     convertGet: async (entity, key, meta) => {
         const payloads = {
-            mode: ["closuresDoorLock", 0x0051],
-            sound: ["closuresDoorLock", 0x0052],
-            time_ring: ["closuresDoorLock", 0x0053],
-            time_talk: ["closuresDoorLock", 0x0054],
-            time_open: ["closuresDoorLock", 0x0055],
-            time_bell: ["closuresDoorLock", 0x0057],
-            time_report: ["closuresDoorLock", 0x0056],
+            mode: 0x0051,
+            sound: 0x0052,
+            time_ring: 0x0053,
+            time_talk: 0x0054,
+            time_open: 0x0055,
+            time_bell: 0x0057,
+            time_report: 0x0056,
         };
         const v = utils.getFromLookup(key, payloads);
-        await entity.read(v[0], [v[1]]);
+        await entity.read("closuresDoorLock", [v]);
     },
 };
 exports.power_source = {
@@ -3664,13 +3660,11 @@ exports.scene_store = {
                     utils.saveSceneState(member, sceneid, groupid, meta.membersState[member.getDevice().ieeeAddr], scenename);
                 }
             }
-            // @ts-expect-error ignore
         }
         else if (response.status === 0) {
             utils.saveSceneState(entity, sceneid, groupid, meta.state, scenename);
         }
         else {
-            // @ts-expect-error ignore
             throw new Error(`Scene add not successful ('${zigbee_herdsman_1.Zcl.Status[response.status]}')`);
         }
         logger_1.logger.info("Successfully stored scene", NS);
@@ -3892,13 +3886,11 @@ exports.scene_remove = {
                     utils.deleteSceneState(member, sceneid, groupid);
                 }
             }
-            // @ts-expect-error ignore
         }
         else if (response.status === 0) {
             utils.deleteSceneState(entity, sceneid, groupid);
         }
         else {
-            // @ts-expect-error ignore
             throw new Error(`Scene remove not successful ('${zigbee_herdsman_1.Zcl.Status[response.status]}')`);
         }
         logger_1.logger.info("Successfully removed scene", NS);
@@ -4109,7 +4101,7 @@ exports.viessmann_window_open_force = {
     key: ["window_open_force"],
     convertSet: async (entity, key, value, meta) => {
         if (typeof value === "boolean") {
-            await entity.write("hvacThermostat", { viessmannWindowOpenForce: value }, manufacturerOptions.viessmann);
+            await entity.write("hvacThermostat", { viessmannWindowOpenForce: value ? 1 : 0 }, manufacturerOptions.viessmann);
             return { state: { window_open_force: value } };
         }
         logger_1.logger.error("window_open_force must be a boolean!", NS);
@@ -4128,11 +4120,9 @@ exports.dawondns_only_off = {
     key: ["state"],
     convertSet: async (entity, key, value, meta) => {
         utils.assertString(value, key);
-        // biome-ignore lint/style/noParameterAssign: ignored using `--suppress`
-        value = value.toLowerCase();
-        utils.assertString(value, key);
-        utils.validateValue(value, ["off"]);
-        await entity.command("genOnOff", value, {}, utils.getOptions(meta.mapped, entity));
+        const lowerValue = value.toLowerCase();
+        utils.validateValue(lowerValue, ["off"]);
+        await entity.command("genOnOff", lowerValue, {}, utils.getOptions(meta.mapped, entity));
     },
     convertGet: async (entity, key, meta) => {
         await entity.read("genOnOff", ["onOff"]);
@@ -4220,8 +4210,7 @@ exports.schneider_dimmer_mode = {
 exports.wiser_dimmer_mode = {
     key: ["dimmer_mode"],
     convertSet: async (entity, key, value, meta) => {
-        const controlMode = utils.getKey(constants.wiserDimmerControlMode, value, value, Number);
-        await entity.write("lightingBallastCfg", { wiserControlMode: controlMode }, { manufacturerCode: zigbee_herdsman_1.Zcl.ManufacturerCode.SCHNEIDER_ELECTRIC });
+        await entity.write("lightingBallastCfg", { wiserControlMode: utils.getKey(constants.wiserDimmerControlMode, value, value, Number) }, { manufacturerCode: zigbee_herdsman_1.Zcl.ManufacturerCode.SCHNEIDER_ELECTRIC });
         return { state: { dimmer_mode: value } };
     },
     convertGet: async (entity, key, meta) => {
@@ -4366,17 +4355,15 @@ exports.wiser_sed_thermostat_local_temperature_calibration = {
 exports.wiser_sed_thermostat_keypad_lockout = {
     key: ["keypad_lockout"],
     convertSet: async (entity, key, value, meta) => {
-        const keypadLockout = utils.getKey(constants.keypadLockoutMode, value, value, Number);
-        await entity.write("hvacUserInterfaceCfg", { keypadLockout }, { srcEndpoint: 11, disableDefaultResponse: true });
+        await entity.write("hvacUserInterfaceCfg", { keypadLockout: utils.getKey(constants.keypadLockoutMode, value, value, Number) }, { srcEndpoint: 11, disableDefaultResponse: true });
         return { state: { keypad_lockout: value } };
     },
 };
 exports.sihas_set_people = {
     key: ["people"],
     convertSet: async (entity, key, value, meta) => {
-        const payload = { presentValue: value };
         const endpoint = meta.device.endpoints.find((e) => e.supportsInputCluster("genAnalogInput"));
-        await endpoint.write("genAnalogInput", payload);
+        await endpoint.write("genAnalogInput", { presentValue: value });
     },
     convertGet: async (entity, key, meta) => {
         const endpoint = meta.device.endpoints.find((e) => e.supportsInputCluster("genAnalogInput"));